Aidan Saunders [Fri, 6 Jan 2023 10:48:14 +0000 (10:48 +0000)]
Fix `cv` failure on J3.
Seamus Lee [Wed, 11 Jan 2023 02:47:14 +0000 (13:47 +1100)]
Merge pull request #25316 from jofranz/5.57.0_security_quotes_typo
5.57.0 quotes typo: security 2x double quotes to 1x double quotes
Seamus Lee [Wed, 11 Jan 2023 02:46:35 +0000 (13:46 +1100)]
Merge pull request #25305 from totten/5.58-assetbuilder-2
AssetBuilder - Fix `testInvalid()` failure. Switch to JWT.
Jo Franz [Tue, 10 Jan 2023 22:27:07 +0000 (23:27 +0100)]
5.57.0 quotes typo: security 2x double quotes to 1x double quotes
Tim Otten [Tue, 10 Jan 2023 22:00:26 +0000 (14:00 -0800)]
Merge pull request #25285 from totten/master-sign-warning
Status Check - Raise severity of the check for signing keys
Tim Otten [Tue, 10 Jan 2023 01:07:57 +0000 (17:07 -0800)]
AssetBuilder - Define a fallback key (WEAK_SIGN) for sites that have not been configured
Tim Otten [Mon, 9 Jan 2023 22:45:49 +0000 (14:45 -0800)]
AssetBuilder - Switch to JWT
Eileen McNaughton [Mon, 9 Jan 2023 23:00:56 +0000 (12:00 +1300)]
Merge pull request #25300 from artfulrobot/artfulrobot-fix-null-line-item-label-crash
Fix Contributions listing crash due to getLineItemTitle returning null
Tim Otten [Thu, 5 Jan 2023 22:28:08 +0000 (14:28 -0800)]
Status Check - Raise severity of the check for signing keys. Tweak prose.
Rich Lott / Artful Robot [Mon, 9 Jan 2023 19:36:39 +0000 (19:36 +0000)]
Fix Contributions listing crash due to CRM_Financial_BAO_Order::getLineItemTitle
demeritcowboy [Fri, 6 Jan 2023 19:21:27 +0000 (14:21 -0500)]
Merge pull request #25289 from demeritcowboy/sk-update
searchkit - fix broken update task in dropdown
demeritcowboy [Fri, 6 Jan 2023 17:56:14 +0000 (12:56 -0500)]
fix broken update task
Tim Otten [Thu, 5 Jan 2023 05:57:00 +0000 (21:57 -0800)]
Set version to 5.58.beta1
Tim Otten [Thu, 5 Jan 2023 03:13:35 +0000 (19:13 -0800)]
Merge pull request #25281 from seamuslee001/move_help_test
Move newly added Help Test to Inline folder to match Core Folder stru…
Seamus Lee [Thu, 5 Jan 2023 00:52:58 +0000 (11:52 +1100)]
Move newly added Help Test to Inline folder to match Core Folder structure
Seamus Lee [Thu, 5 Jan 2023 00:45:13 +0000 (11:45 +1100)]
Merge pull request #25280 from civicrm/5.57
5.57
Tim Otten [Wed, 4 Jan 2023 02:32:08 +0000 (18:32 -0800)]
release-notes/5.57.0.md - Add security advisories
Tim Otten [Wed, 29 Jun 2022 05:06:05 +0000 (22:06 -0700)]
AssetBuilder - Validate checksum for requested parameters
Seamus Lee [Tue, 3 Jan 2023 01:54:11 +0000 (12:54 +1100)]
CiviEvent - Escape parameters in help text
Seamus Lee [Fri, 16 Dec 2022 00:55:57 +0000 (11:55 +1100)]
security/core#120 Use Rich's patch (ArtfulRobot) with minor variation to try to resolve the issue and add unit tests
Fix Regex and include test cases as per Rich's comments
Tim Otten [Thu, 5 Jan 2023 00:35:26 +0000 (16:35 -0800)]
Merge pull request #25170 from demeritcowboy/sortable
dev/core#4013 dev/core#4022 - Broken quicksearch options setting
demeritcowboy [Wed, 4 Jan 2023 22:34:17 +0000 (17:34 -0500)]
Merge pull request #25222 from eileenmcnaughton/cust_ed4
[REF] [merge custom fields] Only call function when applicable (well tested code)
Tim Otten [Wed, 4 Jan 2023 20:59:26 +0000 (12:59 -0800)]
Merge pull request #25278 from totten/5.57-rn
release-notes/5.57.0.md - Add recent update
Tim Otten [Wed, 4 Jan 2023 20:58:20 +0000 (12:58 -0800)]
release-notes/5.57.0.md - Add recent update
Eileen McNaughton [Wed, 4 Jan 2023 20:40:57 +0000 (09:40 +1300)]
Merge pull request #25276 from demeritcowboy/turk
[NFC] Restore locale properly after test
Eileen McNaughton [Mon, 26 Dec 2022 22:15:29 +0000 (11:15 +1300)]
Only call function when applicable
Big whitespace change as IF is moved
demeritcowboy [Wed, 4 Jan 2023 15:40:17 +0000 (10:40 -0500)]
Merge pull request #25245 from braders/php82_ical_dynamic_properties
[REF][PHP8.2] Avoid dynamic properties in CRM_Activity_BAO_ICalendar
Yashodha Chaku [Wed, 4 Jan 2023 06:51:47 +0000 (12:21 +0530)]
Merge pull request #25260 from eileenmcnaughton/prev_o
Remove Mar 2020 deprecated functions
demeritcowboy [Wed, 4 Jan 2023 03:08:54 +0000 (22:08 -0500)]
restore properly
Seamus Lee [Wed, 4 Jan 2023 00:31:16 +0000 (11:31 +1100)]
Merge pull request #25264 from eileenmcnaughton/leg_selector
Move legacy search selector file to legacy search extension
Seamus Lee [Wed, 4 Jan 2023 00:30:46 +0000 (11:30 +1100)]
Merge pull request #25275 from mlutfy/petitionMsgTypo
Petition ThankYou.tpl: fix strong typo
Mathieu Lutfy [Tue, 3 Jan 2023 21:47:17 +0000 (16:47 -0500)]
Petition ThankYou.tpl: fix strong typo
Eileen McNaughton [Tue, 3 Jan 2023 20:51:02 +0000 (09:51 +1300)]
Merge pull request #25274 from civicrm/5.57
5.57 to master
Eileen McNaughton [Tue, 3 Jan 2023 20:50:19 +0000 (09:50 +1300)]
Merge pull request #25273 from gellweiler/5.57
Add gellweiler to contributor-key.yml
Eileen McNaughton [Tue, 3 Jan 2023 20:49:42 +0000 (09:49 +1300)]
Merge pull request #25272 from eileenmcnaughton/557
dev/core#4049 Nested tags are not showing under some circumstances.
Sebastian Gellweiler [Tue, 3 Jan 2023 20:18:07 +0000 (21:18 +0100)]
Add gellweiler to contributor-key.yml
gellweiler [Sat, 24 Dec 2022 13:51:00 +0000 (14:51 +0100)]
Fix #4049
This commit fixes #4049: Nested tags are not showing under some circumstances.
Yashodha Chaku [Tue, 3 Jan 2023 04:47:23 +0000 (10:17 +0530)]
Merge pull request #25268 from eileenmcnaughton/is_separate
Remove unreachable code (since 2020)
Seamus Lee [Tue, 3 Jan 2023 00:54:42 +0000 (11:54 +1100)]
Merge pull request #25258 from eileenmcnaughton/search_test
NFC cleanup in test class
Seamus Lee [Tue, 3 Jan 2023 00:52:03 +0000 (11:52 +1100)]
Merge pull request #25269 from demeritcowboy/more-better-deleted
Better fix for is_deleted notice in 25261
Seamus Lee [Mon, 2 Jan 2023 22:08:16 +0000 (09:08 +1100)]
Merge pull request #25267 from eileenmcnaughton/no_input
Move part of deprecated function `loadRelatedObjects` to calling functions
demeritcowboy [Mon, 2 Jan 2023 22:07:04 +0000 (17:07 -0500)]
better fix for 25261
Eileen McNaughton [Mon, 2 Jan 2023 21:52:04 +0000 (10:52 +1300)]
Remove unreachable code (since 2020)
Seamus Lee [Mon, 2 Jan 2023 21:01:51 +0000 (08:01 +1100)]
Merge pull request #25253 from braders/api3-properties
[REF][PHP8.2] Avoid dynamic properties in civicrm_api3 class
Seamus Lee [Mon, 2 Jan 2023 21:01:17 +0000 (08:01 +1100)]
Merge pull request #25252 from braders/empty-param-annotations
Remove empty param declarations in docblocks
Eileen McNaughton [Mon, 2 Jan 2023 20:43:04 +0000 (09:43 +1300)]
Move part of deprecated function loadRelatedObjects to calling functions
Eileen McNaughton [Mon, 2 Jan 2023 20:07:54 +0000 (09:07 +1300)]
Merge pull request #25266 from braders/phpdoc-fixes3
PHPDoc corrections
Bradley Taylor [Sat, 31 Dec 2022 23:37:26 +0000 (23:37 +0000)]
Remove empty param declarations in docblocks
demeritcowboy [Mon, 2 Jan 2023 17:48:03 +0000 (12:48 -0500)]
Merge pull request #25265 from braders/tagelement-property-removal
(REF) Remove _tagElement dynamic property
demeritcowboy [Mon, 2 Jan 2023 17:31:30 +0000 (12:31 -0500)]
Merge pull request #25261 from eileenmcnaughton/notice
Smarty notice fix on contact search results
Bradley Taylor [Mon, 2 Jan 2023 16:52:10 +0000 (16:52 +0000)]
PHPDoc corrections
Bradley Taylor [Mon, 2 Jan 2023 16:18:47 +0000 (16:18 +0000)]
(REF) Remove _tagElement dynamic property
Matthew Wire [Mon, 2 Jan 2023 09:49:55 +0000 (09:49 +0000)]
Merge pull request #25238 from eileenmcnaughton/is_separate
Extract `getMembershipBlock`
Yashodha Chaku [Mon, 2 Jan 2023 07:52:10 +0000 (13:22 +0530)]
Merge pull request #25263 from eileenmcnaughton/by_ref
Remove unnecessary pass-by-ref
Eileen McNaughton [Mon, 2 Jan 2023 07:45:48 +0000 (20:45 +1300)]
Move legacy search selector file to legacy search extension
Eileen McNaughton [Mon, 2 Jan 2023 06:02:44 +0000 (19:02 +1300)]
Remove unnecessary pass-by-ref
Eileen McNaughton [Mon, 2 Jan 2023 04:34:14 +0000 (17:34 +1300)]
Smarty notice fix on contact search results
Eileen McNaughton [Mon, 2 Jan 2023 03:26:38 +0000 (16:26 +1300)]
Remove more deprecated functions
Eileen McNaughton [Mon, 2 Jan 2023 03:23:36 +0000 (16:23 +1300)]
Remove 2020 deprecated functions
demeritcowboy [Mon, 2 Jan 2023 01:57:50 +0000 (20:57 -0500)]
Merge pull request #25257 from eileenmcnaughton/unused
Remove unused variable
Eileen McNaughton [Mon, 2 Jan 2023 01:48:52 +0000 (14:48 +1300)]
Improve dataSet
It seems when writing this test I thought it was worth having more confusing code
in order to have a clearer failure message - I think that might have been more valid
when writing the test than it is now it rarely fails
Eileen McNaughton [Mon, 2 Jan 2023 01:05:02 +0000 (14:05 +1300)]
NFC cleanup in test class
Yashodha Chaku [Mon, 2 Jan 2023 01:45:09 +0000 (07:15 +0530)]
Merge pull request #25255 from eileenmcnaughton/test_simp
Simplify dataProvider in queryTest
Eileen McNaughton [Mon, 2 Jan 2023 00:16:48 +0000 (13:16 +1300)]
Remove unused variable
Eileen McNaughton [Mon, 2 Jan 2023 00:02:51 +0000 (13:02 +1300)]
Simplify dataProvider in queryTest
This data provider really is not doing much more than returning
an array - but it's adding confusing complexity and a maintenance
need (as can be seen by the fact it has been edited for php 8 compatibility
Bradley Taylor [Sun, 1 Jan 2023 15:09:54 +0000 (15:09 +0000)]
[REF][PHP8.2] Avoid dynamic properties in civicrm_api3 class
Eileen McNaughton [Sat, 31 Dec 2022 23:10:06 +0000 (12:10 +1300)]
Merge pull request #25246 from braders/payment-getbyclass-return-type
(NFC) Fix documented return type on getByClass method
Bradley Taylor [Sat, 31 Dec 2022 20:10:30 +0000 (20:10 +0000)]
(NFC) Fix documented return type on getByClass method
Bradley Taylor [Sat, 31 Dec 2022 16:48:21 +0000 (16:48 +0000)]
[REF][PHP8.2] Avoid dynamic properties in CRM_Activity_BAO_ICalendar
Eileen McNaughton [Fri, 30 Dec 2022 22:30:45 +0000 (11:30 +1300)]
Merge pull request #25243 from braders/php82_mailbox_dynamic_properties
[REF][PHP8.2] Avoid dynamic properties in mailstores
Eileen McNaughton [Fri, 30 Dec 2022 22:26:23 +0000 (11:26 +1300)]
Merge pull request #25244 from braders/php82_signer_dynamic_props
[REF][PHP8.2] Avoid dynamic properties in CRM_Utils_Signer
demeritcowboy [Fri, 30 Dec 2022 20:02:30 +0000 (15:02 -0500)]
Merge pull request #25221 from eileenmcnaughton/cust_ed3
[REF] [merge custom fields function] Stop returning unaltered cFields parameter (good unit test cover)
Bradley Taylor [Fri, 30 Dec 2022 19:56:44 +0000 (19:56 +0000)]
[REF][PHP8.2] Avoid dynamic properties in CRM_Utils_Signer
demeritcowboy [Fri, 30 Dec 2022 16:07:43 +0000 (11:07 -0500)]
Merge pull request #25242 from braders/var-docblock-type-order
(NFC) When using @var annotations, ensure type comes first
Bradley Taylor [Fri, 30 Dec 2022 13:51:21 +0000 (13:51 +0000)]
[REF][PHP8.2] Avoid dynamic properties in mailstores
Bradley Taylor [Fri, 30 Dec 2022 10:47:09 +0000 (10:47 +0000)]
When using @var annotations, ensure type comes first
Yashodha Chaku [Fri, 30 Dec 2022 04:13:47 +0000 (09:43 +0530)]
Merge pull request #25234 from braders/unused-line
[NFC] Remove line that does nothing
Yashodha Chaku [Fri, 30 Dec 2022 04:10:12 +0000 (09:40 +0530)]
Merge pull request #25240 from eileenmcnaughton/cancel
Remove legacy code payment processor handling
Eileen McNaughton [Fri, 30 Dec 2022 00:28:47 +0000 (13:28 +1300)]
Merge pull request #25236 from braders/shouldexitafterfatal-docblock
[NFC] Fix @method documentation for shouldExitAfterFatal
Eileen McNaughton [Fri, 30 Dec 2022 00:03:27 +0000 (13:03 +1300)]
Remove legacy code payment processor handling
Eileen McNaughton [Thu, 29 Dec 2022 23:31:08 +0000 (12:31 +1300)]
Extract getMembershipBlock
Eileen McNaughton [Thu, 29 Dec 2022 21:58:27 +0000 (10:58 +1300)]
Merge pull request #25231 from alifrumin/rn5.57
[NFC] first pass at 5.57 release notes
Bradley Taylor [Thu, 29 Dec 2022 21:54:20 +0000 (21:54 +0000)]
Fix @method documentation for shouldExitAfterFatal
Eileen McNaughton [Thu, 29 Dec 2022 21:44:29 +0000 (10:44 +1300)]
Merge pull request #25230 from braders/php8-customdatabytype
[REF] Fix strstr deprecation in CustomDataByType class
Eileen McNaughton [Thu, 29 Dec 2022 21:42:41 +0000 (10:42 +1300)]
Merge pull request #25233 from braders/remove-isHtml
Remove broken method CRM_Utils_File::isHtml()
Bradley Taylor [Thu, 29 Dec 2022 21:31:18 +0000 (21:31 +0000)]
Remove line that does nothing
Bradley Taylor [Thu, 29 Dec 2022 20:10:22 +0000 (20:10 +0000)]
Remove broken method CRM_Utils_File::isHtml()
Bradley Taylor [Wed, 28 Dec 2022 20:35:28 +0000 (20:35 +0000)]
Fix strstr deprecation in CustomDataByType class
Alice Frumin [Wed, 28 Dec 2022 03:24:38 +0000 (22:24 -0500)]
[NFC] first pass 5.57 release notes
Yashodha Chaku [Wed, 28 Dec 2022 09:56:42 +0000 (15:26 +0530)]
Merge pull request #25227 from eileenmcnaughton/dedupe_rule
Support DedupeRules as Managed entities
Eileen McNaughton [Wed, 28 Dec 2022 07:01:57 +0000 (20:01 +1300)]
Merge pull request #25228 from civicrm/5.57
5.57 to master
Eileen McNaughton [Wed, 28 Dec 2022 07:01:22 +0000 (20:01 +1300)]
Merge pull request #25225 from agh1/5.57.0-releasenotes-initial
5.57.0 release notes initial run
Eileen McNaughton [Wed, 28 Dec 2022 01:02:21 +0000 (14:02 +1300)]
Support DedupeRules as Managed entities
Andie Hunt [Tue, 27 Dec 2022 21:23:49 +0000 (16:23 -0500)]
5.57.0 release notes: added boilerplate
Andie Hunt [Tue, 27 Dec 2022 14:57:39 +0000 (09:57 -0500)]
5.57.0 release notes: raw from script
Yashodha Chaku [Tue, 27 Dec 2022 05:01:05 +0000 (10:31 +0530)]
Merge pull request #25223 from eileenmcnaughton/dep_opt
Remove deprecated ids from OptionValue::add
Eileen McNaughton [Tue, 27 Dec 2022 02:49:32 +0000 (15:49 +1300)]
Remove deprecated ids from OptionValue::add
Eileen McNaughton [Mon, 26 Dec 2022 22:09:36 +0000 (11:09 +1300)]
Stop returning unaltered cFields parameter
demeritcowboy [Fri, 23 Dec 2022 19:03:21 +0000 (14:03 -0500)]
Merge pull request #25217 from braders/profile-image-accept-types
Only allow valid image types to be uploaded to image_URL field on profiles
demeritcowboy [Fri, 23 Dec 2022 18:09:31 +0000 (13:09 -0500)]
Merge pull request #25216 from civicrm/5.57
5.57