Monish Deb [Wed, 16 Jan 2019 13:35:04 +0000 (19:05 +0530)]
dev/financial#39: Drop checkMD5 support from Authorize.net
Seamus Lee [Wed, 16 Jan 2019 05:17:40 +0000 (16:17 +1100)]
Merge pull request #13439 from jgillmanjr/paypal-standard-ipn-tz-fix
Convert Paypal Standard IPN payment_date to system's time zone
Monish Deb [Wed, 16 Jan 2019 04:29:38 +0000 (09:59 +0530)]
Merge pull request #13442 from eileenmcnaughton/paymen_line
Remove inappropriate exception handling.
Eileen McNaughton [Wed, 16 Jan 2019 01:48:18 +0000 (14:48 +1300)]
Merge pull request #13466 from colemanw/tsFix
Translate untranslated string
Eileen McNaughton [Tue, 15 Jan 2019 23:21:40 +0000 (12:21 +1300)]
Merge pull request #13458 from mattwire/unused_var_caseformcustomdata
REF Remove duplicate call to session singleton
colemanw [Tue, 15 Jan 2019 22:46:06 +0000 (17:46 -0500)]
Merge pull request #13453 from eileenmcnaughton/report_tpl
Escape the header title & section title in reports to better support extensions
colemanw [Tue, 15 Jan 2019 22:40:52 +0000 (17:40 -0500)]
Merge pull request #13465 from mlutfy/setLocale
setLocale: precaution for when setLocale is called on an unilingual site
Coleman Watts [Tue, 15 Jan 2019 22:30:33 +0000 (17:30 -0500)]
Translate untranslated string
Seamus Lee [Tue, 15 Jan 2019 19:52:18 +0000 (06:52 +1100)]
Merge pull request #13455 from eileenmcnaughton/payment_email_test
Add unit test for emailing receipts from additional payment page
Mathieu Lutfy [Tue, 15 Jan 2019 19:14:53 +0000 (14:14 -0500)]
setLocale: precaution for when setLocale is called on an unilingual site
Matthew Wire (MJW Consulting) [Tue, 15 Jan 2019 10:48:11 +0000 (10:48 +0000)]
Remove duplicate call to session singleton
eileen [Tue, 15 Jan 2019 05:44:19 +0000 (18:44 +1300)]
Add unit test for payment email from AdditionalPayment form, rationalise some parameters to do this.
Note that the goal is to move this function off this class to somewhere api accessible so breaking the connections
with the form makes sense & in fact some like the fromEmails handling are really just badly copied & pasted from elsewhere
(ie. the fromEmailIds doesn't exist & is created on the fly to house the email being passed in
Seamus Lee [Tue, 15 Jan 2019 03:16:03 +0000 (14:16 +1100)]
Merge pull request #13444 from eileenmcnaughton/payment_smarty
[REF] Replace ->assign with CRM_Core_Smarty::singleton()->assign in preparation for making function shareable
eileen [Tue, 15 Jan 2019 02:43:34 +0000 (15:43 +1300)]
Escape the header title & section title in reports.
In extended reports I'm making it possible for column titles to be user edited. since they will represent user input it
makes sense to escape on output. I think core makes sense as the place to do this as it is best practice
to escape all output in the smarty layer and I have tested that it still works fine
Eileen McNaughton [Mon, 14 Jan 2019 23:05:52 +0000 (12:05 +1300)]
Merge pull request #13450 from civicrm/5.10
5.10 to master
Eileen McNaughton [Mon, 14 Jan 2019 23:03:01 +0000 (12:03 +1300)]
Merge pull request #13448 from eileenmcnaughton/everyone_510
Fix unreleased regression on building GroupContact clause
Eileen McNaughton [Mon, 14 Jan 2019 23:01:43 +0000 (12:01 +1300)]
Merge pull request #13449 from colemanw/caseDateSearch
Fix broken case activity date filter
eileen [Mon, 14 Jan 2019 10:39:03 +0000 (23:39 +1300)]
Fix unreleased regression whereby acls are skipped for groups
Jason Gillman Jr [Mon, 14 Jan 2019 15:57:34 +0000 (10:57 -0500)]
Quick comment describing need for IPN TZ adjustment
Seamus Lee [Sat, 12 Jan 2019 22:41:43 +0000 (17:41 -0500)]
Utilize getTimeZoneString() method
Co-Authored-By: jgillmanjr <jason@rrfaae.com>
Jason Gillman Jr [Sat, 12 Jan 2019 05:40:14 +0000 (00:40 -0500)]
Convert Paypal Standard IPN payment_date to system's time zone
Coleman Watts [Mon, 14 Jan 2019 17:22:07 +0000 (12:22 -0500)]
Fix broken case activity date filter
colemanw [Mon, 14 Jan 2019 14:54:46 +0000 (09:54 -0500)]
Merge pull request #13438 from colemanw/timeIcon
Use icon for timepicker placeholder
eileen [Mon, 14 Jan 2019 09:04:45 +0000 (22:04 +1300)]
Add unit test to cover granting everyone' group permission to access a group
eileen [Sun, 13 Jan 2019 21:13:43 +0000 (10:13 +1300)]
Remove inappropriate exception handling.
Per discussion in https://github.com/civicrm/civicrm-core/commit/
570243c292fa7bceea74ce233feceb3f69211e54#r31805899
the core logic has been changed to now accept a payment regardless of contribution status. This reflects the
fact that a payment could be received for a fully paid contribution and we still need to record it.
This exception is inappropriately narrow (& likely in the wrong place since it should probably be closer to
where the decision is made about adding a payment rather than when it is being processed
Seamus Lee [Mon, 14 Jan 2019 07:28:21 +0000 (18:28 +1100)]
Merge pull request #13447 from eileenmcnaughton/dumb_stuff
[tidy-up] remove a couple of useless bits of code
Seamus Lee [Mon, 14 Jan 2019 06:09:26 +0000 (17:09 +1100)]
Merge pull request #13443 from eileenmcnaughton/move_payment
[REF] Create pseudo bao CRM_Financial_BAO_Payment & move create function to it
Eileen McNaughton [Mon, 14 Jan 2019 05:23:14 +0000 (18:23 +1300)]
Merge pull request #13446 from civicrm/5.10
5.10
eileen [Mon, 14 Jan 2019 05:22:49 +0000 (18:22 +1300)]
Remove verify_mandatory that does nothing due to nothing to verify
eileen [Mon, 14 Jan 2019 05:22:05 +0000 (18:22 +1300)]
Remove unused parameter
Seamus Lee [Mon, 14 Jan 2019 02:01:53 +0000 (13:01 +1100)]
Merge pull request #13445 from seamuslee001/dev-656
(dev/core#656) unreleased regression - attendee report generates unde…
yashodha [Thu, 10 Jan 2019 12:07:34 +0000 (17:37 +0530)]
(dev/core#656) unreleased regression - attendee report generates undefined property notice
eileen [Sun, 13 Jan 2019 22:59:15 +0000 (11:59 +1300)]
Replace ->assign with CRM_Core_Smarty::singleton()->assign in preparation for making function shareable
Per PR 1330 there is an intention to make this form receipting function a shared function. Part of making it sharable is making it static.
This is a preparatory refactor towards that end, getting rid of the 'this' in assigning variables to smarty
eileen [Sun, 13 Jan 2019 22:30:11 +0000 (11:30 +1300)]
Create pseudo bao CRM_Financial_BAO_Payment & move create function to it.
This is per discussions coming off https://github.com/civicrm/civicrm-core/pull/13330
Note that this ONLY moves the code - that PR does other things as well that still need to be worked through
Coleman Watts [Sat, 12 Jan 2019 01:04:56 +0000 (20:04 -0500)]
Use icon for timepicker placeholder
Seamus Lee [Fri, 11 Jan 2019 20:46:29 +0000 (07:46 +1100)]
Merge pull request #13412 from mattwire/extract_customData
REF Convert forms to standard customData template
Matthew Wire (MJW Consulting) [Fri, 11 Jan 2019 18:55:07 +0000 (18:55 +0000)]
Don't call getEntitySubTypeId if a subType is not defined
colemanw [Fri, 11 Jan 2019 16:10:20 +0000 (11:10 -0500)]
Merge pull request #13134 from agileware/CIVICRM-1006
dev/core#500 Fix user-specific Case filtering on dashboard and searches to exclude cases from inactive relationships
Yashodha Chaku [Fri, 11 Jan 2019 13:22:44 +0000 (18:52 +0530)]
Merge pull request #13433 from colemanw/actSub
Fix undefined index warning
colemanw [Fri, 11 Jan 2019 00:54:50 +0000 (19:54 -0500)]
Merge pull request #13377 from eileenmcnaughton/activity_extract2
Fix activity.getcount function to filter out unpermitted activities.
Seamus Lee [Thu, 10 Jan 2019 20:05:40 +0000 (07:05 +1100)]
Merge pull request #13409 from yashodha/dev-646
(dev/core#646) Event date sorting doesn't work for ical listing
Coleman Watts [Thu, 10 Jan 2019 17:05:23 +0000 (12:05 -0500)]
Fix undefined index warning
Seamus Lee [Thu, 10 Jan 2019 10:08:16 +0000 (21:08 +1100)]
Merge pull request #13430 from civicrm/5.10
5.10
Seamus Lee [Thu, 10 Jan 2019 10:03:41 +0000 (21:03 +1100)]
Merge pull request #13429 from seamuslee001/5.10
Port Test fixes to 5.10
Seamus Lee [Mon, 7 Jan 2019 21:17:13 +0000 (08:17 +1100)]
(NFC) Ensure that when loading in the test data it is done with UTF8 encoding
Seamus Lee [Mon, 7 Jan 2019 23:55:29 +0000 (10:55 +1100)]
(dev/core#647) Fix up Test Class names and file names to ensure all test classes are run by Jenkins
Seamus Lee [Tue, 8 Jan 2019 01:18:10 +0000 (12:18 +1100)]
(dev/core#647) Fix Up Contact Selector Test by changing class name to get test to run and make changes following code changes that affect clauses and calling get rows
CRM_Contact_SelectorTest - Fix escaping
(dev/core#217) CRM_Contact_SelectorTest - Remove stale/unnecessary assertion
The table `civicrm_prevnext_cache` includes three columns (`entity_id1`,
`entity_id2`, `entity_table`). These columns have some use-cases (e.g. for
deduping) and some historical value, but the only one needed for
caching search-results is `entity_id1`.
dev/core#217 introduced an interface `CRM_Core_PrevNextCache_Interface` for
caching search-results. This interface only passes through a list of CID's
(effectively `entity_id1`); because we don't need `entity_id2` and
`entity_table`, it makes no provisions for passing them through, and they're
not saved. This simplifies the interface and makes it more realistic to
implement alternative prevnext storage mechanisms.
colemanw [Thu, 10 Jan 2019 02:39:47 +0000 (21:39 -0500)]
Merge pull request #13211 from eileenmcnaughton/search_grant
dev/core#561 Convert grant search fields to use datepicker
colemanw [Thu, 10 Jan 2019 02:39:27 +0000 (21:39 -0500)]
Merge pull request #13395 from eileenmcnaughton/datepicker-update
Add routine for updating smartgroups, currently handling datepicker conversion
Seamus Lee [Wed, 9 Jan 2019 23:51:10 +0000 (10:51 +1100)]
Merge pull request #13426 from eileenmcnaughton/report_instance_domain
Add default for domain_id for report_instance.
Eileen McNaughton [Wed, 9 Jan 2019 19:55:33 +0000 (08:55 +1300)]
Merge pull request #13428 from mattwire/nfc_membership_function
REF Remove redundant function
Matthew Wire (MJW Consulting) [Wed, 9 Jan 2019 15:27:17 +0000 (15:27 +0000)]
Remove redundant function
Alok Patel [Wed, 9 Jan 2019 07:24:08 +0000 (12:54 +0530)]
CIVICRM-1128: Added Unit Tests to validate the Case counts when case role is active/inactive.
Eileen McNaughton [Wed, 9 Jan 2019 05:13:29 +0000 (18:13 +1300)]
Merge pull request #13416 from seamuslee001/647_selector_test
(dev/core#647) Fix Up Contact Selector Test by changing class name to…
eileen [Wed, 9 Jan 2019 05:11:35 +0000 (18:11 +1300)]
Add default for domain_id for report_instance.
This is consistent with other api like Job, MembershipType, PaymentProcessor
Mathieu Lu [Wed, 9 Jan 2019 00:02:35 +0000 (19:02 -0500)]
Merge pull request #13424 from seamuslee001/dev-drupal-43
dev/drupal#43 Update composer requirement on PSR Log and civicrm-cxn-…
Seamus Lee [Tue, 8 Jan 2019 01:18:10 +0000 (12:18 +1100)]
(dev/core#647) Fix Up Contact Selector Test by changing class name to get test to run and make changes following code changes that affect clauses and calling get rows
CRM_Contact_SelectorTest - Fix escaping
(dev/core#217) CRM_Contact_SelectorTest - Remove stale/unnecessary assertion
The table `civicrm_prevnext_cache` includes three columns (`entity_id1`,
`entity_id2`, `entity_table`). These columns have some use-cases (e.g. for
deduping) and some historical value, but the only one needed for
caching search-results is `entity_id1`.
dev/core#217 introduced an interface `CRM_Core_PrevNextCache_Interface` for
caching search-results. This interface only passes through a list of CID's
(effectively `entity_id1`); because we don't need `entity_id2` and
`entity_table`, it makes no provisions for passing them through, and they're
not saved. This simplifies the interface and makes it more realistic to
implement alternative prevnext storage mechanisms.
Eileen McNaughton [Tue, 8 Jan 2019 23:18:36 +0000 (12:18 +1300)]
Merge pull request #13419 from tschuettler/37-dev-mail
dev/mail#37 - Replace non-supported 4-byte unicode characters in bounce processing
Seamus Lee [Tue, 8 Jan 2019 20:38:21 +0000 (07:38 +1100)]
dev/mail#43 Update composer requirement on PSR Log and civicrm-cxn-rpc to fix compatability issue with psr/log from Drupal8
Seamus Lee [Tue, 8 Jan 2019 22:46:43 +0000 (09:46 +1100)]
Merge pull request #13422 from colemanw/dev/core#561
dev/core#561 - Convert campaign form date fields
Seamus Lee [Tue, 8 Jan 2019 20:31:18 +0000 (07:31 +1100)]
Merge pull request #13423 from colemanw/dev/core#561-followup
dev/core#561 - Convert activity followup form date field
Seamus Lee [Tue, 8 Jan 2019 20:21:46 +0000 (07:21 +1100)]
Merge pull request #13420 from yashodha/dev-649
(dev/core#649) DB error on Find Activities with follow up criteria
Coleman Watts [Tue, 8 Jan 2019 18:18:12 +0000 (13:18 -0500)]
dev/core#561 - Convert activity followup form date field
Coleman Watts [Tue, 8 Jan 2019 17:08:39 +0000 (12:08 -0500)]
dev/core#561 - Convert campaign form date fields
yashodha [Tue, 8 Jan 2019 14:34:15 +0000 (20:04 +0530)]
(dev/core#649) DB error on Find Activities with follow up criteria
colemanw [Tue, 8 Jan 2019 13:34:51 +0000 (08:34 -0500)]
Merge pull request #13394 from totten/master-srchcache
(dev/core#635) Reduce unnecessary SQL writes
Thomas Schüttler [Tue, 8 Jan 2019 12:55:50 +0000 (13:55 +0100)]
Replace 4-byte utf8 characters with unicode replacement character
Thomas Schüttler [Tue, 8 Jan 2019 12:38:07 +0000 (13:38 +0100)]
Add unit test for utf8mb4 unicode character
Seamus Lee [Tue, 8 Jan 2019 07:40:38 +0000 (18:40 +1100)]
Merge pull request #12923 from vinuvarshith/scheduled-reminders-error-fix
dev/core#434: Check If 'absolute_date' Is Used In 'prepareRepetitionEndFilter' To Prevent SQL Error
Seamus Lee [Tue, 8 Jan 2019 05:05:06 +0000 (16:05 +1100)]
Merge pull request #13415 from seamuslee001/nfc_test_file_fixes
(dev/core#647) Fix up Test Class names and file names to ensure all t…
Eileen McNaughton [Tue, 8 Jan 2019 02:33:18 +0000 (15:33 +1300)]
Merge pull request #13417 from civicrm/5.10
5.10
Seamus Lee [Tue, 8 Jan 2019 02:28:30 +0000 (13:28 +1100)]
Merge pull request #13414 from eileenmcnaughton/count
Fix php 7.2 countable warning
Seamus Lee [Mon, 7 Jan 2019 23:55:29 +0000 (10:55 +1100)]
(dev/core#647) Fix up Test Class names and file names to ensure all test classes are run by Jenkins
eileen [Mon, 7 Jan 2019 22:32:03 +0000 (11:32 +1300)]
Fix php 7.2 countable warning
per https://lab.civicrm.org/dev/core/issues/406#note_12393
Warning: count(): Parameter must be an array or an object that implements Countable in CRM_Event_Form_Participant->submit() (line 1722 of .../all/modules/civicrm/CRM/Event/Form/Participant.php).
Eileen McNaughton [Mon, 7 Jan 2019 22:52:26 +0000 (11:52 +1300)]
Merge pull request #13252 from jmcclelland/issue586
PCP report - fix number of donors and total committed.
Eileen McNaughton [Mon, 7 Jan 2019 22:51:44 +0000 (11:51 +1300)]
Merge pull request #13413 from seamuslee001/nfc_test_utf8
(NFC) Ensure that when loading in the test data it is done with UTF8 …
Matthew Wire (MJW Consulting) [Mon, 7 Jan 2019 17:55:53 +0000 (17:55 +0000)]
Convert Membership/Membership Renewal forms to standard customData template
Matthew Wire (MJW Consulting) [Mon, 7 Jan 2019 17:55:27 +0000 (17:55 +0000)]
Convert Grant form to standard customData template
Matthew Wire (MJW Consulting) [Mon, 7 Jan 2019 17:55:10 +0000 (17:55 +0000)]
Convert Manage Event Info form to standard customData template
Matthew Wire (MJW Consulting) [Mon, 7 Jan 2019 17:54:40 +0000 (17:54 +0000)]
Convert UpdateSubscription form to standard customData template
Matthew Wire (MJW Consulting) [Mon, 7 Jan 2019 17:54:22 +0000 (17:54 +0000)]
Convert contribution form to standard customData template
Matthew Wire (MJW Consulting) [Mon, 7 Jan 2019 17:53:14 +0000 (17:53 +0000)]
Convert activity form to standard customData template
Matthew Wire (MJW Consulting) [Mon, 7 Jan 2019 17:51:24 +0000 (17:51 +0000)]
Convert case/case activity forms to standard customData template
Matthew Wire (MJW Consulting) [Mon, 7 Jan 2019 17:50:09 +0000 (17:50 +0000)]
Convert Survey/Petition to standard customData template
Seamus Lee [Mon, 7 Jan 2019 21:17:13 +0000 (08:17 +1100)]
(NFC) Ensure that when loading in the test data it is done with UTF8 encoding
Jamie McClelland [Tue, 11 Dec 2018 21:40:58 +0000 (16:40 -0500)]
PCP report - fix number of donors and total committed.
ensure number of donors and committed are properly calculated in the PCP
report.
See: https://lab.civicrm.org/dev/core/issues/586
colemanw [Mon, 7 Jan 2019 19:43:20 +0000 (14:43 -0500)]
Merge pull request #13411 from mattwire/fix_buildCustomDataTwice
Membership custom fields sometimes don't display
Matthew Wire (MJW Consulting) [Mon, 7 Jan 2019 16:29:06 +0000 (16:29 +0000)]
Fix build custom data twice on edit forms
Monish Deb [Mon, 7 Jan 2019 12:28:43 +0000 (17:58 +0530)]
Merge pull request #13408 from seamuslee001/lab_core_644
(dev/core#644) Add in unit test showing backend able to handle user e…
yashodha [Mon, 7 Jan 2019 09:25:39 +0000 (14:55 +0530)]
(dev/core#646) Event date sorting doesn't work for ical listing
Monish Deb [Mon, 7 Jan 2019 07:27:41 +0000 (12:57 +0530)]
Merge pull request #13407 from MegaphoneJon/core-644
core#644 - extract function to return correct mailbox header
Seamus Lee [Mon, 7 Jan 2019 03:41:25 +0000 (14:41 +1100)]
(dev/core#644) Add in unit test showing backend able to handle user email address as from email sensibly
Seamus Lee [Mon, 7 Jan 2019 00:02:00 +0000 (11:02 +1100)]
Merge pull request #13393 from eileenmcnaughton/free
dev/core#562 remove calls to dao->free() from api folder
Eileen McNaughton [Sun, 6 Jan 2019 21:53:11 +0000 (10:53 +1300)]
Merge pull request #13402 from pradpnayak/ReportDelete
Donot show delete task option on create new report
Jon Goldberg [Sun, 6 Jan 2019 21:02:55 +0000 (16:02 -0500)]
rename function and vars; move fix to common mail sending function
Seamus Lee [Sun, 6 Jan 2019 19:31:56 +0000 (06:31 +1100)]
Merge pull request #13397 from pradpnayak/AddressCustomFieldFix
dev/core/issues/636 - Custom field for Address: The "No" value is not defaulted
Jon Goldberg [Sat, 5 Jan 2019 20:46:25 +0000 (15:46 -0500)]
core#644 - extract function to return correct mailbox header
Seamus Lee [Sat, 5 Jan 2019 20:30:29 +0000 (07:30 +1100)]
Merge pull request #13406 from eileenmcnaughton/api_getsingle
Fix bug where getsingle calls chained actions twice
Seamus Lee [Sat, 5 Jan 2019 20:23:31 +0000 (07:23 +1100)]
Merge pull request #13405 from davejenx/core-640-repeat-activity-permission
Don't require CiviEvent permission to create repeating activity
Eileen McNaughton [Sat, 5 Jan 2019 08:29:49 +0000 (21:29 +1300)]
Merge pull request #13318 from eileenmcnaughton/api_perm
Do not check financial permissions on contribution.create if check_perrmissions is FALSE.