Jitendra Purohit [Fri, 24 Jul 2020 13:59:26 +0000 (19:29 +0530)]
dev/core#1906 - Allow payment create api to record payment on Failed Contributions
Eileen McNaughton [Fri, 24 Jul 2020 00:05:22 +0000 (12:05 +1200)]
Merge pull request #17930 from twomice/1902_contrib_source_profile
dev/core#1902: "Contribution Source" profile field has no effect
Eileen McNaughton [Thu, 23 Jul 2020 23:01:53 +0000 (11:01 +1200)]
Merge pull request #17928 from colemanw/groupContactCleanup
[REF] GroupContact BAO - Minor code cleanup
Eileen McNaughton [Thu, 23 Jul 2020 22:45:30 +0000 (10:45 +1200)]
Merge pull request #17931 from civicrm/5.28
5.28 to master
Eileen McNaughton [Thu, 23 Jul 2020 22:42:12 +0000 (10:42 +1200)]
Merge pull request #17929 from demeritcowboy/required-not-5.28
dev/core#1903 - Avoid E_WARNING and remove code
Allen Shaw [Thu, 23 Jul 2020 22:19:39 +0000 (17:19 -0500)]
dev/core#1902: "Contribution Source" profile field has no effect on new contribution.
demeritcowboy [Thu, 23 Jul 2020 20:26:11 +0000 (16:26 -0400)]
avoid E_WARNING and remove code
Coleman Watts [Thu, 23 Jul 2020 16:23:11 +0000 (12:23 -0400)]
GroupContact BAO - Minor code cleanup
colemanw [Thu, 23 Jul 2020 16:18:26 +0000 (12:18 -0400)]
Merge pull request #17922 from eileenmcnaughton/group_contact
[REF] Minor function signuture cleanup
colemanw [Thu, 23 Jul 2020 13:05:41 +0000 (09:05 -0400)]
Merge pull request #17921 from eileenmcnaughton/format
[REF] Do not pass variable by reference
Eileen McNaughton [Thu, 23 Jul 2020 08:41:38 +0000 (20:41 +1200)]
Merge pull request #17926 from civicrm/5.28
5.28
eileen [Thu, 23 Jul 2020 04:06:23 +0000 (16:06 +1200)]
[REF] Minor function signuturre cleanup
is never altered so it is unnecessary to pass by reference. visibility is just
used to set ignorePermissions
Seamus Lee [Thu, 23 Jul 2020 06:44:09 +0000 (16:44 +1000)]
Merge pull request #17925 from seamuslee001/5.28
Add release-notes/5.27.3
Tim Otten [Thu, 23 Jul 2020 04:53:40 +0000 (21:53 -0700)]
Add release-notes/5.27.3
Eileen McNaughton [Thu, 23 Jul 2020 04:20:45 +0000 (16:20 +1200)]
Merge pull request #17918 from mlutfy/docUpdates
[NFC] Update a few doc/wiki links in code comments
eileen [Thu, 23 Jul 2020 03:52:55 +0000 (15:52 +1200)]
[REF] Do not pass variable by reference
This variable is not altered in the function so does not need to be passed by reference
Seamus Lee [Thu, 23 Jul 2020 02:43:35 +0000 (12:43 +1000)]
Merge pull request #17916 from colemanw/domainCache
Improve caching of current domain
Seamus Lee [Wed, 22 Jul 2020 21:49:10 +0000 (07:49 +1000)]
Merge pull request #17778 from totten/master-setup-validate
Setup UI - Validate that at least one "Component" is enabled
Seamus Lee [Wed, 22 Jul 2020 21:12:27 +0000 (07:12 +1000)]
Merge pull request #17911 from agh1/memberdetailreportautorenew
Member detail report: nest "in" options in parentheses
Mathieu Lutfy [Wed, 22 Jul 2020 20:14:49 +0000 (16:14 -0400)]
Update a few doc/wiki links in code comments
Coleman Watts [Wed, 22 Jul 2020 14:20:26 +0000 (10:20 -0400)]
APIv3 - If requesting current domain, read from cache
Coleman Watts [Thu, 18 Jun 2020 16:21:54 +0000 (12:21 -0400)]
Use sensible caching for current domain
colemanw [Wed, 22 Jul 2020 15:41:55 +0000 (11:41 -0400)]
Merge pull request #17917 from christianwach/lab-core-1901
Fix sticky table header on "Find Activities" page
Christian Wach [Wed, 22 Jul 2020 15:03:05 +0000 (16:03 +0100)]
Fix sticky table header on "Find Activities" page
Andrew Hunt [Wed, 22 Jul 2020 01:49:20 +0000 (21:49 -0400)]
Member detail report: nest "in" options in parentheses
Seamus Lee [Wed, 22 Jul 2020 00:26:56 +0000 (10:26 +1000)]
Merge pull request #17908 from civicrm/5.28
5.28
Seamus Lee [Wed, 22 Jul 2020 00:25:58 +0000 (10:25 +1000)]
Merge branch 'master' into 5.28
Seamus Lee [Wed, 22 Jul 2020 00:13:27 +0000 (10:13 +1000)]
Merge pull request #17906 from seamuslee001/lab_core_1846
dev/core#1846 Make DAO upgrade safe
Coleman Watts [Fri, 3 Jul 2020 16:20:04 +0000 (12:20 -0400)]
Fix failing settingTest and mark setting.fill as deprecated
The settingTest class was being too aggressive about creating and deleting domains,
this teaches it to not delete pre-existing domains.
Also marks an old unused api function deprecated.
Coleman Watts [Wed, 1 Jul 2020 17:25:31 +0000 (13:25 -0400)]
Add upgrade-safe DAO::getSupportedFields method
Switches api v3 and v4 to use that method so they are upgrade-safe by default.
Seamus Lee [Tue, 21 Jul 2020 22:23:45 +0000 (08:23 +1000)]
Merge pull request #17903 from eileenmcnaughton/format
[REF] remove unnecessary variable variables
Seamus Lee [Tue, 21 Jul 2020 22:12:08 +0000 (08:12 +1000)]
Merge pull request #17901 from demeritcowboy/outputhandler2
dev/core#1855 - Allow different output formats for CiviReport results and untangle code
Seamus Lee [Tue, 21 Jul 2020 22:07:17 +0000 (08:07 +1000)]
Merge pull request #17650 from colemanw/getMultilingual
[REF] - Add helper function for the repetitive task of fetching multilingual
Seamus Lee [Tue, 21 Jul 2020 20:31:44 +0000 (06:31 +1000)]
Merge pull request #17905 from MegaphoneJon/fix-dummy-processor
[unreleased regression] Dummy processor now is ID 7 on buildkit sites
Coleman Watts [Thu, 18 Jun 2020 16:21:54 +0000 (12:21 -0400)]
[REF] - Add helper function for the repetitive task of fetching multilingual
Adds the function CRM_Core_I18n::getMultilingual() and replaces a bunch of
places where the work was being done manually.
This also fixes a suspected bug where multiple domains may not have been compatible
with multiple languages, as the current domain id was previously ignored,
but is respected in the helper function.
Matthew Wire [Tue, 21 Jul 2020 18:46:36 +0000 (19:46 +0100)]
Merge pull request #17904 from christianwach/lab-core-1890
Remove unused "ufUniqID" session variable
Jon Goldberg [Tue, 21 Jul 2020 18:00:14 +0000 (14:00 -0400)]
Dummy processor now is ID 7 on buildkit sites
colemanw [Tue, 21 Jul 2020 14:45:00 +0000 (10:45 -0400)]
Merge pull request #17900 from aydun/wiki_changes
Replace a load of references to the wiki with docs links
Christian Wach [Tue, 21 Jul 2020 13:03:50 +0000 (14:03 +0100)]
Remove unused "ufUniqID" session variable
Aidan Saunders [Mon, 20 Jul 2020 21:07:30 +0000 (22:07 +0100)]
Replace a load of references to the wiki with docs links
Change docs links to 'latest' not 'stable'
Eileen McNaughton [Tue, 21 Jul 2020 05:21:25 +0000 (17:21 +1200)]
Merge pull request #17902 from demeritcowboy/test-activity-qill
dev/core#1894 - Make CRM_Activity_Form_SearchTest::testQill less time-sensitive
eileen [Tue, 21 Jul 2020 04:17:42 +0000 (16:17 +1200)]
[REF] remove unnecessary variable variables
For a brief but terrifying spell this arvo I delved into this function to try to understand
the purpose of 'preserveDBName'. Obviously I ran screaming from the room but I thought I could disarm these
few lines to slighly file down the fangs of the beast.
Code is heavily covered by tests
demeritcowboy [Tue, 21 Jul 2020 03:14:46 +0000 (23:14 -0400)]
make test less time-sensitive
demeritcowboy [Mon, 20 Jul 2020 01:09:55 +0000 (21:09 -0400)]
Allow extensions to provide their own formats and clean up tangled code
Seamus Lee [Mon, 20 Jul 2020 22:32:37 +0000 (08:32 +1000)]
Merge pull request #17827 from eileenmcnaughton/utf_import
dev/core#183 Use TempTable builder to generate table for import
Eileen McNaughton [Mon, 20 Jul 2020 22:14:06 +0000 (10:14 +1200)]
Merge pull request #17771 from mattwire/ufmatch_validemail
Remove check for valid email in synchronizeUFMatch
colemanw [Mon, 20 Jul 2020 21:34:00 +0000 (17:34 -0400)]
Merge pull request #17881 from eileenmcnaughton/activity
Call apiv4 from Contribution create rather than fugly addActivity function
Eileen McNaughton [Mon, 20 Jul 2020 21:30:55 +0000 (09:30 +1200)]
Merge pull request #17899 from colemanw/basicEntity
APIv4 - Add BasicEntity helper class
eileen [Sat, 18 Jul 2020 02:02:47 +0000 (14:02 +1200)]
Call apiv4 from Contribution create rather than fugly addActivity function
I took a look at https://github.com/civicrm/civicrm-core/pull/17274 which has blocking test failures - but felt that
the shared function was adding nothing and simply using the api to create the activity made more sense. The
shared function does a lot of silly wrangling for very little shared functionality and is
hard to read. In this call only 2 params are passed in - so most of the wranglingg
doesn't apply anyway. I ensured the 2 JIRA issues referenced in the removed code have test cover (one already
had a test written by Monish & I added in the campaign check
eileen [Tue, 14 Jul 2020 05:57:39 +0000 (17:57 +1200)]
dev/core#183 Fix import csv to use temp table builder
eileen [Tue, 14 Jul 2020 05:36:24 +0000 (17:36 +1200)]
Use TempTable builder to generate table for import
colemanw [Mon, 20 Jul 2020 18:45:47 +0000 (14:45 -0400)]
Merge pull request #17867 from MegaphoneJon/mailing-70
mailing#70 Don't create users for test mail if user doesn't have permission
Coleman Watts [Mon, 20 Jul 2020 18:30:35 +0000 (14:30 -0400)]
APIv4 - Add BasicEntity helper class
colemanw [Mon, 20 Jul 2020 14:43:32 +0000 (10:43 -0400)]
Merge pull request #17879 from colemanw/relCacheApi
Add APIv4 and pseudoconstants for RelationshipCache
Eileen McNaughton [Mon, 20 Jul 2020 07:11:33 +0000 (19:11 +1200)]
Merge pull request #17580 from samuelsov/dev/core#1670
dev/core#1670 copy custom fields from master to shared address
Seamus Lee [Mon, 20 Jul 2020 06:59:08 +0000 (16:59 +1000)]
Merge pull request #17560 from eileenmcnaughton/import
[Ref] Unit test attempt to create reported bugs , minor cleanup
Seamus Lee [Mon, 20 Jul 2020 05:14:13 +0000 (15:14 +1000)]
Merge pull request #17897 from seamuslee001/setver_new
Update version in the test_data_second_domain file and also update th…
Eileen McNaughton [Mon, 20 Jul 2020 03:50:42 +0000 (15:50 +1200)]
Merge pull request #17898 from demeritcowboy/smartgroupmarker
dev/core#1888 - Fix one line in PR 17888
Seamus Lee [Mon, 20 Jul 2020 01:42:23 +0000 (11:42 +1000)]
Update version in the test_data_second_domain file and also update the setVersion script to update the file version as necessary
Set setting indicating system has been installed after loading in the 2nd domain
demeritcowboy [Mon, 20 Jul 2020 02:44:07 +0000 (22:44 -0400)]
somehow messed up a line in revert
ba2ad46
eileen [Tue, 9 Jun 2020 07:50:02 +0000 (19:50 +1200)]
[Ref] Unit test attempt to create reported bugs , minor refactor
This lays the ground work to test a couple of reported bugs. Minor cleanup of code
colemanw [Mon, 20 Jul 2020 02:25:52 +0000 (22:25 -0400)]
Merge pull request #17896 from eileenmcnaughton/pdfletter
Be a little less supportive to cvs
Eileen McNaughton [Mon, 20 Jul 2020 02:16:17 +0000 (14:16 +1200)]
Merge pull request #17888 from demeritcowboy/groups-warnings
dev/core#1888 and dev/core#1885 - Fatal error on advanced search and warnings and missing group display on contact form
eileen [Mon, 20 Jul 2020 00:48:29 +0000 (12:48 +1200)]
Be a little less supportive to cvs
Eileen McNaughton [Mon, 20 Jul 2020 00:45:35 +0000 (12:45 +1200)]
Merge pull request #17808 from colemanw/bridge
APIv4 - Specify BridgeEntities to assist with joins
Eileen McNaughton [Mon, 20 Jul 2020 00:40:14 +0000 (12:40 +1200)]
Merge pull request #16736 from ixiam/dev_report_issue#27
Contribution Summary Report: Taking the currency filtered in the "gen…
Eileen McNaughton [Sun, 19 Jul 2020 23:08:33 +0000 (11:08 +1200)]
Merge pull request #17891 from mattwire/eventcartmenu
Event Cart ext: Move menu entries to extension
Eileen McNaughton [Sun, 19 Jul 2020 23:08:18 +0000 (11:08 +1200)]
Merge pull request #17895 from civicrm/5.28
5.28
Eileen McNaughton [Sun, 19 Jul 2020 22:13:54 +0000 (10:13 +1200)]
Merge pull request #17892 from demeritcowboy/tests-outputreport
[Test Framework] - Tests for report downloads
Seamus Lee [Sun, 19 Jul 2020 21:36:49 +0000 (07:36 +1000)]
Merge pull request #17890 from christianwach/lab-core-1889-3
Prevent session from starting during WordPress pseudo-cron procedures
colemanw [Sun, 19 Jul 2020 19:57:52 +0000 (15:57 -0400)]
Merge pull request #17866 from colemanw/customFix
dev/core#1578 - Fix APIv4 chaining with custom fields
demeritcowboy [Sun, 19 Jul 2020 13:38:46 +0000 (09:38 -0400)]
tests for report downloads
Matthew Wire [Sun, 19 Jul 2020 10:46:04 +0000 (11:46 +0100)]
Move menu definitions to eventcart extension
Seamus Lee [Sun, 19 Jul 2020 04:38:12 +0000 (14:38 +1000)]
Merge pull request #17882 from eileenmcnaughton/jaap
Unit test for #17361
colemanw [Sat, 18 Jul 2020 21:46:36 +0000 (17:46 -0400)]
Merge pull request #17885 from mattwire/eventcartext_forms
EventCart ext: Cleanup and move form components to ext
Seamus Lee [Sat, 18 Jul 2020 20:48:11 +0000 (06:48 +1000)]
Merge pull request #17884 from mattwire/eventcartext_meta
EventCart ext: Fix autogenerated code, remove unused hooks, update readme
Christian Wach [Sat, 18 Jul 2020 20:08:50 +0000 (21:08 +0100)]
Prevent session from starting during WordPress pseudo-cron procedures
Matthew Wire [Sat, 18 Jul 2020 17:32:25 +0000 (18:32 +0100)]
Merge pull request #17828 from eileenmcnaughton/matt
Load contribution page if live payment processor is disabled but test is available
colemanw [Sat, 18 Jul 2020 17:04:17 +0000 (13:04 -0400)]
Merge pull request #17887 from colemanw/searchDebug
Search debug
demeritcowboy [Sat, 18 Jul 2020 15:17:31 +0000 (11:17 -0400)]
revert PR 13958
Coleman Watts [Sat, 18 Jul 2020 13:09:03 +0000 (09:09 -0400)]
Search Ext: fix parseExpr field prefix
Coleman Watts [Sat, 18 Jul 2020 03:27:46 +0000 (23:27 -0400)]
Search Ext: Add api params to debug section
Matthew Wire [Sat, 18 Jul 2020 11:42:02 +0000 (12:42 +0100)]
Cleanup and move eventcart form components to ext
Matthew Wire [Sat, 18 Jul 2020 11:35:48 +0000 (12:35 +0100)]
Fix autogenerated code, remove unused hooks, update readme
Eileen McNaughton [Sat, 18 Jul 2020 09:07:01 +0000 (21:07 +1200)]
Merge pull request #17361 from jaapjansma/dev-1767
dev/core#1767 Fix phone key parsing in CRM_Dedupe_Finder
eileen [Sat, 18 Jul 2020 09:04:50 +0000 (21:04 +1200)]
Unit test for #17361
Seamus Lee [Sat, 18 Jul 2020 08:57:43 +0000 (18:57 +1000)]
Merge pull request #17880 from colemanw/headerComments
[NFC] Fix nonstandard header comments
Eileen McNaughton [Sat, 18 Jul 2020 03:03:03 +0000 (15:03 +1200)]
Merge pull request #17480 from tunbola/email-template-perms
dev/core#1751: [Create Email] Only Show Update/Save Template when User has Permission to Edit Templates
Coleman Watts [Sat, 18 Jul 2020 01:21:59 +0000 (21:21 -0400)]
Fix nonstandard header comments
Coleman Watts [Sat, 18 Jul 2020 00:33:42 +0000 (20:33 -0400)]
Add APIv4 and pseudoconstants for RelationshipCache
Seamus Lee [Fri, 17 Jul 2020 23:12:29 +0000 (09:12 +1000)]
Merge pull request #17874 from colemanw/checkPermShort
Use new checkPermissions shorthand in api calls
Eileen McNaughton [Fri, 17 Jul 2020 22:40:31 +0000 (10:40 +1200)]
Merge pull request #17878 from civicrm/5.28
5.28
Eileen McNaughton [Fri, 17 Jul 2020 22:17:39 +0000 (10:17 +1200)]
Merge pull request #17846 from mattwire/optimiseclearcaches
Simplify flushing group contact cache query to reduce table locking and improve performance
Seamus Lee [Fri, 17 Jul 2020 21:58:17 +0000 (07:58 +1000)]
Merge pull request #17806 from demeritcowboy/mail-report-csv-bom
dev/core#1869 - Include BOM in attachment when sending CSV CiviReport via mail_report job
Seamus Lee [Fri, 17 Jul 2020 21:55:29 +0000 (07:55 +1000)]
Merge pull request #17875 from colemanw/customFieldVersionCheck
Ensure serialize field exists before adding to query
Coleman Watts [Fri, 17 Jul 2020 16:16:35 +0000 (12:16 -0400)]
Ensure serialize field exists before adding to query
Mathieu Lu [Fri, 17 Jul 2020 15:54:47 +0000 (11:54 -0400)]
Merge pull request #16838 from mlutfy/core1280
dev/core#1280 Fix ContributionPage soft_credit translation
Coleman Watts [Fri, 17 Jul 2020 14:16:01 +0000 (10:16 -0400)]
Use new checkPermissions shorthand in api calls
colemanw [Fri, 17 Jul 2020 13:08:53 +0000 (09:08 -0400)]
Merge pull request #17872 from eileenmcnaughton/ids
[NFC] Comment block cleanup
Mathieu Lutfy [Wed, 18 Mar 2020 18:11:12 +0000 (14:11 -0400)]
dev/core#1280 Test for ContributionPage soft_credit translation