civicrm-core.git
3 years agoafHtmlEditor - Add descriptions. Add more missing fields.
Tim Otten [Tue, 1 Dec 2020 00:24:39 +0000 (16:24 -0800)]
afHtmlEditor - Add descriptions. Add more missing fields.

3 years agoafHtmlEditor - Use more BS3
Tim Otten [Wed, 25 Nov 2020 07:13:55 +0000 (23:13 -0800)]
afHtmlEditor - Use more BS3

3 years agoafGuiEditor - Allow editing `is_public`
Tim Otten [Wed, 25 Nov 2020 05:03:14 +0000 (21:03 -0800)]
afGuiEditor - Allow editing `is_public`

3 years agoafGuiEditor - Add help blocks. Reorder in anticipation of more fields.
Tim Otten [Wed, 25 Nov 2020 05:02:42 +0000 (21:02 -0800)]
afGuiEditor - Add help blocks. Reorder in anticipation of more fields.

3 years agoMerge pull request #19087 from civicrm/5.32
Eileen McNaughton [Tue, 1 Dec 2020 18:57:35 +0000 (07:57 +1300)]
Merge pull request #19087 from civicrm/5.32

5.32

3 years agoMerge pull request #19082 from compucorp/dev-core-1790-contact-card-delay
colemanw [Tue, 1 Dec 2020 14:58:46 +0000 (09:58 -0500)]
Merge pull request #19082 from compucorp/dev-core-1790-contact-card-delay

dev/core#1790: Add short delay before closing tooltip elements

3 years agoMerge pull request #19084 from eileenmcnaughton/prod
Seamus Lee [Tue, 1 Dec 2020 09:44:51 +0000 (20:44 +1100)]
Merge pull request #19084 from eileenmcnaughton/prod

dev/drupal#148 Fix product form such that it is possible to unseletc …

3 years agodev/drupal#148 Fix product form such that it is possible to unseletc duration unit...
eileen [Tue, 1 Dec 2020 03:42:42 +0000 (16:42 +1300)]
dev/drupal#148 Fix product form such that it is possible to unseletc duration unit, frequency unit

3 years agoMerge pull request #19078 from seamuslee001/emoiji_test_api3
Eileen McNaughton [Tue, 1 Dec 2020 02:49:47 +0000 (15:49 +1300)]
Merge pull request #19078 from seamuslee001/emoiji_test_api3

[NFC] Add in an Emoji test for APIv3 as per Eileen's PR

3 years agoMerge pull request #19075 from colemanw/searchable
Seamus Lee [Tue, 1 Dec 2020 01:13:52 +0000 (12:13 +1100)]
Merge pull request #19075 from colemanw/searchable

Improve schema metadata for Search Kit

3 years agodev/core#1790: Add short delay before closing tooltip elements
René Olivo [Tue, 1 Dec 2020 00:20:37 +0000 (00:20 +0000)]
dev/core#1790: Add short delay before closing tooltip elements

3 years agoMerge pull request #19081 from civicrm/5.32
Seamus Lee [Mon, 30 Nov 2020 23:44:53 +0000 (10:44 +1100)]
Merge pull request #19081 from civicrm/5.32

5.32

3 years agoMerge pull request #19077 from seamuslee001/dev_core_2213
Seamus Lee [Mon, 30 Nov 2020 23:44:24 +0000 (10:44 +1100)]
Merge pull request #19077 from seamuslee001/dev_core_2213

dev/core#2213 Protect against 404s when wpBasePage is mixed case

3 years agoMerge pull request #19080 from seamuslee001/master
Seamus Lee [Mon, 30 Nov 2020 23:35:52 +0000 (10:35 +1100)]
Merge pull request #19080 from seamuslee001/master

5.32

3 years agoMerge in 5.32
Seamus Lee [Mon, 30 Nov 2020 23:34:33 +0000 (10:34 +1100)]
Merge in 5.32

3 years agoMerge pull request #19076 from seamuslee001/update_cache_integration_tests
Seamus Lee [Mon, 30 Nov 2020 23:32:45 +0000 (10:32 +1100)]
Merge pull request #19076 from seamuslee001/update_cache_integration_tests

[NFC] Update Cache/integration-tests version as new version recently …

3 years ago[NFC] Add in an Emoji test for APIv3 as per Eileen's PR
Seamus Lee [Mon, 30 Nov 2020 23:23:26 +0000 (10:23 +1100)]
[NFC] Add in an Emoji test for APIv3 as per Eileen's PR

3 years agoMerge pull request #18918 from eileenmcnaughton/emoji
Seamus Lee [Mon, 30 Nov 2020 23:22:39 +0000 (10:22 +1100)]
Merge pull request #18918 from eileenmcnaughton/emoji

dev/core#2165 Test for Handle emojis less fatally where not supported

3 years agoAnnotate DAO files with COMPONENT, exclude disabled components' entities from APIv4...
Coleman Watts [Mon, 30 Nov 2020 20:10:46 +0000 (15:10 -0500)]
Annotate DAO files with COMPONENT, exclude disabled components' entities from APIv4 Entity::get

3 years agoMerge pull request #19044 from seamuslee001/dev_drupal_149
Seamus Lee [Mon, 30 Nov 2020 23:03:48 +0000 (10:03 +1100)]
Merge pull request #19044 from seamuslee001/dev_drupal_149

dev/drupal#149 Override sessionStart function for Drupal8 using appro…

3 years agodev/core#2213 Protect against 404s when wpBasePage is mixed case
Christian Wach [Fri, 27 Nov 2020 16:13:53 +0000 (16:13 +0000)]
dev/core#2213 Protect against 404s when wpBasePage is mixed case

3 years ago[NFC] Update Cache/integration-tests version as new version recently released that...
Seamus Lee [Mon, 30 Nov 2020 21:34:05 +0000 (08:34 +1100)]
[NFC] Update Cache/integration-tests version as new version recently released that contains the patches already applied

3 years agodev/core#2165 Test & fix for Handle emojis less fatally where not supported
eileen [Tue, 3 Nov 2020 22:07:37 +0000 (11:07 +1300)]
dev/core#2165 Test & fix for Handle emojis less fatally where not supported

Fix emoji handling by returning always-false when unwelcomely present

3 years agoAdd @searchable annotation to denote which API entities should be visible in Search...
Coleman Watts [Mon, 30 Nov 2020 19:23:53 +0000 (14:23 -0500)]
Add @searchable annotation to denote which API entities should be visible in Search Kit UI

3 years agoMerge pull request #19063 from christianwach/lab-core-2213
Eileen McNaughton [Mon, 30 Nov 2020 18:21:07 +0000 (07:21 +1300)]
Merge pull request #19063 from christianwach/lab-core-2213

Protect against 404s when wpBasePage is mixed case

3 years agoMerge pull request #19070 from mattwire/extensionupgrademsg
Eileen McNaughton [Mon, 30 Nov 2020 00:20:36 +0000 (13:20 +1300)]
Merge pull request #19070 from mattwire/extensionupgrademsg

Extract function that generates upgrade link for extensions

3 years agoExtract function that generates upgrade link for extensions
Matthew Wire [Sun, 29 Nov 2020 20:04:03 +0000 (20:04 +0000)]
Extract function that generates upgrade link for extensions

3 years agoMerge pull request #18612 from mattwire/tokenprocessorsimplify
Matthew Wire [Sun, 29 Nov 2020 15:30:37 +0000 (15:30 +0000)]
Merge pull request #18612 from mattwire/tokenprocessorsimplify

REF Simplify tokenProcessor code

3 years agoMerge pull request #19025 from sunilpawar/favourite_country
Eileen McNaughton [Sat, 28 Nov 2020 22:46:48 +0000 (11:46 +1300)]
Merge pull request #19025 from sunilpawar/favourite_country

Feature to provide mostly used countries in top section of Country select list

3 years agoSimplify tokenProcessor code for activities
Matthew Wire [Sat, 26 Sep 2020 17:55:38 +0000 (18:55 +0100)]
Simplify tokenProcessor code for activities

3 years agoMerge pull request #19065 from colemanw/campaignTabs
Matthew Wire [Sat, 28 Nov 2020 18:31:14 +0000 (18:31 +0000)]
Merge pull request #19065 from colemanw/campaignTabs

Minor tabs cleanup toward fixing dev/core#2215

3 years agoMinor tabs cleanup
Coleman Watts [Sat, 28 Nov 2020 00:30:32 +0000 (19:30 -0500)]
Minor tabs cleanup

1. Avoid overwriting CRM.tabSettings.active by cloning the variable rather than copying by reference
2. Initialize tabs only once on the Campaign dashboard

3 years agoMerge pull request #19059 from eileenmcnaughton/2199_ufgroup_pre_post_hook
colemanw [Fri, 27 Nov 2020 16:30:10 +0000 (11:30 -0500)]
Merge pull request #19059 from eileenmcnaughton/2199_ufgroup_pre_post_hook

Remove use of nullArray in delete hooks

3 years agoProtect against 404s when wpBasePage is mixed case
Christian Wach [Fri, 27 Nov 2020 16:13:53 +0000 (16:13 +0000)]
Protect against 404s when wpBasePage is mixed case

3 years agoMerge pull request #19060 from eileenmcnaughton/ufadd
colemanw [Fri, 27 Nov 2020 15:45:38 +0000 (10:45 -0500)]
Merge pull request #19060 from eileenmcnaughton/ufadd

Deprecate UFGroup::add parameter ids

3 years agoadded test case, ts for help text in setting file, changed static variable logic
Sunil Pawar [Fri, 27 Nov 2020 08:08:39 +0000 (13:38 +0530)]
added test case, ts for help text in setting file, changed static variable logic

3 years agoDeprecate UFGroup::add parameter ids
eileen [Fri, 27 Nov 2020 07:16:32 +0000 (20:16 +1300)]
Deprecate UFGroup::add parameter ids

This is only passed in from one place. This PR removes it & adds noisy deprecation

3 years agoRemove use of nullArray in delete hooks
eileen [Fri, 27 Nov 2020 07:05:06 +0000 (20:05 +1300)]
Remove use of nullArray in delete hooks

Looking at #18995 I was struck by the delete hook being non-standard. In general we don't load from the DB just to pass
to the hook as the hook can do that itself. However, when I looked at other hooks
I found that they were passing out nullArray - this is a legacy method that precedes
being on a php version that supported default params when passing by reference.

It's further known to introduce intermittent hard to debug issues. This adds the new hook
and also adds standardisation to the other hooks for pre+delete.

I've left the create one for now but GroupContact is a good example of something
close to what we want to standardise on there

3 years agodev/drupal#149 Override sessionStart function for Drupal8 using appropriate session...
Seamus Lee [Wed, 25 Nov 2020 09:53:06 +0000 (20:53 +1100)]
dev/drupal#149 Override sessionStart function for Drupal8 using appropriate session functions

Use Drupal Session service and don't worry about calling migrate

3 years agoMerge pull request #19050 from eileenmcnaughton/pp
Seamus Lee [Fri, 27 Nov 2020 01:37:05 +0000 (12:37 +1100)]
Merge pull request #19050 from eileenmcnaughton/pp

[REF] Remove excess handling around contact_id

3 years agoMerge pull request #19051 from eileenmcnaughton/pps
Seamus Lee [Fri, 27 Nov 2020 01:32:53 +0000 (12:32 +1100)]
Merge pull request #19051 from eileenmcnaughton/pps

Remove extra handling around contact id

3 years agoMerge pull request #18916 from colemanw/crudLink
Eileen McNaughton [Fri, 27 Nov 2020 00:50:40 +0000 (13:50 +1300)]
Merge pull request #18916 from colemanw/crudLink

Remove unused hook_civicrm_crudLink and switch to using metadata for crudLinks

3 years agoMerge pull request #19052 from colemanw/angModuleCleanup
Eileen McNaughton [Thu, 26 Nov 2020 21:53:44 +0000 (10:53 +1300)]
Merge pull request #19052 from colemanw/angModuleCleanup

[REF] Cleanup Ang modules in core to follow conventions

3 years agoMerge pull request #19058 from mattwire/pcpshortcodeaction
Seamus Lee [Thu, 26 Nov 2020 21:29:23 +0000 (08:29 +1100)]
Merge pull request #19058 from mattwire/pcpshortcodeaction

wordpress#63 Add action parameter to PCP shortcode

3 years agoMerge pull request #19046 from dwoods-encircle/Resource-URL-helptext-update
colemanw [Thu, 26 Nov 2020 16:42:25 +0000 (11:42 -0500)]
Merge pull request #19046 from dwoods-encircle/Resource-URL-helptext-update

Update Resource URL Helptext

3 years agosmall change
Sunil Pawar [Thu, 26 Nov 2020 13:22:57 +0000 (18:52 +0530)]
small change

3 years agochanged lable and field name from favourite to Pinned
Sunil Pawar [Thu, 26 Nov 2020 13:20:43 +0000 (18:50 +0530)]
changed lable and field name from favourite to Pinned

3 years agowordpress#63 Add action parameter to PCP shortcode
Matthew Wire [Thu, 26 Nov 2020 11:18:21 +0000 (11:18 +0000)]
wordpress#63 Add action parameter to PCP shortcode

3 years agoMerge pull request #19056 from civicrm/5.32
Seamus Lee [Thu, 26 Nov 2020 08:36:51 +0000 (19:36 +1100)]
Merge pull request #19056 from civicrm/5.32

5.32

3 years agoMerge pull request #19055 from colemanw/fixSearchActionButton
Seamus Lee [Thu, 26 Nov 2020 05:14:25 +0000 (16:14 +1100)]
Merge pull request #19055 from colemanw/fixSearchActionButton

Search ext: Fix search action button

3 years agoSearch ext: Fix search action button
Coleman Watts [Thu, 26 Nov 2020 02:47:30 +0000 (21:47 -0500)]
Search ext: Fix search action button

3 years agoRemove extra handling around contact id
eileen [Wed, 25 Nov 2020 19:04:34 +0000 (08:04 +1300)]
Remove extra handling around contact id

It's retrieved a few rows earlier from the contribution - this is from formerly
shared code that does not apply here

3 years ago[REF] Remove excess handling around contact_id
eileen [Wed, 25 Nov 2020 19:00:01 +0000 (08:00 +1300)]
[REF] Remove excess handling around contact_id

The removed code was formerly in a shared function. On looking the
getIDS actually just gets the contact id from the contributionRecur
object & every thing else is extraneous

3 years agoMerge pull request #19049 from colemanw/crmExampleGone
Eileen McNaughton [Thu, 26 Nov 2020 02:08:08 +0000 (15:08 +1300)]
Merge pull request #19049 from colemanw/crmExampleGone

Delete outdated/unused crmExample Angular module

3 years agoMerge pull request #19047 from colemanw/crmD3
Seamus Lee [Thu, 26 Nov 2020 00:30:32 +0000 (11:30 +1100)]
Merge pull request #19047 from colemanw/crmD3

[REF] Decouple crmD3 angular module from CiviMail

3 years agoMerge pull request #19045 from seamuslee001/remove_xss_function
Seamus Lee [Thu, 26 Nov 2020 00:25:35 +0000 (11:25 +1100)]
Merge pull request #19045 from seamuslee001/remove_xss_function

[REF] Remove xssString as it is providing a false sense of security

3 years agoFix crmStatusPage file name to match module name per convention
Coleman Watts [Wed, 25 Nov 2020 19:07:24 +0000 (14:07 -0500)]
Fix crmStatusPage file name to match module name per convention

3 years agoUse settingsFactory intead of settings for angular modules.
Coleman Watts [Wed, 25 Nov 2020 18:53:43 +0000 (13:53 -0500)]
Use settingsFactory intead of settings for angular modules.

We are moving toward the use of settingsFactory and away from settings for angular modules.
This would allow the list of modules to be cached as it would only contain static metadata.

3 years agoMerge pull request #19048 from colemanw/angComment
colemanw [Wed, 25 Nov 2020 23:19:36 +0000 (18:19 -0500)]
Merge pull request #19048 from colemanw/angComment

[NFC] Remove boilerplate comment from .ang.php files

3 years agoMerge pull request #19054 from eileenmcnaughton/pp1
Seamus Lee [Wed, 25 Nov 2020 22:56:18 +0000 (09:56 +1100)]
Merge pull request #19054 from eileenmcnaughton/pp1

[REF] Simplify sendNotification determination

3 years agoRemove boilerplate comment from .ang.php files
Coleman Watts [Wed, 25 Nov 2020 15:33:27 +0000 (10:33 -0500)]
Remove boilerplate comment from .ang.php files

Link to wiki was outdated and comment was not very helpful

3 years ago[REF] Simplify sendNotification determination
eileen [Wed, 25 Nov 2020 19:20:24 +0000 (08:20 +1300)]
[REF] Simplify sendNotification determination

3 years agoDelete outdated/unused crmExample Angular module
Coleman Watts [Wed, 25 Nov 2020 15:46:13 +0000 (10:46 -0500)]
Delete outdated/unused crmExample Angular module

3 years agoDecouple crmD3 angular module from CiviMail
Coleman Watts [Wed, 25 Nov 2020 15:13:32 +0000 (10:13 -0500)]
Decouple crmD3 angular module from CiviMail

The crmD3 module was being conditionally loaded based on whether CiviMail was enabled.
This changes it to always exist but only loaded as required.

3 years agoUpdate Resource URL Helptext
Darren Woods [Wed, 25 Nov 2020 11:46:11 +0000 (11:46 +0000)]
Update Resource URL Helptext

3 years ago[REF] Remove xssString as it is providing a false sense of security
Seamus Lee [Wed, 25 Nov 2020 10:02:27 +0000 (21:02 +1100)]
[REF] Remove xssString as it is providing a false sense of security

3 years agoMerge pull request #19043 from eileenmcnaughton/pp
Seamus Lee [Wed, 25 Nov 2020 09:48:57 +0000 (20:48 +1100)]
Merge pull request #19043 from eileenmcnaughton/pp

dev/financial#148 fully deprecate validateData function

3 years agoMerge pull request #19042 from eileenmcnaughton/pps
Seamus Lee [Wed, 25 Nov 2020 09:48:41 +0000 (20:48 +1100)]
Merge pull request #19042 from eileenmcnaughton/pps

Remove legacy check

3 years agoMerge pull request #19005 from totten/master-afform-dashlet
Tim Otten [Wed, 25 Nov 2020 04:57:59 +0000 (20:57 -0800)]
Merge pull request #19005 from totten/master-afform-dashlet

Afform - Generate dashlets based on `Afform.is_dashlet` property.

3 years agodev/financial#148 fully deprecate validateData function
eileen [Wed, 25 Nov 2020 03:08:58 +0000 (16:08 +1300)]
dev/financial#148 fully deprecate validateData function

3 years agoRemove legacy check
eileen [Tue, 24 Nov 2020 22:42:51 +0000 (11:42 +1300)]
Remove legacy check

This check dates right back to when we started extracting IPN code from code blocks in the processor. I don't believe it's meaningful

3 years agoMerge pull request #19040 from eileenmcnaughton/pp2
colemanw [Wed, 25 Nov 2020 01:16:57 +0000 (20:16 -0500)]
Merge pull request #19040 from eileenmcnaughton/pp2

[REF] remove obscure use of objects from A.net

3 years agoafform - Interpret the 'is_dashlet' property and auto-(de)register a `Dashboard`...
Tim Otten [Fri, 20 Nov 2020 04:44:03 +0000 (20:44 -0800)]
afform - Interpret the 'is_dashlet' property and auto-(de)register a `Dashboard` element

3 years agoMerge pull request #19006 from colemanw/bsCheckbox
colemanw [Wed, 25 Nov 2020 00:03:44 +0000 (19:03 -0500)]
Merge pull request #19006 from colemanw/bsCheckbox

Improve bootstrap3 checkbox theming

3 years agoMerge pull request #19041 from eileenmcnaughton/ppp
Eileen McNaughton [Tue, 24 Nov 2020 23:48:05 +0000 (12:48 +1300)]
Merge pull request #19041 from eileenmcnaughton/ppp

[REF] Stop passing objects to recur in paypal pro - pass specific objects

3 years ago[REF] Remove obscure objects from A.net
eileen [Tue, 24 Nov 2020 22:38:51 +0000 (11:38 +1300)]
[REF] Remove obscure objects from A.net

3 years agoMerge pull request #19039 from eileenmcnaughton/pp
Eileen McNaughton [Tue, 24 Nov 2020 22:33:13 +0000 (11:33 +1300)]
Merge pull request #19039 from eileenmcnaughton/pp

[REF] remove obscure use of objects from Anet.ipn

3 years agoStop passing objects to recur - pass specific objects
eileen [Tue, 24 Nov 2020 21:26:41 +0000 (10:26 +1300)]
Stop passing objects to recur - pass specific objects

3 years ago[REF] remove obscure use of objects from Anet.ipn
eileen [Tue, 24 Nov 2020 19:29:34 +0000 (08:29 +1300)]
[REF] remove obscure use of objects from Anet.ipn

3 years agoMerge pull request #19038 from eileenmcnaughton/coleman_cheer
colemanw [Tue, 24 Nov 2020 14:26:07 +0000 (09:26 -0500)]
Merge pull request #19038 from eileenmcnaughton/coleman_cheer

[REF] Remove code Coleman hates

3 years agoafGuiEditor - Expose the `is_dashlet' property
Tim Otten [Fri, 20 Nov 2020 04:43:32 +0000 (20:43 -0800)]
afGuiEditor - Expose the `is_dashlet' property

3 years ago(REF) afGuiEditor - Add form-* elements to 'config-form.html'
Tim Otten [Fri, 20 Nov 2020 04:40:45 +0000 (20:40 -0800)]
(REF) afGuiEditor - Add form-* elements to 'config-form.html'

This should bring the markup closer to Bootstrap3 convention.

3 years agoafform/core - Add property 'is_dashlet'
Tim Otten [Fri, 20 Nov 2020 00:28:53 +0000 (16:28 -0800)]
afform/core - Add property 'is_dashlet'

3 years agoafform/mock - Update phpunix.xml.dist for phpunit7
Tim Otten [Fri, 20 Nov 2020 00:02:20 +0000 (16:02 -0800)]
afform/mock - Update phpunix.xml.dist for phpunit7

3 years agoMerge pull request #19037 from eileenmcnaughton/dep
Eileen McNaughton [Tue, 24 Nov 2020 07:25:50 +0000 (20:25 +1300)]
Merge pull request #19037 from eileenmcnaughton/dep

Remove some deprecated code

3 years agoMerge pull request #19032 from eileenmcnaughton/obj
Seamus Lee [Tue, 24 Nov 2020 06:32:29 +0000 (17:32 +1100)]
Merge pull request #19032 from eileenmcnaughton/obj

[REF] Simplify single function to receive contribution not objects

3 years agoMerge pull request #19033 from eileenmcnaughton/obj2
Seamus Lee [Tue, 24 Nov 2020 06:31:06 +0000 (17:31 +1100)]
Merge pull request #19033 from eileenmcnaughton/obj2

dev/financial#148 fold call to loadObjects

3 years agoMerge pull request #19035 from eileenmcnaughton/obj4
Seamus Lee [Tue, 24 Nov 2020 06:30:29 +0000 (17:30 +1100)]
Merge pull request #19035 from eileenmcnaughton/obj4

dev/financial#148 fold call to loadObjects - a.net

3 years agoMerge pull request #19034 from eileenmcnaughton/obj3
Seamus Lee [Tue, 24 Nov 2020 06:30:14 +0000 (17:30 +1100)]
Merge pull request #19034 from eileenmcnaughton/obj3

dev/financial#148 duplicate out call to validateObjects

3 years ago[REF] Remove code Coleman hates
eileen [Tue, 24 Nov 2020 03:30:44 +0000 (16:30 +1300)]
[REF] Remove code Coleman hates

3 years agoRemove some deprecated code
eileen [Tue, 24 Nov 2020 03:18:09 +0000 (16:18 +1300)]
Remove some deprecated code

This was deprecated over a year ago just in case anyone was passing in the legacy param - fully removing now

3 years agoMerge pull request #19036 from civicrm/5.32
Eileen McNaughton [Tue, 24 Nov 2020 02:21:28 +0000 (15:21 +1300)]
Merge pull request #19036 from civicrm/5.32

5.32 to master

3 years agoMerge pull request #19031 from colemanw/bullets
Eileen McNaughton [Tue, 24 Nov 2020 02:20:48 +0000 (15:20 +1300)]
Merge pull request #19031 from colemanw/bullets

Improve options in list search display

3 years agoImprove bootstrap3 checkbox theming
Coleman Watts [Fri, 20 Nov 2020 20:32:36 +0000 (15:32 -0500)]
Improve bootstrap3 checkbox theming

Standardizes our styling of checkboxes in boostrap markup to:
`<label class="form-control"><input type="checkbox"> <span>Title</span></label>`

3 years agoMerge pull request #19030 from civicrm/5.32
Eileen McNaughton [Tue, 24 Nov 2020 01:14:20 +0000 (14:14 +1300)]
Merge pull request #19030 from civicrm/5.32

5.32

3 years agoMerge pull request #19027 from mlutfy/fixEvent30
Eileen McNaughton [Tue, 24 Nov 2020 01:13:22 +0000 (14:13 +1300)]
Merge pull request #19027 from mlutfy/fixEvent30

Event Full: fix translation regression

3 years agodev/financial#148 fold call to loadObjects
eileen [Tue, 24 Nov 2020 01:04:34 +0000 (14:04 +1300)]
dev/financial#148 fold call to loadObjects

3 years agodev/financial#148 duplicate out call to validateObjects
eileen [Tue, 24 Nov 2020 00:58:52 +0000 (13:58 +1300)]
dev/financial#148 duplicate out call to validateObjects

3 years agodev/financial#148 fold call to loadObjects
eileen [Tue, 24 Nov 2020 00:49:51 +0000 (13:49 +1300)]
dev/financial#148 fold call to loadObjects

3 years agoSimplify single function to receive contribution not objects
eileen [Tue, 24 Nov 2020 00:40:36 +0000 (13:40 +1300)]
Simplify single function to receive contribution not objects

Contribution is now the only object used in this function - so it should be the only one passed in