civicrm-core.git
2 years ago(NFC) Update stale comments
Tim Otten [Thu, 2 Jun 2022 06:43:34 +0000 (23:43 -0700)]
(NFC) Update stale comments

2 years agoCivi::queue(...$queueSpec) - Accept the 'status' and 'error' options
Tim Otten [Tue, 31 May 2022 07:02:20 +0000 (00:02 -0700)]
Civi::queue(...$queueSpec) - Accept the 'status' and 'error' options

Note: We only enforce this requirement for queues that use the `runner`
option.  Older queue-users may not specify a `runner` -- in which case
they're responsible for establishing their own runner, and their runner
problem doesn't care what is specified here.

2 years agocivicrm_queue - Backfill "status" and "error" columns
Tim Otten [Tue, 31 May 2022 01:19:31 +0000 (18:19 -0700)]
civicrm_queue - Backfill "status" and "error" columns

2 years agocivicrm_queue - Add 'status' and 'error' columns
Tim Otten [Tue, 31 May 2022 01:18:58 +0000 (18:18 -0700)]
civicrm_queue - Add 'status' and 'error' columns

2 years agoMerge pull request #23657 from colemanw/fixGetFieldsWithNoSubType
Tim Otten [Wed, 1 Jun 2022 22:04:22 +0000 (15:04 -0700)]
Merge pull request #23657 from colemanw/fixGetFieldsWithNoSubType

[UNRELEASED REGRESSION] APIv4 - Fix GetFields to return custom fields with no sub-type

2 years agoAPIv4 - Fix GetFields to return custom fields with no sub-type
Coleman Watts [Wed, 1 Jun 2022 20:36:29 +0000 (16:36 -0400)]
APIv4 - Fix GetFields to return custom fields with no sub-type

Ensures unconditional custom fields are always present.

2 years agoMerge pull request #23653 from eileenmcnaughton/import_going
colemanw [Wed, 1 Jun 2022 11:52:28 +0000 (07:52 -0400)]
Merge pull request #23653 from eileenmcnaughton/import_going

Remove no-longer-used function 29 points

2 years agoMerge pull request #23588 from eileenmcnaughton/import_soft
Monish Deb [Wed, 1 Jun 2022 07:44:54 +0000 (13:14 +0530)]
Merge pull request #23588 from eileenmcnaughton/import_soft

[Import] Cleanup Contribution flow - esp with regards to soft credits

2 years agoClean up preview screen code
Eileen McNaughton [Thu, 26 May 2022 04:21:19 +0000 (16:21 +1200)]
Clean up preview screen code

2 years agoSimplify handling of soft credit
Eileen McNaughton [Thu, 26 May 2022 00:37:29 +0000 (12:37 +1200)]
Simplify handling of soft credit

2 years agoMerge pull request #23637 from eileenmcnaughton/import_fn
Eileen McNaughton [Wed, 1 Jun 2022 04:15:59 +0000 (16:15 +1200)]
Merge pull request #23637 from eileenmcnaughton/import_fn

[Import] [Ref] [Contribution] Additional functions, typo fix

2 years agoMerge pull request #23635 from eileenmcnaughton/import_unreach2
Eileen McNaughton [Wed, 1 Jun 2022 04:15:25 +0000 (16:15 +1200)]
Merge pull request #23635 from eileenmcnaughton/import_unreach2

Simplify return from createContact

2 years agoMerge pull request #23647 from civicrm/5.50
Eileen McNaughton [Wed, 1 Jun 2022 03:14:51 +0000 (15:14 +1200)]
Merge pull request #23647 from civicrm/5.50

Merge 5.50 to Master

2 years agoMerge pull request #23654 from agh1/5.50.0-releasenotes-final
Eileen McNaughton [Wed, 1 Jun 2022 03:14:26 +0000 (15:14 +1200)]
Merge pull request #23654 from agh1/5.50.0-releasenotes-final

5.50.0 release notes final

2 years ago5.50.0 release notes: misc edits
Andie Hunt [Wed, 1 Jun 2022 03:08:07 +0000 (23:08 -0400)]
5.50.0 release notes: misc edits

2 years agoMerge pull request #23358 from mattwire/participantwaitlist
Eileen McNaughton [Wed, 1 Jun 2022 02:59:26 +0000 (14:59 +1200)]
Merge pull request #23358 from mattwire/participantwaitlist

Fix missing contactID when registering for paid event from waitlist

2 years ago5.50.0 release notes: added security release
Andie Hunt [Wed, 1 Jun 2022 02:53:42 +0000 (22:53 -0400)]
5.50.0 release notes: added security release

2 years agoRemove no-longer-used function
Eileen McNaughton [Wed, 1 Jun 2022 02:46:25 +0000 (14:46 +1200)]
Remove no-longer-used function

2 years ago5.50.0 release notes: updated with late changes
Andie Hunt [Wed, 1 Jun 2022 02:06:12 +0000 (22:06 -0400)]
5.50.0 release notes: updated with late changes

2 years agoAdd release-notes/5.49.3.md
Tim Otten [Thu, 26 May 2022 05:43:56 +0000 (22:43 -0700)]
Add release-notes/5.49.3.md

2 years agoAdd release-notes/5.49.2.md
Tim Otten [Thu, 19 May 2022 08:08:09 +0000 (01:08 -0700)]
Add release-notes/5.49.2.md

2 years agoAdd release-notes/5.49.1.md
Tim Otten [Fri, 6 May 2022 18:42:41 +0000 (11:42 -0700)]
Add release-notes/5.49.1.md

2 years agoAdd release-notes/5.48.2.md
Tim Otten [Wed, 20 Apr 2022 02:07:56 +0000 (19:07 -0700)]
Add release-notes/5.48.2.md

2 years agoAdd release-notes/5.48.1.md
Tim Otten [Tue, 12 Apr 2022 23:34:14 +0000 (16:34 -0700)]
Add release-notes/5.48.1.md

2 years agoAdd release-notes/5.47.4.md
Tim Otten [Wed, 6 Apr 2022 06:14:29 +0000 (23:14 -0700)]
Add release-notes/5.47.4.md

2 years agoUpdate 5.47.3.md
Tim Otten [Sun, 27 Mar 2022 22:30:02 +0000 (15:30 -0700)]
Update 5.47.3.md

2 years agoAdd release-notes/5.47.3.md
Tim Otten [Sun, 27 Mar 2022 22:19:18 +0000 (15:19 -0700)]
Add release-notes/5.47.3.md

2 years agoAdd release-notes/5.47.2.md
Tim Otten [Thu, 17 Mar 2022 04:58:39 +0000 (21:58 -0700)]
Add release-notes/5.47.2.md

2 years agoAdd release-notes/5.47.1.md
Tim Otten [Wed, 9 Mar 2022 23:37:29 +0000 (15:37 -0800)]
Add release-notes/5.47.1.md

2 years agoAdd release-notes/5.46.3.md
Tim Otten [Thu, 17 Mar 2022 05:07:57 +0000 (22:07 -0700)]
Add release-notes/5.46.3.md

2 years agoAdd release-notes/5.46.2.md
Tim Otten [Fri, 11 Feb 2022 04:10:33 +0000 (20:10 -0800)]
Add release-notes/5.46.2.md

2 years agoAdd release-notes/5.46.1.md
Tim Otten [Wed, 9 Feb 2022 05:02:12 +0000 (21:02 -0800)]
Add release-notes/5.46.1.md

2 years agoAdd release-notes/5.45.3.md
Tim Otten [Fri, 4 Feb 2022 06:19:27 +0000 (22:19 -0800)]
Add release-notes/5.45.3.md

2 years ago[Import] [Ref] Additional functions, typo fix
Eileen McNaughton [Tue, 31 May 2022 03:56:53 +0000 (15:56 +1200)]
[Import] [Ref] Additional functions, typo fix

The functions are not yet used -in the interests of managing conflicts"

2 years agoFurther cleanup return checks
Eileen McNaughton [Mon, 30 May 2022 22:50:03 +0000 (10:50 +1200)]
Further cleanup return checks

2 years agoSimplify return from createContact
Eileen McNaughton [Mon, 30 May 2022 22:31:06 +0000 (10:31 +1200)]
Simplify return from createContact

2 years agoMerge pull request #23642 from eileenmcnaughton/import_c
colemanw [Wed, 1 Jun 2022 02:11:47 +0000 (22:11 -0400)]
Merge pull request #23642 from eileenmcnaughton/import_c

 Fix State handling to be case insensitive again (unreleased regression)

2 years agoMerge pull request #23636 from eileenmcnaughton/import_contact_type
colemanw [Wed, 1 Jun 2022 02:10:46 +0000 (22:10 -0400)]
Merge pull request #23636 from eileenmcnaughton/import_contact_type

Import - ensure userID is set on parser

2 years agoMerge pull request #23643 from eileenmcnaughton/match
colemanw [Wed, 1 Jun 2022 02:07:59 +0000 (22:07 -0400)]
Merge pull request #23643 from eileenmcnaughton/match

Fixes for contact matching - unreleased regression

2 years agoMerge pull request #23644 from lcdservices/dev-core-3482c
colemanw [Wed, 1 Jun 2022 00:49:47 +0000 (20:49 -0400)]
Merge pull request #23644 from lcdservices/dev-core-3482c

dev/core#3482 mailing approval workflow fix

2 years agoMerge pull request #23603 from eileenmcnaughton/rel2
demeritcowboy [Wed, 1 Jun 2022 00:37:03 +0000 (20:37 -0400)]
Merge pull request #23603 from eileenmcnaughton/rel2

Fix createEmployerRelationship to work with the data it has when doing a lookup, test

2 years agoFixes for contact matching
Eileen McNaughton [Tue, 31 May 2022 19:03:49 +0000 (07:03 +1200)]
Fixes for contact matching

2 years agoFix State handling to be case insensitive again
Eileen McNaughton [Tue, 31 May 2022 16:05:41 +0000 (04:05 +1200)]
Fix State handling to be case insensitive again

2 years agoAdd geocode import
Eileen McNaughton [Mon, 30 May 2022 04:58:49 +0000 (16:58 +1200)]
Add geocode import

2 years agoFix State handling to be case insensitive again
Eileen McNaughton [Tue, 31 May 2022 16:05:41 +0000 (04:05 +1200)]
Fix State handling to be case insensitive again

2 years agoAdd geocode import
Eileen McNaughton [Mon, 30 May 2022 04:58:49 +0000 (16:58 +1200)]
Add geocode import

2 years agoMerge pull request #23629 from eileenmcnaughton/import_greetings
colemanw [Tue, 31 May 2022 21:25:40 +0000 (17:25 -0400)]
Merge pull request #23629 from eileenmcnaughton/import_greetings

Simplify greeting handling, add test

2 years agodev/core#3482 mailing approval workflow fix
Brian Shaughnessy [Tue, 31 May 2022 19:36:16 +0000 (15:36 -0400)]
dev/core#3482 mailing approval workflow fix

2 years agoMerge pull request #23567 from kurund/honor-roll-fixes
Eileen McNaughton [Tue, 31 May 2022 19:16:50 +0000 (07:16 +1200)]
Merge pull request #23567 from kurund/honor-roll-fixes

show honor roll only if it's enabled for the PCP page

2 years agoMerge pull request #23640 from aydun/casetype
Eileen McNaughton [Tue, 31 May 2022 16:18:38 +0000 (04:18 +1200)]
Merge pull request #23640 from aydun/casetype

Make CaseType usable in Afform & SearchKit

2 years agoSimplify greeting handling, add test
Eileen McNaughton [Mon, 30 May 2022 03:22:30 +0000 (15:22 +1200)]
Simplify greeting handling, add test

2 years agoMerge pull request #23623 from eileenmcnaughton/pcm
colemanw [Tue, 31 May 2022 14:49:12 +0000 (10:49 -0400)]
Merge pull request #23623 from eileenmcnaughton/pcm

Deprecate crazy BAO handling of preferred_communication_method

2 years agoMake CaseType usable in Afform
Aidan Saunders [Tue, 31 May 2022 14:20:33 +0000 (15:20 +0100)]
Make CaseType usable in Afform

2 years agoMerge pull request #23056 from yashodha/dev-3141
Eileen McNaughton [Tue, 31 May 2022 09:07:42 +0000 (21:07 +1200)]
Merge pull request #23056 from yashodha/dev-3141

(dev/core#3141) Membership should be listed chronologically by join d…

2 years agoMerge pull request #23626 from eileenmcnaughton/import_try
Monish Deb [Tue, 31 May 2022 05:22:41 +0000 (10:52 +0530)]
Merge pull request #23626 from eileenmcnaughton/import_try

Minor cleanup on import return codes

2 years agoMerge pull request #23597 from colemanw/searchKitProximity
Eileen McNaughton [Tue, 31 May 2022 04:19:17 +0000 (16:19 +1200)]
Merge pull request #23597 from colemanw/searchKitProximity

SearchKit - add address proximity (map radius) search

2 years agoMerge pull request #23631 from eileenmcnaughton/authx
Eileen McNaughton [Tue, 31 May 2022 03:16:39 +0000 (15:16 +1200)]
Merge pull request #23631 from eileenmcnaughton/authx

Add Authx settings to navigation

2 years agoImport - ensure userID is set on parser
Eileen McNaughton [Tue, 31 May 2022 02:13:51 +0000 (14:13 +1200)]
Import - ensure userID is set on parser

2 years agoUpdate ext/authx/authx.php
Eileen McNaughton [Tue, 31 May 2022 00:28:40 +0000 (12:28 +1200)]
Update ext/authx/authx.php

Co-authored-by: Tim Otten <totten@civicrm.org>
2 years agoAdd Authx settings to navigation
Eileen McNaughton [Mon, 30 May 2022 11:28:53 +0000 (23:28 +1200)]
Add Authx settings to navigation

2 years agoMinor cleanup on import return codes
Eileen McNaughton [Sun, 29 May 2022 23:51:56 +0000 (11:51 +1200)]
Minor cleanup on import return codes

2 years agoMerge pull request #23634 from eileenmcnaughton/import_unreach
Eileen McNaughton [Tue, 31 May 2022 00:07:20 +0000 (12:07 +1200)]
Merge pull request #23634 from eileenmcnaughton/import_unreach

Remove legacy calls to `civicrm_error`, unpack return

2 years agoAnother unreachable place - code is always duplicate if it is an array
Eileen McNaughton [Mon, 30 May 2022 22:27:08 +0000 (10:27 +1200)]
Another unreachable place - code is always duplicate if it is an array

2 years agoRemove more checks that can be is_array
Eileen McNaughton [Mon, 30 May 2022 22:21:11 +0000 (10:21 +1200)]
Remove more checks that can be is_array

2 years agoRemove unreachable code
Eileen McNaughton [Mon, 30 May 2022 22:11:51 +0000 (10:11 +1200)]
Remove unreachable code

2 years agoRemove legacy calls to civicrm_error, unpack return
Eileen McNaughton [Mon, 30 May 2022 22:07:49 +0000 (10:07 +1200)]
Remove legacy calls to civicrm_error, unpack return

The function can only return an array or a BAO object

2 years agoMerge pull request #23633 from briennekordis/patch-2
demeritcowboy [Mon, 30 May 2022 16:38:35 +0000 (12:38 -0400)]
Merge pull request #23633 from briennekordis/patch-2

Update contributor-key.yml

2 years agoUpdate contributor-key.yml
Brienne Kordis [Mon, 30 May 2022 14:36:05 +0000 (10:36 -0400)]
Update contributor-key.yml

add @briennekordis as a contributor

2 years agoMerge pull request #23610 from eileenmcnaughton/import_dupe
Yashodha Chaku [Mon, 30 May 2022 11:27:17 +0000 (16:57 +0530)]
Merge pull request #23610 from eileenmcnaughton/import_dupe

[Import] [Ref] Trivial - fold function contents back into parent

2 years agoMerge pull request #23628 from totten/5.50-alsoinc-test
Eileen McNaughton [Mon, 30 May 2022 06:58:11 +0000 (18:58 +1200)]
Merge pull request #23628 from totten/5.50-alsoinc-test

(NFC) Scheduled Reminders - Reinstate and analyze test-case for "Also Include"

2 years agoMerge pull request #23627 from eileenmcnaughton/import_test
Yashodha Chaku [Mon, 30 May 2022 06:23:03 +0000 (11:53 +0530)]
Merge pull request #23627 from eileenmcnaughton/import_test

Test cleanup - use names keys in mapper array where possible for clarity

2 years agoMerge pull request #23625 from eileenmcnaughton/import_suff
Yashodha Chaku [Mon, 30 May 2022 05:23:54 +0000 (10:53 +0530)]
Merge pull request #23625 from eileenmcnaughton/import_suff

Remove obsolete code - this parameter is not possible

2 years agoDeprecate crazy BAO handling of preferred_communication_method
Eileen McNaughton [Sun, 29 May 2022 11:18:28 +0000 (23:18 +1200)]
Deprecate crazy BAO handling of preferred_communication_method

In the context of import this is tested in
testImportFieldsWithVariousOptions

- for the api it is tested via testPseudoFields - although in
api context it is just a deprecation

2 years ago(NFC) Scheduled Reminders - Reinstate and analyze test-case for "Also Include"
Tim Otten [Mon, 30 May 2022 02:46:27 +0000 (19:46 -0700)]
(NFC) Scheduled Reminders - Reinstate and analyze test-case for "Also Include"

After reading #23445 and #23101, I wanted to see the test-coverage for "Also
Include".  There's a little...  but not a lot.  There was an interesting-but-inert
test-case.

Before
------

* Test-case is commented-out
* Comments indicate a vague sense of confusion

After
-----

* Test-case is enabled
* Comments indicate a well-developed, robust sense of confusion

2 years agoTest cleanup - use names keys in mapper array where possible for clarity
Eileen McNaughton [Sun, 29 May 2022 22:43:58 +0000 (10:43 +1200)]
Test cleanup - use names keys in mapper array where possible for clarity

2 years agoMerge pull request #23619 from darrick/pull/23534
Eileen McNaughton [Mon, 30 May 2022 00:34:41 +0000 (12:34 +1200)]
Merge pull request #23619 from darrick/pull/23534

Fix swapOptions writing over selected options on mapField page load.

2 years agoMerge pull request #23624 from mattwire/sqlgroup
Seamus Lee [Sun, 29 May 2022 23:55:15 +0000 (09:55 +1000)]
Merge pull request #23624 from mattwire/sqlgroup

Release lock when deleting cache key

2 years ago[Import] [Ref] Trivial - fold function contents back into parent
Eileen McNaughton [Fri, 27 May 2022 21:43:41 +0000 (09:43 +1200)]
[Import] [Ref] Trivial - fold function contents back into parent

The parent is actually longer by virtue of calling the child than without it....

2 years agoRemove obsolete code - this parameter is not possible
Eileen McNaughton [Sun, 29 May 2022 21:35:21 +0000 (09:35 +1200)]
Remove obsolete code - this parameter is not possible

2 years agoRelease lock when deleting cache key
Matthew Wire [Sun, 29 May 2022 16:00:51 +0000 (17:00 +0100)]
Release lock when deleting cache key

2 years agoMerge pull request #23474 from eileenmcnaughton/import_dep
colemanw [Sun, 29 May 2022 15:46:20 +0000 (11:46 -0400)]
Merge pull request #23474 from eileenmcnaughton/import_dep

[Import] Unpack the weird wild error return

2 years agoMerge pull request #23609 from briennekordis/leading_zero_fix
colemanw [Sun, 29 May 2022 15:44:19 +0000 (11:44 -0400)]
Merge pull request #23609 from briennekordis/leading_zero_fix

core 3459 getlist leading zero fix

2 years agoMerge pull request #23613 from eileenmcnaughton/member_unused
colemanw [Sun, 29 May 2022 15:42:50 +0000 (11:42 -0400)]
Merge pull request #23613 from eileenmcnaughton/member_unused

Remove unused variables

2 years agoMerge pull request #23614 from eileenmcnaughton/import_unused2
colemanw [Sun, 29 May 2022 15:42:19 +0000 (11:42 -0400)]
Merge pull request #23614 from eileenmcnaughton/import_unused2

Remove some unused variables

2 years agoMerge pull request #23621 from eileenmcnaughton/import_1
colemanw [Sun, 29 May 2022 15:41:41 +0000 (11:41 -0400)]
Merge pull request #23621 from eileenmcnaughton/import_1

Whitespace cleanup - remove `if(1)`

2 years agoMerge pull request #23586 from eileenmcnaughton/import_mem
colemanw [Sun, 29 May 2022 15:40:59 +0000 (11:40 -0400)]
Merge pull request #23586 from eileenmcnaughton/import_mem

dev/core#3038 Fix handling for payment_instrument_id, cleanup financial_type_id

2 years agoWhitespace cleanup - remove if(1)
Eileen McNaughton [Sun, 29 May 2022 11:02:26 +0000 (23:02 +1200)]
Whitespace cleanup - remove if(1)

2 years agoFix style errors
Darrick Servis [Sun, 29 May 2022 03:15:47 +0000 (20:15 -0700)]
Fix style errors

2 years agoFix swapOptions writing over selected options on mapField page load.
Darrick Servis [Sat, 28 May 2022 18:21:50 +0000 (11:21 -0700)]
Fix swapOptions writing over selected options on mapField page load.

use swapOptions exclusivily to hide fields on mapField form.

2 years agoMerge pull request #23560 from eileenmcnaughton/import_catcher
Eileen McNaughton [Sat, 28 May 2022 03:00:05 +0000 (15:00 +1200)]
Merge pull request #23560 from eileenmcnaughton/import_catcher

[Import] Test + fix for failure to reject invalid ex identifier

2 years ago[Import] Test + fix for failure to reject invalid ex identifier
Eileen McNaughton [Tue, 24 May 2022 05:10:24 +0000 (17:10 +1200)]
[Import] Test + fix for failure to reject invalid ex identifier

2 years agoRemove some unused variables
Eileen McNaughton [Fri, 27 May 2022 22:04:36 +0000 (10:04 +1200)]
Remove some unused variables

2 years agoRemove unused variables
Eileen McNaughton [Fri, 27 May 2022 22:01:28 +0000 (10:01 +1200)]
Remove unused variables

2 years agoMerge pull request #23612 from civicrm/5.50
Eileen McNaughton [Fri, 27 May 2022 21:49:08 +0000 (09:49 +1200)]
Merge pull request #23612 from civicrm/5.50

5.50 to master

2 years agoMerge pull request #23607 from mattwire/23099recentitemspermission
Eileen McNaughton [Fri, 27 May 2022 21:46:01 +0000 (09:46 +1200)]
Merge pull request #23607 from mattwire/23099recentitemspermission

Fix 'Authorization Failed' regression when submitting eg. webform via checksum

2 years agoMerge pull request #23606 from eileenmcnaughton/import_activity
Eileen McNaughton [Fri, 27 May 2022 21:32:42 +0000 (09:32 +1200)]
Merge pull request #23606 from eileenmcnaughton/import_activity

[Import] [Activity] Fix fatal error regression

2 years agocore 3459 getlist leading zero fix
Brienne Kordis [Fri, 27 May 2022 20:57:16 +0000 (16:57 -0400)]
core 3459 getlist leading zero fix

2 years agoMerge pull request #23563 from eileenmcnaughton/import_location_all
colemanw [Fri, 27 May 2022 20:05:30 +0000 (16:05 -0400)]
Merge pull request #23563 from eileenmcnaughton/import_location_all

Import locations - code cleanup, add tests, fix bugs

2 years ago[Import] [Activity] Fix fatal error regression
Eileen McNaughton [Fri, 27 May 2022 06:48:37 +0000 (18:48 +1200)]
[Import] [Activity] Fix fatal error regression

2 years agoMerge pull request #23599 from aydun/contriberror
Eileen McNaughton [Fri, 27 May 2022 19:41:29 +0000 (07:41 +1200)]
Merge pull request #23599 from aydun/contriberror

Make this error message more informative.