civicrm-core.git
13 months agoLoad metadata from settings for Contribution Invoice Settings
Eileen McNaughton [Fri, 27 Oct 2023 04:40:38 +0000 (17:40 +1300)]
Load metadata from settings for Contribution Invoice Settings

13 months agoAdd a couple of soft deprecations
Eileen McNaughton [Fri, 27 Oct 2023 04:25:36 +0000 (17:25 +1300)]
Add a couple of soft deprecations

13 months agoDeprecate setting handler for long-gone nested contribution_invoice_settings
Eileen McNaughton [Fri, 27 Oct 2023 04:08:43 +0000 (17:08 +1300)]
Deprecate setting handler for long-gone nested contribution_invoice_settings

13 months agoMerge pull request #27762 from reflexive-communications/duplicate-contact-sub-type
Eileen McNaughton [Fri, 27 Oct 2023 02:59:15 +0000 (15:59 +1300)]
Merge pull request #27762 from reflexive-communications/duplicate-contact-sub-type

CRM_Core_DAO::copyValues() deduplicate pseudo-constant fields

13 months agoMerge pull request #27942 from colemanw/exportMatch
Tim Otten [Thu, 26 Oct 2023 22:58:38 +0000 (15:58 -0700)]
Merge pull request #27942 from colemanw/exportMatch

APIv4 - Smarter matching params in Managed export action

13 months agoMerge pull request #27895 from colemanw/crmFixArray
Yashodha Chaku [Thu, 26 Oct 2023 14:10:29 +0000 (19:40 +0530)]
Merge pull request #27895 from colemanw/crmFixArray

[REF] Civi - Refactor unnecessary uses of CRM_Utils_Array::value

13 months agoAPIv4 - Smarter matching params in Managed export action
colemanw [Thu, 26 Oct 2023 01:11:19 +0000 (21:11 -0400)]
APIv4 - Smarter matching params in Managed export action

Adds a new bit of entity metadata: match_fields

13 months agoMerge pull request #27938 from eileenmcnaughton/purify
colemanw [Thu, 26 Oct 2023 11:22:41 +0000 (07:22 -0400)]
Merge pull request #27938 from eileenmcnaughton/purify

Use purify over escape for price set fields

13 months agoMerge pull request #27941 from totten/master-karma
colemanw [Thu, 26 Oct 2023 11:20:20 +0000 (07:20 -0400)]
Merge pull request #27941 from totten/master-karma

karma.conf.js - Switch from PhantomJS to ChromeHeadless

13 months agokarma.conf.js - Switch from PhantomJS to ChromeHeadless
Tim Otten [Thu, 26 Oct 2023 07:14:25 +0000 (00:14 -0700)]
karma.conf.js - Switch from PhantomJS to ChromeHeadless

PhantomJS was abandoned upstream in favor of ChromeHeadless

13 months agoMerge pull request #27935 from colemanw/dateYears
Eileen McNaughton [Thu, 26 Oct 2023 00:13:49 +0000 (13:13 +1300)]
Merge pull request #27935 from colemanw/dateYears

SearchKit - Increase date range for in-place edit

13 months agoMerge pull request #27940 from civicrm/5.67
Eileen McNaughton [Wed, 25 Oct 2023 23:36:52 +0000 (12:36 +1300)]
Merge pull request #27940 from civicrm/5.67

5.67 to master

13 months agoMerge pull request #27939 from eileenmcnaughton/price
Eileen McNaughton [Wed, 25 Oct 2023 23:36:27 +0000 (12:36 +1300)]
Merge pull request #27939 from eileenmcnaughton/price

Add weights to PriceField

13 months agoAdd weights to PriceField
Eileen McNaughton [Wed, 25 Oct 2023 22:53:42 +0000 (11:53 +1300)]
Add weights to PriceField

13 months agoMerge pull request #27933 from jaapjansma/civiimport_description_improvement_issue_4714
Eileen McNaughton [Wed, 25 Oct 2023 22:42:26 +0000 (11:42 +1300)]
Merge pull request #27933 from jaapjansma/civiimport_description_improvement_issue_4714

dev/core#4714 Improved wording of CiviImport extension description

13 months agoMerge pull request #27936 from eileenmcnaughton/pledge_block
Eileen McNaughton [Wed, 25 Oct 2023 22:23:58 +0000 (11:23 +1300)]
Merge pull request #27936 from eileenmcnaughton/pledge_block

Move pledge block function back to the only form that calls it

13 months agoMerge pull request #27928 from eileenmcnaughton/mem_test
colemanw [Wed, 25 Oct 2023 21:39:19 +0000 (17:39 -0400)]
Merge pull request #27928 from eileenmcnaughton/mem_test

Fix test on secondary membership contribution to use full form flow

13 months agoUse purify over escape for price set fields
Eileen McNaughton [Wed, 25 Oct 2023 20:40:53 +0000 (09:40 +1300)]
Use purify over escape for price set fields

The label was causing an issue, but I wasn't confident people couldn't leverage
html from the various help_pre, description fields so I used purify for them too

13 months agoMerge pull request #27937 from seamuslee001/master
Seamus Lee [Wed, 25 Oct 2023 20:37:41 +0000 (07:37 +1100)]
Merge pull request #27937 from seamuslee001/master

5.67

13 months agoMerge branch '5.67'
Seamus Lee [Wed, 25 Oct 2023 20:36:06 +0000 (07:36 +1100)]
Merge branch '5.67'

13 months agoMove pledge block function back to the only form that calls it
Eileen McNaughton [Wed, 25 Oct 2023 20:19:39 +0000 (09:19 +1300)]
Move pledge block function back to the only form that calls it

13 months agoSearchKit - Increase date range for in-place edit
colemanw [Wed, 25 Oct 2023 18:39:59 +0000 (14:39 -0400)]
SearchKit - Increase date range for in-place edit

13 months agoMerge pull request #27899 from colemanw/afformSubmit
colemanw [Wed, 25 Oct 2023 17:50:28 +0000 (13:50 -0400)]
Merge pull request #27899 from colemanw/afformSubmit

Afform - Improve error handling during form submission

13 months agoImproved wording
Jaap Jansma [Wed, 25 Oct 2023 13:17:29 +0000 (15:17 +0200)]
Improved wording

13 months agoFix test on secondary membership contribution to use full form flow
Eileen McNaughton [Wed, 25 Oct 2023 01:04:15 +0000 (14:04 +1300)]
Fix test on secondary membership contribution to use full form flow

This includes minor standardisation on the priceSetID references - the
variable is being referred to from both the get & within params but the
getter is the primary source

13 months agoMerge pull request #27929 from eileenmcnaughton/private_func
Eileen McNaughton [Wed, 25 Oct 2023 03:57:48 +0000 (16:57 +1300)]
Merge pull request #27929 from eileenmcnaughton/private_func

Make function private,non static, after universe search

13 months agoMerge pull request #27913 from colemanw/fiveSixtySeven
Tim Otten [Wed, 25 Oct 2023 03:06:24 +0000 (20:06 -0700)]
Merge pull request #27913 from colemanw/fiveSixtySeven

dev/core#4696 - Increase length of ActionSchedule.name (again)

13 months agoIncrease length of ActionSchedule.name and fix swapped comments in upgrader
colemanw [Tue, 24 Oct 2023 01:36:09 +0000 (21:36 -0400)]
Increase length of ActionSchedule.name and fix swapped comments in upgrader

Fixes dev/core#4696 by increasing the column length before writing to it.
Also fixes an error in the upgrader where Discount.entity_table and ActionSchedule.name
descriptions were accidentally swapped.

13 months agoMerge pull request #27926 from seamuslee001/dev_core_4726
Seamus Lee [Wed, 25 Oct 2023 02:07:56 +0000 (13:07 +1100)]
Merge pull request #27926 from seamuslee001/dev_core_4726

dev/core#4726 Ensure that quickform mapper default value is set correā€¦

13 months agoMake function private,non static, after universe search
Eileen McNaughton [Wed, 25 Oct 2023 01:52:44 +0000 (14:52 +1300)]
Make function private,non static, after universe search

13 months agoMerge pull request #27920 from eileenmcnaughton/main_member
Seamus Lee [Wed, 25 Oct 2023 01:51:22 +0000 (12:51 +1100)]
Merge pull request #27920 from eileenmcnaughton/main_member

Fix master-only regression on auto_renew

13 months agoMerge pull request #27927 from colemanw/jwtCheck
Tim Otten [Wed, 25 Oct 2023 01:29:49 +0000 (18:29 -0700)]
Merge pull request #27927 from colemanw/jwtCheck

Afform - Remove redundant status checks

13 months agoMerge pull request #27881 from mlutfy/withDecimals
demeritcowboy [Wed, 25 Oct 2023 01:21:14 +0000 (21:21 -0400)]
Merge pull request #27881 from mlutfy/withDecimals

Tweak money/numeric error messages to not mention point (could be a comma)

13 months agoRemove references to empty price set, we are within a loop of that var
Eileen McNaughton [Tue, 24 Oct 2023 20:21:13 +0000 (09:21 +1300)]
Remove references to empty price set, we are within a loop of that var

13 months agodev/core#4726 Ensure that quickform mapper default value is set correctly for do_not_...
Seamus Lee [Wed, 25 Oct 2023 00:05:37 +0000 (11:05 +1100)]
dev/core#4726 Ensure that quickform mapper default value is set correctly for do_not_import fields in saved mappings on import

Fix test failure

13 months agoAfform - Remove redundant status checks
colemanw [Wed, 25 Oct 2023 00:40:24 +0000 (20:40 -0400)]
Afform - Remove redundant status checks

Now that Afform and Authx are both required extensions, status check for the presence of Authx is redundant.

13 months agoMerge pull request #27925 from eileenmcnaughton/form_this
colemanw [Tue, 24 Oct 2023 23:45:30 +0000 (19:45 -0400)]
Merge pull request #27925 from eileenmcnaughton/form_this

Fix use of `$form` for `$this` in previously shared, previously static function

13 months agoFix use of form for this in previously shared, previously static function
Eileen McNaughton [Tue, 24 Oct 2023 22:59:38 +0000 (11:59 +1300)]
Fix use of form for this in previously shared, previously static function

13 months agoMerge pull request #27921 from demeritcowboy/attributes
Eileen McNaughton [Tue, 24 Oct 2023 22:04:11 +0000 (11:04 +1300)]
Merge pull request #27921 from demeritcowboy/attributes

dev/core#4729 - Menu doesn't build because wrong array key

13 months agoMerge pull request #27919 from eileenmcnaughton/unreachable
Eileen McNaughton [Tue, 24 Oct 2023 22:03:08 +0000 (11:03 +1300)]
Merge pull request #27919 from eileenmcnaughton/unreachable

Remove always-true if

13 months agoSet version to 5.67.beta2
colemanw [Tue, 24 Oct 2023 21:19:13 +0000 (17:19 -0400)]
Set version to 5.67.beta2

13 months agoUpgrader - Repeat step from 5.66 because it was added late in the release-cycle
colemanw [Tue, 24 Oct 2023 12:50:38 +0000 (08:50 -0400)]
Upgrader - Repeat step from 5.66 because it was added late in the release-cycle

13 months agotypo
demeritcowboy [Tue, 24 Oct 2023 21:12:03 +0000 (17:12 -0400)]
typo

13 months agoMerge pull request #27914 from colemanw/releaseDate
Tim Otten [Tue, 24 Oct 2023 21:07:54 +0000 (14:07 -0700)]
Merge pull request #27914 from colemanw/releaseDate

Core/ext - Update releaseDate when setting new version

13 months agoFix master-only regression on id
Eileen McNaughton [Tue, 24 Oct 2023 20:17:00 +0000 (09:17 +1300)]
Fix master-only regression on id

13 months agoRemove always-true if
Eileen McNaughton [Tue, 24 Oct 2023 19:26:22 +0000 (08:26 +1300)]
Remove always-true if

As can be seen the last OR in the IF is always TRUE as validFieldsOnly is always FALSE

13 months agoTweak money/numeric error messages to not mention point (could be a comma)
Mathieu Lu [Sun, 22 Oct 2023 18:13:20 +0000 (14:13 -0400)]
Tweak money/numeric error messages to not mention point (could be a comma)

13 months agoCore/ext - Update releaseDay when setting new version
colemanw [Tue, 24 Oct 2023 13:30:24 +0000 (09:30 -0400)]
Core/ext - Update releaseDay when setting new version

13 months agoMerge pull request #27876 from colemanw/master-multi-domain
colemanw [Tue, 24 Oct 2023 12:38:08 +0000 (08:38 -0400)]
Merge pull request #27876 from colemanw/master-multi-domain

ManagedEntity - Replicate multi-domain entities when multisite is enabled

13 months agoMerge pull request #27897 from MegaphoneJon/geocoding-catch
Matthew Wire [Tue, 24 Oct 2023 12:07:41 +0000 (13:07 +0100)]
Merge pull request #27897 from MegaphoneJon/geocoding-catch

fixes core#2929: Don't crash a contribution because of a geocoding failure

13 months agoUpdate CRM/Core/BAO/Address.php
Matthew Wire [Tue, 24 Oct 2023 12:07:03 +0000 (13:07 +0100)]
Update CRM/Core/BAO/Address.php

Co-authored-by: Rich Lott <artfulrobot@users.noreply.github.com>
13 months agoMerge pull request #27749 from eileenmcnaughton/queue
Tim Otten [Tue, 24 Oct 2023 06:20:48 +0000 (23:20 -0700)]
Merge pull request #27749 from eileenmcnaughton/queue

Save mailing_id, is_test in test mode, where job is available

13 months agoMerge pull request #27911 from ranjit-git/master
Eileen McNaughton [Tue, 24 Oct 2023 05:46:09 +0000 (18:46 +1300)]
Merge pull request #27911 from ranjit-git/master

event title xss fix

13 months agoMerge pull request #27908 from civicrm/5.67
Eileen McNaughton [Tue, 24 Oct 2023 05:45:48 +0000 (18:45 +1300)]
Merge pull request #27908 from civicrm/5.67

5.67

13 months agoMerge pull request #1 from ranjit-git/ranjit-git-patch-1
ranjit-git [Tue, 24 Oct 2023 03:56:00 +0000 (09:26 +0530)]
Merge pull request #1 from ranjit-git/ranjit-git-patch-1

event title xss fix

13 months agoevent title xss fix
ranjit-git [Tue, 24 Oct 2023 03:54:59 +0000 (09:24 +0530)]
event title xss fix

xss fix report link https://huntr.com/bounties/85a48225-24a4-4d5a-8134-36724183b53e/

13 months agoMerge pull request #27858 from samuelsov/lab4703
Seamus Lee [Tue, 24 Oct 2023 02:36:38 +0000 (13:36 +1100)]
Merge pull request #27858 from samuelsov/lab4703

dev/core#4703

13 months agoMerge pull request #27902 from eileenmcnaughton/supports
colemanw [Tue, 24 Oct 2023 01:28:18 +0000 (21:28 -0400)]
Merge pull request #27902 from eileenmcnaughton/supports

Use api to get price set metadata - Online Contribution Page

13 months agoMerge pull request #27905 from eileenmcnaughton/price_var
colemanw [Tue, 24 Oct 2023 01:25:59 +0000 (21:25 -0400)]
Merge pull request #27905 from eileenmcnaughton/price_var

Remove non-variable variables from previously-shared code

13 months agoMerge pull request #27906 from eileenmcnaughton/unreachable
colemanw [Tue, 24 Oct 2023 01:25:07 +0000 (21:25 -0400)]
Merge pull request #27906 from eileenmcnaughton/unreachable

Remove unreachable code from previously shared function

13 months agodev/core#4703 remove obsolete code
Samuel Vanhove [Mon, 23 Oct 2023 13:33:13 +0000 (09:33 -0400)]
dev/core#4703 remove obsolete code

13 months agodev/core#4703 edit with no parents crash
Samuel Vanhove [Wed, 18 Oct 2023 21:59:59 +0000 (17:59 -0400)]
dev/core#4703 edit with no parents crash

13 months agodev/core#4703
Samuel Vanhove [Wed, 18 Oct 2023 21:39:47 +0000 (17:39 -0400)]
dev/core#4703

13 months agoRemove unreachable code from previously shared function
Eileen McNaughton [Tue, 24 Oct 2023 00:33:30 +0000 (13:33 +1300)]
Remove unreachable code from previously shared function

13 months agoRemove non-variable variables from previously-shared code
Eileen McNaughton [Tue, 24 Oct 2023 00:04:59 +0000 (13:04 +1300)]
Remove non-variable variables from previously-shared code

This new private function is only called from one place & the variables are always the same

13 months agoFurther recent regression fix
Eileen McNaughton [Mon, 23 Oct 2023 23:03:01 +0000 (12:03 +1300)]
Further recent regression fix

13 months agoUse api to get price set metadata
Eileen McNaughton [Mon, 23 Oct 2023 20:51:37 +0000 (09:51 +1300)]
Use api to get price set metadata

13 months agoMerge pull request #27901 from eileenmcnaughton/life_time
Eileen McNaughton [Mon, 23 Oct 2023 22:52:07 +0000 (11:52 +1300)]
Merge pull request #27901 from eileenmcnaughton/life_time

Minor variable consolidation, reduce notices

13 months agoMinor variable consolidation
Eileen McNaughton [Mon, 23 Oct 2023 21:42:18 +0000 (10:42 +1300)]
Minor variable consolidation

lifetime & pricelifetime both have one function - to trigger the message in the touched tpl.

If either are set then effectively both are set. This consolidates them to 1, reducing notices

13 months agoCRM_Contact_BAO_Contact::add handle serialized contact_sub_type also
Sandor Semsey [Fri, 20 Oct 2023 12:49:29 +0000 (14:49 +0200)]
CRM_Contact_BAO_Contact::add handle serialized contact_sub_type also

Co-authored-by: colemanw <coleman@civicrm.org>
13 months agoMerge pull request #27890 from eileenmcnaughton/backoffice
colemanw [Mon, 23 Oct 2023 20:52:01 +0000 (16:52 -0400)]
Merge pull request #27890 from eileenmcnaughton/backoffice

Stop assigning ispricelifetime - used in previously shared usage

13 months agoMerge pull request #27900 from eileenmcnaughton/supports
Eileen McNaughton [Mon, 23 Oct 2023 20:49:17 +0000 (09:49 +1300)]
Merge pull request #27900 from eileenmcnaughton/supports

Fix MainTest to test form metadata function, not old unused function

13 months agoMerge pull request #27898 from colemanw/apiArrayFix
Eileen McNaughton [Mon, 23 Oct 2023 20:33:17 +0000 (09:33 +1300)]
Merge pull request #27898 from colemanw/apiArrayFix

[REF] Apiv3 - Refactor unnecessary uses of CRM_Utils_Array::value

13 months agoFix MainTest to test form metadata function, not old unused function
Eileen McNaughton [Mon, 23 Oct 2023 19:51:25 +0000 (08:51 +1300)]
Fix MainTest to test form metadata function, not old unused function

13 months agoMerge pull request #27816 from colemanw/arrayCleanupReport
Eileen McNaughton [Mon, 23 Oct 2023 19:07:35 +0000 (08:07 +1300)]
Merge pull request #27816 from colemanw/arrayCleanupReport

[REF] CRM/Report - Refactor unnecessary uses of CRM_Utils_Array::value

13 months agoAfform - Improve error handling during form submission
colemanw [Mon, 23 Oct 2023 17:55:52 +0000 (13:55 -0400)]
Afform - Improve error handling during form submission

13 months agoApiv3 - Refactor unnecessary uses of CRM_Utils_Array::value
colemanw [Mon, 23 Oct 2023 16:12:54 +0000 (12:12 -0400)]
Apiv3 - Refactor unnecessary uses of CRM_Utils_Array::value

13 months agofixes core#2929: Don't crash a contribution because of a geocoding failure
Jon Goldberg [Mon, 23 Oct 2023 15:59:53 +0000 (11:59 -0400)]
fixes core#2929: Don't crash a contribution because of a geocoding failure

13 months agoCivi - Refactor unnecessary uses of CRM_Utils_Array::value
colemanw [Mon, 23 Oct 2023 15:21:56 +0000 (11:21 -0400)]
Civi - Refactor unnecessary uses of CRM_Utils_Array::value

13 months agoMerge pull request #27885 from eileenmcnaughton/batches
colemanw [Mon, 23 Oct 2023 14:35:22 +0000 (10:35 -0400)]
Merge pull request #27885 from eileenmcnaughton/batches

Report notice fix - batch id

13 months agoMerge pull request #27851 from eileenmcnaughton/main_behalf
colemanw [Mon, 23 Oct 2023 14:35:04 +0000 (10:35 -0400)]
Merge pull request #27851 from eileenmcnaughton/main_behalf

Extract addOnBehalfFields, ensure variables always assigned

13 months agoMerge pull request #27863 from colemanw/skCssRuleOptions
colemanw [Mon, 23 Oct 2023 13:59:39 +0000 (09:59 -0400)]
Merge pull request #27863 from colemanw/skCssRuleOptions

Fix dev/core#4638 - SearchKit conditional option matching fix

13 months agoMerge pull request #27892 from eileenmcnaughton/build_recur
colemanw [Mon, 23 Oct 2023 13:51:33 +0000 (09:51 -0400)]
Merge pull request #27892 from eileenmcnaughton/build_recur

Unshare form function

13 months agoMerge pull request #27893 from eileenmcnaughton/supports
colemanw [Mon, 23 Oct 2023 13:48:50 +0000 (09:48 -0400)]
Merge pull request #27893 from eileenmcnaughton/supports

Fix Contribution MainTest to set payment processor properties better

13 months agoMerge pull request #27889 from eileenmcnaughton/main_member
colemanw [Mon, 23 Oct 2023 13:46:47 +0000 (09:46 -0400)]
Merge pull request #27889 from eileenmcnaughton/main_member

Standardise price field metadata  on Main contribution page

13 months agoReports - fix redundant stuff
colemanw [Mon, 23 Oct 2023 13:41:10 +0000 (09:41 -0400)]
Reports - fix redundant stuff

13 months agoCRM/Report - Refactor unnecessary uses of CRM_Utils_Array::value
colemanw [Fri, 13 Oct 2023 23:40:17 +0000 (19:40 -0400)]
CRM/Report - Refactor unnecessary uses of CRM_Utils_Array::value

13 months agoFix Contribution MainTest to set payment processor properties better
Eileen McNaughton [Mon, 23 Oct 2023 11:23:09 +0000 (00:23 +1300)]
Fix Contribution MainTest to set payment processor properties better

13 months agoUnshare form function
Eileen McNaughton [Mon, 23 Oct 2023 10:17:16 +0000 (23:17 +1300)]
Unshare form function

13 months agoStop assigning ispricelifetime - used in previously shared usage
Eileen McNaughton [Mon, 23 Oct 2023 09:16:38 +0000 (22:16 +1300)]
Stop assigning ispricelifetime - used in previously shared usage

13 months agoMerge pull request #26002 from eileenmcnaughton/declare_strict
Eileen McNaughton [Mon, 23 Oct 2023 03:29:37 +0000 (16:29 +1300)]
Merge pull request #26002 from eileenmcnaughton/declare_strict

Declare strict types in CiviUnitTestCase

13 months agoFix notices relating to membership on Main contribution page
Eileen McNaughton [Mon, 23 Oct 2023 03:18:26 +0000 (16:18 +1300)]
Fix notices relating to membership on Main contribution page

13 months agoMerge pull request #27888 from eileenmcnaughton/event_summary
Yashodha Chaku [Mon, 23 Oct 2023 03:11:36 +0000 (08:41 +0530)]
Merge pull request #27888 from eileenmcnaughton/event_summary

PHP8.2 undefined property fix event summary report

13 months agoMerge pull request #27886 from eileenmcnaughton/soft
colemanw [Mon, 23 Oct 2023 01:51:24 +0000 (21:51 -0400)]
Merge pull request #27886 from eileenmcnaughton/soft

Preliminary cleanup - remove function overrides that do not override

13 months agoMerge pull request #27850 from eileenmcnaughton/confirm_nfc
colemanw [Mon, 23 Oct 2023 00:51:39 +0000 (20:51 -0400)]
Merge pull request #27850 from eileenmcnaughton/confirm_nfc

[REF] Unshared processRecurringContribution

13 months agoMerge pull request #27884 from eileenmcnaughton/blt
colemanw [Mon, 23 Oct 2023 00:49:22 +0000 (20:49 -0400)]
Merge pull request #27884 from eileenmcnaughton/blt

Remove one more ref to undefined property `contributeMode`

13 months agoPHP8.2 undefined property fix event summary report
Eileen McNaughton [Mon, 23 Oct 2023 00:21:13 +0000 (13:21 +1300)]
PHP8.2 undefined property fix event summary report

13 months agoMerge pull request #27887 from eileenmcnaughton/select_clauses
colemanw [Mon, 23 Oct 2023 00:09:28 +0000 (20:09 -0400)]
Merge pull request #27887 from eileenmcnaughton/select_clauses

Php 8.2 notice fix on soft credit report

13 months agoPhp 8.2 notice fix
Eileen McNaughton [Mon, 23 Oct 2023 00:05:12 +0000 (13:05 +1300)]
Php 8.2 notice fix

This uses the same variable name as other reports for selectClauses - which means
it is no longer undefined / causing test fails on edge

13 months agoPreliminary cleanup - remove function overrides that do not override
Eileen McNaughton [Sun, 22 Oct 2023 23:49:49 +0000 (12:49 +1300)]
Preliminary cleanup - remove function overrides that do not override