civicrm-core.git
22 months ago[NFC] 5.56 release notes first pass
Alice Frumin [Fri, 10 Mar 2023 02:52:02 +0000 (21:52 -0500)]
[NFC] 5.56 release notes first pass

23 months agoMerge pull request #25775 from eileenmcnaughton/payapl
Tim Otten [Thu, 9 Mar 2023 23:30:32 +0000 (15:30 -0800)]
Merge pull request #25775 from eileenmcnaughton/payapl

dev/core#4158 Fix for recurring double ups

23 months agodev/core#4158 Fix for recurring double ups
Eileen McNaughton [Thu, 9 Mar 2023 22:22:50 +0000 (11:22 +1300)]
dev/core#4158 Fix for recurring double ups

23 months agoMerge pull request #25769 from agh1/5.60.0-releasenotes-initial
Eileen McNaughton [Thu, 9 Mar 2023 03:41:59 +0000 (16:41 +1300)]
Merge pull request #25769 from agh1/5.60.0-releasenotes-initial

5.60.0 release notes initial run

23 months ago5.60.0 release notes: added boilerplate
Andie Hunt [Thu, 9 Mar 2023 01:12:28 +0000 (20:12 -0500)]
5.60.0 release notes: added boilerplate

23 months ago5.60.0 release notes: raw from script
Andie Hunt [Thu, 9 Mar 2023 01:08:43 +0000 (20:08 -0500)]
5.60.0 release notes: raw from script

23 months agoMerge pull request #25758 from eileenmcnaughton/560
Eileen McNaughton [Wed, 8 Mar 2023 03:38:41 +0000 (16:38 +1300)]
Merge pull request #25758 from eileenmcnaughton/560

Load submitted `fieldSeparator` on back on `Import Datasource` screen

23 months agoLoad submitted fieldSeparator on back on Import Datasource screen
Eileen McNaughton [Wed, 8 Mar 2023 02:15:39 +0000 (15:15 +1300)]
Load submitted fieldSeparator on back on Import Datasource screen

23 months agoMerge pull request #25753 from MegaphoneJon/two-field-separators-3
Eileen McNaughton [Tue, 7 Mar 2023 22:21:55 +0000 (11:21 +1300)]
Merge pull request #25753 from MegaphoneJon/two-field-separators-3

Remove the correct extraneous field separator field

23 months agoRemove the correct extraneous field separator field
Jon Goldberg [Mon, 6 Mar 2023 19:47:38 +0000 (14:47 -0500)]
Remove the correct extraneous field separator field

23 months agoMerge pull request #25724 from eileenmcnaughton/crazy_complete
Tim Otten [Tue, 7 Mar 2023 04:18:39 +0000 (20:18 -0800)]
Merge pull request #25724 from eileenmcnaughton/crazy_complete

PayPal Prp IPN - Fix incorrect option_group update

23 months agodev/core#4158 Fix incorrect option_group update in paypal recurring
Eileen McNaughton [Fri, 3 Mar 2023 05:41:32 +0000 (18:41 +1300)]
dev/core#4158 Fix incorrect option_group update in paypal recurring

This line was pointed out as being problematic in the issue
https://lab.civicrm.org/dev/core/-/issues/4158 and in a test
I was able to verify it causes issues if the value for Completed
in the contribution status option group is not the same as the
contribution recur option group. However, it appears to
be more of a theoretical / test creatable regression than a real
world one & is not a credible fix for the bug.

I think an rc merge without a stable back port is OK

23 months agoMerge pull request #25733 from totten/5.60-upg-ml
Tim Otten [Sat, 4 Mar 2023 03:31:04 +0000 (19:31 -0800)]
Merge pull request #25733 from totten/5.60-upg-ml

Fix for 5.59 upgrade on multilingual

23 months agoFix for 5.59 upgrade on multilingual
Jon Goldberg [Thu, 2 Mar 2023 15:37:09 +0000 (10:37 -0500)]
Fix for 5.59 upgrade on multilingual

23 months agoMerge pull request #25729 from MegaphoneJon/membership-lookup-fix
Seamus Lee [Fri, 3 Mar 2023 21:02:53 +0000 (08:02 +1100)]
Merge pull request #25729 from MegaphoneJon/membership-lookup-fix

Contribution pages crash for logged-in users when CiviMember is disabled

23 months agoFix regression on contribution pages when CiviMember is not enabled
Jon Goldberg [Fri, 3 Mar 2023 19:37:50 +0000 (14:37 -0500)]
Fix regression on contribution pages when CiviMember is not enabled

23 months agoMerge pull request #25704 from totten/5.59-token-mismatch
Tim Otten [Thu, 2 Mar 2023 22:45:41 +0000 (14:45 -0800)]
Merge pull request #25704 from totten/5.59-token-mismatch

(dev/core#4147) Add test and fix for various flaky tokens

23 months agoApi4 - Rename Worldregion to WorldRegion
Tim Otten [Thu, 2 Mar 2023 08:22:40 +0000 (00:22 -0800)]
Api4 - Rename Worldregion to WorldRegion

23 months agoWorldregion - For API-entity-naming, prefer "WorldRegion"
Tim Otten [Thu, 2 Mar 2023 05:53:53 +0000 (21:53 -0800)]
Worldregion - For API-entity-naming, prefer "WorldRegion"

23 months agoSet version to 5.60.beta1
CiviCRM [Thu, 2 Mar 2023 01:32:11 +0000 (01:32 +0000)]
Set version to 5.60.beta1

23 months agoStyle
Eileen McNaughton [Wed, 1 Mar 2023 22:56:05 +0000 (11:56 +1300)]
Style

23 months agoMerge pull request #25706 from eileenmcnaughton/strict
Eileen McNaughton [Wed, 1 Mar 2023 22:46:58 +0000 (11:46 +1300)]
Merge pull request #25706 from eileenmcnaughton/strict

Stricter typing in Apiv4

23 months agoSigh, and they have colons:
Eileen McNaughton [Wed, 1 Mar 2023 22:21:37 +0000 (11:21 +1300)]
Sigh, and they have colons:

23 months agoFix key mismatch
Eileen McNaughton [Wed, 1 Mar 2023 22:20:16 +0000 (11:20 +1300)]
Fix key mismatch

23 months agoFix preferred_communication method
Eileen McNaughton [Wed, 1 Mar 2023 22:19:02 +0000 (11:19 +1300)]
Fix preferred_communication method

Also fix over-aggressive test assertion

23 months agoFix region token
Eileen McNaughton [Wed, 1 Mar 2023 21:56:43 +0000 (10:56 +1300)]
Fix region token

23 months agoStricter typing in Apiv4
Eileen McNaughton [Wed, 1 Mar 2023 21:49:40 +0000 (10:49 +1300)]
Stricter typing in Apiv4

23 months agoAdd Worldregion api for join
Eileen McNaughton [Wed, 1 Mar 2023 21:47:44 +0000 (10:47 +1300)]
Add Worldregion api for join

23 months agoFix for unresolved state_province
Eileen McNaughton [Wed, 1 Mar 2023 21:47:26 +0000 (10:47 +1300)]
Fix for unresolved state_province

23 months agoMerge pull request #25705 from eileenmcnaughton/dep
colemanw [Wed, 1 Mar 2023 21:03:00 +0000 (16:03 -0500)]
Merge pull request #25705 from eileenmcnaughton/dep

Remove deprecated function calls to Event::del, Membership functions del, OptionValue

23 months agoRename variable - I figured out what it meant
Eileen McNaughton [Wed, 1 Mar 2023 20:09:49 +0000 (09:09 +1300)]
Rename variable - I figured out what it meant

23 months agoAdhere to comment block code standard
Eileen McNaughton [Wed, 1 Mar 2023 20:08:31 +0000 (09:08 +1300)]
Adhere to comment block code standard

Standard is short one liner first:

23 months agoSuperficial test cleanup, protect variable
Eileen McNaughton [Wed, 1 Mar 2023 20:07:37 +0000 (09:07 +1300)]
Superficial test cleanup, protect variable

23 months agoAdd phpdoc to prevent restoreTime being removed
Eileen McNaughton [Wed, 1 Mar 2023 20:05:46 +0000 (09:05 +1300)]
Add phpdoc to prevent restoreTime being removed

These unused variables cause quite a few bugs - keeping them 'matters' but
they look like they can go and people doing that happens moderately often,
causing bugs (this has been the cause of more than one 'locks don't work bug'

23 months agoRemove some calls to OptionValue deleteRecord
Eileen McNaughton [Wed, 1 Mar 2023 19:51:53 +0000 (08:51 +1300)]
Remove some calls to OptionValue deleteRecord

23 months agoDeprecations in Event, Membership
Eileen McNaughton [Wed, 1 Mar 2023 19:48:57 +0000 (08:48 +1300)]
Deprecations in Event, Membership

Per https://github.com/civicrm/civicrm-core/pull/25677

23 months agoStop calling deprectated del function
Eileen McNaughton [Wed, 1 Mar 2023 19:44:34 +0000 (08:44 +1300)]
Stop calling deprectated del function

23 months ago(dev/core#4147) Add scenario testTokensIndividually
Tim Otten [Wed, 1 Mar 2023 09:12:49 +0000 (01:12 -0800)]
(dev/core#4147) Add scenario testTokensIndividually

23 months ago(REF) MessageTemplateTest - Extract method useFrozenTime()
Tim Otten [Wed, 1 Mar 2023 09:10:40 +0000 (01:10 -0800)]
(REF) MessageTemplateTest - Extract method useFrozenTime()

23 months agoMerge pull request #25702 from civicrm/5.59
Eileen McNaughton [Wed, 1 Mar 2023 06:34:22 +0000 (19:34 +1300)]
Merge pull request #25702 from civicrm/5.59

5.59

23 months agoMerge pull request #25698 from colemanw/removeIds
Yashodha Chaku [Wed, 1 Mar 2023 04:42:43 +0000 (10:12 +0530)]
Merge pull request #25698 from colemanw/removeIds

Remove deprecated use of $ids

23 months agoMerge pull request #25701 from alifrumin/5.59rn
Yashodha Chaku [Wed, 1 Mar 2023 04:40:51 +0000 (10:10 +0530)]
Merge pull request #25701 from alifrumin/5.59rn

[NFC] 5.59 release notes sorting and annotating

23 months ago[NFC] 5.59 release notes sorting and annotating
Alice Frumin [Wed, 1 Mar 2023 03:56:11 +0000 (22:56 -0500)]
[NFC] 5.59 release notes sorting and annotating

23 months agoMerge pull request #25699 from civicrm/5.59
Eileen McNaughton [Wed, 1 Mar 2023 02:51:57 +0000 (15:51 +1300)]
Merge pull request #25699 from civicrm/5.59

5.59 to master

23 months agoMerge pull request #25697 from agh1/5.59.0-releasenotes-initial
Eileen McNaughton [Wed, 1 Mar 2023 02:51:34 +0000 (15:51 +1300)]
Merge pull request #25697 from agh1/5.59.0-releasenotes-initial

5.59.0 releasenotes initial run

23 months agoMerge pull request #25639 from eileenmcnaughton/import_validate
Tim Otten [Wed, 1 Mar 2023 01:44:30 +0000 (17:44 -0800)]
Merge pull request #25639 from eileenmcnaughton/import_validate

dev/core#4132 Fix import for multi-custom boxes

23 months agoRemove deprecated use of $ids
Coleman Watts [Wed, 1 Mar 2023 01:32:09 +0000 (20:32 -0500)]
Remove deprecated use of $ids

23 months ago5.59.0 release notes: added boilerplate
Andie Hunt [Wed, 1 Mar 2023 01:26:08 +0000 (20:26 -0500)]
5.59.0 release notes: added boilerplate

23 months ago5.59.0 release notes: raw from script
Andie Hunt [Wed, 1 Mar 2023 01:21:59 +0000 (20:21 -0500)]
5.59.0 release notes: raw from script

23 months agoMerge pull request #25696 from colemanw/delDep
colemanw [Wed, 1 Mar 2023 00:57:11 +0000 (19:57 -0500)]
Merge pull request #25696 from colemanw/delDep

Delete long-deprecated functions

23 months agoMerge pull request #25695 from eileenmcnaughton/CRM/Block
colemanw [Wed, 1 Mar 2023 00:22:38 +0000 (19:22 -0500)]
Merge pull request #25695 from eileenmcnaughton/CRM/Block

Pull over a few more deprecations + blockDelete deprecation

23 months agoDelete long-deprecated functions
Coleman Watts [Wed, 1 Mar 2023 00:04:36 +0000 (19:04 -0500)]
Delete long-deprecated functions

23 months agoPull over a few more deprecations + blockDelete deprecation
Eileen McNaughton [Tue, 28 Feb 2023 23:48:27 +0000 (12:48 +1300)]
Pull over a few more deprecations + blockDelete deprecation

23 months agoMerge pull request #25693 from eileenmcnaughton/CRM/Block
Eileen McNaughton [Tue, 28 Feb 2023 23:45:38 +0000 (12:45 +1300)]
Merge pull request #25693 from eileenmcnaughton/CRM/Block

Address portions of deprecated code replacement

23 months agoAddress portions of deprecated code replacement
Eileen McNaughton [Tue, 28 Feb 2023 22:31:22 +0000 (11:31 +1300)]
Address portions of deprecated code replacement

23 months agoMerge pull request #25691 from eileenmcnaughton/dep_mailing
colemanw [Tue, 28 Feb 2023 22:07:48 +0000 (17:07 -0500)]
Merge pull request #25691 from eileenmcnaughton/dep_mailing

Deprecations for Mailing::delete functions

23 months agoMerge pull request #25690 from eileenmcnaughton/dep_test
Eileen McNaughton [Tue, 28 Feb 2023 21:49:55 +0000 (10:49 +1300)]
Merge pull request #25690 from eileenmcnaughton/dep_test

Deprecations for delete on ACL entities

23 months agoDeprecations for Mailing::delete functions
Eileen McNaughton [Tue, 28 Feb 2023 21:01:23 +0000 (10:01 +1300)]
Deprecations for Mailing::delete functions

23 months agoDeprecations for delete on ACL entities
Eileen McNaughton [Tue, 28 Feb 2023 20:51:03 +0000 (09:51 +1300)]
Deprecations for delete on ACL entities

23 months agoMerge pull request #25688 from eileenmcnaughton/dep_test
Seamus Lee [Tue, 28 Feb 2023 20:10:29 +0000 (07:10 +1100)]
Merge pull request #25688 from eileenmcnaughton/dep_test

Remove deprecated functions from tests

23 months agoRemove deprecated functions from tests
Eileen McNaughton [Tue, 28 Feb 2023 18:48:22 +0000 (07:48 +1300)]
Remove deprecated functions from tests

23 months agoMerge pull request #25686 from eileenmcnaughton/dep_2020_address
Eileen McNaughton [Tue, 28 Feb 2023 06:02:16 +0000 (19:02 +1300)]
Merge pull request #25686 from eileenmcnaughton/dep_2020_address

Remove 2020-deprecated handling of `legacyAddressCreate`

23 months agoMerge pull request #25685 from eileenmcnaughton/dep_2020
Yashodha Chaku [Tue, 28 Feb 2023 03:16:00 +0000 (08:46 +0530)]
Merge pull request #25685 from eileenmcnaughton/dep_2020

Remove function noisily deprecated when the world was young (2020)

23 months agoMerge pull request #25684 from eileenmcnaughton/address_delete
Yashodha Chaku [Tue, 28 Feb 2023 03:14:00 +0000 (08:44 +0530)]
Merge pull request #25684 from eileenmcnaughton/address_delete

Remove deprecated function call

23 months agoMerge pull request #25646 from colemanw/fixSearchDisplayFilter
Eileen McNaughton [Tue, 28 Feb 2023 02:28:15 +0000 (15:28 +1300)]
Merge pull request #25646 from colemanw/fixSearchDisplayFilter

Afform - Filter autocomplete fields belonging to a search display

23 months agoRemove 2020-deprecated handline of legacyAddressCreate
Eileen McNaughton [Tue, 28 Feb 2023 02:24:31 +0000 (15:24 +1300)]
Remove 2020-deprecated handline of legacyAddressCreate

23 months agoRemove function noisily deprecated when the world was young (2020)
Eileen McNaughton [Tue, 28 Feb 2023 02:01:49 +0000 (15:01 +1300)]
Remove function noisily deprecated when the world was young (2020)

23 months agoMerge pull request #25669 from eileenmcnaughton/smarty-syntax
demeritcowboy [Tue, 28 Feb 2023 01:53:40 +0000 (20:53 -0500)]
Merge pull request #25669 from eileenmcnaughton/smarty-syntax

dev/core#4146 Remove (old) Smarty-forward incompatible syntax from Address.tpl

23 months agoMerge pull request #25683 from eileenmcnaughton/logging_dep
demeritcowboy [Tue, 28 Feb 2023 01:34:09 +0000 (20:34 -0500)]
Merge pull request #25683 from eileenmcnaughton/logging_dep

Add gentle deprecation to `debug_log_message`

23 months agoMerge pull request #25682 from eileenmcnaughton/log_smarty
demeritcowboy [Tue, 28 Feb 2023 01:25:34 +0000 (20:25 -0500)]
Merge pull request #25682 from eileenmcnaughton/log_smarty

Log Smarty debug to it's own channel

23 months agoMerge pull request #25680 from eileenmcnaughton/smarty-bank
demeritcowboy [Tue, 28 Feb 2023 01:05:03 +0000 (20:05 -0500)]
Merge pull request #25680 from eileenmcnaughton/smarty-bank

Smarty notice fix on bank_account_number

23 months agoRemove deprecated function call
Eileen McNaughton [Tue, 28 Feb 2023 00:54:38 +0000 (13:54 +1300)]
Remove deprecated function call

23 months agoMerge pull request #25678 from eileenmcnaughton/logging-ref
Eileen McNaughton [Tue, 28 Feb 2023 00:50:13 +0000 (13:50 +1300)]
Merge pull request #25678 from eileenmcnaughton/logging-ref

Remove unnecessary pass-by-reference

23 months agoAdd gentle deprecation to debug_log_message
Eileen McNaughton [Tue, 28 Feb 2023 00:47:52 +0000 (13:47 +1300)]
Add gentle deprecation to debug_log_message

23 months agoMerge pull request #25679 from eileenmcnaughton/deprecated_mem_type
colemanw [Tue, 28 Feb 2023 00:47:11 +0000 (19:47 -0500)]
Merge pull request #25679 from eileenmcnaughton/deprecated_mem_type

Remove code deprecated in 2018

23 months agoLog Smarty debug to it's own channel
Eileen McNaughton [Tue, 28 Feb 2023 00:36:47 +0000 (13:36 +1300)]
Log Smarty debug to it's own channel

I just wrote the docs on the right way to log using this example
https://docs.civicrm.org/dev/en/latest/framework/logging/

- so we should make it the same. I tested locally
& this results in the smarty debugging going to a separate file (good).

I personally think we should send all the IPN files off to their
own channel but am loath to be pro-active on changing that

23 months agoSmarty notice fix on bank_account_number
Eileen McNaughton [Mon, 27 Feb 2023 23:48:33 +0000 (12:48 +1300)]
Smarty notice fix on bank_account_number

23 months agoAlso remove CRM_Utils_Array call
Eileen McNaughton [Mon, 27 Feb 2023 23:23:23 +0000 (12:23 +1300)]
Also remove CRM_Utils_Array call

23 months agoRemove code deprecated in 2018
Eileen McNaughton [Mon, 27 Feb 2023 23:19:50 +0000 (12:19 +1300)]
Remove code deprecated in 2018

23 months agoMake function private
Eileen McNaughton [Mon, 27 Feb 2023 23:04:19 +0000 (12:04 +1300)]
Make function private

23 months agoRemove unnecessary pass-by-reference
Eileen McNaughton [Mon, 27 Feb 2023 23:01:52 +0000 (12:01 +1300)]
Remove unnecessary pass-by-reference

23 months agoMerge pull request #25675 from eileenmcnaughton/notice_location
demeritcowboy [Mon, 27 Feb 2023 21:44:16 +0000 (16:44 -0500)]
Merge pull request #25675 from eileenmcnaughton/notice_location

Remove empty on location - it should always be set now

23 months agoRemove empty on location - it should always be set now
Eileen McNaughton [Mon, 27 Feb 2023 19:56:51 +0000 (08:56 +1300)]
Remove empty on location - it should always be set now

See https://github.com/civicrm/civicrm-core/pull/25668

23 months agoMerge pull request #25618 from mattwire/caserelationship
colemanw [Mon, 27 Feb 2023 15:34:25 +0000 (10:34 -0500)]
Merge pull request #25618 from mattwire/caserelationship

Afform: Allow selecting case for relationship

23 months agoMerge pull request #25668 from eileenmcnaughton/notice_location
demeritcowboy [Mon, 27 Feb 2023 13:47:30 +0000 (08:47 -0500)]
Merge pull request #25668 from eileenmcnaughton/notice_location

Fix e-notice pattern around location not defined in formButtons.tpl

23 months agoMerge pull request #25309 from MegaphoneJon/flexmailer-return-path
demeritcowboy [Mon, 27 Feb 2023 13:44:36 +0000 (08:44 -0500)]
Merge pull request #25309 from MegaphoneJon/flexmailer-return-path

closes core#4070 - respect default return path

23 months agoMerge pull request #25585 from herbdool/core-4127-4
demeritcowboy [Mon, 27 Feb 2023 13:40:03 +0000 (08:40 -0500)]
Merge pull request #25585 from herbdool/core-4127-4

dev/core#4127 move cms user parameters to userSystem

23 months agoMerge pull request #25671 from colemanw/viewSql
Seamus Lee [Mon, 27 Feb 2023 03:58:11 +0000 (14:58 +1100)]
Merge pull request #25671 from colemanw/viewSql

SearchKit - Clarify how to view SQL output

23 months agoSearchKit - Clarify how to view SQL output
Coleman Watts [Mon, 27 Feb 2023 02:16:27 +0000 (21:16 -0500)]
SearchKit - Clarify how to view SQL output

23 months agoMerge pull request #25670 from eileenmcnaughton/cust_it
Seamus Lee [Sun, 26 Feb 2023 21:24:29 +0000 (08:24 +1100)]
Merge pull request #25670 from eileenmcnaughton/cust_it

Remove unused variables

23 months agoRemove unused variables
Eileen McNaughton [Tue, 7 Feb 2023 01:58:54 +0000 (14:58 +1300)]
Remove unused variables

23 months agoMerge pull request #25466 from eileenmcnaughton/sep
colemanw [Sun, 26 Feb 2023 02:42:48 +0000 (21:42 -0500)]
Merge pull request #25466 from eileenmcnaughton/sep

Remove unused property - not used since import code refactor `_lineCount`

23 months agoMerge pull request #25237 from eileenmcnaughton/mem_receipt
colemanw [Sun, 26 Feb 2023 02:41:42 +0000 (21:41 -0500)]
Merge pull request #25237 from eileenmcnaughton/mem_receipt

Remove conditional assignment around `is_deductible`

23 months agoMerge pull request #25621 from eileenmcnaughton/event_test_cleanup
colemanw [Sun, 26 Feb 2023 02:40:17 +0000 (21:40 -0500)]
Merge pull request #25621 from eileenmcnaughton/event_test_cleanup

Event test cleanup, fix test to use submitted form values, rather than require a lot of contorting

23 months agoMerge pull request #25270 from eileenmcnaughton/separate
colemanw [Sun, 26 Feb 2023 02:39:39 +0000 (21:39 -0500)]
Merge pull request #25270 from eileenmcnaughton/separate

Extend testing for ContributionConfirm & consolidate `isSeparateMembershipPayment`

23 months agoMerge pull request #25667 from eileenmcnaughton/mixin
Tim Otten [Sat, 25 Feb 2023 04:46:58 +0000 (20:46 -0800)]
Merge pull request #25667 from eileenmcnaughton/mixin

Fix mixin to use `addTemplateDir`

23 months agoRemove (old) Smarty-forward incompatible syntax from Address.tpl
Eileen McNaughton [Fri, 24 Feb 2023 22:54:41 +0000 (11:54 +1300)]
Remove (old) Smarty-forward incompatible syntax from Address.tpl

23 months agoFix e-notice pattern around location not defined in formButtons.tpl
Eileen McNaughton [Fri, 24 Feb 2023 21:19:08 +0000 (10:19 +1300)]
Fix e-notice pattern around location not defined in formButtons.tpl

23 months agoFix mixin
Eileen McNaughton [Fri, 24 Feb 2023 07:36:50 +0000 (20:36 +1300)]
Fix mixin

23 months agoMerge pull request #25662 from eileenmcnaughton/token_dep
demeritcowboy [Fri, 24 Feb 2023 19:02:25 +0000 (14:02 -0500)]
Merge pull request #25662 from eileenmcnaughton/token_dep

Add noisy deprecation to deprecated function, after universe search