Kurund Jalmi [Tue, 24 May 2022 10:26:00 +0000 (11:26 +0100)]
show honor roll only if it's enabled for the PCP page for contribution
confirm, thank you and email receipt
Eileen McNaughton [Tue, 24 May 2022 10:06:00 +0000 (22:06 +1200)]
Merge pull request #23555 from civicrm/5.50
5.50
Monish Deb [Tue, 24 May 2022 07:01:00 +0000 (12:31 +0530)]
Merge pull request #23551 from eileenmcnaughton/import_no_go
Remove unreachable code
Monish Deb [Tue, 24 May 2022 06:05:46 +0000 (11:35 +0530)]
Merge pull request #23535 from eileenmcnaughton/import_prefix
Extend import option handling to prefix, suffix, language, communication_style
Eileen McNaughton [Mon, 23 May 2022 23:21:19 +0000 (11:21 +1200)]
Remove unreachable code
Seamus Lee [Tue, 24 May 2022 02:23:01 +0000 (12:23 +1000)]
Merge pull request #23528 from eileenmcnaughton/raw_money
Fix empty money handling
Seamus Lee [Tue, 24 May 2022 02:20:48 +0000 (12:20 +1000)]
Merge pull request #23550 from eileenmcnaughton/import_cust
Clean up function signature
colemanw [Mon, 23 May 2022 23:16:23 +0000 (19:16 -0400)]
Merge pull request #23532 from eileenmcnaughton/import_depo
Remove extraneous deprecated check
Eileen McNaughton [Sat, 21 May 2022 04:08:52 +0000 (16:08 +1200)]
Extend import option handling to prefix, suffix, language, communication_style
This extends a pattern thoroughly tested for gender to
other single-option-value fields & removes duplicate handling.
Test cover in
`CRM_Contact_Import_Parser_ContactTest::testPrefixLabel`
`CRM_Contact_Import_Parser_ContactTest::testPreferredLanguageImport`
Eileen McNaughton [Mon, 23 May 2022 21:03:08 +0000 (09:03 +1200)]
Clean up function signature
colemanw [Mon, 23 May 2022 20:50:06 +0000 (16:50 -0400)]
Merge pull request #23533 from eileenmcnaughton/import_if
Remove always true if conditions (whitespace in next commit)
colemanw [Mon, 23 May 2022 20:49:38 +0000 (16:49 -0400)]
Merge pull request #23515 from eileenmcnaughton/no_prof
[REF] Simplify contact.create
colemanw [Mon, 23 May 2022 20:47:22 +0000 (16:47 -0400)]
Merge pull request #23545 from eileenmcnaughton/import_location2
Remove never-true fields, and impossible property handling from previously shared function
colemanw [Mon, 23 May 2022 20:46:39 +0000 (16:46 -0400)]
Merge pull request #23488 from colemanw/afformGetHook
Afform - dispatch event when loading afforms
colemanw [Mon, 23 May 2022 20:45:36 +0000 (16:45 -0400)]
Merge pull request #23536 from eileenmcnaughton/import_cust
[REF] Minor simplification on input
colemanw [Mon, 23 May 2022 20:44:54 +0000 (16:44 -0400)]
Merge pull request #23537 from eileenmcnaughton/greet_cust
Greeting handling - if email_greeting_custom (etc) isset & email_greeting_id is not, set to 'Customized'
colemanw [Mon, 23 May 2022 20:43:55 +0000 (16:43 -0400)]
Merge pull request #23540 from eileenmcnaughton/import_location
Add location import testing
colemanw [Mon, 23 May 2022 20:43:23 +0000 (16:43 -0400)]
Merge pull request #23538 from eileenmcnaughton/import_regression
Fix unreleased regression from strict typing
Eileen McNaughton [Mon, 23 May 2022 19:37:55 +0000 (07:37 +1200)]
Merge pull request #22682 from agileware/CIVICRM-1922
🪳🪳🪳 Bug Fix: Merging an Organisation contact and de-selecting the merge Membership checkbox causes all related Membership to not be removed and the Primary Membership is linked to the deleted Organisation
Eileen McNaughton [Mon, 23 May 2022 19:33:17 +0000 (07:33 +1200)]
Merge pull request #22487 from mattwire/repeattransactiontemplatecontribution
dev/financial#6 Use template contribution for Contribution.repeattransaction
demeritcowboy [Mon, 23 May 2022 17:09:23 +0000 (13:09 -0400)]
Merge pull request #23467 from christianwach/event-caps
Capitalise event setting title
Yashodha Chaku [Mon, 23 May 2022 17:06:10 +0000 (22:36 +0530)]
Merge pull request #23541 from eileenmcnaughton/import_provider
E-notice fix on import
Christian Wach [Mon, 23 May 2022 14:50:42 +0000 (15:50 +0100)]
Capitalise event setting title
Eileen McNaughton [Sun, 22 May 2022 01:26:40 +0000 (13:26 +1200)]
Remove never-true fields, and impossible property handling from previously shared function
colemanw [Mon, 23 May 2022 03:37:03 +0000 (23:37 -0400)]
Merge pull request #23542 from eileenmcnaughton/import_location2
Duplicate function - divide & conquer
colemanw [Sun, 22 May 2022 18:00:49 +0000 (14:00 -0400)]
Merge pull request #23544 from colemanw/revertPost
Revert "SearchKit - Use POST to send contact ids to action forms"
Coleman Watts [Sun, 22 May 2022 17:59:27 +0000 (13:59 -0400)]
Revert "SearchKit - Use POST to send contact ids to action forms"
This reverts commit
1297a574fd3e28d4714c145627b35c08e5933675.
Eileen McNaughton [Sun, 22 May 2022 01:11:58 +0000 (13:11 +1200)]
Duplicate function - divide & conquer
Eileen McNaughton [Sun, 22 May 2022 00:11:28 +0000 (12:11 +1200)]
Add location import testing
Eileen McNaughton [Sun, 22 May 2022 01:12:12 +0000 (13:12 +1200)]
E-notice fix
Eileen McNaughton [Sat, 21 May 2022 19:59:56 +0000 (07:59 +1200)]
Merge pull request #23539 from demeritcowboy/huh
[NFC] Remove weird file
demeritcowboy [Sat, 21 May 2022 14:02:21 +0000 (10:02 -0400)]
weird file
colemanw [Sat, 21 May 2022 13:52:20 +0000 (09:52 -0400)]
Merge pull request #23404 from colemanw/getFieldsFilters
SearchKit - Make inline edit only available when applicable
Eileen McNaughton [Sat, 21 May 2022 09:29:02 +0000 (21:29 +1200)]
Fix unreleased regression from strict typing
Eileen McNaughton [Sat, 21 May 2022 07:08:40 +0000 (19:08 +1200)]
[REF] Minor simplification on input
Eileen McNaughton [Sat, 21 May 2022 06:00:57 +0000 (18:00 +1200)]
Greeting handling - if email_greeting_custom (etc) isset & email_greeting_id is not, set to 'Customized'
Eileen McNaughton [Sat, 21 May 2022 03:49:52 +0000 (15:49 +1200)]
Merge pull request #23502 from eileenmcnaughton/import_test_ex
Add unit tests to cover date field imports
Coleman Watts [Thu, 19 May 2022 00:01:52 +0000 (20:01 -0400)]
APIv4 GetFields - Ignore invalid fields rather than fatal error in getFields action
Coleman Watts [Mon, 9 May 2022 00:45:21 +0000 (20:45 -0400)]
SearchKit - ensure only relevant fields are editable
Fixes dev/core#3423
Ensures that custom fields for one entity sub-type (e.g. Individual) are not
presented as editable for other sub-types (e.g. Organiztion).
Eileen McNaughton [Sat, 21 May 2022 00:51:07 +0000 (12:51 +1200)]
Remove always true if conditions (whitespace in next commit)
Eileen McNaughton [Sat, 21 May 2022 00:49:44 +0000 (12:49 +1200)]
Merge pull request #23531 from eileenmcnaughton/import_goned
[Import] Remove empty if
Eileen McNaughton [Sat, 21 May 2022 00:37:44 +0000 (12:37 +1200)]
Merge pull request #23530 from eileenmcnaughton/import_gone
Remove always-true if-check
Eileen McNaughton [Sat, 21 May 2022 00:37:31 +0000 (12:37 +1200)]
Merge pull request #23496 from colemanw/fixCustomGroupJoinable
SearchKit - Fix in-place editing custom relationship fields
Eileen McNaughton [Fri, 20 May 2022 09:27:08 +0000 (21:27 +1200)]
Switch now-tested birth & deceased date handling to be metadata based
Eileen McNaughton [Thu, 19 May 2022 06:23:37 +0000 (18:23 +1200)]
Add unit tests to cover date field imports
Eileen McNaughton [Fri, 20 May 2022 21:17:01 +0000 (09:17 +1200)]
[REF] Minor simplification on input
colemanw [Fri, 20 May 2022 23:32:05 +0000 (19:32 -0400)]
Merge pull request #23509 from eileenmcnaughton/import_except
[Import] Remove handling for unavailable field current_employer
Eileen McNaughton [Fri, 20 May 2022 20:43:42 +0000 (08:43 +1200)]
Fix empty money handling
Eileen McNaughton [Fri, 20 May 2022 22:27:42 +0000 (10:27 +1200)]
Remove extraneous deprecated check
Eileen McNaughton [Fri, 20 May 2022 22:21:22 +0000 (10:21 +1200)]
[Import] Remove empty if
Eileen McNaughton [Fri, 20 May 2022 22:18:20 +0000 (10:18 +1200)]
Remove always-true if-check
colemanw [Fri, 20 May 2022 21:38:35 +0000 (17:38 -0400)]
Merge pull request #23508 from eileenmcnaughton/import_subkid
[Import] Fix & test check on contact subtype change
colemanw [Fri, 20 May 2022 21:38:17 +0000 (17:38 -0400)]
Merge pull request #23526 from eileenmcnaughton/import_sub
[Import] Check subtype validity in validate rather than wait for 'imort'
Coleman Watts [Thu, 19 May 2022 02:16:15 +0000 (22:16 -0400)]
SearchKit - Fix in-place editing custom relationship fields for related contacts
Before: In-place edit updates the wrong record for custom relationship fields
After: Fixed
Eileen McNaughton [Fri, 20 May 2022 20:51:59 +0000 (08:51 +1200)]
Merge pull request #23525 from aydun/yesno
Fixes dev/core#3475 - Allow 'yesno' as a valid value of `html_type`
Eileen McNaughton [Fri, 20 May 2022 20:50:41 +0000 (08:50 +1200)]
Merge pull request #23331 from colemanw/post
SearchKit - Use POST to send contact ids to action forms
Eileen McNaughton [Wed, 18 May 2022 23:28:32 +0000 (11:28 +1200)]
[Import] Check subtype validity in validate rather than wait for 'import', test
Aidan Saunders [Fri, 20 May 2022 18:47:27 +0000 (19:47 +0100)]
Fixes dev/core#3475 - Allow 'yesno' as a valid value of `html_type`I
Yashodha Chaku [Fri, 20 May 2022 14:27:08 +0000 (19:57 +0530)]
Merge pull request #23521 from eileenmcnaughton/dead
Ensure setting deceased date sets is_deceased in the BAO
demeritcowboy [Fri, 20 May 2022 13:29:25 +0000 (09:29 -0400)]
Merge pull request #23524 from mattwire/contributiontestfixes
Payment forms test fixes
demeritcowboy [Fri, 20 May 2022 11:25:05 +0000 (07:25 -0400)]
Merge pull request #23523 from eileenmcnaughton/import_little
Re-use code in test
Matthew Wire [Tue, 22 Mar 2022 18:57:39 +0000 (18:57 +0000)]
Build form properly for CRM_Financial_Form_PaymentEditTest::testSubmitOnCheckNumberChange
Matthew Wire [Mon, 21 Mar 2022 14:31:57 +0000 (14:31 +0000)]
Build form properly for PaymentEditTest::testSubmitOnPaymentInstrumentChange
Matthew Wire [Mon, 21 Mar 2022 14:30:46 +0000 (14:30 +0000)]
Build form properly for FinancialItemTest::testGetPreviousFinancialItemHavingTax
Eileen McNaughton [Fri, 20 May 2022 09:11:10 +0000 (21:11 +1200)]
Re-use code in test
Tim Otten [Fri, 20 May 2022 08:16:16 +0000 (01:16 -0700)]
Merge pull request #23518 from eileenmcnaughton/import_meta
[REF] Move list of fields that have been upgraded
Eileen McNaughton [Fri, 20 May 2022 07:48:07 +0000 (19:48 +1200)]
Ensure setting deceased date sets is_deceased in the BAO
Seamus Lee [Fri, 20 May 2022 05:11:09 +0000 (15:11 +1000)]
Merge pull request #23517 from eileenmcnaughton/import_comments
[NFC] Improve comment blocks for mapper
Eileen McNaughton [Fri, 20 May 2022 03:39:43 +0000 (15:39 +1200)]
[REF] Move list of fields that have been upgraded
Eileen McNaughton [Thu, 19 May 2022 22:17:56 +0000 (10:17 +1200)]
Improve comment blocks for mapper
colemanw [Fri, 20 May 2022 01:36:51 +0000 (21:36 -0400)]
Merge pull request #23511 from eileenmcnaughton/import_unused
[Ref] [Import] Cleanup function return
colemanw [Fri, 20 May 2022 01:34:14 +0000 (21:34 -0400)]
Merge pull request #23498 from eileenmcnaughton/import_cust_extract
Ref Extract import validation
Seamus Lee [Fri, 20 May 2022 01:18:13 +0000 (11:18 +1000)]
Merge pull request #23512 from eileenmcnaughton/part_count
Cleanup sql query
Eileen McNaughton [Fri, 20 May 2022 01:14:51 +0000 (13:14 +1200)]
[REF] Simplify contact.create
colemanw [Fri, 20 May 2022 01:11:42 +0000 (21:11 -0400)]
Merge pull request #23504 from eileenmcnaughton/import_replace
[Import] Remove svn whimsy - DUPLICATE_REPLACE
Tim Otten [Fri, 20 May 2022 00:04:50 +0000 (17:04 -0700)]
Merge pull request #23499 from totten/master-cdesc
(dev/core#3436) MultipleRecordFieldsListing.tpl - JS strings should us JS escaping
Tim Otten [Fri, 20 May 2022 00:00:17 +0000 (17:00 -0700)]
Merge pull request #23501 from eileenmcnaughton/import_json
Fix use of not-universally supported mysql field type
Eileen McNaughton [Thu, 19 May 2022 23:20:33 +0000 (11:20 +1200)]
Merge pull request #23510 from yashodha/ckeditor_issue_5
fix to get around link issues in ckeditor when opening scheduled remi…
Eileen McNaughton [Thu, 19 May 2022 23:07:30 +0000 (11:07 +1200)]
Cleanup sql query
On digging into this query I found that is uses protected words like value & count
so I have fixed the query to no longer use those & re-formatted to add comments.
I suspect the actual fix might need to sit around pending community input so I think it is good to
get this tidy up merged to make it all clearer
Tim Otten [Thu, 19 May 2022 04:50:15 +0000 (21:50 -0700)]
MultipleRecordFieldsListing.tpl - JS strings should us JS escaping
Eileen McNaughton [Thu, 19 May 2022 20:36:12 +0000 (08:36 +1200)]
[Ref] [Import] Cleanup function return
yashodha [Thu, 19 May 2022 15:52:09 +0000 (21:22 +0530)]
fix to get around link issues in ckeditor when opening scheduled reminder in popup
colemanw [Thu, 19 May 2022 14:40:51 +0000 (10:40 -0400)]
Merge pull request #23507 from eileenmcnaughton/import_match2
[REF] Remove unreachable code
demeritcowboy [Thu, 19 May 2022 14:21:20 +0000 (10:21 -0400)]
Merge pull request #23495 from eileenmcnaughton/import_unused
[REF] [Import] Remove unused parameter
colemanw [Thu, 19 May 2022 13:35:35 +0000 (09:35 -0400)]
Merge pull request #23493 from eileenmcnaughton/import_rel
[Import] Remove silly param
Eileen McNaughton [Thu, 19 May 2022 11:18:58 +0000 (23:18 +1200)]
[Import] Remove handling for unavailable field current_employer
Eileen McNaughton [Thu, 19 May 2022 00:19:25 +0000 (12:19 +1200)]
[Import] Fix & test check on contact subtype change
Eileen McNaughton [Thu, 19 May 2022 09:30:12 +0000 (21:30 +1200)]
[REF] Remove unreachable code
Eileen McNaughton [Thu, 19 May 2022 08:42:35 +0000 (20:42 +1200)]
[Import] Remove svn whimsy - DUPLICATE_REPLACE
Eileen McNaughton [Thu, 19 May 2022 06:23:37 +0000 (18:23 +1200)]
Add unit tests to cover date field imports
Eileen McNaughton [Thu, 19 May 2022 06:42:06 +0000 (18:42 +1200)]
Fix use of not-universally supported mysql field type
Eileen McNaughton [Thu, 19 May 2022 05:29:20 +0000 (17:29 +1200)]
Merge pull request #23500 from civicrm/5.50
5.50 to master
Eileen McNaughton [Thu, 19 May 2022 05:28:44 +0000 (17:28 +1200)]
Merge pull request #23497 from totten/5.50-schedrem-bool
Restore `civicrm_action_schedule.limit_to` (5.50)
Eileen McNaughton [Thu, 19 May 2022 01:49:50 +0000 (13:49 +1200)]
[Import] Remove silly param
Eileen McNaughton [Thu, 19 May 2022 04:58:25 +0000 (16:58 +1200)]
Merge pull request #23494 from eileenmcnaughton/import_if
[Import] Remove `if (1) {` (whitespace intensive)
Eileen McNaughton [Thu, 19 May 2022 02:40:14 +0000 (14:40 +1200)]
Ref Extract import validation
Eileen McNaughton [Thu, 19 May 2022 03:35:18 +0000 (15:35 +1200)]
Merge pull request #23492 from totten/master-silly-method
(REF) CRM_Upgrade_Form - Remove silly method `runQuery`
Tim Otten [Thu, 19 May 2022 02:32:46 +0000 (19:32 -0700)]
FiveFortyNine - Tweak task title
Tim Otten [Wed, 18 May 2022 23:33:37 +0000 (16:33 -0700)]
FiveFortyNine - Revise message about "limit to"
1. This fixes a problem where the message shows at the opposite-of-correct time
(ie it should display on builds that have already run 5.49.{beta,0,1}, but
it actually displayed on builds that have not run 5.49.{beta,0,1})
2. This makes the pre+post messages match.
Tim Otten [Wed, 18 May 2022 22:02:12 +0000 (15:02 -0700)]
FiveFortyNine - Don't munge soft credit 'limit-to'
I'm not sure what it even means to limit a scheduled-reminder to a "soft_credit_type".
But it's a thing - I can use the 5.48 GUI to create it. Here's how it looks in the DB (in 5.48):
+----+------------------------------------------+------------------+----------+------------------+-------------------+----------+
| id | title | recipient | limit_to | recipient_manual | recipient_listing | group_id |
+----+------------------------------------------+------------------+----------+------------------+-------------------+----------+
| 11 | Limit To - Soft Credit | soft_credit_type | 1 | NULL | in_memory_of | NULL |
+----+------------------------------------------+------------------+----------+------------------+-------------------+----------+
The `changeBooleanColumnLimitTo()` was coercing down to `limit_to=null` because it lacked `recipient_manual` and `group_id`.