Tim Otten [Tue, 8 Sep 2015 01:30:23 +0000 (18:30 -0700)]
CRM-16373 - CRM_Admin_Form_Setting_Misc - Don't save through ConfigSetting::add()
Tim Otten [Tue, 8 Sep 2015 01:09:25 +0000 (18:09 -0700)]
CRM-16373 - Migrate Map/Geocode settings
Tim Otten [Sun, 6 Sep 2015 01:01:18 +0000 (18:01 -0700)]
CRM-16373 - Localization - Save through settings instead of domain
Tim Otten [Mon, 7 Sep 2015 23:54:56 +0000 (16:54 -0700)]
ConfigSetting::fixParams - Remove legacy handling for countryLimit, provinceLimit, defaultContactCountry
This appears to be migration logic for handling a change in the format of
select config fields. The migration logic appears to originate before v3.0.
Since we're only supporting upgrades from v4.0+, there's no point in keeping
it.
Tim Otten [Mon, 7 Sep 2015 23:39:23 +0000 (16:39 -0700)]
CRM_Core_BAO_ConfigSetting::formatParams - Remove silly function
This function is basically just array_merge().
In theory, there's a side-effect where NULL values in `$values` are unset,
but neither use-case seems to make any use of `$values` afterward, and that
smells like an accidental side-effect anyway.
Tim Otten [Sat, 5 Sep 2015 19:23:13 +0000 (12:23 -0700)]
CRM-16373 - Mailer settings - Remove reliance on CRM_Core_BAO_ConfigSetting::create
Tim Otten [Fri, 28 Aug 2015 02:29:24 +0000 (19:29 -0700)]
CRM-16373, CRM-14349 - Config - Disintermediate localeCustomStrings
localeCustomStrings has a pretty w.e.i.r.d. lifecycle (involving table `civicrm_word_replacements`
and column `civicrm_domain.locale_cusotm_Strings`). This commit does not unweird it, but the
weirdness no longer involves special-case logic on `CRM_Core_Config*` -- all the weirdness is
concentrated in `CRM_Core_BAO_WordReplacements` and `CRM_Admin_Form_WordReplacements`.
Tim Otten [Thu, 27 Aug 2015 23:03:54 +0000 (16:03 -0700)]
CRM-16373 - Simplify loading of enableComponents
Tim Otten [Thu, 27 Aug 2015 23:01:08 +0000 (16:01 -0700)]
CRM_Core_BAO_Setting::dao() - Don't filter on group, but do save a blank group.
Tim Otten [Sun, 23 Aug 2015 17:03:44 +0000 (10:03 -0700)]
CRM-16373 - Save URLs and paths through settings instead of domain
Tim Otten [Sun, 23 Aug 2015 22:46:41 +0000 (15:46 -0700)]
civicrm_api3_setting_getvalue - Skip $config. Use settings.
Tim Otten [Sun, 23 Aug 2015 17:01:38 +0000 (10:01 -0700)]
(Directory,Url).setting.php - Tweaks
Tim Otten [Sun, 23 Aug 2015 16:05:55 +0000 (09:05 -0700)]
CRM_Core_BAO_Preferences - Remove unused file/class/functions
Tim Otten [Sun, 23 Aug 2015 15:58:33 +0000 (08:58 -0700)]
CRM-16373 - CRM_Core_Config_Defaults - Split setValues() into pieces
The major pieces:
* `userSystem->getDefaultFileStorage`
* `userSystem->getCiviSourceStorage`
* `getCustomFileUploadDir`, `getCustomPhpPathDir`, `getImageUploadDir`, etc
Tim Otten [Sun, 23 Aug 2015 15:58:01 +0000 (08:58 -0700)]
CRM_Utils_Geocode - Read settings instead of config
Tim Otten [Sun, 23 Aug 2015 09:43:12 +0000 (02:43 -0700)]
CRM-16373 - SettingsBag - Add getUrl/getPath/setUrl/setPath
Tim Otten [Sun, 23 Aug 2015 08:38:35 +0000 (01:38 -0700)]
CRM-16373 - CRM_Core_Config - Simplify initialization, esp `templateCompileDir`
Generally, this commit removes some silly 1-line functions, misplaed
functions, duplicated steps, obvious comments, and expired comments.
There is a change in `templateCompileDir`.
The `templateCompileDir` had two different intialization blocks (in
different places), which likely arose from variations in the code-paths used
for memcache systems. Both routines append a locale and create the dir.
This is redundant, and it unnecessarily forces us to resolve the locale
early during initialization. But honestly we don't need to append the
locale until much later (when/if Smarty is first used).
There are a few oddballs who use `$config->templateCompileDir` and they may
see a slight change (working with the real templateCompileDir rather than
the locale subdir):
* The cleanup. If this code causes a change, it will be an improvement:
instead of cleaning the Smarty cache for one locale, it'll clean the
entire Smarty cache for all locales.
* Random temp files. The temp files seem to be transactional in nature
(tied to the specific invocatoin) and not to the locale.
Tim Otten [Sat, 22 Aug 2015 11:29:06 +0000 (04:29 -0700)]
CRM-16373 - Config - Migrate `userFrameworkUsersTableName` to settings
There was some code to initialize this field on Joomla and WordPress, but it
appears to be pointless -- the value is only used within the Drupal UF.
More generally, this is a good thing - we should use CMS API's rather than
peeking into their schema.
Tim Otten [Sat, 22 Aug 2015 10:42:07 +0000 (03:42 -0700)]
CRM-16373 - Config - Remove `userFrameworkVersion`
This is only very rarely used -- seems silly to look it up on every page
request and to cache it config object.
Tim Otten [Sat, 22 Aug 2015 10:21:14 +0000 (03:21 -0700)]
CRM-16373 - Config - Remove `smartyDir`, `pluginsDir`, and `sqlDir`
Tim Otten [Sat, 22 Aug 2015 10:10:04 +0000 (03:10 -0700)]
CRM-16373 - Config - Remove `componentRegistry`
Tim Otten [Sat, 15 Aug 2015 11:53:59 +0000 (04:53 -0700)]
CRM-16373 - CRM_*_Config - Remove unused component config stuff
This code seems to generate default value for domain.config_backend.
However, the only one which defined any defaults was CiviMail, and that's
now moved over to `settings/`.
Tim Otten [Sat, 15 Aug 2015 11:45:54 +0000 (04:45 -0700)]
CRM-16373 - settings - Declare mailer settings
Conflicts:
settings/Mailing.setting.php
Tim Otten [Sat, 22 Aug 2015 09:45:39 +0000 (02:45 -0700)]
CRM-16373 - Config - Remove `enableComponentIDs`
Note: `enableComponents` is heavily used, but `enableComponentIDs` is only
used once. Generally, it's much easier to write tests based on names
(`enableComponents`) than IDs (`enableComponentIDs`).
Tim Otten [Thu, 23 Jul 2015 02:00:31 +0000 (19:00 -0700)]
CRM-13244 - Civi\Core\Container - Allow hooks to modify container. Cache it.
Conflicts:
composer.json
Tim Otten [Sat, 22 Aug 2015 08:46:25 +0000 (01:46 -0700)]
CRM_Core_BAO_Setting::getItem() - Fix calls which use deprecated parameters. Fix dedupe_email_default conflict.
For `dedupe_email_default`, the default values in `getItem()` and in
`settings/` disagree. The default in `settings/` seems better IMHO.
Tim Otten [Fri, 21 Aug 2015 06:05:18 +0000 (23:05 -0700)]
CRM-11743 - Civi::log() - Add short hand for logging
Tim Otten [Thu, 20 Aug 2015 11:14:04 +0000 (04:14 -0700)]
checksum_timeout - Use consistent naming
This was a weird one:
* The admin form rendered HTML element "checksumTimeout" but saved setting "checksum_timeout", which required workarounds.
* The runtime code read the setting as "checksum_timeout".
* The metadata defined setting "checksumTimeout". `prefetch` is enabled, but there's no `config_key` or `legacy_key`.
I believe this means that the runtime and admin form worked (because they
agreed that the name was "checksum_timeout"), but the Setting API would not
work (because it used "checksumTimeout").
This revision standardizes on "checksum_timeout" on the theory that
"checksum_timeout" was the actual value used at runtime. This means:
* If you had configured the form and had it working correctly, it should
still work correctly.
* If you had a script to set "checksumTimeout" via API, then it wasn't
working before, and it's still not working now.
Tim Otten [Fri, 21 Aug 2015 02:55:37 +0000 (19:55 -0700)]
CRM_Core_BAO_Setting::getItem() - Fix calls which use deprecated parameters
Tim Otten [Thu, 20 Aug 2015 10:51:39 +0000 (03:51 -0700)]
CRM_Core_BAO_Setting::getItem() - Fix calls which use deprecated parameters
Tim Otten [Thu, 20 Aug 2015 07:08:45 +0000 (00:08 -0700)]
CRM_Core_BAO_Setting::getItem() - Fix calls which use deprecated parameters
Tim Otten [Wed, 19 Aug 2015 13:27:43 +0000 (06:27 -0700)]
Civi::settings() - Add short hand for accessing domain settings
Tim Otten [Wed, 19 Aug 2015 13:26:57 +0000 (06:26 -0700)]
\Civi::cache() - Add shorthand for accessing cache.
Tim Otten [Wed, 19 Aug 2015 09:07:49 +0000 (02:07 -0700)]
CRM_Utils_Cache_Interface - Add missing "implements"
Tim Otten [Wed, 19 Aug 2015 06:19:27 +0000 (23:19 -0700)]
\Civi - Use facade instead of Civi\Core\Container::singleton()
Tim Otten [Wed, 19 Aug 2015 06:14:27 +0000 (23:14 -0700)]
\Civi - Add facade accessing system services
Dave Greenberg [Thu, 17 Sep 2015 17:13:33 +0000 (10:13 -0700)]
Merge pull request #6753 from davecivicrm/CRM-17223
CRM-17223 - fix for cvv2 failure.
Eileen McNaughton [Thu, 17 Sep 2015 03:09:55 +0000 (15:09 +1200)]
Merge pull request #6739 from jitendrapurohit/CRM-17205
CRM-17205 -- Fix for broken Free event registration
Eileen McNaughton [Thu, 17 Sep 2015 02:16:54 +0000 (14:16 +1200)]
Merge pull request #6728 from eileenmcnaughton/CRM-14232-add-setting-for-default-lang
CRM-14232 add setting for default contact language.
colemanw [Wed, 16 Sep 2015 12:44:55 +0000 (08:44 -0400)]
Merge pull request #6754 from colemanw/CRM-16555
CRM-16555 - Fix double-processors on backend credit card event form
eileenmcnaugton [Fri, 11 Sep 2015 07:21:23 +0000 (19:21 +1200)]
CRM-14232 add setting for default contact language.
If a contact is created & the preferred_language is not set this
setting can be used to manipulate the default.
Tests!
Conflicts:
settings/Localization.setting.php
CRM-14232 adjust options for default contact language
To reflect bgm suggestions - add current language & remove long-list of countries
CRM-14232 contact default language setting: don't use null as it has special handling
Coleman Watts [Wed, 16 Sep 2015 01:46:46 +0000 (21:46 -0400)]
CRM-16555 - Fix double-processors on backend credit card event form
Coleman Watts [Tue, 15 Sep 2015 21:17:17 +0000 (17:17 -0400)]
Comment fix
Dave Greenberg [Tue, 15 Sep 2015 19:04:59 +0000 (12:04 -0700)]
CRM-17223 - fix for cvv2 failure.
----------------------------------------
* CRM-17223: PayJunction CVV Transactions Fail
https://issues.civicrm.org/jira/browse/CRM-17223
colemanw [Tue, 15 Sep 2015 15:25:01 +0000 (11:25 -0400)]
Merge pull request #6738 from eileenmcnaughton/CRM-17075
CRM-17075 convert membership_type_id field to entity_reference field in search
Monish Deb [Tue, 15 Sep 2015 06:53:09 +0000 (12:23 +0530)]
Merge pull request #6698 from jitendrapurohit/CRM-17169
CRM-17169 - Inconsistent Soft Credit Reporting
Kurund Jalmi [Tue, 15 Sep 2015 06:45:15 +0000 (12:15 +0530)]
Merge pull request #6748 from davidjosephhayes/master
Running the fetch_activities cli task stops with a fatal error when t…
Kurund Jalmi [Tue, 15 Sep 2015 06:22:41 +0000 (11:52 +0530)]
Merge remote-tracking branch 'upstream/4.6' into 4.6-master-2015-09-15-10-14-22
Conflicts:
CRM/Admin/Form/Setting/Localization.php
CRM/Event/BAO/Query.php
CRM/Export/BAO/Export.php
CRM/Financial/Page/AJAX.php
templates/CRM/Event/Form/Registration/Register.tpl
tests/phpunit/CRM/Contribute/BAO/ContributionTest.php
tests/phpunit/api/v3/ContactTest.php
tests/phpunit/api/v3/SyntaxConformanceTest.php
Eileen McNaughton [Tue, 15 Sep 2015 01:25:45 +0000 (13:25 +1200)]
Merge pull request #6727 from eileenmcnaughton/comments
comment fixes
colemanw [Tue, 15 Sep 2015 01:24:45 +0000 (21:24 -0400)]
CRM-17075 - Open entityRef automatically
Eileen McNaughton [Tue, 15 Sep 2015 01:22:15 +0000 (13:22 +1200)]
Merge pull request #6741 from eileenmcnaughton/comments-formatting
Comments formatting
David Hayes [Mon, 14 Sep 2015 21:11:39 +0000 (16:11 -0500)]
remove whitespace at end of line
David Hayes [Mon, 14 Sep 2015 20:29:50 +0000 (15:29 -0500)]
fix formatting
Monish Deb [Mon, 14 Sep 2015 18:47:27 +0000 (00:17 +0530)]
Merge pull request #6745 from monishdeb/testFailures-master
CRM-16941 test failure fix
Dave Greenberg [Mon, 14 Sep 2015 16:48:04 +0000 (09:48 -0700)]
Merge pull request #6735 from davecivicrm/CRM-17207
CRM-17207 - Use mailto link on contact summary when outbound email is…
Dave Greenberg [Mon, 14 Sep 2015 16:32:09 +0000 (09:32 -0700)]
Merge pull request #6744 from seamuslee001/CRM-16584
CRM-16584 Remove line causing fatal error
monishdeb [Mon, 14 Sep 2015 11:51:39 +0000 (17:21 +0530)]
CRM-16941 test failure fix
----------------------------------------
* CRM-16941: Search Form and api.Get fixes for Contact
https://issues.civicrm.org/jira/browse/CRM-16941
jitendrapurohit [Mon, 14 Sep 2015 11:26:21 +0000 (16:56 +0530)]
sql changes
jitendrapurohit [Mon, 7 Sep 2015 12:43:50 +0000 (18:13 +0530)]
CRM-17169 - Inconsistent Soft Credit Reporting
Seamus Lee [Mon, 14 Sep 2015 10:30:33 +0000 (10:30 +0000)]
CRM-16584 Remove line causing fatal error
eileenmcnaugton [Mon, 14 Sep 2015 00:55:24 +0000 (12:55 +1200)]
CRM-17075 switch membership_type_id to use entity reference
This commit also adds generic handling for changing select fields to
entity reference fields with tests to ensure previous smart group
behaviour is respected by handling within the convertFormValues function.
This reverts advanced search domain filtering to ?4.4? 4.5? behaviour which does not assume only that domain's memberships should be searched on.
It make be that domain filtering + allowing an override makes most sense. I did think the pseudoconstant & getoptions use the same
mechanism, but it seems they don't. Really they should both allow the same behaviour & override
eileenmcnaugton [Mon, 14 Sep 2015 00:49:12 +0000 (12:49 +1200)]
CRM-17075 add test to lock in membership_type_id returned for all domains
Until such time as a hook allows overriding of the domain assumptions we should not limit this by domain in advanced search
(which leverages the getoptions via use of an entity reference field
eileenmcnaugton [Mon, 14 Sep 2015 00:12:16 +0000 (12:12 +1200)]
fixes to comments & remove unused vars
comment fixes
eileenmcnaugton [Sun, 13 Sep 2015 23:47:49 +0000 (11:47 +1200)]
minor test formatting tidy ups
Eileen McNaughton [Mon, 14 Sep 2015 08:59:26 +0000 (20:59 +1200)]
Merge pull request #6697 from eileenmcnaughton/CRM-17116-custom-date-search-fields
Crm 17116 custom date search fields
jitendrapurohit [Mon, 14 Sep 2015 07:20:20 +0000 (12:50 +0530)]
CRM-17205 -- Fix for broken Free event registration
David Hayes [Sun, 13 Sep 2015 23:03:30 +0000 (18:03 -0500)]
Running the fetch_activities cli task stops with a fatal error when the incomming mail parser is unable to determine the ezcMailDeliveryStatus. The fetch_activities task will continue to download and attempt to parse the offending email, dying every time. This prevents other mails from being downloaded and parsed.
Error Message: "No clue about the ezcMailDeliveryStatus"
This patch catches that error, prints it, marks the offending email ignored, and allows activities processing to continue.
colemanw [Sun, 13 Sep 2015 19:09:34 +0000 (15:09 -0400)]
Merge pull request #6734 from colemanw/CRM-17186
CRM-17186 - Add ts tags & normalize strings for paypal button
Eileen McNaughton [Sun, 13 Sep 2015 14:56:59 +0000 (02:56 +1200)]
Merge pull request #6737 from eileenmcnaughton/test
fix date format in test
eileenmcnaugton [Sun, 13 Sep 2015 14:56:18 +0000 (02:56 +1200)]
fix date format in test
Dave Greenberg [Sat, 12 Sep 2015 00:24:26 +0000 (17:24 -0700)]
CRM-17207 - Use mailto link on contact summary when outbound email is disabled.
----------------------------------------
* CRM-17207: Use mailto link on contact summary emails if outbound email is disabled
https://issues.civicrm.org/jira/browse/CRM-17207
Dave Greenberg [Fri, 11 Sep 2015 20:39:13 +0000 (13:39 -0700)]
Merge pull request #6711 from pradpnayak/CRM-16904
CRM-16904, updated 4th parameter to use base url
Dave Greenberg [Fri, 11 Sep 2015 20:34:13 +0000 (13:34 -0700)]
Merge pull request #6638 from pradpnayak/CRM-16542-PaypalExp
--CRM-16542, fixed code for form rule for Paypal Express
Coleman Watts [Fri, 11 Sep 2015 20:27:44 +0000 (16:27 -0400)]
CRM-17186 - Add ts tags & normalize strings for paypal button
colemanw [Fri, 11 Sep 2015 20:12:04 +0000 (16:12 -0400)]
Merge pull request #6607 from guanhuan/update-event-templates
Add crm-public-form-item class to event forms
Dave Greenberg [Fri, 11 Sep 2015 19:19:42 +0000 (12:19 -0700)]
Merge pull request #6731 from pradpnayak/CRM-17208
CRM-17208, moved $params before pre hook so that it can be altered in…
Dave Greenberg [Fri, 11 Sep 2015 19:12:52 +0000 (12:12 -0700)]
Merge pull request #6730 from monishdeb/migrate-onBehalf-master
CRM-16941 fix - Search Form and api.Get fixes for Contact
Monish Deb [Fri, 11 Sep 2015 18:51:28 +0000 (00:21 +0530)]
Merge pull request #6729 from jitendrapurohit/apitestfix
Test fix for CRM-13160
Pradeep Nayak [Fri, 11 Sep 2015 14:29:23 +0000 (19:59 +0530)]
CRM-17208, moved $params before pre hook so that it can be altered in pre hook
----------------------------------------
* CRM-17208: Allow $params to be changed in pre hook
https://issues.civicrm.org/jira/browse/CRM-17208
Monish Deb [Fri, 11 Sep 2015 13:39:21 +0000 (19:09 +0530)]
Merge pull request #6726 from jitendrapurohit/CRM-17206
Fix Country => State hierarachical select broken in 4.7 branch
monishdeb [Fri, 11 Sep 2015 13:37:36 +0000 (19:07 +0530)]
CRM-16941 fix - Search Form and api.Get fixes for Contact
https://issues.civicrm.org/jira/browse/CRM-16941
jitendrapurohit [Fri, 11 Sep 2015 13:29:51 +0000 (18:59 +0530)]
added comment
jitendrapurohit [Fri, 11 Sep 2015 13:17:33 +0000 (18:47 +0530)]
test fix for CRM-13160
Kurund Jalmi [Fri, 11 Sep 2015 09:38:58 +0000 (15:08 +0530)]
Merge pull request #6672 from monishdeb/migrate-onBehalf-master
CRM-16873: Migrate on behalf master to profileContact
Yashodha Chaku [Fri, 11 Sep 2015 08:46:13 +0000 (14:16 +0530)]
Merge pull request #6720 from yashodha/CRM-17015
CRM-17015: “Sold out” error message when registering event with PayPal …
eileenmcnaugton [Fri, 11 Sep 2015 07:23:30 +0000 (19:23 +1200)]
comment fixes
Eileen McNaughton [Fri, 11 Sep 2015 07:22:30 +0000 (19:22 +1200)]
Merge pull request #6725 from eileenmcnaughton/CRM-14232
minor tidy-ups to comments & spelling
Eileen McNaughton [Fri, 11 Sep 2015 07:10:23 +0000 (19:10 +1200)]
Merge pull request #6724 from eileenmcnaughton/master
Test fixes
jitendrapurohit [Fri, 11 Sep 2015 06:29:52 +0000 (11:59 +0530)]
Fix Country => State hierarachical select broken in 4.7 branch
eileenmcnaugton [Fri, 11 Sep 2015 05:09:51 +0000 (17:09 +1200)]
minor tidy-ups
monishdeb [Fri, 11 Sep 2015 05:03:05 +0000 (10:33 +0530)]
upgrade fix
eileenmcnaughton [Fri, 11 Sep 2015 01:46:48 +0000 (01:46 +0000)]
test fixes
Dave Greenberg [Thu, 10 Sep 2015 23:06:23 +0000 (16:06 -0700)]
Merge pull request #6412 from colemanw/CRM-11369
CRM-11369 - Changed to Pending (pay later) and Pending (incomplete transaction)
eileenmcnaughton [Thu, 10 Sep 2015 22:24:23 +0000 (22:24 +0000)]
test fix
Eileen McNaughton [Thu, 10 Sep 2015 21:54:32 +0000 (09:54 +1200)]
Merge pull request #6570 from eileenmcnaughton/CRM-17023
CRM-12326 quicksearch speed improvements
monishdeb [Thu, 10 Sep 2015 20:00:15 +0000 (01:30 +0530)]
format fix
monishdeb [Thu, 10 Sep 2015 19:54:25 +0000 (01:24 +0530)]
CRM-16490: allow all permissioned organization for on-behalf registration
----------------------------------------
* CRM-16490: load org for permissioned relationships other than current employer
https://issues.civicrm.org/jira/browse/CRM-16490
Eileen McNaughton [Thu, 10 Sep 2015 18:35:23 +0000 (06:35 +1200)]
Merge pull request #6631 from eileenmcnaughton/CRM-17115
CRM-17115 extra/ stdise fields on CiviReport
Dave Greenberg [Thu, 10 Sep 2015 17:41:41 +0000 (10:41 -0700)]
Merge pull request #6717 from PalanteJon/CRM-17194
CRM-17194 - CiviReport - fix date range bug on Contribution Repeat Re…
Dave Greenberg [Thu, 10 Sep 2015 16:45:21 +0000 (09:45 -0700)]
Merge pull request #6613 from pradpnayak/CRM-16542
-- CRM-16542, fixed regression for billing block