Eileen McNaughton [Fri, 19 Aug 2022 09:39:11 +0000 (21:39 +1200)]
E-notice fix
Eileen McNaughton [Fri, 19 Aug 2022 05:43:52 +0000 (17:43 +1200)]
Merge pull request #24311 from eileenmcnaughton/ql
Regenerate sql
Eileen McNaughton [Fri, 19 Aug 2022 04:10:22 +0000 (16:10 +1200)]
Merge pull request #24310 from agileware/CIVICRM-2033
For Contribution pages with a recurring payment option. Change the label from "Regular amount" to "Regular Amount"
Eileen McNaughton [Fri, 19 Aug 2022 02:48:20 +0000 (14:48 +1200)]
Merge pull request #24309 from seamuslee001/greeting_check
[REF] Only add in entry to update Greeting if the greeting doesn't ma…
Seamus Lee [Fri, 19 Aug 2022 01:52:45 +0000 (11:52 +1000)]
Merge pull request #24308 from eileenmcnaughton/processor_notice
Enotice fix on payment processor browse
Eileen McNaughton [Fri, 19 Aug 2022 00:37:34 +0000 (12:37 +1200)]
Regenerate sql
Seamus Lee [Fri, 19 Aug 2022 01:03:30 +0000 (11:03 +1000)]
Merge pull request #24103 from eileenmcnaughton/ship_set
dev/core#3685 Update some of our sample data price sets to NOT be quick config
Justin Freeman [Fri, 19 Aug 2022 00:14:39 +0000 (10:14 +1000)]
CIVICRM-2033 Use CiviCRM standard first letter case "Regular amount" changes to "Regular Amount"
Seamus Lee [Fri, 19 Aug 2022 00:09:05 +0000 (10:09 +1000)]
Merge pull request #24183 from seamuslee001/elavon_extension_convert
[REF] Convert Elavon Payment Processor to be a core Extension
Seamus Lee [Thu, 18 Aug 2022 23:47:37 +0000 (09:47 +1000)]
[REF] Only add in entry to update Greeting if the greeting doesn't match what is already in the database
Eileen McNaughton [Thu, 18 Aug 2022 23:46:25 +0000 (11:46 +1200)]
Merge pull request #24306 from eileenmcnaughton/assoc
Deprecate two single-use option-value functions `create-a-sock` and `delete-a-sock`
Seamus Lee [Thu, 18 Aug 2022 23:43:10 +0000 (09:43 +1000)]
Merge pull request #24129 from eileenmcnaughton/greeting_perf
Code cleanup on greeting processing
demeritcowboy [Thu, 18 Aug 2022 23:24:19 +0000 (19:24 -0400)]
Merge pull request #24282 from totten/master-hookstyle-svc
CiviEventDispatcher - Fix pass-by-reference of hook-style arguments for service-based listeners
Eileen McNaughton [Thu, 18 Aug 2022 22:27:47 +0000 (10:27 +1200)]
Enotice fix on payment processor browse
Eileen McNaughton [Thu, 18 Aug 2022 21:43:03 +0000 (09:43 +1200)]
Merge pull request #24307 from totten/master-ornery
(NFC) FileTest - Mark as ornery
Seamus Lee [Mon, 8 Aug 2022 22:51:59 +0000 (08:51 +1000)]
[REF] Convert Elavon Payment Processor to be a core Extension
Tim Otten [Thu, 18 Aug 2022 21:23:03 +0000 (14:23 -0700)]
(NFC) FileTest - Mark as ornery
colemanw [Thu, 18 Aug 2022 21:22:44 +0000 (17:22 -0400)]
Merge pull request #24230 from eileenmcnaughton/import_api
Add `civiimport` core extension with Import api code for viewing import tables
Eileen McNaughton [Thu, 18 Aug 2022 20:34:36 +0000 (08:34 +1200)]
Deprecate two single-use option-value functions
Eileen McNaughton [Thu, 18 Aug 2022 19:53:09 +0000 (07:53 +1200)]
Merge pull request #24299 from colemanw/daoIdField
CRM_Core_DAO - Be more flexible about the primary key name
Eileen McNaughton [Thu, 18 Aug 2022 19:44:34 +0000 (07:44 +1200)]
Merge pull request #24303 from kurund/recaptcha-fatal-fixes
dev/core#3811 fixes for missing recaptcha_check_answer() when validate is called by other extensions
Eileen McNaughton [Thu, 18 Aug 2022 19:42:37 +0000 (07:42 +1200)]
Merge pull request #24301 from mattwire/participantnotice
Fix PHP notice and hide/show 'including yourself' depending on if contact_id is set
Matthew Wire [Thu, 18 Aug 2022 16:18:27 +0000 (17:18 +0100)]
Merge pull request #24277 from mattwire/testsvalidcountry
AUS is not a valid ISO 3166-1 alpha-2 country code. Do not use it in tests
colemanw [Thu, 18 Aug 2022 16:05:54 +0000 (12:05 -0400)]
Merge pull request #24287 from totten/master-single
(REF) Extract method `Array::single()`
Kurund Jalmi [Thu, 18 Aug 2022 16:03:21 +0000 (17:03 +0100)]
fixes for missing recaptcha_check_answer() when validate is called by other extensions
Matthew Wire [Sun, 3 Jul 2022 16:05:38 +0000 (17:05 +0100)]
Fix PHP notice and hide/show 'including yourself' depending on if contact_id is set
colemanw [Thu, 18 Aug 2022 14:53:25 +0000 (10:53 -0400)]
Merge pull request #24167 from mattwire/participant_created_id
dev/core#3778 Add created_id field to civicrm_participant
Coleman Watts [Wed, 17 Aug 2022 18:29:17 +0000 (14:29 -0400)]
Import API - remove unused actions, use trait for create/save/update actions
Coleman Watts [Thu, 18 Aug 2022 12:36:45 +0000 (08:36 -0400)]
CRM_Core_DAO - Be more flexible about the primary key name
colemanw [Thu, 18 Aug 2022 12:19:32 +0000 (08:19 -0400)]
Merge pull request #24236 from colemanw/afformCase
Afform - support opening new case
Matthew Wire [Tue, 16 Aug 2022 08:59:47 +0000 (09:59 +0100)]
AUS is not a valid ISO 3166-1 alpha-2 country code. Do not use it in tests
Matthew Wire [Tue, 9 Aug 2022 10:41:11 +0000 (11:41 +0100)]
Add created_id field to civicrm_participant
Eileen McNaughton [Thu, 18 Aug 2022 04:47:25 +0000 (16:47 +1200)]
Merge pull request #24294 from eileenmcnaughton/cache
Further caching fix - use metadata cache
Eileen McNaughton [Tue, 2 Aug 2022 23:56:12 +0000 (11:56 +1200)]
Code cleanup on greeting procssing
Eileen McNaughton [Thu, 4 Aug 2022 09:38:00 +0000 (21:38 +1200)]
Further caching fix - use metadata cache
demeritcowboy [Thu, 18 Aug 2022 00:27:41 +0000 (20:27 -0400)]
Merge pull request #24286 from eileenmcnaughton/rem
[REF] [Upgrade] Remove the entry point that called the unused entry point
demeritcowboy [Thu, 18 Aug 2022 00:20:06 +0000 (20:20 -0400)]
Merge pull request #24102 from eileenmcnaughton/emp_token
dev/core#3681 Add token for CiviCRM empowered by image
colemanw [Thu, 18 Aug 2022 00:05:01 +0000 (20:05 -0400)]
Merge pull request #24288 from eileenmcnaughton/get_mem_fields
Remove now-unused addField from Membership import
colemanw [Wed, 17 Aug 2022 22:14:46 +0000 (18:14 -0400)]
Merge pull request #24156 from eileenmcnaughton/cache_miss
Fix array-cache-bypass - in FastArrays on `has()`
colemanw [Wed, 17 Aug 2022 21:56:05 +0000 (17:56 -0400)]
Merge pull request #22504 from eileenmcnaughton/jon
financial#121: Support modifying Soft Credit permissions via hook
demeritcowboy [Wed, 17 Aug 2022 19:53:01 +0000 (15:53 -0400)]
Merge pull request #24122 from eileenmcnaughton/inv_lines
Update invoice template to be (mostly) previewable
demeritcowboy [Wed, 17 Aug 2022 12:53:40 +0000 (08:53 -0400)]
Merge pull request #24291 from totten/master-ml-test
(REF) Extract LocaleTestTrait. Tighten up multilingual testing.
Eileen McNaughton [Wed, 17 Aug 2022 09:39:37 +0000 (21:39 +1200)]
Merge pull request #23862 from eileenmcnaughton/nav
Move creating of nav & menu items to legacycustomsearches extension
Eileen McNaughton [Thu, 4 Aug 2022 06:54:23 +0000 (18:54 +1200)]
Test fix up & add stuff to diagnose the cleanup issue
Tim Otten [Wed, 17 Aug 2022 07:19:02 +0000 (00:19 -0700)]
MailingTest - Update multilingual helper calls
Tim Otten [Wed, 17 Aug 2022 07:18:50 +0000 (00:18 -0700)]
LoggingTest - Update multilingual helper calls
Tim Otten [Wed, 17 Aug 2022 07:18:30 +0000 (00:18 -0700)]
FinancialTypeTest - Update multilingual helper calls
Tim Otten [Wed, 17 Aug 2022 07:08:45 +0000 (00:08 -0700)]
SchemaTest - Update multilingual helper calls
Tim Otten [Wed, 17 Aug 2022 07:08:26 +0000 (00:08 -0700)]
ContributionPageTranslationTest - Update multilingual helper calls
Tim Otten [Wed, 17 Aug 2022 07:08:07 +0000 (00:08 -0700)]
MailingSystemTest - Update multilingual helper calls
Tim Otten [Wed, 17 Aug 2022 07:07:42 +0000 (00:07 -0700)]
MultilingualTest - Update multilingual helper calls
Tim Otten [Wed, 17 Aug 2022 07:07:23 +0000 (00:07 -0700)]
CopyTest - Update multilingual helper calls
Tim Otten [Wed, 17 Aug 2022 07:06:45 +0000 (00:06 -0700)]
LocaleTest - Update multilingual helper calls
Tim Otten [Wed, 17 Aug 2022 07:05:28 +0000 (00:05 -0700)]
Extract LocaleTestTrait from CiviUnitTestCase. Add more helpers.
Eileen McNaughton [Tue, 9 Aug 2022 01:13:44 +0000 (13:13 +1200)]
NFC code tidy up
Eileen McNaughton [Wed, 3 Aug 2022 23:17:05 +0000 (11:17 +1200)]
Fix test to cope with there actually being an extension with managed entities enabled
Eileen McNaughton [Tue, 21 Jun 2022 23:39:42 +0000 (11:39 +1200)]
Move creating of nav & menu items to legacycustomsearches extension
Eileen McNaughton [Thu, 11 Aug 2022 12:35:32 +0000 (00:35 +1200)]
Add civiimport with Import api code for viewing import tables
Seamus Lee [Wed, 17 Aug 2022 05:43:12 +0000 (15:43 +1000)]
Merge pull request #24290 from colemanw/daoIdFix
APIv4 - Fix some hard-coded references to 'id' in DAO action classes
Tim Otten [Wed, 17 Aug 2022 03:53:25 +0000 (20:53 -0700)]
Merge pull request #24258 from seamuslee001/authx_debug_test
[NFC] Add in Further debugging to authx test to try and debug issue o…
Coleman Watts [Wed, 17 Aug 2022 02:44:00 +0000 (22:44 -0400)]
APIv4 - Fix some hard-coded references to 'id' in DAO action classes
Eileen McNaughton [Wed, 17 Aug 2022 03:03:27 +0000 (15:03 +1200)]
Merge pull request #24284 from totten/master-nfc-locale
(NFC) Mark various tests with `@group locale`
Eileen McNaughton [Wed, 17 Aug 2022 03:00:41 +0000 (15:00 +1200)]
Merge pull request #24285 from eileenmcnaughton/import_dec
Add 'Entity' to the information import parser classes provide
colemanw [Wed, 17 Aug 2022 02:52:51 +0000 (22:52 -0400)]
Merge pull request #24054 from eileenmcnaughton/msg_workflow
Update references to 'workflow' (from old 'valueName' parameter)
Tim Otten [Tue, 16 Aug 2022 21:53:31 +0000 (14:53 -0700)]
HookStyleServiceListenerTest - Add test for running `hook_foo(&$alterable)`
Tim Otten [Tue, 16 Aug 2022 04:53:34 +0000 (21:53 -0700)]
CiviEventDispatcher - Fix pass-by-reference of hook-style arguments for service-based listeners
Suppose you are firing `hook_civicrm_foo` to a serivce-based listener
taht uses hook-style arguments. Conceptually, this is a call like:
Civi::service('foo')->hook_civicrm_foo($arg1, &$arg2, $arg3);
Before this patch, all values are pass-by-value. Changes to `&$arg2`
are not propagated back out.
The patch ensures that `&$arg2` propagates back out.
Tim Otten [Tue, 16 Aug 2022 21:46:05 +0000 (14:46 -0700)]
(REF) Civi\Core\Container - Extract method for overriding the active container
colemanw [Wed, 17 Aug 2022 02:11:31 +0000 (22:11 -0400)]
Merge pull request #24283 from totten/master-api4-passes
(REF) Extract compiler passes from CRM_Api4_Services
Eileen McNaughton [Wed, 17 Aug 2022 02:11:22 +0000 (14:11 +1200)]
Remove now-unused addField from Membership import
Tim Otten [Wed, 17 Aug 2022 02:10:02 +0000 (19:10 -0700)]
DAO - Raise error if we don't get the expected PK
Follow-up to #24275
colemanw [Wed, 17 Aug 2022 02:02:10 +0000 (22:02 -0400)]
Merge pull request #24279 from eileenmcnaughton/get_part_fields
Remove now-unused addField from Participant import
Eileen McNaughton [Sun, 31 Jul 2022 20:57:19 +0000 (06:57 +1000)]
Add token for CiviCRM empowered by image
Tim Otten [Wed, 17 Aug 2022 01:44:29 +0000 (18:44 -0700)]
Add test for `Array::single()`
Tim Otten [Wed, 17 Aug 2022 01:25:46 +0000 (18:25 -0700)]
(REF) Extract method Array::single()
Note: If you're reading this, you may notice that the exception-type looks different.
`API_Exception` is just an alias of `CRM_Core_Exception`.
colemanw [Wed, 17 Aug 2022 01:52:03 +0000 (21:52 -0400)]
Merge pull request #24275 from eileenmcnaughton/dao_prim
Update DAO to use declared primary field, do not assume...
colemanw [Wed, 17 Aug 2022 01:49:34 +0000 (21:49 -0400)]
Merge pull request #24254 from colemanw/mailingTask
SearchKit - Add contacts to mailing group in batches
colemanw [Wed, 17 Aug 2022 01:48:40 +0000 (21:48 -0400)]
Merge pull request #24186 from colemanw/groupContactPerm
APIv4 - Fix GroupContact permission to use standard ACLs
Eileen McNaughton [Wed, 17 Aug 2022 01:19:05 +0000 (13:19 +1200)]
[REF] [Upgrade] Remove the entry point that called the unused entry point
Eileen McNaughton [Wed, 17 Aug 2022 00:53:40 +0000 (12:53 +1200)]
Merge pull request #24280 from eileenmcnaughton/cust_err
Importer - Remove unused functions (`isErrorInCustomData`, `getSubtypes`, `validateCustomField`)
Eileen McNaughton [Wed, 17 Aug 2022 00:52:53 +0000 (12:52 +1200)]
Merge pull request #24281 from eileenmcnaughton/tim
(REF) I18nSubscriber - Rename parameter to be more evocative
Tim Otten [Tue, 16 Aug 2022 23:39:09 +0000 (16:39 -0700)]
Merge pull request #24274 from eileenmcnaughton/flush
AllCoreTables - Dismbiguate `init `and `flush`
Seamus Lee [Mon, 15 Aug 2022 08:16:38 +0000 (08:16 +0000)]
[NFC] Add in Further debugging to authx test to try and debug issue on php8.1
Eileen McNaughton [Tue, 16 Aug 2022 23:34:52 +0000 (11:34 +1200)]
Add 'Entity' to the information import classes provide
Tim Otten [Mon, 15 Aug 2022 23:51:00 +0000 (16:51 -0700)]
(REF) Define SpecProviderPass (extracted from CRM_Api4_Services)
The `CRM_Api4_Services` implementation has a secret behavior that applies
to all services - it detects the tag 'spec_provider' and registers
with the spec-gatherer.
This kind of behavior is often implemented as "compiler pass" and given its
own documentation.
Tim Otten [Mon, 15 Aug 2022 23:32:04 +0000 (16:32 -0700)]
(REF) Define EventScannerPass (extracted from CRM_Api4_Services)
The `CRM_Api4_Services` implementation has a secret behavior that applies
to all services - it detects the tag 'event_subscriber' and registers with
the dispatcher.
This kind of behavior is often implemented as "compiler pass" and given its
own documentation.
Tim Otten [Wed, 3 Aug 2022 05:00:23 +0000 (22:00 -0700)]
(REF) I18nSubscriber - Rename parameter to be more evocative
Eileen McNaughton [Tue, 16 Aug 2022 20:40:16 +0000 (08:40 +1200)]
Remove getSubTypes
Eileen McNaughton [Tue, 16 Aug 2022 20:36:50 +0000 (08:36 +1200)]
Remove further unused function
Eileen McNaughton [Tue, 16 Aug 2022 20:34:18 +0000 (08:34 +1200)]
Remove function only called from unittest
Eileen McNaughton [Tue, 16 Aug 2022 20:23:31 +0000 (08:23 +1200)]
Remove now-unused addField from Participant import
Tim Otten [Mon, 8 Aug 2022 09:24:33 +0000 (02:24 -0700)]
(NFC) Mark various tests with `@group locale`
Note: There seems to be some weirdness when running the full-group. But breaking down by a couple folders may help:
```
civibuild restore dmaster --no-cms ; CIVICRM_UF=UnitTests phpunit8 tests/phpunit/api/ --debug --group locale --stop-on-failure
civibuild restore dmaster --no-cms ; CIVICRM_UF=UnitTests phpunit8 tests/phpunit/CRM/ --debug --group locale --stop-on-failure
civibuild restore dmaster --no-cms ; CIVICRM_UF=UnitTests phpunit8 tests/phpunit/Civi/ --debug --group locale --stop-on-failure
```
demeritcowboy [Tue, 16 Aug 2022 15:14:27 +0000 (11:14 -0400)]
Merge pull request #24269 from eileenmcnaughton/msg
Unhide message_admin extension
colemanw [Tue, 16 Aug 2022 13:31:09 +0000 (09:31 -0400)]
Merge pull request #24273 from eileenmcnaughton/imp_has_loc
Remove last usage of `_fields` from `Import_Parser`
Eileen McNaughton [Tue, 16 Aug 2022 11:51:52 +0000 (23:51 +1200)]
Update RuleGroupTest to flush sanely
Eileen McNaughton [Tue, 16 Aug 2022 08:55:50 +0000 (20:55 +1200)]
Update DynamicAuthorizationTest to flush sanely
Eileen McNaughton [Tue, 16 Aug 2022 01:32:08 +0000 (13:32 +1200)]
Also merge in reinitializeCache
Eileen McNaughton [Tue, 16 Aug 2022 01:18:56 +0000 (13:18 +1200)]
Dismbiguate init and flush
Eileen McNaughton [Tue, 16 Aug 2022 07:34:26 +0000 (19:34 +1200)]
Update DAO to use declared primary field, do not assume...
Eileen McNaughton [Mon, 15 Aug 2022 22:40:48 +0000 (10:40 +1200)]
Rename function
Eileen McNaughton [Mon, 15 Aug 2022 22:38:54 +0000 (10:38 +1200)]
Make property private