civicrm-core.git
9 months agoMerge pull request #29379 from seamuslee001/5.70
Eileen McNaughton [Tue, 13 Feb 2024 19:58:11 +0000 (08:58 +1300)]
Merge pull request #29379 from seamuslee001/5.70

dev/4989 Fix non-default currency in contribution confirm and thank-y…

9 months agodev/4989 Fix non-default currency in contribution confirm and thank-you pages
John Kingsnorth [Mon, 12 Feb 2024 23:30:24 +0000 (23:30 +0000)]
dev/4989 Fix non-default currency in contribution confirm and thank-you pages

9 months agoMerge pull request #29374 from eileenmcnaughton/570
Eileen McNaughton [Tue, 13 Feb 2024 00:32:19 +0000 (13:32 +1300)]
Merge pull request #29374 from eileenmcnaughton/570

APIv4 - Fetch all options when matching pseudoconstants.

9 months agoAPIv4 - Fetch all options when matching pseudoconstants.
colemanw [Sun, 11 Feb 2024 23:02:57 +0000 (18:02 -0500)]
APIv4 - Fetch all options when matching pseudoconstants.

When performing a match we want to fetch all options not a filtered list.
Fixes https://lab.civicrm.org/dev/core/-/issues/4997

9 months agoSet version to 5.70.0
CiviCRM [Fri, 9 Feb 2024 04:49:40 +0000 (23:49 -0500)]
Set version to 5.70.0

9 months agorelease-notes.md - Last minute tweaks
CiviCRM [Fri, 9 Feb 2024 04:48:08 +0000 (23:48 -0500)]
release-notes.md - Last minute tweaks

9 months agoMerge pull request #29345 from totten/5.70-jwt
Tim Otten [Fri, 9 Feb 2024 04:02:33 +0000 (20:02 -0800)]
Merge pull request #29345 from totten/5.70-jwt

CryptoJwt - Fix detection of firebase/php-jwt APIs

9 months agoMerge pull request #29338 from eileenmcnaughton/rc_clear
Eileen McNaughton [Thu, 8 Feb 2024 23:05:12 +0000 (12:05 +1300)]
Merge pull request #29338 from eileenmcnaughton/rc_clear

Fix clearAssign for php8.x

9 months agoFix clearAssign for php8.x
eileen [Thu, 8 Feb 2024 20:17:21 +0000 (09:17 +1300)]
Fix clearAssign for php8.x

9 months agoCryptoJwt - Fix detection of firebase/php-jwt APIs
Tim Otten [Thu, 8 Feb 2024 22:21:31 +0000 (14:21 -0800)]
CryptoJwt - Fix detection of firebase/php-jwt APIs

9 months agoMerge pull request #29330 from eileenmcnaughton/570_cfix
Tim Otten [Thu, 8 Feb 2024 06:59:49 +0000 (22:59 -0800)]
Merge pull request #29330 from eileenmcnaughton/570_cfix

Ensure currency is set various forms

9 months agoFix some currencies not passed
eileen [Thu, 8 Feb 2024 05:21:40 +0000 (18:21 +1300)]
Fix some currencies not passed

9 months agoMerge pull request #29190 from eileenmcnaughton/570
Tim Otten [Thu, 8 Feb 2024 05:19:11 +0000 (21:19 -0800)]
Merge pull request #29190 from eileenmcnaughton/570

dev/core#4953 Fix failure to show existing membership type in renewal mode

9 months agoMerge pull request #29326 from eileenmcnaughton/currency_small
Tim Otten [Thu, 8 Feb 2024 05:15:31 +0000 (21:15 -0800)]
Merge pull request #29326 from eileenmcnaughton/currency_small

 Ensure currency is set on back office participant form

9 months agoadditional e-notice fix
eileen [Fri, 2 Feb 2024 03:12:29 +0000 (16:12 +1300)]
additional e-notice fix

9 months agodev/core#4953 Fix failure to show existing membership type in renewal mode
eileen [Fri, 2 Feb 2024 03:03:22 +0000 (16:03 +1300)]
dev/core#4953 Fix failure to show existing membership type in renewal mode

The previous fix dealt with js layer issues but this affects select boxes in the php layer

Also fixed 2 smarty notices that turned out to not be related

9 months agoMerge pull request #29275 from eileenmcnaughton/570_mem
Tim Otten [Thu, 8 Feb 2024 04:17:05 +0000 (20:17 -0800)]
Merge pull request #29275 from eileenmcnaughton/570_mem

dev/core#4963 Fix validation error on membership renew with auto-renew

9 months ago Ensure currency is set on back office participant form
eileen [Thu, 8 Feb 2024 03:15:57 +0000 (16:15 +1300)]
 Ensure currency is set on back office participant form

9 months agoMerge pull request #29195 from eileenmcnaughton/receipt_text
Tim Otten [Thu, 8 Feb 2024 03:06:33 +0000 (19:06 -0800)]
Merge pull request #29195 from eileenmcnaughton/receipt_text

dev/core#4948 Fix online_receipt template to include receipt text

9 months agoMerge pull request #29324 from agh1/5.70.0-releasenotes
Tim Otten [Thu, 8 Feb 2024 02:09:47 +0000 (18:09 -0800)]
Merge pull request #29324 from agh1/5.70.0-releasenotes

5.70.0 release notes

9 months agoMerge pull request #29290 from colemanw/scheduleRemindersRequired
Tim Otten [Thu, 8 Feb 2024 01:01:29 +0000 (17:01 -0800)]
Merge pull request #29290 from colemanw/scheduleRemindersRequired

Fix dev/core#4949 ScheduleReminder form required field error

9 months agoMerge pull request #29293 from colemanw/fixScheduleReminderFormPerms
Tim Otten [Thu, 8 Feb 2024 00:28:50 +0000 (16:28 -0800)]
Merge pull request #29293 from colemanw/fixScheduleReminderFormPerms

Fix dev/core#4971 - Skip redundant permission checks in ScheduleReminder form

9 months ago5.70.0 release notes: big batch of edits
Amanda Hunt [Wed, 7 Feb 2024 23:59:02 +0000 (18:59 -0500)]
5.70.0 release notes: big batch of edits

9 months agoMerge pull request #29312 from eileenmcnaughton/suppress_570
demeritcowboy [Wed, 7 Feb 2024 22:27:34 +0000 (17:27 -0500)]
Merge pull request #29312 from eileenmcnaughton/suppress_570

dev/core#4973 Fix credit card info not showing up in ThankYou & Confirm

9 months agoMerge pull request #29300 from eileenmcnaughton/995
colemanw [Wed, 7 Feb 2024 21:27:21 +0000 (16:27 -0500)]
Merge pull request #29300 from eileenmcnaughton/995

dev/core#4980 Ensure payment processor object is returned

9 months agoMerge pull request #29296 from colemanw/jobParams
Eileen McNaughton [Wed, 7 Feb 2024 21:25:57 +0000 (10:25 +1300)]
Merge pull request #29296 from colemanw/jobParams

Fix dev/core#4959 - Handle extra whitespace in scheduled job params

9 months ago5.70.0 release notes: added boilerplate
Amanda Hunt [Wed, 7 Feb 2024 21:02:15 +0000 (16:02 -0500)]
5.70.0 release notes: added boilerplate

9 months ago5.70.0 release notes: raw from script
Andie Hunt [Wed, 7 Feb 2024 20:47:33 +0000 (15:47 -0500)]
5.70.0 release notes: raw from script

9 months agodev/core#4973 Fix credit card info not showing up in ThankYou & Confirm
eileen [Wed, 7 Feb 2024 20:05:17 +0000 (09:05 +1300)]
dev/core#4973 Fix credit card info not showing up in ThankYou & Confirm

9 months agoFix dev/core#4949 ScheduleReminder form required field error
colemanw [Wed, 7 Feb 2024 00:55:43 +0000 (19:55 -0500)]
Fix dev/core#4949 ScheduleReminder form required field error

9 months agoScheduleReminders - Prevent changing values to existing reminders via url
colemanw [Wed, 7 Feb 2024 18:42:48 +0000 (13:42 -0500)]
ScheduleReminders - Prevent changing values to existing reminders via url

9 months agodev/core#4980 Ensure payment processor object is returned
eileen [Wed, 7 Feb 2024 17:38:39 +0000 (06:38 +1300)]
dev/core#4980 Ensure payment processor object is returned

9 months agoFix dev/core#4959 - Handle extra whitespace in scheduled job params
colemanw [Wed, 7 Feb 2024 13:48:21 +0000 (08:48 -0500)]
Fix dev/core#4959 - Handle extra whitespace in scheduled job params

9 months agoMerge pull request #29260 from colemanw/getModules
Tim Otten [Wed, 7 Feb 2024 08:10:44 +0000 (00:10 -0800)]
Merge pull request #29260 from colemanw/getModules

dev/core#4969 Simplify AngularManager loading/caching system

9 months agoFix dev/core#4971 - Skip redundant permission checks in CRM_Admin_Form_ScheduleReminders
colemanw [Wed, 7 Feb 2024 03:15:14 +0000 (22:15 -0500)]
Fix dev/core#4971 - Skip redundant permission checks in CRM_Admin_Form_ScheduleReminders

Temporary override to solve https://lab.civicrm.org/dev/core/-/issues/4971
This regressed in https://github.com/civicrm/civicrm-core/pull/27003 which
switched $this->retrieveMethod to 'api' - this had the unintended effect of checking
permissions during retrieveValues(), but the API is not sophisticated enough: we need to
add
a `CRM_Core_BAO_ActionSchedule::addSelectWhereClause()` function that can handle the logic
of "if the reminder is for an event, check user has edit permission for that specific
event".

Meanwhile we can skip permission checks in the form layer, because that logic is
implemented here,
specifically in `\CRM_Event_ActionMapping::checkAccess()`.

9 months agoMerge pull request #29193 from eileenmcnaughton/570_tags
colemanw [Wed, 7 Feb 2024 01:17:12 +0000 (20:17 -0500)]
Merge pull request #29193 from eileenmcnaughton/570_tags

Fix wonkyness if contribution page includes a profile with both groups & tags

9 months agoAngularManager - Simplify caching
colemanw [Mon, 5 Feb 2024 19:25:37 +0000 (14:25 -0500)]
AngularManager - Simplify caching

In 604cca72 the cache was split into smaller pieces in an attempt to fix some failing tests.
It turned out those fails for other reasons so there's no need to have > 1 cache for angularModules.

Fixes https://lab.civicrm.org/dev/core/-/issues/4969

9 months agoAngularManager - Ensure 'basePages' is an array
colemanw [Mon, 5 Feb 2024 19:20:42 +0000 (14:20 -0500)]
AngularManager - Ensure 'basePages' is an array

This doesn't change the behavior (historical default mainained, with a comment added about why),
just ensures the value is always set to prevent errors when it gets passed to in_array().

9 months agodev/core#4963 Fix validation error on membership renew with auto-renew
eileen [Tue, 6 Feb 2024 05:20:15 +0000 (18:20 +1300)]
dev/core#4963 Fix validation error on membership renew with auto-renew

9 months agoMerge pull request #29277 from eileenmcnaughton/570-orn
Eileen McNaughton [Tue, 6 Feb 2024 06:14:02 +0000 (19:14 +1300)]
Merge pull request #29277 from eileenmcnaughton/570-orn

Disable failing test in PR runs for now

9 months agoDisable failing test in PR runs for now
eileen [Sun, 4 Feb 2024 21:27:32 +0000 (10:27 +1300)]
Disable failing test in PR runs for now

9 months agoMerge pull request #29264 from MegaphoneJon/cond-receipt
Eileen McNaughton [Tue, 6 Feb 2024 00:55:55 +0000 (13:55 +1300)]
Merge pull request #29264 from MegaphoneJon/cond-receipt

don't send an extra receipt when completing pending contributions

9 months agoMerge pull request #29226 from eileenmcnaughton/tags_g
colemanw [Tue, 6 Feb 2024 00:41:23 +0000 (19:41 -0500)]
Merge pull request #29226 from eileenmcnaughton/tags_g

Php 8.x notice fix on tags & groups fields

9 months agodon't send an extra receipt when completing pending contributions
Jon Goldberg [Mon, 5 Feb 2024 22:49:58 +0000 (17:49 -0500)]
don't send an extra receipt when completing pending contributions

9 months agoPhp 8.x notice fix on tags & groups fields
eileen [Fri, 2 Feb 2024 05:40:06 +0000 (18:40 +1300)]
Php 8.x notice fix on tags & groups fields

9 months agoFix online_receipt template to include receipt text
eileen [Fri, 2 Feb 2024 06:18:49 +0000 (19:18 +1300)]
Fix online_receipt template to include receipt text

9 months agoMerge pull request #29208 from colemanw/fixIrrelevantLinks
Eileen McNaughton [Sat, 3 Feb 2024 03:02:33 +0000 (16:02 +1300)]
Merge pull request #29208 from colemanw/fixIrrelevantLinks

SearchKit - Remove irrelevant links from default display

9 months agoMerge pull request #29209 from colemanw/disableActivityTab
Eileen McNaughton [Sat, 3 Feb 2024 03:01:13 +0000 (16:01 +1300)]
Merge pull request #29209 from colemanw/disableActivityTab

dev/core#4950 - Disable SearchUI version of ContactSummary Activity tab

9 months agoMerge pull request #29200 from ejegg/conditionalCaseLink
colemanw [Sat, 3 Feb 2024 02:53:40 +0000 (21:53 -0500)]
Merge pull request #29200 from ejegg/conditionalCaseLink

dev/core#4960 Make Case menu link in relationship tab conditional

9 months agoMerge pull request #29192 from eileenmcnaughton/570_2
Eileen McNaughton [Fri, 2 Feb 2024 22:50:48 +0000 (11:50 +1300)]
Merge pull request #29192 from eileenmcnaughton/570_2

Fix 5.67 regression on loading custom data defaults on contribution page

9 months agodev/core#4950 - Disable SearchUI version of ContactSummary Activity tab
colemanw [Fri, 2 Feb 2024 22:17:31 +0000 (17:17 -0500)]
dev/core#4950 - Disable SearchUI version of ContactSummary Activity tab

This temporarily disables the new tab while we assess query performance problems
See https://lab.civicrm.org/dev/core/-/issues/4950

Note: commented out code uses the new 'placement' option which is preferred
over the legacy 'contact_summary' flag.

9 months agoMerge pull request #29206 from colemanw/fixInvalidLinks
colemanw [Fri, 2 Feb 2024 22:11:57 +0000 (17:11 -0500)]
Merge pull request #29206 from colemanw/fixInvalidLinks

SearchKit - Hide invalid links and prevent error

9 months agoSearchKit - Remove irrelevant links from default display
colemanw [Fri, 2 Feb 2024 22:02:31 +0000 (17:02 -0500)]
SearchKit - Remove irrelevant links from default display

The action regressed when switching search displays to use the GetLinks api action.
This fixes the filtering & makes it more efficient by passing the filter to the api.

9 months agoSearchKit - Hide invalid links and prevent error
colemanw [Fri, 2 Feb 2024 16:28:11 +0000 (11:28 -0500)]
SearchKit - Hide invalid links and prevent error

Fixes dev/core#4961

9 months agoMerge pull request #29203 from eileenmcnaughton/url
colemanw [Fri, 2 Feb 2024 20:53:53 +0000 (15:53 -0500)]
Merge pull request #29203 from eileenmcnaughton/url

dev/core#4962 Fix Smarty fatal on resource url page

9 months agodev/core#4962 Fix Smarty fatal on resource url page
eileen [Fri, 2 Feb 2024 19:12:05 +0000 (08:12 +1300)]
dev/core#4962 Fix Smarty fatal on resource url page

9 months agoFix 5.67 regression on loading custom data defaults on contribution page
eileen [Fri, 2 Feb 2024 04:05:20 +0000 (17:05 +1300)]
Fix 5.67 regression on loading custom data defaults on contribution page

9 months agoMake Case menu link in relationship tab conditional
Elliott Eggleston [Fri, 2 Feb 2024 15:52:07 +0000 (10:52 -0500)]
Make Case menu link in relationship tab conditional

Only add the link when CiviCase is enabled

dev/core#4960

10 months agoMerge pull request #29180 from colemanw/selectTab
colemanw [Fri, 2 Feb 2024 11:57:24 +0000 (06:57 -0500)]
Merge pull request #29180 from colemanw/selectTab

SearchKit - Fix switching to nonexistent tab

10 months agoFix wonkyness if contribution page includes a profile with both groups & tags
eileen [Fri, 2 Feb 2024 05:04:47 +0000 (18:04 +1300)]
Fix wonkyness if contribution page includes a profile with both groups & tags

10 months agoMerge pull request #29189 from seamuslee001/dev_ui_65
Seamus Lee [Fri, 2 Feb 2024 03:37:48 +0000 (14:37 +1100)]
Merge pull request #29189 from seamuslee001/dev_ui_65

dev/user-interface#65 Remove top set of buttons which only show up in…

10 months agodev/user-interface#65 Remove top set of buttons which only show up in non popup form
Seamus Lee [Fri, 2 Feb 2024 02:40:28 +0000 (13:40 +1100)]
dev/user-interface#65 Remove top set of buttons which only show up in non popup form

10 months agoSearchKit - Fix switching to nonexistent tab
colemanw [Thu, 1 Feb 2024 02:22:49 +0000 (21:22 -0500)]
SearchKit - Fix switching to nonexistent tab

Tabs were recently renamed so this keeps up with the change.

10 months agoMerge pull request #28971 from mattwire/firebase
Seamus Lee [Wed, 31 Jan 2024 23:15:20 +0000 (10:15 +1100)]
Merge pull request #28971 from mattwire/firebase

Fix fatal error when firebase/php-jwt library is 'replaced' in composer

10 months agoFix fatal error when firebase/php-jwt library is 'replaced' in composer
Matthew Wire [Thu, 11 Jan 2024 12:46:57 +0000 (12:46 +0000)]
Fix fatal error when firebase/php-jwt library is 'replaced' in composer

10 months agoMerge pull request #29107 from eileenmcnaughton/570_no_wiz
Tim Otten [Wed, 31 Jan 2024 07:14:20 +0000 (23:14 -0800)]
Merge pull request #29107 from eileenmcnaughton/570_no_wiz

Remove attempt to use wizard on manage ACLs

10 months agoMerge pull request #29092 from colemanw/getAutocompleteParams
Tim Otten [Wed, 31 Jan 2024 06:57:59 +0000 (22:57 -0800)]
Merge pull request #29092 from colemanw/getAutocompleteParams

dev/core#4937 - Fix js error in formBuilder autocompletes

10 months agoMerge pull request #29112 from eileenmcnaughton/570_mem
Tim Otten [Wed, 31 Jan 2024 06:15:32 +0000 (22:15 -0800)]
Merge pull request #29112 from eileenmcnaughton/570_mem

dev/core#4939 Fix failure to load existing membership info on online membership page

10 months agoMerge pull request #29155 from colemanw/colIndex
colemanw [Tue, 30 Jan 2024 15:05:16 +0000 (10:05 -0500)]
Merge pull request #29155 from colemanw/colIndex

crmDashboard - Fix deleting item from 2nd column

10 months agocrmDashboard - Fix deleting item from 2nd column
colemanw [Mon, 29 Jan 2024 20:41:51 +0000 (15:41 -0500)]
crmDashboard - Fix deleting item from 2nd column

10 months agoMerge pull request #29143 from colemanw/excludeCaseActivities
demeritcowboy [Mon, 29 Jan 2024 13:28:55 +0000 (08:28 -0500)]
Merge pull request #29143 from colemanw/excludeCaseActivities

Fix dev/core#4943 - Exclude case activities from count if appropriate

10 months agoFix dev/core#4943 - Exclude case activities from count if appropriate
colemanw [Mon, 29 Jan 2024 04:02:38 +0000 (23:02 -0500)]
Fix dev/core#4943 - Exclude case activities from count if appropriate

10 months agoMerge pull request #29118 from eileenmcnaughton/570_patrick
colemanw [Mon, 29 Jan 2024 03:36:52 +0000 (22:36 -0500)]
Merge pull request #29118 from eileenmcnaughton/570_patrick

When auto-renew option is available, show the checkbox immediately in…

10 months agoMerge pull request #29115 from eileenmcnaughton/570
colemanw [Sun, 28 Jan 2024 22:09:48 +0000 (17:09 -0500)]
Merge pull request #29115 from eileenmcnaughton/570

dev/core#4917 Ensure total is always updated when other amount is selected

10 months agoWhen auto-renew option is available, show the checkbox immediately instead of upon...
Patrick Lam [Tue, 16 Jan 2024 11:03:44 +0000 (00:03 +1300)]
When auto-renew option is available, show the checkbox immediately instead of upon clicking the price.

memTypeId was previously "undefined" after trying to read attribute
"membership-type".  The DOM shows an attribute
"data-membership-type-id" and this patch modifies the attribute read
to "data-membership-type-id", which is also consistent with the
variable name in the code.

10 months agoEnsure total is always updated when other amount is selected
eileen [Sat, 27 Jan 2024 20:04:39 +0000 (09:04 +1300)]
Ensure total is always updated when other amount is selected

10 months agoMerge pull request #29113 from eileenmcnaughton/christian
Eileen McNaughton [Sat, 27 Jan 2024 19:50:35 +0000 (08:50 +1300)]
Merge pull request #29113 from eileenmcnaughton/christian

Fix JS error and allow focus of Other Amount field

10 months agoFix JS error and allow focus of Other Amount field
Christian Wach [Wed, 17 Jan 2024 13:41:19 +0000 (13:41 +0000)]
Fix JS error and allow focus of Other Amount field

10 months agodev/core#4939 Fix failure to load existing membership info on online membership page
eileen [Sat, 27 Jan 2024 06:28:22 +0000 (19:28 +1300)]
dev/core#4939 Fix failure to load existing membership info on online membership page

10 months agoMerge pull request #29097 from demeritcowboy/grouprole
Eileen McNaughton [Sat, 27 Jan 2024 02:12:51 +0000 (15:12 +1300)]
Merge pull request #29097 from demeritcowboy/grouprole

dev/core#4938 - crash after saving a civireport

10 months agoRemove attempt to use wizard on manage ACLs
eileen [Sat, 27 Jan 2024 02:01:27 +0000 (15:01 +1300)]
Remove attempt to use wizard on manage ACLs

10 months agothe field needs null
demeritcowboy [Fri, 26 Jan 2024 17:15:40 +0000 (12:15 -0500)]
the field needs null

10 months agoMerge pull request #29091 from wmortada/accordion
demeritcowboy [Fri, 26 Jan 2024 16:48:50 +0000 (11:48 -0500)]
Merge pull request #29091 from wmortada/accordion

Invert logic for collapsing contact dashboard accordion

10 months agoInvert logic for accordion open
William Mortada [Fri, 26 Jan 2024 09:14:23 +0000 (09:14 +0000)]
Invert logic for accordion open

10 months agodev/core#4937 - Fix js error in formBuilder autocompletes
colemanw [Fri, 26 Jan 2024 15:11:43 +0000 (10:11 -0500)]
dev/core#4937 - Fix js error in formBuilder autocompletes

Due to 5071a76 this field was fetching form values during every digest cycle and in some
cases this was causing an infinite loop. Updated the field to only fetch values when needed.

10 months agoMerge pull request #29086 from totten/5.70-unsub-wp
colemanw [Thu, 25 Jan 2024 23:09:10 +0000 (18:09 -0500)]
Merge pull request #29086 from totten/5.70-unsub-wp

(dev/core#4641) ListUnsubscribe - Fix HTTP URL generation on WordPress

10 months agoListUnsubscribe - Fix HTTP URL generation on WP/J
Tim Otten [Thu, 25 Jan 2024 00:07:27 +0000 (16:07 -0800)]
ListUnsubscribe - Fix HTTP URL generation on WP/J

10 months agoMerge pull request #28964 from totten/5.70-unsub-overload
Tim Otten [Wed, 24 Jan 2024 22:02:42 +0000 (14:02 -0800)]
Merge pull request #28964 from totten/5.70-unsub-overload

(dev/core#4641) CiviMail - Add support for One-Click unsubscribes

10 months agoMerge pull request #29080 from demeritcowboy/formprop
Eileen McNaughton [Wed, 24 Jan 2024 20:01:32 +0000 (09:01 +1300)]
Merge pull request #29080 from demeritcowboy/formprop

Avoid crash in extensions that call getVar

10 months agoMerge pull request #29073 from mlutfy/core4930
colemanw [Wed, 24 Jan 2024 17:02:35 +0000 (12:02 -0500)]
Merge pull request #29073 from mlutfy/core4930

dev/core#4930 Fix Activity count when contact is assigned multiple roles

10 months agoMerge pull request #29079 from demeritcowboy/missing-sms
demeritcowboy [Wed, 24 Jan 2024 16:39:16 +0000 (11:39 -0500)]
Merge pull request #29079 from demeritcowboy/missing-sms

dev/core#4932 - Bring back missing actions when viewing contact summary

10 months agoavoid crash
demeritcowboy [Wed, 24 Jan 2024 16:22:22 +0000 (11:22 -0500)]
avoid crash

10 months agobring back missing actions
demeritcowboy [Wed, 24 Jan 2024 15:52:12 +0000 (10:52 -0500)]
bring back missing actions

10 months agoListUnsubscribe - Production sites really should use HTTPS
Tim Otten [Wed, 24 Jan 2024 05:19:27 +0000 (21:19 -0800)]
ListUnsubscribe - Production sites really should use HTTPS

10 months agoListUnsubscribe - Ensure URL is always absolute
Tim Otten [Thu, 18 Jan 2024 05:51:18 +0000 (21:51 -0800)]
ListUnsubscribe - Ensure URL is always absolute

When delivering via unit-test or cron job, the URL came out absolute.

But when using web UI to "Send test", the URL was relative.

It should be absolute.

10 months agoListUnsubscribe - Fix VERP parsing (alternate separators; optional localpart-prefix)
Tim Otten [Wed, 17 Jan 2024 22:36:55 +0000 (14:36 -0800)]
ListUnsubscribe - Fix VERP parsing (alternate separators; optional localpart-prefix)

10 months ago(REF) Move testGitLabIssue1108() to its own class
Tim Otten [Thu, 11 Jan 2024 04:23:55 +0000 (20:23 -0800)]
(REF) Move testGitLabIssue1108() to its own class

BEFORE: `MailingSystemTest` (which extends `BaseMailingSystemTest`)
includes `testGitLabIssue1108($isMultilingual)`. This is
a transactional test (per `BaseMailingSystemTest::setUp()`).

AFTER: `MultingualSystemTest` includes `testGitLabIssue1108()`.
This is not a transactional test.

COMMENTS: This resolves some circumstantial flakiness in the tests.

* The problem appeared when adding an unrelated test `BaseMailingSystemTest` -- the
  new test failed because of a conflict with `testGitLabIssue1108()`.
* You could also produce the problem in other cases by switching around the order of
  `testGitLabIssue1108()` (e.g. hack data-provider `multiLingual()`)
* I believe the root problem is that `BaseMailingSystemTest` is written as
  a transactional test -- but `testGitLabIssue1108()` does large-scale
  schema changes (whenever it toggles multilingual), which makes it
  non-transactional.
* The patch here prevents these kind of conflicts by putting
  `testGitLabIssue1108()` in a separate (non-transactional) context.

10 months agoCiviMail - Add status-check for civimail_unsubscribe_methods
Tim Otten [Thu, 11 Jan 2024 00:13:20 +0000 (16:13 -0800)]
CiviMail - Add status-check for civimail_unsubscribe_methods

10 months agoCiviMail - Implement List-Unsubscibe=One-Click (with overloaded routing)
Tim Otten [Tue, 9 Jan 2024 04:09:32 +0000 (20:09 -0800)]
CiviMail - Implement List-Unsubscibe=One-Click (with overloaded routing)

10 months agoMerge pull request #29072 from colemanw/serviceName
colemanw [Wed, 24 Jan 2024 01:31:57 +0000 (20:31 -0500)]
Merge pull request #29072 from colemanw/serviceName

Fix metadata cache clear event