civicrm-core.git
4 years agoMerge pull request #16228 from demeritcowboy/more-t2
Eileen McNaughton [Wed, 8 Jan 2020 20:35:37 +0000 (09:35 +1300)]
Merge pull request #16228 from demeritcowboy/more-t2

dev/core#495 Make admin settings field labels translatable

4 years agoMerge pull request #16229 from demeritcowboy/more-t3
Eileen McNaughton [Wed, 8 Jan 2020 20:33:19 +0000 (09:33 +1300)]
Merge pull request #16229 from demeritcowboy/more-t3

dev/core#495 Make admin settings field labels translatable

4 years agomake translatable
demeritcowboy [Wed, 8 Jan 2020 14:36:28 +0000 (09:36 -0500)]
make translatable

4 years agomake translatable
demeritcowboy [Wed, 8 Jan 2020 14:30:31 +0000 (09:30 -0500)]
make translatable

4 years agoMerge pull request #16227 from demeritcowboy/more-t
Matthew Wire [Wed, 8 Jan 2020 10:25:23 +0000 (10:25 +0000)]
Merge pull request #16227 from demeritcowboy/more-t

dev/core#495 Make admin settings field labels translatable

4 years agomake translatable
demeritcowboy [Wed, 8 Jan 2020 06:19:57 +0000 (01:19 -0500)]
make translatable

4 years agoMerge pull request #16220 from colemanw/checkmark
Eileen McNaughton [Tue, 7 Jan 2020 23:10:45 +0000 (12:10 +1300)]
Merge pull request #16220 from colemanw/checkmark

Change check.gif to an actual gif (was a PNG)

4 years agoMerge pull request #16222 from colemanw/importable
Eileen McNaughton [Tue, 7 Jan 2020 23:10:16 +0000 (12:10 +1300)]
Merge pull request #16222 from colemanw/importable

Refactor CRM_Contact_BAO_Contact::importableFields() to use metadata

4 years agoMerge pull request #16226 from civicrm/5.22
Eileen McNaughton [Tue, 7 Jan 2020 23:08:13 +0000 (12:08 +1300)]
Merge pull request #16226 from civicrm/5.22

5.22 to master

4 years agoMerge pull request #16225 from demeritcowboy/contribution-view-missing-status
Eileen McNaughton [Tue, 7 Jan 2020 23:06:35 +0000 (12:06 +1300)]
Merge pull request #16225 from demeritcowboy/contribution-view-missing-status

dev/core#1508 Regression/E_NOTICE - Missing table on contribution view

4 years agoMerge pull request #16224 from eileenmcnaughton/set
Eileen McNaughton [Tue, 7 Jan 2020 23:02:29 +0000 (12:02 +1300)]
Merge pull request #16224 from eileenmcnaughton/set

dev/core#495 Add some ts tags on settings

4 years agoput back mistakenly removed variable
demeritcowboy [Tue, 7 Jan 2020 21:07:25 +0000 (16:07 -0500)]
put back mistakenly removed variable

4 years agodev/core#495 Add some ts tags on settings
eileen [Tue, 7 Jan 2020 19:32:19 +0000 (08:32 +1300)]
dev/core#495 Add some ts tags on settings

4 years agoRefactor CRM_Contact_BAO_Contact::importableFields() to use metadata
Coleman Watts [Tue, 7 Jan 2020 18:25:05 +0000 (13:25 -0500)]
Refactor CRM_Contact_BAO_Contact::importableFields() to use metadata

This squares up the recently added metadata with a hardcoded list in the BAO,
removing the hardcoded list in favor of metadata.

4 years agoMerge pull request #15307 from seamuslee001/dev_core_1249
Eileen McNaughton [Tue, 7 Jan 2020 04:26:07 +0000 (17:26 +1300)]
Merge pull request #15307 from seamuslee001/dev_core_1249

dev/core#1249 Allow IPNs to be validated even if the supplied contact…

4 years agoMerge pull request #15670 from eileenmcnaughton/dupe_locks
Seamus Lee [Tue, 7 Jan 2020 03:43:48 +0000 (14:43 +1100)]
Merge pull request #15670 from eileenmcnaughton/dupe_locks

dev/core#1355 Add contention handling for dedupe jobs

4 years agoMerge pull request #15948 from eileenmcnaughton/export_test
Seamus Lee [Tue, 7 Jan 2020 03:30:50 +0000 (14:30 +1100)]
Merge pull request #15948 from eileenmcnaughton/export_test

Revised version of test from #15725

4 years agoMerge pull request #16219 from seamuslee001/nfc_test_followup_16150
Seamus Lee [Tue, 7 Jan 2020 02:40:51 +0000 (13:40 +1100)]
Merge pull request #16219 from seamuslee001/nfc_test_followup_16150

[NFC] Test update following PR #16150, assertEquals first param is th…

4 years agoChange check.gif to an actual gif (was a PNG)
Coleman Watts [Tue, 7 Jan 2020 02:04:04 +0000 (21:04 -0500)]
Change check.gif to an actual gif (was a PNG)

4 years ago[NFC] Test update following PR #16150, assertEquals first param is the expected value...
Seamus Lee [Tue, 7 Jan 2020 01:36:22 +0000 (12:36 +1100)]
[NFC] Test update following PR #16150, assertEquals first param is the expected value not the current value

4 years agoMerge pull request #16150 from jitendrapurohit/dev-1499
Seamus Lee [Tue, 7 Jan 2020 01:33:58 +0000 (12:33 +1100)]
Merge pull request #16150 from jitendrapurohit/dev-1499

dev/core#1499 - Case Resource shows contact names that are not access…

4 years agoMerge pull request #15855 from eileenmcnaughton/test_dep
Seamus Lee [Tue, 7 Jan 2020 01:30:46 +0000 (12:30 +1100)]
Merge pull request #15855 from eileenmcnaughton/test_dep

Deprecate creating partially paid contributions, other than by partially paying a contribution.

4 years agoMerge pull request #16218 from seamuslee001/nfc_add_more_asserts_change_fee_selection
Seamus Lee [Tue, 7 Jan 2020 01:24:03 +0000 (12:24 +1100)]
Merge pull request #16218 from seamuslee001/nfc_add_more_asserts_change_fee_selection

[NFC] Add in more assertions around the content of line items and tot…

4 years ago[NFC] Add in more assertions around the content of line items and total amount of...
Seamus Lee [Mon, 6 Jan 2020 23:48:21 +0000 (10:48 +1100)]
[NFC] Add in more assertions around the content of line items and total amount of the contribution record

4 years agoMerge pull request #16198 from seamuslee001/parent_fetchall
Eileen McNaughton [Mon, 6 Jan 2020 21:14:36 +0000 (10:14 +1300)]
Merge pull request #16198 from seamuslee001/parent_fetchall

[REF] Update fetchAll function signature to match parent function

4 years agoMerge pull request #16213 from seamuslee001/error_handling_fix
Eileen McNaughton [Mon, 6 Jan 2020 20:23:41 +0000 (09:23 +1300)]
Merge pull request #16213 from seamuslee001/error_handling_fix

Fix Error handling following DB Package upgrade

4 years agoMerge pull request #16201 from seamuslee001/dev_core_1143_2
Monish Deb [Mon, 6 Jan 2020 08:21:37 +0000 (13:51 +0530)]
Merge pull request #16201 from seamuslee001/dev_core_1143_2

dev/core#1143 Support MySQL 8 by wrapping the word groups around in b…

4 years agoMerge pull request #16202 from seamuslee001/mysql_8_information_schema
Monish Deb [Mon, 6 Jan 2020 03:43:40 +0000 (09:13 +0530)]
Merge pull request #16202 from seamuslee001/mysql_8_information_schema

dev/core#392 Fix FTS INNDOB indexer query to work in MySQL 8 as well …

4 years agoMerge pull request #16214 from seamuslee001/mysql_8_upgrade
Monish Deb [Mon, 6 Jan 2020 03:03:41 +0000 (08:33 +0530)]
Merge pull request #16214 from seamuslee001/mysql_8_upgrade

dev/core#1143 Fix Upgrade tests on MySQL 8 by quoting reserved words

4 years agoMerge pull request #16211 from seamuslee001/wordpress_2
Seamus Lee [Mon, 6 Jan 2020 01:27:48 +0000 (12:27 +1100)]
Merge pull request #16211 from seamuslee001/wordpress_2

dev/WordPress#2 Modify the WordPress plugin version using distmaker

4 years agoMerge pull request #16197 from demeritcowboy/group-recent-items
Seamus Lee [Sun, 5 Jan 2020 23:21:41 +0000 (10:21 +1100)]
Merge pull request #16197 from demeritcowboy/group-recent-items

dev/core#1506 Fix blank group title in recent items list when editing description inline

4 years agodev/core#1143 Fix Upgrade tests on MySQL 8 by quoting reserved words
Seamus Lee [Sun, 5 Jan 2020 20:58:28 +0000 (07:58 +1100)]
dev/core#1143 Fix Upgrade tests on MySQL 8 by quoting reserved words

4 years agoFix Error handling following DB Package upgrade
Seamus Lee [Sun, 5 Jan 2020 20:44:35 +0000 (07:44 +1100)]
Fix Error handling following DB Package upgrade

4 years agoMerge pull request #16210 from mattwire/caseformactivity_simplifyif
Seamus Lee [Sun, 5 Jan 2020 00:45:19 +0000 (11:45 +1100)]
Merge pull request #16210 from mattwire/caseformactivity_simplifyif

REF Simplify if statement on case activity form

4 years agoModify the plugin version using distmaker
Seamus Lee [Sat, 4 Jan 2020 22:27:18 +0000 (09:27 +1100)]
Modify the plugin version using distmaker

4 years agodev/core#1143 Support MySQL 8 by wrapping the word groups around in backticks as...
Seamus Lee [Fri, 3 Jan 2020 20:50:40 +0000 (07:50 +1100)]
dev/core#1143 Support MySQL 8 by wrapping the word groups around in backticks as it is now a reserved word

4 years agoSimplify if statement
Matthew Wire [Sat, 4 Jan 2020 12:24:05 +0000 (12:24 +0000)]
Simplify if statement

4 years agoMerge pull request #16203 from seamuslee001/dev_core_1143_translate
Seamus Lee [Sat, 4 Jan 2020 04:40:16 +0000 (15:40 +1100)]
Merge pull request #16203 from seamuslee001/dev_core_1143_translate

dev/core#1143 Ensure that columns that are reserved words e.g. groupi…

4 years ago[REF] Update fetchAll function signature to match parent function
Seamus Lee [Fri, 3 Jan 2020 06:34:37 +0000 (17:34 +1100)]
[REF] Update fetchAll function signature to match parent function

4 years agoMerge pull request #16204 from seamuslee001/dev_core_392_logging
Seamus Lee [Sat, 4 Jan 2020 03:54:44 +0000 (14:54 +1100)]
Merge pull request #16204 from seamuslee001/dev_core_392_logging

dev/core#392 Ensure that the log_date column on logging tables is NOT…

4 years agoMerge pull request #16207 from seamuslee001/membership_392
Seamus Lee [Sat, 4 Jan 2020 03:54:03 +0000 (14:54 +1100)]
Merge pull request #16207 from seamuslee001/membership_392

dev/core#392 Fix handling of dates in getMembershipStarts function to…

4 years agoMerge pull request #16206 from seamuslee001/dev_core_1143_export
Seamus Lee [Sat, 4 Jan 2020 00:48:29 +0000 (11:48 +1100)]
Merge pull request #16206 from seamuslee001/dev_core_1143_export

dev/core#1143 Ensure that any field name when performaning an export …

4 years agodev/core#392 Fix handling of dates in getMembershipStarts function to ensure date...
Seamus Lee [Sat, 4 Jan 2020 00:16:37 +0000 (11:16 +1100)]
dev/core#392 Fix handling of dates in getMembershipStarts function to ensure date is passed to query as yyyy-mm-dd to fix test failure on MySQL 8

4 years agoMerge pull request #16199 from mattwire/copyright_headers
Seamus Lee [Fri, 3 Jan 2020 23:11:35 +0000 (10:11 +1100)]
Merge pull request #16199 from mattwire/copyright_headers

Update copyright headers following merge of #14662

4 years agoMerge pull request #16196 from eileenmcnaughton/mem_add
Seamus Lee [Fri, 3 Jan 2020 22:31:10 +0000 (09:31 +1100)]
Merge pull request #16196 from eileenmcnaughton/mem_add

[REF] Eliminate ['userID'] as an input for BAO_Membership::create

4 years agoMerge pull request #16193 from seamuslee001/enable_backticks_dao
Eileen McNaughton [Fri, 3 Jan 2020 22:03:33 +0000 (11:03 +1300)]
Merge pull request #16193 from seamuslee001/enable_backticks_dao

dev/core#1143 enable auto adding of backticks when doing an insert() or update() function

4 years agoMerge pull request #16146 from eileenmcnaughton/index_api2
Matthew Wire [Fri, 3 Jan 2020 21:22:18 +0000 (21:22 +0000)]
Merge pull request #16146 from eileenmcnaughton/index_api2

Update function to repair indexes to take table as a parameter

4 years agodev/core#392 Ensure that the log_date column on logging tables is NOT NULL in MySQL 8
Seamus Lee [Fri, 3 Jan 2020 20:59:01 +0000 (07:59 +1100)]
dev/core#392 Ensure that the log_date column on logging tables is NOT NULL in MySQL 8

4 years agodev/core#1143 Ensure that any field name when performaning an export is quoted so...
Seamus Lee [Fri, 3 Jan 2020 20:59:01 +0000 (07:59 +1100)]
dev/core#1143 Ensure that any field name when performaning an export is quoted so that if it contained a reserved word the export will still work in MySQL 8

4 years agodev/core#1143 Ensure that columns that are reserved words e.g. grouping are quoted...
Seamus Lee [Fri, 3 Jan 2020 20:58:54 +0000 (07:58 +1100)]
dev/core#1143 Ensure that columns that are reserved words e.g. grouping are quoted for use in MySQL 8 when creating the view generation queries

4 years agodev/core#392 Fix FTS INNDOB indexer query to work in MySQL 8 as well as previous...
Seamus Lee [Fri, 3 Jan 2020 20:50:45 +0000 (07:50 +1100)]
dev/core#392 Fix FTS INNDOB indexer query to work in MySQL 8 as well as previous MySQL versions

4 years agoMerge pull request #16185 from seamuslee001/dev_core_711
Eileen McNaughton [Fri, 3 Jan 2020 20:32:34 +0000 (09:32 +1300)]
Merge pull request #16185 from seamuslee001/dev_core_711

dev/core#711 Add in upgrade step for removing Google+ from website ty…

4 years agoMerge pull request #16191 from seamuslee001/mem_custom_add
Matthew Wire [Fri, 3 Jan 2020 18:28:15 +0000 (18:28 +0000)]
Merge pull request #16191 from seamuslee001/mem_custom_add

[REF] Move the storing of custom data into the add function rather th…

4 years agoUpdate copyright headers following merge of #14662
Matthew Wire [Fri, 3 Jan 2020 16:52:44 +0000 (16:52 +0000)]
Update copyright headers following merge of #14662

4 years agoMerge pull request #14662 from eileenmcnaughton/activity_pdf_71
Matthew Wire [Fri, 3 Jan 2020 16:49:37 +0000 (16:49 +0000)]
Merge pull request #14662 from eileenmcnaughton/activity_pdf_71

Add PDF letter functionality for Activities using new token processor

4 years agofix blank group title in recent items list when editing description
demeritcowboy [Fri, 3 Jan 2020 05:59:10 +0000 (00:59 -0500)]
fix blank group title in recent items list when editing description

4 years agoEliminate ['userID'] as an input for BAO_Membership::create
eileen [Fri, 3 Jan 2020 03:50:33 +0000 (16:50 +1300)]
Eliminate ['userID'] as an input for BAO_Membership::create

4 years agoMerge pull request #16194 from civicrm/5.22
Seamus Lee [Fri, 3 Jan 2020 00:17:07 +0000 (11:17 +1100)]
Merge pull request #16194 from civicrm/5.22

5.22

4 years agoMerge pull request #16192 from eileenmcnaughton/mem_add
Seamus Lee [Thu, 2 Jan 2020 23:36:03 +0000 (10:36 +1100)]
Merge pull request #16192 from eileenmcnaughton/mem_add

Remove  $ids as parameter for Membership::add

4 years agoMerge pull request #16190 from alifrumin/rn5.22
Seamus Lee [Thu, 2 Jan 2020 23:02:39 +0000 (10:02 +1100)]
Merge pull request #16190 from alifrumin/rn5.22

5.22 Release Notes Annotating and Sorting

4 years agodev/core#711 Add in upgrade step for removing Google+ from website type option value
Seamus Lee [Thu, 2 Jan 2020 07:15:30 +0000 (18:15 +1100)]
dev/core#711 Add in upgrade step for removing Google+ from website type option value

4 years agoWIP enable auto adding of backticks
Seamus Lee [Thu, 2 Jan 2020 22:28:38 +0000 (22:28 +0000)]
WIP enable auto adding of backticks

4 years agoRemove as paramter for Membership::add
eileen [Thu, 2 Jan 2020 22:14:31 +0000 (11:14 +1300)]
Remove  as paramter for Membership::add

The only place it's called with  is from create so we can handle userId there

4 years ago[REF] Move the storing of custom data into the add function rather than in the create...
Seamus Lee [Thu, 2 Jan 2020 22:07:22 +0000 (09:07 +1100)]
[REF] Move the storing of custom data into the add function rather than in the create function so it is processed before the post hook

4 years ago5.22 Release Notes Annotating and Sorting
Alice Frumin [Thu, 2 Jan 2020 20:30:38 +0000 (15:30 -0500)]
5.22 Release Notes Annotating and Sorting

4 years agoMerge pull request #16166 from eileenmcnaughton/mod_member
Seamus Lee [Thu, 2 Jan 2020 21:55:22 +0000 (08:55 +1100)]
Merge pull request #16166 from eileenmcnaughton/mod_member

Permit modified_id as a parameter for membership create api

4 years agoMerge pull request #16183 from eileenmcnaughton/acl
Seamus Lee [Thu, 2 Jan 2020 20:51:38 +0000 (07:51 +1100)]
Merge pull request #16183 from eileenmcnaughton/acl

Remove unindexed join from getACLRoles query

4 years agoMerge pull request #16188 from civicrm/5.22
Seamus Lee [Thu, 2 Jan 2020 20:43:11 +0000 (07:43 +1100)]
Merge pull request #16188 from civicrm/5.22

5.22

4 years agoMerge pull request #16177 from eileenmcnaughton/sess
Eileen McNaughton [Thu, 2 Jan 2020 20:33:05 +0000 (09:33 +1300)]
Merge pull request #16177 from eileenmcnaughton/sess

dev/drupal#98 Fix masquerade issue caused by drupal update change

4 years agoMerge pull request #16187 from agh1/5.22.0-releasenotes
Seamus Lee [Thu, 2 Jan 2020 19:58:43 +0000 (06:58 +1100)]
Merge pull request #16187 from agh1/5.22.0-releasenotes

5.22.0 release notes - initial run

4 years agoMerge pull request #16186 from mlutfy/fixSubscribeSpaces
Eileen McNaughton [Thu, 2 Jan 2020 18:31:27 +0000 (07:31 +1300)]
Merge pull request #16186 from mlutfy/fixSubscribeSpaces

Mailing Subscribe Form: remove nbsp from descriptions

4 years ago5.22.0 release notes: added boilerplate
Andrew Hunt [Thu, 2 Jan 2020 16:38:44 +0000 (11:38 -0500)]
5.22.0 release notes: added boilerplate

4 years ago5.22.0 release notes: raw from script
Andrew Hunt [Thu, 2 Jan 2020 16:32:46 +0000 (11:32 -0500)]
5.22.0 release notes: raw from script

4 years agoMailing Subscribe Form: remove nbsp from descriptions.
Mathieu Lutfy [Thu, 2 Jan 2020 14:20:49 +0000 (09:20 -0500)]
Mailing Subscribe Form: remove nbsp from descriptions.

4 years agoMerge pull request #16184 from seamuslee001/sl_update
Eileen McNaughton [Thu, 2 Jan 2020 07:21:34 +0000 (20:21 +1300)]
Merge pull request #16184 from seamuslee001/sl_update

Update my contributor details

4 years agoPermit modified_id as a parameter for membership create api
eileen [Mon, 30 Dec 2019 04:06:06 +0000 (17:06 +1300)]
Permit modified_id as a parameter for membership create api

Adding a membership create api parameter makes this accessible via the api and also allows us to deprecate & remove
the  array. Note this PR does nothing at the api level to make it available - it just takes advantage of apiv3 passing params
through to the BAO. The support is added in the BAO. However, I think we should add formal apiv4 support for modified_id
as a parameter for Membership.create - only issue is that of course it's not a 'real' param so we need to discuss /
understand how that needs to look. In general I think there are a few BAO that store modified_id

4 years agoMerge pull request #16099 from agileware/CIVICRM-1243
Eileen McNaughton [Thu, 2 Jan 2020 06:51:14 +0000 (19:51 +1300)]
Merge pull request #16099 from agileware/CIVICRM-1243

dev/core#711 remove Google+

4 years agoUpdate my contributor details
Seamus Lee [Thu, 2 Jan 2020 05:31:32 +0000 (16:31 +1100)]
Update my contributor details

4 years agoSet version to 5.23.alpha1
CiviCRM [Thu, 2 Jan 2020 04:48:37 +0000 (04:48 +0000)]
Set version to 5.23.alpha1

4 years agoSet version to 5.22.beta1
CiviCRM [Thu, 2 Jan 2020 04:42:58 +0000 (04:42 +0000)]
Set version to 5.22.beta1

4 years agoMerge pull request #16182 from seamuslee001/dev_core_1144
Seamus Lee [Thu, 2 Jan 2020 04:09:58 +0000 (15:09 +1100)]
Merge pull request #16182 from seamuslee001/dev_core_1144

dev/core#1144 (NFC) Handle fact that MySQL 8 always returns the colum…

4 years agoRemove unindexed join from getACLRoles query
eileen [Thu, 2 Jan 2020 02:58:24 +0000 (15:58 +1300)]
Remove unindexed join from getACLRoles query

Replaces the indexed join with a  WHERE  on appropriate entity_id values.

I'm not a fan of CRM_Core_OptionGroup::values('acl_role') but it's what is used on the form that saves this.

The form adds in two pseudovalues but they should stay out to respect the INNER join

4 years agodev/core#1144 (NFC) Handle fact that MySQL 8 always returns the column name as it...
Seamus Lee [Thu, 2 Jan 2020 02:34:44 +0000 (02:34 +0000)]
dev/core#1144 (NFC) Handle fact that MySQL 8 always returns the column name as it is in the DB not as it is in the query

4 years agoMerge pull request #16180 from eileenmcnaughton/act2
Seamus Lee [Thu, 2 Jan 2020 02:18:11 +0000 (13:18 +1100)]
Merge pull request #16180 from eileenmcnaughton/act2

[REF] remove unused  from getACLRoles

4 years agoMerge pull request #16181 from civicrm/5.21
Eileen McNaughton [Thu, 2 Jan 2020 01:25:53 +0000 (14:25 +1300)]
Merge pull request #16181 from civicrm/5.21

5.21 to master

4 years agoMerge pull request #16176 from eileenmcnaughton/mem_fix
Eileen McNaughton [Thu, 2 Jan 2020 01:25:17 +0000 (14:25 +1300)]
Merge pull request #16176 from eileenmcnaughton/mem_fix

dev/membership#21 fix regression on membership handling

4 years ago[REF] remove unused from getACLRoles
eileen [Thu, 2 Jan 2020 00:34:10 +0000 (13:34 +1300)]
[REF] remove unused  from getACLRoles

Following on from https://github.com/civicrm/civicrm-core/pull/16175 we now know that group_id is not
passed into this function as the only place that calls this no longer passes group id, eliminate.

4 years agoMerge pull request #16167 from eileenmcnaughton/mem2
Seamus Lee [Thu, 2 Jan 2020 00:10:48 +0000 (11:10 +1100)]
Merge pull request #16167 from eileenmcnaughton/mem2

[NFC] Add test on buildMembershipTypeValues & cleanup class

4 years agoMerge pull request #16175 from eileenmcnaughton/get_acls
Seamus Lee [Thu, 2 Jan 2020 00:09:52 +0000 (11:09 +1100)]
Merge pull request #16175 from eileenmcnaughton/get_acls

[REF] Remove unused params from function signature for getACLs

4 years agoMerge pull request #16179 from seamuslee001/dev_core_1143
Tim Otten [Wed, 1 Jan 2020 23:54:09 +0000 (15:54 -0800)]
Merge pull request #16179 from seamuslee001/dev_core_1143

dev/core#1143 dev/core#1480 Permit CiviCRM installation and running o…

4 years agoNew year (2020) test fixes. (Backport #16172)
eileen [Wed, 1 Jan 2020 03:22:32 +0000 (16:22 +1300)]
New year (2020) test fixes. (Backport #16172)

We have 8 tests failing that seem to be due to 2020 starting. This fixes 2

4 years agoMerge pull request #16178 from seamuslee001/regen_dao
Seamus Lee [Wed, 1 Jan 2020 23:12:27 +0000 (10:12 +1100)]
Merge pull request #16178 from seamuslee001/regen_dao

[NFC] Re-generate DAOs

4 years agodev/core#1143 dev/core#1480 Permit CiviCRM installation and running on MySQL 8 by...
Seamus Lee [Wed, 1 Jan 2020 22:17:16 +0000 (22:17 +0000)]
dev/core#1143 dev/core#1480 Permit CiviCRM installation and running on MySQL 8 by adding backticks around grouping

4 years ago[NFC] Re-generate DAOs
Seamus Lee [Wed, 1 Jan 2020 22:06:42 +0000 (22:06 +0000)]
[NFC] Re-generate DAOs

4 years agodev/drupal#98 Fix masquerade issue caused by drupal update change
eileen [Wed, 1 Jan 2020 22:01:06 +0000 (11:01 +1300)]
dev/drupal#98 Fix masquerade issue caused by drupal update change

4 years agodev/membership#21 fix regression on membership handling
eileen [Wed, 1 Jan 2020 21:44:22 +0000 (10:44 +1300)]
dev/membership#21 fix regression on membership handling

This turns https://lab.civicrm.org/dev/membership/issues/21#note_29439 into a patch. As new code it seems to
have triggered an underlying issue. I also have https://github.com/civicrm/civicrm-core/pull/16139 open but
would be happy to see this hit the rc & the other have a full rc cycle.

The logic for this change makes sense as described & it is trivial. This has been a very hard bug
to reproduce so I'm unable to give full steps

4 years agoAdd test on buildMembershipTypeValues & cleanup class
eileen [Mon, 9 Dec 2019 08:59:27 +0000 (21:59 +1300)]
Add test on buildMembershipTypeValues & cleanup class

I found the class wasn't running reliably in isolation so had to strip out some invalid things

4 years ago[REF] Remove unused params from function signature for getACLs
eileen [Wed, 1 Jan 2020 21:25:57 +0000 (10:25 +1300)]
[REF] Remove unused params from function signature for getACLs

It turns out this function is only called once & the second 2 acls are hard-coded so we don't need them

4 years agoMerge pull request #16172 from eileenmcnaughton/happy_new_year
Eileen McNaughton [Wed, 1 Jan 2020 20:01:38 +0000 (09:01 +1300)]
Merge pull request #16172 from eileenmcnaughton/happy_new_year

2020 test fixes.

4 years agoMerge pull request #16100 from jitendrapurohit/dev-1473
Yashodha Chaku [Wed, 1 Jan 2020 04:55:22 +0000 (10:25 +0530)]
Merge pull request #16100 from jitendrapurohit/dev-1473

dev/core#1473 - Missing address on /user when location type label dif…