Tim Otten [Wed, 24 Jan 2024 05:19:27 +0000 (21:19 -0800)]
ListUnsubscribe - Production sites really should use HTTPS
Tim Otten [Thu, 18 Jan 2024 05:51:18 +0000 (21:51 -0800)]
ListUnsubscribe - Ensure URL is always absolute
When delivering via unit-test or cron job, the URL came out absolute.
But when using web UI to "Send test", the URL was relative.
It should be absolute.
Tim Otten [Wed, 17 Jan 2024 22:36:55 +0000 (14:36 -0800)]
ListUnsubscribe - Fix VERP parsing (alternate separators; optional localpart-prefix)
Tim Otten [Thu, 11 Jan 2024 04:23:55 +0000 (20:23 -0800)]
(REF) Move testGitLabIssue1108() to its own class
BEFORE: `MailingSystemTest` (which extends `BaseMailingSystemTest`)
includes `testGitLabIssue1108($isMultilingual)`. This is
a transactional test (per `BaseMailingSystemTest::setUp()`).
AFTER: `MultingualSystemTest` includes `testGitLabIssue1108()`.
This is not a transactional test.
COMMENTS: This resolves some circumstantial flakiness in the tests.
* The problem appeared when adding an unrelated test `BaseMailingSystemTest` -- the
new test failed because of a conflict with `testGitLabIssue1108()`.
* You could also produce the problem in other cases by switching around the order of
`testGitLabIssue1108()` (e.g. hack data-provider `multiLingual()`)
* I believe the root problem is that `BaseMailingSystemTest` is written as
a transactional test -- but `testGitLabIssue1108()` does large-scale
schema changes (whenever it toggles multilingual), which makes it
non-transactional.
* The patch here prevents these kind of conflicts by putting
`testGitLabIssue1108()` in a separate (non-transactional) context.
Tim Otten [Thu, 11 Jan 2024 00:13:20 +0000 (16:13 -0800)]
CiviMail - Add status-check for civimail_unsubscribe_methods
Tim Otten [Tue, 9 Jan 2024 04:09:32 +0000 (20:09 -0800)]
CiviMail - Implement List-Unsubscibe=One-Click (with overloaded routing)
Tim Otten [Wed, 10 Jan 2024 21:54:41 +0000 (13:54 -0800)]
(REF) civicrm/mailing/unsubscribe - Add page-controller in front of form-controller
Before: `civicrm/mailing/unsubscribe` points directly to `CRM_Mailing_Form_Unsubscribe`
After: `civicrm/mailing/unsubscribe` points to `CRM_Mailing_Page_Unsubscribe`, which MAY delegate
to `CRM_Mailing_Form_Unsubscribe`
Comments:
* This is a step toward supporting one-click subscribe.
* The problem is that one-click unsubscribe MUST receive a POST on the same URL
as a user-visible form.
* In Quickform (esp `CRM_Mailing_Form_Unsubscribe`), every POST MUST give a `qfKey`.
* We need a place to process the one-click POST *without* requiring `qfKey`.
* There is a pre-existing class `CRM_Mailing_Page_Unsubscribe`. This was dead code.
The patch co-opts/re-uses the class for its own purpose.
* The old `Page` class was not referenced anywhere (by routes or other classes).
* What appears to have happened: this screen was originally a `Page`; then it was
renamed/converted to a `Form`; then shortly after, the original `Page` was re-imported
verbatim by a gsoc student. Their commit doesn't appear to make substantive use of
the `Page`. This smells like mistake in handling branches/merges/rebases.
Tim Otten [Thu, 11 Jan 2024 00:09:53 +0000 (16:09 -0800)]
Status Check Actions - Allow off-site info link ("More info"). Update docblock.
Tim Otten [Wed, 10 Jan 2024 20:43:06 +0000 (12:43 -0800)]
(NFC) Unsubscribe - Placate PhpStorm
Tim Otten [Tue, 9 Jan 2024 08:13:42 +0000 (00:13 -0800)]
LocalHttpClient - How do you make an internal/headless HTTP request?
Tim Otten [Tue, 9 Jan 2024 04:18:38 +0000 (20:18 -0800)]
CRM_Utils_System::sendResponse() - Provide copy of $response for testers
colemanw [Fri, 12 Jan 2024 21:17:58 +0000 (16:17 -0500)]
Merge pull request #28994 from demeritcowboy/lineitem
smarty3 - crash on viewing contribution
colemanw [Fri, 12 Jan 2024 20:47:48 +0000 (15:47 -0500)]
Merge pull request #28893 from eileenmcnaughton/570
Fix rc-only regression - back-office registration does not reload contact ID
colemanw [Fri, 12 Jan 2024 20:41:35 +0000 (15:41 -0500)]
Merge pull request #28966 from eileenmcnaughton/unsub
Remove possibly-unavailable job_id from unsub function
demeritcowboy [Fri, 12 Jan 2024 18:51:14 +0000 (13:51 -0500)]
fix order of operations
Eileen McNaughton [Thu, 11 Jan 2024 22:55:57 +0000 (11:55 +1300)]
Merge pull request #28959 from seamuslee001/5.70
[REF] Fix Hard Fail when loading back office add membership form with membeā¦
Tim Otten [Thu, 11 Jan 2024 21:37:10 +0000 (13:37 -0800)]
Merge pull request #28933 from eileenmcnaughton/570_import
dev/core#4781 Handle invalid deprecated fields with more grace
Yashodha Chaku [Thu, 11 Jan 2024 17:56:47 +0000 (23:26 +0530)]
Merge pull request #28970 from pradpnayak/cmsissue
Regression: fix CMS creation issue from profile
Pradeep Nayak [Thu, 11 Jan 2024 11:25:04 +0000 (11:25 +0000)]
fix CMS creation issue from profile
colemanw [Thu, 11 Jan 2024 12:25:36 +0000 (07:25 -0500)]
Merge pull request #28957 from colemanw/caseCrashFix
CiviCase - Fix crash when fetching status_id pseudoconstant
eileen [Thu, 11 Jan 2024 01:21:57 +0000 (14:21 +1300)]
Do not use job_id when looking up the mailin in unsubscribe table
eileen [Thu, 11 Jan 2024 01:13:40 +0000 (14:13 +1300)]
Remove possibly-unavailable job_id from unsub function
Seamus Lee [Thu, 11 Jan 2024 01:11:27 +0000 (12:11 +1100)]
Merge pull request #28962 from demeritcowboy/cancelurl
dev/core#4903 - undefined variable in New Individual on-the-fly popup
Seamus Lee [Wed, 10 Jan 2024 21:15:21 +0000 (08:15 +1100)]
Fix Hard Fail when loading back office add membership form with membership types with no minimum fee set
Switch to numeric 0
demeritcowboy [Thu, 11 Jan 2024 00:29:26 +0000 (19:29 -0500)]
undefined variable
eileen [Mon, 8 Jan 2024 03:29:10 +0000 (16:29 +1300)]
dev/core#4781 Handle invalid deprecated fields with more grace
colemanw [Wed, 10 Jan 2024 18:11:48 +0000 (13:11 -0500)]
CiviCase - Fix crash when fetching status_id pseudoconstant
Fixes crash reported in https://civicrm.stackexchange.com/q/46209
Seamus Lee [Wed, 10 Jan 2024 05:31:15 +0000 (16:31 +1100)]
Merge pull request #28952 from eileenmcnaughton/570_links
dev/core#4898 Add getLinks to Import api
eileen [Wed, 10 Jan 2024 04:15:11 +0000 (17:15 +1300)]
dev/core#4898 Add getLinks to Import api
Eileen McNaughton [Tue, 9 Jan 2024 23:23:54 +0000 (12:23 +1300)]
Merge pull request #28944 from ufundo/search-kit-action-links
dev/core#4897 Fix Search Kit row link conditions
Tim Otten [Tue, 9 Jan 2024 22:57:29 +0000 (14:57 -0800)]
Merge pull request #28928 from eileenmcnaughton/570-ev
dev/core#4893 Fix failure to send event emails on non-monetary events with no confirm page
benjamin [Tue, 9 Jan 2024 21:44:18 +0000 (21:44 +0000)]
conditional operator precedence fix
Tim Otten [Tue, 9 Jan 2024 21:36:22 +0000 (13:36 -0800)]
Merge pull request #28913 from eileenmcnaughton/570_ornery
Make fail-heavy test as ornery
Eileen McNaughton [Tue, 9 Jan 2024 21:05:40 +0000 (10:05 +1300)]
Merge pull request #28942 from seamuslee001/5.70
Bump follow-redirects from 1.14.8 to 1.15.4
dependabot[bot] [Tue, 9 Jan 2024 17:35:03 +0000 (17:35 +0000)]
Bump follow-redirects from 1.14.8 to 1.15.4
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.8 to 1.15.4.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.8...v1.15.4)
---
updated-dependencies:
- dependency-name: follow-redirects
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
demeritcowboy [Mon, 8 Jan 2024 14:27:12 +0000 (09:27 -0500)]
Merge pull request #28931 from eileenmcnaughton/570-weight
dev/core#4892 dev/core#4891 fix weight notices
eileen [Mon, 8 Jan 2024 00:34:56 +0000 (13:34 +1300)]
dev/core#4892 dev/core#4891 fix weight notices
eileen [Mon, 8 Jan 2024 00:07:50 +0000 (13:07 +1300)]
dev/core#4893 Fix failure to send event emails on non-monetary evetns with no confirm page
colemanw [Sun, 7 Jan 2024 23:56:45 +0000 (18:56 -0500)]
Merge pull request #28922 from colemanw/deleted-files-exclude
dev/core#4889 - Exclude tools & tests from deleted-files-list.json
colemanw [Sat, 6 Jan 2024 20:11:10 +0000 (15:11 -0500)]
Merge pull request #28907 from mlutfy/ui64
dev/user-interface#64 civicrm.css: fix cancel/done button alignment
colemanw [Sat, 6 Jan 2024 15:11:07 +0000 (10:11 -0500)]
dev/core#4889 - Exclude tools & tests from deleted-files-list.json
Eileen McNaughton [Sat, 6 Jan 2024 04:31:27 +0000 (17:31 +1300)]
Merge pull request #28919 from eileenmcnaughton/570-regen
Run regen
eileen [Sat, 6 Jan 2024 04:30:49 +0000 (17:30 +1300)]
Run regen
Tim Otten [Sat, 6 Jan 2024 03:41:50 +0000 (19:41 -0800)]
Merge pull request #28895 from eileenmcnaughton/570_pay
Fix pay-later receipt token in shipped version
eileen [Fri, 5 Jan 2024 05:37:17 +0000 (18:37 +1300)]
Add upgrade fix
Mathieu Lu [Fri, 5 Jan 2024 18:33:41 +0000 (13:33 -0500)]
dev/user-interface#64 civicrm.css: fix cancel/done button alignment
Eileen McNaughton [Sat, 6 Jan 2024 00:21:55 +0000 (13:21 +1300)]
Merge pull request #28909 from demeritcowboy/win-smarty3-alt
(alternate 2) Fix bad smarty3 compile filenames
eileen [Fri, 5 Jan 2024 23:57:38 +0000 (12:57 +1300)]
Make fail-heavy test as ornery
demeritcowboy [Fri, 5 Jan 2024 22:47:30 +0000 (17:47 -0500)]
fix bad filenames
demeritcowboy [Fri, 5 Jan 2024 15:00:07 +0000 (10:00 -0500)]
Merge pull request #28897 from demeritcowboy/json
Corrupted version.js file
demeritcowboy [Fri, 5 Jan 2024 13:55:28 +0000 (08:55 -0500)]
Merge pull request #28901 from eileenmcnaughton/smarty_uf
Smarty Syntax fix - UFGroup help file
demeritcowboy [Fri, 5 Jan 2024 05:15:56 +0000 (00:15 -0500)]
weird
eileen [Fri, 5 Jan 2024 06:19:44 +0000 (19:19 +1300)]
Smarty Syntax fix - UFGroup help file
eileen [Fri, 5 Jan 2024 05:14:59 +0000 (18:14 +1300)]
Fix pay-later receipt token in shipped version
eileen [Fri, 5 Jan 2024 04:54:16 +0000 (17:54 +1300)]
Fix validation on event-change
eileen [Fri, 5 Jan 2024 04:42:53 +0000 (17:42 +1300)]
Fix rc-only regression
CiviCRM [Fri, 5 Jan 2024 04:00:48 +0000 (04:00 +0000)]
Set version to 5.70.beta1
colemanw [Fri, 5 Jan 2024 03:42:48 +0000 (22:42 -0500)]
Merge pull request #20970 from eileenmcnaughton/inv
dev/core#2719 [REF] Deprecate legacy references to contribution_invoice_settings
Tim Otten [Fri, 5 Jan 2024 03:00:36 +0000 (19:00 -0800)]
Merge pull request #28884 from eileenmcnaughton/event_online_receipt_smarty
Fix Smarty3 error in online event registration
eileen [Thu, 4 Jan 2024 23:09:20 +0000 (12:09 +1300)]
Remove tests on outgoing handling
Eileen McNaughton [Thu, 29 Jul 2021 00:45:18 +0000 (12:45 +1200)]
dev/core#2719 [REF] Deprecate legacy references to contribution_invoice_settings
Eileen McNaughton [Thu, 4 Jan 2024 22:41:45 +0000 (11:41 +1300)]
Merge pull request #28887 from eileenmcnaughton/port_forward
Fixes Backdrop summary/detail admin theme clash
Nicol [Thu, 4 Jan 2024 16:24:40 +0000 (23:24 +0700)]
Rebases against 5.69
Eileen McNaughton [Thu, 4 Jan 2024 21:44:49 +0000 (10:44 +1300)]
Merge pull request #28882 from colemanw/productFix
[NFC] Product - Fix duplicated key in xml file
eileen [Thu, 4 Jan 2024 21:42:34 +0000 (10:42 +1300)]
Fix Smarty3 error in online event registration
colemanw [Thu, 4 Jan 2024 20:45:59 +0000 (15:45 -0500)]
Merge pull request #28873 from eileenmcnaughton/report_instance_perms
Add report instance permission check & test
colemanw [Thu, 4 Jan 2024 20:43:02 +0000 (15:43 -0500)]
Merge pull request #28716 from eileenmcnaughton/date_nz_formats
Fix month date string format support in imports
colemanw [Thu, 4 Jan 2024 20:31:35 +0000 (15:31 -0500)]
Product - Fix duplicated key in xml file
Followup fix to https://github.com/civicrm/civicrm-core/pull/28540#discussion_r1433156758
Eileen McNaughton [Thu, 4 Jan 2024 20:19:18 +0000 (09:19 +1300)]
Merge pull request #28876 from olayiwola-compucorp/filter-payment-processor
Support creating payment methods that can be hidden from user
Eileen McNaughton [Thu, 4 Jan 2024 20:16:33 +0000 (09:16 +1300)]
Merge pull request #28880 from eileenmcnaughton/import_tag
dev/core#4886 fix syntax error in contact summary template
colemanw [Thu, 4 Jan 2024 20:12:07 +0000 (15:12 -0500)]
Merge pull request #28778 from eileenmcnaughton/part_fix
Consolidate participant creation into 1 place
colemanw [Thu, 4 Jan 2024 20:11:25 +0000 (15:11 -0500)]
Merge pull request #28732 from eileenmcnaughton/event_online_no_text
Remove text version on online event receipt
Eileen McNaughton [Thu, 4 Jan 2024 19:58:37 +0000 (08:58 +1300)]
Merge pull request #28529 from MegaphoneJon/faster-activitycount
faster activity counting
Eileen McNaughton [Thu, 4 Jan 2024 19:56:35 +0000 (08:56 +1300)]
Merge pull request #27717 from colemanw/activityTab
AdminUI - Replace Contact Summary Activities tab
eileen [Thu, 4 Jan 2024 19:27:59 +0000 (08:27 +1300)]
dev/core#4886 fix syntax error in contact summary template
olayiwola-compucorp [Thu, 4 Jan 2024 12:46:36 +0000 (13:46 +0100)]
Support creating payment methods that can be hidden from user
colemanw [Thu, 4 Jan 2024 13:03:55 +0000 (08:03 -0500)]
Merge pull request #28875 from eileenmcnaughton/port
Handle auto-renew correctly on original-price-sets
eileen [Thu, 4 Jan 2024 07:14:29 +0000 (20:14 +1300)]
Handle auto-renew correctly on original-price-sets
eileen [Thu, 4 Jan 2024 05:26:25 +0000 (18:26 +1300)]
Add report instance permission check & test
Eileen McNaughton [Thu, 4 Jan 2024 09:07:29 +0000 (22:07 +1300)]
Merge pull request #28874 from eileenmcnaughton/port
Ensure auto renew is set on Membership price set
Jitendra Purohit [Thu, 4 Jan 2024 06:26:52 +0000 (11:56 +0530)]
Ensure auto renew is set on Membership price set
Eileen McNaughton [Thu, 4 Jan 2024 05:37:06 +0000 (18:37 +1300)]
Merge pull request #28863 from eileenmcnaughton/logging_detail
Add system check to warn if CiviReport disabled & logging enabled
Eileen McNaughton [Thu, 4 Jan 2024 05:18:57 +0000 (18:18 +1300)]
Merge pull request #28868 from civicrm/5.69
5.69 to master
Eileen McNaughton [Thu, 4 Jan 2024 04:48:40 +0000 (17:48 +1300)]
Merge pull request #28867 from eileenmcnaughton/report_move
Move report test to civi_report
eileen [Thu, 4 Jan 2024 01:02:26 +0000 (14:02 +1300)]
Add system check to warn if CiviReport disabled & logging enabled
Tim Otten [Thu, 4 Jan 2024 03:44:55 +0000 (21:44 -0600)]
Merge pull request #28722 from eileenmcnaughton/auto_renew
CiviMember - Fix checkbox for optional auto-renewals
eileen [Thu, 4 Jan 2024 03:29:26 +0000 (16:29 +1300)]
Move report test to civi_report
Eileen McNaughton [Thu, 4 Jan 2024 03:38:08 +0000 (16:38 +1300)]
Merge pull request #28866 from eileenmcnaughton/report_instance
Minor cleanup in ReportInstance BAO
Seamus Lee [Thu, 4 Jan 2024 03:23:55 +0000 (14:23 +1100)]
Merge pull request #28641 from colemanw/fullScreenDashlet
Dashboard Fullscreen dashlet improvements
Eileen McNaughton [Thu, 4 Jan 2024 03:21:58 +0000 (16:21 +1300)]
Merge pull request #28865 from civicrm/5.69
5.69
Eileen McNaughton [Thu, 4 Jan 2024 03:15:52 +0000 (16:15 +1300)]
Merge pull request #28860 from colemanw/deprecateDate
CoreForm - Add noisy deprecation to addDate & addDateTime functions
colemanw [Thu, 4 Jan 2024 02:47:34 +0000 (21:47 -0500)]
Merge pull request #28861 from seamuslee001/grant_report_recieved_fixed
[REF] Fix grant_report_received column to be not null and default to 0
colemanw [Thu, 4 Jan 2024 02:29:05 +0000 (21:29 -0500)]
Merge pull request #28769 from eileenmcnaughton/amountu
Declare amount private - use magic method to provide access to the old value
Seamus Lee [Thu, 4 Jan 2024 02:25:56 +0000 (13:25 +1100)]
Merge pull request #28850 from colemanw/fkColumn
APIv4 - Add fk_column to getFields metadata
Seamus Lee [Thu, 4 Jan 2024 02:25:44 +0000 (13:25 +1100)]
Merge pull request #28862 from seamuslee001/grant_search_notices
[REF] Fix Smarty Notices on Find Grants search
eileen [Wed, 3 Jan 2024 02:01:35 +0000 (15:01 +1300)]
Fix time-handling for DATE_Month_dd_yyyy format
eileen [Thu, 4 Jan 2024 02:14:19 +0000 (15:14 +1300)]
Minor cleanup in ReportInstance BAO
Seamus Lee [Thu, 4 Jan 2024 02:09:14 +0000 (13:09 +1100)]
Merge pull request #28848 from eileenmcnaughton/notice
Fix notice in workflow message examples when no price set present
colemanw [Thu, 4 Jan 2024 01:52:03 +0000 (20:52 -0500)]
Merge pull request #28847 from eileenmcnaughton/date_non_us_time_2
Fix time handling for dd_mon_yy format date strings
Seamus Lee [Thu, 4 Jan 2024 01:03:58 +0000 (12:03 +1100)]
[REF] Fix grant_report_received column to be not null and default to 0
Fix form handling