Eileen McNaughton [Tue, 4 Apr 2017 05:23:01 +0000 (17:23 +1200)]
Merge pull request #9371 from seamuslee001/CRM-19633
CRM-19633 Allow for Contribution pages to be viewed from any domain in a multisite setup
Seamus Lee [Tue, 4 Apr 2017 04:51:31 +0000 (14:51 +1000)]
CRM-19961 Schema changes to make sms provider multisite aware
Seamus Lee [Tue, 4 Apr 2017 04:32:26 +0000 (14:32 +1000)]
Move upgrade logic to .19
Seamus Lee [Mon, 19 Dec 2016 20:42:46 +0000 (07:42 +1100)]
Move upgrade logic to .16
Seamus Lee [Mon, 17 Oct 2016 20:37:02 +0000 (07:37 +1100)]
CRM-19517 allow disabled financial types to show
Andrew Hunt [Tue, 4 Apr 2017 04:28:50 +0000 (00:28 -0400)]
4.7.18 release notes: features done, Heels won, I'll finish up tomorrow
Seamus Lee [Tue, 4 Apr 2017 04:27:48 +0000 (14:27 +1000)]
Alter var and comment as per Eileen
Seamus Lee [Thu, 10 Nov 2016 20:25:30 +0000 (07:25 +1100)]
Ensure we clear out the cache just to be sure
Fix docblock
Seamus Lee [Thu, 10 Nov 2016 20:23:36 +0000 (07:23 +1100)]
Retrieve all pamyent processors if we have had an id passed in as most likely coming from a contribution form
Eileen McNaughton [Tue, 4 Apr 2017 04:20:53 +0000 (16:20 +1200)]
Merge pull request #9724 from civicrm/michaelmcandrew-CRM-19921
CRM-19921
Eileen McNaughton [Tue, 4 Apr 2017 03:20:47 +0000 (15:20 +1200)]
Merge pull request #9960 from colemanw/CRM-20029
CRM-20029 - Copy custom files when duplicating an event
Eileen McNaughton [Tue, 4 Apr 2017 03:16:34 +0000 (15:16 +1200)]
Merge pull request #10040 from jaapjansma/CRM-20333
Fixed CRM-20333: search menu visible even when a user does not has access to any contacts.
Eileen McNaughton [Mon, 3 Apr 2017 22:21:31 +0000 (10:21 +1200)]
Merge pull request #10094 from mattwire/updatesubscription_fatal
CRM-20374 Be a bit more friendly rather than crashing with fatal when we can't …
Eileen McNaughton [Mon, 3 Apr 2017 22:05:40 +0000 (10:05 +1200)]
Merge pull request #10097 from jmcclelland/CRM-20378
Crm 20378 - simplify SurveyDetail report - improve line breaks in PDF, etc.
Andrew Hunt [Mon, 3 Apr 2017 21:58:16 +0000 (17:58 -0400)]
4.7.18 release notes: raw from script
Jamie McClelland [Mon, 3 Apr 2017 20:26:12 +0000 (16:26 -0400)]
CRM-20378 - populate select aliases so totals in parens work
Without populating this variable, we get empty () when grouping.
Jamie McClelland [Mon, 3 Apr 2017 20:23:09 +0000 (16:23 -0400)]
CRM-20378 - use Form.php to handle page breaks
The only reason to override postProcess is for the page breaks
and for the custom cover sheet. We can handle the cover sheet
in compileContent and Form.php handles the page breaks for us.
Eileen McNaughton [Mon, 3 Apr 2017 19:54:09 +0000 (07:54 +1200)]
Merge pull request #10049 from twomice/CRM-19400_osm_tileserver
CRM-19400: Use Carto tileserver for OpenStreetMap.
Matthew Wire [Mon, 3 Apr 2017 14:15:41 +0000 (15:15 +0100)]
Be a bit more friendly rather than crashing with fatal when we can't update the subscription
Jitendra Purohit [Mon, 3 Apr 2017 10:04:10 +0000 (15:34 +0530)]
CRM-20343: skip status calculation when form dates are not modified.
Eileen McNaughton [Mon, 3 Apr 2017 07:46:37 +0000 (19:46 +1200)]
Merge pull request #10091 from eileenmcnaughton/trans
CRM-20371 set is_transaction on best-effort attempt to create members…
eileenmcnaugton [Mon, 3 Apr 2017 04:10:41 +0000 (16:10 +1200)]
CRM-20371 set is_transaction on best-effort attempt to create membership payment
Jitendra Purohit [Mon, 3 Apr 2017 02:44:10 +0000 (08:14 +0530)]
Add test to check mail count
Eileen McNaughton [Mon, 3 Apr 2017 01:23:08 +0000 (13:23 +1200)]
Merge pull request #10090 from fuzionnz/CRM-19967-contact_query_docs
CRM-19967 contact query docs
Chris Burgess [Fri, 3 Feb 2017 19:13:50 +0000 (08:13 +1300)]
Theoretically harmless docs fixes and rearrangement of MODE_* contstants.
Chris Burgess [Sun, 2 Apr 2017 22:11:33 +0000 (10:11 +1200)]
Link to CRM-19967 in function docs.
Chris Burgess [Fri, 3 Feb 2017 19:12:56 +0000 (08:12 +1300)]
CRM-19967: Proposed docs improvements.
Conflicts:
CRM/Contact/BAO/Query.php
Eileen McNaughton [Sun, 2 Apr 2017 05:28:33 +0000 (17:28 +1200)]
Merge pull request #10088 from lcdservices/CRM-20369
CRM-20369
Brian Shaughnessy [Sun, 2 Apr 2017 02:25:52 +0000 (22:25 -0400)]
CRM-20369 code cleanup
Brian Shaughnessy [Sun, 2 Apr 2017 02:18:17 +0000 (22:18 -0400)]
CRM-20369 mailing detail report
Brian Shaughnessy [Sun, 2 Apr 2017 02:15:15 +0000 (22:15 -0400)]
CRM-20369 mailing opened report
Brian Shaughnessy [Sun, 2 Apr 2017 02:12:49 +0000 (22:12 -0400)]
CRM-20369 mailing summary report
Brian Shaughnessy [Sun, 2 Apr 2017 02:11:37 +0000 (22:11 -0400)]
CRM-20369 mailing clicks report
Brian Shaughnessy [Sun, 2 Apr 2017 01:59:56 +0000 (21:59 -0400)]
CRM-20369 mailing bounce report
colemanw [Sat, 1 Apr 2017 04:13:35 +0000 (00:13 -0400)]
Merge pull request #10058 from colemanw/CRM-20345
CRM-20345 - Case API - Sort by client & addtimeline action
Tim Otten [Sat, 1 Apr 2017 01:59:44 +0000 (18:59 -0700)]
CRM-20345 - CRM_Utils_SQL_Select::orderBy() (#4)
* CRM-20345 - CRM_Utils_Array::crmArraySortByField - Add test. Allow multiple fields.
* CRM-20345 - CRM_Utils_SQL_Select::orderBy - Use more deterministic ordering
The technique of computing default `$weight = count($this->orderBys)`
addresses a valid point: we need to preserve ordering for existing callers
who don't specify weights -- while also allowing weights.
However, it feels weird in my gut. Not sure why -- maybe it's something like this:
```php
// A1: Non-deterministic ordering
$select->orderBy('alpha', 1);
$select->orderBy('beta');
$select->orderBy('delta', 2);
$select->orderBy('gamma', 3);
// A2: Deterministic ordering
$select->orderBy('alpha', 10);
$select->orderBy('beta');
$select->orderBy('delta', 20);
$select->orderBy('gamma', 30);
// B1: Deterministic ordering
$select->orderBy('alpha');
$select->orderBy('beta');
$select->orderBy('delta');
$select->orderBy('gamma');
// B2: Non-deterministic ordering
$select->orderBy('alpha', 1);
$select->orderBy('beta', 1);
$select->orderBy('delta', 1);
$select->orderBy('gamma', 1);
```
As a reader, I would expect A1/A2 to be the same, and I would expect B1/B2
to be the same. But they're not. If there's a collision in the `weight`s,
the ordering becomes non-deterministic (depending on obscure details or
happenstance of the PHP runtime).
Of course, there's no right answer: in A1/A2, you can plausibly put `beta`
before `alpha` or after `alpha` or after `gamma`. But it should be
determinstic so that it always winds up in the same place.
colemanw [Sat, 1 Apr 2017 00:00:17 +0000 (20:00 -0400)]
Merge pull request #10086 from JMAConsulting/CRM-20367
CRM-20367: Add wrapper function for adding and dropping Index in Upgrder
Matthew Wire [Fri, 31 Mar 2017 22:45:42 +0000 (23:45 +0100)]
Show message instead of checkbox when renew required. Hide checkbox when renew not allowed. On confirmation page change message depending if user selected auto-renew or it was mandatory
deb.monish [Fri, 31 Mar 2017 19:49:27 +0000 (01:19 +0530)]
CRM-20367: Add wrapper function for adding and dropping Index in Upgrader
Jitendra Purohit [Fri, 31 Mar 2017 13:48:08 +0000 (19:18 +0530)]
test fix
Jitendra Purohit [Fri, 31 Mar 2017 04:56:25 +0000 (10:26 +0530)]
CRM-19243: Free membership results in two email receipts
Tim Otten [Fri, 31 Mar 2017 03:24:20 +0000 (20:24 -0700)]
CRM-19813 - CRM_Utils_Hook - Don't allow conflicts in property names
Traditionally, the names of the hook parameters were advisory/aesthetic.
With the introduction of GenericHookEvent, they become first class symbols
-- and they can theoretically conflict with properties of `GenericHookEvent`
or `Event`. In particular, the parameter `$name` conflicts with
`Event::$name` in Symfony 2.x.
Eileen McNaughton [Thu, 30 Mar 2017 23:24:04 +0000 (12:24 +1300)]
Merge pull request #10083 from JMAConsulting/CRM-19715-2
CRM-19715, added upgrade script to delete current_period_opening_bala…
Tim Otten [Tue, 28 Mar 2017 07:10:38 +0000 (00:10 -0700)]
(NFC) GenericHookEvent - Update docblocks
Tim Otten [Thu, 16 Mar 2017 01:38:45 +0000 (18:38 -0700)]
CRM-19813 - CRM_Utils_Hook - Set names for `dashboard_defaults`, etal (15x)
Tim Otten [Thu, 16 Mar 2017 01:36:00 +0000 (18:36 -0700)]
CRM-19813 - CRM_Utils_Hook - Set names for `entityTypes`, etal (10x)
Tim Otten [Thu, 16 Mar 2017 01:33:29 +0000 (18:33 -0700)]
CRM-19813 - CRM_Utils_Hook - Set names for `alterReportVar`, etal (10x)
Tim Otten [Thu, 16 Mar 2017 01:30:06 +0000 (18:30 -0700)]
CRM-19813 - CRM_Utils_Hook - Set names for `alterAPIPermissions`, etal (10x)
Tim Otten [Thu, 16 Mar 2017 01:26:34 +0000 (18:26 -0700)]
CRM-19813 - CRM_Utils_Hook - Set names for `config`, `optionValues`, etal (10x)
Tim Otten [Tue, 7 Mar 2017 22:30:29 +0000 (14:30 -0800)]
CRM-19813 - CRM_Utils_Hook - Set names for `mailingTemplateTypes`, etal (10x)
Tim Otten [Tue, 7 Mar 2017 22:27:12 +0000 (14:27 -0800)]
CRM-19813 - CRM_Utils_Hook - Set names for `tokenValue`, `pageRun`, etal (9x)
Tim Otten [Tue, 7 Mar 2017 22:21:33 +0000 (14:21 -0800)]
CRM-19813 - CRM_Utils_Hook - Set names for `managed`, `dashboard`, etal (9x)
Tim Otten [Tue, 7 Mar 2017 22:16:36 +0000 (14:16 -0800)]
CRM-19813 - CRM_Utils_Hook - Set names for `links`, `preProcess`, etal (11x)
Tim Otten [Tue, 7 Mar 2017 22:13:31 +0000 (14:13 -0800)]
CRM-19813 - CRM_Utils_Hook::invoke() - Use dispatcher when possible
Tim Otten [Tue, 7 Mar 2017 08:00:03 +0000 (00:00 -0800)]
CRM-19813 - CRM_Utils_Hook::container() - Continue using legacy hooks
Tim Otten [Fri, 3 Mar 2017 22:38:20 +0000 (14:38 -0800)]
CRM-19813 - CRM_Utils_Hook - Cleanup existing dual-emit events
There are a handful of events which have been dual-emitted by explicitly
calling both the dispatcher and Hook::invoke(). The dispatcher now calls
Hook::invoke automatically (if applicable), so we can omit that.
Tim Otten [Fri, 3 Mar 2017 20:15:09 +0000 (12:15 -0800)]
CRM-19813 - GenericHookEvent - Bridge between Symfony Events and hooks
The GenericHookEvent is used to expose all traditional hooks to the Symfony
EventDispatcher.
The traditional notation for a hook is based on a function signature:
function hook_civicrm_foo($bar, &$whiz, &$bang);
Symfony Events are based on a class with properties and methods. This
requires some kind of mapping.
Symfony Events has two conventions which might be used to support that
mapping. One might implement event classes for every hook, or one might use
the `GenericEvent`. This design-decision comes with a basic trade-off
between size (total #files, #classes, #SLOC) and IDE assistance
(docs/autocomplete):
* `GenericEvent` has smaller size and less boiler-plate, but it also
provides little IDE assistance.
* Custom event classes provide more IDE assistance, but they also
inflate the size (with lots of boilerplate).
This patch implements `GenericHookEvent`, which is conceptually similar to
`GenericEvent`, but it has a few modifications:
* The `__get()` function returns references, which makes it easier to
alter data.
* The `getHookValues()` function returns an ordered list of hook arguments.
The approach of `GenericEvent` / `GenericHookEvent` seems like a reasonable
balance -- it starts out with little boilerplate, but we can incrementally
introduce subclasses. The subclasses can:
* Use docblocks for IDE support
* Use declared properties for IDE support (though you may need to customize
the constructor, etal).
* Add semantic/businessy functions.
* Override the `__get()` / `__set()` functions to be provide
different getter/setter behavior.
Tim Otten [Wed, 8 Mar 2017 09:50:12 +0000 (01:50 -0800)]
CRM-19813 - Civi::dispatcher() - Add lookup helper
The `EventDispacherInterface` is widely-used across frameworks, and this
makes it easier to lookup and autocomplete calls to the dispatcher.
Tim Otten [Tue, 7 Mar 2017 22:06:10 +0000 (14:06 -0800)]
CRM-19813 - CRM_Utils_Hook_* - Rename invoke() to invokeViaUF()
We're going to provide transitional wrapper function for `invoke()`, but
we'll still need access to the original implementations. This renames the
original implementations.
Tim Otten [Sat, 4 Mar 2017 00:52:01 +0000 (16:52 -0800)]
CRM-19813 - CRM_Utils_Hook_UnitTests::invoke() - Fix return handling
The normal `runHooks()` function has a weird protocol wherein results may be
progressively merged (if they're non-empty arrays). This revision extends
that behavior to each of the unit-test hook formulations.
The patch enables better unit-testing of CRM-19813.
Pradeep Nayak [Thu, 30 Mar 2017 21:56:50 +0000 (03:26 +0530)]
CRM-19715, added upgrade script to delete current_period_opening_balance and opening_balance if they are <> 0
----------------------------------------
* CRM-19715: Remove Close Accounting Period code
https://issues.civicrm.org/jira/browse/CRM-19715
Monish Deb [Thu, 30 Mar 2017 05:13:25 +0000 (10:43 +0530)]
Merge pull request #10006 from JMAConsulting/CRM-20022
CRM-20022 Extended function to support multiple batch labels
Eileen McNaughton [Thu, 30 Mar 2017 01:54:22 +0000 (14:54 +1300)]
Merge pull request #10055 from jitendrapurohit/CRM-20344
CRM-20344: Make 'Member Since' displayed on membership tabs for Inac…
Francis Whittle [Thu, 30 Mar 2017 00:33:34 +0000 (11:33 +1100)]
CRM-20360: Remove superfluous showing of payment options header on page load.
----------------------------------------
* CRM-20360: Payment Options heading is incorrectly shown when default amount is 0
https://issues.civicrm.org/jira/browse/CRM-20360
Coleman Watts [Thu, 30 Mar 2017 00:29:24 +0000 (20:29 -0400)]
CRM-20345 - Don't be tripped up by deleted contacts or inactive relationships
Eileen McNaughton [Wed, 29 Mar 2017 23:15:24 +0000 (12:15 +1300)]
Merge pull request #10041 from mlutfy/master-crm20336
CRM-20336: Failed contributions should be set as failed, not left as pending
Eileen McNaughton [Wed, 29 Mar 2017 22:46:39 +0000 (11:46 +1300)]
Merge pull request #10065 from colemanw/CRM-19778
CRM-19778 - Improve layout of caseType config UI
Eileen McNaughton [Wed, 29 Mar 2017 22:44:21 +0000 (11:44 +1300)]
Merge pull request #9974 from JMAConsulting/CRM-19715-2
CRM-19715 (IIDA-96), removed opening_balance and current_period_openi…
Eileen McNaughton [Wed, 29 Mar 2017 22:42:59 +0000 (11:42 +1300)]
Merge pull request #10071 from eileenmcnaughton/dedup_4
CRM-20357 remove unused Finder::dupesOfContact function.
Mathieu Lutfy [Wed, 29 Mar 2017 22:10:56 +0000 (18:10 -0400)]
CRM-20336: Failed contributions should be set as failed, not left as pending (cleanup)
Pradeep Nayak [Mon, 13 Mar 2017 14:22:22 +0000 (19:52 +0530)]
CRM-19715 (IIDA-96), removed opening_balance and current_period_opening_balance field from civicrm_financial_account table and code
----------------------------------------
* CRM-19715:
https://issues.civicrm.org/jira/browse/CRM-19715
CRM-19715, added DAO changes
----------------------------------------
* CRM-19715: Remove Close Accounting Period code
https://issues.civicrm.org/jira/browse/CRM-19715
CRM-19715, removed upgrade code to drop fields from civicrm_financial_account table
----------------------------------------
* CRM-19715: Remove Close Accounting Period code
https://issues.civicrm.org/jira/browse/CRM-19715
Eileen McNaughton [Wed, 29 Mar 2017 21:25:22 +0000 (10:25 +1300)]
Merge pull request #9985 from JMAConsulting/CRM-19715-4
CRM-19715 (IIDA-96), Removed Close Accounting Period Activity Type
Mathieu Lutfy [Wed, 29 Mar 2017 20:33:35 +0000 (16:33 -0400)]
CRM-20336: Failed contributions should be set as failed, not left as pending (more test fixes).
Eileen McNaughton [Wed, 29 Mar 2017 20:23:02 +0000 (09:23 +1300)]
Merge pull request #10077 from JMAConsulting/CRM-19715-5
CRM-19715, fixed api test so that its not affected by any deletion of…
Eileen McNaughton [Wed, 29 Mar 2017 20:21:58 +0000 (09:21 +1300)]
Merge pull request #10078 from colemanw/Icons
Icons for attachments
Eileen McNaughton [Wed, 29 Mar 2017 20:18:30 +0000 (09:18 +1300)]
Merge pull request #10069 from eileenmcnaughton/dedup_2
Towards CRM-20328 remove another call to the duplicate code
Eileen McNaughton [Wed, 29 Mar 2017 20:17:58 +0000 (09:17 +1300)]
Merge pull request #10070 from eileenmcnaughton/dedup_3
CRM-20328 code rationalisation on calling dedupe code
Eileen McNaughton [Wed, 29 Mar 2017 20:08:58 +0000 (09:08 +1300)]
Merge pull request #10046 from JMAConsulting/CRM-20332
CRM-20332 Added support for third column of actions list to be modifi…
Eileen McNaughton [Wed, 29 Mar 2017 19:57:41 +0000 (08:57 +1300)]
Merge pull request #8525 from twomice/CRM-18251b
CRM-18251 - Domain stats and VersionCheck
Mathieu Lutfy [Wed, 29 Mar 2017 19:50:54 +0000 (15:50 -0400)]
CRM-20336: Failed contributions should be set as failed, not left as pending (fix the test).
Coleman Watts [Wed, 29 Mar 2017 18:11:36 +0000 (14:11 -0400)]
Icons for attachments
colemanw [Wed, 29 Mar 2017 16:28:51 +0000 (12:28 -0400)]
Merge pull request #9729 from eileenmcnaughton/cust_date
CRM-20012, CRM-19490 (now merged & closed), CRM-18387(merged& closed), CRM-20011 (in separate pr), CRM-15948(resolved by arlready-merged-part), CRM-19911 profile date fixes & code improvement
Pradeep Nayak [Wed, 15 Mar 2017 07:07:24 +0000 (12:37 +0530)]
CRM-19715, Removed Close Accounting Period Activity Type
----------------------------------------
* CRM-19715: Remove Close Accounting Period code
https://issues.civicrm.org/jira/browse/CRM-19715
CRM-19715, updated sql to delete activity type if not present
----------------------------------------
* CRM-19715: Remove Close Accounting Period code
https://issues.civicrm.org/jira/browse/CRM-19715
CRM-19715, removed cruft
----------------------------------------
* CRM-19715: Remove Close Accounting Period code
https://issues.civicrm.org/jira/browse/CRM-19715
Pradeep Nayak [Wed, 29 Mar 2017 14:53:02 +0000 (20:23 +0530)]
CRM-19715, fixed api test so that its not affected by any deletion of activity types from core
----------------------------------------
* CRM-19715: Remove Close Accounting Period code
https://issues.civicrm.org/jira/browse/CRM-19715
Eileen McNaughton [Wed, 29 Mar 2017 10:18:03 +0000 (23:18 +1300)]
Merge pull request #10064 from eileenmcnaughton/dedup_tidy
Towards CRM-20328 remove duplicate code, towards taking extension fro…
eileen [Wed, 29 Mar 2017 07:34:24 +0000 (20:34 +1300)]
CRM-20328 further fix on deprected duplicate code.
Remove parameters only passed in in unit tests. This deprecated function is called from
only one place, so reduce parameters & testing to reflect. Remove test
that duplicates other test aside from deprecated paramter
Eileen McNaughton [Wed, 29 Mar 2017 06:58:06 +0000 (19:58 +1300)]
Merge pull request #10076 from eileenmcnaughton/master
Merge to master from 4.7.18rc
eileen [Wed, 29 Mar 2017 06:55:44 +0000 (19:55 +1300)]
Merge branch '4.7.18-rc' of https://github.com/civicrm/civicrm-core
eileen [Wed, 29 Mar 2017 06:54:25 +0000 (19:54 +1300)]
Empty merge commit to mark 4.7.18-rc merged.
Somehow we lost the merged marker with a cherry pick.
Have used merge -s ours
d46d3ea to grab these as empty-but-merged
Eileen McNaughton [Wed, 29 Mar 2017 06:46:38 +0000 (19:46 +1300)]
Merge pull request #10061 from eileenmcnaughton/fatal
CRM-20347 Fatal error on delete participant record with related contr…
Eileen McNaughton [Wed, 29 Mar 2017 06:46:07 +0000 (19:46 +1300)]
Merge from 4.7.18rc to master (#10075)
* Minor test tidy up.
(this is actually because we need a commit to do a merge to master after the same commit was merged to both).
* CRM-20342: add 'view' Api action
* CRM-19385 revert changes to order by id on prevnext_cache.
After PR #10019 was merged @bhahumanists reported on #9801 that smart group ordering was broken. The
report is lacking detail and I could not replicate it, but am reverting the search changes for safety.
After this revert sites can still experiment with dropping/altering the primary key on
-civicrm_cache
-civicrm_group_contact_cache
-civicrm_acl_cache
But not civicrm_prevnext_cache.
Although I could not replicate the search issue it seems to me that our Ubuntu test suite
is failing where the other one is not on search-related items, suggesting that
for some reason Ubuntu does not default to the natural search order, due to
some config or other difference
Eileen McNaughton [Wed, 29 Mar 2017 06:31:58 +0000 (19:31 +1300)]
Merge pull request #10073 from eileenmcnaughton/4.7.18-rc
CRM-19385 revert changes to order by id on prevnext_cache.
eileen [Wed, 29 Mar 2017 06:26:56 +0000 (19:26 +1300)]
CRM-20347 fix for fatal on view records from participant
Eileen McNaughton [Wed, 29 Mar 2017 06:03:39 +0000 (19:03 +1300)]
Merge pull request #10074 from eileenmcnaughton/master
Merge from 4.7.18rc
eileen [Wed, 29 Mar 2017 05:58:08 +0000 (18:58 +1300)]
Fix merge head on master.
Master is treating some 4.7.18-rc commits as unmerged. This just marks as merged : Merge commit '
58025217985f3c8cf'
eileen [Wed, 29 Mar 2017 05:51:24 +0000 (18:51 +1300)]
CRM-19385 revert changes to order by id on prevnext_cache.
After PR #10019 was merged @bhahumanists reported on #9801 that smart group ordering was broken. The
report is lacking detail and I could not replicate it, but am reverting the search changes for safety.
After this revert sites can still experiment with dropping/altering the primary key on
-civicrm_cache
-civicrm_group_contact_cache
-civicrm_acl_cache
But not civicrm_prevnext_cache.
Although I could not replicate the search issue it seems to me that our Ubuntu test suite
is failing where the other one is not on search-related items, suggesting that
for some reason Ubuntu does not default to the natural search order, due to
some config or other difference
Coleman Watts [Wed, 29 Mar 2017 04:48:38 +0000 (00:48 -0400)]
CRM-20345 - Allow weight to be specified for an orderBy
Functions wishing to extend & override an api sort properties can use the placeholder (1)
to maintain sort param order.
Coleman Watts [Wed, 29 Mar 2017 03:22:00 +0000 (23:22 -0400)]
CRM-20345 - Fix retrieval of primary client
Coleman Watts [Wed, 29 Mar 2017 02:53:45 +0000 (22:53 -0400)]
CRM-20345 - Remove undefined variable
Coleman Watts [Wed, 29 Mar 2017 01:28:57 +0000 (21:28 -0400)]
CRM-20355 - Add Case.addtimeline action