eileen [Wed, 20 May 2020 02:58:52 +0000 (14:58 +1200)]
Fix pricefield pseudoconstant.
The price field turns out not to be returning pseudoconstant fields for 2 reasons
1) the label field is defined but the name field is not
2) any price fields with no domain are filtered out. In my single domain db this is
all of them.
I think we can safely understand NULL domain_id as 'not restricted by domain'. For some tables
(membershipType) it is a required field but for PriceField it is not.
I would be inclined to say it should be required less often. However, where it is required thenn
the OR IS NULL should never be true
Eileen McNaughton [Mon, 18 May 2020 22:09:05 +0000 (10:09 +1200)]
Merge pull request #17330 from colemanw/dao_field
[REF] Cleanup and extract string functions specific to entity names.
Eileen McNaughton [Mon, 18 May 2020 19:51:08 +0000 (07:51 +1200)]
Merge pull request #17304 from colemanw/endCode
Switch docblock code to use markdown syntax.
colemanw [Mon, 18 May 2020 14:01:37 +0000 (10:01 -0400)]
Merge pull request #17349 from eileenmcnaughton/validate
[REF] Stop passing by reference.
Seamus Lee [Mon, 18 May 2020 08:31:42 +0000 (18:31 +1000)]
Merge pull request #17347 from eileenmcnaughton/status
Call completeOrder directly from contribute status update form
Seamus Lee [Mon, 18 May 2020 07:37:43 +0000 (17:37 +1000)]
Merge pull request #17343 from eileenmcnaughton/js_curr
Use status bounces, not fatal, in front end contribution form base class
eileen [Mon, 18 May 2020 06:56:39 +0000 (18:56 +1200)]
[REF] Stop passing by reference.
By checking in BAOContribution::loadRelatedObjects we can see it is not modified. The other 2 functions
only pass input to that function, so can also be non-variables
eileen [Mon, 18 May 2020 06:04:31 +0000 (18:04 +1200)]
Call completeOrder directly from contribute status update form
We should really call completetransaction but that has been left for later unravelling with the focus here being
to clarify the purpose of the transaction. We don't need to pass a transaction around unless it has DB changes not
yet committed - which is not eally the case here. There is no reason to invoke BaseIPN but more unravelling required...
Eileen McNaughton [Mon, 18 May 2020 05:01:22 +0000 (17:01 +1200)]
Merge pull request #17341 from seamuslee001/fatal_exception_status_bounce
dev/core#560 Replace deprecated CRM_Core_Error::fatal with either sta…
eileen [Mon, 18 May 2020 04:44:50 +0000 (16:44 +1200)]
Use status bounces, not fatal, in front end contribution form base class
Eileen McNaughton [Mon, 18 May 2020 02:45:40 +0000 (14:45 +1200)]
Merge pull request #17342 from eileenmcnaughton/event
Remove code that still seems unnecessary.
colemanw [Mon, 18 May 2020 00:46:18 +0000 (20:46 -0400)]
Merge pull request #17338 from demeritcowboy/test-from-to
[TEST] dev/core#1766 - Remove flakiness from testGetFromTo tests
eileen [Mon, 18 May 2020 00:24:48 +0000 (12:24 +1200)]
Remove code that still seems unnecessary.
Per the code comment we should not need to unset these fields as they should not be present if not required.
I guess the test for this is whether the fields are unset if we start off with a payment processor & then deselect
it in favour of pay later
Eileen McNaughton [Sun, 17 May 2020 23:58:00 +0000 (11:58 +1200)]
Merge pull request #17340 from demeritcowboy/not-yet-deprecated
[NFC] Add comment that deprecated code is actually still reachable
Seamus Lee [Sun, 17 May 2020 23:48:55 +0000 (09:48 +1000)]
dev/core#560 Replace depreacted CRM_Core_Error::fatal with either statusBounce or Exceptions as appropriate in CRM/Core folder update langauge as per demeritcowboy
Eileen McNaughton [Sun, 17 May 2020 23:01:25 +0000 (11:01 +1200)]
Merge pull request #17336 from seamuslee001/fatal_exception_status_bounce
dev/core#560 Replace some instances of CRM_Core_Error::fatal with an …
Seamus Lee [Sun, 17 May 2020 21:58:36 +0000 (07:58 +1000)]
Merge pull request #17319 from agh1/icon-links
Extend icon helper support, including for formLink
demeritcowboy [Sun, 17 May 2020 20:35:26 +0000 (16:35 -0400)]
code is still reachable
Matthew Wire [Sun, 17 May 2020 10:27:20 +0000 (11:27 +0100)]
Merge pull request #17297 from agh1/treeminus-gone
Removed last TreePlus.gif and TreeMinus.gif spots
demeritcowboy [Sat, 16 May 2020 15:11:38 +0000 (11:11 -0400)]
switch away from dataprovider for time-sensitive test
Seamus Lee [Sat, 16 May 2020 20:15:47 +0000 (06:15 +1000)]
Merge pull request #17337 from civicrm/5.26
5.26
Tim Otten [Sat, 16 May 2020 02:54:25 +0000 (19:54 -0700)]
Merge pull request #17331 from colemanw/briefName
[REF] CRM_Core_DAO_AllCoreTables::getBriefName to accept BAO name
Seamus Lee [Sat, 16 May 2020 01:20:30 +0000 (11:20 +1000)]
Merge pull request #17335 from demeritcowboy/missing-semicolon
[REF] Missing semicolon on smtp settings page, code cleanup in file-on-case, add test
Seamus Lee [Sat, 16 May 2020 01:18:20 +0000 (11:18 +1000)]
Merge pull request #17334 from seamuslee001/fix_d8_install
[REF] Fix install on Drupal 8 using new setup code
Seamus Lee [Sat, 16 May 2020 00:12:53 +0000 (10:12 +1000)]
dev/core#560 Replace some instances of CRM_Core_Error::fatal with an exception or status bounce
Seamus Lee [Fri, 15 May 2020 23:31:02 +0000 (09:31 +1000)]
[REF] Fix install on Drupal 8 using new setup code
demeritcowboy [Fri, 15 May 2020 21:47:42 +0000 (17:47 -0400)]
missing semicolon, other cleanup, add test
Seamus Lee [Fri, 15 May 2020 22:42:13 +0000 (08:42 +1000)]
Merge pull request #17291 from mfb/tracking-default
Allow click-through and open tracking to be enabled/disabled by default
Coleman Watts [Fri, 15 May 2020 15:04:04 +0000 (11:04 -0400)]
Fix CRM_Core_DAO_AllCoreTables::getBriefName to accept BAO name
This function was overly strict about not accepting BAO names, prompting end-users of the function
to do their own ad-hoc conversions before using it.
eileen [Sat, 25 Apr 2020 00:56:00 +0000 (12:56 +1200)]
[REF] Cleanup and extract string functions specific to entity names.
The function CRM_Utils_String::convertStringToCamel was being stretched to also work in entity name oddities
And an api3 utility function was being over-used.
This adds symmetrical utility functions in AllCoreTables to covert entity names between the 2 formats.
Matthew Wire [Fri, 15 May 2020 14:23:50 +0000 (15:23 +0100)]
Merge pull request #17323 from JKingsnorth/patch-14
dev/core#1762 Don't log subscription_history
Matthew Wire [Fri, 15 May 2020 14:22:50 +0000 (15:22 +0100)]
Merge pull request #17296 from agh1/fa-accordions
Accordion open-close with Font Awesome icons
Seamus Lee [Fri, 15 May 2020 06:36:57 +0000 (16:36 +1000)]
Merge pull request #17327 from demeritcowboy/poland-lower-case
[NFC] Add comment regarding lower case for Polish states
Seamus Lee [Fri, 15 May 2020 06:36:26 +0000 (16:36 +1000)]
Merge pull request #17329 from civicrm/5.26
5.26
Seamus Lee [Fri, 15 May 2020 01:28:11 +0000 (11:28 +1000)]
Merge pull request #17261 from seamuslee001/dev_core_1681
dev/core#1681 Add in deprecation notice for Systems using MySQL versions before 5.7 and require 5.5 for install
Seamus Lee [Fri, 15 May 2020 01:16:00 +0000 (11:16 +1000)]
Merge pull request #17277 from mattwire/fatalerrorhandler
Trigger fatalErrorHandler for PEAR errors and for logs with severity ERROR or higher
Seamus Lee [Fri, 15 May 2020 01:10:09 +0000 (11:10 +1000)]
Merge pull request #17307 from agh1/privacy-flag-conditional
Comm prefs: add condition param for {privacyFlag}
Seamus Lee [Fri, 15 May 2020 01:09:01 +0000 (11:09 +1000)]
Merge pull request #17310 from agh1/autorenew-active-icon
Member tab: auto-renew status was hidden from screen readers
colemanw [Fri, 15 May 2020 00:47:31 +0000 (20:47 -0400)]
Merge pull request #17326 from demeritcowboy/ts-params
Remove unneeded parameters in {ts} on membership form
Seamus Lee [Thu, 14 May 2020 23:55:38 +0000 (09:55 +1000)]
Merge pull request #17320 from totten/master-url-type
(NFC) CRM_Utils_Url - Fix declared type
demeritcowboy [Thu, 14 May 2020 23:24:09 +0000 (19:24 -0400)]
prevent someone thinking this is wrong
demeritcowboy [Thu, 14 May 2020 22:23:52 +0000 (18:23 -0400)]
unneeded parameters
Tim Otten [Thu, 14 May 2020 20:46:59 +0000 (13:46 -0700)]
Merge pull request #17322 from eileenmcnaughton/ids
(NFC) Remove some cvs docblock help
colemanw [Thu, 14 May 2020 20:08:26 +0000 (16:08 -0400)]
Merge pull request #16992 from colemanw/customSerialize
Add serialize column to civicrm_custom_field, remove "Multi-Select" html type
Matthew Wire [Thu, 14 May 2020 11:22:40 +0000 (12:22 +0100)]
Merge pull request #17314 from jitendrapurohit/dev-1758
dev/core#1758 - Fix check number and trxn id values on record payment…
Matthew Wire [Thu, 14 May 2020 11:15:12 +0000 (12:15 +0100)]
Merge pull request #17285 from agh1/no-rendered-icons-in-data-source
No rendered icons in data source
Matthew Wire [Thu, 14 May 2020 11:13:41 +0000 (12:13 +0100)]
Merge pull request #17303 from agh1/no-icon-crmbutton
crmButton: support icon=0 for no icon
John Kingsnorth [Thu, 14 May 2020 08:27:55 +0000 (09:27 +0100)]
dev/core#1762 Don't log subscription_history
eileen [Thu, 14 May 2020 06:37:00 +0000 (18:37 +1200)]
Remove some cvs docblock help
The $ pattern turns out to be cvs support. We agreed the whole block should only
stay if it adds extra info
Tim Otten [Thu, 14 May 2020 06:34:27 +0000 (23:34 -0700)]
(NFC) CRM_Utils_Url - Fix declared type
Before
------
References a non-existent type `\GuzzleHttp\Psr7\UriInterface`.
After
-----
References an existent type `\Psr\Http\Message\UriInterface`.
Seamus Lee [Thu, 14 May 2020 00:45:16 +0000 (10:45 +1000)]
Merge pull request #17306 from colemanw/priceFieldValue
Cleanup PriceFieldValue BAO
Seamus Lee [Fri, 8 May 2020 03:58:41 +0000 (13:58 +1000)]
Set minimum install MySQL version to be 5.5 and a recommended minimum of 5.7
Fix to use min install version
Seamus Lee [Fri, 8 May 2020 03:44:39 +0000 (13:44 +1000)]
Add in deprecation notice for MySQL/MariaDB versions below 5.7
Eileen McNaughton [Thu, 14 May 2020 00:16:53 +0000 (12:16 +1200)]
Merge pull request #17078 from herbdool/ui-18
Ui 18
Eileen McNaughton [Thu, 14 May 2020 00:12:47 +0000 (12:12 +1200)]
Merge pull request #17116 from lcdservices/dev-core-1721
dev/core#1721 send email to case follow-up activity assignees
Coleman Watts [Mon, 11 May 2020 14:51:53 +0000 (10:51 -0400)]
Fix setting profile defaults
Coleman Watts [Fri, 17 Apr 2020 00:34:58 +0000 (20:34 -0400)]
Fix dedupe merger handling of serialized custom fields
Coleman Watts [Fri, 17 Apr 2020 00:05:20 +0000 (20:05 -0400)]
Update contact import parser to validate serialized custom fields
Coleman Watts [Thu, 16 Apr 2020 21:56:37 +0000 (17:56 -0400)]
Custom Field serialization test fixes
Coleman Watts [Tue, 7 Apr 2020 14:57:11 +0000 (10:57 -0400)]
Cleanup references to custom field html_type
Coleman Watts [Mon, 6 Apr 2020 01:23:50 +0000 (21:23 -0400)]
Update CustomField form with 'serialize' option
Coleman Watts [Sun, 5 Apr 2020 21:06:27 +0000 (17:06 -0400)]
Eliminate Multi-Select field types
Coleman Watts [Fri, 3 Apr 2020 23:31:46 +0000 (19:31 -0400)]
APIv4 - Update custom field spec for serialize column
Coleman Watts [Fri, 3 Apr 2020 01:06:06 +0000 (21:06 -0400)]
Rely on serialize property when checking if custom field is multivalued
Coleman Watts [Fri, 3 Apr 2020 00:37:05 +0000 (20:37 -0400)]
APIv3 - Legacy handling for old way of naming serialized fields
Coleman Watts [Thu, 2 Apr 2020 21:37:59 +0000 (17:37 -0400)]
Add serialize column to civicrm_custom_field
Andrew Hunt [Wed, 13 May 2020 22:45:24 +0000 (18:45 -0400)]
Don't send bare markup to formLink, support icon link attrib instead
Seamus Lee [Wed, 13 May 2020 22:36:53 +0000 (08:36 +1000)]
Merge pull request #17311 from KarinG/clarify_amount
Clarify definition of amount field in civicrm_contribution_recur table.
Seamus Lee [Wed, 13 May 2020 22:35:54 +0000 (08:35 +1000)]
Merge pull request #17313 from civicrm/5.26
5.26
Andrew Hunt [Wed, 13 May 2020 22:34:21 +0000 (18:34 -0400)]
PHPUnit test for icon construction
Andrew Hunt [Wed, 13 May 2020 22:34:07 +0000 (18:34 -0400)]
icon helpers - allow specification of HTML attributes
Andrew Hunt [Wed, 13 May 2020 18:25:36 +0000 (14:25 -0400)]
Update icons with aria-hidden
Andrew Hunt [Wed, 13 May 2020 18:20:34 +0000 (14:20 -0400)]
Common.js Icons should be aria-hidden
colemanw [Wed, 13 May 2020 17:14:44 +0000 (13:14 -0400)]
Merge pull request #17316 from agh1/ab-test-flask-icon
A/B test: icon should be Erlenmeyer flask, not bar chart
Andrew Hunt [Wed, 13 May 2020 15:55:51 +0000 (11:55 -0400)]
A/B test: icon should be Erlenmeyer flask, not bar chart
Coleman Watts [Tue, 12 May 2020 15:41:27 +0000 (11:41 -0400)]
Switch docblock code to use markdown syntax.
We are moving toward markdown in docblock comments. This is a step in that direction.
Jitendra Purohit [Wed, 13 May 2020 12:52:39 +0000 (18:22 +0530)]
dev/core#1758 - Fix check number and trxn id values on record payment form
Seamus Lee [Wed, 13 May 2020 08:42:20 +0000 (18:42 +1000)]
Merge pull request #17265 from MegaphoneJon/mime-error-rc
[regression] Fix error on no MIME type
Seamus Lee [Wed, 13 May 2020 08:38:06 +0000 (18:38 +1000)]
Merge pull request #17309 from colemanw/MailingAB
[REF] Cleanup MailingAB BAO
KarinG [Tue, 12 May 2020 23:02:22 +0000 (17:02 -0600)]
Clarify definition of amount field in civicrm_contribution_recur table.
colemanw [Tue, 12 May 2020 22:15:03 +0000 (18:15 -0400)]
Merge pull request #17293 from agh1/sr-wrenches
Screen reader text for wrenches
colemanw [Tue, 12 May 2020 22:08:37 +0000 (18:08 -0400)]
Merge pull request #17294 from agh1/sr-rel-perms
sr-only text for relationship permissions
Andrew Hunt [Tue, 12 May 2020 19:45:13 +0000 (15:45 -0400)]
Member tab: auto-renew status was aria-hidden
Coleman Watts [Tue, 12 May 2020 17:32:48 +0000 (13:32 -0400)]
Cleanup MailingAB BAO
- Use writeRecord function instead of boilerplate.
- Use api defaults for domain_id instead of setting in BAO:
- APIv3 default domain is set via _civicrm_api3_mailing_a_b_create_spec() function.
- APIv4 FieldDomainIdSpecProvider will set it automatically based on the required property in the schema.
Andrew Hunt [Tue, 12 May 2020 18:35:26 +0000 (14:35 -0400)]
CRM.utils.formatIcon: updated function name and made condition optional
Andrew Hunt [Tue, 12 May 2020 16:33:48 +0000 (12:33 -0400)]
Comm prefs: add condition param for {privacyFlag}
Coleman Watts [Tue, 12 May 2020 15:56:56 +0000 (11:56 -0400)]
Cleanup PriceFieldValue BAO
- Use writeRecord() helper function
- Remove $ids param from add()
- Make sense of previously unused $priceFieldID variable
Andrew Hunt [Tue, 12 May 2020 15:20:07 +0000 (11:20 -0400)]
crmButton: support icon=0 for no icon
Andrew Hunt [Tue, 12 May 2020 13:58:48 +0000 (09:58 -0400)]
Update CRM/Core/Form/Renderer.php
Adopting @colemanw's suggestion since it's more of a concern that the label be blank than undefined.
Co-authored-by: colemanw <coleman@civicrm.org>
colemanw [Tue, 12 May 2020 13:37:21 +0000 (09:37 -0400)]
Merge pull request #17301 from eileenmcnaughton/recur
dev/core#1728 Ensure that custom fields that extend specified financi…
colemanw [Tue, 12 May 2020 13:36:36 +0000 (09:36 -0400)]
Merge pull request #17302 from eileenmcnaughton/mem
[REF] Minor tidy up
colemanw [Tue, 12 May 2020 12:51:10 +0000 (08:51 -0400)]
Merge pull request #17246 from agh1/review-contrib
Proceeding to confirmation page should be a "next" button not a check
eileen [Tue, 12 May 2020 07:30:04 +0000 (19:30 +1200)]
[REF] Minor tidy up
Removes a few old constructs like the value() function
eileen [Tue, 12 May 2020 07:11:37 +0000 (19:11 +1200)]
Alternate to #17156
Seamus Lee [Tue, 12 May 2020 05:44:24 +0000 (15:44 +1000)]
Merge pull request #17299 from eileenmcnaughton/recur
Add ContributionRecur crud api
colemanw [Tue, 12 May 2020 02:46:33 +0000 (22:46 -0400)]
Merge pull request #17295 from agh1/fa-more
Replaced more> icon with Font Awesome
eileen [Tue, 12 May 2020 01:58:53 +0000 (13:58 +1200)]
Add ContributionRecur crud api
Andrew Hunt [Sat, 9 May 2020 04:22:22 +0000 (00:22 -0400)]
Removed last TreePlus.gif and TreeMinus.gif spots
Andrew Hunt [Sat, 9 May 2020 04:16:13 +0000 (00:16 -0400)]
Event aggregate custom search: Remove archaic form patterns
Andrew Hunt [Sat, 9 May 2020 03:54:02 +0000 (23:54 -0400)]
Get rid of unused CRM_Core_ShowHideBlocks::links()