colemanw [Wed, 19 Jul 2023 23:55:55 +0000 (19:55 -0400)]
ScheduledReminders - Handle legacy input for limit_to
colemanw [Wed, 19 Jul 2023 21:10:32 +0000 (17:10 -0400)]
ScheduledReminders - Add option list for limit_to column and fix type
Before: limit_to column is 'boolean' in the metadata and has no option list, but
effectively it has 3 options: NULL, '0' and '1'.
After: Changed type to 'integer', added pseudoconstant, and renamed the '0' option
to '2' so it isn't as easily confused with NULL.
colemanw [Thu, 20 Jul 2023 15:05:17 +0000 (08:05 -0700)]
Merge pull request #26884 from colemanw/scheduledRemindersStandaloneForm
ScheduledReminders - Refactor form to work at a standalone url
Seamus Lee [Thu, 20 Jul 2023 08:27:39 +0000 (04:27 -0400)]
Merge pull request #26885 from civicrm/5.64
5.64
Seamus Lee [Thu, 20 Jul 2023 05:40:06 +0000 (01:40 -0400)]
Merge pull request #26868 from seamuslee001/fix_redirect_url_payment_processor_wordpress
[REF] Ensure that url that is stored as context is generated correctl…
demeritcowboy [Thu, 20 Jul 2023 05:17:34 +0000 (01:17 -0400)]
Merge pull request #25206 from mattwire/activityexternalid
Allow matching on external_identifier for source/target contacts on Activity import
Eileen McNaughton [Thu, 20 Jul 2023 03:42:50 +0000 (15:42 +1200)]
Merge pull request #26343 from larssandergreen/More-PHP8-warnings-on-Participant
Fix PHP8 tax_rate warning on Participant
colemanw [Thu, 20 Jul 2023 01:38:49 +0000 (21:38 -0400)]
ScheduledReminders - Refactor form to work at a standalone url
Eileen McNaughton [Wed, 19 Jul 2023 23:46:45 +0000 (11:46 +1200)]
Merge pull request #26883 from colemanw/adminUiVer
Mark admin_ui extension as 'beta'
colemanw [Wed, 19 Jul 2023 23:45:00 +0000 (16:45 -0700)]
Merge pull request #26882 from seamuslee001/5.64
dev/core#4439 Fix price set select broken price attr regression
Eileen McNaughton [Wed, 19 Jul 2023 23:40:32 +0000 (11:40 +1200)]
Merge pull request #26880 from colemanw/jobToJob
Job - uppercase api entity
colemanw [Wed, 19 Jul 2023 23:15:44 +0000 (19:15 -0400)]
Mark admin_ui extension as 'beta'
Seamus Lee [Wed, 19 Jul 2023 22:53:56 +0000 (18:53 -0400)]
Merge pull request #26876 from colemanw/scheduleReminderForm
[REF] ScheduleReminders - Cleanup "sublimely stupid" form code
larssandergreen [Tue, 18 Jul 2023 18:56:15 +0000 (12:56 -0600)]
Fix price set select broken price attr regression
colemanw [Wed, 19 Jul 2023 18:07:10 +0000 (14:07 -0400)]
Job - uppercase api entity
Matthew Wire [Thu, 15 Dec 2022 21:46:42 +0000 (21:46 +0000)]
Allow activity import matching source/target contact on external ID
Matthew Wire [Wed, 19 Jul 2023 14:24:42 +0000 (15:24 +0100)]
Merge pull request #26877 from colemanw/godHasAnswered
God has answered
colemanw [Wed, 19 Jul 2023 01:24:11 +0000 (21:24 -0400)]
God has answered
colemanw [Wed, 19 Jul 2023 00:30:12 +0000 (20:30 -0400)]
ScheduleReminders - Cleanup awful form code
Lots more refactoring to do, this fixes the easy-to-fix things that were obviously wrong.
colemanw [Tue, 18 Jul 2023 23:34:31 +0000 (16:34 -0700)]
Merge pull request #26867 from eileenmcnaughton/import
Fix js error on CiviImport when csv has additional fields
Eileen McNaughton [Tue, 18 Jul 2023 23:16:39 +0000 (11:16 +1200)]
Merge pull request #26875 from civicrm/5.64
5.64
Seamus Lee [Tue, 18 Jul 2023 22:51:23 +0000 (18:51 -0400)]
Merge pull request #26855 from colemanw/actionMappingCleanup
[REF] ActionMapping - Improve class structure
Eileen McNaughton [Tue, 18 Jul 2023 22:50:24 +0000 (10:50 +1200)]
Merge pull request #26874 from eileenmcnaughton/property_test
Cleanup test class, including fix undeclared property
Seamus Lee [Tue, 18 Jul 2023 22:43:34 +0000 (18:43 -0400)]
Merge pull request #26831 from totten/5.64-icon-path
(dev/core#4414) Greenwich - Fix icon path
Eileen McNaughton [Tue, 18 Jul 2023 20:37:15 +0000 (08:37 +1200)]
Cleanup test class, including fix undeclared property
demeritcowboy [Tue, 18 Jul 2023 21:45:32 +0000 (17:45 -0400)]
Merge pull request #26871 from demeritcowboy/upg-smarty
Upgrade doesn't work
demeritcowboy [Tue, 18 Jul 2023 21:45:16 +0000 (17:45 -0400)]
Merge pull request #26872 from eileenmcnaughton/custom
Remove never set property from previously shared code
demeritcowboy [Tue, 18 Jul 2023 20:04:14 +0000 (16:04 -0400)]
correct precedence
Eileen McNaughton [Tue, 18 Jul 2023 20:01:01 +0000 (08:01 +1200)]
Remove never set property from previously shared code
demeritcowboy [Tue, 18 Jul 2023 19:49:01 +0000 (15:49 -0400)]
be more literal
colemanw [Tue, 18 Jul 2023 14:46:14 +0000 (10:46 -0400)]
ActionMapping - Clean up obtuse methods of fetching a MappingInterface class
Changed calls to getMappings to use getMapping if they only needed a single value.
In some cases they could be entirely removed because they weren't using the retrieved class for anything.
Deprecated the use of 'filters' param in getMappings as it was redundant with simply calling getMapping with an id.
Seamus Lee [Tue, 18 Jul 2023 07:30:37 +0000 (03:30 -0400)]
Merge pull request #26869 from yashodha/add_tpl_class
fix duplicate id for softCredit
yashodha [Tue, 18 Jul 2023 05:19:47 +0000 (10:49 +0530)]
fix duplicate id for softCredit
Seamus Lee [Tue, 18 Jul 2023 04:45:17 +0000 (14:45 +1000)]
[REF] Ensure that url that is stored as context is generated correctly for backend usage in wordpress
Eileen McNaughton [Tue, 18 Jul 2023 03:04:55 +0000 (15:04 +1200)]
Fix js error on CiviImport when csv has additional fields
colemanw [Tue, 18 Jul 2023 00:27:51 +0000 (20:27 -0400)]
ActionMapping - Improve class structure
Completes the refactoring that began with https://github.com/civicrm/civicrm-core/pull/6687
Fully migrates from the old model based on the civicrm_action_mapping table
(dropped in https://github.com/civicrm/civicrm-core/pull/26646)
by removing all references to that structure and fully embracing the object-model.
New common base-class added to make it eaiser to implement MappingInterface.
Seamus Lee [Tue, 18 Jul 2023 00:05:00 +0000 (20:05 -0400)]
Merge pull request #26866 from eileenmcnaughton/logged
Superficial cleanup in pledge form
Tim Otten [Mon, 17 Jul 2023 21:58:02 +0000 (14:58 -0700)]
Merge pull request #26852 from totten/master-s3b
Standalone - Web-based installation for PHP built-in server
Eileen McNaughton [Mon, 17 Jul 2023 21:25:34 +0000 (09:25 +1200)]
Merge pull request #26864 from colemanw/deleteBoilerplate
[NFC] Delete unused boilerplate comments
Eileen McNaughton [Mon, 17 Jul 2023 21:05:12 +0000 (09:05 +1200)]
Superficial cleanup in pledge form
colemanw [Mon, 17 Jul 2023 18:17:41 +0000 (14:17 -0400)]
Delete unused boilerplate comments
colemanw [Mon, 17 Jul 2023 18:15:01 +0000 (11:15 -0700)]
Merge pull request #26863 from aydun/searchui_create
Create SearchUI extension
Aidan Saunders [Mon, 17 Jul 2023 17:36:51 +0000 (18:36 +0100)]
Update AdminUI & SearchUI info.xml
Aidan Saunders [Mon, 17 Jul 2023 17:07:59 +0000 (18:07 +0100)]
Move Contact Search from AdminUI to SearchUI
Aidan Saunders [Mon, 17 Jul 2023 17:07:33 +0000 (18:07 +0100)]
Create SearchUI extension
colemanw [Mon, 17 Jul 2023 16:28:10 +0000 (09:28 -0700)]
Merge pull request #26862 from yashodha/add_tpl_class
Add classes to membership results
yashodha [Mon, 17 Jul 2023 15:04:25 +0000 (20:34 +0530)]
add classes to membership results
Yashodha Chaku [Mon, 17 Jul 2023 11:57:27 +0000 (17:27 +0530)]
Merge pull request #26860 from eileenmcnaughton/member
[PHP8.2] move property declaration form CRM_Member_Form_Membership to parent
Aidan Saunders [Mon, 17 Jul 2023 09:44:35 +0000 (10:44 +0100)]
Merge pull request #26842 from colemanw/isActiveToggle
AdminUI - Add toggle for is_active
Yashodha Chaku [Mon, 17 Jul 2023 06:32:51 +0000 (12:02 +0530)]
Merge pull request #26857 from eileenmcnaughton/logged
[tests][php8.2] Use function rather than sometimes declared property for loggedInUserID
Eileen McNaughton [Mon, 17 Jul 2023 01:20:56 +0000 (13:20 +1200)]
[tests][php8.2] Use function rather than sometimes declared property for loggedInUserID
colemanw [Mon, 17 Jul 2023 03:02:23 +0000 (20:02 -0700)]
Merge pull request #26859 from eileenmcnaughton/cust_case
[php8.2] Fix undeclared properties on case custom data form
Seamus Lee [Mon, 17 Jul 2023 03:01:29 +0000 (23:01 -0400)]
Merge pull request #26858 from eileenmcnaughton/cust_by_type
Remove never-true-if
demeritcowboy [Mon, 17 Jul 2023 02:39:38 +0000 (22:39 -0400)]
Merge pull request #26845 from eileenmcnaughton/subname
Remove `_subName` property
Eileen McNaughton [Mon, 17 Jul 2023 02:05:24 +0000 (14:05 +1200)]
[php8.2] Fix undeclared properties on case custom data form
Eileen McNaughton [Mon, 17 Jul 2023 02:18:39 +0000 (14:18 +1200)]
[PHP8.2] move property declaration form CRM_Member_Form_Membership to parent
Eileen McNaughton [Mon, 17 Jul 2023 01:36:51 +0000 (13:36 +1200)]
Remove never-true-if
Tim Otten [Mon, 17 Jul 2023 00:58:45 +0000 (17:58 -0700)]
Merge pull request #26856 from seamuslee001/p82_logged_in_user
[NFC][PHP8.2] Fix dynamic property _loggedInUser
Seamus Lee [Sun, 16 Jul 2023 22:57:16 +0000 (08:57 +1000)]
[NFC][PHP8.2] Fix dynamic property _loggedInUser
colemanw [Sun, 16 Jul 2023 21:29:49 +0000 (17:29 -0400)]
ActionMapping - Rename ambiguous 'getEntity' function
Before: function getEntity() actually returns the name of the table, not the entity
After: function getEntityTable() returns table name and getEntityName() returns entity name
demeritcowboy [Sun, 16 Jul 2023 15:08:42 +0000 (11:08 -0400)]
Merge pull request #26843 from colemanw/searchKitButtons
SearchKit - fix min-width of buttons
colemanw [Sun, 16 Jul 2023 14:28:52 +0000 (07:28 -0700)]
Merge pull request #26850 from totten/master-ref-mail
(REF) CMSUser::create - Rename misleading parameter
Eileen McNaughton [Sun, 16 Jul 2023 06:35:45 +0000 (18:35 +1200)]
Merge pull request #26851 from eileenmcnaughton/unshared
Follow up fix (master only regression)
Tim Otten [Sun, 16 Jul 2023 06:12:18 +0000 (23:12 -0700)]
Setup UI - Use separate "Database" section (on standalone)
Tim Otten [Sun, 16 Jul 2023 05:55:00 +0000 (22:55 -0700)]
Setup UI - Display "Administrator" options (on standalone)
Eileen McNaughton [Sun, 16 Jul 2023 05:12:13 +0000 (17:12 +1200)]
Follow up fix
Tim Otten [Sun, 16 Jul 2023 04:54:12 +0000 (21:54 -0700)]
Standalone - Interpret the $mailParam (same way as everyone else)
Tim Otten [Sun, 16 Jul 2023 04:11:02 +0000 (21:11 -0700)]
setup - Fix php8 warnings when MySQL password is blank
Tim Otten [Sun, 16 Jul 2023 04:10:02 +0000 (21:10 -0700)]
SetupResponse - Fix php8 warning
Tim Otten [Sun, 16 Jul 2023 04:08:17 +0000 (21:08 -0700)]
SelectValues::permissions - Fix php8 warning
Tim Otten [Sun, 16 Jul 2023 04:11:12 +0000 (21:11 -0700)]
DbUtil - Report MySQL failures consistently on php7+php8
Tim Otten [Sun, 16 Jul 2023 04:11:38 +0000 (21:11 -0700)]
router.php - Enable the "civicrm-setup" UI
Tim Otten [Sun, 16 Jul 2023 03:34:20 +0000 (20:34 -0700)]
router.php - Fix for php73 compat
Tim Otten [Sun, 16 Jul 2023 03:32:14 +0000 (20:32 -0700)]
Standalone.civi-setup.php - Fix 'HTTP'/'HTTPS' detection on non-Apache environments
Tim Otten [Sun, 16 Jul 2023 04:36:16 +0000 (21:36 -0700)]
(REF) CMSUser::create - Rename misleading parameter
The second parameter is very confusing:
* The name `$mail` suggests that the parameter is an email address.
* The parameter `$mail` actually contains the name of the *field* which has the email address.
This is a weird contract. It invites misinterpretation -- and now, e.g., some of the `Standalone`
code has misused it.
To confirm that `$mail` is actually the parameter-name, note that:
1. `create()` actually looks for `$params[$mail]`
2. Callers like `CRM/Contact/Form/Task/Useradd.php` actually give a parameter name
Tim Otten [Sun, 16 Jul 2023 04:26:31 +0000 (21:26 -0700)]
Merge pull request #26771 from totten/master-s3
Standalone - Add support for development-friendly file-layouts
Eileen McNaughton [Sun, 16 Jul 2023 04:13:03 +0000 (16:13 +1200)]
Merge pull request #26839 from colemanw/searchKitActionLinksCleanup
Search kit action links cleanup
Eileen McNaughton [Sun, 16 Jul 2023 04:12:11 +0000 (16:12 +1200)]
Merge pull request #26848 from mlutfy/newEventTR
[NFC] New Event: remove empty table row
colemanw [Sun, 16 Jul 2023 01:57:42 +0000 (18:57 -0700)]
Merge pull request #26846 from eileenmcnaughton/custom
Notice fix - ensure extends_entity_column_value isset
Mathieu Lutfy [Sun, 16 Jul 2023 01:25:34 +0000 (21:25 -0400)]
New Event: remove empty table row
colemanw [Sun, 16 Jul 2023 01:18:09 +0000 (18:18 -0700)]
Merge pull request #26844 from eileenmcnaughton/unshared
Fold private `setGroupTree` function back into caller
Eileen McNaughton [Sun, 16 Jul 2023 00:05:59 +0000 (12:05 +1200)]
Notice fix - ensure extends_entity_column_value isset
Eileen McNaughton [Sat, 15 Jul 2023 23:29:51 +0000 (11:29 +1200)]
Remove subName property in favour of an internal variable
This is not used outside the function
Eileen McNaughton [Sat, 15 Jul 2023 23:26:18 +0000 (11:26 +1200)]
Remove use of subName property
Eileen McNaughton [Sat, 15 Jul 2023 23:20:23 +0000 (11:20 +1200)]
Merge pull request #26791 from jmcclelland/hide-view-only
hide view only custom fields on merge screen
Eileen McNaughton [Sat, 15 Jul 2023 23:17:28 +0000 (11:17 +1200)]
Fold private setGroupTree function back into caller
colemanw [Sat, 15 Jul 2023 20:20:42 +0000 (16:20 -0400)]
SearchKit - fix min-width of buttons
colemanw [Sat, 15 Jul 2023 20:00:33 +0000 (16:00 -0400)]
AdminUI - Add toggle for is_active
colemanw [Sat, 15 Jul 2023 16:10:48 +0000 (12:10 -0400)]
SearchKit - Ensure task links work with relationships
colemanw [Sat, 15 Jul 2023 02:16:32 +0000 (22:16 -0400)]
SearchKit - Make loading task links more efficient
colemanw [Sat, 15 Jul 2023 14:59:28 +0000 (07:59 -0700)]
Merge pull request #26837 from eileenmcnaughton/no_pre_process
Fold `preProcess` into `run`
demeritcowboy [Sat, 15 Jul 2023 14:20:40 +0000 (10:20 -0400)]
Merge pull request #26836 from eileenmcnaughton/unshared
Remove last reference to undefined property `_subType`
Eileen McNaughton [Sat, 15 Jul 2023 03:30:55 +0000 (15:30 +1200)]
Merge pull request #26838 from seamuslee001/php82_ssid_dynamic
[REF][PHP8.2] Ref fix deprecation in PHP8.2 about dynamic property _ssID
Eileen McNaughton [Sat, 15 Jul 2023 01:42:25 +0000 (13:42 +1200)]
Use internal var for groupID
colemanw [Sat, 15 Jul 2023 02:25:06 +0000 (19:25 -0700)]
Merge pull request #26835 from seamuslee001/performance_fix
Ensure that we only check permissions if we want to in getActions fol…
Seamus Lee [Sat, 15 Jul 2023 02:11:54 +0000 (12:11 +1000)]
[REF][PHP8.2] Ref fix deprecation in PHP8.2 about dynamic property _ssID
Eileen McNaughton [Sat, 15 Jul 2023 02:01:48 +0000 (14:01 +1200)]
Fold preProcess into run
there are properties that appear to be being set solely to pass variables from preProcess to
run.
preProcess is called from run and that is the only way it is accessed.
There are some forms that use the pageRun hook in the universe but this has no impact on them
colemanw [Sat, 15 Jul 2023 01:49:28 +0000 (21:49 -0400)]
SearchKit - Break getLinkInfo into 3 smaller functions
Seamus Lee [Sat, 15 Jul 2023 01:43:08 +0000 (21:43 -0400)]
Merge pull request #26834 from eileenmcnaughton/amount
[REF] Use internal variable rather than property to pass variable
Eileen McNaughton [Sat, 15 Jul 2023 01:39:02 +0000 (13:39 +1200)]
Remove last reference to undefined property ->_subType