Coleman Watts [Tue, 29 Nov 2022 01:48:30 +0000 (20:48 -0500)]
SearchKit - Minor wording change
Matthew Wire [Mon, 28 Nov 2022 17:23:17 +0000 (17:23 +0000)]
Merge pull request #25030 from mlutfy/logAuthFailed
Log API Authorization failed errors
demeritcowboy [Mon, 28 Nov 2022 16:22:44 +0000 (11:22 -0500)]
Merge pull request #25065 from JKingsnorth/standardise-ip-detection
Use IP address helper method consistently
John Kingsnorth [Mon, 28 Nov 2022 13:17:46 +0000 (13:17 +0000)]
Use IP address helper method consistently
Seamus Lee [Mon, 28 Nov 2022 07:02:37 +0000 (18:02 +1100)]
Merge pull request #24980 from colemanw/alwaysAllowAutocomplete
APIv4 - Always allow anonymous autocomplete action access
Seamus Lee [Mon, 28 Nov 2022 07:01:43 +0000 (18:01 +1100)]
Merge pull request #25064 from colemanw/contactTypes
[REF] ContactType BAO - Simplify getAllContactTypes
Coleman Watts [Mon, 28 Nov 2022 05:20:22 +0000 (00:20 -0500)]
ContactType BAO - Simplify getAllContactTypes
Looking up pseudoconstants was silly, the data is already there
Seamus Lee [Mon, 28 Nov 2022 02:13:20 +0000 (13:13 +1100)]
Merge pull request #25040 from eileenmcnaughton/import_summary
Fix Import summary to differentiate between 'valid' and 'imported'
Eileen McNaughton [Sun, 27 Nov 2022 23:07:58 +0000 (12:07 +1300)]
Merge pull request #24987 from colemanw/searchDisplayPagerCountFix
SearchKit - Fix display count when updating items on the last page
Eileen McNaughton [Sun, 27 Nov 2022 20:24:22 +0000 (09:24 +1300)]
Merge pull request #25062 from civicrm/5.56
5.56 to master
Eileen McNaughton [Sun, 27 Nov 2022 20:23:58 +0000 (09:23 +1300)]
Merge pull request #25061 from colemanw/fixAfformFilter
Afform - fix empty search filters
Mathieu Lutfy [Tue, 22 Nov 2022 21:02:04 +0000 (16:02 -0500)]
Log API Authorization failed errors
colemanw [Sun, 27 Nov 2022 16:50:41 +0000 (11:50 -0500)]
Merge pull request #25056 from aydun/messagetemplate_update
Make MessageTemplate.master_id fully joinable
Coleman Watts [Sun, 27 Nov 2022 16:26:09 +0000 (11:26 -0500)]
Afform - fix empty search filters
Fixes dev/core#3997
colemanw [Sun, 27 Nov 2022 00:48:45 +0000 (19:48 -0500)]
Merge pull request #25001 from colemanw/autofillRelationship
Afform - Autofill contacts by relationship
demeritcowboy [Sat, 26 Nov 2022 00:34:36 +0000 (19:34 -0500)]
Merge pull request #25057 from civicrm/5.56
Merge 5.56 to master
colemanw [Fri, 25 Nov 2022 22:53:20 +0000 (17:53 -0500)]
Merge pull request #25047 from eileenmcnaughton/rel_except
Fix Relationship to permit disabled relationships as duplicates & fix test
Eileen McNaughton [Fri, 25 Nov 2022 22:15:54 +0000 (11:15 +1300)]
Merge pull request #25055 from colemanw/upgraderFix
Fix upgrader to safely run multiple times
Coleman Watts [Fri, 25 Nov 2022 20:57:43 +0000 (15:57 -0500)]
Fix upgrader to safely run multiple times
Aidan Saunders [Fri, 25 Nov 2022 20:42:03 +0000 (20:42 +0000)]
Make MessageTemplate.master_id fully joinable
Move Calculated Field tests out of BAO tests - they're not BAO
Enhance test to check fields of master_id entity are returned.
demeritcowboy [Fri, 25 Nov 2022 19:50:54 +0000 (14:50 -0500)]
Merge pull request #25033 from kurund/contribution-fee-fixes
fixes dash line appended to the contribution amounts if label is empty
Coleman Watts [Fri, 18 Nov 2022 19:57:45 +0000 (14:57 -0500)]
Afform - Autofill contacts by relationship
Fixes dev/core#3453
Kurund Jalmi [Fri, 25 Nov 2022 17:27:52 +0000 (17:27 +0000)]
fixed the typo
colemanw [Fri, 25 Nov 2022 14:46:51 +0000 (09:46 -0500)]
Merge pull request #25051 from eileenmcnaughton/tok_org
Remove deprecated, probably long-broken function `replaceOrgTokens`
colemanw [Fri, 25 Nov 2022 14:45:02 +0000 (09:45 -0500)]
Merge pull request #25050 from eileenmcnaughton/token_noisy
Add noisy deprecation to deprecated contribution token functions
Yashodha Chaku [Fri, 25 Nov 2022 11:13:39 +0000 (16:43 +0530)]
Merge pull request #25049 from eileenmcnaughton/token_custom
Remove deprecated token function
demeritcowboy [Fri, 25 Nov 2022 03:53:40 +0000 (22:53 -0500)]
Merge pull request #25046 from eileenmcnaughton/rel_hook
Pass correct variable type to the hook
Eileen McNaughton [Fri, 25 Nov 2022 03:49:04 +0000 (16:49 +1300)]
Remove deprecated, probably long-broken function
Eileen McNaughton [Fri, 25 Nov 2022 03:14:52 +0000 (16:14 +1300)]
Add noisy deprecation to deprecated contribution token functions
Eileen McNaughton [Fri, 25 Nov 2022 02:36:21 +0000 (15:36 +1300)]
Remove deprecated token function
Eileen McNaughton [Fri, 25 Nov 2022 01:39:56 +0000 (14:39 +1300)]
Fix Relationship to permit disabled relationships to work & fix test
Shane Bill [Mon, 24 Oct 2022 17:08:08 +0000 (14:08 -0300)]
dev/cor#3874 Added test cases for failing relationship creation
Seamus Lee [Fri, 25 Nov 2022 00:56:50 +0000 (11:56 +1100)]
Merge pull request #25037 from eileenmcnaughton/test_fix
Test fix - setup is incongruent
Eileen McNaughton [Fri, 25 Nov 2022 00:47:48 +0000 (13:47 +1300)]
Pass correct variable type to the hook
The variable type for 'rows' is an array, not null. Fix to pass
an empty array.
I renamed it to 'rows' since that is what the hook
calls it & it is just a dummy variable from the page's
point of view
Eileen McNaughton [Thu, 24 Nov 2022 22:26:09 +0000 (11:26 +1300)]
Merge pull request #25045 from mattwire/confirmvarnames
REF: Consistent variables names in formRule for CRM/Event/Form/Register
Matthew Wire [Thu, 24 Nov 2022 20:47:32 +0000 (20:47 +0000)]
Rename variables for consistency with Register form
Matthew Wire [Thu, 24 Nov 2022 20:39:12 +0000 (20:39 +0000)]
Convert CRM_Utils_Array::value in Event/Form/Confirm
demeritcowboy [Thu, 24 Nov 2022 19:27:25 +0000 (14:27 -0500)]
Merge pull request #25043 from demeritcowboy/dao
DAOs are stale
colemanw [Thu, 24 Nov 2022 18:39:39 +0000 (13:39 -0500)]
Merge pull request #25042 from mattwire/registrationarrayvalue
REF: Replace CRM_Utils_Array::value in CRM/Event/Form/Registration
demeritcowboy [Thu, 24 Nov 2022 18:06:18 +0000 (13:06 -0500)]
dao
Matthew Wire [Thu, 24 Nov 2022 16:44:09 +0000 (16:44 +0000)]
Replace CRM_Utils_Array::value in Form/Registration
colemanw [Thu, 24 Nov 2022 04:41:35 +0000 (23:41 -0500)]
Merge pull request #25038 from eileenmcnaughton/civiimport
Use search display to view errors when using Civi-import extension
colemanw [Thu, 24 Nov 2022 04:38:51 +0000 (23:38 -0500)]
Merge pull request #24947 from colemanw/entityTypesMixin
Add entity-types-php mixin
Eileen McNaughton [Thu, 24 Nov 2022 02:34:11 +0000 (15:34 +1300)]
Fix Import summary to differentiate between 'valid' and 'imported'
Eileen McNaughton [Thu, 24 Nov 2022 00:15:00 +0000 (13:15 +1300)]
Use search display to view errors when using Civi-import extension
This replaces the link to download the csv with a link to view the search
display if civiimport is enabled, allowing re-doing within the UI
Eileen McNaughton [Wed, 23 Nov 2022 23:06:30 +0000 (12:06 +1300)]
Test fix - setup is incongruent
The point of this test is to check that line items are created. However, the test sloppily sets
the value of the contribution to be different to the recurring contribution - which is
something tested elsewhere but which is sloppy here. Fix
Tim Otten [Wed, 23 Nov 2022 22:18:56 +0000 (14:18 -0800)]
Add example+test for 'entity-types-php@1'
To some extent, there's implicit coverage because `search_kit` uses
`entity-types-php@1`. But this goes a bit further, ensuring that the
entity-type metadata is maintained consistently across different stages of
lifecycle (enable/disable/uninstall) and styles of interaction (eg local-only
phpunit and multi-process cv CLI).
Tim Otten [Wed, 23 Nov 2022 22:17:11 +0000 (14:17 -0800)]
Mixin LifecycleTest - Add phpCall() helper
This is similar to the existing phpEval() helper, but it only calls one function, and it handles escaping the params.
Tangentially, relax the return type for `phpEval()` - since it's equally valid to return scalars.
Eileen McNaughton [Wed, 23 Nov 2022 22:07:06 +0000 (11:07 +1300)]
Merge pull request #25036 from colemanw/renameFinancialTypeAccount
EntityFinancialAccount - A tale of two BAO classes
Eileen McNaughton [Wed, 23 Nov 2022 20:40:48 +0000 (09:40 +1300)]
Merge pull request #24992 from aydun/messagetemplate_schema_changes
Messagetemplate schema changes
Coleman Watts [Wed, 23 Nov 2022 20:22:45 +0000 (15:22 -0500)]
APIv3 - Don't use deprecated del() methods
This follows the same pattern as the create action - to only use BAO methods if they are not @deprecated.
Note that APIv4 already does this in the DAODeleteAction class.
Coleman Watts [Wed, 23 Nov 2022 16:58:34 +0000 (11:58 -0500)]
Alias CRM_Financial_BAO_FinancialTypeAccount -> CRM_Financial_BAO_EntityFinancialAccount
This BAO class did not follow the standard naming convention which effectively made it invisible to the API.
Why was named this way in the first place was never explained, I suspect it was simply a mistake.
A BAO class actually did get added before this PR, in
37c608f6e which further added to the confusion.
This consolidates the two classes.
Because it was an "invisible" BAO class, the create and del functions were never used by the API.
For consistency, I've therefore tagged them as @deprecated which keeps them hidden from the API.
We can add business logic back in as needed using hook listeners.
Eileen McNaughton [Wed, 23 Nov 2022 20:10:31 +0000 (09:10 +1300)]
Merge pull request #24982 from colemanw/renameMailing
Mailing - Rename DAO files for better short names
demeritcowboy [Wed, 23 Nov 2022 18:09:56 +0000 (13:09 -0500)]
Merge pull request #25035 from demeritcowboy/stat
afform/oauth-client - don't call stat on null
demeritcowboy [Wed, 23 Nov 2022 18:09:45 +0000 (13:09 -0500)]
Merge pull request #25034 from civicrm/5.56
5.56
Aidan Saunders [Wed, 23 Nov 2022 16:50:15 +0000 (16:50 +0000)]
Add `master_id` calculated field
Add tet for `master_id`
demeritcowboy [Wed, 23 Nov 2022 16:02:07 +0000 (11:02 -0500)]
don't call stat on null
demeritcowboy [Wed, 23 Nov 2022 15:36:14 +0000 (10:36 -0500)]
Merge pull request #24996 from totten/5.56-locale-uf-test
(dev/core#3979) Localization - Assign a locale for UF during negotiation
demeritcowboy [Wed, 23 Nov 2022 15:34:59 +0000 (10:34 -0500)]
Merge pull request #25012 from colemanw/civiMenuCleanup
Menubar - Fix buggy, slow loader
colemanw [Wed, 23 Nov 2022 15:21:55 +0000 (10:21 -0500)]
Merge pull request #25024 from aydun/bao_del_mailingab
Deprecate `CRM_Mailing_BAO_MailingAB::del()`
colemanw [Wed, 23 Nov 2022 15:18:17 +0000 (10:18 -0500)]
Merge pull request #25032 from eileenmcnaughton/tokens
Update location tokens for Contact to new apiv4 style
Kurund Jalmi [Wed, 23 Nov 2022 10:19:41 +0000 (10:19 +0000)]
fixes dash line appended to the contribution amounts if label is empty
Eileen McNaughton [Tue, 22 Nov 2022 01:44:03 +0000 (14:44 +1300)]
Update location tokens for Contact to new apiv4 style
Seamus Lee [Tue, 22 Nov 2022 23:27:49 +0000 (10:27 +1100)]
Merge pull request #25031 from MegaphoneJon/default-token-filter
default token filter
Jon Goldberg [Tue, 22 Nov 2022 21:29:26 +0000 (16:29 -0500)]
default token filter
Eileen McNaughton [Tue, 22 Nov 2022 21:27:20 +0000 (10:27 +1300)]
Merge pull request #25029 from christopher-yu/master
ajax batchSave() method should be static, php8 compatibility
demeritcowboy [Tue, 22 Nov 2022 21:06:40 +0000 (16:06 -0500)]
Merge pull request #25027 from civicrm/5.56
5.56
Seamus Lee [Tue, 22 Nov 2022 20:41:52 +0000 (07:41 +1100)]
Merge pull request #25006 from aydun/bao_del
More del() deprecations in favour of standard deleteRecord()
cyu [Tue, 22 Nov 2022 19:42:33 +0000 (11:42 -0800)]
ajax batchSave() method should be static, php8 compatibility
demeritcowboy [Tue, 22 Nov 2022 18:16:15 +0000 (13:16 -0500)]
Merge pull request #25022 from eileenmcnaughton/tokens
Cleanup in test class
demeritcowboy [Tue, 22 Nov 2022 17:51:10 +0000 (12:51 -0500)]
Merge pull request #25025 from mlutfy/fixAnonEventReg
Fix Authorization failed on Event Registration - 5.56 RC regression
Mathieu Lutfy [Tue, 22 Nov 2022 14:42:39 +0000 (09:42 -0500)]
Fix Authorization failed on Event Registration
Aidan Saunders [Tue, 22 Nov 2022 12:41:42 +0000 (12:41 +0000)]
Don't let missing mailing parts throw exceptions
Aidan Saunders [Mon, 21 Nov 2022 11:09:56 +0000 (11:09 +0000)]
More del() deprecations in favour of standard deleteRecord()
Aidan Saunders [Tue, 22 Nov 2022 12:28:26 +0000 (12:28 +0000)]
Deprecate `CRM_Mailing_BAO_Mailing::del()`
Aidan Saunders [Tue, 22 Nov 2022 09:25:42 +0000 (09:25 +0000)]
Deprecate `CRM_Mailing_BAO_MailingAB::del()`
Eileen McNaughton [Tue, 22 Nov 2022 01:44:03 +0000 (14:44 +1300)]
Cleanup in test class
colemanw [Tue, 22 Nov 2022 01:04:00 +0000 (20:04 -0500)]
Merge pull request #25021 from colemanw/relationshipType
Add default label field for RelationshipType entity
Coleman Watts [Mon, 21 Nov 2022 23:22:46 +0000 (18:22 -0500)]
Add default label field for RelationshipType entity
Tim Otten [Mon, 21 Nov 2022 22:32:19 +0000 (14:32 -0800)]
E2E\Api4\LocaleTest - Update to reflect current reality
Seamus Lee [Mon, 21 Nov 2022 21:23:27 +0000 (08:23 +1100)]
Merge pull request #25019 from aydun/bao_del_more
More BAO `del()` deprecations
colemanw [Mon, 21 Nov 2022 19:43:18 +0000 (14:43 -0500)]
Merge pull request #25018 from aydun/bao_del_event
Deprecate `CRM_Event_BAO_Event::del()` in favour of `deleteRecord()`
colemanw [Mon, 21 Nov 2022 19:43:03 +0000 (14:43 -0500)]
Merge pull request #25017 from aydun/bao_del_relationship
Deprecate `CRM_Contact_BAO_Relationship::del()` in favour of `deleteRecord()`
Aidan Saunders [Mon, 21 Nov 2022 19:37:58 +0000 (19:37 +0000)]
More BAO `del()` deprecations
colemanw [Mon, 21 Nov 2022 18:33:57 +0000 (13:33 -0500)]
Merge pull request #24985 from colemanw/searchDisplayDescriptions
SearchKit - Descriptions for search displays
Aidan Saunders [Mon, 21 Nov 2022 16:40:11 +0000 (16:40 +0000)]
Deprecate `CRM_Contact_BAO_Relationship::del()` in favour of
`deleteRecord()`
Move status message out of business-layer
colemanw [Mon, 21 Nov 2022 17:09:24 +0000 (12:09 -0500)]
Merge pull request #24999 from colemanw/refOptionValueDel
[REF] OptionValue - Deprecate del() function in favor of standard deleteRecord
colemanw [Mon, 21 Nov 2022 17:06:50 +0000 (12:06 -0500)]
Merge pull request #24991 from kurund/formbuilder-event-entity
add event entity to formbuilder
Aidan Saunders [Mon, 21 Nov 2022 16:37:22 +0000 (16:37 +0000)]
Deprecate `CRM_Event_BAO_Event::del()`
Coleman Watts [Mon, 21 Nov 2022 01:23:37 +0000 (20:23 -0500)]
Menubar - Fix buggy, slow loader
Yashodha Chaku [Mon, 21 Nov 2022 13:24:43 +0000 (18:54 +0530)]
Merge pull request #25016 from JMAConsulting/dev-core#3999-56
dev/core#3999 : Unable to delete price field
Monish Deb [Mon, 21 Nov 2022 08:12:05 +0000 (13:42 +0530)]
dev/core#3999 : Unable to delete price field
Seamus Lee [Mon, 21 Nov 2022 04:38:08 +0000 (15:38 +1100)]
Merge pull request #25013 from demeritcowboy/dispatcher-utilstest
[NFC] UtilsTest - convert EventDispatcher to CiviEventDispatcher
demeritcowboy [Mon, 21 Nov 2022 03:09:39 +0000 (22:09 -0500)]
Merge pull request #25010 from colemanw/minHeight
Menubar - fix height of quicksearch (Drupal9)
Seamus Lee [Mon, 21 Nov 2022 03:04:18 +0000 (14:04 +1100)]
Merge pull request #25011 from eileenmcnaughton/res
Var type fix in comment
Eileen McNaughton [Mon, 21 Nov 2022 01:04:17 +0000 (14:04 +1300)]
Var type fix in comment
Coleman Watts [Sun, 20 Nov 2022 23:15:13 +0000 (18:15 -0500)]
Menubar - fix height of quicksearch (Drupal9)
demeritcowboy [Sun, 20 Nov 2022 19:45:20 +0000 (14:45 -0500)]
convert to CiviEventDispatcher
colemanw [Sun, 20 Nov 2022 18:03:42 +0000 (13:03 -0500)]
Merge pull request #25007 from demeritcowboy/daotest2
php8 - don't pass null as string
demeritcowboy [Sun, 20 Nov 2022 01:34:59 +0000 (20:34 -0500)]
Merge pull request #25008 from demeritcowboy/daotest
[NFC] Allow running tests/phpunit/CRM/Core/DAOTest.php on mariadb