Seamus Lee [Fri, 1 Sep 2023 06:16:52 +0000 (16:16 +1000)]
Merge branch '5.65'
Seamus Lee [Fri, 1 Sep 2023 06:14:23 +0000 (02:14 -0400)]
Merge pull request #27237 from seamuslee001/dev_core_4537
dev/core#4537 Ensure that Event Registration email works when CiviCon…
Seamus Lee [Fri, 1 Sep 2023 06:00:07 +0000 (02:00 -0400)]
Merge pull request #27245 from eileenmcnaughton/party
Participant Form Test fixes
Seamus Lee [Thu, 31 Aug 2023 22:53:14 +0000 (08:53 +1000)]
dev/core#4537 Ensure that Event Registration email works when CiviContribute component is disabled and add unit test
Shift to using action object provider and rename function to remove Component
Eileen McNaughton [Fri, 1 Sep 2023 03:35:30 +0000 (15:35 +1200)]
Participant Form Test fixes
Eileen McNaughton [Fri, 1 Sep 2023 04:12:57 +0000 (16:12 +1200)]
Merge pull request #27243 from alifrumin/5.65rn
[NFC] 5.65 Release Notes
Alice Frumin [Mon, 28 Aug 2023 20:38:08 +0000 (16:38 -0400)]
[NFC] release notes 5.65
Eileen McNaughton [Fri, 1 Sep 2023 02:23:40 +0000 (14:23 +1200)]
Merge pull request #27238 from eileenmcnaughton/test_clean
Superficial clean up in test class
Eileen McNaughton [Fri, 1 Sep 2023 01:50:31 +0000 (13:50 +1200)]
Merge pull request #27236 from colemanw/textOptions
APIv4 - Add missing input type options
Eileen McNaughton [Fri, 1 Sep 2023 01:49:54 +0000 (13:49 +1200)]
Merge pull request #27228 from pradpnayak/dateFormattingIssue
PHP8 date range not rendered correctly
Eileen McNaughton [Fri, 1 Sep 2023 01:48:58 +0000 (13:48 +1200)]
Merge pull request #27239 from totten/phpstorm-adaptive-path
phpstorm - Prefer to store generated hints in source-tree
Eileen McNaughton [Fri, 1 Sep 2023 00:25:35 +0000 (12:25 +1200)]
Superficial clean up in test class
Tim Otten [Fri, 1 Sep 2023 01:04:58 +0000 (18:04 -0700)]
phpstorm - Allow manual override of data folder
Tim Otten [Fri, 1 Sep 2023 00:23:20 +0000 (17:23 -0700)]
gitignore - Ignore dynamically generated ".phpstorm.meta.php"
Tim Otten [Fri, 1 Sep 2023 00:19:40 +0000 (17:19 -0700)]
phpstorm - Prefer self-same folder for output, but fallback to [civicrm.files]
colemanw [Fri, 1 Sep 2023 00:05:16 +0000 (20:05 -0400)]
APIv4 - Add missing input type options
Tim Otten [Fri, 1 Sep 2023 00:02:20 +0000 (17:02 -0700)]
phpstorm - Move static rules into the dynamic folder
Tim Otten [Thu, 31 Aug 2023 23:47:06 +0000 (16:47 -0700)]
phpstorm - Regen code
A couple symbols were stale after prior edit to 'info.xml'
Seamus Lee [Thu, 31 Aug 2023 22:06:52 +0000 (18:06 -0400)]
Merge pull request #27224 from eileenmcnaughton/arb
Remove isset from Arb.xml
Eileen McNaughton [Thu, 31 Aug 2023 21:57:45 +0000 (09:57 +1200)]
Merge pull request #27230 from eileenmcnaughton/weight_m
Add weights to MemberSelectorSearch
Eileen McNaughton [Thu, 31 Aug 2023 09:10:15 +0000 (21:10 +1200)]
Add weights to MemberSelectorSearch
Eileen McNaughton [Thu, 31 Aug 2023 12:15:30 +0000 (00:15 +1200)]
Merge pull request #27225 from eileenmcnaughton/search_form
Cleanup signature for test function `getFormObject`
Eileen McNaughton [Thu, 31 Aug 2023 11:55:52 +0000 (23:55 +1200)]
Merge pull request #27229 from eileenmcnaughton/weigh
Add weights to MessageTemplate links
Eileen McNaughton [Thu, 31 Aug 2023 11:32:22 +0000 (23:32 +1200)]
Merge pull request #27118 from yashodha/dev-4522
(dev/core#4522) Membership Detail improvements - add sorting for Memb…
Eileen McNaughton [Thu, 31 Aug 2023 07:41:01 +0000 (19:41 +1200)]
Cleanup signature for test function getFormObject
I want to make form test functions available outside core (to wean some extensions off calling methods on the
forms that we no longer call from core. They were copy & paste from when we did). Also, I want to have some nicer form
functions.
I think getFormObject is OK-ish but I don't like the parameters that are there to support
search tests, so I am trying to split that out to allow signature change on the main function
Eileen McNaughton [Thu, 31 Aug 2023 05:56:23 +0000 (17:56 +1200)]
Add weights to MessageTemplate links
colemanw [Thu, 31 Aug 2023 10:44:32 +0000 (06:44 -0400)]
Merge pull request #27227 from eileenmcnaughton/weigh
Fix Contribution_Tab links to have weight, improve test
Pradeep Nayak [Thu, 31 Aug 2023 09:13:35 +0000 (10:13 +0100)]
PHP8 date range not rendered correctly
Eileen McNaughton [Thu, 31 Aug 2023 09:02:49 +0000 (21:02 +1200)]
Merge pull request #27217 from eileenmcnaughton/create_test
Switch tests to use createTestEntity for payment processor
Eileen McNaughton [Thu, 31 Aug 2023 06:07:40 +0000 (18:07 +1200)]
Fix Contribution_Tab links to have weight, improve test
Eileen McNaughton [Thu, 31 Aug 2023 00:55:48 +0000 (12:55 +1200)]
Switch tests to use createTestEntity for payment processor
Eileen McNaughton [Thu, 31 Aug 2023 06:13:49 +0000 (18:13 +1200)]
Remove isset from Arb.xml
The variable has already been checked so it must already be 'assigned enough'
Eileen McNaughton [Thu, 31 Aug 2023 05:43:15 +0000 (17:43 +1200)]
Merge pull request #27222 from civicrm/5.65
5.65 to master
Eileen McNaughton [Thu, 31 Aug 2023 05:19:35 +0000 (17:19 +1200)]
Merge pull request #27220 from eileenmcnaughton/detail_report
Fix undeclared properties in crufty old report
Eileen McNaughton [Thu, 31 Aug 2023 05:17:33 +0000 (17:17 +1200)]
Merge pull request #27221 from seamuslee001/dev_core_4538
dev/core#4538 Move the setting of session status into the if check wi…
Eileen McNaughton [Thu, 31 Aug 2023 05:16:42 +0000 (17:16 +1200)]
Merge pull request #27219 from eileenmcnaughton/last_decade
Remove decade-only typo
Eileen McNaughton [Thu, 31 Aug 2023 03:34:00 +0000 (15:34 +1200)]
Fix undeclared properties in crufty old report
This report doesn't really interact with anything else so I just added private properties
I also removed some deprecated function calls.
Seamus Lee [Thu, 31 Aug 2023 03:43:44 +0000 (13:43 +1000)]
dev/core#4538 Move the setting of session status into the if check within the Participant payment to ensure status is not set if it is a free event
Seamus Lee [Thu, 31 Aug 2023 03:33:57 +0000 (23:33 -0400)]
Merge pull request #27216 from eileenmcnaughton/weight2
Add weight to a few more links
Eileen McNaughton [Thu, 31 Aug 2023 03:17:24 +0000 (15:17 +1200)]
Remove decade-only typo
This is an undefined property. Nothing accesses the mis-typed version....
colemanw [Thu, 31 Aug 2023 03:14:23 +0000 (23:14 -0400)]
Merge pull request #27214 from eileenmcnaughton/block
Remove some copy & paste code
Eileen McNaughton [Thu, 31 Aug 2023 00:31:24 +0000 (12:31 +1200)]
Set weights in phpLinks
Eileen McNaughton [Thu, 31 Aug 2023 02:00:00 +0000 (14:00 +1200)]
Merge pull request #27218 from larssandergreen/remove-html2text-from-security-checks-as-package-is-gone
Remove Html2text security check, package deleted
larssandergreen [Thu, 31 Aug 2023 00:55:37 +0000 (18:55 -0600)]
Remove Html2text security check, package deleted
Eileen McNaughton [Thu, 31 Aug 2023 00:26:07 +0000 (12:26 +1200)]
Add weight to batch links
Seamus Lee [Wed, 30 Aug 2023 23:42:20 +0000 (19:42 -0400)]
Merge pull request #27200 from seamuslee001/case_remove_client
Be able to remove clients from a case from the manage case view
Eileen McNaughton [Wed, 30 Aug 2023 23:05:12 +0000 (11:05 +1200)]
Merge pull request #27215 from eileenmcnaughton/block2
Replace another badly named undeclared property
Seamus Lee [Fri, 28 Oct 2022 03:31:23 +0000 (14:31 +1100)]
[REF] Be able to remove clients from the case from manage case view
Modify to allow any other than the currently viewed contact to be removed from a case and create activity when it is removed
Remove restriction on link showing and convert to popup link
Only show x if there is more than 2 clients
Only Add in new activity type if CiviCase is enabled
Eileen McNaughton [Wed, 30 Aug 2023 22:47:23 +0000 (10:47 +1200)]
Merge pull request #27196 from colemanw/afformTabNames
Afform - make summary tab names less weird
Eileen McNaughton [Wed, 30 Aug 2023 22:15:15 +0000 (10:15 +1200)]
Replace another badly named undeclared property
Eileen McNaughton [Wed, 30 Aug 2023 22:13:01 +0000 (10:13 +1200)]
Merge pull request #27213 from eileenmcnaughton/location_1
Move no-longer-shared function back to it's form
Eileen McNaughton [Wed, 30 Aug 2023 22:11:01 +0000 (10:11 +1200)]
Remove some copy & past code
Eileen McNaughton [Wed, 30 Aug 2023 21:03:19 +0000 (09:03 +1200)]
Add notice
Eileen McNaughton [Wed, 30 Aug 2023 20:59:57 +0000 (08:59 +1200)]
Copy locationBuildForm function back to only class that calls it
Eileen McNaughton [Wed, 30 Aug 2023 20:51:29 +0000 (08:51 +1200)]
Move no-longer-shared function back to it's form
Eileen McNaughton [Wed, 30 Aug 2023 21:44:16 +0000 (09:44 +1200)]
Merge pull request #27212 from eileenmcnaughton/location
Fix notices, php errors on event location tab
Eileen McNaughton [Wed, 30 Aug 2023 21:10:01 +0000 (09:10 +1200)]
Merge pull request #27210 from MegaphoneJon/sort-groups
fix sort groups on PHP8
Eileen McNaughton [Wed, 30 Aug 2023 20:44:00 +0000 (08:44 +1200)]
Stop calling -do-nothing pre-process
Eileen McNaughton [Wed, 30 Aug 2023 20:36:21 +0000 (08:36 +1200)]
Remove unused constant
Jon Goldberg [Wed, 30 Aug 2023 18:57:39 +0000 (14:57 -0400)]
fix sort groups on PHP8
Eileen McNaughton [Wed, 30 Aug 2023 19:09:36 +0000 (07:09 +1200)]
Merge pull request #27209 from colemanw/greetingNotices
ContactSummary - Fix smarty notices in communication preferences section
colemanw [Wed, 30 Aug 2023 18:32:23 +0000 (14:32 -0400)]
Merge pull request #27208 from eileenmcnaughton/stop_testing_the_test
Remove old tests that only test test functions
colemanw [Wed, 30 Aug 2023 16:09:13 +0000 (12:09 -0400)]
ContactSummary - Fix smarty notices in communication preferences section
Mathieu Lu [Wed, 30 Aug 2023 14:52:23 +0000 (10:52 -0400)]
Merge pull request #27194 from larssandergreen/SMS-error-message
Update SMS cannot send message to specify that a mobile phone number is required
colemanw [Wed, 30 Aug 2023 13:54:19 +0000 (09:54 -0400)]
Afform - Fix setting tab contact type
colemanw [Tue, 29 Aug 2023 15:46:28 +0000 (11:46 -0400)]
Afform - make summary tab names less weird
demeritcowboy [Wed, 30 Aug 2023 12:48:30 +0000 (08:48 -0400)]
Merge pull request #27205 from eileenmcnaughton/test_easy
Simplify test
Eileen McNaughton [Wed, 30 Aug 2023 05:34:47 +0000 (17:34 +1200)]
Merge pull request #27207 from eileenmcnaughton/multi
Move smarty assign to be always assigned (notices)
Eileen McNaughton [Wed, 30 Aug 2023 04:55:39 +0000 (16:55 +1200)]
Remove old tests that only test test functions
These tests are calling the test functions to create & delete contacts- but these are not 'real'
functions - ideally we wouldn't even call them in tests. We have lots of cover for the
actual functions - so just removing
Seamus Lee [Wed, 30 Aug 2023 04:45:27 +0000 (00:45 -0400)]
Merge pull request #27206 from eileenmcnaughton/delete_test
Remove never called testCleanUp function
Eileen McNaughton [Wed, 30 Aug 2023 04:40:38 +0000 (16:40 +1200)]
Move smarty assign to be always assigned (notices)
Eileen McNaughton [Wed, 30 Aug 2023 03:28:46 +0000 (15:28 +1200)]
Remove never called testCleanUp function
deleteTestObjects is not called, except by itself, which is not called. Without
that function there is no need to 'register' the test entities either...
Eileen McNaughton [Wed, 30 Aug 2023 02:01:24 +0000 (14:01 +1200)]
Simplify test
Tim Otten [Tue, 29 Aug 2023 23:17:24 +0000 (16:17 -0700)]
Merge pull request #27138 from artfulrobot/artfulrobot-improve-initialization-crash-message
Improve initialization crash message
Eileen McNaughton [Tue, 29 Aug 2023 18:59:29 +0000 (06:59 +1200)]
Merge pull request #27198 from larssandergreen/Fix-membership-renewal-leap-year-bug
dev/core#4541 Fix membership leap year bug that causes test failure
larssandergreen [Tue, 29 Aug 2023 18:33:59 +0000 (12:33 -0600)]
Fix membership leap year bug
Rich Lott / Artful Robot [Tue, 29 Aug 2023 11:30:24 +0000 (12:30 +0100)]
Improve debug() function
larssandergreen [Tue, 29 Aug 2023 05:38:40 +0000 (23:38 -0600)]
Update SMS cannot send message to specify that a mobile phone number is required
Eileen McNaughton [Tue, 29 Aug 2023 04:22:09 +0000 (16:22 +1200)]
Merge pull request #27192 from eileenmcnaughton/hidden
[REF] Remove unreachable handling
Eileen McNaughton [Tue, 29 Aug 2023 02:39:54 +0000 (14:39 +1200)]
Merge pull request #27193 from eileenmcnaughton/hidden_2
Remove always-true empty check
Eileen McNaughton [Tue, 29 Aug 2023 02:02:24 +0000 (14:02 +1200)]
Remove always-true empty check
Per https://github.com/civicrm/civicrm-core/pull/27192
hidden_CreditCard is always empty so the check is meaningless.
The newer boolean token check is safer than the quoted string check
Eileen McNaughton [Tue, 29 Aug 2023 01:59:22 +0000 (13:59 +1200)]
Remove unreachable handling
generatePane is only called from one function & those calls have either AdditionalDetail
or Premium as the type - the rest of the handling in the function
apparently relates to before we used the payment form load method (a long time ago)
Eileen McNaughton [Tue, 29 Aug 2023 01:04:07 +0000 (13:04 +1200)]
Merge pull request #27183 from colemanw/relationshipAcls
APIv4 - Proper ACLs for relationship entity
Eileen McNaughton [Mon, 28 Aug 2023 22:41:45 +0000 (10:41 +1200)]
Merge pull request #27191 from colemanw/removeDateFields
CRM_Core_Form - Remove unused protected properties
Seamus Lee [Mon, 28 Aug 2023 22:19:05 +0000 (18:19 -0400)]
Merge pull request #27113 from eileenmcnaughton/redis_flush
Flush Redis `prevnext` cache when clearing `civicrm_cache`
Seamus Lee [Mon, 28 Aug 2023 22:18:06 +0000 (18:18 -0400)]
Merge pull request #27172 from colemanw/suffixes
[REF] Add pseudoconstant suffixes to xml/dao
Seamus Lee [Mon, 28 Aug 2023 22:15:24 +0000 (18:15 -0400)]
Merge pull request #27187 from colemanw/utilsArrayX
[REF] 🏌️ CRM_Utils_Array cleanup
Seamus Lee [Mon, 28 Aug 2023 22:13:43 +0000 (18:13 -0400)]
Merge pull request #27186 from colemanw/void
[NFC] Test - Add return type hints to test functions
Seamus Lee [Mon, 28 Aug 2023 22:13:07 +0000 (18:13 -0400)]
Merge pull request #27190 from eileenmcnaughton/domain_email_2
Fix Domain Organization form for notices & php8 compliance
Seamus Lee [Mon, 28 Aug 2023 22:12:56 +0000 (18:12 -0400)]
Merge pull request #27189 from eileenmcnaughton/domain_email
Fix notices on domain.tpl by just adding what we need
colemanw [Mon, 28 Aug 2023 21:55:44 +0000 (17:55 -0400)]
CRM_Core_Form - Remove unused var _is_pay_later_enabled
This field was added in
cbcb5b49 but was never used for anything.
colemanw [Mon, 28 Aug 2023 21:53:34 +0000 (17:53 -0400)]
CRM_Core_Form - Remove unused var _dateFields
This field was added in
5d86176 for the sake of the convertDateFieldsToMySQL() function which has since been deleted.
Tim Otten [Mon, 28 Aug 2023 21:52:12 +0000 (14:52 -0700)]
Merge pull request #27104 from mlutfy/distmakerStandalone
Distmaker: add CiviCRM Standalone support
Tim Otten [Mon, 28 Aug 2023 21:41:25 +0000 (14:41 -0700)]
Merge pull request #27181 from colemanw/api3UnusedCode
APIv3 Explorer - Delete unused code
colemanw [Mon, 28 Aug 2023 15:52:04 +0000 (11:52 -0400)]
Test - Add return type hints to test functions
Tim Otten [Mon, 28 Aug 2023 21:23:34 +0000 (14:23 -0700)]
Merge pull request #27180 from colemanw/deprecateApiWrapper
API - Soft-deprecate civicrm_api() wrapper
Eileen McNaughton [Mon, 28 Aug 2023 21:12:26 +0000 (09:12 +1200)]
Fix remaining undefined properties by no longer calling unrelated preProcess
Eileen McNaughton [Mon, 28 Aug 2023 20:50:50 +0000 (08:50 +1200)]
Fix notices on domain.tpl by just adding what we need
Eileen McNaughton [Mon, 28 Aug 2023 21:08:24 +0000 (09:08 +1200)]
Merge pull request #27188 from eileenmcnaughton/notice_1
E-notice fix - switch order of and params check around
Eileen McNaughton [Mon, 28 Aug 2023 20:50:50 +0000 (08:50 +1200)]
Fix notices on domain.tpl by just adding what we need