Tim Otten [Sat, 2 Mar 2024 20:42:29 +0000 (15:42 -0500)]
Merge pull request #29591 from colemanw/fixSkEntityGetLinks
Regression - Fix missing getLinks action in SKEntity
colemanw [Sat, 2 Mar 2024 19:30:22 +0000 (14:30 -0500)]
Regression - Fix missing getLinks action in SKEntity
colemanw [Fri, 1 Mar 2024 18:02:26 +0000 (13:02 -0500)]
Merge pull request #29548 from colemanw/searchKitTaskFix
[BACKPORT] SearchKit - Fix enable/disable links in displays
colemanw [Thu, 29 Feb 2024 22:03:14 +0000 (17:03 -0500)]
SearchKit - Fix enable/disable links in displays
This fixes task-based links (enable, disable, etc) when used as buttons, dropdowns, etc. in search displays
Eileen McNaughton [Fri, 23 Feb 2024 18:07:37 +0000 (07:07 +1300)]
Merge pull request #29485 from totten/5.70-rn-tweak
5.70.1 - Update notes
Tim Otten [Fri, 23 Feb 2024 08:57:10 +0000 (00:57 -0800)]
5.70.1 - Update notes
Tim Otten [Fri, 23 Feb 2024 06:57:00 +0000 (22:57 -0800)]
Merge pull request #29484 from totten/5.70-bump1
5.70.1 - Add notes. Set version.
Tim Otten [Fri, 23 Feb 2024 06:54:54 +0000 (22:54 -0800)]
Add release-notes/5.70.1.md
Tim Otten [Fri, 23 Feb 2024 06:54:53 +0000 (22:54 -0800)]
Set version to 5.70.1
Tim Otten [Fri, 23 Feb 2024 06:44:27 +0000 (22:44 -0800)]
Merge pull request #29428 from eileenmcnaughton/570_self
dev/core#5006 Fix event online receipt for selfcancelxfer
Tim Otten [Fri, 23 Feb 2024 04:46:27 +0000 (20:46 -0800)]
Merge pull request #29407 from eileenmcnaughton/mem_570
dev/core#5007 Fix failure to assign default membership to quick config price set
Seamus Lee [Wed, 21 Feb 2024 01:18:16 +0000 (12:18 +1100)]
Merge pull request #29455 from seamuslee001/dev_core_5005
dev/core#5005 Fix validating to allow for saving with entity sub filters that are disabled
colemanw [Wed, 21 Feb 2024 00:28:00 +0000 (19:28 -0500)]
Merge pull request #29453 from colemanw/newsFeedUnread
News Dashlet - Fix styling of unread items
Seamus Lee [Tue, 20 Feb 2024 03:07:40 +0000 (14:07 +1100)]
Try fixing test failures
Seamus Lee [Mon, 19 Feb 2024 23:09:27 +0000 (10:09 +1100)]
dev/core#5005 Fix validating to allow for saving with entity sub filters that are disabled
colemanw [Tue, 20 Feb 2024 22:34:02 +0000 (17:34 -0500)]
News Dashlet - Fix styling of unread items
Adjusts css to target the new disclosure element markup,
and removes dependence on the deprecated `crmAccordion:open` event.
eileen [Thu, 15 Feb 2024 23:26:48 +0000 (12:26 +1300)]
dev/core#5006 Fix event online receipt for selfcancelxfer
Eileen McNaughton [Sun, 18 Feb 2024 22:12:51 +0000 (11:12 +1300)]
Merge pull request #29401 from colemanw/unicodeHtmlBP
Afform - Fix incorrect html encoding when saving
Eileen McNaughton [Sun, 18 Feb 2024 22:04:55 +0000 (11:04 +1300)]
Merge pull request #29420 from MegaphoneJon/active-premiums
dev/core#5014 don't show premiums unless premiums are active
Jon Goldberg [Fri, 16 Feb 2024 23:36:25 +0000 (18:36 -0500)]
don't show premiums unless premiums are active
colemanw [Fri, 16 Feb 2024 11:46:02 +0000 (06:46 -0500)]
Merge pull request #29416 from eileenmcnaughton/570
dev/core#5012 Fix SmartyCompatibility to use php8.3 friendly function
eileen [Fri, 16 Feb 2024 03:40:44 +0000 (16:40 +1300)]
Fix SmartyCompatibility to use php8.3 friendly function
eileen [Thu, 15 Feb 2024 23:16:10 +0000 (12:16 +1300)]
dev/core#5007 Fix failure to assign default membership to quick config price set
colemanw [Thu, 15 Feb 2024 16:42:33 +0000 (11:42 -0500)]
Afform - Fix incorrect html encoding when saving
Fixes https://lab.civicrm.org/dev/core/-/issues/4977
This reverts
0ae1b99 AND
4a439e7 back to the original version which used a simple str_replace.
The problem with
4a439e7 is that function mode is deprecated in php 8.2.
The problem with
0ae1b99 is that it was wrong and broke the html encoding of the file.
So this takes us all the way back to the original version of the function, which worked fine for what it did.
Eileen McNaughton [Tue, 13 Feb 2024 19:58:11 +0000 (08:58 +1300)]
Merge pull request #29379 from seamuslee001/5.70
dev/4989 Fix non-default currency in contribution confirm and thank-y…
John Kingsnorth [Mon, 12 Feb 2024 23:30:24 +0000 (23:30 +0000)]
dev/4989 Fix non-default currency in contribution confirm and thank-you pages
Eileen McNaughton [Tue, 13 Feb 2024 00:32:19 +0000 (13:32 +1300)]
Merge pull request #29374 from eileenmcnaughton/570
APIv4 - Fetch all options when matching pseudoconstants.
colemanw [Sun, 11 Feb 2024 23:02:57 +0000 (18:02 -0500)]
APIv4 - Fetch all options when matching pseudoconstants.
When performing a match we want to fetch all options not a filtered list.
Fixes https://lab.civicrm.org/dev/core/-/issues/4997
CiviCRM [Fri, 9 Feb 2024 04:49:40 +0000 (23:49 -0500)]
Set version to 5.70.0
CiviCRM [Fri, 9 Feb 2024 04:48:08 +0000 (23:48 -0500)]
release-notes.md - Last minute tweaks
Tim Otten [Fri, 9 Feb 2024 04:02:33 +0000 (20:02 -0800)]
Merge pull request #29345 from totten/5.70-jwt
CryptoJwt - Fix detection of firebase/php-jwt APIs
Eileen McNaughton [Thu, 8 Feb 2024 23:05:12 +0000 (12:05 +1300)]
Merge pull request #29338 from eileenmcnaughton/rc_clear
Fix clearAssign for php8.x
eileen [Thu, 8 Feb 2024 20:17:21 +0000 (09:17 +1300)]
Fix clearAssign for php8.x
Tim Otten [Thu, 8 Feb 2024 22:21:31 +0000 (14:21 -0800)]
CryptoJwt - Fix detection of firebase/php-jwt APIs
Tim Otten [Thu, 8 Feb 2024 06:59:49 +0000 (22:59 -0800)]
Merge pull request #29330 from eileenmcnaughton/570_cfix
Ensure currency is set various forms
eileen [Thu, 8 Feb 2024 05:21:40 +0000 (18:21 +1300)]
Fix some currencies not passed
Tim Otten [Thu, 8 Feb 2024 05:19:11 +0000 (21:19 -0800)]
Merge pull request #29190 from eileenmcnaughton/570
dev/core#4953 Fix failure to show existing membership type in renewal mode
Tim Otten [Thu, 8 Feb 2024 05:15:31 +0000 (21:15 -0800)]
Merge pull request #29326 from eileenmcnaughton/currency_small
Ensure currency is set on back office participant form
eileen [Fri, 2 Feb 2024 03:12:29 +0000 (16:12 +1300)]
additional e-notice fix
eileen [Fri, 2 Feb 2024 03:03:22 +0000 (16:03 +1300)]
dev/core#4953 Fix failure to show existing membership type in renewal mode
The previous fix dealt with js layer issues but this affects select boxes in the php layer
Also fixed 2 smarty notices that turned out to not be related
Tim Otten [Thu, 8 Feb 2024 04:17:05 +0000 (20:17 -0800)]
Merge pull request #29275 from eileenmcnaughton/570_mem
dev/core#4963 Fix validation error on membership renew with auto-renew
eileen [Thu, 8 Feb 2024 03:15:57 +0000 (16:15 +1300)]
Ensure currency is set on back office participant form
Tim Otten [Thu, 8 Feb 2024 03:06:33 +0000 (19:06 -0800)]
Merge pull request #29195 from eileenmcnaughton/receipt_text
dev/core#4948 Fix online_receipt template to include receipt text
Tim Otten [Thu, 8 Feb 2024 02:09:47 +0000 (18:09 -0800)]
Merge pull request #29324 from agh1/5.70.0-releasenotes
5.70.0 release notes
Tim Otten [Thu, 8 Feb 2024 01:01:29 +0000 (17:01 -0800)]
Merge pull request #29290 from colemanw/scheduleRemindersRequired
Fix dev/core#4949 ScheduleReminder form required field error
Tim Otten [Thu, 8 Feb 2024 00:28:50 +0000 (16:28 -0800)]
Merge pull request #29293 from colemanw/fixScheduleReminderFormPerms
Fix dev/core#4971 - Skip redundant permission checks in ScheduleReminder form
Amanda Hunt [Wed, 7 Feb 2024 23:59:02 +0000 (18:59 -0500)]
5.70.0 release notes: big batch of edits
demeritcowboy [Wed, 7 Feb 2024 22:27:34 +0000 (17:27 -0500)]
Merge pull request #29312 from eileenmcnaughton/suppress_570
dev/core#4973 Fix credit card info not showing up in ThankYou & Confirm
colemanw [Wed, 7 Feb 2024 21:27:21 +0000 (16:27 -0500)]
Merge pull request #29300 from eileenmcnaughton/995
dev/core#4980 Ensure payment processor object is returned
Eileen McNaughton [Wed, 7 Feb 2024 21:25:57 +0000 (10:25 +1300)]
Merge pull request #29296 from colemanw/jobParams
Fix dev/core#4959 - Handle extra whitespace in scheduled job params
Amanda Hunt [Wed, 7 Feb 2024 21:02:15 +0000 (16:02 -0500)]
5.70.0 release notes: added boilerplate
Andie Hunt [Wed, 7 Feb 2024 20:47:33 +0000 (15:47 -0500)]
5.70.0 release notes: raw from script
eileen [Wed, 7 Feb 2024 20:05:17 +0000 (09:05 +1300)]
dev/core#4973 Fix credit card info not showing up in ThankYou & Confirm
colemanw [Wed, 7 Feb 2024 00:55:43 +0000 (19:55 -0500)]
Fix dev/core#4949 ScheduleReminder form required field error
colemanw [Wed, 7 Feb 2024 18:42:48 +0000 (13:42 -0500)]
ScheduleReminders - Prevent changing values to existing reminders via url
eileen [Wed, 7 Feb 2024 17:38:39 +0000 (06:38 +1300)]
dev/core#4980 Ensure payment processor object is returned
colemanw [Wed, 7 Feb 2024 13:48:21 +0000 (08:48 -0500)]
Fix dev/core#4959 - Handle extra whitespace in scheduled job params
Tim Otten [Wed, 7 Feb 2024 08:10:44 +0000 (00:10 -0800)]
Merge pull request #29260 from colemanw/getModules
dev/core#4969 Simplify AngularManager loading/caching system
colemanw [Wed, 7 Feb 2024 03:15:14 +0000 (22:15 -0500)]
Fix dev/core#4971 - Skip redundant permission checks in CRM_Admin_Form_ScheduleReminders
Temporary override to solve https://lab.civicrm.org/dev/core/-/issues/4971
This regressed in https://github.com/civicrm/civicrm-core/pull/27003 which
switched $this->retrieveMethod to 'api' - this had the unintended effect of checking
permissions during retrieveValues(), but the API is not sophisticated enough: we need to
add
a `CRM_Core_BAO_ActionSchedule::addSelectWhereClause()` function that can handle the logic
of "if the reminder is for an event, check user has edit permission for that specific
event".
Meanwhile we can skip permission checks in the form layer, because that logic is
implemented here,
specifically in `\CRM_Event_ActionMapping::checkAccess()`.
colemanw [Wed, 7 Feb 2024 01:17:12 +0000 (20:17 -0500)]
Merge pull request #29193 from eileenmcnaughton/570_tags
Fix wonkyness if contribution page includes a profile with both groups & tags
colemanw [Mon, 5 Feb 2024 19:25:37 +0000 (14:25 -0500)]
AngularManager - Simplify caching
In
604cca72 the cache was split into smaller pieces in an attempt to fix some failing tests.
It turned out those fails for other reasons so there's no need to have > 1 cache for angularModules.
Fixes https://lab.civicrm.org/dev/core/-/issues/4969
colemanw [Mon, 5 Feb 2024 19:20:42 +0000 (14:20 -0500)]
AngularManager - Ensure 'basePages' is an array
This doesn't change the behavior (historical default mainained, with a comment added about why),
just ensures the value is always set to prevent errors when it gets passed to in_array().
eileen [Tue, 6 Feb 2024 05:20:15 +0000 (18:20 +1300)]
dev/core#4963 Fix validation error on membership renew with auto-renew
Eileen McNaughton [Tue, 6 Feb 2024 06:14:02 +0000 (19:14 +1300)]
Merge pull request #29277 from eileenmcnaughton/570-orn
Disable failing test in PR runs for now
eileen [Sun, 4 Feb 2024 21:27:32 +0000 (10:27 +1300)]
Disable failing test in PR runs for now
Eileen McNaughton [Tue, 6 Feb 2024 00:55:55 +0000 (13:55 +1300)]
Merge pull request #29264 from MegaphoneJon/cond-receipt
don't send an extra receipt when completing pending contributions
colemanw [Tue, 6 Feb 2024 00:41:23 +0000 (19:41 -0500)]
Merge pull request #29226 from eileenmcnaughton/tags_g
Php 8.x notice fix on tags & groups fields
Jon Goldberg [Mon, 5 Feb 2024 22:49:58 +0000 (17:49 -0500)]
don't send an extra receipt when completing pending contributions
eileen [Fri, 2 Feb 2024 05:40:06 +0000 (18:40 +1300)]
Php 8.x notice fix on tags & groups fields
eileen [Fri, 2 Feb 2024 06:18:49 +0000 (19:18 +1300)]
Fix online_receipt template to include receipt text
Eileen McNaughton [Sat, 3 Feb 2024 03:02:33 +0000 (16:02 +1300)]
Merge pull request #29208 from colemanw/fixIrrelevantLinks
SearchKit - Remove irrelevant links from default display
Eileen McNaughton [Sat, 3 Feb 2024 03:01:13 +0000 (16:01 +1300)]
Merge pull request #29209 from colemanw/disableActivityTab
dev/core#4950 - Disable SearchUI version of ContactSummary Activity tab
colemanw [Sat, 3 Feb 2024 02:53:40 +0000 (21:53 -0500)]
Merge pull request #29200 from ejegg/conditionalCaseLink
dev/core#4960 Make Case menu link in relationship tab conditional
Eileen McNaughton [Fri, 2 Feb 2024 22:50:48 +0000 (11:50 +1300)]
Merge pull request #29192 from eileenmcnaughton/570_2
Fix 5.67 regression on loading custom data defaults on contribution page
colemanw [Fri, 2 Feb 2024 22:17:31 +0000 (17:17 -0500)]
dev/core#4950 - Disable SearchUI version of ContactSummary Activity tab
This temporarily disables the new tab while we assess query performance problems
See https://lab.civicrm.org/dev/core/-/issues/4950
Note: commented out code uses the new 'placement' option which is preferred
over the legacy 'contact_summary' flag.
colemanw [Fri, 2 Feb 2024 22:11:57 +0000 (17:11 -0500)]
Merge pull request #29206 from colemanw/fixInvalidLinks
SearchKit - Hide invalid links and prevent error
colemanw [Fri, 2 Feb 2024 22:02:31 +0000 (17:02 -0500)]
SearchKit - Remove irrelevant links from default display
The action regressed when switching search displays to use the GetLinks api action.
This fixes the filtering & makes it more efficient by passing the filter to the api.
colemanw [Fri, 2 Feb 2024 16:28:11 +0000 (11:28 -0500)]
SearchKit - Hide invalid links and prevent error
Fixes dev/core#4961
colemanw [Fri, 2 Feb 2024 20:53:53 +0000 (15:53 -0500)]
Merge pull request #29203 from eileenmcnaughton/url
dev/core#4962 Fix Smarty fatal on resource url page
eileen [Fri, 2 Feb 2024 19:12:05 +0000 (08:12 +1300)]
dev/core#4962 Fix Smarty fatal on resource url page
eileen [Fri, 2 Feb 2024 04:05:20 +0000 (17:05 +1300)]
Fix 5.67 regression on loading custom data defaults on contribution page
Elliott Eggleston [Fri, 2 Feb 2024 15:52:07 +0000 (10:52 -0500)]
Make Case menu link in relationship tab conditional
Only add the link when CiviCase is enabled
dev/core#4960
colemanw [Fri, 2 Feb 2024 11:57:24 +0000 (06:57 -0500)]
Merge pull request #29180 from colemanw/selectTab
SearchKit - Fix switching to nonexistent tab
eileen [Fri, 2 Feb 2024 05:04:47 +0000 (18:04 +1300)]
Fix wonkyness if contribution page includes a profile with both groups & tags
Seamus Lee [Fri, 2 Feb 2024 03:37:48 +0000 (14:37 +1100)]
Merge pull request #29189 from seamuslee001/dev_ui_65
dev/user-interface#65 Remove top set of buttons which only show up in…
Seamus Lee [Fri, 2 Feb 2024 02:40:28 +0000 (13:40 +1100)]
dev/user-interface#65 Remove top set of buttons which only show up in non popup form
colemanw [Thu, 1 Feb 2024 02:22:49 +0000 (21:22 -0500)]
SearchKit - Fix switching to nonexistent tab
Tabs were recently renamed so this keeps up with the change.
Seamus Lee [Wed, 31 Jan 2024 23:15:20 +0000 (10:15 +1100)]
Merge pull request #28971 from mattwire/firebase
Fix fatal error when firebase/php-jwt library is 'replaced' in composer
Matthew Wire [Thu, 11 Jan 2024 12:46:57 +0000 (12:46 +0000)]
Fix fatal error when firebase/php-jwt library is 'replaced' in composer
Tim Otten [Wed, 31 Jan 2024 07:14:20 +0000 (23:14 -0800)]
Merge pull request #29107 from eileenmcnaughton/570_no_wiz
Remove attempt to use wizard on manage ACLs
Tim Otten [Wed, 31 Jan 2024 06:57:59 +0000 (22:57 -0800)]
Merge pull request #29092 from colemanw/getAutocompleteParams
dev/core#4937 - Fix js error in formBuilder autocompletes
Tim Otten [Wed, 31 Jan 2024 06:15:32 +0000 (22:15 -0800)]
Merge pull request #29112 from eileenmcnaughton/570_mem
dev/core#4939 Fix failure to load existing membership info on online membership page
colemanw [Tue, 30 Jan 2024 15:05:16 +0000 (10:05 -0500)]
Merge pull request #29155 from colemanw/colIndex
crmDashboard - Fix deleting item from 2nd column
colemanw [Mon, 29 Jan 2024 20:41:51 +0000 (15:41 -0500)]
crmDashboard - Fix deleting item from 2nd column
demeritcowboy [Mon, 29 Jan 2024 13:28:55 +0000 (08:28 -0500)]
Merge pull request #29143 from colemanw/excludeCaseActivities
Fix dev/core#4943 - Exclude case activities from count if appropriate
colemanw [Mon, 29 Jan 2024 04:02:38 +0000 (23:02 -0500)]
Fix dev/core#4943 - Exclude case activities from count if appropriate
colemanw [Mon, 29 Jan 2024 03:36:52 +0000 (22:36 -0500)]
Merge pull request #29118 from eileenmcnaughton/570_patrick
When auto-renew option is available, show the checkbox immediately in…
colemanw [Sun, 28 Jan 2024 22:09:48 +0000 (17:09 -0500)]
Merge pull request #29115 from eileenmcnaughton/570
dev/core#4917 Ensure total is always updated when other amount is selected
Patrick Lam [Tue, 16 Jan 2024 11:03:44 +0000 (00:03 +1300)]
When auto-renew option is available, show the checkbox immediately instead of upon clicking the price.
memTypeId was previously "undefined" after trying to read attribute
"membership-type". The DOM shows an attribute
"data-membership-type-id" and this patch modifies the attribute read
to "data-membership-type-id", which is also consistent with the
variable name in the code.
eileen [Sat, 27 Jan 2024 20:04:39 +0000 (09:04 +1300)]
Ensure total is always updated when other amount is selected