Matthew Wire [Mon, 1 Jun 2020 12:19:41 +0000 (13:19 +0100)]
Set activity_date_time and created_date to default to current_timestamp
Eileen McNaughton [Mon, 8 Jun 2020 11:12:13 +0000 (23:12 +1200)]
Merge pull request #17374 from totten/master-setlocale
CRM_Core_I18n::setLocale() - Fix bug with repeated usage
Eileen McNaughton [Mon, 8 Jun 2020 11:05:22 +0000 (23:05 +1200)]
Merge pull request #17179 from mattwire/addpaymentprocessortorecurlist
Add payment processor to details on list of recurring contributions
Eileen McNaughton [Mon, 8 Jun 2020 10:47:03 +0000 (22:47 +1200)]
Merge pull request #17512 from semseysandor/relative-date-filter
dev/core#1798 - "End of yesterday" Relative Date Filter
Eileen McNaughton [Mon, 8 Jun 2020 10:46:37 +0000 (22:46 +1200)]
Merge pull request #17523 from mattwire/customsearchzipcode
Zip code range search only supports numeric zip codes
Seamus Lee [Mon, 8 Jun 2020 08:52:31 +0000 (18:52 +1000)]
Merge pull request #17549 from eileenmcnaughton/friend
[Ref] Remove another instance of fatal()
Seamus Lee [Mon, 8 Jun 2020 06:33:15 +0000 (16:33 +1000)]
Merge pull request #17543 from eileenmcnaughton/dummy
[Ref] Readability extraction in Dummy class
Seamus Lee [Mon, 8 Jun 2020 06:32:55 +0000 (16:32 +1000)]
Merge pull request #17546 from eileenmcnaughton/validate2
Remove isThrowException from CRM_Utils_Type::validate() signature
eileen [Mon, 8 Jun 2020 05:03:38 +0000 (17:03 +1200)]
[Ref] Remove another instance of fatal()
eileen [Mon, 8 Jun 2020 00:33:04 +0000 (12:33 +1200)]
[Ref] Readability extraction in Dummy class
Seamus Lee [Mon, 8 Jun 2020 04:37:31 +0000 (14:37 +1000)]
Merge pull request #17545 from seamuslee001/dev_core_560_fin
dev/core#560 Convert final CRM_Core_Error::fatal to statusBounces or …
eileen [Mon, 8 Jun 2020 01:21:14 +0000 (13:21 +1200)]
Remove isThrowException from CRM_Utils_Type::validate() signature
There are no instances in core where FALSE is passed
Seamus Lee [Mon, 8 Jun 2020 04:30:36 +0000 (14:30 +1000)]
Merge pull request #17544 from eileenmcnaughton/validate
Fix validateAll to no longer support unused abort param
Seamus Lee [Mon, 8 Jun 2020 01:13:26 +0000 (11:13 +1000)]
dev/core#560 Convert final CRM_Core_Error::fatal to statusBounces or Exceptions
Seamus Lee [Mon, 8 Jun 2020 02:48:30 +0000 (12:48 +1000)]
Merge pull request #17542 from eileenmcnaughton/pay_error
dev/financial#131 Fix Eway processor to throw exceptions rather than return errors
Seamus Lee [Mon, 8 Jun 2020 02:47:43 +0000 (12:47 +1000)]
Merge pull request #17533 from eileenmcnaughton/fatal
[REF] Replace some instances of fatal with thrown exceptions.
Eileen McNaughton [Mon, 8 Jun 2020 01:59:33 +0000 (13:59 +1200)]
Merge pull request #17540 from colemanw/getActionsPerm
APIv4 - filter getActions results based on user permissions
Seamus Lee [Mon, 8 Jun 2020 01:57:13 +0000 (11:57 +1000)]
Merge pull request #17491 from eileenmcnaughton/toemail
[Ref] Simplify the replacing of the email with the email from the url
Seamus Lee [Mon, 8 Jun 2020 01:54:11 +0000 (11:54 +1000)]
Merge pull request #17500 from eileenmcnaughton/renew_can
[Ref] Throw exceptions from Authorize.net rather than return errors
Seamus Lee [Mon, 8 Jun 2020 01:50:20 +0000 (11:50 +1000)]
Merge pull request #17499 from eileenmcnaughton/unhandled
[Ref] Remove calls to, and deprecate, unhandled function
Seamus Lee [Mon, 8 Jun 2020 01:49:37 +0000 (11:49 +1000)]
Merge pull request #17504 from eileenmcnaughton/renewd
[REF] Remove handling for 2 fields not on the form
eileen [Mon, 8 Jun 2020 01:11:02 +0000 (13:11 +1200)]
Fix validateAll to no longer support unused abort param
Default of TRUE is good here
Seamus Lee [Mon, 8 Jun 2020 00:53:13 +0000 (10:53 +1000)]
Merge pull request #17539 from eileenmcnaughton/fatal2
Replace calls to fatal with statusBounces
eileen [Mon, 8 Jun 2020 00:12:04 +0000 (12:12 +1200)]
dev/financial#131 Fix Eway processor to throw exceptions rather than return errors
This is part of a push to model the correct behaviour in processors we can alter. This is safe as CRM_Core_Payment
already converts these
eileen [Sun, 7 Jun 2020 04:59:24 +0000 (16:59 +1200)]
[REF] Replace some instances of fatal with thrown exceptions.
This is ongoing cleanup to consisently throw execptions. The only thing notable is in the OG class where
it turned out the exception was thrown if a never-passed-in-parameter was passed in, so I removed the
construct
Seamus Lee [Mon, 8 Jun 2020 00:39:39 +0000 (10:39 +1000)]
Merge pull request #17541 from seamuslee001/dev_core_560_third_to_last
dev/core#560 Replace deprecated CRM_Core_Erorr::fatal with Exceptions…
Seamus Lee [Sun, 7 Jun 2020 23:33:47 +0000 (09:33 +1000)]
dev/core#560 Replace deprecated CRM_Core_Erorr::fatal with Exceptions or status bounces as appropriate
Coleman Watts [Sun, 7 Jun 2020 23:11:46 +0000 (19:11 -0400)]
APIv4 - filter getActions results based on user permissions
eileen [Sun, 7 Jun 2020 23:11:38 +0000 (11:11 +1200)]
Replace calls to fatal with statusBounces
Eileen McNaughton [Sun, 7 Jun 2020 22:56:28 +0000 (10:56 +1200)]
Merge pull request #17511 from mattwire/paymentprocessoraddfrontendfunctions
Add isBackOffice, isPayLater, getPaymentMode helpers to frontendpaymentformtrait
Eileen McNaughton [Sun, 7 Jun 2020 22:53:04 +0000 (10:53 +1200)]
Merge pull request #17534 from eileenmcnaughton/fatal2
Remove instances of fatal from upgrade folder
Sandor Semsey [Sun, 7 Jun 2020 19:14:58 +0000 (21:14 +0200)]
Earlier.day test
Seamus Lee [Sun, 7 Jun 2020 10:55:33 +0000 (20:55 +1000)]
Merge pull request #17535 from eileenmcnaughton/gone
Remove unused deprecated class
Seamus Lee [Sun, 7 Jun 2020 10:55:13 +0000 (20:55 +1000)]
Merge pull request #17528 from seamuslee001/nfv_apiv3_mem_type_apiv4_test
[NFC] Update existing APIv3 MembershipType Tests to also test against…
Seamus Lee [Sun, 7 Jun 2020 10:50:44 +0000 (20:50 +1000)]
Merge pull request #17536 from eileenmcnaughton/fatal3
[Ref] Remove some instances of fatal in BAO classes
Seamus Lee [Sun, 7 Jun 2020 09:43:24 +0000 (19:43 +1000)]
Merge pull request #17538 from civicrm/5.27
5.27
Seamus Lee [Sun, 7 Jun 2020 06:27:23 +0000 (16:27 +1000)]
Merge pull request #17502 from eileenmcnaughton/first
Fix probably-unused core payment processors to throw extensions
Seamus Lee [Sun, 7 Jun 2020 06:12:20 +0000 (16:12 +1000)]
Merge pull request #17532 from totten/5.27-queue-test
QueueTest - Be more forgiving about slow execution
Eileen McNaughton [Sun, 7 Jun 2020 05:44:45 +0000 (17:44 +1200)]
Merge pull request #17510 from mattwire/paymentprocessorinstrumentnotrequired
Payment instrument ID is not required at processorform level
eileen [Sun, 7 Jun 2020 05:24:03 +0000 (17:24 +1200)]
[Ref] Remove some instances of fatal in BAO classes
eileen [Sun, 7 Jun 2020 05:10:30 +0000 (17:10 +1200)]
Remove unused deprecated class
eileen [Sun, 7 Jun 2020 05:06:38 +0000 (17:06 +1200)]
Remove instances of fatal from upgrade folder
Tim Otten [Sun, 7 Jun 2020 04:29:17 +0000 (21:29 -0700)]
QueueTest - Be more forgiving about slow execution
The `CRM_Queue_QueueTest` is producing failures with the
[TIME_FUNC](https://github.com/civicrm/civicrm-core/pull/17414) option of
`linear:500` (the value currently used in PR test runs) -- which is to say,
it fails when the system runs very slowly (with some 500ms stalling during
execution).
This gets it working under some very slow scenarios:
```
for TIME_FUNC in natural frozen linear:500 linear:1250 prng:500 prng:666 prng:1000 prng:1500 ; do
export TIME_FUNC;
echo;
echo "TIME_FUNC=$TIME_FUNC" ;
env CIVICRM_UF=UnitTests phpunit6 tests/phpunit/CRM/Queue/QueueTest.php ;
done
```
Seamus Lee [Sun, 7 Jun 2020 03:51:35 +0000 (13:51 +1000)]
Merge pull request #17530 from civicrm/5.27
5.27
Seamus Lee [Sun, 7 Jun 2020 02:04:26 +0000 (12:04 +1000)]
Merge pull request #17527 from colemanw/nameAndIcon
Add titles and icons to entities
Seamus Lee [Sun, 7 Jun 2020 02:01:55 +0000 (12:01 +1000)]
Merge pull request #17360 from totten/master-wp-var
WP - Change definitions of `cms.root`, `civicrm.root`
Seamus Lee [Sun, 7 Jun 2020 01:01:04 +0000 (11:01 +1000)]
Merge pull request #17529 from totten/5.27-comm-msg
CommunityMessages - Define more consistent behavior in the face of slow execution
Tim Otten [Sat, 6 Jun 2020 22:21:01 +0000 (15:21 -0700)]
CommunityMessages - Define more consistent behavior in the face of slow execution
This passes under some brutally slow scenarios:
```
for TIME_FUNC in natural frozen linear:500 linear:1250 prng:500 prng:666 prng:1000 prng:1500 ; do
export TIME_FUNC;
echo;
echo "TIME_FUNC=$TIME_FUNC" ;
env CIVICRM_UF=UnitTests phpunit6 tests/phpunit/CRM/Core/CommunityMessagesTest.php ;
done
```
Seamus Lee [Sat, 6 Jun 2020 22:34:17 +0000 (08:34 +1000)]
[NFC] Update existing APIv3 MembershipType Tests to also test against APIv4 as appropriate
Coleman Watts [Sat, 6 Jun 2020 20:43:21 +0000 (16:43 -0400)]
Add titles and icons to entities
Matthew Wire [Fri, 5 Jun 2020 09:45:29 +0000 (10:45 +0100)]
Add isBackOffice, isPayLater, getPaymentMode helpers to frontendpaymentformtrait
Sandor Semsey [Sat, 6 Jun 2020 13:00:44 +0000 (15:00 +0200)]
Earlier.day test
Sandor Semsey [Sat, 6 Jun 2020 12:57:16 +0000 (14:57 +0200)]
Earlier.day test
Matthew Wire [Sat, 6 Jun 2020 11:46:07 +0000 (12:46 +0100)]
Zip code range search only supports numeric zip codes so don't try and search if values are not numeric
CiviCRM [Sat, 6 Jun 2020 07:45:49 +0000 (07:45 +0000)]
Set version to 5.28.alpha1
CiviCRM [Sat, 6 Jun 2020 07:40:15 +0000 (07:40 +0000)]
Set version to 5.27.beta1
Tim Otten [Sat, 6 Jun 2020 07:39:32 +0000 (00:39 -0700)]
Merge pull request #17521 from seamuslee001/master
Add release-notes/5.26.1.md
Tim Otten [Sat, 6 Jun 2020 07:04:55 +0000 (00:04 -0700)]
Update release-notes.md
Tim Otten [Sat, 6 Jun 2020 00:54:38 +0000 (17:54 -0700)]
Add release-notes/5.26.1.md
Seamus Lee [Sat, 6 Jun 2020 04:03:31 +0000 (14:03 +1000)]
Merge pull request #17518 from totten/master-mysql-notice
dev/core#1681 - Copy-edits on MySQL version notices
Tim Otten [Sat, 6 Jun 2020 02:01:22 +0000 (19:01 -0700)]
dev/core#1681 - Copy-edits on MySQL version notices
* The titles for PHP+MySQL notices should use the same
capitalization/hyphenation ("Out-of-Date" vs "Out of date").
* Extract some more "%n" variables. Fix one errant variable.
* Reduce floweriness of the "version" / "at least" / "or later" text.
* Make it possible to add/remove the "+" notation without changing
the ts() message.
Tim Otten [Sat, 6 Jun 2020 00:22:55 +0000 (17:22 -0700)]
Merge pull request #17452 from eileenmcnaughton/dummy_bag
[REF] Start to convert Dummy processor to use PropertyBag
Sandor Semsey [Fri, 5 Jun 2020 15:19:34 +0000 (17:19 +0200)]
fix for end-of-yesterday
Seamus Lee [Fri, 5 Jun 2020 10:51:12 +0000 (20:51 +1000)]
Merge pull request #17505 from mattwire/propertybagfixsetamount
Payment PropertyBag - Fix setAmount
Matthew Wire [Fri, 5 Jun 2020 09:42:04 +0000 (10:42 +0100)]
Payment instrument ID is not required at processorform level
Matthew Wire [Fri, 5 Jun 2020 09:19:44 +0000 (10:19 +0100)]
Fix setAmount to set the right amount on payment propertybag
Seamus Lee [Fri, 5 Jun 2020 09:05:34 +0000 (19:05 +1000)]
Merge pull request #17496 from seamuslee001/mysql_upgrade_notice
dev/core#1681 Add in notice about 5.28 Dropping MySQL 5.5 Support
eileen [Fri, 5 Jun 2020 05:38:09 +0000 (17:38 +1200)]
[REF] Remove handling for 2 fields not on the form
Neither membership_source or campaign_id are fields on the renewal form. The handling is left over from
code for other forms. This tidies it up
Seamus Lee [Fri, 5 Jun 2020 05:22:10 +0000 (15:22 +1000)]
Merge pull request #17489 from eileenmcnaughton/mod
[REF] Remove always NULL param modified_id
Seamus Lee [Thu, 4 Jun 2020 23:19:01 +0000 (09:19 +1000)]
dev/core#1681 Add in notice about 5.28 Dropping MySQL 5.5 Support
eileen [Fri, 5 Jun 2020 02:23:02 +0000 (14:23 +1200)]
Fix probably-unused core payment processors to throw extensions
These 2 processors are probably entirely unused and are not enabled on new installs. However, as they are still in core,
and removing them will take a plan + time, we should have them model 'good behaviour' - ie throwing exceptions
rather than returning errors
Eileen McNaughton [Fri, 5 Jun 2020 04:58:51 +0000 (16:58 +1200)]
Merge pull request #17497 from seamuslee001/dev_core_1797
dev/core#1797 Fix jquery Credit card validation on front end contribu…
eileen [Fri, 5 Jun 2020 01:02:48 +0000 (13:02 +1200)]
[Ref] Throw exceptions from Authorize.net rather than return errors
This is part of 'modelling good behaviour' - curently doPayment converts the errors to thrown exceptions,
but the recommendation is that the payment processor functions should throw exceptions themselves.
If they do they willl bypass the doPayment handling, but acheive the same thing
Eileen McNaughton [Thu, 4 Jun 2020 23:55:50 +0000 (11:55 +1200)]
Merge pull request #17448 from mattwire/api4membershiptype
Add MembershipType to Api4
eileen [Thu, 4 Jun 2020 23:47:28 +0000 (11:47 +1200)]
[Ref] Remove calls to, and deprecate, unhandled function
Seamus Lee [Thu, 4 Jun 2020 23:46:18 +0000 (09:46 +1000)]
Merge pull request #17473 from eileenmcnaughton/anet
Convert remaining Authorize.net test to use guzzle
Seamus Lee [Thu, 4 Jun 2020 23:41:10 +0000 (09:41 +1000)]
dev/core#1797 Fix jquery Credit card validation on front end contribution forms
Seamus Lee [Thu, 4 Jun 2020 23:23:24 +0000 (09:23 +1000)]
Merge pull request #17494 from pradpnayak/reminderSetdefault
set boolean fields to false if not set.
Seamus Lee [Thu, 4 Jun 2020 22:52:11 +0000 (08:52 +1000)]
Merge pull request #17490 from eileenmcnaughton/pending
[Ref] remove calls to, and deprecate, pending function
Eileen McNaughton [Thu, 4 Jun 2020 21:46:45 +0000 (09:46 +1200)]
Merge pull request #17426 from mattwire/recaptcha
Make reCAPTCHA settings clearer
eileen [Tue, 26 May 2020 04:57:22 +0000 (16:57 +1200)]
Simplify the replacing of the email with the email from the url
This is a readability improvement. Prior to this change an email coming from the url
from on of the classes that uses this trait is loaded into $this->_toEmail so we have
$this->_toEmail = ['email' => 'x', 'contact_id' => 2])
When $allContactDetails is iterated it checks each row to see if the contact_id matches the
above and if so swaps out the email address when wrangling $toArray from allContactDetails.
This change simply does the swap out before the loop, rather than during it
Also, an if...else is change to an elseif
Seamus Lee [Thu, 4 Jun 2020 21:14:30 +0000 (07:14 +1000)]
Merge pull request #17492 from eileenmcnaughton/search
[NFC] Fix use of single quotes, strict operator
Seamus Lee [Thu, 4 Jun 2020 21:14:04 +0000 (07:14 +1000)]
Merge pull request #17488 from eileenmcnaughton/memtype
Test fixes to support apiv4 add of MembershipType
colemanw [Thu, 4 Jun 2020 11:59:28 +0000 (07:59 -0400)]
Merge pull request #17493 from pradpnayak/tinyintFixes
dev/core/-/issues/1794, changed int to tinyint for boolean fields
Pradeep Nayak [Thu, 4 Jun 2020 10:15:15 +0000 (11:15 +0100)]
set boolean fields to false if not set.
Pradeep Nayak [Thu, 4 Jun 2020 09:47:34 +0000 (10:47 +0100)]
dev/core/-/issues/1794, changed int to tinyint for boolean fields
eileen [Thu, 4 Jun 2020 07:00:54 +0000 (19:00 +1200)]
[Ref] remove calls to, and deprecate, pending function
eileen [Tue, 2 Jun 2020 08:48:10 +0000 (20:48 +1200)]
[REF] Remove always NULL param modified_id
This funnction is not now shared with any other forms
eileen [Thu, 4 Jun 2020 06:41:45 +0000 (18:41 +1200)]
Test fixes to support apiv4 add of MembershipType
eileen [Tue, 2 Jun 2020 21:37:28 +0000 (09:37 +1200)]
Convert remaining Authorize.net test to use guzzle
This allows us to remove the handling for when a.net doesn't reply
Seamus Lee [Thu, 4 Jun 2020 05:01:15 +0000 (15:01 +1000)]
Merge pull request #17486 from seamuslee001/master
5.26
Seamus Lee [Thu, 4 Jun 2020 05:00:16 +0000 (15:00 +1000)]
Merge in 5.26
Tim Otten [Thu, 4 Jun 2020 04:58:04 +0000 (21:58 -0700)]
Merge pull request #17485 from totten/5.26-misc
5.26.0 - Small edits
Tim Otten [Thu, 4 Jun 2020 04:47:13 +0000 (21:47 -0700)]
Set version to 5.26.0
Tim Otten [Thu, 4 Jun 2020 04:46:48 +0000 (21:46 -0700)]
release-notes/5.26.0 - Copy-edits
Seamus Lee [Thu, 4 Jun 2020 04:06:04 +0000 (14:06 +1000)]
Merge pull request #17484 from civicrm/5.26
5.26
Seamus Lee [Thu, 4 Jun 2020 02:26:15 +0000 (12:26 +1000)]
Merge pull request #17483 from agh1/5.26.0-release-notes-final
5.26.0 release notes final
Eileen McNaughton [Thu, 4 Jun 2020 01:02:16 +0000 (13:02 +1200)]
Merge pull request #17482 from colemanw/orderBySuffix
APIv4 - Support pseudoconstant suffixes in orderBy clause
Seamus Lee [Thu, 4 Jun 2020 00:39:32 +0000 (10:39 +1000)]
Merge pull request #17481 from eileenmcnaughton/email
[REF] Extract createFollowUpActivities
Andrew Hunt [Wed, 3 Jun 2020 23:51:13 +0000 (19:51 -0400)]
5.26.0 release notes: some final edits