civicrm-core.git
5 years agoBetter variable name
Coleman Watts [Fri, 26 Apr 2019 14:09:02 +0000 (10:09 -0400)]
Better variable name

5 years agoAlter menubar breakpoint to match WP admin theme
Coleman Watts [Fri, 26 Apr 2019 12:56:46 +0000 (08:56 -0400)]
Alter menubar breakpoint to match WP admin theme

5 years agoAdd hook to influince menubar css variables
Coleman Watts [Fri, 26 Apr 2019 03:01:03 +0000 (23:01 -0400)]
Add hook to influince menubar css variables

5 years agoAdd css variable for menubar breakpoint
Coleman Watts [Fri, 26 Apr 2019 02:48:14 +0000 (22:48 -0400)]
Add css variable for menubar breakpoint

5 years agoMerge pull request #14131 from colemanw/resourceList
Tim Otten [Fri, 26 Apr 2019 06:54:08 +0000 (23:54 -0700)]
Merge pull request #14131 from colemanw/resourceList

[REF] Use events for CMS resource loading

5 years agoMerge pull request #14133 from civicrm/5.13
Seamus Lee [Fri, 26 Apr 2019 02:53:00 +0000 (12:53 +1000)]
Merge pull request #14133 from civicrm/5.13

5.13

5 years agoMerge pull request #14132 from seamuslee001/5.13
Seamus Lee [Fri, 26 Apr 2019 01:03:59 +0000 (11:03 +1000)]
Merge pull request #14132 from seamuslee001/5.13

Add 5.12.4 release notes

5 years agoUpdate 5.12.4.md
Tim Otten [Thu, 25 Apr 2019 23:42:50 +0000 (16:42 -0700)]
Update 5.12.4.md

5 years agoUpdate 5.12.4.md
Tim Otten [Thu, 25 Apr 2019 23:42:03 +0000 (16:42 -0700)]
Update 5.12.4.md

5 years agoUpdate release notes
Seamus Lee [Thu, 25 Apr 2019 23:31:42 +0000 (09:31 +1000)]
Update release notes

5 years agoAdd 5.12.4 release notes
Seamus Lee [Thu, 25 Apr 2019 01:11:43 +0000 (11:11 +1000)]
Add 5.12.4 release notes

5 years agoUse events for CMS resource loading
Coleman Watts [Thu, 25 Apr 2019 14:41:49 +0000 (10:41 -0400)]
Use events for CMS resource loading

5 years agoMerge pull request #14086 from agh1/caseactqueryfix
Eileen McNaughton [Thu, 25 Apr 2019 22:03:34 +0000 (10:03 +1200)]
Merge pull request #14086 from agh1/caseactqueryfix

Case activity query performs poorly on large databases

5 years agoMerge pull request #14122 from colemanw/menubarHeight
Eileen McNaughton [Thu, 25 Apr 2019 21:52:30 +0000 (09:52 +1200)]
Merge pull request #14122 from colemanw/menubarHeight

[REF] Use variable for menubar height

5 years agoUse variable for menubar height
Coleman Watts [Wed, 24 Apr 2019 17:55:08 +0000 (13:55 -0400)]
Use variable for menubar height

5 years agoMerge pull request #13689 from eileenmcnaughton/no_record_payment
Monish Deb [Thu, 25 Apr 2019 11:24:25 +0000 (16:54 +0530)]
Merge pull request #13689 from eileenmcnaughton/no_record_payment

Call Payment.create from payment.cancel

5 years agoMerge pull request #14127 from civicrm/5.13
Seamus Lee [Thu, 25 Apr 2019 09:38:32 +0000 (19:38 +1000)]
Merge pull request #14127 from civicrm/5.13

5.13

5 years agoMerge pull request #14126 from seamuslee001/dev_core_880
Seamus Lee [Thu, 25 Apr 2019 09:38:10 +0000 (19:38 +1000)]
Merge pull request #14126 from seamuslee001/dev_core_880

Fix typo in DROP table query.

5 years agoMerge pull request #14045 from totten/master-ab-winning
Eileen McNaughton [Thu, 25 Apr 2019 07:34:45 +0000 (19:34 +1200)]
Merge pull request #14045 from totten/master-ab-winning

(REF; dev/core#873) MailingAB - Migrate "copy winner" logic from JS to PHP

5 years agoFix typo in DROP table query.
mark burdett [Wed, 24 Apr 2019 18:32:32 +0000 (11:32 -0700)]
Fix typo in DROP table query.

5 years agoMerge pull request #14110 from mattwire/caseactivitylinks_partial
Eileen McNaughton [Thu, 25 Apr 2019 04:34:03 +0000 (16:34 +1200)]
Merge pull request #14110 from mattwire/caseactivitylinks_partial

REF Don't pass activity object to addCaseActivityLinks

5 years agoMerge pull request #14112 from mattwire/action_filterlinks
Eileen McNaughton [Thu, 25 Apr 2019 04:26:02 +0000 (16:26 +1200)]
Merge pull request #14112 from mattwire/action_filterlinks

Add function filterLinks to return an array of links for an entity that can be used by the API / form layer to generate a link

5 years agoMerge pull request #14109 from mattwire/refactor_inboundemailshared
Eileen McNaughton [Thu, 25 Apr 2019 04:23:30 +0000 (16:23 +1200)]
Merge pull request #14109 from mattwire/refactor_inboundemailshared

REF Use shared function to check inbound email permissions

5 years agoMerge pull request #14121 from civicrm/revert-14063-core-553
Eileen McNaughton [Wed, 24 Apr 2019 23:54:01 +0000 (11:54 +1200)]
Merge pull request #14121 from civicrm/revert-14063-core-553

Revert "dev/core#553: Creating new event takes value from default value not from saved template for custom fields"

5 years agoMerge pull request #14117 from eileenmcnaughton/import_3
Seamus Lee [Wed, 24 Apr 2019 23:47:02 +0000 (09:47 +1000)]
Merge pull request #14117 from eileenmcnaughton/import_3

[REF] Follow up tidy up on import fixes

5 years agoFollow up tidy up on import - use same fn for address
eileen [Wed, 24 Apr 2019 03:33:56 +0000 (15:33 +1200)]
Follow up tidy up on import - use same fn for address

This is covered by testImportPrimaryAddressUpdate

5 years agoMerge pull request #14123 from mfb/drop-bug
Seamus Lee [Wed, 24 Apr 2019 21:30:23 +0000 (07:30 +1000)]
Merge pull request #14123 from mfb/drop-bug

dev/core#880: Fix typo in DROP table query.

5 years agoMerge pull request #14043 from eileenmcnaughton/import_2
Seamus Lee [Wed, 24 Apr 2019 20:09:10 +0000 (06:09 +1000)]
Merge pull request #14043 from eileenmcnaughton/import_2

Fix import primary phone, primary email, add tests

5 years agoFix typo in DROP table query.
mark burdett [Wed, 24 Apr 2019 18:32:32 +0000 (11:32 -0700)]
Fix typo in DROP table query.

5 years agoRevert "dev/core#553: Creating new event takes value from default value not from...
Yashodha Chaku [Wed, 24 Apr 2019 15:27:19 +0000 (20:57 +0530)]
Revert "dev/core#553: Creating new event takes value from default value not from saved template for custom fields"

5 years agoMerge pull request #13994 from eileenmcnaughton/recur_cancel
Matthew Wire [Wed, 24 Apr 2019 09:53:13 +0000 (10:53 +0100)]
Merge pull request #13994 from eileenmcnaughton/recur_cancel

dev/core#846 Convert Recurring forms to entity forms

5 years agoMerge pull request #14063 from JMAConsulting/core-553
Yashodha Chaku [Wed, 24 Apr 2019 07:00:25 +0000 (12:30 +0530)]
Merge pull request #14063 from JMAConsulting/core-553

dev/core#553: Creating new event takes value from default value not from saved template for custom fields

5 years agoFix handling of importing 'primary
eileen [Fri, 12 Apr 2019 07:51:50 +0000 (17:51 +1000)]
Fix handling of importing 'primary
' phone & email and enable test

Prior to this selecting 'Primary' as location_type_id for phone or email will result in duplicates.

This also simplifies the indexing to be by location type, as it is with addresses, as the code is kinda
confusing

5 years agoMerge pull request #14108 from mattwire/form_activity_hardcoded_ids
Eileen McNaughton [Tue, 23 Apr 2019 23:06:49 +0000 (09:06 +1000)]
Merge pull request #14108 from mattwire/form_activity_hardcoded_ids

REF Replace hardcoded IDs with pseudoconstants in activity form

5 years agoMerge pull request #14115 from civicrm/5.13
Seamus Lee [Tue, 23 Apr 2019 05:49:37 +0000 (15:49 +1000)]
Merge pull request #14115 from civicrm/5.13

5.13

5 years agoMerge pull request #14114 from lcdservices/5.13
Seamus Lee [Tue, 23 Apr 2019 04:17:21 +0000 (14:17 +1000)]
Merge pull request #14114 from lcdservices/5.13

dev/core#891 condition on id existenced when retrieving mailing hash

5 years agodev/core#891 condition on id existenced when retrieving mailing hash
Brian Shaughnessy [Tue, 23 Apr 2019 01:43:19 +0000 (21:43 -0400)]
dev/core#891 condition on id existenced when retrieving mailing hash

5 years agoMerge pull request #14084 from colemanw/UFFieldBAO
Seamus Lee [Tue, 23 Apr 2019 01:51:26 +0000 (11:51 +1000)]
Merge pull request #14084 from colemanw/UFFieldBAO

(REF) Standardize UFField create function

5 years agoAdd UFField to syntaxConformanceTest
Coleman Watts [Mon, 22 Apr 2019 12:22:13 +0000 (08:22 -0400)]
Add UFField to syntaxConformanceTest

5 years agoMerge pull request #14105 from eileenmcnaughton/import
Seamus Lee [Mon, 22 Apr 2019 20:27:38 +0000 (06:27 +1000)]
Merge pull request #14105 from eileenmcnaughton/import

 [REF] calll formatLocationBlock from parent function.

5 years agoMerge pull request #14107 from mattwire/formbuttons_formatting
Seamus Lee [Mon, 22 Apr 2019 20:27:18 +0000 (06:27 +1000)]
Merge pull request #14107 from mattwire/formbuttons_formatting

NFC Whitespace formatting for formButtons.tpl

5 years agoMerge pull request #14111 from mlutfy/sms-ts
Seamus Lee [Mon, 22 Apr 2019 20:26:53 +0000 (06:26 +1000)]
Merge pull request #14111 from mlutfy/sms-ts

Fix ts() usage in CRM_SMS_Form_Schedule

5 years agoReplace hardcoded IDs with pseudoconstants in activity form
Matthew Wire (MJW Consulting) [Mon, 22 Apr 2019 12:22:08 +0000 (13:22 +0100)]
Replace hardcoded IDs with pseudoconstants in activity form

5 years agoAdd function filterLinks to return an array of links for an entity that can be used...
Matthew Wire (MJW Consulting) [Mon, 22 Apr 2019 14:08:50 +0000 (15:08 +0100)]
Add function filterLinks to return an array of links for an entity that can be used by the API / form layer to generate a link

5 years agoRefactor-Don't pass activity object to addCaseActivityLinks
Matthew Wire (MJW Consulting) [Mon, 22 Apr 2019 12:38:00 +0000 (13:38 +0100)]
Refactor-Don't pass activity object to addCaseActivityLinks

5 years agoFix ts() usage in CRM_SMS_Form_Schedule
Mathieu Lutfy [Mon, 22 Apr 2019 13:20:28 +0000 (09:20 -0400)]
Fix ts() usage in CRM_SMS_Form_Schedule

5 years agoUse shared function to check inbound email permissions
Matthew Wire (MJW Consulting) [Mon, 22 Apr 2019 12:24:13 +0000 (13:24 +0100)]
Use shared function to check inbound email permissions

5 years ago(REF) Standardize UFField create function
Coleman Watts [Thu, 18 Apr 2019 18:00:51 +0000 (14:00 -0400)]
(REF) Standardize UFField create function

5 years agoFix creating Formatting fields in api and UI
Coleman Watts [Thu, 18 Apr 2019 17:52:25 +0000 (13:52 -0400)]
Fix creating Formatting fields in api and UI

5 years agoWhitespace formatting for formButtons.tpl
Matthew Wire (MJW Consulting) [Mon, 22 Apr 2019 11:54:41 +0000 (12:54 +0100)]
Whitespace formatting for formButtons.tpl

5 years agoRemove now-redundant if
eileen [Fri, 12 Apr 2019 07:55:15 +0000 (17:55 +1000)]
Remove now-redundant if

This is no longer called when location_type_id is empty

5 years ago[REF] calll formatLocationBlock from parent function.
eileen [Fri, 12 Apr 2019 07:18:11 +0000 (17:18 +1000)]
[REF] calll formatLocationBlock from parent function.

This is about starting to unnest the spaghetti of functions here.....
Just deprecating for now in case

5 years agoMerge pull request #14099 from seamuslee001/pledge_dates_contribution_form_conversion
Eileen McNaughton [Mon, 22 Apr 2019 08:03:25 +0000 (18:03 +1000)]
Merge pull request #14099 from seamuslee001/pledge_dates_contribution_form_conversion

Convert Pledge Calander Date and Start Date for pledges to use datepic…

5 years agoConvert Pledge Calander Date and Start Date for pleges to use datepicker rather than...
Seamus Lee [Sun, 21 Apr 2019 23:45:41 +0000 (09:45 +1000)]
Convert Pledge Calander Date and Start Date for pleges to use datepicker rather than jcalendar

5 years agoMerge pull request #14101 from civicrm/5.13
Seamus Lee [Mon, 22 Apr 2019 02:41:41 +0000 (12:41 +1000)]
Merge pull request #14101 from civicrm/5.13

5.13

5 years agoMerge pull request #14100 from seamuslee001/5.13
Seamus Lee [Mon, 22 Apr 2019 01:52:07 +0000 (11:52 +1000)]
Merge pull request #14100 from seamuslee001/5.13

Add release-notes/5.12.3.md

5 years agoAdd release-notes/5.12.3.md
Tim Otten [Sat, 20 Apr 2019 15:44:42 +0000 (08:44 -0700)]
Add release-notes/5.12.3.md

5 years agoMerge pull request #13890 from aydun/joomla#6
Seamus Lee [Mon, 22 Apr 2019 00:27:38 +0000 (10:27 +1000)]
Merge pull request #13890 from aydun/joomla#6

Fix bug preventing affecting `cv --user` on Joomla

5 years agoMerge pull request #14096 from colemanw/tags
colemanw [Sun, 21 Apr 2019 17:32:18 +0000 (13:32 -0400)]
Merge pull request #14096 from colemanw/tags

Add serialize metadata to tag used_for field

5 years agoRemove problematic serialize handing from conformance test
Coleman Watts [Sun, 21 Apr 2019 15:08:18 +0000 (11:08 -0400)]
Remove problematic serialize handing from conformance test

5 years agoMerge pull request #14088 from MegaphoneJon/membership-9
Eileen McNaughton [Sun, 21 Apr 2019 01:27:35 +0000 (11:27 +1000)]
Merge pull request #14088 from MegaphoneJon/membership-9

membership#9 - show user a notification on back-office renewals

5 years agoAdd serialize metadata to tag used_for field
Coleman Watts [Sun, 21 Apr 2019 00:24:08 +0000 (20:24 -0400)]
Add serialize metadata to tag used_for field

The used_for field is a comma separated list.

5 years agoMerge pull request #13963 from eileenmcnaughton/event_report
Seamus Lee [Sat, 20 Apr 2019 20:41:11 +0000 (06:41 +1000)]
Merge pull request #13963 from eileenmcnaughton/event_report

Readability cleanup on EventIncome report (towards bringing it under testing)

5 years agoMerge pull request #14094 from seamuslee001/node_dedupe_exception_test
colemanw [Sat, 20 Apr 2019 13:42:47 +0000 (09:42 -0400)]
Merge pull request #14094 from seamuslee001/node_dedupe_exception_test

(NFC) Add tests of retreiving notes for display on a contact record a…

5 years agoConvert Recurring forms to entity forms
eileen [Sun, 7 Apr 2019 21:50:56 +0000 (09:50 +1200)]
Convert Recurring forms to entity forms

5 years agoMerge pull request #14091 from civicrm/5.13
Eileen McNaughton [Sat, 20 Apr 2019 07:35:23 +0000 (17:35 +1000)]
Merge pull request #14091 from civicrm/5.13

5.13

5 years ago(NFC) Add tests of retreiving notes for display on a contact record and returning...
Seamus Lee [Sat, 20 Apr 2019 03:50:28 +0000 (13:50 +1000)]
(NFC) Add tests of retreiving notes for display on a contact record and returning DedupeExecptions for output on page

Update Unit test to check output of note browse as well

5 years agoMerge pull request #14073 from seamuslee001/dev_core_881_unit_test
Seamus Lee [Sat, 20 Apr 2019 03:20:55 +0000 (13:20 +1000)]
Merge pull request #14073 from seamuslee001/dev_core_881_unit_test

dev/core#881 Add in unit test demonstrating issue Stoob found with is…

5 years agoMerge pull request #14092 from eileenmcnaughton/search_513
Seamus Lee [Sat, 20 Apr 2019 02:18:43 +0000 (12:18 +1000)]
Merge pull request #14092 from eileenmcnaughton/search_513

dev/core#887 Fix fatal error on pledge search

5 years agoMerge pull request #14083 from grischard/patch-1
Eileen McNaughton [Sat, 20 Apr 2019 01:23:04 +0000 (11:23 +1000)]
Merge pull request #14083 from grischard/patch-1

Fix upgrade message db setting location

5 years agoReadability cleanup on EventIncome report to bring it under testing
eileen [Fri, 5 Apr 2019 01:15:12 +0000 (14:15 +1300)]
Readability cleanup on EventIncome report to bring it under testing

5 years agoMerge pull request #14052 from yashodha/dev-876
colemanw [Sat, 20 Apr 2019 01:06:08 +0000 (21:06 -0400)]
Merge pull request #14052 from yashodha/dev-876

(dev/core#876) Allow url to set IS NULL/ NOT NULL in report for opera…

5 years agoMerge pull request #14059 from Stoob/patch-2
colemanw [Sat, 20 Apr 2019 01:04:25 +0000 (21:04 -0400)]
Merge pull request #14059 from Stoob/patch-2

change is_override logic

5 years agoMerge pull request #14077 from pradpnayak/AutoComplete
colemanw [Sat, 20 Apr 2019 01:00:42 +0000 (21:00 -0400)]
Merge pull request #14077 from pradpnayak/AutoComplete

Fixed auto populate of contact refrence field on membership signup form

5 years agoMerge pull request #14050 from eileenmcnaughton/import
colemanw [Sat, 20 Apr 2019 00:58:27 +0000 (20:58 -0400)]
Merge pull request #14050 from eileenmcnaughton/import

[REF] cleanup input parameters on extracted function

5 years agodev/core#887 Fix fatal error on pledge search
eileen [Sat, 20 Apr 2019 00:56:36 +0000 (10:56 +1000)]
dev/core#887 Fix fatal error on pledge search

5 years agoMerge pull request #14090 from seamuslee001/5.13
Tim Otten [Fri, 19 Apr 2019 23:05:14 +0000 (16:05 -0700)]
Merge pull request #14090 from seamuslee001/5.13

Add release-notes/5.12.2.md

5 years agoAdd release-notes/5.12.2.md
Tim Otten [Fri, 19 Apr 2019 22:59:22 +0000 (15:59 -0700)]
Add release-notes/5.12.2.md

5 years agoCiviCase: use aliases on all items in case activity query b/c ANY_VALUE
Andrew Hunt [Fri, 19 Apr 2019 22:40:16 +0000 (18:40 -0400)]
CiviCase: use aliases on all items in case activity query b/c ANY_VALUE

5 years agomembership#9 - show user a notification on back-office renewals
Jon Goldberg [Fri, 19 Apr 2019 22:20:00 +0000 (18:20 -0400)]
membership#9 - show user a notification on back-office renewals

5 years agoCiviCase: remove multi-nested subqueries when work now handled by views
Andrew Hunt [Fri, 19 Apr 2019 20:41:01 +0000 (16:41 -0400)]
CiviCase: remove multi-nested subqueries when work now handled by views

5 years agoCiviCase: test for activity query latest activity
Andrew Hunt [Fri, 19 Apr 2019 20:06:24 +0000 (16:06 -0400)]
CiviCase: test for activity query latest activity

5 years agoCiviCase: recent case activity view pull one per case
Andrew Hunt [Fri, 19 Apr 2019 19:13:54 +0000 (15:13 -0400)]
CiviCase: recent case activity view pull one per case

5 years agoCiviCase: simplify activity type, date, and id fields in case activity query
Andrew Hunt [Fri, 19 Apr 2019 14:51:36 +0000 (10:51 -0400)]
CiviCase: simplify activity type, date, and id fields in case activity query

5 years agoMerge pull request #14085 from totten/master-cron-doc
colemanw [Fri, 19 Apr 2019 13:12:18 +0000 (09:12 -0400)]
Merge pull request #14085 from totten/master-cron-doc

Cron Status Check - Better hyperlinks

5 years agoCiviCase: convoluted subquery in case activity query
Andrew Hunt [Thu, 18 Apr 2019 23:40:50 +0000 (19:40 -0400)]
CiviCase: convoluted subquery in case activity query

5 years agoCiviCase: use pseudoconstants in case activity query
Andrew Hunt [Thu, 18 Apr 2019 23:19:39 +0000 (19:19 -0400)]
CiviCase: use pseudoconstants in case activity query

5 years agoMerge pull request #14079 from colemanw/setValues
Matthew Wire [Thu, 18 Apr 2019 20:44:09 +0000 (21:44 +0100)]
Merge pull request #14079 from colemanw/setValues

(REF) Fix accepted params in CustomValueTable::setValues

5 years agoMerge pull request #14075 from colemanw/contactBAO
Matthew Wire [Thu, 18 Apr 2019 20:35:03 +0000 (21:35 +0100)]
Merge pull request #14075 from colemanw/contactBAO

(REF) Fix unnecessary required param in contact BAO update

5 years agoMerge pull request #14067 from colemanw/menuZindex
colemanw [Thu, 18 Apr 2019 17:58:18 +0000 (13:58 -0400)]
Merge pull request #14067 from colemanw/menuZindex

Menubar z-index fixes

5 years agoCron Status Check - Better hyperlinks
Tim Otten [Thu, 18 Apr 2019 17:31:27 +0000 (10:31 -0700)]
Cron Status Check - Better hyperlinks

* The old link pointed to a frozen wiki page with bad styling
* The old link was buried

5 years agoCRM_Utils_System - Allow docURL functions to support "sysadmin" and "dev" links
Tim Otten [Thu, 18 Apr 2019 17:30:35 +0000 (10:30 -0700)]
CRM_Utils_System - Allow docURL functions to support "sysadmin" and "dev" links

5 years agoMerge pull request #14014 from MegaphoneJon/reporting-14
colemanw [Thu, 18 Apr 2019 14:21:47 +0000 (10:21 -0400)]
Merge pull request #14014 from MegaphoneJon/reporting-14

fix getAddressColumns() to respect tableAlias

5 years agoFix upgrade message db setting location
Guillaume Rischard [Thu, 18 Apr 2019 13:58:19 +0000 (15:58 +0200)]
Fix upgrade message db setting location

5 years agoBetter variable name
Coleman Watts [Tue, 16 Apr 2019 20:40:36 +0000 (16:40 -0400)]
Better variable name

5 years agoSimplify hiding CMS elements behind modal dialogs
Coleman Watts [Tue, 16 Apr 2019 20:36:42 +0000 (16:36 -0400)]
Simplify hiding CMS elements behind modal dialogs

Using css instead of js makes this a lot simpler

5 years agoMerge pull request #14062 from civicrm/5.13
Seamus Lee [Thu, 18 Apr 2019 04:52:59 +0000 (14:52 +1000)]
Merge pull request #14062 from civicrm/5.13

5.13

5 years agoMerge pull request #13956 from seamuslee001/dev_mail_41
Eileen McNaughton [Thu, 18 Apr 2019 04:43:42 +0000 (14:43 +1000)]
Merge pull request #13956 from seamuslee001/dev_mail_41

dev/mail#41 Do not generate tracking urls if no mailing id has been p…

5 years agoMerge pull request #14076 from seamuslee001/e2e_rest_test_get_admin_contact_id
colemanw [Thu, 18 Apr 2019 01:33:34 +0000 (21:33 -0400)]
Merge pull request #14076 from seamuslee001/e2e_rest_test_get_admin_contact_id

(NFC) Add in unit test checking that E2E test returns sensible contac…

5 years agoFix unnecessary required param in contact BAO create
Coleman Watts [Wed, 17 Apr 2019 00:45:36 +0000 (20:45 -0400)]
Fix unnecessary required param in contact BAO create

Normally a BAO should require an id and nothing else for an update op
But the contact BAO required contact_type for no good reason.