Seamus Lee [Tue, 25 Jul 2023 07:41:10 +0000 (03:41 -0400)]
Merge pull request #24683 from larssandergreen/check-if-employer-matches-employer-value-in-profile
Check if profile contact employer name matches existing contact employer name when saving profile
Seamus Lee [Tue, 25 Jul 2023 01:59:39 +0000 (21:59 -0400)]
Merge pull request #26889 from demeritcowboy/slow
Status check - Use guzzle instead to avoid slowness reading zero-length file
Eileen McNaughton [Tue, 25 Jul 2023 01:53:06 +0000 (13:53 +1200)]
Merge pull request #26926 from eileenmcnaughton/import_part
Fix multi-value custom fields on participant import
Jon Goldberg [Tue, 4 Apr 2023 16:59:31 +0000 (12:59 -0400)]
Fix multi-value custom fields on participant import
Eileen McNaughton [Mon, 24 Jul 2023 19:35:33 +0000 (07:35 +1200)]
Merge pull request #26924 from larssandergreen/Update-tests-to-ignore-packaged-saved-searches
Update tests to ignore packaged saved searches
Aidan Saunders [Mon, 24 Jul 2023 19:24:16 +0000 (20:24 +0100)]
Merge pull request #26921 from aydun/add_browse
Add '<browse>' links matching those in AdminUI
larssandergreen [Mon, 24 Jul 2023 18:22:30 +0000 (12:22 -0600)]
Update tests to ignore packaged saved searches
Aidan Saunders [Mon, 24 Jul 2023 15:09:06 +0000 (16:09 +0100)]
Add '<browse>' links matching those in AdminUI
demeritcowboy [Mon, 24 Jul 2023 15:21:38 +0000 (11:21 -0400)]
Merge pull request #26919 from aydun/searchui_findcontacts
SearchUI:Move 'Find Contacts' upgrader steps from AdminUI to SearchUI
Aidan Saunders [Mon, 24 Jul 2023 13:21:56 +0000 (14:21 +0100)]
Move 'Find Contacts' upgrader steps from AdminUI to SearchUI
Yashodha Chaku [Mon, 24 Jul 2023 13:53:39 +0000 (19:23 +0530)]
Merge pull request #26918 from colemanw/arrayValueAssignments
REF - Split variable assignments out of conditionals
Aidan Saunders [Mon, 24 Jul 2023 11:53:06 +0000 (12:53 +0100)]
Merge pull request #26896 from colemanw/mappingMetadata
AdminUI - Add Administer Scheduled Reminders page
colemanw [Mon, 24 Jul 2023 11:18:01 +0000 (04:18 -0700)]
Merge pull request #26825 from colemanw/dialogHeight
Reduce initial height of crm-popup dialog
colemanw [Mon, 24 Jul 2023 10:29:21 +0000 (06:29 -0400)]
REF - Split variable assignments out of conditionals
colemanw [Mon, 24 Jul 2023 10:16:45 +0000 (03:16 -0700)]
Merge pull request #26914 from eileenmcnaughton/mem_amount
Remove old broken code
Tim Otten [Mon, 24 Jul 2023 08:11:56 +0000 (01:11 -0700)]
Merge pull request #26772 from seamuslee001/fix_unit_test_failure_wp_url
(dev/core#4433) Fix unit test failure on WordPress by specifying --entry=backend
Seamus Lee [Mon, 24 Jul 2023 07:39:30 +0000 (03:39 -0400)]
Merge pull request #26916 from eileenmcnaughton/line
[PHP8.2] Remove undefined property in favour of calc-as-needed
Eileen McNaughton [Mon, 24 Jul 2023 05:10:01 +0000 (17:10 +1200)]
[PHP8.2] Remove undefined property in favour of calc-as-needed
This appears to be one of those cases where they wanted to
'save the code the effort' of calculating twice - but
it is a trivial calculation balanced
against the confusion of setting an undefined
property in one place to use later
Eileen McNaughton [Mon, 24 Jul 2023 04:09:30 +0000 (16:09 +1200)]
Remove old broken code
colemanw [Mon, 24 Jul 2023 02:38:04 +0000 (19:38 -0700)]
Merge pull request #26904 from larssandergreen/css-fix-for-delete-button
Remove gap before delete button on contact
colemanw [Mon, 24 Jul 2023 02:35:09 +0000 (19:35 -0700)]
Merge pull request #26908 from eileenmcnaughton/member
Follow on cleanup - remove unused assign
colemanw [Mon, 24 Jul 2023 02:33:53 +0000 (19:33 -0700)]
Merge pull request #26909 from eileenmcnaughton/member_2
Stop setting undeclared property in previously shared code
Seamus Lee [Mon, 24 Jul 2023 02:25:06 +0000 (22:25 -0400)]
Merge pull request #26907 from eileenmcnaughton/notice_pay
dev/core#4435 Fix e-notice with Manual processor
Tim Otten [Mon, 24 Jul 2023 00:43:19 +0000 (17:43 -0700)]
Merge pull request #26910 from eileenmcnaughton/setting
dev/core#1926 Add docs link to civicrm.settings.php.template
Eileen McNaughton [Sun, 23 Jul 2023 23:51:20 +0000 (11:51 +1200)]
dev/core#1926 Add docs link to civicrm.settings.php.template
Eileen McNaughton [Sun, 23 Jul 2023 23:38:54 +0000 (11:38 +1200)]
Stop setting undeclared property in previously shared code
Eileen McNaughton [Sun, 23 Jul 2023 23:29:24 +0000 (11:29 +1200)]
Follow on cleanup - remove unused assign
Eileen McNaughton [Sun, 23 Jul 2023 23:24:19 +0000 (11:24 +1200)]
Merge pull request #25458 from MegaphoneJon/lifetime-membership-fix-2
fix lifetime membership calc in contribution pages
Eileen McNaughton [Sun, 23 Jul 2023 23:14:36 +0000 (11:14 +1200)]
Fix e-notice with Manual processor
Eileen McNaughton [Sun, 23 Jul 2023 22:52:34 +0000 (10:52 +1200)]
Merge pull request #26906 from civicrm/5.64
5.64 to master
Eileen McNaughton [Sun, 23 Jul 2023 22:49:27 +0000 (10:49 +1200)]
Merge pull request #26893 from demeritcowboy/mistaken-identity
dev/core#4441 - Incorrect error "There might be a data problem, contribution id could not be loaded from the line item"
larssandergreen [Sun, 23 Jul 2023 18:41:07 +0000 (12:41 -0600)]
Remove gap before delete button on contact
demeritcowboy [Sun, 23 Jul 2023 16:20:31 +0000 (12:20 -0400)]
Merge pull request #26900 from totten/master-relurl
Fix relative URL generation when using alternate HTTP port
demeritcowboy [Sun, 23 Jul 2023 14:49:26 +0000 (10:49 -0400)]
Merge pull request #26890 from larssandergreen/Label-Page-Formats-follow-up
Link between Label Page Formats and Address Settings
larssandergreen [Sun, 23 Jul 2023 14:17:29 +0000 (08:17 -0600)]
Link between Label Page Formats and Address Settings
colemanw [Sat, 22 Jul 2023 06:10:16 +0000 (23:10 -0700)]
Merge pull request #26899 from colemanw/utilsArrayFixes
[REF] Fix CRM_Utils_Array calls that return potentially incorrect value types
colemanw [Sat, 22 Jul 2023 03:32:02 +0000 (20:32 -0700)]
(REF) Replace CRM_Utils_Array in more complex cases
colemanw [Sat, 22 Jul 2023 03:29:49 +0000 (20:29 -0700)]
CRM_Utils_String::munge() - Change test
colemanw [Sat, 22 Jul 2023 03:27:35 +0000 (20:27 -0700)]
(REF) Replace CRM_Utils_Array in context of date-time function calls
colemanw [Sat, 22 Jul 2023 03:24:36 +0000 (20:24 -0700)]
(REF) Replace CRM_Utils_Array in context of conditional expressions
colemanw [Sat, 22 Jul 2023 03:20:25 +0000 (20:20 -0700)]
(REF) Replace CRM_Utils_Array in context of string-building (HTML/SQL/URL/etc)
colemanw [Sat, 22 Jul 2023 03:10:47 +0000 (20:10 -0700)]
(REF) Replace CRM_Utils_Array having default ''
colemanw [Sat, 22 Jul 2023 03:08:59 +0000 (20:08 -0700)]
(REF) Replace CRM_Utils_Array in context of munge()
colemanw [Sat, 22 Jul 2023 03:03:47 +0000 (20:03 -0700)]
(REF) Replace CRM_Utils_Array in context of is_numeric()
colemanw [Sat, 22 Jul 2023 02:57:06 +0000 (19:57 -0700)]
(REF) Replace CRM_Utils_Array with equivalent `?? NULL`
Tim Otten [Sat, 22 Jul 2023 01:18:27 +0000 (18:18 -0700)]
Fix relative URL generation when using alternate HTTP port
Tim Otten [Sat, 22 Jul 2023 00:17:01 +0000 (17:17 -0700)]
(REF) Extract method CRM_Utils_Url::toRelative()
Aidan Saunders [Fri, 21 Jul 2023 20:26:02 +0000 (21:26 +0100)]
Merge pull request #26898 from colemanw/noBrowse
Remove 'browse' link that shouldn't be there
colemanw [Fri, 21 Jul 2023 17:25:02 +0000 (13:25 -0400)]
AdminUI - Add Administer Scheduled Reminders page
colemanw [Fri, 21 Jul 2023 17:15:17 +0000 (13:15 -0400)]
ActionSchedule - Add dynamic pseudoconstants and other metadata
colemanw [Fri, 21 Jul 2023 17:33:03 +0000 (13:33 -0400)]
Remove 'browse' link that shouldn't be there
demeritcowboy [Fri, 21 Jul 2023 17:04:48 +0000 (13:04 -0400)]
Merge pull request #26894 from colemanw/fixTrimWarning
[PHP Deprecation] trim(): Passing null to parameter #1 () of type string
colemanw [Fri, 21 Jul 2023 16:32:48 +0000 (12:32 -0400)]
Pseudoconstant - Standardize callback params
Before: pseudoconstant callbacks received different params depending on where they were being called from
After: Standardized on ($fieldName, $params)
Note: The previous $context arg is useless and also contained in $params if it's really needed.
colemanw [Fri, 21 Jul 2023 15:34:31 +0000 (11:34 -0400)]
[PHP Deprecation] trim(): Passing null to parameter #1 () of type string is deprecated
colemanw [Fri, 21 Jul 2023 15:13:42 +0000 (11:13 -0400)]
DAO - Add 'fillValues' utility function to facilitate looking up fields from an incomplete record.
demeritcowboy [Fri, 21 Jul 2023 14:26:02 +0000 (10:26 -0400)]
Merge pull request #26892 from artfulrobot/artfulrobot-fix-getcount-on-smartgroups
getEntitySpecificJoins sometimes returns NULL, triggering deprecation warning for trim() in php 8.1
demeritcowboy [Fri, 21 Jul 2023 13:44:02 +0000 (09:44 -0400)]
fix
colemanw [Fri, 21 Jul 2023 13:25:12 +0000 (06:25 -0700)]
Merge pull request #26887 from colemanw/crmAdminFormRedirect
CRM_Admin_Form - Automatically redirect to the "browse" page after submission
colemanw [Fri, 21 Jul 2023 02:47:02 +0000 (22:47 -0400)]
System - Prevent php deprecation notice in pushUserContext
Rich Lott / Artful Robot [Fri, 21 Jul 2023 12:18:26 +0000 (13:18 +0100)]
getEntitySpecificJoins sometimes returns NULL, triggering deprecation warning for trim() in php 8.1
Discovered this in the wild where an api3 Contact.getcount call for a particular smartgroup
was causing this. The smartgroup otherwise works fine.
Looking at the code, it's clear that getEntitySpecificJoins is supposed to return a string,
but in the case of civicrm_activity_contact it was returning from another function which may
return NULL. I have coalesced NULL to empty string.
Aidan Saunders [Fri, 21 Jul 2023 05:45:59 +0000 (06:45 +0100)]
Merge pull request #26746 from aydun/adminui_contributions
SearchUI: add Find Contributions
demeritcowboy [Fri, 21 Jul 2023 01:53:23 +0000 (21:53 -0400)]
Merge pull request #26873 from eileenmcnaughton/custom_2
[PHP8.2] Convert remaining properties to local variables / private properties
Aidan Saunders [Thu, 20 Jul 2023 22:27:52 +0000 (23:27 +0100)]
Update Readme & links
Tim Otten [Thu, 20 Jul 2023 21:31:27 +0000 (14:31 -0700)]
Merge pull request #26865 from larssandergreen/Label-page-formats
Change Administer > Communications > Label Formats to Label Page Formats
demeritcowboy [Thu, 20 Jul 2023 21:00:11 +0000 (17:00 -0400)]
Merge pull request #26888 from colemanw/removeDoubleHtmlize
CRM_Utils_System::url - Remove unused param to double-escape html
colemanw [Thu, 20 Jul 2023 17:32:21 +0000 (13:32 -0400)]
Metadata - add 'browse' path to LocationType entity
colemanw [Thu, 20 Jul 2023 17:30:37 +0000 (13:30 -0400)]
AdminForm - Automatically redirect back to browse page after form submittion
This reads from the `paths` metadata in the DAO to look for a 'browse' path;
we need to add 'browse' paths to the rest of our entities.
colemanw [Thu, 20 Jul 2023 15:10:42 +0000 (11:10 -0400)]
CRM_Admin_Form - general code cleanup
Mathieu Lu [Thu, 20 Jul 2023 20:46:13 +0000 (16:46 -0400)]
Merge pull request #26878 from colemanw/locationTypeFixes
[REF] LocationType - Set defaults, modernize form and BAO
colemanw [Thu, 20 Jul 2023 20:39:36 +0000 (13:39 -0700)]
Merge pull request #26886 from mlutfy/ui51
dev/user-interface#51 Remove top buttons on admin forms
colemanw [Thu, 20 Jul 2023 20:30:08 +0000 (13:30 -0700)]
Merge pull request #26881 from colemanw/actionMappingLimit
ScheduledReminders - Add option list for limit_to column and fix type
colemanw [Thu, 20 Jul 2023 16:36:55 +0000 (12:36 -0400)]
CRM_Utils_System::url - Remove unused param to double-escape html
demeritcowboy [Thu, 20 Jul 2023 19:28:14 +0000 (15:28 -0400)]
add explanatory comment
colemanw [Wed, 19 Jul 2023 23:55:55 +0000 (19:55 -0400)]
ScheduledReminders - Handle legacy input for limit_to
colemanw [Wed, 19 Jul 2023 21:10:32 +0000 (17:10 -0400)]
ScheduledReminders - Add option list for limit_to column and fix type
Before: limit_to column is 'boolean' in the metadata and has no option list, but
effectively it has 3 options: NULL, '0' and '1'.
After: Changed type to 'integer', added pseudoconstant, and renamed the '0' option
to '2' so it isn't as easily confused with NULL.
Mathieu Lutfy [Thu, 20 Jul 2023 10:50:13 +0000 (06:50 -0400)]
dev/user-interface#51 Remove top buttons on admin forms
demeritcowboy [Mon, 10 Jul 2023 21:43:17 +0000 (17:43 -0400)]
use guzzle instead to avoid problems reading zero-length file
colemanw [Thu, 20 Jul 2023 15:05:17 +0000 (08:05 -0700)]
Merge pull request #26884 from colemanw/scheduledRemindersStandaloneForm
ScheduledReminders - Refactor form to work at a standalone url
Seamus Lee [Thu, 20 Jul 2023 08:27:39 +0000 (04:27 -0400)]
Merge pull request #26885 from civicrm/5.64
5.64
Seamus Lee [Thu, 20 Jul 2023 05:40:06 +0000 (01:40 -0400)]
Merge pull request #26868 from seamuslee001/fix_redirect_url_payment_processor_wordpress
[REF] Ensure that url that is stored as context is generated correctl…
demeritcowboy [Thu, 20 Jul 2023 05:17:34 +0000 (01:17 -0400)]
Merge pull request #25206 from mattwire/activityexternalid
Allow matching on external_identifier for source/target contacts on Activity import
Eileen McNaughton [Thu, 20 Jul 2023 03:42:50 +0000 (15:42 +1200)]
Merge pull request #26343 from larssandergreen/More-PHP8-warnings-on-Participant
Fix PHP8 tax_rate warning on Participant
colemanw [Thu, 20 Jul 2023 01:38:49 +0000 (21:38 -0400)]
ScheduledReminders - Refactor form to work at a standalone url
colemanw [Thu, 20 Jul 2023 00:41:53 +0000 (20:41 -0400)]
LocationType - Fix error in fix for smarty notices
colemanw [Wed, 19 Jul 2023 15:49:46 +0000 (11:49 -0400)]
LocationType - Fix generated sql with correct defaults and untranslated names
Eileen McNaughton [Wed, 19 Jul 2023 23:46:45 +0000 (11:46 +1200)]
Merge pull request #26883 from colemanw/adminUiVer
Mark admin_ui extension as 'beta'
colemanw [Wed, 19 Jul 2023 23:45:00 +0000 (16:45 -0700)]
Merge pull request #26882 from seamuslee001/5.64
dev/core#4439 Fix price set select broken price attr regression
Eileen McNaughton [Wed, 19 Jul 2023 23:40:32 +0000 (11:40 +1200)]
Merge pull request #26880 from colemanw/jobToJob
Job - uppercase api entity
colemanw [Wed, 19 Jul 2023 23:15:44 +0000 (19:15 -0400)]
Mark admin_ui extension as 'beta'
Seamus Lee [Wed, 19 Jul 2023 22:53:56 +0000 (18:53 -0400)]
Merge pull request #26876 from colemanw/scheduleReminderForm
[REF] ScheduleReminders - Cleanup "sublimely stupid" form code
larssandergreen [Tue, 18 Jul 2023 18:56:15 +0000 (12:56 -0600)]
Fix price set select broken price attr regression
colemanw [Wed, 19 Jul 2023 18:07:10 +0000 (14:07 -0400)]
Job - uppercase api entity
Matthew Wire [Thu, 15 Dec 2022 21:46:42 +0000 (21:46 +0000)]
Allow activity import matching source/target contact on external ID
colemanw [Wed, 19 Jul 2023 15:08:45 +0000 (11:08 -0400)]
LocationType - Set defaults
Matthew Wire [Wed, 19 Jul 2023 14:24:42 +0000 (15:24 +0100)]
Merge pull request #26877 from colemanw/godHasAnswered
God has answered
colemanw [Wed, 19 Jul 2023 01:24:11 +0000 (21:24 -0400)]
God has answered
colemanw [Wed, 19 Jul 2023 00:30:12 +0000 (20:30 -0400)]
ScheduleReminders - Cleanup awful form code
Lots more refactoring to do, this fixes the easy-to-fix things that were obviously wrong.
colemanw [Tue, 18 Jul 2023 23:34:31 +0000 (16:34 -0700)]
Merge pull request #26867 from eileenmcnaughton/import
Fix js error on CiviImport when csv has additional fields
Eileen McNaughton [Tue, 18 Jul 2023 23:16:39 +0000 (11:16 +1200)]
Merge pull request #26875 from civicrm/5.64
5.64
Eileen McNaughton [Tue, 18 Jul 2023 20:18:17 +0000 (08:18 +1200)]
Convert remaining properties to local variables / private properties