Tim Otten [Sun, 4 Oct 2020 01:00:20 +0000 (18:00 -0700)]
composer.json - Update composer-compile-lib
Eileen McNaughton [Sat, 3 Oct 2020 23:02:54 +0000 (12:02 +1300)]
Merge pull request #18669 from demeritcowboy/blank-target-contact
dev/core#2090 - Undefined index on contact's activity tab when there's an activity that has no With Contact
Andrew Hunt [Mon, 14 Sep 2020 18:39:45 +0000 (14:39 -0400)]
StateProvince DAO title should be State/Province
Andrew Hunt [Mon, 14 Sep 2020 18:38:27 +0000 (14:38 -0400)]
Select placeholders should always say what kind of thing they select
Andrew Hunt [Sat, 20 Jun 2020 18:00:33 +0000 (14:00 -0400)]
Cleanup with ??
Andrew Hunt [Sat, 20 Jun 2020 17:14:42 +0000 (13:14 -0400)]
Attributes for a form element should always be an array
demeritcowboy [Sat, 3 Oct 2020 16:46:15 +0000 (12:46 -0400)]
handle missing array member
eileen [Fri, 2 Oct 2020 20:59:47 +0000 (09:59 +1300)]
dev/core#2079 [REF] clean up call to apiQuery
This fixes
1) fixes apiQuery to be called statically as it is a static function
2) casts results directly to detail
This is the copy & paste source of https://github.com/civicrm/civicrm-core/pull/18664 I guess....
Coleman Watts [Sat, 3 Oct 2020 00:44:43 +0000 (20:44 -0400)]
Search ext: Fix column appearing in the aggregate list when it is used in GROUP_BY
The bug was that it wasn't recognizing the column name after a function was added to it.
Coleman Watts [Wed, 30 Sep 2020 18:56:59 +0000 (14:56 -0400)]
Search ext: Extend api4 smart groups to work with HAVING
eileen [Fri, 2 Oct 2020 03:22:42 +0000 (16:22 +1300)]
Add unit test to cover pcp submission
eileen [Tue, 22 Sep 2020 03:23:53 +0000 (15:23 +1200)]
dev/core#2056 Only retrieve pcp & soft_credit info when needed
Currently we do 2 queries per contribution create to retrieve pcp & soft credit info. However, the
results of the queries are only used if pcp or soft credit keys exist in the params array
Eileen McNaughton [Fri, 2 Oct 2020 22:01:17 +0000 (11:01 +1300)]
Merge pull request #18666 from civicrm/5.30
5.30 to master
Eileen McNaughton [Fri, 2 Oct 2020 22:00:19 +0000 (11:00 +1300)]
Merge pull request #18648 from demeritcowboy/missing-mail-help
dev/core#1920 - Fix smarty error and missing mail setting help
Eileen McNaughton [Fri, 2 Oct 2020 21:58:09 +0000 (10:58 +1300)]
Merge pull request #18660 from totten/master-bundle-ext
(REF) Make it easier for extensions to define basic bundles
Coleman Watts [Tue, 29 Sep 2020 15:30:19 +0000 (11:30 -0400)]
Search ext: Choose smart group contact column
Coleman Watts [Tue, 29 Sep 2020 20:22:50 +0000 (16:22 -0400)]
Search ext: fix missing titles in multivalue custom entities
Coleman Watts [Mon, 28 Sep 2020 20:17:16 +0000 (16:17 -0400)]
Search ext: Ability to load saved searches by id
Tim Otten [Fri, 2 Oct 2020 07:31:18 +0000 (00:31 -0700)]
(NFC) Update docblock in CRM_Core_Resources_Common
eileen [Mon, 28 Sep 2020 01:41:10 +0000 (14:41 +1300)]
dev/core#1790 - Contact Card - Email Links
Alternate to https://github.com/civicrm/civicrm-core/pull/17517
The current PR stalled on the issue that passing 'email' to the email task could load up
the wrong contact. This gets around that by doing a separate (but hopefully quick) lookup
to grab the email id. I also made it dependent on the url having is_show_email_task=1 in
it. I went back & forwards on that vs is_backoffice
Tim Otten [Fri, 2 Oct 2020 00:38:00 +0000 (17:38 -0700)]
(DX) Resources - Add helper for creating new bundles
Tim Otten [Fri, 2 Oct 2020 00:16:44 +0000 (17:16 -0700)]
(REF) Convert hidden function 'useRegion' to public 'fillDefaults'
This mostly affects a hypothetical bundle defined outside of core's `Common.php`:
* Before: You cannot re-use `useRegion()`. You'd have to write it again.
* After: You can re-use and/or override `fillDefaults()`.
Seamus Lee [Fri, 2 Oct 2020 05:05:00 +0000 (15:05 +1000)]
Merge pull request #18635 from colemanw/angular-1.8
dev/core#1818 Upgrade AngularJS from 1.5.11 to 1.8
Seamus Lee [Fri, 2 Oct 2020 03:19:00 +0000 (13:19 +1000)]
Merge pull request #18636 from demeritcowboy/test-scalar-target
dev/core#2057 - Failing unit test for passing in activity contacts as scalars to Activity::create()
Seamus Lee [Fri, 2 Oct 2020 03:09:16 +0000 (13:09 +1000)]
Merge pull request #18659 from totten/master-cssmin
dev/core#1393 - distmaker - Skip new file "vendor/bin/cssmin"
eileen [Thu, 1 Oct 2020 22:57:07 +0000 (11:57 +1300)]
dev/core#2046 Migrate BAO_Address::create towards standardisation
Our standard expectation is that each BAO will have a create action that handles a single entity. For legacy
reasons Address.create has special handling for multiple addresses. This extracts that handling
into a separate function (legacyCreate) and updates the (very few) places currently calling create to
call that.
With this merged apis v3 & v4 can call Address.create - currently v3 is hard coded to call add and
v4 bypasses the BAO altogher. The v4 api bypass means we are not managing is_primay integrity on v4 api calls
eileen [Fri, 2 Oct 2020 01:42:36 +0000 (14:42 +1300)]
dev/core#2017 Deprecate an unused function
eileen [Fri, 2 Oct 2020 01:32:56 +0000 (14:32 +1300)]
dev/core#2046 Fix blockDelete to delete while ensuring is_primary is valid
The del function on each of the location DAO ensures that after a delete at least one phone (etc) is
marked is_primary. This blockDelete does not do that & per the test it's possible to call this
in such a way that no addresses are primary. Whether this actually happens is a bit unknown.
However, this cleans up block delete in a way where we can demonstrate the tests work
Tim Otten [Fri, 2 Oct 2020 00:41:29 +0000 (17:41 -0700)]
dev/core#1393 - distmaker - Skip new file "vendor/bin/cssmin"
Overview
----------------------------------------
This fixes the broken distmaker builds in `master`.
The file `vendor/bin/cssmin` was recently added by way of `composer-compile-lib => cssmin`.
We don't need it in the tarball, and it's a symlink, so trying to include breaks some
consumers (like in https://lab.civicrm.org/dev/core/-/issues/1393).
Technical Details
----------------------------------------
* Before (last release): `vendor/bin/cssmin` does not exist
* Before (current master): `vendor/bin/cssmin` is created as symlink, copied to tarball
* After (this commit): `vendor/bin/cssmin` is created on dev-builds but omitted from tarball
Seamus Lee [Fri, 2 Oct 2020 00:22:12 +0000 (10:22 +1000)]
Merge pull request #18625 from eileenmcnaughton/activi
dev/core#2057 Remove extraneous activity contact queries on activity update
Seamus Lee [Fri, 2 Oct 2020 00:19:41 +0000 (10:19 +1000)]
Merge pull request #18643 from eileenmcnaughton/cache
Fix cache bypass
Eileen McNaughton [Thu, 1 Oct 2020 23:12:07 +0000 (12:12 +1300)]
Merge pull request #18656 from eileenmcnaughton/apiq
dev/core#2079 [REF] Remove reference to second param returned from CRM_Contact_BAO_Query::apiQuery
Seamus Lee [Thu, 1 Oct 2020 22:13:54 +0000 (08:13 +1000)]
Merge pull request #18606 from eileenmcnaughton/create
dev/core#2046 Ensure location BAOs have create actions, deprecate add…
Seamus Lee [Thu, 1 Oct 2020 22:10:55 +0000 (08:10 +1000)]
Merge pull request #18608 from eileenmcnaughton/block
[REF] Follow up cleanup from Event Location
eileen [Thu, 1 Oct 2020 20:17:45 +0000 (09:17 +1300)]
dev/core#2079 do not return never-used, query-wasting variable
The second value from apiQuery is calculated using an extraneous uncached query. This function
is the only function that calls that function AND puts that value into a variable. This change clarfies that
this function does not require thhe variable
eileen [Thu, 1 Oct 2020 05:44:49 +0000 (18:44 +1300)]
[REF] Remove reference to second param returned from CRM_Contact_BAO_Query::apiQuery
Coleman Watts [Tue, 29 Sep 2020 21:53:31 +0000 (17:53 -0400)]
Remove problematic tests
This removes 2 tests that broke with the upgrade to Angular 1.8.
Neither test was covering much of anything useful.
Coleman Watts [Tue, 29 Sep 2020 15:53:30 +0000 (11:53 -0400)]
dev/core#1818 Upgrade AngularJS from 1.5.11 to 1.8
https://lab.civicrm.org/dev/core/-/issues/1818
The biggest breaking change between 1.5 and 1.8 was the default hashPrefix.
See https://github.com/angular/angular.js/blob/master/CHANGELOG.md#location-due-to-1
Our solution is to force crmApp to use the previous default. This ensures that existing modules
which rely on crmApp for routing (which is nearly all of them) will be unaffected.
New modules like Afform which use their own routing should use the new default recommended by Angular.
Eileen McNaughton [Thu, 1 Oct 2020 10:43:49 +0000 (23:43 +1300)]
Merge pull request #18655 from eileenmcnaughton/token2
dev/core#2079 [REF] Fix some more calls to getTokens to make it clear only the first return value is used
Seamus Lee [Thu, 1 Oct 2020 07:30:44 +0000 (17:30 +1000)]
Merge pull request #18652 from eileenmcnaughton/silly
Fix patently silly code
eileen [Mon, 28 Sep 2020 10:06:26 +0000 (23:06 +1300)]
dev/core#2057 Remove extraneous activity contact queries on activity update
This changes it so that instead of doing either
1) if passing in an array of activity contacts for a given type then attempt
to delete existing contacts, regardless of whether they are the same as the
existing ones, create new ones
OR
2) if the param is an int then do a lookup, per record type, and update if needed to
- Do one query to find existing records of types to be deleted (for all 3 record types).
Only delete activity contact records that are not to be kept and
don't alter those records that should be retained
eileen [Thu, 1 Oct 2020 05:39:34 +0000 (18:39 +1300)]
[REF] Fix some more calls to getTokens to make it clear only the first return value is used
eileen [Thu, 1 Oct 2020 05:37:13 +0000 (18:37 +1300)]
[REF] Fix some more calls to getTokens to make it clear only the first return value is used
eileen [Thu, 1 Oct 2020 05:13:07 +0000 (18:13 +1300)]
[Ref] Clarify calls to CRM_Utils_Token::getTokenDetails
This changes the call to getTokenDetails to make it clearer that only the first parameter is used.
The second parameter is an unused query that we should eliminate but getting it
easier to scan is a good first step
eileen [Thu, 1 Oct 2020 03:59:30 +0000 (16:59 +1300)]
Fix patently silly code
eileen [Thu, 1 Oct 2020 03:47:10 +0000 (16:47 +1300)]
Fix complexity on cache key
This seems a likely culprit for https://lab.civicrm.org/dev/core/-/issues/1984
but comments on the gl are inconclusive. Regardless, we can conclude the cacheKey
should not cross-populate values from different users
eileen [Thu, 1 Oct 2020 03:15:35 +0000 (16:15 +1300)]
Fix insufficiently distinct cache key
eileen [Wed, 30 Sep 2020 09:04:43 +0000 (22:04 +1300)]
Fix cache bypass
If the contact is not impacted by any acls then ids will be an empty array. However, currently
an empty array is treated as 'uncached' rather than 'cached by empty' which
would be represented by null
Seamus Lee [Thu, 1 Oct 2020 02:56:54 +0000 (12:56 +1000)]
Merge pull request #18640 from eileenmcnaughton/syn
dev/core#2073 Improve cleanup on syntax conformance test
Eileen McNaughton [Thu, 1 Oct 2020 02:54:27 +0000 (15:54 +1300)]
Merge pull request #18416 from seamuslee001/dev_core_2003
dev/core#2003 Use Brick/Money to ensure that we display all possible …
Seamus Lee [Thu, 1 Oct 2020 02:14:20 +0000 (12:14 +1000)]
Merge pull request #18646 from totten/master-complib
(REF) Switch to composer-compile-lib
eileen [Wed, 30 Sep 2020 05:09:05 +0000 (18:09 +1300)]
dev/core#2073 Improve cleanup on syntaxconformance test
Cleaning up all objects seems a bit too much - but ensuring we
re-set the DAO we create in this class should be a memory-friendly action
https://github.com/civicrm/civicrm-core/pull/18639
demeritcowboy [Wed, 30 Sep 2020 23:44:48 +0000 (19:44 -0400)]
fix missing mail setting help
Tim Otten [Wed, 30 Sep 2020 22:42:29 +0000 (15:42 -0700)]
Greenwich - Switch to composer-compile-lib
Seamus Lee [Wed, 30 Sep 2020 23:18:33 +0000 (09:18 +1000)]
[REF] Add in css classes to make the save and preview button on the Contribution Page widget settings form look consistant with the other buttons on the page
Seamus Lee [Wed, 30 Sep 2020 23:11:05 +0000 (09:11 +1000)]
Merge pull request #18607 from eileenmcnaughton/website
dev/core#2046 Rationalise add vs create on website BAO
Seamus Lee [Wed, 30 Sep 2020 22:38:31 +0000 (08:38 +1000)]
Merge pull request #18642 from seamuslee001/dev_core_339_custom_field
dev/core#334 Use the current in use collation and character sets when…
Tim Otten [Wed, 30 Sep 2020 21:36:44 +0000 (14:36 -0700)]
composer.json - Switch to composer-compile-lib. Add more helpers.
The overall effect of this change is to get access to a few more helpers.
Before: Load `composer-compile-plugin`, `scssphp`, and `php-autoprefxer` as
three distinct packages.
After: Load `composer-compile-lib`, which transitively requires all those others
*and* includes some helpers.
Sea also
* https://github.com/civicrm/composer-compile-plugin
* https://github.com/civicrm/composer-compile-lib
Seamus Lee [Wed, 9 Sep 2020 05:54:50 +0000 (15:54 +1000)]
dev/core#2003 Use Brick/Money to ensure that we display all possible digits stored in the database for the option amount
Add in noisy notice about fall back due to missing intl extension
Seamus Lee [Wed, 30 Sep 2020 21:10:47 +0000 (07:10 +1000)]
Merge pull request #18621 from eileenmcnaughton/prefix
dev/membership#27 Update outdated membership statuses in preProcess rather than submit
Seamus Lee [Wed, 30 Sep 2020 21:05:36 +0000 (07:05 +1000)]
Merge pull request #18632 from eileenmcnaughton/leak
dev/core#2073 Memory drain
Seamus Lee [Wed, 30 Sep 2020 08:19:58 +0000 (18:19 +1000)]
dev/core#334 Use the current in use collation and character sets when creating new custom value tables
Seamus Lee [Wed, 30 Sep 2020 20:32:06 +0000 (06:32 +1000)]
Merge pull request #18599 from seamuslee001/frontend_group_fields
[REF] Add in frontend fields for title and description of group Schem…
Seamus Lee [Fri, 25 Sep 2020 21:05:06 +0000 (07:05 +1000)]
[REF] Add in frontend fields for title and description of group Schema only change
Add in upgrade step to expand title column to be 255 as well
Update langauge as per Artfulrobot and require group title field
Seamus Lee [Wed, 30 Sep 2020 08:22:01 +0000 (18:22 +1000)]
Merge pull request #18641 from eileenmcnaughton/will-the-real-slim-leaky-please-stand-up
dev/core#2073 Fix a real live leak
eileen [Wed, 30 Sep 2020 05:44:19 +0000 (18:44 +1300)]
dev/core#2073 Fix a real live leak
I used the same methods I had been playing with on the test class on a contribution
import script and found that the object that was increasing in memory in tandem with
me increasing iterations was an instance of DB_result
I tracked it down to here. In essence our main DAO functions clean up after themselves - e.g
when the DAO is destructed it cleans up the globals it has created.
However, this older ->query() function does not do that and each time is is called increases it's memory hold.
It's also worth better caching in this function...
Seamus Lee [Wed, 30 Sep 2020 05:37:36 +0000 (15:37 +1000)]
Merge pull request #18638 from eileenmcnaughton/test_perf
[Civi\Test] Fix test output noise
Eileen McNaughton [Wed, 30 Sep 2020 01:29:25 +0000 (14:29 +1300)]
Merge pull request #18637 from demeritcowboy/no-details
dev/core#2075 - E_NOTICE viewing an activity that has no details contents
eileen [Wed, 30 Sep 2020 00:27:20 +0000 (13:27 +1300)]
[Civi\Test] Fix test output noise
Seeing this is test logs
Warning: Invalid argument supplied for foreach() in /home/jenkins/bknix-dfl/build/core-18634-8zcf7/web/sites/all/modules/civicrm/Civi/Test/Schema.php on line 29
Call Stack:
0.0007 530944 1. {main}() /home/jenkins/bknix-dfl/extern/phpunit7/phpunit7.phar:0
0.0498
9999808 2. PHPUnit\TextUI\Command::main() /home/jenkins/bknix-dfl/extern/phpunit7/phpunit7.phar:615
0.0498
10008600 3. PHPUnit\TextUI\Command->run() phar:///home/jenkins/bknix-dfl/extern/phpunit7/phpunit7.phar/phpunit/TextUI/Command.php:162
1.1684
104654872 4. PHPUnit\TextUI\TestRunner->doRun() phar:///home/jenkins/bknix-dfl/extern/phpunit7/phpunit7.phar/phpunit/TextUI/Command.php:206
1.2327
104791840 5. PHPUnit\Framework\TestSuite->run() phar:///home/jenkins/bknix-dfl/extern/phpunit7/phpunit7.phar/phpunit/TextUI/TestRunner.php:652
3300.8182
675188928 6. PHPUnit\Framework\TestSuite->run() phar:///home/jenkins/bknix-dfl/extern/phpunit7/phpunit7.phar/phpunit/Framework/TestSuite.php:746
3300.8199
675188928 7. CiviUnitTestCase::setUpBeforeClass() phar:///home/jenkins/bknix-dfl/extern/phpunit7/phpunit7.phar/phpunit/Framework/TestSuite.php:703
3300.8199
675188928 8. CiviUnitTestCase::_populateDB() /home/jenkins/bknix-dfl/build/core-18634-8zcf7/web/sites/all/modules/civicrm/tests/phpunit/CiviTest/CiviUnitTestCase.php:311
3300.8199
675188928 9. Civi\Test\Data->populate() /home/jenkins/bknix-dfl/build/core-18634-8zcf7/web/sites/all/modules/civicrm/tests/phpunit/CiviTest/CiviUnitTestCase.php:305
3300.8199
675189248 10. Civi\Test::asPreInstall() /home/jenkins/bknix-dfl/build/core-18634-8zcf7/web/sites/all/modules/civicrm/Civi/Test/Data.php:45
:
demeritcowboy [Tue, 29 Sep 2020 23:29:50 +0000 (19:29 -0400)]
handle missing details
demeritcowboy [Tue, 29 Sep 2020 23:03:39 +0000 (19:03 -0400)]
test activity contacts as scalars
Eileen McNaughton [Tue, 29 Sep 2020 20:01:30 +0000 (09:01 +1300)]
Merge pull request #18596 from MegaphoneJon/core-2063
core#2063: Don't throw a warning when public ext directory isn't found
Eileen McNaughton [Tue, 29 Sep 2020 19:17:19 +0000 (08:17 +1300)]
Merge pull request #18564 from seamuslee001/dev_core_1838
dev/core#1838 Ensure that no fatal error is triggered if you try to a…
Eileen McNaughton [Tue, 29 Sep 2020 19:01:33 +0000 (08:01 +1300)]
Merge pull request #18544 from magnolia61/participant_status_notification_default
Set participant status notification to false by default
Seamus Lee [Tue, 22 Sep 2020 22:50:03 +0000 (08:50 +1000)]
dev/core#1838 Ensure that no fatal error is triggered if you try to access a merged contact and the contact that it was merged into has been permanently deleted
Move exception capturing into the page layer and extend unit test to cover page function
Update status message as per Mikeý's comment
Seamus Lee [Tue, 29 Sep 2020 06:21:36 +0000 (16:21 +1000)]
Merge pull request #18633 from eileenmcnaughton/leak2
dev/core#2073 just tweak a memory leak
eileen [Tue, 29 Sep 2020 03:33:31 +0000 (16:33 +1300)]
dev/core#2073 Memory leak fix
eileen [Tue, 29 Sep 2020 04:03:48 +0000 (17:03 +1300)]
dev/core#2073 just tweak a memory leak
This one is like https://github.com/civicrm/civicrm-core/pull/18632 but only
seems to have switched us from an xml leakage to a string leakage - it still
seems slightly better from a code quality point of view
Seamus Lee [Tue, 29 Sep 2020 00:52:01 +0000 (10:52 +1000)]
Merge pull request #18630 from eileenmcnaughton/pps
[REF] Parse ids before sending to single function (minor simplification)
Seamus Lee [Tue, 29 Sep 2020 00:44:25 +0000 (10:44 +1000)]
Merge pull request #18619 from demeritcowboy/contact-test
[NFC/Test] Unit test activity-contact variations
Eileen McNaughton [Mon, 28 Sep 2020 23:55:33 +0000 (12:55 +1300)]
Merge pull request #18570 from mlutfy/pcpLinksHook
dev/core#2061 PCP: call the hook_civicrm_links hook for PCP page user actions
Eileen McNaughton [Mon, 28 Sep 2020 22:40:14 +0000 (11:40 +1300)]
Merge pull request #18626 from demeritcowboy/why-no-id
[Test framework] Wrong group id in mailing test setup
Eileen McNaughton [Mon, 28 Sep 2020 22:39:46 +0000 (11:39 +1300)]
Merge pull request #18627 from civicrm/5.30
5.30
Seamus Lee [Mon, 28 Sep 2020 22:39:02 +0000 (08:39 +1000)]
Merge pull request #18628 from seamuslee001/dev_core_2035
dev/core#2035 Add in upgrade step to fix the template copy on current…
eileen [Mon, 28 Sep 2020 21:14:59 +0000 (10:14 +1300)]
[REF] Parse ids before sending to single function (minor simplification)
Overview
----------------------------------------
Minor simplification - parse ids into valid format & pass them into single, rather than passing them in wrong & 'asking' singleto parse them
Before
----------------------------------------
parsing of ids into usable array done at the last minute, other values passes around unnecessarily
After
----------------------------------------
parsing done close to the point where they are derived
Technical Details
----------------------------------------
Comments
----------------------------------------
Eileen McNaughton [Mon, 28 Sep 2020 20:42:10 +0000 (09:42 +1300)]
Merge pull request #18613 from mattwire/moveloadrelatedobjects
Simplify call to loadRelatedObjects in repeat/completetransaction
Seamus Lee [Mon, 28 Sep 2020 20:15:09 +0000 (06:15 +1000)]
dev/core#2035 Add in upgrade step to fix the template copy on current installs
Seamus Lee [Mon, 28 Sep 2020 20:11:24 +0000 (06:11 +1000)]
Merge pull request #18602 from eileenmcnaughton/msg
dev/core#2035 Invoice template - show Amount paid even when it is fully paid
Mathieu Lutfy [Wed, 23 Sep 2020 20:07:39 +0000 (16:07 -0400)]
dev/core#2061 PCP: call the hook_civicrm_links hook for PCP page user actions
demeritcowboy [Mon, 28 Sep 2020 19:25:53 +0000 (15:25 -0400)]
missing id
Seamus Lee [Mon, 28 Sep 2020 10:50:11 +0000 (20:50 +1000)]
Merge pull request #18559 from agileware/CIVICRM-1567
Update the post-upgrade thank you message to include URLs to CiviCRM contributors, CiviCRM members and minor rewrite
Matthew Wire [Sat, 26 Sep 2020 18:40:26 +0000 (19:40 +0100)]
Simplify call to loadRelationObjects in repeat/completetransaction
Matthew Wire [Mon, 28 Sep 2020 10:30:52 +0000 (11:30 +0100)]
Merge pull request #18590 from eileenmcnaughton/taskname
[REF] Remove unused taskName variable
Matthew Wire [Mon, 28 Sep 2020 10:29:24 +0000 (11:29 +0100)]
Merge pull request #18600 from eileenmcnaughton/aipn
[REF] IPN - move unshared chunk of code out of shared function
Matthew Wire [Mon, 28 Sep 2020 10:28:51 +0000 (11:28 +0100)]
Merge pull request #18536 from eileenmcnaughton/main
[REF] Paypal std ipn Move not-actually shared-code out of shared code function
Matthew Wire [Mon, 28 Sep 2020 10:28:18 +0000 (11:28 +0100)]
Merge pull request #18614 from eileenmcnaughton/mem
[REF] Remove some unused params, move one to where it is used
eileen [Sun, 27 Sep 2020 00:32:49 +0000 (13:32 +1300)]
[REF] Remove some unused params, move one to where it is used
Matthew Wire [Mon, 28 Sep 2020 08:29:44 +0000 (09:29 +0100)]
Merge pull request #18617 from eileenmcnaughton/ord
[Ref] Extract getOrderParams
Eileen McNaughton [Mon, 28 Sep 2020 01:29:33 +0000 (14:29 +1300)]
Merge pull request #18620 from eileenmcnaughton/notice
Enotice fix
Eileen McNaughton [Mon, 28 Sep 2020 00:54:29 +0000 (13:54 +1300)]
Merge pull request #18622 from civicrm/5.30
5.30