Seamus Lee [Thu, 25 Nov 2021 23:32:40 +0000 (10:32 +1100)]
Merge pull request #22134 from eileenmcnaughton/url
Ensure CMSPrint variables are assigned to the template
Seamus Lee [Thu, 25 Nov 2021 23:32:22 +0000 (10:32 +1100)]
Merge pull request #22135 from eileenmcnaughton/pay_test
Ensure tab headers are assigned, fix widget form test
Seamus Lee [Thu, 25 Nov 2021 23:31:26 +0000 (10:31 +1100)]
Merge pull request #22136 from mlutfy/fixEventPrepositionTs
CRM/Event/BAO/Event: Fix ts usage on selfservice_preposition
Mathieu Lutfy [Thu, 25 Nov 2021 21:13:44 +0000 (16:13 -0500)]
CRM/Event/BAO/Event: Fix ts usage on selfservice_preposition
Eileen McNaughton [Thu, 25 Nov 2021 08:01:47 +0000 (21:01 +1300)]
Ensure tab headers are assigned, fix widget form test
This could regress notices elsewhere but I given the difficulty of getting a combo
of fixes that pass tests I think we should only worry if there are actual test fails
since most people won't see smarty notices anyway
Eileen McNaughton [Thu, 25 Nov 2021 07:41:45 +0000 (20:41 +1300)]
Ensure CMSPrint variables are assigned to the template
Seamus Lee [Wed, 24 Nov 2021 22:19:40 +0000 (09:19 +1100)]
Merge pull request #22128 from eileenmcnaughton/cus
Ensure buildForm is called to assign values
Seamus Lee [Wed, 24 Nov 2021 21:10:27 +0000 (08:10 +1100)]
Merge pull request #22131 from civicrm/5.44
5.44
colemanw [Wed, 24 Nov 2021 19:30:00 +0000 (14:30 -0500)]
Merge pull request #22130 from colemanw/fixSearchKitHaving
SearchKit - Fix selecting HAVING operator
colemanw [Wed, 24 Nov 2021 17:47:27 +0000 (12:47 -0500)]
Merge pull request #22129 from kurund/patch-4
Update Fields.tpl
Coleman Watts [Wed, 24 Nov 2021 16:59:22 +0000 (11:59 -0500)]
SearchKit - Fix selecting HAVING operator
Fixes dev/core#2954 by gracefully handling field values when no field exists
Kurund Jalmi [Wed, 24 Nov 2021 16:00:14 +0000 (16:00 +0000)]
Update Fields.tpl
Yashodha Chaku [Wed, 24 Nov 2021 15:56:21 +0000 (21:26 +0530)]
Merge pull request #22122 from agileware/CIVICRM-1894
CiviCRM Event, remove the superfluous "Are you sure you want to delete this Event?" confirmation for the Event delete action
Eileen McNaughton [Wed, 24 Nov 2021 06:31:04 +0000 (19:31 +1300)]
Ensure buildForm is called to assign values
Seamus Lee [Wed, 24 Nov 2021 06:00:09 +0000 (17:00 +1100)]
Merge pull request #22126 from colemanw/deleteAfformHtmlExt
Update Afform & search kit info
colemanw [Wed, 24 Nov 2021 05:06:27 +0000 (00:06 -0500)]
Merge pull request #22007 from joapta/feature/add-missing-colombia-state
Add Colombia missing state
colemanw [Wed, 24 Nov 2021 05:05:35 +0000 (00:05 -0500)]
Merge pull request #22123 from eileenmcnaughton/act
Test fix - use more 'real' rendering function
colemanw [Wed, 24 Nov 2021 05:02:22 +0000 (00:02 -0500)]
Merge pull request #22116 from jensschuppe/virtualEntities/getEntityNameForTable
Use getEntityNameForTable() instead of getClassForTable(), as this might yield ambiguous results
Seamus Lee [Wed, 24 Nov 2021 03:35:00 +0000 (14:35 +1100)]
Merge pull request #21589 from agileware/CIVICRM-1804
Suppresses error logging on every page load when open_basedir restriction in effect: File(/CRM/Core/Smarty/plugins/) is not within the allowed path(s)
Coleman Watts [Wed, 24 Nov 2021 03:20:38 +0000 (22:20 -0500)]
Update afform & search kit info
jptaszynska [Mon, 8 Nov 2021 10:14:02 +0000 (11:14 +0100)]
Add Colombia missing state
colemanw [Wed, 24 Nov 2021 02:36:27 +0000 (21:36 -0500)]
Merge pull request #22087 from agileware/CIVICRM-1887
SearchKit with Form Builder when viewed on the front-end displays a CiviCRM breadcrumb trail which can duplicate the existing website breadcrumb trail
Coleman Watts [Wed, 24 Nov 2021 02:25:58 +0000 (21:25 -0500)]
AllCoreTables - Fix getClassForTable in multilingual databases
Eileen McNaughton [Wed, 24 Nov 2021 01:28:53 +0000 (14:28 +1300)]
Test fix - use more 'real' rendering function
Justin Freeman [Wed, 24 Nov 2021 01:20:25 +0000 (12:20 +1100)]
CIVICRM-1894 CiviCRM Event, remove the superfluous "Are you sure you want to delete this Event?" confirmation for the Event delete action
Eileen McNaughton [Wed, 24 Nov 2021 01:10:44 +0000 (14:10 +1300)]
Merge pull request #22119 from eileenmcnaughton/frontpage
Bypass any default escaping for blog, getting started
Eileen McNaughton [Wed, 24 Nov 2021 01:09:46 +0000 (14:09 +1300)]
Merge pull request #22120 from eileenmcnaughton/address
Do not use default escaping on address display
Justin Freeman [Fri, 24 Sep 2021 04:12:36 +0000 (14:12 +1000)]
CIVICRM-1804 Suppresses error logging on every page load when open_basedir restriction in effect: File(/CRM/Core/Smarty/plugins/) is not within the allowed path(s)
Eileen McNaughton [Tue, 23 Nov 2021 22:53:21 +0000 (11:53 +1300)]
Do not use default escaping on address display
This has vcard html in it and so breaks if default escaping is enabled
Eileen McNaughton [Tue, 23 Nov 2021 22:34:10 +0000 (11:34 +1300)]
Bypass any default escaping for blog, getting started
This specifies that default escaping should not apply to the blog, getting started.
I added purify to the data coming from the blog - this is our blog so should be
safe but it is techically 3rd part data
demeritcowboy [Tue, 23 Nov 2021 22:32:33 +0000 (17:32 -0500)]
Merge pull request #22079 from eileenmcnaughton/options
Remove issets from Options.tpl
colemanw [Tue, 23 Nov 2021 20:56:01 +0000 (15:56 -0500)]
Merge pull request #22070 from eileenmcnaughton/test_id
Throw spaghetti
demeritcowboy [Tue, 23 Nov 2021 15:02:16 +0000 (10:02 -0500)]
Merge pull request #21944 from masetto/unit_plural
fix unit plural in contribution page
Jens Schuppe [Tue, 23 Nov 2021 12:12:16 +0000 (13:12 +0100)]
Use getEntityNameForTable() instead of getClassForTable(), as this might yield ambiguous results
Samuele Masetto [Sat, 30 Oct 2021 17:14:53 +0000 (19:14 +0200)]
fix unit plural in contribution page
style fixes for compiling check
fix a typo
fix `recur_frequency_unit` hidden field value when there is only one unit option
Eileen McNaughton [Mon, 22 Nov 2021 19:59:37 +0000 (08:59 +1300)]
Merge pull request #22112 from Detsieber/master
Update PayPalImpl.php - action on style test failure
Eileen McNaughton [Mon, 22 Nov 2021 06:08:33 +0000 (19:08 +1300)]
Remove a bunch of isset from options.tpl
demeritcowboy [Mon, 22 Nov 2021 19:14:20 +0000 (14:14 -0500)]
Merge pull request #22111 from eileenmcnaughton/opt
Remove a bunch of isset from options.tpl
demeritcowboy [Mon, 22 Nov 2021 19:05:56 +0000 (14:05 -0500)]
Merge pull request #22110 from agileware/CIVICRM-1889
CiviCRM Message Template, HTML Format and Text Format fields are listed in a different order on the Default Message Template
demeritcowboy [Mon, 22 Nov 2021 18:53:37 +0000 (13:53 -0500)]
Merge pull request #22113 from mattwire/eventtitle
Remove broken dynamic title from event template
Matthew Wire [Mon, 22 Nov 2021 12:14:12 +0000 (12:14 +0000)]
Remove broken dynamic title from event template
Detlev Sieber [Mon, 22 Nov 2021 07:07:48 +0000 (08:07 +0100)]
Update PayPalImpl.php
Eileen McNaughton [Mon, 22 Nov 2021 06:08:33 +0000 (19:08 +1300)]
Remove a bunch of isset from options.tpl
Eileen McNaughton [Mon, 15 Nov 2021 01:50:33 +0000 (14:50 +1300)]
Enotice fix
colemanw [Mon, 22 Nov 2021 02:26:57 +0000 (21:26 -0500)]
Merge pull request #22109 from civicrm/5.44
5.44
Justin Freeman [Mon, 22 Nov 2021 00:17:45 +0000 (11:17 +1100)]
CIVICRM-1889 CiviCRM Message Template, HTML Format and Text Format fields are listed in a different order and make it harder to directly compare and copy/paste changes from a Default Message Template to a Message Template
Seamus Lee [Mon, 22 Nov 2021 00:07:26 +0000 (11:07 +1100)]
Merge pull request #22090 from colemanw/apiGetEntityName
APIv4 - Fix checkAccess for CiviCase or other entities with nonstandard class names
Seamus Lee [Sun, 21 Nov 2021 23:00:23 +0000 (10:00 +1100)]
Merge pull request #22108 from colemanw/searchDisplayFix
SearchKit - Fix default displays in Afforms and multiple displays per page
Seamus Lee [Sun, 21 Nov 2021 22:58:55 +0000 (09:58 +1100)]
Merge pull request #22106 from braders/translatable-download-chart-text
Allow "Download chart" text to be translated.
Coleman Watts [Sun, 21 Nov 2021 17:34:29 +0000 (12:34 -0500)]
SearchKit - fix multiple displays on the same page
Coleman Watts [Sun, 21 Nov 2021 17:33:06 +0000 (12:33 -0500)]
SearchKit - fix rendering default display embedded in an afform
Bradley Taylor [Sun, 21 Nov 2021 12:16:10 +0000 (12:16 +0000)]
Allow "Download chart" text to be translated.
This affects the charts on the dashboard, and contribution dashboard.
Detlev Sieber [Sat, 20 Nov 2021 14:00:49 +0000 (15:00 +0100)]
Merge pull request #1 from Detsieber/Detsieber-lab.civicrm.org/dev/core/-/issues/1215
https://lab.civicrm.org/dev/core/-/issues/1215
Detlev Sieber [Sat, 20 Nov 2021 13:52:45 +0000 (14:52 +0100)]
Update PayPalImpl.php
Repair support for PayPal Express by linking to PayPal Pro
Eileen McNaughton [Sat, 13 Nov 2021 03:11:30 +0000 (16:11 +1300)]
Throw spaghetti
Seamus Lee [Sat, 20 Nov 2021 01:38:51 +0000 (12:38 +1100)]
Merge pull request #22104 from civicrm/5.44
5.44
Seamus Lee [Fri, 19 Nov 2021 23:53:24 +0000 (10:53 +1100)]
Merge pull request #22103 from agh1/5.44.0-releasenotes-initial
5.44.0 release notes initial run
Seamus Lee [Fri, 19 Nov 2021 23:53:15 +0000 (10:53 +1100)]
Merge pull request #22102 from eileenmcnaughton/vis
Remove obsolete showVisibility
Andie Hunt [Fri, 19 Nov 2021 22:26:49 +0000 (17:26 -0500)]
5.44.0 release notes: added boilerplate
Eileen McNaughton [Fri, 19 Nov 2021 21:45:28 +0000 (10:45 +1300)]
Remove obsolete showVisibility
Per https://github.com/civicrm/civicrm-core/pull/22079#issuecomment-
974267801
Andie Hunt [Fri, 19 Nov 2021 21:27:59 +0000 (16:27 -0500)]
5.44.0 release notes: raw from script
Seamus Lee [Fri, 19 Nov 2021 06:34:25 +0000 (17:34 +1100)]
Merge pull request #22009 from colemanw/afformSubmissionTable
Afform - Add table of submission results
Seamus Lee [Fri, 19 Nov 2021 06:33:32 +0000 (17:33 +1100)]
Merge pull request #21908 from eileenmcnaughton/statuses
[REF] Remove support for not-passed 'pledge' value
Seamus Lee [Fri, 19 Nov 2021 01:24:59 +0000 (12:24 +1100)]
Merge pull request #22035 from eileenmcnaughton/campaign
Escape-on-output: Cleanup addCampaignToSearch, remove isset
Seamus Lee [Fri, 19 Nov 2021 00:26:27 +0000 (11:26 +1100)]
Merge pull request #22099 from civicrm/5.44
5.44
colemanw [Thu, 18 Nov 2021 22:21:16 +0000 (17:21 -0500)]
Merge pull request #22084 from eileenmcnaughton/search
Remove smarty isset in favour of always set
Seamus Lee [Thu, 18 Nov 2021 22:15:19 +0000 (09:15 +1100)]
Merge pull request #22092 from seamuslee001/ckeditor_upgrade_4_17
[REF] Upgrade CKEditor to 4.17
Eileen McNaughton [Thu, 18 Nov 2021 21:28:51 +0000 (10:28 +1300)]
Merge pull request #22094 from civicrm/5.44
5.44
Eileen McNaughton [Thu, 18 Nov 2021 21:28:22 +0000 (10:28 +1300)]
Merge pull request #22098 from twomice/2959_fix_pdf_default_format
Fix dev/core#2959: some PDFs hard-code format to "a3 landscape", overriding default PDF format
demeritcowboy [Thu, 18 Nov 2021 19:49:34 +0000 (14:49 -0500)]
Merge pull request #22095 from colemanw/fixDomainOptionGroup
OptionValue - Fix checking if domain is set
Eileen McNaughton [Thu, 18 Nov 2021 19:27:35 +0000 (08:27 +1300)]
Merge pull request #22097 from mlutfy/fixStrings2021
Fix two English strings
Allen Shaw [Thu, 18 Nov 2021 18:10:33 +0000 (12:10 -0600)]
Fix dev/core#2959: some PDFs hard-code format to "a3 landscape", overriding default PDF format
Mathieu Lutfy [Thu, 18 Nov 2021 16:26:28 +0000 (11:26 -0500)]
Fix two English strings
Coleman Watts [Thu, 18 Nov 2021 02:56:24 +0000 (21:56 -0500)]
OptionValue - Fix checking if domain is set
Fixes a bug introduced in #19970
Seamus Lee [Thu, 18 Nov 2021 02:43:05 +0000 (13:43 +1100)]
Merge pull request #22093 from totten/5.44-civix-test
EventChecker - Fix recent regression
Tim Otten [Thu, 18 Nov 2021 00:20:55 +0000 (16:20 -0800)]
EventChecker - Fix recent regression
Overview
--------
v5.43 introduced `Civi/Test/EventChecker.php` as part of the execution of all unit-tests.
`civix` generates unit-tests from various templates. As part of the `civix` update-testing, it makes sundry tests with sundry phpunit.
Before
------
In 5.43.0, when running `civix`'s` `tests/make-example.sh`, it fails on one of the tests when using an older version of phpunit.
After
-----
When running `civix`'s` `tests/make-example.sh`, it passes with all tests.
Comment
-------
The type-hint is too strong -- the actual type-name depends on the version of phpunit. It is, of course, good
to have type-hints, and this preserves the softer `@param` hint.
Eileen McNaughton [Mon, 15 Nov 2021 20:33:56 +0000 (09:33 +1300)]
Remove smarty isset in favour of always set
Seamus Lee [Wed, 17 Nov 2021 22:31:41 +0000 (09:31 +1100)]
[REF] Upgrade CKEditor to 4.17.1
Eileen McNaughton [Wed, 17 Nov 2021 22:17:26 +0000 (11:17 +1300)]
Merge pull request #22091 from demeritcowboy/translate-js
Contribution amounts configuration page is borked when translation contains apostrophe
demeritcowboy [Wed, 17 Nov 2021 22:09:59 +0000 (17:09 -0500)]
Merge pull request #22089 from colemanw/nullOptionDefaultFix
OptionValue - Fix incorrect update of `is_default`
Coleman Watts [Wed, 17 Nov 2021 02:15:42 +0000 (21:15 -0500)]
OptionValue - Fix incorrect update of `is_default`
Checking `!empty($params['is_default'])` gave a false-positive for the string 'null'.
demeritcowboy [Wed, 17 Nov 2021 19:23:53 +0000 (14:23 -0500)]
fix when translation contains apostrophe
Coleman Watts [Wed, 17 Nov 2021 15:55:30 +0000 (10:55 -0500)]
APIv4 - Fix checkAccess for CiviCase or other entities with nonstandard class names
Fixes dev/core#2950
demeritcowboy [Wed, 17 Nov 2021 13:35:09 +0000 (08:35 -0500)]
Merge pull request #21992 from colemanw/searchKitImageAndDefault
SearchKit - Add default text/image to displays; support custom file fields
demeritcowboy [Wed, 17 Nov 2021 13:34:24 +0000 (08:34 -0500)]
Merge pull request #21966 from mattwire/eventnopricesetcurrency
Fix missing currency for event registration when configured via "quick config"
Matthew Wire [Wed, 17 Nov 2021 09:44:27 +0000 (09:44 +0000)]
Merge pull request #21854 from braders/feature/dev-core-2919-make-hidden-modal-buttons-non-focussable
dev/core#2919 Hidden submit buttons are confussing for keyboard users
Eileen McNaughton [Tue, 16 Nov 2021 21:09:00 +0000 (10:09 +1300)]
Merge pull request #22088 from demeritcowboy/website-default
dev/core#2894 - Crash when viewing a contact with a website
demeritcowboy [Tue, 16 Nov 2021 18:06:16 +0000 (13:06 -0500)]
fix website default
demeritcowboy [Tue, 16 Nov 2021 12:46:05 +0000 (07:46 -0500)]
Merge pull request #22082 from eileenmcnaughton/validate
Use smarty:nodefaults with smarty.get
Justin Freeman [Tue, 16 Nov 2021 02:16:42 +0000 (13:16 +1100)]
CIVICRM-1887 SearchKit with Form Builder, when viewed on the front-end displays a CiviCRM breadcrumb trail which can duplicate the existing website breadcrumb trail. Do not display breadcrumb on front-end pages
demeritcowboy [Tue, 16 Nov 2021 00:57:03 +0000 (19:57 -0500)]
Merge pull request #22080 from seamuslee001/dev_drupal_169
[REF] dev/drupal#169 Replace other usages of session_id with CRM_Coreā¦
Seamus Lee [Tue, 16 Nov 2021 00:56:47 +0000 (11:56 +1100)]
Merge pull request #22086 from civicrm/5.44
5.44
Seamus Lee [Mon, 15 Nov 2021 23:16:18 +0000 (10:16 +1100)]
Merge pull request #22085 from seamuslee001/5.44
Add in 5.43.1 and 5.43.2 Release Notes
Tim Otten [Mon, 15 Nov 2021 20:27:23 +0000 (12:27 -0800)]
Add release-notes/5.43.2.md
Tim Otten [Fri, 12 Nov 2021 20:18:25 +0000 (12:18 -0800)]
release-notes/5.43.1.md - Add recent patch
Tim Otten [Fri, 12 Nov 2021 04:59:35 +0000 (20:59 -0800)]
Add release-notes/5.43.1.md
Eileen McNaughton [Mon, 15 Nov 2021 20:17:23 +0000 (09:17 +1300)]
Use smarty:nodefaults with smarty.get
smarty.get is a special smary function to access _GET and I think the nodefaults is the only option
(ie we can't ensure it is set)
demeritcowboy [Mon, 15 Nov 2021 13:35:14 +0000 (08:35 -0500)]
Merge pull request #22032 from agileware/CIVICRM-1885
CiviCRM Membership Status can never be deleted when logging is enabled
demeritcowboy [Mon, 15 Nov 2021 13:34:48 +0000 (08:34 -0500)]
Merge pull request #22022 from jaapjansma/issue2948
Fix for dev/core#2948
demeritcowboy [Mon, 15 Nov 2021 13:32:35 +0000 (08:32 -0500)]
Merge pull request #22076 from eileenmcnaughton/master_a
Ensure masterAddress is always assigned