Seamus Lee [Fri, 28 Feb 2020 21:47:22 +0000 (08:47 +1100)]
[REF] Add in pre and post hooks to UFField Entity
colemanw [Fri, 28 Feb 2020 14:58:31 +0000 (09:58 -0500)]
Merge pull request #16632 from colemanw/dash
News dashboard - Code cleanup to update js & css
colemanw [Fri, 28 Feb 2020 14:51:38 +0000 (09:51 -0500)]
Merge pull request #16645 from colemanw/null
APIv4 - Correctly return null values from DAO save actions
Coleman Watts [Fri, 28 Feb 2020 00:45:22 +0000 (19:45 -0500)]
APIv4 - Correctly return null values from DAO save actions
Make sure the value "null" is not returned as a string
Don't return null values from saved DAO objects unless it is in params or reload is set to true
Seamus Lee [Thu, 27 Feb 2020 23:34:40 +0000 (10:34 +1100)]
Merge pull request #16615 from MegaphoneJon/selfsfc-refactor
[REF] Extract self-service eligibility code into its own function
Eileen McNaughton [Thu, 27 Feb 2020 22:41:49 +0000 (11:41 +1300)]
Merge pull request #16627 from seamuslee001/aug_custom_fields_fix
[REF] Apply fix for CRM-607 for when building the select section of t…
colemanw [Thu, 27 Feb 2020 22:34:05 +0000 (17:34 -0500)]
Merge pull request #16638 from UshaMakoa/patch-1
Contact Type Values with Cap in order to be well translated with ts()
colemanw [Thu, 27 Feb 2020 22:33:47 +0000 (17:33 -0500)]
Merge pull request #16643 from demeritcowboy/activity-summary-groupby
dev/core#1619 - Fatal error when grouping Activity Summary report by activity date
colemanw [Thu, 27 Feb 2020 22:33:26 +0000 (17:33 -0500)]
Merge pull request #16642 from eileenmcnaughton/ss2
[REF] simple function extraction
Eileen McNaughton [Thu, 27 Feb 2020 21:53:32 +0000 (10:53 +1300)]
Merge pull request #16595 from seamuslee001/refactor_payment_processor_radio
[REF] Refactor adding payment processor radio section onto register a…
Eileen McNaughton [Thu, 27 Feb 2020 21:46:54 +0000 (10:46 +1300)]
Merge pull request #16637 from eileenmcnaughton/ss
Remove unused columns from civicrm_saved_search
Eileen McNaughton [Thu, 27 Feb 2020 21:10:12 +0000 (10:10 +1300)]
Merge pull request #16639 from seamuslee001/dev_core_1621
[NFC] dev/core#1621 Extend unit tests to ensure that entity financial account is co…
Eileen McNaughton [Thu, 27 Feb 2020 21:09:01 +0000 (10:09 +1300)]
Merge pull request #16640 from JMAConsulting/dev-core-1158
core#1158: Unit Test to ensure primary addresses are printed on mailing label if searchPrimaryDetailsOnly is disabled
Eileen McNaughton [Thu, 27 Feb 2020 21:05:48 +0000 (10:05 +1300)]
Merge pull request #16641 from colemanw/apiError
Api4 - Display sql errors in explorer
eileen [Thu, 27 Feb 2020 20:49:18 +0000 (09:49 +1300)]
[REF] simple funnction extraction
Jon Goldberg [Fri, 21 Feb 2020 23:17:23 +0000 (18:17 -0500)]
[REF] Extract self-service eligibility code into its own function
demeritcowboy [Thu, 27 Feb 2020 20:50:27 +0000 (15:50 -0500)]
fatal error when grouping by activity date
eileen [Thu, 27 Feb 2020 01:51:13 +0000 (14:51 +1300)]
Remove unused columns from civicrm_saved_search
We identified these as unused in 5.20 & removed the places still saving to them -
https://github.com/civicrm/civicrm-core/pull/14891
This removes the actual columns. A couple of other tables still have similar columns, not sure
if they are required still
Eileen McNaughton [Thu, 27 Feb 2020 20:21:10 +0000 (09:21 +1300)]
Merge pull request #16634 from seamuslee001/lab_core_1612
dev/core#1622 Fix unsubscribe when loading the unsubscribe form on a …
Coleman Watts [Thu, 27 Feb 2020 13:05:38 +0000 (08:05 -0500)]
Api4 - Display sql errors in explorer
Coleman Watts [Thu, 27 Feb 2020 13:05:02 +0000 (08:05 -0500)]
Api code minor cleanup
Monish Deb [Thu, 27 Feb 2020 08:53:23 +0000 (14:23 +0530)]
core#1158: Unit Test to ensure primary addresses are printed on mailing label if searchPrimaryDetailsOnly is disabled
Seamus Lee [Thu, 27 Feb 2020 06:51:29 +0000 (17:51 +1100)]
[NFC] Extend unit tests to ensure that entity financial account is correctly deleted when financial type is deleted
Seamus Lee [Wed, 26 Feb 2020 21:00:57 +0000 (08:00 +1100)]
dev/core#1622 Fix unsubscribe when loading the unsubscribe form on a different locale to the one the mailing was sent from
Add in comments as per request from Eileen
Seamus Lee [Thu, 27 Feb 2020 05:57:02 +0000 (16:57 +1100)]
Merge pull request #16636 from totten/master-settings-tpl
civicrm.settings.php.template - Simplify examples of `$civicrm_setting`
Usha Matisson [Thu, 27 Feb 2020 05:39:34 +0000 (06:39 +0100)]
Contact Type Values with Cap in order to be well translated with ts()
Seamus Lee [Thu, 27 Feb 2020 04:32:15 +0000 (15:32 +1100)]
Merge pull request #16635 from seamuslee001/dev_core_1615_distmaker
dev/core#1615 Update distmaker to handle the fact civicrm-setup is no…
Tim Otten [Thu, 27 Feb 2020 02:01:08 +0000 (18:01 -0800)]
dev/financial#84 - Update distmaker to include sequentialcreditnotes
Tim Otten [Thu, 27 Feb 2020 00:12:10 +0000 (16:12 -0800)]
civicrm.settings.php.template - Simplify examples of `$civicrm_setting`
Overview
--------
This simplifies the examples in `civicrm.settings.php.template`.
Before
------
Every reference to `$civicrm_setting` uses an English-looking group-name like
``php
$civicrm_setting['URL Preferences']['imageUploadURL'] = 'http://example.com/example-image-upload-url';
```
After
-----
The varying group names are just `domain`.
```php
$civicrm_setting['domain']['imageUploadURL'] = 'http://example.com/example-image-upload-url';.
```
Comments
--------
Since CiviCRM v4.7, expessions like `$civicrm_setting['URL Preferences']` have been aliases
for `$civicrm_setting['domain']`. (See `SettingsManager::parseMandatorySettings()`.)
These examples were initially kept in the verbose 4.6 format so that users of 4.6 and 4.7
could continue to exchange examples with each other. But 4.6 and 4.7 are pretty old, so I
don't think that's an issue anymore. We're now firmly in the 5.x world.
What does still matter is intuition - if the examples set an expectation that you should put
things under buckets like `URL Preferences`, then it implies that you should be thinking about
those buckets. (Does the `extensionsURL` belong under `URL Preferences` or `Extension
Preferences`? Should a search-related setting defined by an extension go under `Search
Preferences` or `Extension Preferences`? Can I make up new groups? If I know the name used
by the Setting API, then how do I figure out the group-name used for the `$civicrm_setting`
override? ... The answer to all of these questions is that it doesn't matter because they're
really the same group.)
Eileen McNaughton [Wed, 26 Feb 2020 22:23:38 +0000 (11:23 +1300)]
Merge pull request #16597 from colemanw/drilldown
Menubar - Add "find menu item" search feature
Seamus Lee [Wed, 26 Feb 2020 21:55:14 +0000 (08:55 +1100)]
dev/core#1615 Update distmaker to handle the fact civicrm-setup is now in core
Seamus Lee [Wed, 26 Feb 2020 21:25:06 +0000 (08:25 +1100)]
Merge pull request #16631 from kartik1000/Fix_Invalid_parameter_doc
Removed Invalid Paramter from function doc
Seamus Lee [Wed, 26 Feb 2020 21:18:18 +0000 (08:18 +1100)]
Merge pull request #16630 from breheret/master
Add ts() for a sentence 'Add to case as role'
Coleman Watts [Wed, 26 Feb 2020 19:25:23 +0000 (14:25 -0500)]
News dashboard - Code cleanup to update js & css
- Use css class instead of inline style for unread items
- Use `CRM.cache` instead of `window.localStorage`
- Longer preview snippet for wide screens
colemanw [Wed, 26 Feb 2020 19:23:59 +0000 (14:23 -0500)]
Merge pull request #16633 from alexymik/patch-1
CommunicationPreferences 'loclize' -> 'localize'
Alexy Mikhailichenko [Wed, 26 Feb 2020 17:43:12 +0000 (09:43 -0800)]
'loclize' -> 'localize'
Kartik Kathuria [Wed, 26 Feb 2020 15:52:29 +0000 (21:22 +0530)]
Removed Invalid Paramter from function doc
Signed-off-by: Kartik Kathuria <kathuriakartik0@gmail.com>
breheret [Wed, 26 Feb 2020 15:13:35 +0000 (16:13 +0100)]
Add ts() for a sentence 'Add To case role'
Seamus Lee [Wed, 26 Feb 2020 07:15:49 +0000 (18:15 +1100)]
Merge pull request #16628 from totten/master-setup-action
dev/drupal#4 - Add Civi\Setup::getPendingAction() helper
Tim Otten [Wed, 26 Feb 2020 03:42:47 +0000 (19:42 -0800)]
dev/drupal#4 - Add Civi\Setup::getPendingAction() helper
Overview
--------
This exposes a new piece of information for downstream consumers of the `civicrm-setup` API.
It doesn't change any behaviors or expectations - it merely tracks an extra piece of info.
Before
------
The `Civi\Setup` interface does not give any reporting about what's going on.
After
-----
The `Civi\Setup` interface has a method, `getPendingAction()`, which reports the pending action.
Technical Details
-----------------
(1) The pending action is strictly singular - it would not be sensible, for example, to have the
`installFiles` and `uninstallFiles` actions running at the same time. Thus, the guards within
each function.
(2) The basic gist of the change - in each of the functions
(`{install,uninstall}{Files,Database}`), set the `pendingAction` at the start and unset
it at the end. The change looks slightly bigger than it should - because it wraps the
existing code within the `try ... finally ...` block.
(3) This facilitates dev/drupal#4 and https://github.com/civicrm/civicrm-drupal-8/pull/37
- there were some use-cases in which the auto-install behaviors of `civicrm_install()`
and `FlushDrupal8.civi-setup.php` would provoke each other (causing a sort of
installer-loop). This change makes it possible to avoid the loop without changing the
contracts.
Seamus Lee [Wed, 26 Feb 2020 02:02:04 +0000 (13:02 +1100)]
[REF] Apply fix for CRM-607 for when building the select section of the query as well as in where
Eileen McNaughton [Tue, 25 Feb 2020 20:05:19 +0000 (09:05 +1300)]
Merge pull request #16560 from eileenmcnaughton/fgbvar
dev/core#1596 fix (unreleased) regression on contribution summary
eileen [Sun, 16 Feb 2020 23:48:23 +0000 (12:48 +1300)]
dev/core#1596 fix (unreleased) regression on contribution summary
https://lab.civicrm.org/dev/core/issues/1596
Makes more use of parent function to fix (in general we've done fixes/ improvements to the report
generic functions that have not filtered down to reports that override them
Eileen McNaughton [Mon, 24 Feb 2020 21:24:29 +0000 (10:24 +1300)]
Merge pull request #16503 from aydun/dev_core_1584
dev/core#1584 Add function to specify whether payment processor requires email address
Eileen McNaughton [Mon, 24 Feb 2020 21:18:57 +0000 (10:18 +1300)]
Merge pull request #16338 from mattwire/note_timestamp
Convert civicrm_note.modified_date to timestamp
Tim Otten [Mon, 24 Feb 2020 20:49:53 +0000 (12:49 -0800)]
Merge pull request #16598 from eileenmcnaughton/setup
Enable the "sequentialcreditnotes" extension on new installations
colemanw [Mon, 24 Feb 2020 11:30:20 +0000 (06:30 -0500)]
Merge pull request #16621 from totten/master-setup-autoload
dev/core#1615 - Fix for recently migrated civicrm-setup
Eileen McNaughton [Mon, 24 Feb 2020 05:27:08 +0000 (18:27 +1300)]
Merge pull request #16622 from seamuslee001/test_dev_core_1386
dev/core#1386 Add in unit test for #15834
Seamus Lee [Mon, 24 Feb 2020 03:35:52 +0000 (14:35 +1100)]
dev/core#1386 Add in unit test for #15834
Tim Otten [Mon, 24 Feb 2020 00:37:10 +0000 (16:37 -0800)]
dev/core#1615 - Fix for recently migrated civicrm-setup
Overview
--------
Fix a recent (intra-alpha) regression from https://github.com/civicrm/civicrm-core/pull/16618
The search for `civicrm-setup` goes slightly awry because the migrated copy of civicrm-setup uses
the core's classloader rather than its own classloader.
Steps to Reproduce
------------------
* Create a site with WP and Civi(master).
* Ensure Civi is uninstalled. (ex: `cv core:uninstall -f`)
* In `wp-content/plugins/civicrm/civicrm`, touch the file `.use-civicrm-setup`.
(*This is supposed to activate the new UI.*)
* Go to the WP admin console. In the left navbar, choose "CiviCRM Installer".
Before
------
It fails to load the new UI -- the search finds `.use-civicrm-setup` but does not
find `civicrm-setup-autoload.php`. It falls back to the old UI.
After
-----
It opens the new UI.
Tim Otten [Sat, 22 Feb 2020 05:03:40 +0000 (21:03 -0800)]
Regenerate civicrm_generated.mysql
Tim Otten [Sat, 22 Feb 2020 05:02:01 +0000 (21:02 -0800)]
bin/regen.sh - Allow the `sequentialcreditnotes` ext to propagate into generated-data snapshot
eileen [Wed, 19 Feb 2020 23:53:45 +0000 (12:53 +1300)]
Add new core-extension to install sql
Per @totten there are some good future-thinking ways to address this issue of how to
install extensions on install. For now however, this should work & achieve our short-term goal
Eileen McNaughton [Sun, 23 Feb 2020 23:25:36 +0000 (12:25 +1300)]
Merge pull request #16618 from totten/master-setup
dev/core#1615 - Import civicrm-setup
colemanw [Sun, 23 Feb 2020 20:44:47 +0000 (15:44 -0500)]
Merge pull request #16619 from demeritcowboy/remove-noop-translations
dev/translation#37 - Remove hardcoded translations from 13 years ago that no longer do anything
demeritcowboy [Sun, 23 Feb 2020 03:24:44 +0000 (22:24 -0500)]
remove hardcoded translations that don't actually do anything anyway
Tim Otten [Sun, 23 Feb 2020 00:39:21 +0000 (16:39 -0800)]
(NFC) Update civicrm-setup to current civilint
Tim Otten [Sat, 22 Feb 2020 23:55:46 +0000 (15:55 -0800)]
(dev/core#1615) Load local copy of 'civicrm-setup' instead of downloading package
Tim Otten [Sat, 22 Feb 2020 23:52:17 +0000 (15:52 -0800)]
(dev/core#1615) Import civicrm-setup code
Note: This does not import the docs. Those should go to the dev guide.
colemanw [Sat, 22 Feb 2020 23:11:14 +0000 (18:11 -0500)]
Merge pull request #16616 from totten/master-scn
Move sequentialcreditnotes under `ext/` folder
Tim Otten [Sat, 22 Feb 2020 04:20:26 +0000 (20:20 -0800)]
Move sequentialcreditnotes under `ext/` folder
Maybe this is a bit of bikeshedding, but..
* `civicrm/ext/` is used for similar content in a few other cases (eg when adding `iatspayment` to the tarball; eg for
the `drupal-case` and `wp-case` build-types).
* `civicrm/ext/` looks analgous to `sites/default/files/civicrm/ext`, which has similar content.
* Among the list of folders under `civicrm/`, `ext/` looks more consistent. There are only two
folders with capital letters (`CRM/` `Civi/`) and only two folders with multiple
words (`bower_components/` `release-notes/`)... and 18 other folders which are
lowercase+single-word (`ang/` `api/` `bin/` `css/` `distmaker/`
`extern/` `i/` `install/` `js/` `l10n/` `packages/` `settings/` `sql/`
`templates/` `tests/` `tools/` `vendor/` `xml/`).
* The file-hierarchy is additive (combining elements of the OS/host FHS, of the CMS, and of intra-extension content)
and makes for a long total.
Coleman Watts [Wed, 19 Feb 2020 21:45:39 +0000 (16:45 -0500)]
Menubar - Add "Find menu item..." search feature
Allows user to locate menu items by typing a few letters.
Find tool is located under the "Home" (Civi logo) menu.
Seamus Lee [Fri, 21 Feb 2020 21:32:00 +0000 (08:32 +1100)]
Merge pull request #16613 from seamuslee001/nfc_custom_field_array
[NFC] Convert Custom Field BAO file to use short array syntax
Seamus Lee [Fri, 21 Feb 2020 20:09:42 +0000 (07:09 +1100)]
[NFC] Convert Custom Field BAO file to use short array syntax
Seamus Lee [Fri, 21 Feb 2020 19:37:31 +0000 (06:37 +1100)]
Merge pull request #15834 from francescbassas/patch-16
dev/core#1386 Allow advanced search for contributions without a soft credit related
Seamus Lee [Fri, 21 Feb 2020 19:27:34 +0000 (06:27 +1100)]
Merge pull request #16608 from civicrm/5.23
5.23
Seamus Lee [Fri, 21 Feb 2020 10:16:26 +0000 (21:16 +1100)]
Merge pull request #16607 from totten/5.23-pathurltest
Update recently-added PathUrlTest to be more representative
Tim Otten [Fri, 21 Feb 2020 08:34:40 +0000 (00:34 -0800)]
Update recently-added PathUrlTest to be more representative
Before
------
The test generates the URL for an example page (`civicrm/mailing/subscribe`)
by calling `url()`. It does not explicitly set the `url(...$frontend...)` option,
so it defaults to `FALSE`.
By contrast, the other places which make URLs for `civicrm/mailing/subscribe`
(eg `CRM/Mailing/BAO/Mailing.php` and `CRM/Utils/Token.php`) do set `$frontend` to `TRUE`.
After
-----
The test behaves the same way as other code.
Seamus Lee [Fri, 21 Feb 2020 06:53:00 +0000 (17:53 +1100)]
Merge pull request #16545 from eileenmcnaughton/part_pend
[REF] Extract function to getTransactionInfo
Seamus Lee [Fri, 21 Feb 2020 06:49:14 +0000 (17:49 +1100)]
Merge pull request #16606 from ejegg/API4Regex-5.23
Fix two more php-finding regexes
Elliott Eggleston [Fri, 21 Feb 2020 01:34:13 +0000 (20:34 -0500)]
Fix two more php-finding regexes
Before: Civi code living under a path containing the characters php
(such as ~/src/php/civicrm) will fail to load the API4 explorer with
a message like the following:
ReflectionException: "Class \Civi\Api4\src does not exist"
After: API4 explorer loads no matter what the enclosing path
Very similar to PR #16377
Matthew Wire [Thu, 20 Feb 2020 23:06:02 +0000 (23:06 +0000)]
Merge pull request #16605 from seamuslee001/master
[REF] Update civicrm_generated following merge of #16362
Seamus Lee [Thu, 20 Feb 2020 21:15:56 +0000 (08:15 +1100)]
Merge pull request #16604 from civicrm/5.23
5.23
Seamus Lee [Thu, 20 Feb 2020 21:07:36 +0000 (08:07 +1100)]
[REF] Update civicrm_generated following merge of #16362
Seamus Lee [Thu, 20 Feb 2020 20:34:47 +0000 (07:34 +1100)]
Merge pull request #16602 from mattwire/apiv3paymentspec
Add description to params for api3 Payment.get
Seamus Lee [Wed, 19 Feb 2020 21:13:43 +0000 (08:13 +1100)]
[REF] Refactor adding payment processor radio section onto register and contribution main forms
Move Contribute form specific handling back to its own form
Move shared function to the trait
Matthew Wire [Thu, 20 Feb 2020 17:12:50 +0000 (17:12 +0000)]
Add description to params for api3 Payment.get
Yashodha Chaku [Thu, 20 Feb 2020 16:17:54 +0000 (21:47 +0530)]
Merge pull request #16600 from mattwire/casesettingstpl
Remove hardcoded settings from form and use SettingForm.tpl for Case settings
Matthew Wire [Thu, 20 Feb 2020 14:50:13 +0000 (14:50 +0000)]
Merge pull request #16362 from eileenmcnaughton/pp_disable
Do not enable core payment processor types that we believe likely don't work on new installs
Matthew Wire [Thu, 20 Feb 2020 13:36:52 +0000 (13:36 +0000)]
Remove hardcoded settings from form and use SettingForm.tpl for Case settings
Mathieu Lu [Thu, 20 Feb 2020 13:27:24 +0000 (08:27 -0500)]
Merge pull request #16599 from seamuslee001/dev_translation_36
dev/translation#36 Ensure that we are only passing integers to the ng…
Matthew Wire [Thu, 20 Feb 2020 12:39:19 +0000 (12:39 +0000)]
Merge pull request #16562 from eileenmcnaughton/notice
Move determination of year & month to formatCreditCardDetails
Aidan Saunders [Mon, 10 Feb 2020 16:54:54 +0000 (16:54 +0000)]
Add function to specify whether payment processor requires email address
Manual payment processor implements this capability
Test included
Seamus Lee [Thu, 20 Feb 2020 01:53:07 +0000 (12:53 +1100)]
dev/translation#36 Ensure that we are only passing integers to the ngettext function for plurals
Eileen McNaughton [Wed, 19 Feb 2020 22:52:54 +0000 (11:52 +1300)]
Merge pull request #16596 from civicrm/5.23
5.23
Seamus Lee [Wed, 19 Feb 2020 21:48:24 +0000 (08:48 +1100)]
Merge pull request #16594 from alifrumin/rn-5.23
First pass at release notes for 5.23
Alice Frumin [Wed, 19 Feb 2020 20:43:16 +0000 (15:43 -0500)]
First pass at release notes for 5.23
Eileen McNaughton [Wed, 19 Feb 2020 20:06:07 +0000 (09:06 +1300)]
Merge pull request #16529 from mattwire/altermailing_templatetype
Pass template_type through to alterMailing hook
francescbassas [Wed, 19 Feb 2020 17:05:35 +0000 (18:05 +0100)]
dev/core#1386 Allow advanced search for contributions without a soft credit related
Matthew Wire [Wed, 19 Feb 2020 16:25:51 +0000 (16:25 +0000)]
Merge pull request #16085 from seamuslee001/dev_core_1466
[NFC] dev/core#1466 Update Documentation URLS to be the correct links…
Matthew Wire [Wed, 19 Feb 2020 16:18:55 +0000 (16:18 +0000)]
Merge pull request #15940 from seamuslee001/dev_financial_105
dev/financial#105 Add CSS class onto the radio button payment processor options
Matthew Wire [Wed, 19 Feb 2020 16:16:56 +0000 (16:16 +0000)]
Merge pull request #15316 from mepps/order-campaign-dashboard
Secondarily order campaign dashboard by id
Matthew Wire [Wed, 19 Feb 2020 16:14:17 +0000 (16:14 +0000)]
Merge pull request #15884 from kainuk/issue-lab-1365
Related / Inherited Memberships: Custom fields not filled with data
Matthew Wire [Wed, 19 Feb 2020 16:10:04 +0000 (16:10 +0000)]
Merge pull request #16359 from jensschuppe/dev_core_1547
dev/core#1547 Add DT_RowClass CSS classes to nested group markup
Seamus Lee [Wed, 19 Feb 2020 10:08:25 +0000 (21:08 +1100)]
Merge pull request #16005 from magnolia61/Contribution_Invoice_Privacy
dev/core#1436 Do not CC or BCC Contribution invoice
Eileen McNaughton [Tue, 18 Feb 2020 21:49:59 +0000 (10:49 +1300)]
Merge pull request #16580 from civicrm/5.23
5.23
Seamus Lee [Tue, 18 Feb 2020 19:57:08 +0000 (06:57 +1100)]
Merge pull request #16588 from eileenmcnaughton/523partnotice
Fix enotice regression (unreleased)
Eileen McNaughton [Tue, 18 Feb 2020 19:47:00 +0000 (08:47 +1300)]
Merge pull request #16589 from colemanw/copyValues
Cleanup copyValues DAO function
Coleman Watts [Tue, 18 Feb 2020 13:29:17 +0000 (08:29 -0500)]
Cleanup copyValues DAO function
The $serializeArrays parameter was transitional and is now always enabled.
Passing $params by reference was unnecessary and has been removed.
Renamed a few variables for readability.
Yashodha Chaku [Tue, 18 Feb 2020 11:21:13 +0000 (16:51 +0530)]
Merge pull request #16585 from eileenmcnaughton/dep_it
Add deprecation notice