Coleman Watts [Wed, 6 Jul 2022 21:01:47 +0000 (17:01 -0400)]
Afform - Use urlHash embedded in popup dialog
Coleman Watts [Fri, 1 Jul 2022 02:12:24 +0000 (22:12 -0400)]
crmUi - Fix crmPageTitle directive to work inside a modal
Coleman Watts [Fri, 1 Jul 2022 01:53:54 +0000 (21:53 -0400)]
Angular - Support popping up an afform or other ang module via ajax modal
Fixes the AngularLoader to work with modal dialogs via ajax.
Dedupes the already-loaded modules to only load what's needed.
Seamus Lee [Fri, 1 Jul 2022 01:10:30 +0000 (11:10 +1000)]
Merge pull request #23921 from civicrm/5.51
5.51 to master
Eileen McNaughton [Thu, 30 Jun 2022 22:02:11 +0000 (10:02 +1200)]
Merge pull request #23920 from MegaphoneJon/url-validation-regression
fixes #3706 URL validation regression
Jon Goldberg [Thu, 30 Jun 2022 19:45:14 +0000 (15:45 -0400)]
fixes #3706 URL validation regression
demeritcowboy [Thu, 30 Jun 2022 15:31:09 +0000 (11:31 -0400)]
Merge pull request #23914 from seamuslee001/file_substr_null
[REF][PHP8.1] Ensure that NULL is not passed to substr in CRM_Utils_F…
Eileen McNaughton [Thu, 30 Jun 2022 08:32:39 +0000 (20:32 +1200)]
Merge pull request #23916 from totten/master-wfmsg-data-boot
WorkflowMessageTest - Fix weird inconsistency in resolving `@dataProvider`
Tim Otten [Thu, 30 Jun 2022 03:54:19 +0000 (20:54 -0700)]
WorkflowMessageTest - Fix weird inconsistency in resolving `@dataProvider`
We see a failure scenario where:
* The first execution of WorkflowMessageTest runs fine.
* The second execution of WorkflowMessageTest fails to boot (while evaluating `@dataProvider`)
* If you reset the DB, then it works again - but only once.
Seamus Lee [Wed, 29 Jun 2022 23:43:57 +0000 (09:43 +1000)]
[REF][PHP8.1] Ensure that NULL is not passed to substr in CRM_Utils_File::addTrailingSlash
colemanw [Wed, 29 Jun 2022 20:14:36 +0000 (16:14 -0400)]
Merge pull request #23899 from MegaphoneJon/civigrant-afform
Grants appear in afform
Eileen McNaughton [Wed, 29 Jun 2022 15:16:41 +0000 (03:16 +1200)]
Merge pull request #23871 from agileware/CIVICRM-2004
Personal Campaign Pages (PCP) incorrectly displays "Don't list my contribution in the honour roll"
Eileen McNaughton [Wed, 29 Jun 2022 13:03:55 +0000 (01:03 +1200)]
Merge pull request #23909 from civicrm/5.51
5.51 to master
Eileen McNaughton [Wed, 29 Jun 2022 13:03:20 +0000 (01:03 +1200)]
Merge pull request #23893 from eileenmcnaughton/user_two
dev/core#3514 Add interface to allow extensions that deal with imports to cope with 5.51
Eileen McNaughton [Wed, 29 Jun 2022 10:12:50 +0000 (22:12 +1200)]
Merge pull request #23907 from eileenmcnaughton/up
5.51 to master
Eileen McNaughton [Wed, 29 Jun 2022 10:11:54 +0000 (22:11 +1200)]
Merge branch '5.51' of github.com:civicrm/civicrm-core into up
Eileen McNaughton [Tue, 28 Jun 2022 10:42:47 +0000 (22:42 +1200)]
Fix Parser classes to use ClassScanner
Eileen McNaughton [Wed, 29 Jun 2022 10:02:47 +0000 (22:02 +1200)]
Merge pull request #23888 from eileenmcnaughton/user_import
Convert the type on the UserJob entity to be a string
Tim Otten [Wed, 29 Jun 2022 08:07:41 +0000 (01:07 -0700)]
Import Summary - Update to match final schema ('UserJob.job_type')
eg When running "Import Activities", the page-title for the summary is incorrect.
Eileen McNaughton [Wed, 29 Jun 2022 07:40:00 +0000 (19:40 +1200)]
Merge pull request #23903 from eileenmcnaughton/551
Allow tests to pick up hook too
Eileen McNaughton [Wed, 29 Jun 2022 07:22:42 +0000 (19:22 +1200)]
Merge pull request #23902 from civicrm/5.51
5.51 to master
Eileen McNaughton [Wed, 29 Jun 2022 06:04:38 +0000 (18:04 +1200)]
Merge pull request #23889 from eileenmcnaughton/offline_cur
Add second currency example
Eileen McNaughton [Wed, 29 Jun 2022 05:41:22 +0000 (17:41 +1200)]
Merge pull request #23901 from totten/nfc-install-docblock
(NFC) Expand docblocks for hook_install and hook_postInstall
Eileen McNaughton [Wed, 29 Jun 2022 05:40:21 +0000 (17:40 +1200)]
Allow tests to pick up hook too
Eileen McNaughton [Wed, 29 Jun 2022 05:09:35 +0000 (17:09 +1200)]
Merge pull request #23900 from totten/5.51-sticky-classloader
(dev/core#3660) CRM_Extension_ClassLoader - Defend against redundant refreshes
Tim Otten [Wed, 29 Jun 2022 03:58:40 +0000 (20:58 -0700)]
Merge pull request #23894 from eileenmcnaughton/off_it
Minor test cleanup
Tim Otten [Wed, 29 Jun 2022 03:30:42 +0000 (20:30 -0700)]
Examples - Title should differentiate EUR/CAD examples
Tim Otten [Wed, 29 Jun 2022 03:24:17 +0000 (20:24 -0700)]
Merge pull request #23891 from eileenmcnaughton/smarty
Reset smarty-security after an exception
Tim Otten [Wed, 29 Jun 2022 02:37:03 +0000 (19:37 -0700)]
(NFC) Expand docblocks for hook_install and hook_postInstall
Eileen McNaughton [Tue, 28 Jun 2022 05:35:33 +0000 (17:35 +1200)]
Add second currency example
Jon Goldberg [Wed, 29 Jun 2022 01:59:44 +0000 (21:59 -0400)]
Grants appear in afform
Tim Otten [Wed, 29 Jun 2022 01:27:01 +0000 (18:27 -0700)]
(dev/core#3660) CRM_Extension_ClassLoader - Defend against redundant refreshes
Overview
--------
This is a follow-up to #23824 (
c24dd7db7e1e91120fd7daeb7e151f856d6b78c3) which addresses a
regressive edge-case.
Steps to Reproduce
------------------
* Write an extension like `wmf-civicrm` which (a) calls `System.flush` (`rebuildMenuAndCaches()`)
during `hook_install` -- and then (b) loads some class from the same extension.
```php
function foo_civicrm_install() {
civicrm_api3('System', 'flush', []);
CRM_Foo_Helper::doStuff();
}
```
* Try to install the extension.
Before
------
Crashes on loading the class `CRM_Foo_Helper`
After
-----
Loads the class `CRM_Foo_Helper`.
Comments
--------
(1) To see what's happening, consider `CRM_Extension_Manager_Module::onPreInstall()`.
This registers the new classloader and then fires `hook_install` which eventually
fires `rebuildMenuAndCaches()`. With
c24dd7db, this resets the classloader again.
But the extension isn't fully installed yet - so it forgets about the new extension.
(2) Is it safe to have some (temporarily) sticky items? Ish. You might
say: "Ah, but what if we need to remove an extension? Won't this static
variable retain stale things?" Doesn't matter. In PHP, classloading is a
one-way-street. (You cannot unload.) So you'll still have old classes in
memory, regardless of whether the `ClassLoader` has some old metadata
about where to find classes.
(3) I'm on the fence about whether this patch is a good idea. Calling
`System.flush` explicitly in this context seems like an invitation to
trouble. OTOH, it worked before #23824, so it can be called a regression.
Eileen McNaughton [Tue, 28 Jun 2022 23:46:38 +0000 (11:46 +1200)]
Merge pull request #23898 from civicrm/5.51
5.51 to master
Eileen McNaughton [Tue, 28 Jun 2022 23:00:17 +0000 (11:00 +1200)]
Merge pull request #23897 from agh1/5.51.0-releasenotes-initial
5.51.0 release notes initial run
Tim Otten [Tue, 28 Jun 2022 22:41:33 +0000 (15:41 -0700)]
Set version to 5.51.beta2. Retargeg FiveFiftyOne::updateUserJobTable to beta2.
Andie Hunt [Tue, 28 Jun 2022 20:23:55 +0000 (16:23 -0400)]
5.51.0 release notes: added boilerplate
Eileen McNaughton [Tue, 28 Jun 2022 04:23:56 +0000 (16:23 +1200)]
Convert the type on the UserJob entity to be a string
Currently we are storing a numeric ID - however if we
permit non-core classes to register types we find numeric ids
quickly become hard to manage as uninstalling an extension could
change the id. This switches to using a string type
Eileen McNaughton [Tue, 28 Jun 2022 11:26:48 +0000 (23:26 +1200)]
Minor test cleanup
Eileen McNaughton [Tue, 28 Jun 2022 10:49:32 +0000 (22:49 +1200)]
Merge pull request #23852 from IProSoft/master
New domain token base_url
Eileen McNaughton [Tue, 28 Jun 2022 08:49:15 +0000 (20:49 +1200)]
Merge pull request #23892 from eileenmcnaughton/order
Ensure apiv3 params are converted at the line item level
iprosoft [Tue, 21 Jun 2022 08:41:11 +0000 (10:41 +0200)]
New domain token base_url
Change url retrival method for base_url token
Change base url token title. Fix test error
PHPUnit TokenConsCRM_Utils_TokenConsistencyTest update
Eileen McNaughton [Tue, 28 Jun 2022 05:45:59 +0000 (17:45 +1200)]
Ensure apiv3 params are converted at the line item level
We switched to using apiv4 but at least one test seems to be passing in a string
at the line item level which is a bit weird but we should handle it
Eileen McNaughton [Tue, 28 Jun 2022 05:43:52 +0000 (17:43 +1200)]
Reset smarty-security after an exception
This stops tests from getting befuddled
Eileen McNaughton [Tue, 28 Jun 2022 03:22:12 +0000 (15:22 +1200)]
Merge pull request #23887 from civicrm/5.51
5.51 to master
Eileen McNaughton [Tue, 28 Jun 2022 03:21:41 +0000 (15:21 +1200)]
Merge pull request #23854 from totten/master-mixin-wfmsg
Scan for classes based on the PHP interface (WorkflowMessageInterface, ExampleDataInterface)
Eileen McNaughton [Tue, 28 Jun 2022 03:16:39 +0000 (15:16 +1200)]
Merge pull request #23886 from totten/master-act-dao
Activity - Regenerate DAO with current description
Seamus Lee [Tue, 28 Jun 2022 01:47:27 +0000 (11:47 +1000)]
Merge pull request #23885 from totten/master-wfmsgtest
WorkflowMessageTest - Re-enable skipped test
Tim Otten [Tue, 28 Jun 2022 01:41:14 +0000 (18:41 -0700)]
Activity - Regenerate DAO with current description
Tim Otten [Mon, 27 Jun 2022 23:40:10 +0000 (16:40 -0700)]
ExampleDataInterface - Switch to ClassScanner (part 3, swap scanner)
Tim Otten [Thu, 23 Jun 2022 05:25:54 +0000 (22:25 -0700)]
ExampleDataInterface - Switch to ClassScanner (part 2, use new names)
Tim Otten [Tue, 21 Jun 2022 11:12:00 +0000 (04:12 -0700)]
ExampleDataInterface - Switch to ClassScanner (part 1, rename *.ex.php => *.php)
Tim Otten [Tue, 21 Jun 2022 09:12:23 +0000 (02:12 -0700)]
WorkflowMessage - Switch to `ClassScanner` (was: bespoke `include_path` search)
Tim Otten [Tue, 21 Jun 2022 09:39:53 +0000 (02:39 -0700)]
mixin/scan-classes@1 - Allow extensions to opt-in to class scanning
Tim Otten [Tue, 21 Jun 2022 09:11:44 +0000 (02:11 -0700)]
ClassScanner - Add utility for scanning classes based on PHP interfaces
Tim Otten [Tue, 21 Jun 2022 10:33:42 +0000 (03:33 -0700)]
CRM_Utils_System::flushCache - More consistent behavior. Prepare for interface-php test.
* The interface-php test registers an instance of WorkflowMessageInterface.
* The list of WorkflowMessageInterface's is stored in the 'long' cache.
* When you enable/disable an extension, it should clear WorkflowMessage list (and other things).
* Before this patch, interface-php's `LifecycleTest` is inconsistent: it passes with
`testLifecycleWithSubprocesses()` and fails with `testLifecycleWithLocalFunctions()`.
* After this patch, interface-php's `LifecycleTest` is consistent: it passes with both
`testLifecycleWithSubprocesses()` and `testLifecycleWithLocalFunctions()`.
* The problem - while executing `testLifecycleWithLocalFunctions()`, it evidentally uses
`Arraycache` as the backend -- and thus skips the flushes. However, I cannot fathom why
one would want to clear-caches for SQL+memcache+redis but keep them for Arraycache.
Tim Otten [Mon, 27 Jun 2022 23:55:02 +0000 (16:55 -0700)]
WorkflowMessageTest - Re-enable skipped test.
This is a follow-up to #23811 (
409b1e0c30d28179f6244c1f180838a473d7582c). The prior commit
changed the way it found examples - and caused it to skip some examples.
This re-enables the example and adds an assertion to ensure that it actually
finds some examples.
demeritcowboy [Mon, 27 Jun 2022 13:19:23 +0000 (09:19 -0400)]
Merge pull request #23879 from mattwire/wpnotify
Enable the 'notify' parameter for WordPress user creation
Eileen McNaughton [Sun, 26 Jun 2022 01:39:08 +0000 (13:39 +1200)]
Merge pull request #23881 from civicrm/5.51
5.51
Eileen McNaughton [Sat, 25 Jun 2022 22:27:55 +0000 (10:27 +1200)]
Merge pull request #23874 from AlainBenbassat/empty-weight-column-during-upgrade
returns weight 0 when weight column name is empty
demeritcowboy [Sat, 25 Jun 2022 11:49:17 +0000 (07:49 -0400)]
Merge pull request #23722 from jensschuppe/fix/multipleLogfilesMultilanguage
Avoid multiple log files in multi-language environments
demeritcowboy [Sat, 25 Jun 2022 11:42:22 +0000 (07:42 -0400)]
Merge pull request #23878 from herbdool/issue-3691
dev/core#3691: better description of activity table columns
demeritcowboy [Sat, 25 Jun 2022 11:29:48 +0000 (07:29 -0400)]
Merge pull request #23876 from colemanw/checkRecentItemsPerms
RecentItems - Enforce permissions before adding item
Eileen McNaughton [Sat, 25 Jun 2022 00:42:56 +0000 (12:42 +1200)]
Merge pull request #23602 from kainuk/core-3369
Fixes core#3369 scheduled Reminder limited by Participant Role fails if any participant has multiple roles
Matthew Wire [Fri, 24 Jun 2022 16:49:23 +0000 (17:49 +0100)]
Enable the 'notify' parameter for WordPress user creation
Herb v/d Dool [Fri, 24 Jun 2022 16:35:55 +0000 (12:35 -0400)]
Issue 3691: better description of activity table columns
Andie Hunt [Fri, 24 Jun 2022 13:46:22 +0000 (09:46 -0400)]
5.51.0 release notes: raw from script
Coleman Watts [Fri, 24 Jun 2022 00:32:50 +0000 (20:32 -0400)]
RecentItems - Enforce permissions before adding item
demeritcowboy [Fri, 24 Jun 2022 00:19:27 +0000 (20:19 -0400)]
Merge pull request #23856 from eileenmcnaughton/pref
dev/core#2866 ignore preferred_mail_format, send both
Alain Benbassat [Thu, 23 Jun 2022 21:00:47 +0000 (23:00 +0200)]
returns weight 0 when weight column name is empty
Eileen McNaughton [Thu, 23 Jun 2022 22:05:28 +0000 (10:05 +1200)]
Merge pull request #23873 from colemanw/uiDialogBackground
dev/core#3432 UI Dialog - Fix transparent background caused by certain other plugins
Eileen McNaughton [Tue, 21 Jun 2022 20:15:30 +0000 (08:15 +1200)]
dev/core#2866 ignore preferred_mail_format, send both
Seamus Lee [Thu, 23 Jun 2022 21:16:34 +0000 (07:16 +1000)]
Merge pull request #23872 from demeritcowboy/valuestyle
Unassigned variable in invoice message template
Coleman Watts [Thu, 23 Jun 2022 20:12:55 +0000 (16:12 -0400)]
UI Dialog - Fix transparent background caused by certain other plugins
Fixes dev/core#3432
It was reported that certain Drupal modules that include a copy of jQuery UI
cause the background to become transparent. This should prevent that.
Tim Otten [Thu, 23 Jun 2022 19:48:50 +0000 (12:48 -0700)]
Merge pull request #23831 from mlutfy/purgeMenus
navigation: cleanup less frequently used New items
demeritcowboy [Thu, 23 Jun 2022 16:28:20 +0000 (12:28 -0400)]
Unused variable. Meaningless comment.
demeritcowboy [Thu, 23 Jun 2022 14:11:47 +0000 (10:11 -0400)]
Merge pull request #23829 from eileenmcnaughton/inv_lines
Replace more assigns with tokens in invoice, add tests
Justin Freeman [Thu, 23 Jun 2022 05:05:08 +0000 (15:05 +1000)]
CIVICRM-2004 CiviCRM Personal Campaign Pages (PCP), incorrectly display "Don't list my contribution in the honor roll" even if the Contribution Honour Roll feature is not enabled or the user has opted out of the Honour Roll
Eileen McNaughton [Fri, 17 Jun 2022 05:05:56 +0000 (17:05 +1200)]
Swap out some additional assigns for tokens, improve tests
Eileen McNaughton [Wed, 22 Jun 2022 21:42:42 +0000 (09:42 +1200)]
Merge pull request #23868 from civicrm/5.51
5.51 to master
Eileen McNaughton [Wed, 22 Jun 2022 21:38:29 +0000 (09:38 +1200)]
Merge pull request #23867 from demeritcowboy/currency551
dev/core#3680 - Currency incorrectly displayed for price set when default is not USD
Mathieu Lutfy [Fri, 17 Jun 2022 15:06:28 +0000 (11:06 -0400)]
navigation: cleanup less frequently used New items
demeritcowboy [Wed, 22 Jun 2022 13:34:12 +0000 (09:34 -0400)]
use the actual currency if there is one not the default
Eileen McNaughton [Wed, 22 Jun 2022 10:29:06 +0000 (22:29 +1200)]
Merge pull request #23866 from civicrm/5.51
5.51 to master
Eileen McNaughton [Wed, 22 Jun 2022 09:50:42 +0000 (21:50 +1200)]
Merge pull request #23865 from colemanw/behalf
dev/core#3675 Fix Permissioned Relationship pseudoconstant
Coleman Watts [Wed, 22 Jun 2022 08:05:40 +0000 (04:05 -0400)]
dev/core#3675 Fix Permissioned Relationship pseudoconstant
Fixes dev/core#3675 Permissioned Relationship no longer set up
for "On Behalf of Organization" Membership Contribution Form submissions
Eileen McNaughton [Wed, 22 Jun 2022 03:30:27 +0000 (15:30 +1200)]
Merge pull request #23860 from civicrm/5.51
5.51
Eileen McNaughton [Wed, 22 Jun 2022 01:45:48 +0000 (13:45 +1200)]
Merge pull request #23847 from eileenmcnaughton/sync
Attempt to make function more readable by extracting in-line function
Seamus Lee [Tue, 21 Jun 2022 23:58:10 +0000 (09:58 +1000)]
Merge pull request #23839 from eileenmcnaughton/import_outy
dev/core#3665 import summary fixes
Seamus Lee [Tue, 21 Jun 2022 23:27:32 +0000 (09:27 +1000)]
Merge pull request #23849 from eileenmcnaughton/import_55
dev/core#3673 do not attempt to import empty related contact
demeritcowboy [Tue, 21 Jun 2022 23:26:33 +0000 (19:26 -0400)]
Merge pull request #23855 from mlutfy/fixAccentsIcalAgain
dev/core#1541 Fix ICalendar random invalid utf8 (PHP <7.4 compat) and tests
Eileen McNaughton [Tue, 21 Jun 2022 23:08:41 +0000 (11:08 +1200)]
Merge pull request #23836 from stesi561/dev/core/#3671
Refs: dev/core#3671 Fix regression involving CiviCRM Webform + Cases.
Eileen McNaughton [Tue, 21 Jun 2022 00:58:07 +0000 (12:58 +1200)]
Attempt to make function more readable by extracting in-line function
Eileen McNaughton [Tue, 21 Jun 2022 22:59:55 +0000 (10:59 +1200)]
Merge pull request #23858 from seamuslee001/guzzle_658
[REF] Update Guzzle to be 6.5.8
demeritcowboy [Tue, 21 Jun 2022 22:46:58 +0000 (18:46 -0400)]
Merge pull request #23846 from seamuslee001/fix_warning_karma
[REF] Follow on from #23749 and remove refernece to ui-utils from kar…
Seamus Lee [Tue, 21 Jun 2022 21:37:50 +0000 (07:37 +1000)]
[REF] Update Guzzle to be 6.5.8
Mathieu Lu [Tue, 21 Jun 2022 19:53:00 +0000 (15:53 -0400)]
Merge pull request #23850 from demeritcowboy/rsspubdate
Alternate to 23826 - Events RSS feed does not output a pubDate for each Event
demeritcowboy [Tue, 21 Jun 2022 17:25:05 +0000 (13:25 -0400)]
Merge pull request #23853 from pradpnayak/updatecasefixes
Fixed fatal error on update multiple case
Mathieu Lutfy [Tue, 21 Jun 2022 13:54:05 +0000 (09:54 -0400)]
dev/core#1541 Fix ICalendar random invalid utf8 (PHP <7.4 compat) and tests
Pradeep Nayak [Tue, 21 Jun 2022 13:47:38 +0000 (14:47 +0100)]
Fixed fatal error on update multiple case
Eileen McNaughton [Tue, 21 Jun 2022 03:36:11 +0000 (15:36 +1200)]
dev/core#3673 do not attempt to report empty related contact