civicrm-core.git
4 years agoadd asterisk for smart group option in select2 widget
Monish Deb [Thu, 4 Apr 2019 11:35:13 +0000 (17:05 +0530)]
add asterisk for smart group option in select2 widget

4 years agodev/core#785: Differentiate smart group from regular group using icon in select2...
Monish Deb [Fri, 8 Mar 2019 11:11:37 +0000 (16:41 +0530)]
dev/core#785: Differentiate smart group from regular group using icon in select2 field

4 years agoMerge pull request #17559 from eileenmcnaughton/realex
Seamus Lee [Tue, 9 Jun 2020 03:34:05 +0000 (13:34 +1000)]
Merge pull request #17559 from eileenmcnaughton/realex

dev/financial#131 Fix Realex processor to correctly throw an exception

4 years agoMerge pull request #17557 from ngo360/master
Seamus Lee [Tue, 9 Jun 2020 01:30:41 +0000 (11:30 +1000)]
Merge pull request #17557 from ngo360/master

dev/core#1801 Fix hardcoded activity priority by label

4 years agodev/financial#131 Fix Realex processor to correctly throw an exception
eileen [Tue, 9 Jun 2020 01:16:55 +0000 (13:16 +1200)]
dev/financial#131 Fix Realex processor to correctly throw an exception

4 years agoMerge pull request #17515 from seamuslee001/replace_legacy_rebuild_module_data
Seamus Lee [Tue, 9 Jun 2020 00:29:18 +0000 (10:29 +1000)]
Merge pull request #17515 from seamuslee001/replace_legacy_rebuild_module_data

[REF] Replace the deprecated system_rebuild_module_data function with…

4 years agoMerge pull request #17555 from seamuslee001/dev_core_560_deprecated_function_warning
Seamus Lee [Mon, 8 Jun 2020 23:22:21 +0000 (09:22 +1000)]
Merge pull request #17555 from seamuslee001/dev_core_560_deprecated_function_warning

dev/core#560 Add in deprecated function warning now that fatal is dep…

4 years agodev/core#1801 Fix hardcoded activity priority
marcineqpol [Mon, 8 Jun 2020 22:26:13 +0000 (00:26 +0200)]
dev/core#1801 Fix hardcoded activity priority

4 years agoMerge pull request #17450 from mattwire/activitydefaults
Seamus Lee [Mon, 8 Jun 2020 22:18:36 +0000 (08:18 +1000)]
Merge pull request #17450 from mattwire/activitydefaults

dev/core#1782 Set activity_date_time and created_date to default to current_timestamp

4 years agoMerge pull request #17501 from eileenmcnaughton/guzzle3
Seamus Lee [Mon, 8 Jun 2020 21:52:42 +0000 (07:52 +1000)]
Merge pull request #17501 from eileenmcnaughton/guzzle3

[Ref] Convert Authorize.net doDirectPayment to use guzzle & add test

4 years agoMerge pull request #17554 from alifrumin/entryFoundFlag
Eileen McNaughton [Mon, 8 Jun 2020 21:48:27 +0000 (09:48 +1200)]
Merge pull request #17554 from alifrumin/entryFoundFlag

Fix "Undefined variable: entryFound" notice on Bookkeeping report

4 years agoMerge pull request #17506 from mattwire/propertybagremovewarning
Eileen McNaughton [Mon, 8 Jun 2020 21:45:57 +0000 (09:45 +1200)]
Merge pull request #17506 from mattwire/propertybagremovewarning

Payment Propertybag remove warning

4 years agodev/core#560 Add in deprecated function warning now that fatal is deprecated
Seamus Lee [Mon, 8 Jun 2020 21:21:00 +0000 (07:21 +1000)]
dev/core#560 Add in deprecated function warning now that fatal is deprecated

4 years ago[REF] Replace the deprecated system_rebuild_module_data function with equivilant...
Seamus Lee [Fri, 5 Jun 2020 23:11:13 +0000 (09:11 +1000)]
[REF] Replace the deprecated system_rebuild_module_data function with equivilant extension.list.module service function calls to be Drupal 9 compatiable

4 years agoMerge pull request #17552 from mattwire/deprecatedfunctionwarning
Eileen McNaughton [Mon, 8 Jun 2020 20:41:18 +0000 (08:41 +1200)]
Merge pull request #17552 from mattwire/deprecatedfunctionwarning

Support passing old method name into deprecatedFunctionWarning

4 years agoset flag
Alice Frumin [Mon, 8 Jun 2020 20:04:32 +0000 (16:04 -0400)]
set flag

4 years agoMerge pull request #17553 from semseysandor/semseysandor-contributor
Eileen McNaughton [Mon, 8 Jun 2020 19:33:14 +0000 (07:33 +1200)]
Merge pull request #17553 from semseysandor/semseysandor-contributor

Update contributor-key.yml

4 years agoUpdate contributor-key.yml
Sandor Semsey [Mon, 8 Jun 2020 15:14:28 +0000 (17:14 +0200)]
Update contributor-key.yml

4 years agoMerge pull request #17550 from eileenmcnaughton/request
Eileen McNaughton [Mon, 8 Jun 2020 12:35:44 +0000 (00:35 +1200)]
Merge pull request #17550 from eileenmcnaughton/request

Remove last instance of CRM_Core_Error::fatal....

4 years agoMerge pull request #16610 from mattwire/settingstrait_datepicker
Eileen McNaughton [Mon, 8 Jun 2020 12:26:23 +0000 (00:26 +1200)]
Merge pull request #16610 from mattwire/settingstrait_datepicker

Allow adding datepicker to metadata based settings pages

4 years agoSupport passing old method name into deprecatedFunctionWarning
Matthew Wire [Mon, 8 Jun 2020 11:49:30 +0000 (12:49 +0100)]
Support passing old method name into deprecatedFunctionWarning

4 years agoRemove last instance of CRM_Core_Error::fatal....
eileen [Mon, 8 Jun 2020 05:17:50 +0000 (17:17 +1200)]
Remove last instance of CRM_Core_Error::fatal....

4 years agoMerge pull request #16514 from mattwire/phpnotice_ccparams
Eileen McNaughton [Mon, 8 Jun 2020 11:24:07 +0000 (23:24 +1200)]
Merge pull request #16514 from mattwire/phpnotice_ccparams

Fix PHP notice when we don't have credit card params

4 years agoSet activity_date_time and created_date to default to current_timestamp
Matthew Wire [Mon, 1 Jun 2020 12:19:41 +0000 (13:19 +0100)]
Set activity_date_time and created_date to default to current_timestamp

4 years agoMerge pull request #17374 from totten/master-setlocale
Eileen McNaughton [Mon, 8 Jun 2020 11:12:13 +0000 (23:12 +1200)]
Merge pull request #17374 from totten/master-setlocale

CRM_Core_I18n::setLocale() - Fix bug with repeated usage

4 years agoMerge pull request #17179 from mattwire/addpaymentprocessortorecurlist
Eileen McNaughton [Mon, 8 Jun 2020 11:05:22 +0000 (23:05 +1200)]
Merge pull request #17179 from mattwire/addpaymentprocessortorecurlist

Add payment processor to details on list of recurring contributions

4 years agoMerge pull request #17512 from semseysandor/relative-date-filter
Eileen McNaughton [Mon, 8 Jun 2020 10:47:03 +0000 (22:47 +1200)]
Merge pull request #17512 from semseysandor/relative-date-filter

dev/core#1798 - "End of yesterday" Relative Date Filter

4 years agoMerge pull request #17523 from mattwire/customsearchzipcode
Eileen McNaughton [Mon, 8 Jun 2020 10:46:37 +0000 (22:46 +1200)]
Merge pull request #17523 from mattwire/customsearchzipcode

Zip code range search only supports numeric zip codes

4 years agoFix PHP notice when we don't have credit card params
Matthew Wire [Wed, 12 Feb 2020 15:26:37 +0000 (15:26 +0000)]
Fix PHP notice when we don't have credit card params

4 years agoMerge pull request #17549 from eileenmcnaughton/friend
Seamus Lee [Mon, 8 Jun 2020 08:52:31 +0000 (18:52 +1000)]
Merge pull request #17549 from eileenmcnaughton/friend

[Ref] Remove another instance of fatal()

4 years agoMerge pull request #17543 from eileenmcnaughton/dummy
Seamus Lee [Mon, 8 Jun 2020 06:33:15 +0000 (16:33 +1000)]
Merge pull request #17543 from eileenmcnaughton/dummy

[Ref] Readability extraction in Dummy class

4 years agoMerge pull request #17546 from eileenmcnaughton/validate2
Seamus Lee [Mon, 8 Jun 2020 06:32:55 +0000 (16:32 +1000)]
Merge pull request #17546 from eileenmcnaughton/validate2

Remove isThrowException from CRM_Utils_Type::validate() signature

4 years ago[Ref] Remove another instance of fatal()
eileen [Mon, 8 Jun 2020 05:03:38 +0000 (17:03 +1200)]
[Ref] Remove another instance of fatal()

4 years ago[Ref] Readability extraction in Dummy class
eileen [Mon, 8 Jun 2020 00:33:04 +0000 (12:33 +1200)]
[Ref] Readability extraction in Dummy class

4 years agoMerge pull request #17545 from seamuslee001/dev_core_560_fin
Seamus Lee [Mon, 8 Jun 2020 04:37:31 +0000 (14:37 +1000)]
Merge pull request #17545 from seamuslee001/dev_core_560_fin

dev/core#560 Convert final CRM_Core_Error::fatal to statusBounces or …

4 years agoRemove isThrowException from CRM_Utils_Type::validate() signature
eileen [Mon, 8 Jun 2020 01:21:14 +0000 (13:21 +1200)]
Remove isThrowException from CRM_Utils_Type::validate() signature

There are no instances in core where FALSE is passed

4 years agoMerge pull request #17544 from eileenmcnaughton/validate
Seamus Lee [Mon, 8 Jun 2020 04:30:36 +0000 (14:30 +1000)]
Merge pull request #17544 from eileenmcnaughton/validate

Fix validateAll to no longer support unused abort param

4 years agodev/core#560 Convert final CRM_Core_Error::fatal to statusBounces or Exceptions
Seamus Lee [Mon, 8 Jun 2020 01:13:26 +0000 (11:13 +1000)]
dev/core#560 Convert final CRM_Core_Error::fatal to statusBounces or Exceptions

4 years agoMerge pull request #17542 from eileenmcnaughton/pay_error
Seamus Lee [Mon, 8 Jun 2020 02:48:30 +0000 (12:48 +1000)]
Merge pull request #17542 from eileenmcnaughton/pay_error

dev/financial#131 Fix Eway processor to throw exceptions rather than return errors

4 years agoMerge pull request #17533 from eileenmcnaughton/fatal
Seamus Lee [Mon, 8 Jun 2020 02:47:43 +0000 (12:47 +1000)]
Merge pull request #17533 from eileenmcnaughton/fatal

[REF] Replace some instances of fatal with thrown exceptions.

4 years agoMerge pull request #17540 from colemanw/getActionsPerm
Eileen McNaughton [Mon, 8 Jun 2020 01:59:33 +0000 (13:59 +1200)]
Merge pull request #17540 from colemanw/getActionsPerm

APIv4 - filter getActions results based on user permissions

4 years agoMerge pull request #17491 from eileenmcnaughton/toemail
Seamus Lee [Mon, 8 Jun 2020 01:57:13 +0000 (11:57 +1000)]
Merge pull request #17491 from eileenmcnaughton/toemail

[Ref] Simplify the replacing of the email with the email from the url

4 years agoMerge pull request #17500 from eileenmcnaughton/renew_can
Seamus Lee [Mon, 8 Jun 2020 01:54:11 +0000 (11:54 +1000)]
Merge pull request #17500 from eileenmcnaughton/renew_can

[Ref] Throw exceptions from Authorize.net rather than return errors

4 years agoMerge pull request #17499 from eileenmcnaughton/unhandled
Seamus Lee [Mon, 8 Jun 2020 01:50:20 +0000 (11:50 +1000)]
Merge pull request #17499 from eileenmcnaughton/unhandled

[Ref] Remove calls to, and deprecate, unhandled function

4 years agoMerge pull request #17504 from eileenmcnaughton/renewd
Seamus Lee [Mon, 8 Jun 2020 01:49:37 +0000 (11:49 +1000)]
Merge pull request #17504 from eileenmcnaughton/renewd

[REF] Remove handling for 2 fields not on the form

4 years agoFix validateAll to no longer support unused abort param
eileen [Mon, 8 Jun 2020 01:11:02 +0000 (13:11 +1200)]
Fix validateAll to no longer support unused abort param

Default of TRUE is good here

4 years agoMerge pull request #17539 from eileenmcnaughton/fatal2
Seamus Lee [Mon, 8 Jun 2020 00:53:13 +0000 (10:53 +1000)]
Merge pull request #17539 from eileenmcnaughton/fatal2

Replace calls to fatal with statusBounces

4 years agodev/financial#131 Fix Eway processor to throw exceptions rather than return errors
eileen [Mon, 8 Jun 2020 00:12:04 +0000 (12:12 +1200)]
dev/financial#131 Fix Eway processor to throw exceptions rather than return errors

This is part of a push to model the correct behaviour in processors we can alter. This is safe as CRM_Core_Payment
already converts these

4 years ago[REF] Replace some instances of fatal with thrown exceptions.
eileen [Sun, 7 Jun 2020 04:59:24 +0000 (16:59 +1200)]
[REF] Replace some instances of fatal with thrown exceptions.

This is ongoing cleanup to consisently throw execptions. The only thing notable is in the OG class where
it turned out the exception was thrown if a never-passed-in-parameter was passed in, so I removed the
construct

4 years agoMerge pull request #17541 from seamuslee001/dev_core_560_third_to_last
Seamus Lee [Mon, 8 Jun 2020 00:39:39 +0000 (10:39 +1000)]
Merge pull request #17541 from seamuslee001/dev_core_560_third_to_last

dev/core#560 Replace deprecated CRM_Core_Erorr::fatal with Exceptions…

4 years agodev/core#560 Replace deprecated CRM_Core_Erorr::fatal with Exceptions or status bounc...
Seamus Lee [Sun, 7 Jun 2020 23:33:47 +0000 (09:33 +1000)]
dev/core#560 Replace deprecated CRM_Core_Erorr::fatal with Exceptions or status bounces as appropriate

4 years agoAPIv4 - filter getActions results based on user permissions
Coleman Watts [Sun, 7 Jun 2020 23:11:46 +0000 (19:11 -0400)]
APIv4 - filter getActions results based on user permissions

4 years agoReplace calls to fatal with statusBounces
eileen [Sun, 7 Jun 2020 23:11:38 +0000 (11:11 +1200)]
Replace calls to fatal with statusBounces

4 years agoMerge pull request #17511 from mattwire/paymentprocessoraddfrontendfunctions
Eileen McNaughton [Sun, 7 Jun 2020 22:56:28 +0000 (10:56 +1200)]
Merge pull request #17511 from mattwire/paymentprocessoraddfrontendfunctions

Add isBackOffice, isPayLater, getPaymentMode helpers to frontendpaymentformtrait

4 years agoMerge pull request #17534 from eileenmcnaughton/fatal2
Eileen McNaughton [Sun, 7 Jun 2020 22:53:04 +0000 (10:53 +1200)]
Merge pull request #17534 from eileenmcnaughton/fatal2

Remove instances of fatal from upgrade folder

4 years agoEarlier.day test
Sandor Semsey [Sun, 7 Jun 2020 19:14:58 +0000 (21:14 +0200)]
Earlier.day test

4 years agoMerge pull request #17535 from eileenmcnaughton/gone
Seamus Lee [Sun, 7 Jun 2020 10:55:33 +0000 (20:55 +1000)]
Merge pull request #17535 from eileenmcnaughton/gone

Remove unused deprecated class

4 years agoMerge pull request #17528 from seamuslee001/nfv_apiv3_mem_type_apiv4_test
Seamus Lee [Sun, 7 Jun 2020 10:55:13 +0000 (20:55 +1000)]
Merge pull request #17528 from seamuslee001/nfv_apiv3_mem_type_apiv4_test

[NFC] Update existing APIv3 MembershipType Tests to also test against…

4 years agoMerge pull request #17536 from eileenmcnaughton/fatal3
Seamus Lee [Sun, 7 Jun 2020 10:50:44 +0000 (20:50 +1000)]
Merge pull request #17536 from eileenmcnaughton/fatal3

[Ref] Remove some instances of fatal in BAO classes

4 years agoMerge pull request #17538 from civicrm/5.27
Seamus Lee [Sun, 7 Jun 2020 09:43:24 +0000 (19:43 +1000)]
Merge pull request #17538 from civicrm/5.27

5.27

4 years agoMerge pull request #17502 from eileenmcnaughton/first
Seamus Lee [Sun, 7 Jun 2020 06:27:23 +0000 (16:27 +1000)]
Merge pull request #17502 from eileenmcnaughton/first

Fix probably-unused core payment processors to throw extensions

4 years agoMerge pull request #17532 from totten/5.27-queue-test
Seamus Lee [Sun, 7 Jun 2020 06:12:20 +0000 (16:12 +1000)]
Merge pull request #17532 from totten/5.27-queue-test

QueueTest - Be more forgiving about slow execution

4 years agoMerge pull request #17510 from mattwire/paymentprocessorinstrumentnotrequired
Eileen McNaughton [Sun, 7 Jun 2020 05:44:45 +0000 (17:44 +1200)]
Merge pull request #17510 from mattwire/paymentprocessorinstrumentnotrequired

Payment instrument ID is not required at processorform level

4 years ago[Ref] Remove some instances of fatal in BAO classes
eileen [Sun, 7 Jun 2020 05:24:03 +0000 (17:24 +1200)]
[Ref] Remove some instances of fatal in BAO classes

4 years agoRemove unused deprecated class
eileen [Sun, 7 Jun 2020 05:10:30 +0000 (17:10 +1200)]
Remove unused deprecated class

4 years agoRemove instances of fatal from upgrade folder
eileen [Sun, 7 Jun 2020 05:06:38 +0000 (17:06 +1200)]
Remove instances of fatal from upgrade folder

4 years agoQueueTest - Be more forgiving about slow execution
Tim Otten [Sun, 7 Jun 2020 04:29:17 +0000 (21:29 -0700)]
QueueTest - Be more forgiving about slow execution

The `CRM_Queue_QueueTest` is producing failures with the
[TIME_FUNC](https://github.com/civicrm/civicrm-core/pull/17414) option of
`linear:500` (the value currently used in PR test runs) -- which is to say,
it fails when the system runs very slowly (with some 500ms stalling during
execution).

This gets it working under some very slow scenarios:

```
for TIME_FUNC in natural frozen linear:500 linear:1250 prng:500 prng:666 prng:1000 prng:1500 ; do
  export TIME_FUNC;
  echo;
  echo "TIME_FUNC=$TIME_FUNC" ;
  env CIVICRM_UF=UnitTests phpunit6 tests/phpunit/CRM/Queue/QueueTest.php ;
done
```

4 years agoMerge pull request #17530 from civicrm/5.27
Seamus Lee [Sun, 7 Jun 2020 03:51:35 +0000 (13:51 +1000)]
Merge pull request #17530 from civicrm/5.27

5.27

4 years agoMerge pull request #17527 from colemanw/nameAndIcon
Seamus Lee [Sun, 7 Jun 2020 02:04:26 +0000 (12:04 +1000)]
Merge pull request #17527 from colemanw/nameAndIcon

Add titles and icons to entities

4 years agoMerge pull request #17360 from totten/master-wp-var
Seamus Lee [Sun, 7 Jun 2020 02:01:55 +0000 (12:01 +1000)]
Merge pull request #17360 from totten/master-wp-var

WP - Change definitions of `cms.root`, `civicrm.root`

4 years agoMerge pull request #17529 from totten/5.27-comm-msg
Seamus Lee [Sun, 7 Jun 2020 01:01:04 +0000 (11:01 +1000)]
Merge pull request #17529 from totten/5.27-comm-msg

CommunityMessages - Define more consistent behavior in the face of slow execution

4 years agoCommunityMessages - Define more consistent behavior in the face of slow execution
Tim Otten [Sat, 6 Jun 2020 22:21:01 +0000 (15:21 -0700)]
CommunityMessages - Define more consistent behavior in the face of slow execution

This passes under some brutally slow scenarios:

```
for TIME_FUNC in natural frozen linear:500 linear:1250 prng:500 prng:666 prng:1000 prng:1500 ; do
  export TIME_FUNC;
  echo;
  echo "TIME_FUNC=$TIME_FUNC" ;
  env CIVICRM_UF=UnitTests phpunit6 tests/phpunit/CRM/Core/CommunityMessagesTest.php ;
done
```

4 years ago[NFC] Update existing APIv3 MembershipType Tests to also test against APIv4 as approp...
Seamus Lee [Sat, 6 Jun 2020 22:34:17 +0000 (08:34 +1000)]
[NFC] Update existing APIv3 MembershipType Tests to also test against APIv4 as appropriate

4 years agoAdd titles and icons to entities
Coleman Watts [Sat, 6 Jun 2020 20:43:21 +0000 (16:43 -0400)]
Add titles and icons to entities

4 years agoRemove a warning from logs as this triggers everytime the function is called whether...
Matthew Wire [Fri, 5 Jun 2020 09:17:50 +0000 (10:17 +0100)]
Remove a warning from logs as this triggers everytime the function is called whether or not legacy params are actually merged

4 years agoAdd isBackOffice, isPayLater, getPaymentMode helpers to frontendpaymentformtrait
Matthew Wire [Fri, 5 Jun 2020 09:45:29 +0000 (10:45 +0100)]
Add isBackOffice, isPayLater, getPaymentMode helpers to frontendpaymentformtrait

4 years agoEarlier.day test
Sandor Semsey [Sat, 6 Jun 2020 13:00:44 +0000 (15:00 +0200)]
Earlier.day test

4 years agoEarlier.day test
Sandor Semsey [Sat, 6 Jun 2020 12:57:16 +0000 (14:57 +0200)]
Earlier.day test

4 years agoZip code range search only supports numeric zip codes so don't try and search if...
Matthew Wire [Sat, 6 Jun 2020 11:46:07 +0000 (12:46 +0100)]
Zip code range search only supports numeric zip codes so don't try and search if values are not numeric

4 years agoSet version to 5.28.alpha1
CiviCRM [Sat, 6 Jun 2020 07:45:49 +0000 (07:45 +0000)]
Set version to 5.28.alpha1

4 years agoSet version to 5.27.beta1
CiviCRM [Sat, 6 Jun 2020 07:40:15 +0000 (07:40 +0000)]
Set version to 5.27.beta1

4 years agoMerge pull request #17521 from seamuslee001/master
Tim Otten [Sat, 6 Jun 2020 07:39:32 +0000 (00:39 -0700)]
Merge pull request #17521 from seamuslee001/master

Add release-notes/5.26.1.md

4 years agoUpdate release-notes.md
Tim Otten [Sat, 6 Jun 2020 07:04:55 +0000 (00:04 -0700)]
Update release-notes.md

4 years agoAdd release-notes/5.26.1.md
Tim Otten [Sat, 6 Jun 2020 00:54:38 +0000 (17:54 -0700)]
Add release-notes/5.26.1.md

4 years agoMerge pull request #17518 from totten/master-mysql-notice
Seamus Lee [Sat, 6 Jun 2020 04:03:31 +0000 (14:03 +1000)]
Merge pull request #17518 from totten/master-mysql-notice

dev/core#1681 - Copy-edits on MySQL version notices

4 years agodev/core#1681 - Copy-edits on MySQL version notices
Tim Otten [Sat, 6 Jun 2020 02:01:22 +0000 (19:01 -0700)]
dev/core#1681 - Copy-edits on MySQL version notices

* The titles for PHP+MySQL notices should use the same
  capitalization/hyphenation ("Out-of-Date" vs "Out of date").
* Extract some more "%n" variables. Fix one errant variable.
* Reduce floweriness of the "version" / "at least" / "or later" text.
* Make it possible to add/remove the "+" notation without changing
  the ts() message.

4 years agoMerge pull request #17452 from eileenmcnaughton/dummy_bag
Tim Otten [Sat, 6 Jun 2020 00:22:55 +0000 (17:22 -0700)]
Merge pull request #17452 from eileenmcnaughton/dummy_bag

[REF] Start to convert Dummy processor to use PropertyBag

4 years agofix for end-of-yesterday
Sandor Semsey [Fri, 5 Jun 2020 15:19:34 +0000 (17:19 +0200)]
fix for end-of-yesterday

4 years agoMerge pull request #17505 from mattwire/propertybagfixsetamount
Seamus Lee [Fri, 5 Jun 2020 10:51:12 +0000 (20:51 +1000)]
Merge pull request #17505 from mattwire/propertybagfixsetamount

Payment PropertyBag - Fix setAmount

4 years agoPayment instrument ID is not required at processorform level
Matthew Wire [Fri, 5 Jun 2020 09:42:04 +0000 (10:42 +0100)]
Payment instrument ID is not required at processorform level

4 years agoFix setAmount to set the right amount on payment propertybag
Matthew Wire [Fri, 5 Jun 2020 09:19:44 +0000 (10:19 +0100)]
Fix setAmount to set the right amount on payment propertybag

4 years agoMerge pull request #17496 from seamuslee001/mysql_upgrade_notice
Seamus Lee [Fri, 5 Jun 2020 09:05:34 +0000 (19:05 +1000)]
Merge pull request #17496 from seamuslee001/mysql_upgrade_notice

dev/core#1681 Add in notice about 5.28 Dropping MySQL 5.5 Support

4 years ago[REF] Remove handling for 2 fields not on the form
eileen [Fri, 5 Jun 2020 05:38:09 +0000 (17:38 +1200)]
[REF] Remove handling for 2 fields not on the form

Neither membership_source or campaign_id are fields on the renewal form. The handling is left over from
code for other forms. This tidies it up

4 years agoMerge pull request #17489 from eileenmcnaughton/mod
Seamus Lee [Fri, 5 Jun 2020 05:22:10 +0000 (15:22 +1000)]
Merge pull request #17489 from eileenmcnaughton/mod

[REF] Remove always NULL param modified_id

4 years agoConvert Authorize.net doDirectPayment to use guzzle & add test
eileen [Fri, 5 Jun 2020 01:48:11 +0000 (13:48 +1200)]
Convert Authorize.net doDirectPayment to use guzzle & add test

This brings the main Authorize.net payment function under testing, putting us in a better position to bring it
into line with more recommended coding practices.

Note the trick to writing tests for Guzzle is to first add the lines

```
    $this->setUpClientWithHistoryContainer();
    $this->processor->setGuzzleClient($this->getGuzzleClient());
... do the stuff

   $responses = $this->getResponseBodies();
   $requests = $this->getRequestBodies();
```

That allows you to capture the outgoing & incoming responses that form the expectations.
Obviously some credential wrangling is needed to get an OK response but it's also possible
with some processors (e.g ones that are basically done for) to just worry about ensuring
the outgoing is captured

4 years agodev/core#1681 Add in notice about 5.28 Dropping MySQL 5.5 Support
Seamus Lee [Thu, 4 Jun 2020 23:19:01 +0000 (09:19 +1000)]
dev/core#1681 Add in notice about 5.28 Dropping MySQL 5.5 Support

4 years agoFix probably-unused core payment processors to throw extensions
eileen [Fri, 5 Jun 2020 02:23:02 +0000 (14:23 +1200)]
Fix probably-unused core payment processors to throw extensions

These 2 processors are probably entirely unused and are not enabled on new installs. However, as they are still in core,
and removing them will take a plan + time, we should have them model 'good behaviour' - ie throwing exceptions
rather than returning errors

4 years agoMerge pull request #17497 from seamuslee001/dev_core_1797
Eileen McNaughton [Fri, 5 Jun 2020 04:58:51 +0000 (16:58 +1200)]
Merge pull request #17497 from seamuslee001/dev_core_1797

dev/core#1797 Fix jquery Credit card validation on front end contribu…

4 years ago[Ref] Throw exceptions from Authorize.net rather than return errors
eileen [Fri, 5 Jun 2020 01:02:48 +0000 (13:02 +1200)]
[Ref] Throw exceptions from Authorize.net rather than return errors

This is part of 'modelling good behaviour' - curently doPayment converts the errors to thrown exceptions,
but the recommendation is that the payment processor functions should throw exceptions themselves.
If they do they willl bypass the doPayment handling, but acheive the same thing

4 years agoMerge pull request #17448 from mattwire/api4membershiptype
Eileen McNaughton [Thu, 4 Jun 2020 23:55:50 +0000 (11:55 +1200)]
Merge pull request #17448 from mattwire/api4membershiptype

Add MembershipType to Api4