Eileen McNaughton [Wed, 15 Mar 2023 22:04:42 +0000 (11:04 +1300)]
Create getter for renewalMembershipID, remove if
Eileen McNaughton [Wed, 15 Mar 2023 21:21:48 +0000 (10:21 +1300)]
Merge pull request #25828 from braders/php8.2-summary-contact-edit-options
[REF][PHP8.2] Don't use a property where a variable will do (CRM_Contact_Page_View_Summary)
Eileen McNaughton [Wed, 15 Mar 2023 20:34:46 +0000 (09:34 +1300)]
Merge pull request #25782 from anemirovsky/fix-profile-listing-column-blank
Fix profile search listings columns are sometimes blank.
Bradley Taylor [Wed, 15 Mar 2023 20:04:35 +0000 (20:04 +0000)]
[REF][PHP8.2] Don't use a property where a variable will do (CRM_Contact_Page_View_Summary)
Eileen McNaughton [Wed, 15 Mar 2023 19:18:12 +0000 (08:18 +1300)]
Merge pull request #25825 from civicrm/5.60
5.60 to master
Eileen McNaughton [Wed, 15 Mar 2023 19:15:05 +0000 (08:15 +1300)]
Merge pull request #25806 from mlutfy/core4166rc
dev/core#4166 Fix Contribute Import Parser fatal when soft-credit is empty
Mathieu Lutfy [Tue, 14 Mar 2023 00:59:29 +0000 (20:59 -0400)]
dev/core#4166 Fix Contribute Import Parser fatal when soft-credit is empty
Eileen McNaughton [Wed, 15 Mar 2023 06:54:18 +0000 (19:54 +1300)]
Merge pull request #25790 from braders/php82-conformance-test-failures
[REF][PHP8.2] Only set properties which exist within ArrayFormatTrait->loadArray()
Eileen McNaughton [Wed, 15 Mar 2023 06:52:44 +0000 (19:52 +1300)]
Merge pull request #25820 from eileenmcnaughton/sql_cache
Do not report missing triggers if the user cannot check them
demeritcowboy [Wed, 15 Mar 2023 06:24:02 +0000 (02:24 -0400)]
Merge pull request #25687 from yashodha/dev-4124
(dev/core#4124) Past campaigns are not to be assigned via batch updat…
Eileen McNaughton [Wed, 15 Mar 2023 06:00:41 +0000 (19:00 +1300)]
Remove the word 'Experimental' from setting that has been in prod for 7 years
Eileen McNaughton [Wed, 15 Mar 2023 05:58:00 +0000 (18:58 +1300)]
Do not report missing triggers if the user cannot check them
Eileen McNaughton [Wed, 15 Mar 2023 04:02:59 +0000 (17:02 +1300)]
Merge pull request #25817 from eileenmcnaughton/import_url
Fix typo that causes e-notice in just-merged commit
Eileen McNaughton [Wed, 15 Mar 2023 04:01:49 +0000 (17:01 +1300)]
Fix typo that causes e-notice in just-merged commit
Tim Otten [Wed, 15 Mar 2023 02:14:36 +0000 (19:14 -0700)]
Merge pull request #25802 from eileenmcnaughton/delete_message
[PHP8.2] declare deleteMessage on `entityFormTrait`
Eileen McNaughton [Wed, 15 Mar 2023 02:04:15 +0000 (15:04 +1300)]
Merge pull request #25816 from eileenmcnaughton/import_sk
Add links to search kits to import preview screen, when Civ-Import is enabled
Eileen McNaughton [Wed, 15 Mar 2023 01:29:34 +0000 (14:29 +1300)]
Merge pull request #25815 from civicrm/5.60
Merge 5.60 to master
Eileen McNaughton [Wed, 15 Mar 2023 01:29:16 +0000 (14:29 +1300)]
Merge pull request #25810 from eileenmcnaughton/import_subscriber
dev/core#4184 Fix Import over-authorization
Eileen McNaughton [Wed, 15 Mar 2023 01:03:25 +0000 (14:03 +1300)]
Update CRM/Core/Form/EntityFormTrait.php
Co-authored-by: Tim Otten <totten@civicrm.org>
Eileen McNaughton [Wed, 15 Mar 2023 00:53:34 +0000 (13:53 +1300)]
Add links to search kits to preview screen
Eileen McNaughton [Tue, 14 Mar 2023 20:08:27 +0000 (09:08 +1300)]
dev/core#4184 Fix Import over-authorization
Tim Otten [Wed, 15 Mar 2023 00:26:42 +0000 (17:26 -0700)]
Merge pull request #25759 from eileenmcnaughton/import_notice
Fix really annoying notice on mispelt variable name `$isCheked`
Tim Otten [Tue, 14 Mar 2023 23:52:11 +0000 (16:52 -0700)]
Merge pull request #25814 from seamuslee001/fix_false_ipn_log_paypal
[REF] Fix issue where the strict typing was causing false notices to …
Eileen McNaughton [Tue, 14 Mar 2023 23:06:34 +0000 (12:06 +1300)]
Merge pull request #25813 from samuelsov/5.60
dev/core#4186 regression for Contact Reference Autocomplete
Eileen McNaughton [Tue, 14 Mar 2023 23:05:58 +0000 (12:05 +1300)]
Merge pull request #25812 from braders/remove-unused-param
[PHP8.2] (Ref) Remove unused dynamic property in report form class
Seamus Lee [Tue, 14 Mar 2023 22:39:37 +0000 (09:39 +1100)]
[REF] Fix issue where the strict typing was causing false notices to appear in Config And Log
Samuel Vanhove [Tue, 14 Mar 2023 21:27:24 +0000 (17:27 -0400)]
dev/core#4186 regression for Contact Reference Autocomplete
Bradley Taylor [Tue, 14 Mar 2023 21:19:40 +0000 (21:19 +0000)]
(Ref) Remove unused dynamic property in report form class
Eileen McNaughton [Tue, 14 Mar 2023 20:29:12 +0000 (09:29 +1300)]
Merge pull request #25736 from MegaphoneJon/remove-usps-warning
don't show USPS warning when USPS lookup disabled
Eileen McNaughton [Tue, 14 Mar 2023 20:26:48 +0000 (09:26 +1300)]
Merge pull request #25809 from braders/php-8.2-CaseContactTest
[REF][PHP8.2] Tidy up properties in api_v3_CaseContactTest
Eileen McNaughton [Tue, 14 Mar 2023 19:57:57 +0000 (08:57 +1300)]
Merge pull request #25738 from MegaphoneJon/required-field-separator
field separator is a required field
colemanw [Tue, 14 Mar 2023 19:56:24 +0000 (15:56 -0400)]
Merge pull request #25787 from eileenmcnaughton/import_use_uploaded
Import data source Re-use already uploaded data, optionally on use of 'back' button
Bradley Taylor [Tue, 14 Mar 2023 19:53:00 +0000 (19:53 +0000)]
[REF][PHP8.2] Tidy up properties in api_v3_CaseContactTest
demeritcowboy [Tue, 14 Mar 2023 04:42:45 +0000 (00:42 -0400)]
Merge pull request #25805 from mlutfy/homeBreadcrumb
Logging ReportDetail: update breadcrumb to use CiviCRM Home for disambiguation
Mathieu Lutfy [Mon, 13 Mar 2023 17:26:46 +0000 (13:26 -0400)]
Logging ReportDetail: update breadcrumb to use CiviCRM Home for disambiguation with the Home location type translation
demeritcowboy [Mon, 13 Mar 2023 22:59:52 +0000 (18:59 -0400)]
Merge pull request #25803 from mattwire/casedates
Case start_date/end_date are not datetime
Eileen McNaughton [Mon, 13 Mar 2023 21:56:59 +0000 (10:56 +1300)]
Merge pull request #25804 from colemanw/contributionRecurAutocomplete
APIv4 - Autocomplete ContributionRecur entity
Matthew Wire [Mon, 13 Mar 2023 09:43:44 +0000 (09:43 +0000)]
Fix startdate/enddate schema for case DAO - they are date only
Seamus Lee [Mon, 13 Mar 2023 20:46:06 +0000 (07:46 +1100)]
Merge pull request #25796 from demeritcowboy/cachetest
Remove dependence on cache/integration-tests
colemanw [Mon, 13 Mar 2023 15:32:25 +0000 (11:32 -0400)]
Merge pull request #24819 from colemanw/searchKitHelp
SearchKit - POC help text
shaneonabike [Mon, 13 Mar 2023 15:30:12 +0000 (11:30 -0400)]
SearchKit - Add help text
Coleman Watts [Tue, 25 Oct 2022 22:49:39 +0000 (18:49 -0400)]
SearchKit - POC help text
Coleman Watts [Mon, 13 Mar 2023 15:02:22 +0000 (11:02 -0400)]
APIv4 - Autocomplete ContributionRecur entity
colemanw [Mon, 13 Mar 2023 14:23:56 +0000 (10:23 -0400)]
Merge pull request #25742 from colemanw/searchContainer
Afform - Fix editing search filters nested within multiple containers
Eileen McNaughton [Mon, 13 Mar 2023 06:24:25 +0000 (19:24 +1300)]
Merge pull request #25800 from eileenmcnaughton/82_sql
Php8.2 fixes in report `addToDeveloperTab` function
Eileen McNaughton [Sun, 12 Mar 2023 23:10:27 +0000 (12:10 +1300)]
Php8.2 fixes in report addToDeveloperTab function
Eileen McNaughton [Mon, 13 Mar 2023 00:10:12 +0000 (13:10 +1300)]
Php8.2 declare deleteMessage on entityFormTrait
Php8.2 declare deleteMessage on the EntityFormTrait
demeritcowboy [Sun, 12 Mar 2023 23:54:51 +0000 (19:54 -0400)]
Merge pull request #25797 from eileenmcnaughton/php82
Php8.2 fixes in unit tests
Seamus Lee [Sun, 12 Mar 2023 22:58:41 +0000 (09:58 +1100)]
Merge pull request #25798 from eileenmcnaughton/php82-2
[NFC] cleanup in `ChangeFeeSelectionTest`
Eileen McNaughton [Sun, 12 Mar 2023 22:46:46 +0000 (11:46 +1300)]
Php8.2 fix in test
Eileen McNaughton [Sun, 12 Mar 2023 22:10:34 +0000 (11:10 +1300)]
[NFC] cleanup in ChangeFeeSelectionTest
demeritcowboy [Sun, 12 Mar 2023 20:48:48 +0000 (16:48 -0400)]
remove dependence on cache/integration-tests
Eileen McNaughton [Sun, 12 Mar 2023 20:55:16 +0000 (09:55 +1300)]
Merge pull request #25795 from braders/pageparams
[REF][PHP8.2] Refactor use of pageParams properties
Eileen McNaughton [Sun, 12 Mar 2023 20:35:17 +0000 (09:35 +1300)]
Merge pull request #25792 from braders/php82-imtest
[REF][PHP8.2] Refactor api_v3_ImTest with primary aim of improving PHP 8.2 compatiability
Eileen McNaughton [Sun, 12 Mar 2023 20:30:50 +0000 (09:30 +1300)]
Merge pull request #25793 from braders/PriceFieldValueTest
[REF][PHP8.2] Refactor api_v3_PriceFieldValueTest with primary aim of improving PHP 8.2 compatiability
Eileen McNaughton [Sun, 12 Mar 2023 20:25:00 +0000 (09:25 +1300)]
Merge pull request #25794 from braders/unused-onpopupclose
(REF) Remove unused onPopupClose variables
Eileen McNaughton [Sun, 12 Mar 2023 20:18:47 +0000 (09:18 +1300)]
Merge pull request #25791 from braders/deprecated-self-callables-dedupe
[REF][PHP8.2] Fix use of self in callables deprecation
Bradley Taylor [Sun, 12 Mar 2023 18:07:14 +0000 (18:07 +0000)]
[REF][PHP8.2] Refactor use of pageParams properties
Bradley Taylor [Sun, 12 Mar 2023 16:45:27 +0000 (16:45 +0000)]
Remove unused onPopupClose variables
Bradley Taylor [Sun, 12 Mar 2023 10:55:47 +0000 (10:55 +0000)]
[REF][PHP8.2] Refactor api_v3_PriceFieldValueTest with primary aim of improving PHP 8.2 compatiability
Bradley Taylor [Sun, 12 Mar 2023 10:35:02 +0000 (10:35 +0000)]
[REF][PHP8.2] Refactor api_v3_ImTest with primary aim of improving PHP 8.2 compatiability
Bradley Taylor [Sun, 12 Mar 2023 10:18:27 +0000 (10:18 +0000)]
[REF][PHP8.2] Fix use of self in callables deprecation
Eileen McNaughton [Sun, 12 Mar 2023 02:15:55 +0000 (15:15 +1300)]
Merge pull request #25786 from totten/master-setver-warning
set-version.php - Fix warning on PHP 8.1
Seamus Lee [Sat, 11 Mar 2023 23:21:58 +0000 (10:21 +1100)]
Merge pull request #25788 from braders/errortest-php82
[REF][PHP8.2] Declare property on CRM_Core_ErrorTest
Seamus Lee [Sat, 11 Mar 2023 23:21:47 +0000 (10:21 +1100)]
Merge pull request #25789 from braders/participantTest-dynamic-property
[REF][PHP8.2] Declare property on CRM_Event_Import_Parser_ParticipantTest
Bradley Taylor [Sat, 11 Mar 2023 11:42:07 +0000 (11:42 +0000)]
[REF][PHP8.2] Only set properties which exist within ArrayFormatTrait->loadArray
Bradley Taylor [Sat, 11 Mar 2023 11:20:44 +0000 (11:20 +0000)]
[REF][PHP8.2] Declare property on CRM_Event_Import_Parser_ParticipantTest
Bradley Taylor [Sat, 11 Mar 2023 11:17:10 +0000 (11:17 +0000)]
[REF][PHP8.2] Declare property on CRM_Core_ErrorTest
Eileen McNaughton [Sat, 11 Mar 2023 03:06:23 +0000 (16:06 +1300)]
Import data source Re-use already uploaded data, optionally on 'back'
Without this patch a user who uses the 'back' button must re-upload
the csv / sql they just uploaded....
Eileen McNaughton [Sat, 11 Mar 2023 03:31:11 +0000 (16:31 +1300)]
Merge pull request #25657 from eileenmcnaughton/dynamic
dev/core#4144 Fix smarty notice on isDuplicate
Eileen McNaughton [Sat, 11 Mar 2023 02:11:02 +0000 (15:11 +1300)]
Merge pull request #16 from lemniscus/smarty-notices-profile-dynamic
fix notice in non-dialog mode too, make var name clearer, fix another notice
Noah Miller [Sat, 11 Mar 2023 00:59:23 +0000 (19:59 -0500)]
eliminate notice in non-dialog mode too, make var name clearer, fix another couple notices
Tim Otten [Sat, 11 Mar 2023 00:32:09 +0000 (16:32 -0800)]
set-version.php - Fix warning on PHP 8.1
The `$sqlFile` may or may not be needed, which produces a warning:
```
Deprecated: file_exists(): Passing null to parameter #1 ($filename) of type string is deprecated in
/.../tools/bin/scripts/set-version.php on line 105
```
Eileen McNaughton [Fri, 10 Mar 2023 22:38:15 +0000 (11:38 +1300)]
Merge pull request #25781 from colemanw/deprecateConstants
APIv4 - Deprecate unnecessary constants
Eileen McNaughton [Fri, 10 Mar 2023 22:01:47 +0000 (11:01 +1300)]
Merge pull request #25783 from seamuslee001/php82_mailing_contact
[NFC] Fix PHP8.2 issues in the Mailing Contact Test
Seamus Lee [Fri, 10 Mar 2023 20:55:20 +0000 (07:55 +1100)]
[NFC] Fix PHP8.2 issues in the Mailing Contact Test
anemirovsky [Fri, 10 Mar 2023 20:48:19 +0000 (12:48 -0800)]
Fix profile search listings columns are sometimes blank.
The bug is that the query results have the column names formatted like
[location_type_machine_name]-[field_name], like "Work-email", while the
code that handles rendering the row is looking for
[location_type_display_name]-[field_name], like "Office_1-email". I've
adjusted the code that handles rendering the row to instead use the
machine name rather than the display name for the location type.
This only becomes an issue if the location type display name has been
changed from the default so it no longer matches the internal machine
name.
Coleman Watts [Fri, 10 Mar 2023 20:25:46 +0000 (15:25 -0500)]
APIv4 - Deprecate unnecessary constants
Tim Otten [Fri, 10 Mar 2023 08:32:26 +0000 (00:32 -0800)]
Merge pull request #25778 from eileenmcnaughton/560
dev/core#4156 Fix failure to update organization_name on employees during merge
Eileen McNaughton [Fri, 10 Mar 2023 04:06:06 +0000 (17:06 +1300)]
Merge pull request #25774 from eileenmcnaughton/import_cache
Fix cache clearing when import table is changed
Eileen McNaughton [Thu, 9 Mar 2023 04:31:35 +0000 (17:31 +1300)]
Fix cache clearing when import table is changed
Eileen McNaughton [Fri, 10 Mar 2023 00:13:01 +0000 (13:13 +1300)]
dev/core#4156 Fix failure to update organization_name on employees during merge
Eileen McNaughton [Fri, 10 Mar 2023 01:07:46 +0000 (14:07 +1300)]
Merge pull request #25527 from eileenmcnaughton/finder_build
Fix dedupe finder performance issue on looking up table size
Eileen McNaughton [Fri, 10 Mar 2023 01:07:31 +0000 (14:07 +1300)]
Merge pull request #25712 from eileenmcnaughton/import_link
Import link - fix search Import SearchDisplays to link to the created contact
colemanw [Fri, 10 Mar 2023 00:27:30 +0000 (19:27 -0500)]
Merge pull request #25474 from eileenmcnaughton/civi-import
Hyphenate Civi-Import in the title/label
Coleman Watts [Thu, 9 Mar 2023 23:46:41 +0000 (18:46 -0500)]
Civi-Import Add fk joinable to api spec
Tim Otten [Thu, 9 Mar 2023 23:30:32 +0000 (15:30 -0800)]
Merge pull request #25775 from eileenmcnaughton/payapl
dev/core#4158 Fix for recurring double ups
Eileen McNaughton [Thu, 9 Mar 2023 22:53:48 +0000 (11:53 +1300)]
Merge pull request #25187 from totten/master-civiunit-more
CiviUnitTestCase - More aggressive simplifications
Eileen McNaughton [Thu, 9 Mar 2023 22:45:57 +0000 (11:45 +1300)]
Merge pull request #25677 from colemanw/noisyDeprecate
BAO - Noisily deprecate and stop using deprecated functions
Tim Otten [Thu, 9 Mar 2023 22:31:28 +0000 (14:31 -0800)]
Merge pull request #25749 from eileenmcnaughton/retreive
[REF] Improve function signature for `retrieve()` in `PaypalProIPN` , add test for when trxn_id is present
Eileen McNaughton [Thu, 9 Mar 2023 22:22:50 +0000 (11:22 +1300)]
dev/core#4158 Fix for recurring double ups
Coleman Watts [Mon, 27 Feb 2023 22:13:33 +0000 (17:13 -0500)]
BAO - Noisily deprecate and stop using deprecated functions
Eileen McNaughton [Thu, 9 Mar 2023 20:30:40 +0000 (09:30 +1300)]
Merge pull request #25770 from colemanw/replaceWithMatch
APIv4 - Support `match` in replaceAction
Eileen McNaughton [Thu, 9 Mar 2023 20:26:55 +0000 (09:26 +1300)]
Merge pull request #25768 from eileenmcnaughton/dep2
Remove function deprecated noisly in 2020
colemanw [Thu, 9 Mar 2023 17:18:45 +0000 (12:18 -0500)]
Merge pull request #25028 from MegaphoneJon/bad-pseudoconstants-api4
Don't crash API4 if pseudoconstant lookups return nothing
colemanw [Thu, 9 Mar 2023 16:14:52 +0000 (11:14 -0500)]
Merge pull request #25773 from colemanw/allYourBase
All your base are deleted
Coleman Watts [Thu, 9 Mar 2023 14:08:10 +0000 (09:08 -0500)]
All your base are deleted
colemanw [Thu, 9 Mar 2023 13:35:01 +0000 (08:35 -0500)]
Merge pull request #25767 from eileenmcnaughton/dep
More deprecations of `del`
Yashodha Chaku [Thu, 9 Mar 2023 06:36:33 +0000 (12:06 +0530)]
Merge pull request #25771 from eileenmcnaughton/datasource
Consolidate `DataSource.tpl`
Eileen McNaughton [Thu, 9 Mar 2023 06:26:00 +0000 (19:26 +1300)]
Merge pull request #25772 from lemniscus/smarty-notice-merge
Smarty notice fix on Merge