Mathieu Lutfy [Mon, 27 Mar 2023 16:08:57 +0000 (12:08 -0400)]
Log sending of Scheduled Reminders
They are a pain to debug when they fail because of errors with smarty or tokens
Matthew Wire [Mon, 27 Mar 2023 15:38:03 +0000 (16:38 +0100)]
Merge pull request #25408 from artfulrobot/artfulrobot-speedup-searchkit
Speed up SearchKit results loading by 800ms
Matthew Wire [Mon, 27 Mar 2023 11:14:04 +0000 (12:14 +0100)]
Merge pull request #25754 from eileenmcnaughton/quick_config
Extract `isMembershipPriceSet` (`useForMember`)
Matthew Wire [Mon, 27 Mar 2023 11:10:20 +0000 (12:10 +0100)]
Merge pull request #25929 from eileenmcnaughton/mem_test_nfc
Add unit test cover for test offline mail receipt
Matthew Wire [Mon, 27 Mar 2023 11:07:44 +0000 (12:07 +0100)]
Merge pull request #25907 from eileenmcnaughton/url
Fix import contribution url
Matthew Wire [Mon, 27 Mar 2023 11:06:44 +0000 (12:06 +0100)]
Merge pull request #25833 from eileenmcnaughton/mid
[php8.2] Create getter for `renewalMembershipID`, remove if
Matthew Wire [Mon, 27 Mar 2023 11:05:28 +0000 (12:05 +0100)]
Merge pull request #25454 from eileenmcnaughton/grant_notice
CiviReport - Remove duplicate external identifier key in contact fields array, reduce notices
Eileen McNaughton [Mon, 27 Mar 2023 04:45:40 +0000 (17:45 +1300)]
Add unit test cover for test offline mail receipt
Seamus Lee [Mon, 27 Mar 2023 04:02:54 +0000 (15:02 +1100)]
Merge pull request #25928 from eileenmcnaughton/mem_test_nfc
[NFC] Test cleanup, prefer full form test flow
Eileen McNaughton [Mon, 27 Mar 2023 02:36:37 +0000 (15:36 +1300)]
[NFC] Test cleanup, prefer full form test flow
Seamus Lee [Sun, 26 Mar 2023 22:05:13 +0000 (09:05 +1100)]
Merge pull request #25924 from eileenmcnaughton/mem_test
Fix intermittant test fail
colemanw [Sun, 26 Mar 2023 15:11:34 +0000 (11:11 -0400)]
Merge pull request #25926 from braders/entity-form-trait-properties
[REF][PHP8.2] Declare properties directly on CRM_Core_Form_EntityFormTrait
colemanw [Sun, 26 Mar 2023 13:27:28 +0000 (09:27 -0400)]
Merge pull request #25925 from braders/membership-test-variable
[REF][PHP8.2] Convert dynamic property into a variable
Bradley Taylor [Sun, 26 Mar 2023 10:52:14 +0000 (11:52 +0100)]
[REF][PHP8.2] Declare properties directly on CRM_Core_Form_EntityFormTrait
Bradley Taylor [Sun, 26 Mar 2023 10:15:58 +0000 (11:15 +0100)]
[REF][PHP8.2] Convert dynamic property into a variable
colemanw [Sat, 25 Mar 2023 23:24:11 +0000 (19:24 -0400)]
Merge pull request #25923 from eileenmcnaughton/mem_offline
Stop passing `$this` as `$form` to previously shared, non-static, function
Eileen McNaughton [Sat, 25 Mar 2023 22:51:22 +0000 (11:51 +1300)]
Fix intermittant test fail
Eileen McNaughton [Sat, 25 Mar 2023 22:34:08 +0000 (11:34 +1300)]
Stop passing this as form to previously shared, non-static, function
Eileen McNaughton [Sat, 25 Mar 2023 21:08:01 +0000 (10:08 +1300)]
Merge pull request #25918 from mlutfy/core4204
dev/core#4204 Show the Payment Agreement of the selected processor
Eileen McNaughton [Sat, 25 Mar 2023 21:05:44 +0000 (10:05 +1300)]
Merge pull request #25921 from braders/unused-ufmatchid
[REF][PHP8.2] Remove unused dyanamic property
Bradley Taylor [Sat, 25 Mar 2023 16:15:12 +0000 (16:15 +0000)]
[REF][PHP8.2] Remove unused dyanamic property
Mathieu Lutfy [Sat, 25 Mar 2023 01:12:45 +0000 (21:12 -0400)]
dev/core#4204 Show the Payment Agreement of the selected processor
Eileen McNaughton [Sat, 25 Mar 2023 01:11:54 +0000 (14:11 +1300)]
Merge pull request #25916 from civicrm/5.60
5.60 to master
Mathieu Lu [Sat, 25 Mar 2023 00:28:33 +0000 (20:28 -0400)]
Merge pull request #25910 from eileenmcnaughton/regression_dd
dev/core#4189 Fix indiscriminate display of direct debit agreement
colemanw [Fri, 24 Mar 2023 22:50:20 +0000 (18:50 -0400)]
Merge pull request #25900 from eileenmcnaughton/import_contact_custom_bool
dev/core#3937 Remove legacy code causing custom boolean import bug
Matthew Wire [Fri, 24 Mar 2023 21:30:14 +0000 (21:30 +0000)]
Merge pull request #25913 from mlutfy/flushCacheButton
UpdateConfigBackend: use api4 to flush the cache
Mathieu Lutfy [Fri, 24 Mar 2023 19:36:26 +0000 (15:36 -0400)]
UpdateConfigBackend: use api4 to flush the cache
demeritcowboy [Fri, 24 Mar 2023 17:20:22 +0000 (13:20 -0400)]
Merge pull request #25780 from yashodha/dev-4176
(dev/core#4176) Allow to search on participant id
yashodha [Fri, 10 Mar 2023 06:37:38 +0000 (12:07 +0530)]
(dev/core#4176) Allow to search on participant id
Eileen McNaughton [Fri, 24 Mar 2023 02:43:44 +0000 (15:43 +1300)]
Merge pull request #25876 from eileenmcnaughton/custom_number
dev/core#4152 Fix custom data code to not cast to a float
Eileen McNaughton [Fri, 24 Mar 2023 01:53:36 +0000 (14:53 +1300)]
Merge pull request #25911 from eileenmcnaughton/master
5.60 to master
Eileen McNaughton [Fri, 24 Mar 2023 01:52:06 +0000 (14:52 +1300)]
Merge branch '5.60' of github.com:civicrm/civicrm-core
colemanw [Fri, 24 Mar 2023 01:40:10 +0000 (21:40 -0400)]
Merge pull request #25897 from eileenmcnaughton/import_contact_id
Fix for issue when optional contact_id is blank importing contributions
colemanw [Fri, 24 Mar 2023 01:30:43 +0000 (21:30 -0400)]
Merge pull request #25905 from colemanw/getSetApiValues
Api4 - Prevent developer error mixing up `addValue` with `addWhere`
Eileen McNaughton [Thu, 23 Mar 2023 20:17:53 +0000 (09:17 +1300)]
Fix import contribution url
Eileen McNaughton [Thu, 23 Mar 2023 23:33:14 +0000 (12:33 +1300)]
dev/core#4189 Fix indiscriminate display of direct debit agreement
Tim Otten [Thu, 23 Mar 2023 23:21:30 +0000 (16:21 -0700)]
Merge pull request #25909 from totten/5.60-vertest
(NFC) Version Check Test - Fix multi-user and concurrent execution
Eileen McNaughton [Thu, 23 Mar 2023 00:25:27 +0000 (13:25 +1300)]
dev/core#3937 Remove legacy code causing custom boolean import bug
Tim Otten [Thu, 23 Mar 2023 22:22:10 +0000 (15:22 -0700)]
(NFC) Version Check Test - Fix multi-user and concurrent execution
This is a small change to the way the tests run. It doesn't change the meaning of the test.
Before
------
* Writes example file to `/tmp/versionCheckTestFile.json`.
* File left behind at end of test.
* If two users runs the same test at different times, they could interfere with each other.
* If two processes run the same test at the same time, they could interfere with each other.
After
-----
* Writes example file to `/tmp/VersionCheck-NNNNNNN/versionCheckTestFile.json`
* Temp folder cleaned up at end
* If two users or two processes run the test, they use separate folders
Joe Murray [Thu, 23 Mar 2023 21:51:02 +0000 (17:51 -0400)]
Merge pull request #25672 from colemanw/joinStuff
Note API - Fix viewing, joining to, and updating Notes
demeritcowboy [Thu, 23 Mar 2023 16:40:14 +0000 (12:40 -0400)]
Merge pull request #25903 from colemanw/hookCleanup
Code cleanup on aisle Hook
colemanw [Thu, 23 Mar 2023 16:35:05 +0000 (12:35 -0400)]
Merge pull request #25895 from eileenmcnaughton/url
Fix recently added import url
colemanw [Thu, 23 Mar 2023 16:33:41 +0000 (12:33 -0400)]
Merge pull request #25896 from eileenmcnaughton/import_label
Show friendlier labels when Civi-Import enabled
colemanw [Thu, 23 Mar 2023 16:22:05 +0000 (12:22 -0400)]
Merge pull request #25898 from eileenmcnaughton/import_contact_custom
Fix Contact Import tests custom date testing, remove duplicate handling
Coleman Watts [Thu, 23 Mar 2023 13:05:39 +0000 (09:05 -0400)]
Api4 - Prevent developer error mixing up the `addValue` and `addWhere` functions
Coleman Watts [Thu, 23 Mar 2023 12:40:21 +0000 (08:40 -0400)]
Code cleanup on aisle CRM_Utils_Hook
colemanw [Thu, 23 Mar 2023 11:57:36 +0000 (07:57 -0400)]
Merge pull request #25902 from demeritcowboy/that
[NFC] hulk smash
demeritcowboy [Thu, 23 Mar 2023 06:05:57 +0000 (02:05 -0400)]
hulk smash
Eileen McNaughton [Thu, 23 Mar 2023 02:47:40 +0000 (15:47 +1300)]
Merge pull request #25901 from colemanw/nullObject
Deprecate CRM_Utils_Hook::$nullObject
Coleman Watts [Thu, 23 Mar 2023 01:07:17 +0000 (21:07 -0400)]
Deprecate CRM_Utils_Hook::$nullObject
Eileen McNaughton [Wed, 22 Mar 2023 22:28:25 +0000 (11:28 +1300)]
Fix Contact Import tests custom date testing, remove duplicate handling
All the code in the formatCommonData function is legacy contact
import handling for stuff that is already handled in the generic
metadata based code. This fixes the test so it is actually testing
it for contact and address custom date fields & removes
colemanw [Wed, 22 Mar 2023 12:23:36 +0000 (08:23 -0400)]
Merge pull request #25894 from eileenmcnaughton/find_protected
Add getter for dedupeRuleGroupID
colemanw [Wed, 22 Mar 2023 12:13:46 +0000 (08:13 -0400)]
Merge pull request #25874 from eileenmcnaughton/usage
Add handling of `usage` to `DAO` generator
Eileen McNaughton [Wed, 22 Mar 2023 09:22:37 +0000 (22:22 +1300)]
Fix for issue when optional contact_id is blank
Eileen McNaughton [Wed, 22 Mar 2023 04:41:11 +0000 (17:41 +1300)]
Show friendlier labels when Civi-Import enabled
Eileen McNaughton [Wed, 22 Mar 2023 03:29:54 +0000 (16:29 +1300)]
Fix recently added import url
my head hurts - every other import url follows the other
format - ie civicrm/import/contribution & is
defined in Import.xml
Consistency wishmistancy
Tim Otten [Wed, 22 Mar 2023 00:46:56 +0000 (17:46 -0700)]
Merge pull request #25887 from eileenmcnaughton/dep_dn
Remove 2021 noisily deprecated pdfCommon function
Tim Otten [Wed, 22 Mar 2023 00:30:19 +0000 (17:30 -0700)]
Merge pull request #25891 from eileenmcnaughton/map_field
[NFC] Add metadata about import jobs to `MapField` form
Eileen McNaughton [Tue, 21 Mar 2023 23:18:01 +0000 (12:18 +1300)]
Add getter for dedupeRuleGroupID
We recently declared this with protected visibility - it turns out WMF
actually references it... I figure maybe a getter is better practice so
we still can....
Seamus Lee [Tue, 21 Mar 2023 21:57:54 +0000 (08:57 +1100)]
Merge pull request #25890 from eileenmcnaughton/dep_mail_format
Remove references to deprecated `preferred_mail_format` in tests
Eileen McNaughton [Tue, 21 Mar 2023 21:19:41 +0000 (10:19 +1300)]
[NFC] Add metadata about import jobs to MapField form
This extra metadata has been part of a whole lot of PRs & somehow always
winds up in conflict or otherwise so I'm adding it by itself, wihout any usage of it.
Note that
- this brings MapField into line with DataSource
- there is nothing calling these functions as of this PR - it's just
an attempt to get the extra metadata added to the forms/ parsers without
conflict
Eileen McNaughton [Tue, 21 Mar 2023 20:51:58 +0000 (09:51 +1300)]
Remove references to deprecated preferred_mail_format in tests
Eileen McNaughton [Tue, 21 Mar 2023 19:46:24 +0000 (08:46 +1300)]
Merge pull request #25889 from braders/remove-unused-print-property
[REF][PHP8.2] Remove property which is no longer used
Bradley Taylor [Tue, 21 Mar 2023 18:22:27 +0000 (18:22 +0000)]
[REF][PHP8.2] Remove property which is no longer used
Eileen McNaughton [Tue, 21 Mar 2023 06:24:24 +0000 (19:24 +1300)]
Remove 2021 noisily deprecated pdfCommon functions
Eileen McNaughton [Tue, 21 Mar 2023 06:15:47 +0000 (19:15 +1300)]
Merge pull request #25885 from totten/master-cache-unique
civicrm_cache - Replace wonky index
Tim Otten [Tue, 21 Mar 2023 04:55:38 +0000 (21:55 -0700)]
civicrm_cache - Add index on `expired_date`
Tim Otten [Tue, 21 Mar 2023 01:49:28 +0000 (18:49 -0700)]
Upgrader - Dedupe caches. Failsafe to ensure ugprade runs.
Tim Otten [Tue, 21 Mar 2023 00:57:02 +0000 (17:57 -0700)]
civicrm_cache - Replace wonky idx (group,path,date) with sensible idx (group,path)
Note: On the PR, I'll give a more thorough discussion for why the old index seems nonsensical.
Tim Otten [Tue, 21 Mar 2023 03:55:12 +0000 (20:55 -0700)]
Merge pull request #25855 from totten/setup-order
CiviUnitTestCase (etal) - Resolve spooky interaction
Eileen McNaughton [Tue, 21 Mar 2023 02:12:58 +0000 (15:12 +1300)]
Merge pull request #25883 from eileenmcnaughton/mail_format
Remove preferred_mail_format from tokens
Eileen McNaughton [Tue, 21 Mar 2023 01:22:54 +0000 (14:22 +1300)]
Merge pull request #25884 from lemniscus/tagset-markup
don't create tagset markup if there's no tagset
Eileen McNaughton [Tue, 21 Mar 2023 00:01:18 +0000 (13:01 +1300)]
Remove preferred_mail_format from tokens
This also removes the handling from action schedule - there
might be a test checking it's presence to putting up
to adapt tests
Tim Otten [Tue, 21 Mar 2023 00:37:25 +0000 (17:37 -0700)]
Merge pull request #25673 from jmcclelland/transaction-lock
ensure delays from transactions don't cause cache race condition
Eileen McNaughton [Mon, 20 Mar 2023 00:07:10 +0000 (13:07 +1300)]
Add handling of usage to DAO generator
Noah Miller [Mon, 20 Mar 2023 23:54:53 +0000 (19:54 -0400)]
don't create tagset markup if there's no tagset
Seamus Lee [Mon, 20 Mar 2023 21:49:45 +0000 (08:49 +1100)]
Merge pull request #25877 from eileenmcnaughton/submitted
Move getSubmittedValues to `CRM_Core_Form`
colemanw [Mon, 20 Mar 2023 20:49:42 +0000 (16:49 -0400)]
Merge pull request #25882 from lemniscus/tagset-tpl
Skip adding script when it won't have anything to run on
colemanw [Mon, 20 Mar 2023 19:45:49 +0000 (15:45 -0400)]
Merge pull request #25881 from colemanw/dropTable
SchemaHandler - Add IF EXISTS to dropTable function
Noah Miller [Mon, 20 Mar 2023 18:50:01 +0000 (14:50 -0400)]
skip adding script when it won't have anything to run on
Coleman Watts [Mon, 20 Mar 2023 15:57:32 +0000 (11:57 -0400)]
SchemaHandler - Add IF EXISTS to dropTable function
demeritcowboy [Mon, 20 Mar 2023 18:40:44 +0000 (14:40 -0400)]
Merge pull request #25880 from mattwire/caseactivity
Use API4 to create 'Assign Case Role' activity
Matthew Wire [Wed, 22 Feb 2023 14:49:26 +0000 (14:49 +0000)]
Use API4 to create 'Assign Case Role' activity
Matthew Wire [Mon, 20 Mar 2023 13:53:00 +0000 (13:53 +0000)]
Merge pull request #25402 from colemanw/deprecatedActions
APIv4 - Show actions as deprecated in the Explorer
colemanw [Mon, 20 Mar 2023 13:37:58 +0000 (09:37 -0400)]
Merge pull request #25461 from mattwire/dedupepermission
Afform: Fix dedupe rules for anonymous users
colemanw [Mon, 20 Mar 2023 13:23:50 +0000 (09:23 -0400)]
Merge pull request #25779 from eileenmcnaughton/unreachable
Add deprecations to unreachable code in previously shared function
colemanw [Mon, 20 Mar 2023 13:08:03 +0000 (09:08 -0400)]
Merge pull request #25878 from eileenmcnaughton/dep_individual_format
Remove do-nothing noisily deprecated formatting code
Eileen McNaughton [Mon, 20 Mar 2023 06:07:05 +0000 (19:07 +1300)]
Remove do-nothing formatting code
I've been convinced that dates are already handled long before this point
(& loading from the database) so nearly a year ago I added deprecation
notices to fire if this code ever actually did anything. No reports.
It can go:
Eileen McNaughton [Fri, 10 Mar 2023 00:22:36 +0000 (13:22 +1300)]
Add deprecations to unreachable code in previously shared function
Eileen McNaughton [Mon, 20 Mar 2023 03:45:53 +0000 (16:45 +1300)]
dev/core#4152 Fix custom data code to not cast to a float
begin adding support for locale-formatted number input in custom fields
Eileen McNaughton [Mon, 20 Mar 2023 04:17:04 +0000 (17:17 +1300)]
Move getSubmittedValues to CRM_Core_Form
Seamus Lee [Mon, 20 Mar 2023 02:58:25 +0000 (13:58 +1100)]
Merge pull request #25875 from eileenmcnaughton/php82_report
[PHP8.2] Declare outputHandler property in reports
Eileen McNaughton [Mon, 20 Mar 2023 01:29:33 +0000 (14:29 +1300)]
[PHP8.2] Declare outputHandler property
I did a universe search to check private is OK
Eileen McNaughton [Mon, 20 Mar 2023 01:13:55 +0000 (14:13 +1300)]
Merge pull request #25872 from totten/master-release-mysqlver
CiviUnitTestCase - Degrade gracefully on older DBMS
Tim Otten [Sun, 19 Mar 2023 22:52:08 +0000 (15:52 -0700)]
CiviUnitTestCase - Allow relaxed enforcement on older DBMS
colemanw [Sun, 19 Mar 2023 22:46:55 +0000 (18:46 -0400)]
Merge pull request #25862 from eileenmcnaughton/dedupe_finder2
Post split code cleanup
Eileen McNaughton [Sun, 19 Mar 2023 22:05:52 +0000 (11:05 +1300)]
Merge pull request #25869 from eileenmcnaughton/import_contact_pre
[REF] Simplify import preProcess
Eileen McNaughton [Sun, 19 Mar 2023 22:04:55 +0000 (11:04 +1300)]
Merge pull request #25868 from eileenmcnaughton/import_switch
Switch out the switch
Eileen McNaughton [Sun, 19 Mar 2023 20:54:15 +0000 (09:54 +1300)]
[REF] Simplify import preProcess
Eileen McNaughton [Sun, 19 Mar 2023 20:42:24 +0000 (09:42 +1300)]
Remove require_onces