civicrm-core.git
2 years agoAdd release-notes/5.55.1.md
Tim Otten [Tue, 8 Nov 2022 06:02:28 +0000 (22:02 -0800)]
Add release-notes/5.55.1.md

2 years agoMerge pull request #25482 from mattwire/25232search
demeritcowboy [Wed, 1 Feb 2023 00:58:03 +0000 (19:58 -0500)]
Merge pull request #25482 from mattwire/25232search

Fix internal server error when calling GetSearchTasks

2 years agoFix internal server error when calling GetSearchTasks
Matthew Wire [Tue, 31 Jan 2023 21:03:19 +0000 (21:03 +0000)]
Fix internal server error when calling GetSearchTasks

2 years agoMerge pull request #25427 from eileenmcnaughton/notice_import
Matthew Wire [Tue, 31 Jan 2023 19:27:51 +0000 (19:27 +0000)]
Merge pull request #25427 from eileenmcnaughton/notice_import

Regression fix - fieldSeparator lost in 5.58 import screens

2 years agoMerge pull request #25460 from eileenmcnaughton/558
Tim Otten [Tue, 31 Jan 2023 01:51:09 +0000 (17:51 -0800)]
Merge pull request #25460 from eileenmcnaughton/558

dev/core#4063 fix lack of count info on soft credit listing

2 years agoMerge pull request #25467 from demeritcowboy/resubscribe
Eileen McNaughton [Tue, 31 Jan 2023 01:08:23 +0000 (14:08 +1300)]
Merge pull request #25467 from demeritcowboy/resubscribe

Some renames missing from #24982

2 years agoearlier rename missing this one
demeritcowboy [Tue, 31 Jan 2023 01:03:49 +0000 (20:03 -0500)]
earlier rename missing this one

2 years agodev/core#4063 fix lack of count info on soft credit listing
Eileen McNaughton [Mon, 30 Jan 2023 04:41:16 +0000 (17:41 +1300)]
dev/core#4063 fix lack of count info on soft credit listing

https://lab.civicrm.org/dev/core/-/issues/4063

2 years agoMerge pull request #25435 from totten/5.58-upgrade-msg
Tim Otten [Thu, 26 Jan 2023 07:20:51 +0000 (23:20 -0800)]
Merge pull request #25435 from totten/5.58-upgrade-msg

Upgrade - Simplify call to action. Use URL redirect.

2 years agoMerge pull request #25437 from totten/5.58-status-constraint
Tim Otten [Thu, 26 Jan 2023 07:08:06 +0000 (23:08 -0800)]
Merge pull request #25437 from totten/5.58-status-constraint

Status Checks - Add alert for bad foreign key

2 years agoMerge pull request #25410 from larssandergreen/Fix-missing-default-values-for-require...
Tim Otten [Thu, 26 Jan 2023 05:59:12 +0000 (21:59 -0800)]
Merge pull request #25410 from larssandergreen/Fix-missing-default-values-for-required-fields-in-event-registration-setup

CiviEvent - Fix missing default values for required fields in event registration setup

2 years agoStatus Checks - Add alert for bad foreign key
Tim Otten [Thu, 26 Jan 2023 05:50:24 +0000 (21:50 -0800)]
Status Checks - Add alert for bad foreign key

2 years agoFiveFiftySeven - Simplify call to action.
Tim Otten [Thu, 26 Jan 2023 05:09:05 +0000 (21:09 -0800)]
FiveFiftySeven - Simplify call to action.

2 years agoFiveFiftySeven - Point static link to adjustable redirect
Tim Otten [Thu, 26 Jan 2023 04:33:11 +0000 (20:33 -0800)]
FiveFiftySeven - Point static link to adjustable redirect

2 years agoAdd required field to test data
larssandergreen [Thu, 26 Jan 2023 04:20:52 +0000 (21:20 -0700)]
Add required field to test data

2 years agoEvent Registration - Treat omission-by-unset and omission-by-blank-string as the...
Tim Otten [Thu, 26 Jan 2023 03:56:35 +0000 (19:56 -0800)]
Event Registration - Treat omission-by-unset and omission-by-blank-string as the same problem

2 years agoFix fieldSeparator field missing / notice regression
Eileen McNaughton [Thu, 26 Jan 2023 00:41:03 +0000 (13:41 +1300)]
Fix fieldSeparator field missing / notice regression

2 years agoSuperficial cleanup
Eileen McNaughton [Thu, 26 Jan 2023 00:03:00 +0000 (13:03 +1300)]
Superficial cleanup

2 years agoMerge pull request #25421 from aydun/fix_core_4095
Eileen McNaughton [Wed, 25 Jan 2023 22:55:31 +0000 (11:55 +1300)]
Merge pull request #25421 from aydun/fix_core_4095

dev/core#4095 - update log schema of civicrm_option_group before adding values

2 years agoMerge pull request #25424 from totten/5.58-json-wp
Seamus Lee [Wed, 25 Jan 2023 22:39:59 +0000 (09:39 +1100)]
Merge pull request #25424 from totten/5.58-json-wp

distmaker - Fix 'WordPress' entry in JSON report

2 years agoMerge pull request #25423 from seamuslee001/5.58
Seamus Lee [Wed, 25 Jan 2023 22:36:54 +0000 (09:36 +1100)]
Merge pull request #25423 from seamuslee001/5.58

[REF] Bump UA Parser to 0.7.33

2 years agodistmaker - Fix 'WordPress' entry in JSON report
Tim Otten [Wed, 25 Jan 2023 22:18:18 +0000 (14:18 -0800)]
distmaker - Fix 'WordPress' entry in JSON report

2 years ago[REF] Bump UA Parser to 0.7.33
Seamus Lee [Wed, 25 Jan 2023 21:48:05 +0000 (08:48 +1100)]
[REF] Bump UA Parser to 0.7.33

2 years agodev/core#4095 - update log schema of civicrm_option_group before adding values
Aidan Saunders [Wed, 25 Jan 2023 21:29:20 +0000 (21:29 +0000)]
dev/core#4095 - update log schema of civicrm_option_group before adding values

2 years agoFix missing default values for required fields in event registration setup
larssandergreen [Tue, 24 Jan 2023 19:04:07 +0000 (12:04 -0700)]
Fix missing default values for required fields in event registration setup

2 years agoMerge pull request #25380 from demeritcowboy/act-rev
Seamus Lee [Fri, 20 Jan 2023 01:18:52 +0000 (12:18 +1100)]
Merge pull request #25380 from demeritcowboy/act-rev

Avoid 5.57 upgrade taking hours on large activity tables

2 years agoavoid upgrade taking hours
demeritcowboy [Thu, 19 Jan 2023 03:25:23 +0000 (22:25 -0500)]
avoid upgrade taking hours

2 years agoMerge pull request #25374 from colemanw/fixChange
Tim Otten [Thu, 19 Jan 2023 22:24:50 +0000 (14:24 -0800)]
Merge pull request #25374 from colemanw/fixChange

Fix dev/core#4083 - Broken autocomplete Afform widget

2 years agoMerge pull request #25370 from pradpnayak/waitlist
demeritcowboy [Thu, 19 Jan 2023 18:31:26 +0000 (13:31 -0500)]
Merge pull request #25370 from pradpnayak/waitlist

Waitlist

2 years agoDo not display waitlist message dev/core/-/issues/4087
Pradeep Nayak [Wed, 18 Jan 2023 14:43:44 +0000 (14:43 +0000)]
Do not display waitlist message dev/core/-/issues/4087

2 years agoFix dev/core#4083 - Broken autocomplete Afform widget
Coleman Watts [Wed, 18 Jan 2023 19:47:05 +0000 (14:47 -0500)]
Fix dev/core#4083 - Broken autocomplete Afform widget

2 years agoMerge pull request #25364 from alifrumin/rn5.58
Eileen McNaughton [Tue, 17 Jan 2023 04:26:12 +0000 (17:26 +1300)]
Merge pull request #25364 from alifrumin/rn5.58

[NFC] First Pass 5.58 Release Notes

2 years ago[NFC] First Pass 5.58 Release Notes
Alice Frumin [Sat, 14 Jan 2023 03:45:39 +0000 (22:45 -0500)]
[NFC] First Pass 5.58 Release Notes

2 years agoMerge pull request #25341 from agh1/5.58.0-releasenotes-initial
demeritcowboy [Fri, 13 Jan 2023 20:29:48 +0000 (15:29 -0500)]
Merge pull request #25341 from agh1/5.58.0-releasenotes-initial

5.58.0 release notes initial run

2 years ago5.58.0 release notes: added boilerplate
Andie Hunt [Fri, 13 Jan 2023 19:05:18 +0000 (14:05 -0500)]
5.58.0 release notes: added boilerplate

2 years ago5.58.0 release notes: initial run
Andie Hunt [Fri, 13 Jan 2023 19:02:01 +0000 (14:02 -0500)]
5.58.0 release notes: initial run

2 years agoMerge pull request #25320 from JMAConsulting/j3_cv_fix
Seamus Lee [Wed, 11 Jan 2023 04:40:38 +0000 (15:40 +1100)]
Merge pull request #25320 from JMAConsulting/j3_cv_fix

Fix `cv` failure on J3.

2 years agoFix `cv` failure on J3.
Aidan Saunders [Fri, 6 Jan 2023 10:48:14 +0000 (10:48 +0000)]
Fix `cv` failure on J3.

2 years agoMerge pull request #25316 from jofranz/5.57.0_security_quotes_typo
Seamus Lee [Wed, 11 Jan 2023 02:47:14 +0000 (13:47 +1100)]
Merge pull request #25316 from jofranz/5.57.0_security_quotes_typo

5.57.0 quotes typo: security 2x double quotes to 1x double quotes

2 years agoMerge pull request #25305 from totten/5.58-assetbuilder-2
Seamus Lee [Wed, 11 Jan 2023 02:46:35 +0000 (13:46 +1100)]
Merge pull request #25305 from totten/5.58-assetbuilder-2

AssetBuilder - Fix `testInvalid()` failure. Switch to JWT.

2 years ago5.57.0 quotes typo: security 2x double quotes to 1x double quotes
Jo Franz [Tue, 10 Jan 2023 22:27:07 +0000 (23:27 +0100)]
5.57.0 quotes typo: security 2x double quotes to 1x double quotes

2 years agoMerge pull request #25285 from totten/master-sign-warning
Tim Otten [Tue, 10 Jan 2023 22:00:26 +0000 (14:00 -0800)]
Merge pull request #25285 from totten/master-sign-warning

Status Check - Raise severity of the check for signing keys

2 years agoAssetBuilder - Define a fallback key (WEAK_SIGN) for sites that have not been configured
Tim Otten [Tue, 10 Jan 2023 01:07:57 +0000 (17:07 -0800)]
AssetBuilder - Define a fallback key (WEAK_SIGN) for sites that have not been configured

2 years agoAssetBuilder - Switch to JWT
Tim Otten [Mon, 9 Jan 2023 22:45:49 +0000 (14:45 -0800)]
AssetBuilder - Switch to JWT

2 years agoMerge pull request #25300 from artfulrobot/artfulrobot-fix-null-line-item-label-crash
Eileen McNaughton [Mon, 9 Jan 2023 23:00:56 +0000 (12:00 +1300)]
Merge pull request #25300 from artfulrobot/artfulrobot-fix-null-line-item-label-crash

Fix Contributions listing crash due to getLineItemTitle returning null

2 years agoStatus Check - Raise severity of the check for signing keys. Tweak prose.
Tim Otten [Thu, 5 Jan 2023 22:28:08 +0000 (14:28 -0800)]
Status Check - Raise severity of the check for signing keys. Tweak prose.

2 years agoFix Contributions listing crash due to CRM_Financial_BAO_Order::getLineItemTitle
Rich Lott / Artful Robot [Mon, 9 Jan 2023 19:36:39 +0000 (19:36 +0000)]
Fix Contributions listing crash due to CRM_Financial_BAO_Order::getLineItemTitle

2 years agoMerge pull request #25289 from demeritcowboy/sk-update
demeritcowboy [Fri, 6 Jan 2023 19:21:27 +0000 (14:21 -0500)]
Merge pull request #25289 from demeritcowboy/sk-update

searchkit - fix broken update task in dropdown

2 years agofix broken update task
demeritcowboy [Fri, 6 Jan 2023 17:56:14 +0000 (12:56 -0500)]
fix broken update task

2 years agoSet version to 5.58.beta1
Tim Otten [Thu, 5 Jan 2023 05:57:00 +0000 (21:57 -0800)]
Set version to 5.58.beta1

2 years agoMerge pull request #25281 from seamuslee001/move_help_test
Tim Otten [Thu, 5 Jan 2023 03:13:35 +0000 (19:13 -0800)]
Merge pull request #25281 from seamuslee001/move_help_test

Move newly added Help Test to Inline folder to match Core Folder stru…

2 years agoMove newly added Help Test to Inline folder to match Core Folder structure
Seamus Lee [Thu, 5 Jan 2023 00:52:58 +0000 (11:52 +1100)]
Move newly added Help Test to Inline folder to match Core Folder structure

2 years agoMerge pull request #25280 from civicrm/5.57
Seamus Lee [Thu, 5 Jan 2023 00:45:13 +0000 (11:45 +1100)]
Merge pull request #25280 from civicrm/5.57

5.57

2 years agorelease-notes/5.57.0.md - Add security advisories
Tim Otten [Wed, 4 Jan 2023 02:32:08 +0000 (18:32 -0800)]
release-notes/5.57.0.md - Add security advisories

2 years agoAssetBuilder - Validate checksum for requested parameters
Tim Otten [Wed, 29 Jun 2022 05:06:05 +0000 (22:06 -0700)]
AssetBuilder - Validate checksum for requested parameters

2 years agoCiviEvent - Escape parameters in help text
Seamus Lee [Tue, 3 Jan 2023 01:54:11 +0000 (12:54 +1100)]
CiviEvent - Escape parameters in help text

2 years agosecurity/core#120 Use Rich's patch (ArtfulRobot) with minor variation to try to resol...
Seamus Lee [Fri, 16 Dec 2022 00:55:57 +0000 (11:55 +1100)]
security/core#120 Use Rich's patch (ArtfulRobot) with minor variation to try to resolve the issue and add unit tests

Fix Regex and include test cases as per Rich's comments

2 years agoMerge pull request #25170 from demeritcowboy/sortable
Tim Otten [Thu, 5 Jan 2023 00:35:26 +0000 (16:35 -0800)]
Merge pull request #25170 from demeritcowboy/sortable

dev/core#4013 dev/core#4022 - Broken quicksearch options setting

2 years agoMerge pull request #25222 from eileenmcnaughton/cust_ed4
demeritcowboy [Wed, 4 Jan 2023 22:34:17 +0000 (17:34 -0500)]
Merge pull request #25222 from eileenmcnaughton/cust_ed4

[REF] [merge custom fields] Only call function when applicable  (well tested code)

2 years agoMerge pull request #25278 from totten/5.57-rn
Tim Otten [Wed, 4 Jan 2023 20:59:26 +0000 (12:59 -0800)]
Merge pull request #25278 from totten/5.57-rn

release-notes/5.57.0.md - Add recent update

2 years agorelease-notes/5.57.0.md - Add recent update
Tim Otten [Wed, 4 Jan 2023 20:58:20 +0000 (12:58 -0800)]
release-notes/5.57.0.md - Add recent update

2 years agoMerge pull request #25276 from demeritcowboy/turk
Eileen McNaughton [Wed, 4 Jan 2023 20:40:57 +0000 (09:40 +1300)]
Merge pull request #25276 from demeritcowboy/turk

[NFC] Restore locale properly after test

2 years agoOnly call function when applicable
Eileen McNaughton [Mon, 26 Dec 2022 22:15:29 +0000 (11:15 +1300)]
Only call function when applicable

Big whitespace change as IF is moved

2 years agoMerge pull request #25245 from braders/php82_ical_dynamic_properties
demeritcowboy [Wed, 4 Jan 2023 15:40:17 +0000 (10:40 -0500)]
Merge pull request #25245 from braders/php82_ical_dynamic_properties

[REF][PHP8.2] Avoid dynamic properties in CRM_Activity_BAO_ICalendar

2 years agoMerge pull request #25260 from eileenmcnaughton/prev_o
Yashodha Chaku [Wed, 4 Jan 2023 06:51:47 +0000 (12:21 +0530)]
Merge pull request #25260 from eileenmcnaughton/prev_o

Remove Mar 2020 deprecated functions

2 years agorestore properly
demeritcowboy [Wed, 4 Jan 2023 03:08:54 +0000 (22:08 -0500)]
restore properly

2 years agoMerge pull request #25264 from eileenmcnaughton/leg_selector
Seamus Lee [Wed, 4 Jan 2023 00:31:16 +0000 (11:31 +1100)]
Merge pull request #25264 from eileenmcnaughton/leg_selector

Move legacy search selector file to legacy search extension

2 years agoMerge pull request #25275 from mlutfy/petitionMsgTypo
Seamus Lee [Wed, 4 Jan 2023 00:30:46 +0000 (11:30 +1100)]
Merge pull request #25275 from mlutfy/petitionMsgTypo

Petition ThankYou.tpl: fix strong typo

2 years agoPetition ThankYou.tpl: fix strong typo
Mathieu Lutfy [Tue, 3 Jan 2023 21:47:17 +0000 (16:47 -0500)]
Petition ThankYou.tpl: fix strong typo

2 years agoMerge pull request #25274 from civicrm/5.57
Eileen McNaughton [Tue, 3 Jan 2023 20:51:02 +0000 (09:51 +1300)]
Merge pull request #25274 from civicrm/5.57

5.57 to master

2 years agoMerge pull request #25273 from gellweiler/5.57
Eileen McNaughton [Tue, 3 Jan 2023 20:50:19 +0000 (09:50 +1300)]
Merge pull request #25273 from gellweiler/5.57

Add gellweiler to contributor-key.yml

2 years agoMerge pull request #25272 from eileenmcnaughton/557
Eileen McNaughton [Tue, 3 Jan 2023 20:49:42 +0000 (09:49 +1300)]
Merge pull request #25272 from eileenmcnaughton/557

dev/core#4049 Nested tags are not showing under some circumstances.

2 years agoAdd gellweiler to contributor-key.yml
Sebastian Gellweiler [Tue, 3 Jan 2023 20:18:07 +0000 (21:18 +0100)]
Add gellweiler to contributor-key.yml

2 years agoFix #4049
gellweiler [Sat, 24 Dec 2022 13:51:00 +0000 (14:51 +0100)]
Fix #4049

This commit fixes #4049: Nested tags are not showing under some circumstances.

2 years agoMerge pull request #25268 from eileenmcnaughton/is_separate
Yashodha Chaku [Tue, 3 Jan 2023 04:47:23 +0000 (10:17 +0530)]
Merge pull request #25268 from eileenmcnaughton/is_separate

Remove unreachable code (since 2020)

2 years agoMerge pull request #25258 from eileenmcnaughton/search_test
Seamus Lee [Tue, 3 Jan 2023 00:54:42 +0000 (11:54 +1100)]
Merge pull request #25258 from eileenmcnaughton/search_test

NFC cleanup in test class

2 years agoMerge pull request #25269 from demeritcowboy/more-better-deleted
Seamus Lee [Tue, 3 Jan 2023 00:52:03 +0000 (11:52 +1100)]
Merge pull request #25269 from demeritcowboy/more-better-deleted

Better fix for is_deleted notice in 25261

2 years agoMerge pull request #25267 from eileenmcnaughton/no_input
Seamus Lee [Mon, 2 Jan 2023 22:08:16 +0000 (09:08 +1100)]
Merge pull request #25267 from eileenmcnaughton/no_input

Move part of deprecated function `loadRelatedObjects` to calling functions

2 years agobetter fix for 25261
demeritcowboy [Mon, 2 Jan 2023 22:07:04 +0000 (17:07 -0500)]
better fix for 25261

2 years agoRemove unreachable code (since 2020)
Eileen McNaughton [Mon, 2 Jan 2023 21:52:04 +0000 (10:52 +1300)]
Remove unreachable code (since 2020)

2 years agoMerge pull request #25253 from braders/api3-properties
Seamus Lee [Mon, 2 Jan 2023 21:01:51 +0000 (08:01 +1100)]
Merge pull request #25253 from braders/api3-properties

[REF][PHP8.2] Avoid dynamic properties in civicrm_api3 class

2 years agoMerge pull request #25252 from braders/empty-param-annotations
Seamus Lee [Mon, 2 Jan 2023 21:01:17 +0000 (08:01 +1100)]
Merge pull request #25252 from braders/empty-param-annotations

Remove empty param declarations in docblocks

2 years agoMove part of deprecated function loadRelatedObjects to calling functions
Eileen McNaughton [Mon, 2 Jan 2023 20:43:04 +0000 (09:43 +1300)]
Move part of deprecated function loadRelatedObjects to calling functions

2 years agoMerge pull request #25266 from braders/phpdoc-fixes3
Eileen McNaughton [Mon, 2 Jan 2023 20:07:54 +0000 (09:07 +1300)]
Merge pull request #25266 from braders/phpdoc-fixes3

PHPDoc corrections

2 years agoRemove empty param declarations in docblocks
Bradley Taylor [Sat, 31 Dec 2022 23:37:26 +0000 (23:37 +0000)]
Remove empty param declarations in docblocks

2 years agoMerge pull request #25265 from braders/tagelement-property-removal
demeritcowboy [Mon, 2 Jan 2023 17:48:03 +0000 (12:48 -0500)]
Merge pull request #25265 from braders/tagelement-property-removal

(REF) Remove _tagElement dynamic property

2 years agoMerge pull request #25261 from eileenmcnaughton/notice
demeritcowboy [Mon, 2 Jan 2023 17:31:30 +0000 (12:31 -0500)]
Merge pull request #25261 from eileenmcnaughton/notice

Smarty notice fix on contact search results

2 years agoPHPDoc corrections
Bradley Taylor [Mon, 2 Jan 2023 16:52:10 +0000 (16:52 +0000)]
PHPDoc corrections

2 years ago(REF) Remove _tagElement dynamic property
Bradley Taylor [Mon, 2 Jan 2023 16:18:47 +0000 (16:18 +0000)]
(REF) Remove _tagElement dynamic property

2 years agoMerge pull request #25238 from eileenmcnaughton/is_separate
Matthew Wire [Mon, 2 Jan 2023 09:49:55 +0000 (09:49 +0000)]
Merge pull request #25238 from eileenmcnaughton/is_separate

Extract `getMembershipBlock`

2 years agoMerge pull request #25263 from eileenmcnaughton/by_ref
Yashodha Chaku [Mon, 2 Jan 2023 07:52:10 +0000 (13:22 +0530)]
Merge pull request #25263 from eileenmcnaughton/by_ref

Remove unnecessary pass-by-ref

2 years agoMove legacy search selector file to legacy search extension
Eileen McNaughton [Mon, 2 Jan 2023 07:45:48 +0000 (20:45 +1300)]
Move legacy search selector file to legacy search extension

2 years agoRemove unnecessary pass-by-ref
Eileen McNaughton [Mon, 2 Jan 2023 06:02:44 +0000 (19:02 +1300)]
Remove unnecessary pass-by-ref

2 years agoSmarty notice fix on contact search results
Eileen McNaughton [Mon, 2 Jan 2023 04:34:14 +0000 (17:34 +1300)]
Smarty notice fix on contact search results

2 years agoRemove more deprecated functions
Eileen McNaughton [Mon, 2 Jan 2023 03:26:38 +0000 (16:26 +1300)]
Remove more deprecated functions

2 years agoRemove 2020 deprecated functions
Eileen McNaughton [Mon, 2 Jan 2023 03:23:36 +0000 (16:23 +1300)]
Remove 2020 deprecated functions

2 years agoMerge pull request #25257 from eileenmcnaughton/unused
demeritcowboy [Mon, 2 Jan 2023 01:57:50 +0000 (20:57 -0500)]
Merge pull request #25257 from eileenmcnaughton/unused

Remove unused variable

2 years agoImprove dataSet
Eileen McNaughton [Mon, 2 Jan 2023 01:48:52 +0000 (14:48 +1300)]
Improve dataSet

It seems when writing this test I thought it was worth having more confusing code
in order to have a clearer failure message - I think that might have been more valid
when writing the test than it is now it rarely fails

2 years agoNFC cleanup in test class
Eileen McNaughton [Mon, 2 Jan 2023 01:05:02 +0000 (14:05 +1300)]
NFC cleanup in test class

2 years agoMerge pull request #25255 from eileenmcnaughton/test_simp
Yashodha Chaku [Mon, 2 Jan 2023 01:45:09 +0000 (07:15 +0530)]
Merge pull request #25255 from eileenmcnaughton/test_simp

Simplify dataProvider in queryTest