Eileen McNaughton [Fri, 16 Jun 2023 03:42:02 +0000 (15:42 +1200)]
Merge pull request #26537 from colemanw/postPostSelectQuery
APIv4 - Deprecate unused event
Eileen McNaughton [Fri, 16 Jun 2023 03:38:47 +0000 (15:38 +1200)]
Merge pull request #26111 from adixon/membership-detail-report-4261
Report on the most recent membership contribution, not the oldest
colemanw [Fri, 16 Jun 2023 00:54:02 +0000 (20:54 -0400)]
APIv4 - Deprecate unused event
demeritcowboy [Thu, 15 Jun 2023 19:55:07 +0000 (15:55 -0400)]
Merge pull request #26530 from mlutfy/fixCssSiteURL
Fix for domains that have the string .css in them
demeritcowboy [Thu, 15 Jun 2023 19:54:09 +0000 (15:54 -0400)]
Merge pull request #26534 from larssandergreen/Add-additional-message-to-invoice-sent-from-Email-Invoice-form
Add additional message to invoice template if present
Mathieu Lutfy [Wed, 14 Jun 2023 20:30:11 +0000 (16:30 -0400)]
Fix for domains that have the string .css in them
preg_match is used because we also have to match on items from the
asset builder, which have URL params in the filename.
Example:
[...]q=civicrm%2Fasset%2Fbuilder&an=crm-menubar.css&ad=
9caf2150754dca162f3a
larssandergreen [Thu, 15 Jun 2023 14:28:42 +0000 (08:28 -0600)]
Add additional message to invoice template if present
demeritcowboy [Thu, 15 Jun 2023 13:50:31 +0000 (09:50 -0400)]
Merge pull request #26528 from colemanw/fixDouble
Fix dev/core#4359 doubled Afform fields
demeritcowboy [Thu, 15 Jun 2023 13:24:27 +0000 (09:24 -0400)]
Merge pull request #26533 from larssandergreen/Cleanup-send-invoice-email-form
Cleanup Email Invoice form to remove longest ever field label
Aidan Saunders [Thu, 15 Jun 2023 12:58:01 +0000 (13:58 +0100)]
Merge pull request #26498 from colemanw/skAggregateCurrency
Fix dev/core#4207 - Handle currency symbol in SK aggregates
larssandergreen [Thu, 15 Jun 2023 04:15:09 +0000 (22:15 -0600)]
Cleanup Invoice Email form
Eileen McNaughton [Thu, 15 Jun 2023 01:04:28 +0000 (13:04 +1200)]
Merge pull request #26531 from demeritcowboy/google-prompt
dev/core#2184 - OAUTH - make google always return a refresh token
demeritcowboy [Thu, 15 Jun 2023 00:05:53 +0000 (20:05 -0400)]
use more consent-y prompt for google
Eileen McNaughton [Wed, 14 Jun 2023 22:18:53 +0000 (10:18 +1200)]
Merge pull request #26526 from reflexive-communications/open-tracker-legacy-check
FlexMailer\Listener\OpenTracker: remove deprecated isLegacy check
demeritcowboy [Wed, 14 Jun 2023 22:00:18 +0000 (18:00 -0400)]
Merge pull request #26511 from colemanw/civiGrantTest
[TEST] APIv4 - Include CiviGrant in conformance tests
colemanw [Wed, 14 Jun 2023 18:53:37 +0000 (14:53 -0400)]
Merge pull request #26525 from yashodha/dev-4358
(dev/core#4358) Verbiage changes on Find Groups screen
colemanw [Wed, 14 Jun 2023 16:41:23 +0000 (12:41 -0400)]
Fix dev/core#4359 doubled Afform fields
colemanw [Wed, 14 Jun 2023 16:39:35 +0000 (12:39 -0400)]
Tests - Fix Api4TestTrait to create an option value if needed
Sandor Semsey [Wed, 14 Jun 2023 13:04:05 +0000 (15:04 +0200)]
fix format
Sandor Semsey [Wed, 14 Jun 2023 12:36:27 +0000 (14:36 +0200)]
remove deprecated isLegacy check
yashodha [Wed, 14 Jun 2023 10:08:24 +0000 (15:38 +0530)]
(dev/core#4358) Verbiage changes on Find Groups screen
colemanw [Tue, 13 Jun 2023 18:12:47 +0000 (14:12 -0400)]
Merge pull request #26520 from larssandergreen/Don't-add-contact-to-Domain-Group-on-edit
Don't add Contact to Domain Group on edit
colemanw [Tue, 13 Jun 2023 18:00:33 +0000 (14:00 -0400)]
Merge pull request #26519 from larssandergreen/Don't-try-to-add-Contacts-to-Groups-on-Edit
[REF] Don't add Contacts to Groups they are already Added to on Edit
Yashodha Chaku [Tue, 13 Jun 2023 15:27:26 +0000 (20:57 +0530)]
Merge pull request #26502 from larssandergreen/Select2-New-contribution-financial-type
Add select2s for Contribution, etc
larssandergreen [Tue, 13 Jun 2023 14:02:13 +0000 (08:02 -0600)]
Don't add Contact to Domain Group on edit
colemanw [Tue, 13 Jun 2023 13:23:39 +0000 (09:23 -0400)]
Merge pull request #26518 from demeritcowboy/reserved-move
dev/core#4338 - Prevent people from sneakily adding fields to your extension's reserved custom groups by using the Move action
demeritcowboy [Wed, 7 Jun 2023 19:18:04 +0000 (15:18 -0400)]
don't allow moving fields into reserved groups
larssandergreen [Tue, 13 Jun 2023 06:29:07 +0000 (00:29 -0600)]
Don't add Contacts to Groups they are Added to on Edit
Seamus Lee [Tue, 13 Jun 2023 03:08:47 +0000 (13:08 +1000)]
Merge pull request #26517 from demeritcowboy/mystery-index
dev/core#4355 - Fix crash for radio custom fields
demeritcowboy [Tue, 13 Jun 2023 00:57:13 +0000 (20:57 -0400)]
fix crash for radio custom fields
colemanw [Mon, 12 Jun 2023 23:13:02 +0000 (19:13 -0400)]
Merge pull request #26516 from eileenmcnaughton/import_admin2
Add All imports menu item for users with Administer Queues
Eileen McNaughton [Mon, 12 Jun 2023 22:32:23 +0000 (10:32 +1200)]
Add All imports menu item for users with Administer QUeues
This adds the (only just added) search display for 'all imports' to the menu, but
only for users with 'Administer Queues' - for other users they would only see
their own imports, so it would duplicate 'my imports'.
This is useful for site admins etc trying to understand issues their users might be having
with imports.
Note the extension needs to be enabled
colemanw [Mon, 12 Jun 2023 21:04:59 +0000 (17:04 -0400)]
Merge pull request #26514 from larssandergreen/Always-show-implicit-TRUE-Permissions-Check-in-API-4-Explorer
Make implicit TRUE permissions check explicit in API 4 Explorer for PHP
Eileen McNaughton [Mon, 12 Jun 2023 20:25:45 +0000 (08:25 +1200)]
Merge pull request #26515 from civicrm/5.63
5.63
colemanw [Mon, 12 Jun 2023 18:15:15 +0000 (14:15 -0400)]
Merge pull request #26512 from demeritcowboy/regen
regen after 26499 and 26492
larssandergreen [Mon, 12 Jun 2023 17:47:44 +0000 (11:47 -0600)]
Make implicit TRUE permissions check explicit in API 4 Explorer for PHP
colemanw [Mon, 12 Jun 2023 17:44:22 +0000 (13:44 -0400)]
Merge pull request #26513 from colemanw/fixGrantAccess
CiviGrant - Fix error when creating grant without permissions
colemanw [Mon, 12 Jun 2023 16:21:55 +0000 (12:21 -0400)]
CiviGrant - Fix error when creating grant without permissions
When creating a grant with checkPermissions disabled (e.g. via API) the permissions
were getting tripped by the RecentItem create action
demeritcowboy [Mon, 12 Jun 2023 16:19:23 +0000 (16:19 +0000)]
regenerate civicrm_generated
demeritcowboy [Mon, 12 Jun 2023 16:09:01 +0000 (12:09 -0400)]
Merge pull request #26465 from totten/master-test-fetchwith
Smarty - When temporarily setting variable, fix cleanup for previously-undefined values.
demeritcowboy [Mon, 12 Jun 2023 16:08:33 +0000 (12:08 -0400)]
Merge pull request #26506 from larssandergreen/Reduce-PHP-warnings-on-Contribution
Reduce PHP warnings on Contribution
colemanw [Mon, 12 Jun 2023 15:32:44 +0000 (11:32 -0400)]
Merge pull request #26496 from colemanw/afformExposeOperators
Afform - Enable search operators to be exposed on the form
colemanw [Mon, 12 Jun 2023 14:35:02 +0000 (10:35 -0400)]
APIv4 - Include CiviGrant in conformance tests
Yashodha Chaku [Mon, 12 Jun 2023 10:34:42 +0000 (16:04 +0530)]
Merge pull request #26497 from colemanw/apiGuard
Prevent API errors when CiviEvent is disabled
colemanw [Sun, 11 Jun 2023 11:47:31 +0000 (07:47 -0400)]
Merge pull request #26508 from braders/php8.1-getDynamicCharacters
[REF][PHP8.1] Don't pass null to strtoupper in getDynamicCharacters
Bradley Taylor [Sun, 11 Jun 2023 08:01:19 +0000 (09:01 +0100)]
[REF][PHP8.1] Don't pass null to strtoupper in getDynamicCharacters
Tim Otten [Sat, 10 Jun 2023 21:40:06 +0000 (14:40 -0700)]
CrmScopeTest - Use explicit value for default/global example
Before: We rely on default/global value of `x=UNDEFINED` or `x=NULL`.
But this is a bit tempermental.
After: Clear default.
Note: There's a prior commit which adds another test (CRM_Core_SmartyTest)
where the global value is specifically undefined or specifically null.
So that still has coverage.
larssandergreen [Sat, 10 Jun 2023 19:00:38 +0000 (13:00 -0600)]
Reduce PHP warnings on Contribution
colemanw [Sat, 10 Jun 2023 17:11:26 +0000 (13:11 -0400)]
Merge pull request #26503 from larssandergreen/Fix-Financial-Type-status
Expire notifications for Shared Address Contact Delete & Financial Types
colemanw [Sat, 10 Jun 2023 17:04:17 +0000 (13:04 -0400)]
Merge pull request #26504 from braders/findById-return-type
[NFC] Change PHPDoc return type (findById)
Bradley Taylor [Sat, 10 Jun 2023 16:35:58 +0000 (17:35 +0100)]
[NFC] Change PHPDoc return type (findById)
larssandergreen [Sat, 10 Jun 2023 15:54:46 +0000 (09:54 -0600)]
Expire notifications for Shared Address Contact Delete & Financial Type
larssandergreen [Sat, 10 Jun 2023 15:48:14 +0000 (09:48 -0600)]
Add select2s
colemanw [Sat, 10 Jun 2023 13:43:10 +0000 (09:43 -0400)]
Merge pull request #26316 from eileenmcnaughton/import_admin
Add import listing for admins
Eileen McNaughton [Sat, 10 Jun 2023 02:01:32 +0000 (14:01 +1200)]
Merge pull request #26501 from civicrm/5.63
5.63
demeritcowboy [Sat, 10 Jun 2023 00:38:54 +0000 (20:38 -0400)]
Merge pull request #26500 from pradpnayak/hook
wrong hook params
Pradeep Nayak [Fri, 9 Jun 2023 23:53:10 +0000 (00:53 +0100)]
wrong hook params
colemanw [Fri, 9 Jun 2023 23:52:35 +0000 (19:52 -0400)]
Merge pull request #26499 from totten/5.63-init-ext
Component-Extensions - Ensure the initial activation list matches
Tim Otten [Fri, 9 Jun 2023 22:43:17 +0000 (15:43 -0700)]
CRM_Core_Smarty - Fix restoration of undefined values (following temporary assignments)
colemanw [Fri, 9 Jun 2023 22:30:41 +0000 (18:30 -0400)]
Merge pull request #26487 from eileenmcnaughton/notice_part
Fix e-notices on New Participant form, strict smarty
Tim Otten [Fri, 9 Jun 2023 21:47:55 +0000 (14:47 -0700)]
Regenerate `civicrm_generated.mysql`
colemanw [Fri, 9 Jun 2023 21:54:01 +0000 (17:54 -0400)]
Merge pull request #26495 from demeritcowboy/doer2
Add deprecation warning and fix deprecated constructor call (followup to #26398)
Tim Otten [Fri, 9 Jun 2023 21:42:23 +0000 (14:42 -0700)]
regen.sh - Preserve the default component-extensions
The issue is that `civicrm_setting[enable_components]` and
`civicrm_extension` need to be sync'd (as of 5.63+).
But there's a structural asymmetry - when dealing with an empty/default
arrangement, "settings"/"components" will inherit a default activation-list;
but "extensions" start with an empty activation-list.
With this patch, we retain the local-active list of component-extensions.
Hopefully, that matches the default setting...
colemanw [Fri, 9 Jun 2023 21:52:10 +0000 (17:52 -0400)]
Merge pull request #26381 from samuelsov/adminuisearch1
[WIP] civicrm_admin_ui Find contacts replacement
Tim Otten [Fri, 9 Jun 2023 21:37:11 +0000 (14:37 -0700)]
Add default-components to list of default-extensions
Tim Otten [Fri, 9 Jun 2023 21:32:56 +0000 (14:32 -0700)]
(REF) civicrm_extension.sqldata.php - Remove redundant lines
colemanw [Fri, 9 Jun 2023 19:43:52 +0000 (15:43 -0400)]
Fix dev/core#4207 - Handle currency symbol in SK aggregates
demeritcowboy [Fri, 9 Jun 2023 16:28:25 +0000 (12:28 -0400)]
constructor called in a deprecated way
demeritcowboy [Fri, 9 Jun 2023 19:38:19 +0000 (15:38 -0400)]
Revert #26398
Samuel Vanhove [Tue, 30 May 2023 19:04:32 +0000 (15:04 -0400)]
civicrm_admin_ui Find contacts replacement
colemanw [Fri, 9 Jun 2023 19:03:19 +0000 (15:03 -0400)]
Prevent API errors when CiviEvent is disabled
colemanw [Fri, 9 Jun 2023 12:06:13 +0000 (08:06 -0400)]
Afform - Enable search operators to be exposed on the form
colemanw [Fri, 9 Jun 2023 17:13:25 +0000 (13:13 -0400)]
Merge pull request #26491 from mattwire/4336fields
dev/core#4336 Fix don't display payment fields on initial event registration form if payment on confirm is enabled
demeritcowboy [Fri, 9 Jun 2023 16:55:54 +0000 (12:55 -0400)]
Merge pull request #26493 from civicrm/5.63
5.63
demeritcowboy [Fri, 9 Jun 2023 16:54:28 +0000 (12:54 -0400)]
Merge pull request #26492 from larssandergreen/Remove-unreachable-from-event-registration-template-for-tax-total
Remove unreachable code in event registration templates for tax total
colemanw [Fri, 9 Jun 2023 16:53:40 +0000 (12:53 -0400)]
Merge pull request #26494 from demeritcowboy/ufdao
UFGroup DAO is out of date
demeritcowboy [Fri, 9 Jun 2023 16:21:28 +0000 (12:21 -0400)]
regen dao
demeritcowboy [Fri, 9 Jun 2023 16:19:48 +0000 (12:19 -0400)]
Merge pull request #26488 from eileenmcnaughton/event_reg
Fix back office register form validation
larssandergreen [Fri, 9 Jun 2023 15:03:44 +0000 (09:03 -0600)]
Remove unreachable code in event registration templates for tax total
Matthew Wire [Fri, 9 Jun 2023 12:11:32 +0000 (13:11 +0100)]
Fix don't display payment fields on initial event registration form if payment on confirm is enabled
colemanw [Fri, 9 Jun 2023 10:53:33 +0000 (06:53 -0400)]
Merge pull request #25533 from mattwire/afform
Log server-side validation errors so it is easier to troubleshoot/debug afform issues
colemanw [Fri, 9 Jun 2023 10:49:10 +0000 (06:49 -0400)]
Merge pull request #26490 from eileenmcnaughton/comma
Remove stray semi-colon
colemanw [Fri, 9 Jun 2023 10:47:28 +0000 (06:47 -0400)]
Merge pull request #26489 from eileenmcnaughton/remove_comment
Remove obsolete comment
Matthew Wire [Wed, 8 Feb 2023 22:48:25 +0000 (22:48 +0000)]
Log server-side validation errors so it is easier to troubleshoot/debug afform issues
Aidan Saunders [Fri, 9 Jun 2023 09:28:41 +0000 (10:28 +0100)]
Merge pull request #26479 from colemanw/adminUiRedirect
AdminUI - Alter core forms to redirect to the new AdminUI afform pages
Eileen McNaughton [Fri, 9 Jun 2023 07:20:57 +0000 (19:20 +1200)]
Remove stray semi-colon
Eileen McNaughton [Fri, 9 Jun 2023 07:15:33 +0000 (19:15 +1200)]
Remove obsolete comment
This github tried to change the code to match the comment
https://github.com/civicrm/civicrm-core/pull/25819
However, when we inadvertantly did that ... it messed with people's expected
behaviour - so let's remove the comment instead
Eileen McNaughton [Fri, 9 Jun 2023 07:10:43 +0000 (19:10 +1200)]
Fix back office register form validation
Follow on to https://github.com/civicrm/civicrm-core/pull/26346#event-
9346416078
Eileen McNaughton [Fri, 9 Jun 2023 06:52:06 +0000 (18:52 +1200)]
Fix e-notices on New Participant form, strict smarty
Monish Deb [Fri, 9 Jun 2023 04:08:11 +0000 (09:38 +0530)]
Merge pull request #26485 from colemanw/searchKitExpires
SearchKit - Expose expires_date field to UI
Monish Deb [Fri, 9 Jun 2023 04:07:21 +0000 (09:37 +0530)]
Merge pull request #26480 from colemanw/fixLeak
dev/core#4348 - Fix leaky variable in SearchKit traits
Monish Deb [Fri, 9 Jun 2023 03:42:49 +0000 (09:12 +0530)]
Merge pull request #26483 from colemanw/searchKitButtons
SearchKit - Tidy up admin buttons and table header sort icons
Monish Deb [Fri, 9 Jun 2023 03:36:47 +0000 (09:06 +0530)]
Merge pull request #26460 from eileenmcnaughton/api4
Lower-case field name uf_group.post_URL, cancel_URL
Monish Deb [Fri, 9 Jun 2023 03:31:01 +0000 (09:01 +0530)]
Merge pull request #26484 from colemanw/searchKitModified
SearchKit - Fix saving created/modified fields
colemanw [Fri, 9 Jun 2023 02:26:02 +0000 (22:26 -0400)]
SearchKit - Expose expires_date field to UI
colemanw [Fri, 9 Jun 2023 01:28:10 +0000 (21:28 -0400)]
SearchKit - Fix saving created/modified fields
Don't select created/modified id or date fields when loading SavedSearch so they don't get sent back
as values. The BAO will then be free to auto-fill them.
colemanw [Fri, 9 Jun 2023 00:54:17 +0000 (20:54 -0400)]
SearchKit - Tidy up table headers
Eileen McNaughton [Fri, 9 Jun 2023 00:37:06 +0000 (12:37 +1200)]
Merge pull request #26482 from colemanw/redundantVar
Remove redundant variable declared in the parent class
colemanw [Fri, 9 Jun 2023 00:36:40 +0000 (20:36 -0400)]
SearchKit - Tidy up admin buttons
Eileen McNaughton [Fri, 9 Jun 2023 00:36:38 +0000 (12:36 +1200)]
Merge pull request #26481 from eileenmcnaughton/notice
Attempt to fix some form notices on Contact Edit form new contact