Bradley Taylor [Sun, 11 Sep 2022 17:27:30 +0000 (18:27 +0100)]
[REF] Fix syntax of var docblocks
demeritcowboy [Sun, 11 Sep 2022 16:17:01 +0000 (12:17 -0400)]
Merge pull request #24495 from braders/phpdoc-fixes-4
More PHPdoc fixes
Bradley Taylor [Sun, 11 Sep 2022 13:33:41 +0000 (14:33 +0100)]
More PHPdoc fixes
demeritcowboy [Fri, 9 Sep 2022 23:16:31 +0000 (19:16 -0400)]
Merge pull request #24493 from totten/master-slashslash
(REF) SettingsMetadata - Small cleanup to prevent duplicate slashes
demeritcowboy [Fri, 9 Sep 2022 23:15:11 +0000 (19:15 -0400)]
Merge pull request #24492 from yashodha/dev_3790
(dev/core#3790) Pledge status is missing on View Pledge page
Tim Otten [Fri, 9 Sep 2022 20:21:11 +0000 (13:21 -0700)]
(REF) SettingsMetadata - Small cleanup to prevent duplicate slashes
demeritcowboy [Fri, 9 Sep 2022 13:01:29 +0000 (09:01 -0400)]
Merge pull request #24428 from braders/financial-192
dev/financial#192 Fallback to custom currency object for codes which Brick\Money does not support.
demeritcowboy [Fri, 9 Sep 2022 13:01:01 +0000 (09:01 -0400)]
Merge pull request #24489 from shaneonabike/pr24470
Adding better wording to Events page for matching dates
yashodha [Fri, 9 Sep 2022 12:09:04 +0000 (17:39 +0530)]
(dev/core#3790) Pledge status is missing on View Pledge page
colemanw [Fri, 9 Sep 2022 01:27:29 +0000 (21:27 -0400)]
Merge pull request #24332 from eileenmcnaughton/smarty_sig_html
Fix email notices on email edit block
Tim Otten [Fri, 9 Sep 2022 01:05:21 +0000 (18:05 -0700)]
Merge pull request #24490 from totten/master-filescan
File::findFiles - Save 200 million nanoseconds
colemanw [Fri, 9 Sep 2022 00:57:23 +0000 (20:57 -0400)]
Merge pull request #24485 from eileenmcnaughton/import_cont_soft
dev/core#1172 Fix Contribution import to handle ContributionSoft in a storable way
demeritcowboy [Fri, 9 Sep 2022 00:39:49 +0000 (20:39 -0400)]
Merge pull request #24480 from totten/master-global
ClassScanner - Fix guard for preboot cache scenario
Tim Otten [Thu, 8 Sep 2022 22:08:29 +0000 (15:08 -0700)]
File::findFiles - Save 200 million nanoseconds
Eileen McNaughton [Thu, 8 Sep 2022 04:59:16 +0000 (16:59 +1200)]
dev/core#1172 Fix Contribution import to handle ContributionSoft in a storable way
Eileen McNaughton [Thu, 8 Sep 2022 12:05:06 +0000 (00:05 +1200)]
[REF] Extract code to delete existing soft credit
Eileen McNaughton [Thu, 8 Sep 2022 12:12:22 +0000 (00:12 +1200)]
Fold importableFields back into setMetadata - per the code todo
Eileen McNaughton [Thu, 8 Sep 2022 11:53:59 +0000 (23:53 +1200)]
Move header handling to the Form layer in import
colemanw [Thu, 8 Sep 2022 18:49:16 +0000 (14:49 -0400)]
Merge pull request #24409 from eileenmcnaughton/notice_contribution
Fix some notices on New Contribution page (smarty)
colemanw [Thu, 8 Sep 2022 18:48:07 +0000 (14:48 -0400)]
Merge pull request #24484 from eileenmcnaughton/map_form
[REF] Cleanup code to getAvailableFields on Contribution MapField
Eileen McNaughton [Thu, 8 Sep 2022 05:27:36 +0000 (17:27 +1200)]
Merge pull request #24481 from totten/master-testreg
MailingSystemTest - Fix invalid PHP
Eileen McNaughton [Thu, 8 Sep 2022 05:13:39 +0000 (17:13 +1200)]
[REF] Cleanup code to getAvailableFields on Contribution MapField
Tim Otten [Thu, 8 Sep 2022 01:41:05 +0000 (18:41 -0700)]
MailingSystemTest - Fix invalid PHP
Tim Otten [Thu, 8 Sep 2022 00:40:44 +0000 (17:40 -0700)]
ClassScanner - Fix guard for preboot cache scenario
I wanted to inspect how caches were getting setup during test-runs. So I applied
this hack https://github.com/civicrm/civicrm-core/commit/
02106e8693d13ced7a151834a4188ce8b16f6444
and then ran some tests, eg
```
CIVICRM_UF=UnitTests phpunit8 tests/phpunit/CRM/Case/WorkflowMessage/CaseActivityTest.php
```
You can see the change in the HitOrMiss report (displayed after the test).
Before
======
```
OK (3 tests, 38 assertions)
HitOrMiss: {
"ClassScanner::cache(index) => Early usage": 13,
"ClassScanner::cache(structure) => New arraycache": 1
}
```
After
=====
```
OK (3 tests, 38 assertions)
HitOrMiss: {
"ClassScanner::cache(index) => create(...)": 1,
"ClassScanner::cache(structure) => New arraycache": 2
}
```
Shane Bill [Tue, 6 Sep 2022 18:11:53 +0000 (15:11 -0300)]
Adding better wording to Events page for matching dates
colemanw [Wed, 7 Sep 2022 14:14:14 +0000 (10:14 -0400)]
Merge pull request #24471 from colemanw/fixDateDefault
Afform - Fix setting default value for date filter fields
colemanw [Wed, 7 Sep 2022 14:12:31 +0000 (10:12 -0400)]
Merge pull request #24468 from jmcclelland/serialize-variable-length
allow contact reference custom fields to have lengths greater than 255 characters
Eileen McNaughton [Wed, 7 Sep 2022 03:03:59 +0000 (15:03 +1200)]
Merge pull request #24475 from eileenmcnaughton/import_available
Adjust contribution metadata to filter at display not load
Eileen McNaughton [Wed, 7 Sep 2022 03:03:42 +0000 (15:03 +1200)]
Merge pull request #24474 from eileenmcnaughton/import_dupe_fn
[REF] Extract rule-loading function
Eileen McNaughton [Wed, 7 Sep 2022 03:03:30 +0000 (15:03 +1200)]
Merge pull request #24473 from eileenmcnaughton/import_const
Follow up code simplification - no need to map 'Individual' to 'Individual'
Eileen McNaughton [Tue, 6 Sep 2022 23:25:13 +0000 (11:25 +1200)]
[REF] Extract rule-loading function
This makes it possible to load multiple dedupe rules at once
Eileen McNaughton [Tue, 6 Sep 2022 23:41:03 +0000 (11:41 +1200)]
Adjust contribution metadata to filter at display not load
Eileen McNaughton [Tue, 6 Sep 2022 23:20:14 +0000 (11:20 +1200)]
Follow up code simplification - no need to map 'Individual' to 'Individual'
Coleman Watts [Tue, 6 Sep 2022 18:19:09 +0000 (14:19 -0400)]
Afform - Fix setting default value for date filter fields
Fixes dev/core#3111
Jamie McClelland [Tue, 6 Sep 2022 14:29:57 +0000 (10:29 -0400)]
allow serialized custom fields to have bigger lengths
Before all serialized fields were hard-coded to varchar(255). With
this change, they take the given text_length, ensuring we have at
least 255 in length.
Eileen McNaughton [Tue, 6 Sep 2022 10:45:34 +0000 (22:45 +1200)]
Merge pull request #24464 from eileenmcnaughton/saved_mapping_contact
[Ref] [Import] Simplify form event MapField (Contact)
Eileen McNaughton [Tue, 6 Sep 2022 07:22:44 +0000 (19:22 +1200)]
Merge pull request #24465 from eileenmcnaughton/import_const
Remove silly constants for Contact Types (import)
Eileen McNaughton [Tue, 6 Sep 2022 00:01:52 +0000 (12:01 +1200)]
[Ref] [Import] Simplify form event MapField (Contact)
Seamus Lee [Tue, 6 Sep 2022 06:19:11 +0000 (16:19 +1000)]
Merge pull request #24463 from eileenmcnaughton/saved_mapping
[Ref] [Import] Simplify form event MapField to use shared rule (Participant)
Eileen McNaughton [Tue, 6 Sep 2022 06:17:25 +0000 (18:17 +1200)]
Merge pull request #24462 from seamuslee001/remove_setting_api_civimail
[REF] Remove calls to settings from angularjs to php layer to assist …
Tim Otten [Tue, 6 Sep 2022 05:36:08 +0000 (22:36 -0700)]
Merge pull request #24396 from eileenmcnaughton/run_back
Fix import classes to call `runAllInteractive()` rather than `runAllViaWeb` (which in practice currently just calls `runAllViaWeb` )
Eileen McNaughton [Tue, 6 Sep 2022 02:35:39 +0000 (14:35 +1200)]
Merge pull request #24461 from eileenmcnaughton/import_meta
Re-run regen
Eileen McNaughton [Tue, 6 Sep 2022 01:16:24 +0000 (13:16 +1200)]
Remove reference to constants in dedupe rule ajax (which is yuck)
Seamus Lee [Mon, 5 Sep 2022 22:59:07 +0000 (08:59 +1000)]
[REF] Remove calls to settings from angularjs to php layer to assist with less permissioned users using civimail
Eileen McNaughton [Tue, 6 Sep 2022 00:29:19 +0000 (12:29 +1200)]
Remove silly constants for Contact Types (import)
colemanw [Tue, 6 Sep 2022 00:08:18 +0000 (20:08 -0400)]
Merge pull request #24429 from eileenmcnaughton/field_dep
Mark some more fields deprecated or readonly
Eileen McNaughton [Mon, 5 Sep 2022 23:54:58 +0000 (11:54 +1200)]
[Ref] [Import] Simplify form event MapField to use shared rule
Seamus Lee [Mon, 5 Sep 2022 23:47:03 +0000 (09:47 +1000)]
Merge pull request #24304 from mattwire/participantcontacthook
dev/core#3778 Add code hook to set civicrm_participant.created_id
Eileen McNaughton [Mon, 5 Sep 2022 22:40:51 +0000 (10:40 +1200)]
Run regen
Eileen McNaughton [Mon, 5 Sep 2022 22:35:39 +0000 (10:35 +1200)]
Merge pull request #24444 from totten/master-lang-list
Languages - Dropdown lists should reflect supported languages
colemanw [Mon, 5 Sep 2022 16:01:26 +0000 (12:01 -0400)]
Merge pull request #23604 from colemanw/afformValidate
Afform - Implement client-side validation of required fields
colemanw [Mon, 5 Sep 2022 13:38:50 +0000 (09:38 -0400)]
Merge pull request #24441 from eileenmcnaughton/import_meta
Fix Import metadata to use apiv4 for contact on contribution imports
Eileen McNaughton [Mon, 5 Sep 2022 07:15:55 +0000 (19:15 +1200)]
Merge pull request #24427 from braders/no-contributions-warning
Stop PHP warning on installations with no contributions
Eileen McNaughton [Thu, 1 Sep 2022 02:38:13 +0000 (14:38 +1200)]
Switch to api metadata for contact on non-contact imports
This is kinda 'safe' in that these imports only support non-unique contact
fields
Eileen McNaughton [Mon, 5 Sep 2022 02:14:17 +0000 (14:14 +1200)]
Fix contribution import mapping validation, add test
Eileen McNaughton [Mon, 5 Sep 2022 06:36:17 +0000 (18:36 +1200)]
Merge pull request #24453 from seamuslee001/unit_test_reply
[NFC] Add in Unit test to test domain token replacement in Reply process
Seamus Lee [Mon, 5 Sep 2022 00:08:56 +0000 (10:08 +1000)]
[NFC] Add in Unit test to test domain token replacement in Reply process
Check for do not reply and also from email and to email
Eileen McNaughton [Mon, 5 Sep 2022 02:13:39 +0000 (14:13 +1200)]
Add test for Mapping form validation, contribution import
Eileen McNaughton [Fri, 2 Sep 2022 02:35:23 +0000 (14:35 +1200)]
Remove soft credit validation
It is not possible in the UI to deselect the soft-credit-field field so
let's not validate
Eileen McNaughton [Sun, 4 Sep 2022 21:44:47 +0000 (09:44 +1200)]
Merge pull request #24452 from totten/master-queue-stats
CRM_Queue_Queue - Add 'getStatistic($name)'. Deprecate 'numberOfItems()'
Seamus Lee [Sat, 3 Sep 2022 22:51:08 +0000 (08:51 +1000)]
Merge pull request #24442 from eileenmcnaughton/depp
Increase the deprecation on some unused functions
colemanw [Sat, 3 Sep 2022 14:11:20 +0000 (10:11 -0400)]
Merge pull request #24451 from colemanw/fixSearchDateRangeFilters
Afform - Fix date range filters for search displays
Tim Otten [Sat, 3 Sep 2022 05:16:39 +0000 (22:16 -0700)]
(REF) UserJob - Switch numberOfItems to getStatistic()
Tim Otten [Sat, 3 Sep 2022 04:33:58 +0000 (21:33 -0700)]
(REF) Update queue tests to use getStatistics()
Tim Otten [Sat, 3 Sep 2022 01:55:52 +0000 (18:55 -0700)]
CRM_Queue_Queue - Add 'getStatistic($name)'. Deprecate 'numberOfItems()'
Should `numberOfItems()` tell you the _total_ number of items -- or the
number of _ready_ items? Trick question. They can tell you different
things:
* When implementing a task-worker (which should start/stop based
on available tasks), you'd use _ready_ items.
* When implementing `existsQueue()` (which tells if you the queue
has anything at all), you'd use _total_ items.
This trick-question is why different implementations have computed
`numberOfItems()` in different ways.
This patch resolves the trick-question by deprecating `numberOfItems()`
and replacing it with `getStatistic($name)`.
Coleman Watts [Sat, 3 Sep 2022 02:58:29 +0000 (22:58 -0400)]
Afform - Fix setting default required value
Coleman Watts [Thu, 26 May 2022 18:27:03 +0000 (14:27 -0400)]
Afform - Implement client-side validation of required fields
Coleman Watts [Sat, 3 Sep 2022 02:38:10 +0000 (22:38 -0400)]
Afform - Fix date range filters for search displays
Fixes dev/core#3690
Eileen McNaughton [Thu, 1 Sep 2022 23:32:14 +0000 (11:32 +1200)]
Imcrease the deprecation on some unused functions
Eileen McNaughton [Mon, 29 Aug 2022 20:55:24 +0000 (08:55 +1200)]
Fix queue runner not progressing
demeritcowboy [Fri, 2 Sep 2022 15:48:28 +0000 (11:48 -0400)]
Merge pull request #24447 from braders/sprintf-fix
(NFC) Fix sprintf syntax
demeritcowboy [Fri, 2 Sep 2022 15:31:07 +0000 (11:31 -0400)]
Merge pull request #24421 from artfulrobot/dev-core/3823
Improve scheduled reminder form labels. Resolves issue core/3823
Bradley Taylor [Fri, 2 Sep 2022 12:33:22 +0000 (13:33 +0100)]
(NFC) fix sprintf syntax
Eileen McNaughton [Fri, 2 Sep 2022 04:03:25 +0000 (16:03 +1200)]
Merge pull request #24437 from colemanw/deprecatedMgdFn
[REF] ManagedEntities - Move deprecated function
demeritcowboy [Fri, 2 Sep 2022 02:58:07 +0000 (22:58 -0400)]
Merge pull request #24316 from eileenmcnaughton/email_greeting
Use preferred `{contact.email_greeting_display}` token over deprecated `{contact.email_greeting}` in ALL templates
Eileen McNaughton [Fri, 2 Sep 2022 02:39:19 +0000 (14:39 +1200)]
Merge pull request #24235 from masetto/welcome_tokens
Add support for Contact tokens in welcome email using TokenProcessor
Eileen McNaughton [Fri, 2 Sep 2022 02:14:54 +0000 (14:14 +1200)]
Merge pull request #24443 from eileenmcnaughton/depped
Remove function after two years of noisy deprecation
Tim Otten [Fri, 2 Sep 2022 01:31:38 +0000 (18:31 -0700)]
message_admin - Re-enable single-language display for single-language deployments
Coleman Watts [Thu, 1 Sep 2022 15:24:21 +0000 (11:24 -0400)]
ManagedEntities - Move deprecated function
Eileen McNaughton [Fri, 2 Sep 2022 01:09:48 +0000 (13:09 +1200)]
Merge pull request #24174 from totten/master-lang
Message Templates - Allow rendering & previewing of translated messages
Eileen McNaughton [Fri, 2 Sep 2022 01:09:04 +0000 (13:09 +1200)]
Merge pull request #24433 from eileenmcnaughton/required_checker
REF] Standardise validation of mapped fields in imports, fix over-zealous requirements when matching on trxn_id, invoice_id for update
Tim Otten [Fri, 2 Sep 2022 00:55:02 +0000 (17:55 -0700)]
message_admin - Filter language list (depending on `partial_locales` etc)
Tim Otten [Tue, 30 Aug 2022 01:48:22 +0000 (18:48 -0700)]
APIv4 $languages - Adapt based on 'partial_locales' setting
Eileen McNaughton [Thu, 1 Sep 2022 23:45:32 +0000 (11:45 +1200)]
Remove function after two years of noisy deprecation
Tim Otten [Thu, 1 Sep 2022 23:16:33 +0000 (16:16 -0700)]
Merge pull request #24438 from braders/3833-downloader
dev/core#3833 Update CRM_Extension_Downloader to not use dynamic properties
Tim Otten [Thu, 1 Sep 2022 23:13:43 +0000 (16:13 -0700)]
Merge pull request #24435 from colemanw/managedDelete
ManagedEntity - Ensure managed record is consistently deleted
Eileen McNaughton [Thu, 1 Sep 2022 22:50:17 +0000 (10:50 +1200)]
Merge pull request #24434 from demeritcowboy/invoice-crash
dev/financial#208 - Fix crash for invoice button
Eileen McNaughton [Thu, 1 Sep 2022 02:50:09 +0000 (14:50 +1200)]
[REF] Standardise validation of mapped fields in imports
Tim Otten [Thu, 1 Sep 2022 21:54:16 +0000 (14:54 -0700)]
Merge pull request #24425 from braders/remove-method-getActionAttribute
Remove method getActionAttribute
Eileen McNaughton [Thu, 1 Sep 2022 21:52:35 +0000 (09:52 +1200)]
Merge pull request #24436 from braders/core-3831
dev/core#3831 Deprecated string interpolation
Seamus Lee [Thu, 1 Sep 2022 21:49:33 +0000 (07:49 +1000)]
Merge pull request #24440 from braders/3833-runner
dev/core#3833 Update CRM_Extension_Downloader to not use dynamic properties
Tim Otten [Thu, 1 Sep 2022 21:49:17 +0000 (14:49 -0700)]
Merge pull request #24394 from eileenmcnaughton/user_job_delete
When updating userJob status to match queue status skip permission check
Eileen McNaughton [Thu, 1 Sep 2022 21:46:12 +0000 (09:46 +1200)]
Merge pull request #24439 from braders/financialitem-add-docblock-fix
Fix PHPDoc comment for CRM_Financial_BAO_FinancialItem::add
Eileen McNaughton [Thu, 1 Sep 2022 21:32:00 +0000 (09:32 +1200)]
Fix UI bug
demeritcowboy [Thu, 1 Sep 2022 12:53:15 +0000 (08:53 -0400)]
fix crash for invoice button
Bradley Taylor [Thu, 1 Sep 2022 18:57:30 +0000 (19:57 +0100)]
Define CRM_Queue_Runner::lastTaskTitle before it is used, so it is not treated as a dynamic property
Bradley Taylor [Thu, 1 Sep 2022 18:45:55 +0000 (19:45 +0100)]
Fix PHPDoc comment for CRM_Financial_BAO_FinancialItem::add
Bradley Taylor [Wed, 31 Aug 2022 18:57:29 +0000 (19:57 +0100)]
dev/financial#192 Fallback to custom currency object for codes which Brick does not support
Bradley Taylor [Thu, 1 Sep 2022 17:59:08 +0000 (18:59 +0100)]
Update CRM_Extension_Downloader to not use dynamic properties
Bradley Taylor [Thu, 1 Sep 2022 15:05:48 +0000 (16:05 +0100)]
core/3831 Deprecated string interpolation