eileen [Mon, 8 Oct 2018 21:00:15 +0000 (22:00 +0100)]
Convert Contact Search to metadata driven
eileen [Mon, 8 Oct 2018 20:37:01 +0000 (21:37 +0100)]
Add metadata for editing contacts
eileen [Mon, 8 Oct 2018 20:27:33 +0000 (21:27 +0100)]
Convert 'Viewing Smart Groups' on admin display preferences to use metadata.
This has no functional impact - cleanup only
eileen [Mon, 8 Oct 2018 20:27:33 +0000 (21:27 +0100)]
Convert 'Viewing Smart Groups' on admin display preferences to use metadata.
This has no functional impact - cleanup only
Eileen McNaughton [Wed, 10 Oct 2018 08:27:00 +0000 (09:27 +0100)]
Merge pull request #12910 from monishdeb/dev-core-394
(dev/core#394) : Wildcards are ignored in some smart group criteria, when the smart group is directly generated for a mailing
Eileen McNaughton [Wed, 10 Oct 2018 08:09:42 +0000 (09:09 +0100)]
Merge pull request #12890 from dereklewis123/CW-905-2
core/384 CiviSMS does not fall back to non-primary mobile number
Seamus Lee [Wed, 10 Oct 2018 02:33:55 +0000 (13:33 +1100)]
Merge pull request #12784 from eileenmcnaughton/cache
Do not treat an empty array as not set in caches.
Eileen McNaughton [Tue, 9 Oct 2018 20:42:18 +0000 (21:42 +0100)]
Merge pull request #12914 from eileenmcnaughton/record
Fix payment hangs when registering a user for a paid event without recording payment
Eileen McNaughton [Tue, 9 Oct 2018 20:38:53 +0000 (21:38 +0100)]
Merge pull request #12864 from eileenmcnaughton/export
Export - small cleanup
Monish Deb [Tue, 9 Oct 2018 12:00:37 +0000 (17:30 +0530)]
(dev/core#394) : Wildcards are ignored in some smart group criteria, when the smart group is directly generated for a mailing
Eileen McNaughton [Tue, 9 Oct 2018 19:47:57 +0000 (20:47 +0100)]
Merge pull request #12913 from wmortada/shorcuts
Fix typo in hook that enables links to be added to a block
Eileen McNaughton [Tue, 9 Oct 2018 19:47:06 +0000 (20:47 +0100)]
Merge pull request #12819 from mattwire/contributionrecur_contactname
Show contact name on recurring contribution view and improve consistency with Contribution/Membership view
eileen [Tue, 9 Oct 2018 18:07:26 +0000 (19:07 +0100)]
Fix payment hangs when registering a user for a paid event without recording payment
This is an alternative to https://github.com/civicrm/civicrm-core/pull/12888
I wasn't actually able to reproduce the issue but this solution, proposed by
Monish, seems safe & sensible
Eileen McNaughton [Tue, 9 Oct 2018 18:02:24 +0000 (19:02 +0100)]
Merge pull request #12841 from colemanw/richText
Skip html encoding rich-text fields
Eileen McNaughton [Tue, 9 Oct 2018 18:00:56 +0000 (19:00 +0100)]
Merge pull request #12912 from civicrm/totten-patch-1
Fix spelling error ("sript" vs "script")
William Mortada [Tue, 9 Oct 2018 18:00:55 +0000 (19:00 +0100)]
Fix typo in hook that enables links to be added to a block
Eileen McNaughton [Tue, 9 Oct 2018 16:50:42 +0000 (17:50 +0100)]
Merge pull request #12904 from yashodha/report-fixes
On reports make current employer available as a field for display
Eileen McNaughton [Tue, 9 Oct 2018 16:11:17 +0000 (17:11 +0100)]
Merge pull request #12891 from jmcclelland/issue418
ensure all valid relationship types are available
Tim Otten [Tue, 9 Oct 2018 15:55:55 +0000 (16:55 +0100)]
Update Drupal.php
If my username is going to be used for a grammatical edit, then we should get it right!
Tim Otten [Tue, 9 Oct 2018 14:44:12 +0000 (15:44 +0100)]
Fix spelling error ' script' rather than 'sript'
Eileen McNaughton [Tue, 9 Oct 2018 13:27:37 +0000 (14:27 +0100)]
Merge pull request #12824 from jmcclelland/issue389
Ensure relative dates are preserved for custom fields in smart group
Eileen McNaughton [Tue, 9 Oct 2018 13:23:34 +0000 (14:23 +0100)]
Merge pull request #12911 from civicrm/5.7
5.7 to master
Eileen McNaughton [Tue, 9 Oct 2018 13:22:49 +0000 (14:22 +0100)]
Merge pull request #12909 from eileenmcnaughton/57reg
Ensure hard-coded date ranges are preserved in smart groups
Eileen McNaughton [Tue, 9 Oct 2018 12:23:14 +0000 (13:23 +0100)]
Merge pull request #11821 from michaelmcandrew/500-http-response-code
Send an 500 http response code when an exception is encountered.
Eileen McNaughton [Tue, 9 Oct 2018 11:39:06 +0000 (12:39 +0100)]
Merge pull request #12873 from totten/master-short-long
Register "short" and "long" cache services
Jamie McClelland [Mon, 17 Sep 2018 17:02:03 +0000 (13:02 -0400)]
ensure date ranges are preserved in smart groups
See https://lab.civicrm.org/dev/core/issues/396
Eileen McNaughton [Tue, 9 Oct 2018 08:57:46 +0000 (09:57 +0100)]
Merge pull request #12903 from kainuk/drupal8-codegen-path
Added a path to the drupal8 path candidates to find civicrm.config.php
Eileen McNaughton [Tue, 9 Oct 2018 07:02:12 +0000 (08:02 +0100)]
Merge pull request #12908 from xurizaemon/GL425-warning_on_redirectToSSL
GL-425: Log a message if CiviCRM thinks SSL is not enabled
Eileen McNaughton [Tue, 9 Oct 2018 05:30:48 +0000 (06:30 +0100)]
Merge pull request #12907 from civicrm/5.7
5.7
Chris Burgess [Tue, 9 Oct 2018 05:16:24 +0000 (18:16 +1300)]
GL-425: Log a message if CiviCRM thinks SSL is not enabled
The enableSSL setting doesn't reliably detect the presence of SSL (especially
when behind SSL terminating proxies). This log message will allow people
affected by this behaviour to more readily debug it, because CiviCRM
will give them a clue to work with.
See https://lab.civicrm.org/dev/core/issues/425
Seamus Lee [Mon, 8 Oct 2018 23:48:44 +0000 (10:48 +1100)]
Merge pull request #12896 from seamuslee001/dev_core_421
dev/core#421 Fix issue where creating user driven message templates w…
Seamus Lee [Fri, 5 Oct 2018 02:31:38 +0000 (12:31 +1000)]
dev/core#421 Fix issue where creating user driven message templates was requireing the ssystem workflow message template permission as well
Wrap permission checking in the check_permissions param
Move Permission checking to BAO level from API
Allow for the fact that edit message templates permission should still be able to work on both sets of templates without the granular permissions. Also reduce duplication of code abit
Seamus Lee [Mon, 8 Oct 2018 20:59:53 +0000 (07:59 +1100)]
Merge pull request #12905 from totten/master-gitignore
Add `ext/` folder to .gitignore
Eileen McNaughton [Mon, 8 Oct 2018 16:44:19 +0000 (17:44 +0100)]
Merge pull request #12731 from eileenmcnaughton/setting_form
Setting form - start to sync preferences with Setting, using trait
eileen [Sun, 26 Aug 2018 23:34:00 +0000 (11:34 +1200)]
Make checkboxes save
Tim Otten [Mon, 8 Oct 2018 12:59:50 +0000 (13:59 +0100)]
Add `ext/` folder to .gitignore
This folder is populated in various build processes (civibuild's
`drupal-demo`, `wp-demo`, etc; as well as `distmaker`), and sometimes
I like to use it for personal things. Moreover, there is no committed
content inside here.
Eileen McNaughton [Mon, 8 Oct 2018 11:46:44 +0000 (12:46 +0100)]
Merge pull request #12902 from seamuslee001/towards_500
Move towards allowing sending 500 http errors back by switching civiE…
yashodha [Mon, 8 Oct 2018 11:41:04 +0000 (17:11 +0530)]
expose current employer in fields and display in results as well
Klaas Eikelboom [Mon, 8 Oct 2018 11:16:44 +0000 (13:16 +0200)]
Added a path to the drupal8 path candidates to find civicrm.config.php.drupal. So civbuild can find it
Seamus Lee [Mon, 8 Oct 2018 10:33:08 +0000 (21:33 +1100)]
Move towards allowing sending 500 http errors back by switching civiExit(1) to be just civiExit()
Seamus Lee [Mon, 8 Oct 2018 07:59:25 +0000 (18:59 +1100)]
Merge pull request #12898 from kenwest/dev_core_423
dev/core#423 MySQL 5.7 complains about 4.7.19 upgrade script
Eileen McNaughton [Sun, 7 Oct 2018 22:01:43 +0000 (23:01 +0100)]
Merge pull request #12829 from eileenmcnaughton/validate
Add validate api action for ContributionPage.submit
Eileen McNaughton [Sun, 7 Oct 2018 20:58:48 +0000 (21:58 +0100)]
Merge pull request #12900 from eileenmcnaughton/recur_tidy
[NFC] Minor cleanup, return preferred parameter
Tim Otten [Sun, 7 Oct 2018 15:07:04 +0000 (16:07 +0100)]
Merge pull request #12869 from dereklewis123/CW-892
Added missing field name in custom-field deletion dialog
eileen [Mon, 17 Sep 2018 02:58:42 +0000 (14:58 +1200)]
Add validate api action for ContributionPage.submit
eileen [Sun, 26 Aug 2018 22:39:51 +0000 (10:39 +1200)]
Move setting defaults to form
eileen [Sun, 26 Aug 2018 22:29:34 +0000 (10:29 +1200)]
Allow Preferences form to work from settings
eileen [Sun, 7 Oct 2018 10:54:25 +0000 (11:54 +0100)]
[NFC] Minor cleanup, return preferred parameter
The result parameter is the same as $recurring (save()) returns $this. But
it's more correct to return $recurring than result as
a) it's defined as a Contribute_BAO_ContributionRecur object which is correct.
b) it's the object passed through hooks
Eileen McNaughton [Sun, 7 Oct 2018 10:44:08 +0000 (11:44 +0100)]
Merge pull request #12899 from eileenmcnaughton/recur_tpl
Recur tpl
eileen [Sun, 7 Oct 2018 09:23:26 +0000 (10:23 +0100)]
Extract rows section of recur template to separate tpl, for readability
Eileen McNaughton [Sun, 7 Oct 2018 08:07:19 +0000 (09:07 +0100)]
Merge pull request #12821 from mattwire/updatesubscription_fix
Show recurring contribution links based on payment processor capabilities
Monish Deb [Sat, 6 Oct 2018 17:56:59 +0000 (23:26 +0530)]
Merge pull request #12875 from jitendrapurohit/core-411
dev/core#411 - Default currency shown on View participant and contrib…
Eileen McNaughton [Sat, 6 Oct 2018 17:49:11 +0000 (18:49 +0100)]
Merge pull request #12893 from samuelsov/NFC-datatables-style
(NFC) Make datatables in Activities Relationship tab adjust to screen size
Eileen McNaughton [Sat, 6 Oct 2018 15:14:13 +0000 (16:14 +0100)]
Merge pull request #12868 from mattwire/updatesubscription_datepicker
Switch UpdateSubscription to use datepicker
Eileen McNaughton [Sat, 6 Oct 2018 10:06:10 +0000 (11:06 +0100)]
Merge pull request #12897 from jmcclelland/issue422
ensure search on survey results works properly
Ken West [Sat, 6 Oct 2018 08:25:12 +0000 (18:25 +1000)]
MySQL 5.7 may bork when comparing datetime columns to '0000-00-00 00:00:00' so cast the column to a CHAR(20) when comparing
Jamie McClelland [Fri, 5 Oct 2018 20:55:51 +0000 (16:55 -0400)]
ensure search on survey results works properly
https://lab.civicrm.org/dev/core/issues/422
Monish Deb [Fri, 5 Oct 2018 20:38:25 +0000 (02:08 +0530)]
Merge pull request #12884 from colemanw/Remove
Remove crm.admin.js
Eileen McNaughton [Fri, 5 Oct 2018 13:41:57 +0000 (14:41 +0100)]
Merge pull request #12892 from yashodha/report-fixes
CRM-21677 - report clean up
Seamus Lee [Fri, 5 Oct 2018 02:32:15 +0000 (12:32 +1000)]
Merge pull request #12895 from civicrm/5.7
5.7
Tim Otten [Wed, 3 Oct 2018 21:39:59 +0000 (17:39 -0400)]
Merge pull request #12894 from seamuslee001/5.7
5.7
Tim Otten [Wed, 3 Oct 2018 14:55:02 +0000 (10:55 -0400)]
Update 5.6.0.md
Tim Otten [Wed, 3 Oct 2018 14:53:04 +0000 (10:53 -0400)]
Update 5.6.0.md
eileen [Sun, 23 Sep 2018 01:42:01 +0000 (13:42 +1200)]
Fix missing amount in soft credit mode
Andrew Hunt [Thu, 27 Sep 2018 20:53:46 +0000 (16:53 -0400)]
5.6.0 release notes: reorganize sections and fix up contributors
Alice Frumin [Thu, 27 Sep 2018 20:22:23 +0000 (16:22 -0400)]
5.6.0 release notes: bulk of edits
Andrew Hunt [Thu, 13 Sep 2018 16:18:48 +0000 (12:18 -0400)]
5.6.0 release notes: added boilerplate
Andrew Hunt [Thu, 13 Sep 2018 16:15:54 +0000 (12:15 -0400)]
5.6.0 release notes: raw from script
CiviCRM [Wed, 3 Oct 2018 18:28:56 +0000 (18:28 +0000)]
Set version to 5.8.alpha1
CiviCRM [Wed, 3 Oct 2018 18:24:33 +0000 (18:24 +0000)]
Set version to 5.7.beta1
Samuel Vanhove [Wed, 3 Oct 2018 15:45:26 +0000 (11:45 -0400)]
(NFC) Make datatables in Activities and Relationship tab adjust to the screen size
yashodha [Wed, 3 Oct 2018 14:16:56 +0000 (19:46 +0530)]
CRM-21677 - report clean up
Eileen McNaughton [Wed, 3 Oct 2018 00:25:43 +0000 (13:25 +1300)]
Merge pull request #12885 from yashodha/report-fixes
CRM-21677 - report clean up
Jamie McClelland [Tue, 2 Oct 2018 14:57:00 +0000 (10:57 -0400)]
ensure all valid relationship types are available
When adding relationships to search results, ensure all relationship
types, including ones that apply to any contact, are available to
choose.
https://lab.civicrm.org/dev/core/issues/418
dl617 [Tue, 2 Oct 2018 14:09:33 +0000 (15:09 +0100)]
core/384 fix the the problem with not using a non-primary mobile number
dl617 [Tue, 2 Oct 2018 12:09:07 +0000 (13:09 +0100)]
core/384 failing test for mobile phone type
Seamus Lee [Mon, 1 Oct 2018 21:39:59 +0000 (07:39 +1000)]
Merge pull request #12882 from colemanw/extpage
Fix invalid markup on extension page - remove dots from ids & classes
yashodha [Mon, 1 Oct 2018 11:19:33 +0000 (16:49 +0530)]
CRM-21677 - report clean up
Coleman Watts [Mon, 1 Oct 2018 01:36:14 +0000 (21:36 -0400)]
Remove crm.admin.js
Coleman Watts [Sat, 29 Sep 2018 19:29:30 +0000 (15:29 -0400)]
Fix invalid markup on extension page - remove dots from ids & classes
Tim Otten [Sat, 29 Sep 2018 00:56:18 +0000 (20:56 -0400)]
Merge pull request #12876 from colemanw/Don't
Don't mess up fragment links in nav menu
Seamus Lee [Fri, 28 Sep 2018 11:35:32 +0000 (21:35 +1000)]
Merge pull request #12879 from totten/master-contact-settings
(DX) Civi::contactSettings - Add a facade for working with the logged-in user's settings
Seamus Lee [Fri, 28 Sep 2018 05:01:27 +0000 (15:01 +1000)]
Merge pull request #12878 from colemanw/menu-icons
Add icons to top-level navigation menu
Seamus Lee [Fri, 28 Sep 2018 04:59:47 +0000 (14:59 +1000)]
Merge pull request #12877 from colemanw/MailingComponentDAO
Regenerate MailingComponent DAO file to reflect recent changes
Kevin Cristiano [Fri, 28 Sep 2018 02:13:58 +0000 (22:13 -0400)]
Regenerate sql for Add icons to top-level navigation menu (#7)
Tim Otten [Wed, 26 Sep 2018 23:19:45 +0000 (19:19 -0400)]
Register "short" and "long" cache services
Overview
--------
This is an improvement for developer-experience when working with caches.
It reduces the amount of boilerplate required for core-code or
extension-code in a typical caching use-case.
Before
------
* To use a short-lived/latency-optimized cache (e.g. Redis or PHP array),
you can work with the default cache instance (`Civi::cache('default')`.
* To use a long-lived/durability-optimized cache (e.g. Redis or SQL), there is no
simple way or code. You must [register a custom cache service](https://docs.civicrm.org/dev/en/latest/framework/cache/#example-named-service).
After
-----
* All the above remains true. Additionally, you can request the `short` or `long` cache service.
* To use a short-lived/latency-optimized cache, you can use `Civi::cache('short')`. (`short` and `default` are synonmyms.)
* To use a long-lived/durability-optimized cache, you can use use `Civi::cache('long')`.
Comments
--------
* After this is approved, we should update the [dev docs for caching](https://docs.civicrm.org/dev/en/latest/framework/cache/).
* There's a bike-sheddy argument about the naming. I'd be willing to rename if there was a strong reason, but I don't really think
there is a strong reason. This naming convention provides a simple dichotomy of `short` vs `long`.
Eileen McNaughton [Fri, 28 Sep 2018 01:16:06 +0000 (13:16 +1200)]
Merge pull request #12790 from alifrumin/core362
dev/core#362 fix search functionality of contact reference fields in On Behalf Profiles
Eileen McNaughton [Fri, 28 Sep 2018 01:14:23 +0000 (13:14 +1200)]
Merge pull request #12874 from seamuslee001/lab_core_410
dev/core#410 Ensure that Email related fields in Scheduled Reminders …
Coleman Watts [Fri, 28 Sep 2018 00:35:55 +0000 (20:35 -0400)]
Update activity_tab_filter setting code to use new fascade
Eileen McNaughton [Thu, 27 Sep 2018 23:01:31 +0000 (11:01 +1200)]
Merge pull request #12867 from mattwire/entityformajaxcustomdatafreeze
Freeze custom data elements when viewing an entity
Tim Otten [Thu, 27 Sep 2018 21:05:06 +0000 (17:05 -0400)]
(DX) Civi::contactSettings - Add a facade for working with the logged-in user's settings
Before
------
To read/write a setting for the logged-in user, you need a snippet like this:
```php
$cid = CRM_Core_Session::getLoggedInContactID();
$myFilter = Civi::service('settings_manager')
->getBagByContact(NULL, $cid)
->get('activity_tab_filter');
```
After
-----
To read/write a setting for the logged-in user, you can use a snippet like this:
```php
$myFilter = Civi::contactSettings()->get('activity_tab_filter');
```
Technical Details
-----------------
* A convenience function like this is liable to be used in lazy circumstances where
the developer is unlikely to check their conditions carefully. Therefore, the
errors are reported as exceptions so that mistakes are easiliy revealed.
* This is technically a small contract change to `SettingsManager::getBagByContact()`
because it now interprets `$contactId===NULL` as meaning "the logged-in user".
However, I don't think NULL was a sensible value before, and this interface
isn't widely known/used.
Coleman Watts [Thu, 27 Sep 2018 20:05:39 +0000 (16:05 -0400)]
Regenerate MailingComponent DAO file to reflect recent changes
Coleman Watts [Thu, 27 Sep 2018 19:52:36 +0000 (15:52 -0400)]
Fix bad menu name
Coleman Watts [Thu, 27 Sep 2018 19:45:52 +0000 (15:45 -0400)]
Add icons to nav menu
Alice Frumin [Thu, 6 Sep 2018 18:08:45 +0000 (14:08 -0400)]
dev/core#362 fixing contact reference fields on On Behalf Profiles search and select functionality
Coleman Watts [Thu, 27 Sep 2018 19:03:47 +0000 (15:03 -0400)]
Don't mess up fragment links in nav menu
Jitendra Purohit [Thu, 27 Sep 2018 07:12:29 +0000 (12:42 +0530)]
dev/core#411 - Default currency shown on View participant and contribution page if payment is made with different currency
Seamus Lee [Thu, 27 Sep 2018 05:35:10 +0000 (15:35 +1000)]
dev/core#410 Ensure that Email related fields in Scheduled Reminders are not required when creating an SMS reminder and ensure that SMS Text Message field is required when creating an SMS reminder
Seamus Lee [Wed, 26 Sep 2018 09:34:55 +0000 (19:34 +1000)]
Merge pull request #12871 from civicrm/5.6
Merge 5.6 to master
Matthew Wire (MJW Consulting) [Tue, 25 Sep 2018 10:41:30 +0000 (11:41 +0100)]
Freeze custom data elements when viewing an entity