Seamus Lee [Fri, 17 Nov 2023 07:43:58 +0000 (18:43 +1100)]
Merge pull request #28180 from eileenmcnaughton/notice_n
Reverse variable check to fix notice
Eileen McNaughton [Fri, 17 Nov 2023 03:19:04 +0000 (16:19 +1300)]
Reverse variable check to fix notice
colemanw [Fri, 17 Nov 2023 02:55:22 +0000 (21:55 -0500)]
Merge pull request #28165 from colemanw/mockTestMove
[REF] Afform - Namespace mock tests for autoloading
colemanw [Fri, 17 Nov 2023 02:53:50 +0000 (21:53 -0500)]
Merge pull request #28179 from totten/master-langs
setup/res/languages.php - Always generate style-compliant code
Tim Otten [Fri, 17 Nov 2023 01:51:56 +0000 (18:51 -0700)]
Merge pull request #28177 from eileenmcnaughton/mem_online_white
Reformat whitespace in online membership receipt
Tim Otten [Fri, 17 Nov 2023 01:47:30 +0000 (17:47 -0800)]
Regenerate `languages.php` and `langs.php`
Tim Otten [Fri, 17 Nov 2023 01:30:16 +0000 (17:30 -0800)]
GenCode - When generating 'setup/res/languages.php', it should be pass linter
Eileen McNaughton [Fri, 17 Nov 2023 00:19:21 +0000 (13:19 +1300)]
Reformat whitespace in online membership receipt
Seamus Lee [Fri, 17 Nov 2023 00:43:41 +0000 (11:43 +1100)]
Merge pull request #28172 from eileenmcnaughton/mem_online
Fix setting of misnamed property
colemanw [Thu, 16 Nov 2023 02:23:01 +0000 (21:23 -0500)]
Afform - Namespace mock tests for autoloading
Aidan Saunders [Thu, 16 Nov 2023 22:26:46 +0000 (22:26 +0000)]
Merge pull request #28173 from mattwire/contnewtab
Manage Contribution Pages: Open Live/Test page in new tab like old screen
Matthew Wire [Thu, 16 Nov 2023 21:04:46 +0000 (21:04 +0000)]
Manage Contribution Pages: Open Live/Test page in new tab like old screen
Eileen McNaughton [Thu, 16 Nov 2023 20:45:10 +0000 (09:45 +1300)]
Fix setting of misnamed property
The property is ID, not id
demeritcowboy [Thu, 16 Nov 2023 15:43:00 +0000 (10:43 -0500)]
Merge pull request #28139 from mlutfy/l10nPartTwo
setup: Allow language selection regardless of whether languages are available
demeritcowboy [Thu, 16 Nov 2023 02:16:32 +0000 (21:16 -0500)]
Merge pull request #28163 from seamuslee001/notice_fixes_contribution_edit
[REF] Fix Smarty Notice Errors on Contribution Edit
Seamus Lee [Thu, 16 Nov 2023 01:31:44 +0000 (12:31 +1100)]
Merge pull request #28076 from eileenmcnaughton/parse
Clarify that the values passed are the submitted values, not altered values
Eileen McNaughton [Thu, 16 Nov 2023 01:25:31 +0000 (14:25 +1300)]
Merge pull request #28161 from totten/master-allflowstest
(REF) Authx - Split `AllFlowsTest` into smaller, themetic tests
Seamus Lee [Thu, 16 Nov 2023 00:50:56 +0000 (11:50 +1100)]
Merge pull request #28159 from civicrm/5.68
5.68
Seamus Lee [Thu, 16 Nov 2023 00:50:33 +0000 (11:50 +1100)]
Merge pull request #28160 from wikimediaWfan/upstream
Update Merger.php to compare strict type for checkboxes where a dummy…
Seamus Lee [Thu, 16 Nov 2023 00:36:56 +0000 (11:36 +1100)]
[REF] Fix Smarty Notice Errors on Contribution Edit
Tim Otten [Thu, 16 Nov 2023 00:04:24 +0000 (16:04 -0800)]
(REF) Split `AllFlowsTest` into smaller, thematic tests
wfan [Thu, 16 Nov 2023 00:04:07 +0000 (16:04 -0800)]
Update Merger.php to compare strict type for checkboxes where a dummy-string is being used, to prevent this matching 'true'
Seamus Lee [Thu, 16 Nov 2023 00:00:37 +0000 (11:00 +1100)]
Merge pull request #28137 from colemanw/havingFix
APIv4 - Fix index interfering with HAVING
Seamus Lee [Wed, 15 Nov 2023 23:42:31 +0000 (10:42 +1100)]
Merge pull request #28158 from seamuslee001/regen_28144
[REF] Regen after #28144
Tim Otten [Wed, 15 Nov 2023 23:24:28 +0000 (15:24 -0800)]
(REF) Extract base class `AbstractFlowsTest`
Aidan Saunders [Wed, 15 Nov 2023 22:58:29 +0000 (22:58 +0000)]
Merge pull request #28150 from colemanw/today
[REF] APIv4 - Minor cleanup of redundant variables
Seamus Lee [Wed, 15 Nov 2023 22:38:51 +0000 (09:38 +1100)]
[REF] Regen after #28144
Seamus Lee [Wed, 15 Nov 2023 22:35:28 +0000 (09:35 +1100)]
Merge pull request #28144 from eileenmcnaughton/online_receipt
Replace math in template with variable, smarty3 support
Seamus Lee [Wed, 15 Nov 2023 22:34:43 +0000 (09:34 +1100)]
Merge pull request #28140 from eileenmcnaughton/event_text
Remove last references to `_contributeMode`
Seamus Lee [Wed, 15 Nov 2023 21:25:03 +0000 (08:25 +1100)]
Merge pull request #28155 from totten/master-localtasks
Page Templates - Remove unused `$localTasks` (`localNav.tpl`)
demeritcowboy [Wed, 15 Nov 2023 21:03:21 +0000 (16:03 -0500)]
Merge pull request #28154 from civicrm/5.68
5.68
Tim Otten [Wed, 15 Nov 2023 20:19:38 +0000 (12:19 -0800)]
Page Templates - Remove unused `$localTasks` (`localNav.tpl`)
Seamus Lee [Wed, 15 Nov 2023 20:10:59 +0000 (07:10 +1100)]
Merge pull request #28153 from demeritcowboy/menu-missing
dev/core#4778 - php notice causes civi menu to go missing
demeritcowboy [Wed, 15 Nov 2023 20:01:38 +0000 (15:01 -0500)]
Merge pull request #28000 from seamuslee001/guzzle_update
Update Guzzle to 7.6.1 for Drupal 7/Backdrop/WordPress/Joomla
colemanw [Tue, 14 Nov 2023 18:40:29 +0000 (13:40 -0500)]
APIv4 - Fix index interfering with HAVING
It's not always safe to delete items from the SELECT clause... so let's not.
Fixes dev/core#4017
demeritcowboy [Wed, 15 Nov 2023 19:10:28 +0000 (14:10 -0500)]
php notice
demeritcowboy [Wed, 15 Nov 2023 18:38:54 +0000 (13:38 -0500)]
Merge pull request #28143 from eileenmcnaughton/online_cont_tax_check
Add test cover for tax details in Dummy payment online contribution receipt
demeritcowboy [Wed, 15 Nov 2023 18:03:44 +0000 (13:03 -0500)]
Merge pull request #28149 from civicrm/5.68
5.68
colemanw [Wed, 15 Nov 2023 16:34:45 +0000 (11:34 -0500)]
APIv4 - Minor cleanup of redundant variables
Is it just me, or does staring at the word today for too long stop making sense?
demeritcowboy [Wed, 15 Nov 2023 16:16:23 +0000 (11:16 -0500)]
Merge pull request #28136 from ErikHommel/master
fix issue #4770 Ensure the followup_assignee_contact_id is an array so all assignees are saved, not just the first one
colemanw [Wed, 15 Nov 2023 16:11:12 +0000 (11:11 -0500)]
Merge pull request #28145 from colemanw/parentNames
dev/core#4740 - Fix missing tagsets when label doesn't match name
Mathieu Lu [Wed, 15 Nov 2023 14:38:16 +0000 (09:38 -0500)]
Merge pull request #28117 from demeritcowboy/casedashboard-warnings2
[php8] php warnings on case dashboard
demeritcowboy [Wed, 15 Nov 2023 14:03:30 +0000 (09:03 -0500)]
Merge pull request #28146 from seamuslee001/fix_tests
[REF] Fix test fails caused by changes to mailing footer
colemanw [Wed, 15 Nov 2023 13:54:30 +0000 (08:54 -0500)]
Merge pull request #28070 from eileenmcnaughton/participant_backoffice
Clean up contributionParams - backoffice participant form
Erik Hommel [Wed, 15 Nov 2023 13:42:38 +0000 (14:42 +0100)]
fix on review
Co-authored-by: demeritcowboy <demeritcowboy@hotmail.com>
Tim Otten [Wed, 15 Nov 2023 07:55:45 +0000 (00:55 -0700)]
Merge pull request #28119 from lcdservices/dev-core-4772
dev/core#4772 fix authx on Joomla
Seamus Lee [Wed, 15 Nov 2023 05:05:16 +0000 (16:05 +1100)]
[REF] Fix test fails caused by changes to mailing footer
Seamus Lee [Thu, 2 Nov 2023 21:51:06 +0000 (08:51 +1100)]
Update Guzzle to 7.6.1 for Drupal 7/Backdrop/WordPress/Joomla
colemanw [Wed, 15 Nov 2023 01:10:38 +0000 (20:10 -0500)]
dev/core#4740 - Fix missing tagsets when label doesn't match name
CRM_Core_Form_Tag::buildQuickForm was previously being passed an array of [id => name]
but it was wastefully ignoring the passed ids and looking it up from the name.
Now due to
bcf668d is being passed an array of [id => label] which is all it needs,
just had to remove the wasteful id lookup when it's already there.
Eileen McNaughton [Wed, 15 Nov 2023 01:07:09 +0000 (14:07 +1300)]
Merge pull request #28142 from eileenmcnaughton/notice_cms
Fix notice on showCMS:
colemanw [Wed, 15 Nov 2023 00:48:55 +0000 (19:48 -0500)]
Merge pull request #28133 from colemanw/civiCasePerms
dev/core#4769 APIv4 - Fix access to case activities for administrators
Eileen McNaughton [Tue, 14 Nov 2023 23:21:37 +0000 (12:21 +1300)]
Merge pull request #28141 from eileenmcnaughton/object_notice
Fix notice on payment processor object
Eileen McNaughton [Tue, 14 Nov 2023 22:59:59 +0000 (11:59 +1300)]
Replace math in template with variable, smarty3 support
The handling for math in smarty2 & 3 differs wrt precedence, when used
with a modifier. It's a bit tricky supporting both but in this
case we can simply rely on another key in the array that already exists
and is equivalent
Note that the membership online template is excluded deliberately for now
as it does not currently access the same lineItems variable
as all the other templates
Eileen McNaughton [Tue, 14 Nov 2023 22:52:28 +0000 (11:52 +1300)]
Add test cover for tax details in Dummy payment online contribution receipt
Eileen McNaughton [Tue, 14 Nov 2023 22:27:38 +0000 (11:27 +1300)]
Fix notice on showCMS:
Eileen McNaughton [Tue, 14 Nov 2023 22:22:28 +0000 (11:22 +1300)]
Fix notice on payment processor object
demeritcowboy [Tue, 14 Nov 2023 22:10:57 +0000 (17:10 -0500)]
Merge pull request #28138 from eileenmcnaughton/online_cont_tax_check
Check tax is present in online contribution page receipt
Eileen McNaughton [Tue, 14 Nov 2023 21:39:44 +0000 (10:39 +1300)]
Remove last references to _contributeMode
Eileen McNaughton [Tue, 14 Nov 2023 21:35:56 +0000 (10:35 +1300)]
Merge pull request #28065 from eileenmcnaughton/event_text
Replace last tpl uses of `contributeMode`
Eileen McNaughton [Tue, 14 Nov 2023 19:27:48 +0000 (08:27 +1300)]
Check tax is present in online contribution page receipt
Eileen McNaughton [Fri, 22 Sep 2023 22:27:22 +0000 (10:27 +1200)]
Replace last tpl uses of contributeMode
This adds the strings to what the processor can determin, allowing us to stop checkign contributeMode
Mathieu Lu [Tue, 14 Nov 2023 20:44:14 +0000 (15:44 -0500)]
Merge pull request #28053 from agileware/CIVICRM-2190
Default mailing footer component incorrectly describes opt-out action as unsubscribe
Mathieu Lu [Tue, 14 Nov 2023 20:18:25 +0000 (15:18 -0500)]
setup: Allow language selection regarless of whether languages are available
demeritcowboy [Tue, 14 Nov 2023 19:23:01 +0000 (14:23 -0500)]
Merge pull request #28061 from jaapjansma/l10n_downloader
Setup: able to download translation files automatically
demeritcowboy [Tue, 14 Nov 2023 18:09:25 +0000 (13:09 -0500)]
Merge pull request #28033 from colemanw/assetCheck
dev/core#4754 - Add status check to warn of missing/outdated public assets
Jaap Jansma [Tue, 14 Nov 2023 16:16:22 +0000 (17:16 +0100)]
added plugin to download l10n translation files
colemanw [Tue, 14 Nov 2023 15:35:55 +0000 (10:35 -0500)]
Merge pull request #28112 from colemanw/searchKitInputMode
SearchKit - Add inputMode setting to allow clauses to reference column values
colemanw [Tue, 7 Nov 2023 01:36:56 +0000 (20:36 -0500)]
dev/core#4754 - Add status check to warn of missing/outdated public assets
Erik Hommel [Tue, 14 Nov 2023 10:04:16 +0000 (11:04 +0100)]
fix issue #4770
Making sure the followup_assignee_contact_id is an array so all assignees are saved, not just the first one
Matthew Wire [Tue, 14 Nov 2023 09:11:22 +0000 (09:11 +0000)]
Merge pull request #28060 from eileenmcnaughton/error_verbose
Use `supportsNoReturn()` instead of contributeMode check
Seamus Lee [Tue, 14 Nov 2023 02:51:48 +0000 (13:51 +1100)]
Merge pull request #28135 from civicrm/5.68
5.68
Seamus Lee [Tue, 14 Nov 2023 02:50:02 +0000 (13:50 +1100)]
Merge pull request #28130 from eileenmcnaughton/568
Update the parameters passed to the hook_QueueTaskError
Seamus Lee [Tue, 14 Nov 2023 02:49:53 +0000 (13:49 +1100)]
Merge pull request #28131 from civicrm/5.68
5.68
colemanw [Tue, 14 Nov 2023 01:57:26 +0000 (20:57 -0500)]
APIv4 - Fix access to case activities for administrators
Fixes dev/core#4769
Before: Case administrators with 'access deleted contacts' permission blocked from viewing Case activities in APIv4
After: Permissions work correctly.
The problem was the hook logic was incorrectly interpreting empty permissions to mean "no access"
when it actually means "unrestricted access".
Eileen McNaughton [Mon, 13 Nov 2023 18:19:51 +0000 (07:19 +1300)]
Move set up of complicated price set to the ContributionPageTestTrait & test to the confirmTest
We need to add some more testing but most of our existing tests are within the apiv3 test harness
which is not a great location. This moves one test over to the full form test flow
and also pimps the helper trait to support this complex price scenario (with fields
of a mixture of types & financial types.
I want to add some checks on the email output but this specific test is pay later
so I won't do it in this PR
demeritcowboy [Tue, 14 Nov 2023 01:23:27 +0000 (20:23 -0500)]
Merge pull request #28128 from seamuslee001/dev_core_4768_568
dev/core#4768 Fix validating contact when using checksum url
Adedoyin Damilare [Mon, 13 Nov 2023 19:59:27 +0000 (19:59 +0000)]
Update the parameters passed to the hook_QueueTaskError
Issue: https://lab.civicrm.org/dev/core/-/issues/4774
colemanw [Tue, 14 Nov 2023 00:16:53 +0000 (19:16 -0500)]
Merge pull request #28124 from colemanw/fixApi4QueryRegression
dev/core#4773 - Fix APIv4 query regression
Seamus Lee [Mon, 13 Nov 2023 23:43:57 +0000 (10:43 +1100)]
Add unit test
Eileen McNaughton [Mon, 13 Nov 2023 22:55:18 +0000 (11:55 +1300)]
Merge pull request #28120 from demeritcowboy/regen
Regen after 28096
Eileen McNaughton [Mon, 13 Nov 2023 22:54:55 +0000 (11:54 +1300)]
Merge pull request #28126 from civicrm/5.68
5.68
Seamus Lee [Mon, 13 Nov 2023 21:58:09 +0000 (08:58 +1100)]
dev/core#4768 Fix validating contact when using checksum url
Fix type error failures
Seamus Lee [Mon, 13 Nov 2023 20:48:42 +0000 (07:48 +1100)]
Merge pull request #28123 from Damilare1/master
Update the parameters passed to the hook_QueueTaskError
Seamus Lee [Mon, 13 Nov 2023 20:46:38 +0000 (07:46 +1100)]
Merge pull request #28121 from colemanw/contact_autocomplete_options
dev/core#4759 - Respect Autocomplete Contact Search preferences in menubar quicksearch
colemanw [Mon, 13 Nov 2023 20:42:09 +0000 (15:42 -0500)]
dev/core#4773 - Fix APIv4 query regression
Eileen McNaughton [Mon, 13 Nov 2023 20:30:08 +0000 (09:30 +1300)]
Merge pull request #28080 from MegaphoneJon/badge-layout-another-fix
Updated fix for badge layouts
Adedoyin Damilare [Mon, 13 Nov 2023 19:59:27 +0000 (19:59 +0000)]
Update the parameters passed to the hook_QueueTaskError
Issue: https://lab.civicrm.org/dev/core/-/issues/4774
colemanw [Mon, 13 Nov 2023 19:43:40 +0000 (14:43 -0500)]
dev/core#4759 - Respect Autocomplete Contact Search preferences in menubar quicksearch
Jon Goldberg [Thu, 9 Nov 2023 17:01:09 +0000 (12:01 -0500)]
Fix for badge layouts take 3
demeritcowboy [Mon, 13 Nov 2023 19:07:07 +0000 (14:07 -0500)]
regen
demeritcowboy [Mon, 13 Nov 2023 18:58:19 +0000 (13:58 -0500)]
Merge pull request #28096 from eileenmcnaughton/online_cont_notice
Blank out membership_online_receipt - text version
Brian Shaughnessy [Mon, 13 Nov 2023 18:20:00 +0000 (13:20 -0500)]
dev/core#4772 fix authx on Joomla
Eileen McNaughton [Fri, 10 Nov 2023 05:23:57 +0000 (18:23 +1300)]
Blank out membership_online_receipt - text version
As with the offline event receipt this reduces the maintenance effort, given that
we generate a text version anyway
demeritcowboy [Mon, 13 Nov 2023 15:17:16 +0000 (10:17 -0500)]
update test
demeritcowboy [Mon, 13 Nov 2023 05:05:07 +0000 (00:05 -0500)]
php warnings on case dashboard
demeritcowboy [Mon, 13 Nov 2023 15:34:10 +0000 (10:34 -0500)]
Merge pull request #28116 from demeritcowboy/regen
Regen after 28052
demeritcowboy [Mon, 13 Nov 2023 15:23:39 +0000 (10:23 -0500)]
Merge pull request #28118 from civicrm/5.68
5.68
demeritcowboy [Mon, 13 Nov 2023 14:19:52 +0000 (09:19 -0500)]
Merge pull request #28103 from colemanw/tagIndividuals
APIv4 - Fix missing tag filer on Individual,Organization,Household
demeritcowboy [Mon, 13 Nov 2023 14:03:39 +0000 (09:03 -0500)]
regen
Seamus Lee [Mon, 13 Nov 2023 06:14:00 +0000 (17:14 +1100)]
Merge pull request #28013 from agileware/CIVICRM-2188
Pass year to mktime as int in CRM_Contribution_Form_ContributionCharts