Coleman Watts [Sun, 23 Jan 2022 22:29:50 +0000 (17:29 -0500)]
[REF] - Cleanup Contact BAO variables
Seamus Lee [Mon, 31 Jan 2022 22:37:20 +0000 (09:37 +1100)]
Merge pull request #22619 from demeritcowboy/wrong-tz
dev/core#2122 - Manage event online registration page doesn't determine timezone correctly
Eileen McNaughton [Mon, 31 Jan 2022 22:04:23 +0000 (11:04 +1300)]
Merge pull request #22538 from masetto/pdfletter
add `contact_id` to email params in `emailLetter` function
Monish Deb [Mon, 31 Jan 2022 15:10:16 +0000 (20:40 +0530)]
Merge pull request #22587 from colemanw/apiNull
APIv4 - Use empty string instead of 'null' to pass null values to the db
Yashodha Chaku [Mon, 31 Jan 2022 13:38:02 +0000 (19:08 +0530)]
Merge pull request #22634 from eileenmcnaughton/pre_message
dev/core#2866 add pre-upgrade warning
demeritcowboy [Mon, 31 Jan 2022 05:34:00 +0000 (00:34 -0500)]
Merge pull request #22652 from civicrm/5.46
5.46
demeritcowboy [Mon, 31 Jan 2022 05:32:32 +0000 (00:32 -0500)]
Merge pull request #22669 from agileware/CIVICRM-1921
CiviCRM Event, the link to "On-line Registration (Test Drive)" is an admin-only URL to register in the backend, should be a frontend URL
colemanw [Sun, 30 Jan 2022 20:32:56 +0000 (15:32 -0500)]
Merge pull request #22668 from braders/profile-preview-template-formatting
[REF] Tidy up group.tpl
Bradley Taylor [Sun, 30 Jan 2022 16:44:59 +0000 (16:44 +0000)]
Tidy up group.tpl
This rationalises the indentation, and removes an extra closing </div> which was causing issues in some contexts.
colemanw [Sat, 29 Jan 2022 21:38:38 +0000 (16:38 -0500)]
Merge pull request #22653 from colemanw/searchKitOperatorFixes
SearchKit - Fix selecting operators and values in clauses
colemanw [Sat, 29 Jan 2022 21:13:37 +0000 (16:13 -0500)]
Merge pull request #22663 from braders/manage-event-listing-default-values
Set default values to avoid notices when rendering (event templates screen)
colemanw [Sat, 29 Jan 2022 18:35:44 +0000 (13:35 -0500)]
Merge pull request #22660 from braders/membership-dashboard-smarty-notices
Fix smarty notices in membership dashboard
colemanw [Sat, 29 Jan 2022 18:35:21 +0000 (13:35 -0500)]
Merge pull request #22661 from braders/contributionpage-php-notice
Avoid PHP notice on 'Manage Contribution Pages' screen
Bradley Taylor [Sat, 29 Jan 2022 18:25:42 +0000 (18:25 +0000)]
Set default values to avoid notices when rendering
Bradley Taylor [Sat, 29 Jan 2022 15:54:19 +0000 (15:54 +0000)]
Avoid PHP notice on 'Manage Contribution Pages' screen
Bradley Taylor [Sat, 29 Jan 2022 12:14:18 +0000 (12:14 +0000)]
Fix smarty notices in membership dashboard
colemanw [Sat, 29 Jan 2022 15:14:30 +0000 (10:14 -0500)]
Merge pull request #22658 from braders/phpdoc-fixes-3
Another set of PHPdoc corrections
colemanw [Sat, 29 Jan 2022 15:12:49 +0000 (10:12 -0500)]
Merge pull request #22659 from braders/const-type-hints
Correctly document types for class consts
Bradley Taylor [Sat, 29 Jan 2022 11:46:55 +0000 (11:46 +0000)]
Another set of PHPdoc corrections
Bradley Taylor [Sat, 29 Jan 2022 11:56:12 +0000 (11:56 +0000)]
Correctly document types for class consts
Seamus Lee [Fri, 28 Jan 2022 23:30:54 +0000 (10:30 +1100)]
Merge pull request #22656 from seamuslee001/5.46
5.45.1 & 5.45.2 Release Notes
Tim Otten [Fri, 28 Jan 2022 23:23:05 +0000 (15:23 -0800)]
Add release-notes/5.45.2.md
Tim Otten [Tue, 11 Jan 2022 19:34:54 +0000 (11:34 -0800)]
Add release-notes/5.45.1.md
Coleman Watts [Fri, 28 Jan 2022 14:54:34 +0000 (09:54 -0500)]
SearchKit - Fix selecting operators and values in clauses
Fixes dev/core#3046 which was caused by incomplete refactoring in
https://github.com/civicrm/civicrm-core/pull/22604
colemanw [Fri, 28 Jan 2022 15:13:32 +0000 (10:13 -0500)]
Merge pull request #22358 from colemanw/searchKitNotNull
SearchKit - Improve editable UX by not allowing required fields to be left blank
demeritcowboy [Fri, 28 Jan 2022 14:46:26 +0000 (09:46 -0500)]
Merge pull request #22650 from totten/5.46-greeting
dev/core#3028 - For invalid greetings, return '' instead of failing
Justin Freeman [Fri, 28 Jan 2022 06:48:40 +0000 (17:48 +1100)]
CIVICRM-1921 Event, the link to "On-line Registration (Test Drive)" is an admin-only URL to register in the backend, should be a frontend URL
Eileen McNaughton [Fri, 28 Jan 2022 05:58:07 +0000 (21:58 -0800)]
dev/core#3028 - For invalid greetings, return '' instead of failing
colemanw [Fri, 28 Jan 2022 03:36:26 +0000 (22:36 -0500)]
Merge pull request #22649 from colemanw/api4CustomDateFormat
APIv4 - Correctly return date-only custom field values without the time
Coleman Watts [Fri, 28 Jan 2022 01:23:33 +0000 (20:23 -0500)]
APIv4 - Correctly return date-only custom field values without the time
Eileen McNaughton [Thu, 27 Jan 2022 21:44:51 +0000 (10:44 +1300)]
Merge pull request #22646 from braders/feature/tasktrait-issingle-docblock
Resolve docblock inaccuracy in CRM_Contribute_Form_Task_TaskTrait
Eileen McNaughton [Thu, 27 Jan 2022 21:44:22 +0000 (10:44 +1300)]
Merge pull request #22645 from demeritcowboy/event-default-tz
dev/core#2122 - Add an event timezone for sample data
Seamus Lee [Thu, 27 Jan 2022 20:42:03 +0000 (07:42 +1100)]
Merge pull request #22644 from demeritcowboy/fix-add-version
dev/core#2122 - Fix "add" version for event timezone dao field
Bradley Taylor [Thu, 27 Jan 2022 19:42:42 +0000 (19:42 +0000)]
Resolve docblock inaccuracy in CRM_Contribute_Form_Task_TaskTrait
demeritcowboy [Thu, 27 Jan 2022 19:19:42 +0000 (14:19 -0500)]
default event timezone for sample data
demeritcowboy [Thu, 27 Jan 2022 19:09:11 +0000 (14:09 -0500)]
fix add version
colemanw [Thu, 27 Jan 2022 12:57:33 +0000 (07:57 -0500)]
Merge pull request #22639 from civicrm/5.46
5.46
colemanw [Thu, 27 Jan 2022 12:22:38 +0000 (07:22 -0500)]
Merge pull request #22640 from totten/5.46-ext-check
Extensions - Add dependency status check
Eileen McNaughton [Thu, 27 Jan 2022 05:32:05 +0000 (18:32 +1300)]
Merge pull request #22638 from totten/master-ext-prose
Extensions - Revise prose for status check
Tim Otten [Thu, 27 Jan 2022 02:44:10 +0000 (18:44 -0800)]
Extensions - Revise prose for status check
Coleman Watts [Mon, 10 Jan 2022 22:48:03 +0000 (17:48 -0500)]
Extensions - Add dependency status check
Adds a system status check to ensure extension dependencies are met
Tim Otten [Thu, 27 Jan 2022 04:52:25 +0000 (20:52 -0800)]
Merge pull request #22623 from colemanw/extensionUpgrades
ExtensionUpgrades - Skip trying to upgrade missing dependencies
Tim Otten [Thu, 27 Jan 2022 02:44:10 +0000 (18:44 -0800)]
Extensions - Revise prose for status check
Coleman Watts [Tue, 25 Jan 2022 16:54:40 +0000 (11:54 -0500)]
ExtensionUpgrades - Skip trying to upgrade missing dependencies
Before: Missing dependencies would be added and then the extension upgrader would try and fail to upgrade them
After: They are skipped, as missing extension dependencies are handled elsewhere
This allows the extension upgrade to proceed without error, even if there are missing dependencies.
The user will be prompted to install the missing dependencies afterward.
Eileen McNaughton [Thu, 27 Jan 2022 00:59:32 +0000 (13:59 +1300)]
Merge pull request #22626 from colemanw/readOnlyRename
APIv4 - Rename 'ReadOnly' trait to 'ReadOnlyEntity' to avoid PHP error
Eileen McNaughton [Thu, 27 Jan 2022 00:46:45 +0000 (13:46 +1300)]
Merge pull request #22631 from braders/calculateBaseScheduleDate-docblock
Fix inaccuracy in docblock for method calculateBaseScheduleDate
Eileen McNaughton [Thu, 27 Jan 2022 00:01:04 +0000 (13:01 +1300)]
dev/core#2866 add pre-upgrade warning
Seamus Lee [Wed, 26 Jan 2022 22:27:51 +0000 (09:27 +1100)]
Merge pull request #22629 from braders/attachmentInfo-docblock
Resolve inaccuracies in CRM_Core_BAO_File::attachmentInfo docblock
Eileen McNaughton [Wed, 26 Jan 2022 22:02:22 +0000 (11:02 +1300)]
Merge pull request #22601 from braders/set-print-functions-tidy
Tidy up functions related to printing.
Bradley Taylor [Wed, 26 Jan 2022 21:57:22 +0000 (21:57 +0000)]
Fix inaccuracy in docblock for method calculateBaseScheduleDate
Bradley Taylor [Wed, 26 Jan 2022 20:24:20 +0000 (20:24 +0000)]
Resolve inaccuracies in CRM_Core_BAO_File::attachmentInfo docblock
Bradley Taylor [Sat, 22 Jan 2022 12:04:54 +0000 (12:04 +0000)]
Tidy up functions related to printing.
Calls to setPrint updated to use constant,
and inline documentation updated to reflect the values which are actually expected.
setWord and setExcel methods deprectated as they are not in use,
and they only support the older Microsoft Office formats (doc, not docx)
colemanw [Wed, 26 Jan 2022 15:18:59 +0000 (10:18 -0500)]
Merge pull request #22625 from eileenmcnaughton/comp
Do not pass in tablename
Coleman Watts [Mon, 3 Jan 2022 16:48:37 +0000 (11:48 -0500)]
APIv4 - Add `nullable` property to getFields; improve SearchKit editable UX
Unlike the 'required' field property, which only determines if the API requires a value to Create,
the 'nullable' property tells a UI whether a field is allowed to be set to NULL in Create OR Update.
SearchKit uses this property during in-place edit and bulk edit operations to determine whether a
field can be left blank.
colemanw [Wed, 26 Jan 2022 14:31:20 +0000 (09:31 -0500)]
Merge pull request #22627 from eileenmcnaughton/config
Remove deprecated language construct
Coleman Watts [Wed, 26 Jan 2022 02:10:34 +0000 (21:10 -0500)]
APIv4 - Rename 'ReadOnly' trait to 'ReadOnlyEntity' to avoid PHP fatal error
Fixes dev/core#3043
The word 'readonly' is reserved as of php 8.1
Eileen McNaughton [Wed, 26 Jan 2022 05:10:04 +0000 (18:10 +1300)]
Remove deprecated language construct
Per https://github.com/totten/civix/pull/235 this language construct
appears to be getting more noisy about being bad....
Monish Deb [Wed, 26 Jan 2022 05:08:01 +0000 (10:38 +0530)]
Merge pull request #22615 from eileenmcnaughton/online
Remove isset from online contribution receipt
Monish Deb [Wed, 26 Jan 2022 04:01:20 +0000 (09:31 +0530)]
Merge pull request #22551 from eileenmcnaughton/phpcs
More phpcbs code cleanups
Monish Deb [Wed, 26 Jan 2022 03:58:42 +0000 (09:28 +0530)]
Merge pull request #22606 from colemanw/relationshipPseudoFields
SearchKit - Expose relationship description, created/modified_date & permissions
Eileen McNaughton [Wed, 26 Jan 2022 01:57:21 +0000 (14:57 +1300)]
Merge pull request #22620 from demeritcowboy/adjust-version
dev/core#2122 - Fix version specified in message template upgrade
Eileen McNaughton [Wed, 26 Jan 2022 01:56:33 +0000 (14:56 +1300)]
Merge pull request #22592 from colemanw/searchKitSmarty2
SearchKit - Allow smarty in field rewrite
Eileen McNaughton [Wed, 26 Jan 2022 01:43:53 +0000 (14:43 +1300)]
Do not pass in tablename
Tablename is fetched if not passed in so no need to do the fetch first
Eileen McNaughton [Tue, 25 Jan 2022 23:23:04 +0000 (12:23 +1300)]
Merge pull request #22622 from demeritcowboy/unused-tz
dev/core#2122 - prevent E_NOTICEs and blank dates being converted to current datetime
Eileen McNaughton [Tue, 25 Jan 2022 21:32:16 +0000 (10:32 +1300)]
Updated generated sql
Eileen McNaughton [Tue, 25 Jan 2022 03:22:21 +0000 (16:22 +1300)]
Remove isset from online contribution receipt
This removes the isset checks that re failing around
totalTaxAmount (solved the same way as offline
https://github.com/civicrm/civicrm-core/pull/22560/files#diff-fd5668d5492e5f0ec55b7f8a10eccfa4ea9de249e4cf2383a2e0d36dbd92ebe0R134
)
It also removes the isset around contribution.amount_level (switching
to a token) and the enotice on isQuickConfig - this
switches to loading that information & also using a more meaningful variable.
Note that line items should always be assigned so that check is silly.
Monish Deb [Tue, 25 Jan 2022 18:19:18 +0000 (23:49 +0530)]
Merge pull request #22519 from colemanw/customGroupCleanup
[REF] CustomField Admin - Decouple page code from form code
demeritcowboy [Tue, 25 Jan 2022 15:51:08 +0000 (10:51 -0500)]
prevent E_NOTICE and prevent blank dates being converted to current date/time
Coleman Watts [Sun, 16 Jan 2022 01:50:30 +0000 (20:50 -0500)]
CustomField Admin - Decouple page code from form code
This moves the forms for creating/editing/previewing/deleting custom data
to their own url paths instead of sharing the same path as the page.
demeritcowboy [Tue, 25 Jan 2022 15:12:21 +0000 (10:12 -0500)]
wrong variable
demeritcowboy [Tue, 25 Jan 2022 15:09:55 +0000 (10:09 -0500)]
fix version
demeritcowboy [Tue, 25 Jan 2022 15:07:33 +0000 (10:07 -0500)]
Merge pull request #20476 from agileware/CIVICRM-404
dev/core#2122 Add timezone support for events
colemanw [Tue, 25 Jan 2022 13:59:38 +0000 (08:59 -0500)]
Merge pull request #22618 from eileenmcnaughton/batch
Fix batch summary to use the api
Yashodha Chaku [Tue, 25 Jan 2022 13:05:08 +0000 (18:35 +0530)]
Merge pull request #22617 from eileenmcnaughton/view
Split View Relationship tpl ito own file
Yashodha Chaku [Tue, 25 Jan 2022 12:54:02 +0000 (18:24 +0530)]
Merge pull request #22548 from eileenmcnaughton/raw
Add option to display money tokens without formatting
Eileen McNaughton [Tue, 25 Jan 2022 07:39:24 +0000 (20:39 +1300)]
Fix batch summary to use the api
In looking at @colemanw's work to clean up the retrieve function it
turned out that in at least one place NULL is being passed to Batch::retrieve
Since I dug into that 1 place I fixed it to use v4 api (it is
the screen accessed after creating a new accounting batch
from contribution->accounting batches->new batch)
However, it seems safer to continue to accept NULL
Francis Whittle [Fri, 21 Jan 2022 06:05:47 +0000 (06:05 +0000)]
CIVICRM-1773 Add Event timezone tests.
Francis Whittle [Wed, 2 Jun 2021 01:28:55 +0000 (11:28 +1000)]
CIVICRM-1763 Add Event component check for missing timezones.
Francis Whittle [Mon, 24 May 2021 01:30:09 +0000 (11:30 +1000)]
CIVICRM-1761 Add event_tz default to API spec.
Francis Whittle [Mon, 10 May 2021 07:16:34 +0000 (17:16 +1000)]
CIVICRM-1753 Add event timezone information to message templates.
Francis Whittle [Fri, 7 May 2021 03:08:53 +0000 (13:08 +1000)]
CIVICRM-1758 Add timezone output for Event Tokens.
Francis Whittle [Fri, 7 May 2021 00:52:08 +0000 (10:52 +1000)]
CIVICRM-1756 Update Event ICalendar & List output to use timezone
Francis Whittle [Wed, 5 May 2021 01:26:06 +0000 (11:26 +1000)]
CIVICRM-1749 Add timezone output to Event Registration forms
Francis Whittle [Thu, 29 Apr 2021 05:07:25 +0000 (15:07 +1000)]
CIVICRM-1749 Add time elements and timezone to Event Info output.
Francis Whittle [Wed, 28 Apr 2021 00:28:57 +0000 (10:28 +1000)]
CIVICRM-1749 Implement UI for timezone in Event management forms
Francis Whittle [Mon, 8 Nov 2021 05:54:46 +0000 (16:54 +1100)]
CIVICRM-1754 Add timezone to Event Schema.
Eileen McNaughton [Tue, 25 Jan 2022 04:24:44 +0000 (17:24 +1300)]
Split View Relationship tpl ito own file
The inclusion of templates/CRM/Contact/Form/Relationship.tpl simply contains a chunk
of code for the view file in a big IF - this separates that out it's own file & is
more thoughtful about the inclusion....
demeritcowboy [Tue, 25 Jan 2022 02:23:36 +0000 (21:23 -0500)]
Merge pull request #22547 from eileenmcnaughton/smart
Only format smarty aliases as money if specified
colemanw [Tue, 25 Jan 2022 01:53:34 +0000 (20:53 -0500)]
Merge pull request #22613 from eileenmcnaughton/notice
Fix smarty notices in footer files
colemanw [Tue, 25 Jan 2022 00:12:24 +0000 (19:12 -0500)]
Merge pull request #22314 from braders/core-3004-remove-fontsize-classes
Remove use of .font-size11pt and .font-size12pt
Eileen McNaughton [Mon, 17 Jan 2022 08:04:27 +0000 (21:04 +1300)]
Fix smarty notices in footer files
Eileen McNaughton [Mon, 17 Jan 2022 22:10:57 +0000 (11:10 +1300)]
Only format smarty aliases as money if specified
smarty aliases allow tokens to be assigned to the template as smarty variables. They are very new,
have only been implemented in these 2 places and are not accessible from outside of core, which
both have unit test cover.
When trying to extend it to cover another variable (totalTaxAmount) in another template I found
that a raw format is appropriate. I think it makes sense to explicitly specify.
Code comment
Co-authored-by: Tim Otten <totten@civicrm.org>
Eileen McNaughton [Mon, 24 Jan 2022 20:23:55 +0000 (09:23 +1300)]
Merge pull request #22611 from yashodha/report_cleanup
report cleanup - no functional change
Bradley Taylor [Thu, 23 Dec 2021 15:49:49 +0000 (15:49 +0000)]
Remove use of .font-size11pt and .font-size12pt
colemanw [Mon, 24 Jan 2022 13:47:25 +0000 (08:47 -0500)]
Merge pull request #20845 from herbdool/issue-899
Issue #899: don't show PCPs where the events or contribution pages are disabled or past the end date
Samuele Masetto [Mon, 24 Jan 2022 13:35:23 +0000 (14:35 +0100)]
update doc block, work on `PDFLetterCommonTest` unit test compatibility with `contactId` parameter
colemanw [Mon, 24 Jan 2022 13:20:54 +0000 (08:20 -0500)]
Merge pull request #20251 from larssandergreen/change-registration-button-text
dev/core#1613 Change event registration button text based on if there are additional participants
Monish Deb [Mon, 24 Jan 2022 12:04:04 +0000 (17:34 +0530)]
Merge pull request #22604 from colemanw/searchKitOperators
SearchKit - Improve field/operator/value selection UI
yashodha [Mon, 24 Jan 2022 05:25:35 +0000 (10:55 +0530)]
report cleanup
Yashodha Chaku [Mon, 24 Jan 2022 05:00:04 +0000 (10:30 +0530)]
Merge pull request #22610 from colemanw/deprecatedUnusedFunction
Contact BAO - Deprecate unused function