Eileen McNaughton [Sat, 23 Sep 2023 12:01:25 +0000 (00:01 +1200)]
Simplify a couple of lines of code
Eileen McNaughton [Sat, 23 Sep 2023 11:55:05 +0000 (23:55 +1200)]
Require all fields in signature, as always passed
Eileen McNaughton [Sat, 23 Sep 2023 04:22:59 +0000 (16:22 +1200)]
Merge pull request #27547 from larssandergreen/More-Smarty-3+-prep
dev/core##4146 [NFC] More Smarty 3+ prep, mostly quoting strings and removing backticks
larssandergreen [Sat, 23 Sep 2023 03:37:39 +0000 (21:37 -0600)]
Fix Administer Custom Field Groups in AdminUI for Smarty 3
Eileen McNaughton [Sat, 23 Sep 2023 03:26:02 +0000 (15:26 +1200)]
Merge pull request #27590 from eileenmcnaughton/template_again
Fix those pesky field notices ...again
larssandergreen [Sat, 23 Sep 2023 03:11:29 +0000 (21:11 -0600)]
Smarty backticks fixes, etc
Eileen McNaughton [Sat, 23 Sep 2023 03:00:30 +0000 (15:00 +1200)]
Merge pull request #27589 from eileenmcnaughton/help_fix
Stop accessng _tpl_vars in smarty from property
Eileen McNaughton [Sat, 23 Sep 2023 02:12:10 +0000 (14:12 +1200)]
Fix those pesky field notices ...again
Eileen McNaughton [Sat, 23 Sep 2023 02:02:50 +0000 (14:02 +1200)]
Stop accessng _tpl_vars in smarty from property
it's bad practice & it hard fails in smartyv3
Tim Otten [Sat, 23 Sep 2023 00:20:20 +0000 (17:20 -0700)]
Merge pull request #27526 from eileenmcnaughton/hook
(dev/core#4490) Queues - Add setting and hook to pause/resume background-queues
Eileen McNaughton [Fri, 22 Sep 2023 23:47:34 +0000 (11:47 +1200)]
Merge pull request #27584 from colemanw/smartyEval
dev/core#4618 - Update APIv3 explorer to not encourage php-eval in smarty
Eileen McNaughton [Fri, 22 Sep 2023 23:32:54 +0000 (11:32 +1200)]
Merge pull request #27578 from eileenmcnaughton/offline_e
Fix undefined property on fromEmails for Participant fee
colemanw [Fri, 22 Sep 2023 23:13:20 +0000 (19:13 -0400)]
dev/core#4618 - Update APIv3 explorer to not encourage php-eval in smarty
Tim Otten [Fri, 22 Sep 2023 23:07:55 +0000 (16:07 -0700)]
Merge pull request #27553 from colemanw/afformPhp
dev/core#2396 - Read afform defn from .aff.php files
Eileen McNaughton [Fri, 22 Sep 2023 21:43:36 +0000 (09:43 +1200)]
Fix undefined property on fromEmails for Participant fee
Seamus Lee [Fri, 22 Sep 2023 22:14:26 +0000 (08:14 +1000)]
Merge pull request #27580 from civicrm/5.66
5.66
Tim Otten [Fri, 22 Sep 2023 21:43:47 +0000 (14:43 -0700)]
The Battle of the Synonyms was put on-hold.
With the recent update, it fires a hook, and the hook-data describes the
queue-status as "deferred".
But the setting which drives it is called "queue_suspended".
Which word is better? On reflection... neither!
In CiviMail, there's some existing functionality where you can "pause" a
mail-blast. And it's basically the same thing: we keep the queue-data, but
we tell the workers to temporarily refrain from execution. And that's fine.
"Pausing" sounds less scary...
Eileen McNaughton [Fri, 22 Sep 2023 21:51:09 +0000 (09:51 +1200)]
Merge pull request #27574 from demeritcowboy/sixhundred
[NFC] Partial backport of
0c1d533c to avoid random test fails
Eileen McNaughton [Fri, 22 Sep 2023 21:50:37 +0000 (09:50 +1200)]
Merge pull request #27573 from alifrumin/5.66rn
[NFC] 5.66 release notes
Tim Otten [Fri, 22 Sep 2023 21:40:55 +0000 (14:40 -0700)]
Queue::isActive() - Use the latest value of the setting
demeritcowboy [Fri, 22 Sep 2023 20:58:15 +0000 (16:58 -0400)]
Merge pull request #27530 from eileenmcnaughton/misc
php8.x Fix notice from adding esm_loader to wrong settings form
colemanw [Fri, 22 Sep 2023 20:09:38 +0000 (16:09 -0400)]
Merge pull request #27576 from colemanw/enter
SearchKit - Save In-place edit when pressing enter
colemanw [Fri, 22 Sep 2023 13:47:58 +0000 (09:47 -0400)]
Ext - Convert *.aff.json files to *.aff.php
Used a bunch of regexes to convert file formats
The new format allows titles, labels, etc to be translatable.
colemanw [Fri, 22 Sep 2023 19:53:38 +0000 (15:53 -0400)]
Merge pull request #27563 from eileenmcnaughton/pro
Remove unreachable code
colemanw [Fri, 22 Sep 2023 19:31:45 +0000 (15:31 -0400)]
SearchKit - Save In-place edit when pressing enter
demeritcowboy [Fri, 22 Sep 2023 17:41:41 +0000 (13:41 -0400)]
avoid random test fails
demeritcowboy [Fri, 22 Sep 2023 17:39:23 +0000 (13:39 -0400)]
Merge pull request #27572 from larssandergreen/Delete-unneeded-test-file
Remove unintentionally added test file
Alice Frumin [Tue, 19 Sep 2023 15:26:57 +0000 (11:26 -0400)]
[NFC] 5.66 release notes
larssandergreen [Fri, 22 Sep 2023 15:23:37 +0000 (09:23 -0600)]
Remove unintentionally added test file
colemanw [Thu, 21 Sep 2023 23:16:46 +0000 (19:16 -0400)]
Afform - Read afform defn from .aff.php files as well as .aff.json
By switching the file format, defn fields like `title` and `description` can be wrapped in ts().
This is intended for developers and extensions authors. They can generate these php files by calling `Afform.get`
with the api explorer, and copying the result (minus the "layout" field).
FormBuilder still saves files locally in `aff.json` format.
Overriding a packaged `.aff.php` form with a local `aff.json` works fine.
demeritcowboy [Fri, 22 Sep 2023 13:10:23 +0000 (09:10 -0400)]
Merge pull request #27571 from civicrm/5.66
5.66
demeritcowboy [Fri, 22 Sep 2023 12:36:33 +0000 (08:36 -0400)]
Merge pull request #27567 from eileenmcnaughton/action
Loosen action typing - doing nothing is doing something
colemanw [Fri, 22 Sep 2023 12:26:31 +0000 (08:26 -0400)]
Merge pull request #27560 from eileenmcnaughton/event_type
Stop using undefined properties to specify custom data extends values
demeritcowboy [Fri, 22 Sep 2023 12:26:03 +0000 (08:26 -0400)]
Merge pull request #27566 from eileenmcnaughton/price
Fix weight values on PriceSet page
colemanw [Fri, 22 Sep 2023 12:04:23 +0000 (08:04 -0400)]
Merge pull request #27316 from lemniscus/oauth-session-token
Implement OAuthSessionToken
colemanw [Fri, 22 Sep 2023 12:00:19 +0000 (08:00 -0400)]
Merge pull request #27570 from jensschuppe/financialItemEntityTableCampaign
Allow `civicrm_campaign` as `entity_table` for `FinancialItem` API entity
colemanw [Fri, 22 Sep 2023 11:58:58 +0000 (07:58 -0400)]
Merge pull request #27568 from eileenmcnaughton/petition
Fix notice on 'new petition' page
Jens Schuppe [Fri, 22 Sep 2023 09:39:15 +0000 (11:39 +0200)]
Allow `civicrm_campaign` as `entity_table` for `FinancialItem` API entity
Eileen McNaughton [Fri, 22 Sep 2023 08:11:06 +0000 (20:11 +1200)]
Fix notice on 'new petition' page
Eileen McNaughton [Fri, 22 Sep 2023 07:57:17 +0000 (19:57 +1200)]
Loosen action typing - doing nothing is doing something
Eileen McNaughton [Fri, 22 Sep 2023 07:34:26 +0000 (19:34 +1200)]
Fix weight values on PriceSet page
Tim Otten [Fri, 22 Sep 2023 04:41:15 +0000 (21:41 -0700)]
Use subsystem prefix on new setting
Eileen McNaughton [Fri, 22 Sep 2023 04:03:57 +0000 (16:03 +1200)]
Remove unreachable code
The ContributionRecur::add function throws an error if there
is a problem - it doesn't return an error
Noah Miller [Fri, 22 Sep 2023 04:03:43 +0000 (00:03 -0400)]
update function signature to match that in parent class (recently changed)
Noah Miller [Fri, 22 Sep 2023 03:40:36 +0000 (23:40 -0400)]
replace deleteAll with a delete action, no "where" required
Noah Miller [Fri, 22 Sep 2023 03:39:19 +0000 (23:39 -0400)]
make cardinal more reliable; add a little more info to getFields
make cardinal more reliable; add a little more info to getFields
Noah Miller [Fri, 22 Sep 2023 02:46:10 +0000 (22:46 -0400)]
improve PHPDocs
Noah Miller [Fri, 22 Sep 2023 02:44:46 +0000 (22:44 -0400)]
use getEntityName instead of constant
highfalutin [Fri, 22 Sep 2023 01:41:52 +0000 (18:41 -0700)]
PHPDoc for OAuthSessionToken class
Co-authored-by: colemanw <coleman@civicrm.org>
Noah Miller [Wed, 6 Sep 2023 19:38:09 +0000 (15:38 -0400)]
minor improvements, and add a provider for manual testing
Noah Miller [Tue, 5 Sep 2023 17:55:15 +0000 (13:55 -0400)]
implement OAuthSessionToken, with tests
Eileen McNaughton [Fri, 22 Sep 2023 03:31:25 +0000 (15:31 +1200)]
Merge pull request #27558 from colemanw/noPaths
APIv4 - Remove function that doesn't do anything, add some type hints
Eileen McNaughton [Fri, 22 Sep 2023 02:21:36 +0000 (14:21 +1200)]
Stop using undefined properties to specify custom data extends values
colemanw [Fri, 22 Sep 2023 02:05:07 +0000 (22:05 -0400)]
Merge pull request #27552 from eileenmcnaughton/custom_field_trait
Fix assigning of customGroup data to be more re-usable & use undefined properties less
colemanw [Fri, 22 Sep 2023 01:58:29 +0000 (21:58 -0400)]
APIv4 - Remove function that doesn't do anything, add some type hints
colemanw [Fri, 22 Sep 2023 00:57:26 +0000 (20:57 -0400)]
Merge pull request #27495 from eileenmcnaughton/action_notice
Cast _action to an int
colemanw [Fri, 22 Sep 2023 00:55:53 +0000 (20:55 -0400)]
Merge pull request #27555 from larssandergreen/Fix-{php}-in-hlp-test
Remove {php} in hlp test
Eileen McNaughton [Fri, 22 Sep 2023 00:27:04 +0000 (12:27 +1200)]
Merge pull request #27554 from demeritcowboy/quick-safe
dev/core#4616 - Fix js syntax error on contribution page / nonfunctioning honoree toggle
Eileen McNaughton [Thu, 21 Sep 2023 22:05:49 +0000 (10:05 +1200)]
Fix assigning of customGroup data to be more re-usable
larssandergreen [Thu, 21 Sep 2023 23:53:29 +0000 (17:53 -0600)]
Remove {php} in hlp test
colemanw [Thu, 21 Sep 2023 23:34:27 +0000 (19:34 -0400)]
Merge pull request #27535 from eileenmcnaughton/custom
Simplify CustomField::displayValue to expect an ID & have deprecated handling for anything else
colemanw [Thu, 21 Sep 2023 23:32:53 +0000 (19:32 -0400)]
Merge pull request #27532 from eileenmcnaughton/verify_1
Pass `NULL` instead of a value where function requires a parameter but does not use it
colemanw [Thu, 21 Sep 2023 23:31:54 +0000 (19:31 -0400)]
Merge pull request #27474 from eileenmcnaughton/billing_field
php8.x Remove never-used undeclared property
colemanw [Thu, 21 Sep 2023 23:31:11 +0000 (19:31 -0400)]
Merge pull request #27429 from eileenmcnaughton/ref
Fix unnecessary pass-by-ref, minor code improvements
colemanw [Thu, 21 Sep 2023 23:30:38 +0000 (19:30 -0400)]
Merge pull request #27471 from eileenmcnaughton/smartY
Fix Smarty secure mode for premiums tab
colemanw [Thu, 21 Sep 2023 23:30:18 +0000 (19:30 -0400)]
Merge pull request #27470 from eileenmcnaughton/contribution_form
PHP 8.x always assign taxTerm, ppID - backoffice contribution form
demeritcowboy [Thu, 21 Sep 2023 23:30:13 +0000 (19:30 -0400)]
js syntax error when false
Eileen McNaughton [Mon, 18 Sep 2023 21:05:01 +0000 (09:05 +1200)]
Case _action to an int
There is a lot of code comparing to action which is unsure whether it
is dealing with 2 or '2'. It should be possible to always cast to an int but
I have added deprecation just in case...
colemanw [Thu, 21 Sep 2023 23:23:39 +0000 (19:23 -0400)]
Merge pull request #27016 from eileenmcnaughton/tax
Use token for tax_amount, quick config mode
Seamus Lee [Thu, 21 Sep 2023 22:56:17 +0000 (08:56 +1000)]
Merge pull request #27551 from civicrm/5.66
5.66
Eileen McNaughton [Wed, 20 Sep 2023 21:09:43 +0000 (09:09 +1200)]
Simplify CustomField::displayValue to expect an ID & have deprecated handline for anything else
Seamus Lee [Thu, 21 Sep 2023 22:29:00 +0000 (08:29 +1000)]
Merge pull request #27550 from seamuslee001/ca_config_update
Update CAConfig to use 23.07 version
Seamus Lee [Thu, 21 Sep 2023 22:03:14 +0000 (08:03 +1000)]
Update CAConfig to use 23.07 version
Seamus Lee [Thu, 21 Sep 2023 21:26:40 +0000 (07:26 +1000)]
Merge pull request #27522 from eileenmcnaughton/billing
PHP8.2 Pass variables rather than co-erce properties when caling `AbstractEditPayment:processBillingAddress`
colemanw [Thu, 21 Sep 2023 19:42:21 +0000 (15:42 -0400)]
Merge pull request #27548 from larssandergreen/Remove-templates/CRM/Price/Form/LineItem.tpl
Remove unused templates/CRM/Price/Form/LineItem.tpl
Eileen McNaughton [Thu, 21 Sep 2023 19:15:17 +0000 (07:15 +1200)]
Merge pull request #27540 from eileenmcnaughton/membership_type_edit
[php8.x[ Remove notice-causing code that seems unreachable
larssandergreen [Thu, 21 Sep 2023 18:55:26 +0000 (12:55 -0600)]
More Smarty 3+ prep
larssandergreen [Thu, 21 Sep 2023 18:32:47 +0000 (12:32 -0600)]
Remove unused templates/CRM/Price/Form/LineItem.tpl
Eileen McNaughton [Thu, 21 Sep 2023 04:44:54 +0000 (16:44 +1200)]
Set variables when calling customDataBlock.tpl from MembershipType
Eileen McNaughton [Thu, 21 Sep 2023 04:37:46 +0000 (16:37 +1200)]
Remove notice-causing code that seems unreachable
I really can't find any way this code could be triggered - I think it
might have been quietly broken for years...
colemanw [Thu, 21 Sep 2023 17:38:41 +0000 (13:38 -0400)]
Merge pull request #26529 from samuelsov/adminui3
civicrm_admin_ui: add Profile Copy action
Samuel Vanhove [Thu, 21 Sep 2023 16:08:59 +0000 (12:08 -0400)]
civicrm_admin_ui: add Profile Copy action
colemanw [Thu, 21 Sep 2023 15:03:06 +0000 (11:03 -0400)]
Merge pull request #27546 from demeritcowboy/double-honor
Fix double fieldset for honoree section
demeritcowboy [Thu, 21 Sep 2023 14:26:24 +0000 (10:26 -0400)]
Merge pull request #27545 from civicrm/5.66
5.66
colemanw [Thu, 21 Sep 2023 13:39:35 +0000 (09:39 -0400)]
Merge pull request #27541 from eileenmcnaughton/cid_notice
Always assign noCid when the tpl is included
colemanw [Thu, 21 Sep 2023 13:28:09 +0000 (09:28 -0400)]
Merge pull request #27539 from eileenmcnaughton/class_notice
Remove some copy & paste...
demeritcowboy [Thu, 21 Sep 2023 13:18:58 +0000 (09:18 -0400)]
true
demeritcowboy [Thu, 21 Sep 2023 12:55:20 +0000 (08:55 -0400)]
Merge pull request #27446 from demeritcowboy/upgrade-multi-default-566
Add missing upgrade script for multilingual defaults
demeritcowboy [Thu, 21 Sep 2023 12:53:57 +0000 (08:53 -0400)]
Merge pull request #27544 from eileenmcnaughton/badge56
Add weights on badge layout links
Eileen McNaughton [Thu, 21 Sep 2023 09:49:25 +0000 (21:49 +1200)]
Add weights on badge layout links
Tim Otten [Thu, 21 Sep 2023 08:16:17 +0000 (01:16 -0700)]
Merge pull request #27513 from eileenmcnaughton/mailing
dev/core#4567 Add mailing_id, is_test to civicrm_mailing_event_queue
Eileen McNaughton [Thu, 21 Sep 2023 07:06:54 +0000 (19:06 +1200)]
Merge pull request #27542 from civicrm/5.66
5.66
Eileen McNaughton [Thu, 21 Sep 2023 05:19:43 +0000 (17:19 +1200)]
Always assign noCid when the tpl is included
Fixes notices by moving the assign out of the function that adds the form elements
This one only matters when smarty is in secure mode:
Eileen McNaughton [Thu, 21 Sep 2023 04:31:18 +0000 (16:31 +1200)]
Merge pull request #27483 from eileenmcnaughton/8_notice
Php 8.x clean up notices on Profiles
Eileen McNaughton [Thu, 21 Sep 2023 04:22:35 +0000 (16:22 +1200)]
Remove some copy & paste...
Class is never in the rows array - this is copy & paste
Eileen McNaughton [Thu, 21 Sep 2023 03:22:05 +0000 (15:22 +1200)]
Merge pull request #27533 from eileenmcnaughton/hash_less
CiviMail - Generate email auth-code as random string
Eileen McNaughton [Mon, 18 Sep 2023 05:37:31 +0000 (17:37 +1200)]
php8.x Fix notices on displaying FieldSet
Eileen McNaughton [Mon, 18 Sep 2023 05:15:11 +0000 (17:15 +1200)]
Stop using mode as magic for showing the fieldset
Eileen McNaughton [Thu, 21 Sep 2023 02:43:31 +0000 (14:43 +1200)]
Loosen regex
Eileen McNaughton [Thu, 21 Sep 2023 02:11:49 +0000 (14:11 +1200)]
Merge pull request #27536 from totten/master-getclass
PHP 7.x - Use get_class() instead of $object::class