civicrm-core.git
4 years agoMerge pull request #16508 from colemanw/escape
colemanw [Tue, 11 Feb 2020 21:50:02 +0000 (16:50 -0500)]
Merge pull request #16508 from colemanw/escape

Common.js - remove duplicate function

4 years agoMerge pull request #16507 from colemanw/title
Seamus Lee [Tue, 11 Feb 2020 20:44:47 +0000 (07:44 +1100)]
Merge pull request #16507 from colemanw/title

dev/core#1587 Select2 - Use description as title for each option

4 years agoCommon.js - remove duplicate function
Coleman Watts [Tue, 11 Feb 2020 20:43:54 +0000 (15:43 -0500)]
Common.js - remove duplicate function

This function did the same thing as the one in lo-dash

4 years agoSelect2 - Use description as title for each option
Coleman Watts [Tue, 11 Feb 2020 20:07:25 +0000 (15:07 -0500)]
Select2 - Use description as title for each option

4 years agoMerge pull request #16504 from acrollet/master
Eileen McNaughton [Tue, 11 Feb 2020 20:02:11 +0000 (09:02 +1300)]
Merge pull request #16504 from acrollet/master

dev/financial#117 - Add link metadata for payment edit link

4 years agoMerge pull request #16499 from pradpnayak/caseAuditReport
Yashodha Chaku [Tue, 11 Feb 2020 10:06:21 +0000 (15:36 +0530)]
Merge pull request #16499 from pradpnayak/caseAuditReport

Added conditional check so that it can be altered by hook

4 years agoMerge pull request #16505 from eileenmcnaughton/part_pay_dep
Monish Deb [Tue, 11 Feb 2020 09:37:00 +0000 (15:07 +0530)]
Merge pull request #16505 from eileenmcnaughton/part_pay_dep

Add deprecation notices on PartialAmount params

4 years agoMerge pull request #16497 from totten/master-pear-mail-delg
Seamus Lee [Tue, 11 Feb 2020 06:41:22 +0000 (17:41 +1100)]
Merge pull request #16497 from totten/master-pear-mail-delg

(REF) Move CIVICRM_MAIL_LOG logic from patch-files to wrapper-class

4 years agoCRM_Utils_Mail::send - Adjust hack to work with filtered mailer
Tim Otten [Tue, 11 Feb 2020 01:52:41 +0000 (17:52 -0800)]
CRM_Utils_Mail::send - Adjust hack to work with filtered mailer

4 years ago(REF) CRM_Utils_Mail - Split LoggingMailer into FilteredPearMailer and Logger
Tim Otten [Tue, 11 Feb 2020 01:48:50 +0000 (17:48 -0800)]
(REF) CRM_Utils_Mail - Split LoggingMailer into FilteredPearMailer and Logger

1. Captures more context (i.e. the original driver and params)
2. Changes various property names to avoid potential for conflict with delegated properties
3. Adds `addFilter($id, $func)` so that one can move more filters in here
4. Consolidates the various references ot CIVICRM_MAIL_LOG* into one file.

4 years agoMerge pull request #16360 from artfulrobot/case-activities-setting
Eileen McNaughton [Tue, 11 Feb 2020 02:21:40 +0000 (15:21 +1300)]
Merge pull request #16360 from artfulrobot/case-activities-setting

Add CiviCase option for showing case activities in normal views

4 years agoMerge pull request #15410 from herbdool/cloud-21
Mathieu Lu [Tue, 11 Feb 2020 01:41:29 +0000 (20:41 -0500)]
Merge pull request #15410 from herbdool/cloud-21

dev/cloud-native#21 Don't cache the full path of extensions so they don't break with dynamic paths

4 years agoAdd deprecation notices on PartialAmount params
eileen [Mon, 10 Feb 2020 23:19:00 +0000 (12:19 +1300)]
Add deprecation notices on PartialAmount params

We've removed all the places that pass these in so these 2 places handling them are the only remaining references.

All calling code now uses Payment.create to add the payments - yay. Removing these fully will clean up the code
notably

4 years agoCRM_Admin_Form_Setting_Smtp - Use the same mailer as CRM_Utils_Mail
Tim Otten [Mon, 10 Feb 2020 22:09:06 +0000 (14:09 -0800)]
CRM_Admin_Form_Setting_Smtp - Use the same mailer as CRM_Utils_Mail

When civicrm-core used patches to change the behavior of `Mail_mail` (etal),
this was fine.  The preceding commit removes the patches and uses a wrapper
instead - so it's more important to get the same mailer as the
regular CRM_Utils_Mail logic.

4 years agoAdd CiviCase option for showing case activities in normal views
Rich Lott / Artful Robot [Thu, 23 Jan 2020 11:08:30 +0000 (11:08 +0000)]
Add CiviCase option for showing case activities in normal views

Different aproach to tackling #16353

Fix array-to-string notice; Improve activity action links

remove upgrader - as per Pradeep's suggestion

update version added

tweak way description is gotten

update activity tests to check civicaseShowCaseActivities setting

Fix another array-to-string conversion error

Remove File On Case from activity View; add Manage Case

fix case activity links when using caseShowCaseActivities

remove ctx parameter for case activity links

various

US-Englishized Case settings texts.

fix permission name

4 years agoAdd link metadata for payment edit link
Adrian Rollett [Mon, 10 Feb 2020 18:44:23 +0000 (11:44 -0700)]
Add link metadata for payment edit link

4 years agoMerge pull request #16502 from yashodha/header
colemanw [Mon, 10 Feb 2020 14:02:47 +0000 (09:02 -0500)]
Merge pull request #16502 from yashodha/header

remove unnecessary file

4 years agoMerge pull request #16487 from mlutfy/core1019
Yashodha Chaku [Mon, 10 Feb 2020 11:47:11 +0000 (17:17 +0530)]
Merge pull request #16487 from mlutfy/core1019

dev/core#1019 Calculate.tpl: fix the Total Amount currency formatting.

4 years agoMerge pull request #16442 from eileenmcnaughton/pree
Monish Deb [Mon, 10 Feb 2020 09:27:14 +0000 (14:57 +0530)]
Merge pull request #16442 from eileenmcnaughton/pree

Fix backoffice participant partial payments to be stdised & not miscalculate net_amount

4 years agoremove unnecessary file
yashodha [Mon, 10 Feb 2020 07:46:49 +0000 (13:16 +0530)]
remove unnecessary file

4 years agoMerge pull request #16500 from eileenmcnaughton/fatal
Seamus Lee [Mon, 10 Feb 2020 07:19:02 +0000 (18:19 +1100)]
Merge pull request #16500 from eileenmcnaughton/fatal

Remove fatal  from  form

4 years agoRemove fatal from form
eileen [Mon, 10 Feb 2020 06:04:09 +0000 (19:04 +1300)]
Remove fatal  from  form

4 years agoMerge pull request #16475 from JMAConsulting/core_1577
Eileen McNaughton [Mon, 10 Feb 2020 04:11:35 +0000 (17:11 +1300)]
Merge pull request #16475 from JMAConsulting/core_1577

dev/core#1577 : Custom Group Types not filterable

4 years agoMerge pull request #16465 from albionbrown/#1565-API-Exception
Eileen McNaughton [Mon, 10 Feb 2020 02:50:11 +0000 (15:50 +1300)]
Merge pull request #16465 from albionbrown/#1565-API-Exception

Throwing API_Exception is file fails to copy when creating attachment…

4 years agoAdded conditional check so that it can be altered by hook
Pradeep Nayak [Mon, 10 Feb 2020 00:53:40 +0000 (00:53 +0000)]
Added conditional check so that it can be altered by hook

4 years ago(REF) Move CIVICRM_MAIL_LOG logic from patch-files to wrapper-class
Tim Otten [Fri, 7 Feb 2020 23:15:14 +0000 (15:15 -0800)]
(REF) Move CIVICRM_MAIL_LOG logic from patch-files to wrapper-class

Overview
--------

This aims to improve maintainablity and deployment workflows by reduing the
scope of the needed files.

It is an alternative approach for #16481.

Before
------

`civicrm-core` included patch files for `pear/mail`.  These files modified
the behavior of `Mail_sendmail`, `Mail_smtp`, and `Mail_mail` to ensure that
the `send()` function would abide by the `CIVICRM_MAIL_LOG` constant.

After
-----

`civicrm-core` includes a wrapper class `LoggingMailer`.  It takes an
instance of `Mail_sendmail`, `Mail_smtp`, or `Mail_mail` and mixes-in the
`CIVICRM_MAIL_LOG` logic.

Technical Details
-----------------

There is a `hook_civicrm_alterMailer`, for which consumers could potentially
see a change in behavior (because the concrete-class of `$mailer` may
change and support different properties). Mitigating factors:

* There is only one public method in the `Mail` contract: `send()`.
* The only example of `alterMailer` in the documentation suggests
  that you wholly replace the object with your own implementation.
  This was the original purpose. If you use it this way, then it doesn't
  matter what's happening inside the old object.
  https://docs.civicrm.org/dev/en/latest/hooks/hook_civicrm_alterMailer/
* In public `universe`, there is only one extension (Cividesk's Sparkpost)
  which uses this hook. And it does swap in that expected way.
* Just in case... the `LoggingMailer` passes-through all calls to read/write properties.
  You can see this in action in a specific configuration, e.g.
  ```
  ## Before patch
  $ cv ev '$m=Civi::service("pear_mail"); return [get_class($m), $m->host];'
  [
      "Mail_smtp",
      "127.0.0.1"
  ]

  ## After patch
  $ cv ev '$m=Civi::service("pear_mail"); return [get_class($m), $m->host];'
  [
      "CRM_Utils_Mail_LoggingMailer",
      "127.0.0.1"
  ]
  ```

4 years agoMerge pull request #16494 from mattwire/enablevalidate
Seamus Lee [Fri, 7 Feb 2020 21:43:42 +0000 (08:43 +1100)]
Merge pull request #16494 from mattwire/enablevalidate

Enable jQuery validate on register/contribution forms

4 years agoMerge pull request #16493 from mattwire/unusedcode
Seamus Lee [Fri, 7 Feb 2020 21:43:32 +0000 (08:43 +1100)]
Merge pull request #16493 from mattwire/unusedcode

Remove unused code

4 years agoMerge pull request #16492 from yashodha/header
Seamus Lee [Fri, 7 Feb 2020 20:10:17 +0000 (07:10 +1100)]
Merge pull request #16492 from yashodha/header

fix headers

4 years agoEnable jQuery validate on register/contribution forms
Matthew Wire [Fri, 7 Feb 2020 20:03:52 +0000 (20:03 +0000)]
Enable jQuery validate on register/contribution forms

4 years agoRemove unused code
Matthew Wire [Thu, 6 Feb 2020 22:40:03 +0000 (22:40 +0000)]
Remove unused code

4 years agoMerge pull request #16490 from seamuslee001/dompdf_update_script
colemanw [Fri, 7 Feb 2020 15:13:25 +0000 (10:13 -0500)]
Merge pull request #16490 from seamuslee001/dompdf_update_script

[REF] Remove patch from dompdf cleanup script that is no longer needed

4 years agofix headers
yashodha [Fri, 7 Feb 2020 11:12:08 +0000 (16:42 +0530)]
fix headers

4 years ago[REF] Remove patch from dompdf cleanup script that is no longer needed
Seamus Lee [Fri, 7 Feb 2020 03:46:48 +0000 (14:46 +1100)]
[REF] Remove patch from dompdf cleanup script that is no longer needed

4 years agoMerge pull request #16489 from civicrm/5.23
Seamus Lee [Fri, 7 Feb 2020 03:41:13 +0000 (14:41 +1100)]
Merge pull request #16489 from civicrm/5.23

5.23

4 years agoMerge pull request #16483 from seamuslee001/utf8mb4_min
Seamus Lee [Fri, 7 Feb 2020 01:06:49 +0000 (12:06 +1100)]
Merge pull request #16483 from seamuslee001/utf8mb4_min

[NFC] Skip utf8mb4 test on MySQL versions lower than 5.7

4 years agoMerge pull request #13078 from agh1/contactdetail-no-or2
Mathieu Lu [Thu, 6 Feb 2020 22:20:04 +0000 (17:20 -0500)]
Merge pull request #13078 from agh1/contactdetail-no-or2

Improve activity query performance in Constituent Detail Report

4 years agoMerge pull request #16459 from eileenmcnaughton/rec_ver
Mathieu Lu [Thu, 6 Feb 2020 22:05:41 +0000 (17:05 -0500)]
Merge pull request #16459 from eileenmcnaughton/rec_ver

Make php 7.3 the recommended php version

4 years agoMerge pull request #16486 from mfb/year-typo
Mathieu Lu [Thu, 6 Feb 2020 22:01:38 +0000 (17:01 -0500)]
Merge pull request #16486 from mfb/year-typo

Fix year typo.

4 years agodev/core#1019 Calculate.tpl: fix the Total Amount currency formatting (code reformatt...
Mathieu Lutfy [Thu, 6 Feb 2020 20:05:04 +0000 (15:05 -0500)]
dev/core#1019 Calculate.tpl: fix the Total Amount currency formatting (code reformatting).

4 years agodev/core#1019 Calculate.tpl: fix the Total Amount currency formatting.
Mathieu Lutfy [Thu, 6 Feb 2020 19:56:41 +0000 (14:56 -0500)]
dev/core#1019 Calculate.tpl: fix the Total Amount currency formatting.

4 years agoFix year typo.
mark burdett [Thu, 6 Feb 2020 19:15:57 +0000 (11:15 -0800)]
Fix year typo.

4 years agodev/core#1577 : Custom Group Types not filterable
Monish Deb [Wed, 5 Feb 2020 12:34:05 +0000 (18:04 +0530)]
dev/core#1577 : Custom Group Types not filterable

4 years agoSet version to 5.24.alpha1
CiviCRM [Thu, 6 Feb 2020 07:14:40 +0000 (07:14 +0000)]
Set version to 5.24.alpha1

4 years agoSet version to 5.23.beta1
CiviCRM [Thu, 6 Feb 2020 07:07:34 +0000 (07:07 +0000)]
Set version to 5.23.beta1

4 years ago[NFC] Skip utf8mb4 test on MySQL versions lower than 5.7
Seamus Lee [Thu, 6 Feb 2020 04:21:59 +0000 (15:21 +1100)]
[NFC] Skip utf8mb4 test on MySQL versions lower than 5.7

4 years agoMerge pull request #16485 from seamuslee001/master
Seamus Lee [Thu, 6 Feb 2020 06:46:15 +0000 (17:46 +1100)]
Merge pull request #16485 from seamuslee001/master

release-notes: Late changes for 5.22 release notes

4 years agorelease-notes: Late changes for 5.22 release notes
Alice Frumin [Wed, 5 Feb 2020 15:36:22 +0000 (10:36 -0500)]
release-notes: Late changes for 5.22 release notes

4 years agoMerge pull request #16457 from colemanw/api4doc
Seamus Lee [Wed, 5 Feb 2020 19:07:28 +0000 (06:07 +1100)]
Merge pull request #16457 from colemanw/api4doc

APIv4 documentation & code cleanup

4 years agoUpdate api/v3/Attachment.php to remove concatenation
Josh Brown [Wed, 5 Feb 2020 08:25:55 +0000 (08:25 +0000)]
Update api/v3/Attachment.php to remove concatenation

Co-Authored-By: colemanw <coleman@civicrm.org>
4 years agoMerge pull request #16472 from eileenmcnaughton/cn_for_now
Seamus Lee [Wed, 5 Feb 2020 07:05:11 +0000 (18:05 +1100)]
Merge pull request #16472 from eileenmcnaughton/cn_for_now

Revert "Remove unreachable code lines."

4 years agoMerge pull request #16466 from mattwire/recurringentity_copy
Seamus Lee [Wed, 5 Feb 2020 06:57:54 +0000 (17:57 +1100)]
Merge pull request #16466 from mattwire/recurringentity_copy

Call hook_civicrm_copy for RecurringEntity

4 years agoMerge pull request #16471 from totten/master-psr-log
Seamus Lee [Wed, 5 Feb 2020 06:44:55 +0000 (17:44 +1100)]
Merge pull request #16471 from totten/master-psr-log

composer.json - Relax psr/log constraint. Improve D8 compatibility.

4 years agoRevert "Remove unreachable code lines."
eileen [Wed, 5 Feb 2020 05:12:54 +0000 (18:12 +1300)]
Revert "Remove unreachable code lines."

In the course of https://github.com/civicrm/civicrm-core/pull/16462
I concluded that there might be (untested scenarios) where this would still be hit.

In #16462 I adopted a cleaner (tested) approach. However, I think it's unlikely that
will be merged before 5.23 is cut so I propose reverting this change & re-reverting it
once the rc is cut as a more conservative approach. We can focus on getting #16462
wrapped up for 5.24

This reverts commit d7943ca7f7107c1466e687e876bddaf0f1998d99.

4 years agoMerge pull request #16460 from colemanw/noInclude
Eileen McNaughton [Wed, 5 Feb 2020 04:44:29 +0000 (17:44 +1300)]
Merge pull request #16460 from colemanw/noInclude

APIv3 - Only scan files for deprecation checks in Entity.get

4 years agocomposer.json - Relax psr/log constraint. Improve D8 compatibility.
Tim Otten [Wed, 5 Feb 2020 03:53:58 +0000 (19:53 -0800)]
composer.json - Relax psr/log constraint. Improve D8 compatibility.

Overview
--------

This addresses a composer conflict that's reported when trying to install
on Drupal 8.7. For example, run these commands:

```
drush8 dl drupal-8.7.x
cd drupal-8*
composer require civicrm/civicrm-core:5.22.x-dev
```

This is a port of #16470 for `master`.

Before
------

The install fails because `civicrm-core` requires `psr/log:~1.1`, and something else
is prodding us to use `psr/log:1.0.2`.

```
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Installation request for civicrm/civicrm-core 5.22.x-dev -> satisfiable by civicrm/civicrm-core[5.22.x-dev].
    - Conclusion: remove psr/log 1.0.2
    - Conclusion: don't install psr/log 1.0.2
    - civicrm/civicrm-core 5.22.x-dev requires psr/log ~1.1 -> satisfiable by psr/log[1.1.0, 1.1.1, 1.1.2, 1.1.x-dev].
    - Can only install one of: psr/log[1.1.0, 1.0.2].
    - Can only install one of: psr/log[1.1.1, 1.0.2].
    - Can only install one of: psr/log[1.1.2, 1.0.2].
    - Can only install one of: psr/log[1.1.x-dev, 1.0.2].
    - Installation request for psr/log (locked at 1.0.2) -> satisfiable by psr/log[1.0.2].

Installation failed, reverting ./composer.json to its original content.
```

After
-----

It should work.  However, this is hard to demonstrate via `r-run` without merging.

Comments
--------

The substantive differences between `psr/log` in v1.0 and v1.1 relate to `LoggerInterfaceTest` and `TestLogger`:

https://github.com/php-fig/log/compare/1.0.2...1.1.2

However, `civicrm-core` does not use `LoggerInterfaceTest` or `TestLogger`, so it shouldn't matter.

For the standard tarballs which use `composer.lock`, this does have the side-effect of bumping up from 1.1.0 to 1.1.2.

4 years agoMerge pull request #16458 from twomice/1573_extra_columns_contribution_detail_report
Eileen McNaughton [Wed, 5 Feb 2020 03:01:22 +0000 (16:01 +1300)]
Merge pull request #16458 from twomice/1573_extra_columns_contribution_detail_report

Fix for #1573: Extra columns for Contribution Detail report.

4 years agoAPIv4 Organize debug sql into a single array
Coleman Watts [Tue, 4 Feb 2020 14:12:17 +0000 (09:12 -0500)]
APIv4 Organize debug sql into a single array

4 years agoMerge pull request #16469 from civicrm/5.22
Eileen McNaughton [Tue, 4 Feb 2020 22:43:47 +0000 (11:43 +1300)]
Merge pull request #16469 from civicrm/5.22

5.22 to master

4 years agoMerge pull request #16464 from WeMoveEU/core-1564-against-5.22
Eileen McNaughton [Tue, 4 Feb 2020 22:43:13 +0000 (11:43 +1300)]
Merge pull request #16464 from WeMoveEU/core-1564-against-5.22

dev/core#1564 Fix category name for a/b test temporary table

4 years agoMerge pull request #16463 from eileenmcnaughton/obscure
Seamus Lee [Tue, 4 Feb 2020 22:08:59 +0000 (09:08 +1100)]
Merge pull request #16463 from eileenmcnaughton/obscure

Fix obscure bug

4 years agoCall hook_civicrm_copy when we copy entities using RecurringEntity
Matthew Wire [Tue, 4 Feb 2020 11:43:20 +0000 (11:43 +0000)]
Call hook_civicrm_copy when we copy entities using RecurringEntity

4 years agoThrowing API_Exception is file fails to copy when creating attachment with APIv3
Josh Brown [Tue, 4 Feb 2020 11:15:33 +0000 (11:15 +0000)]
Throwing API_Exception is file fails to copy when creating attachment with APIv3

4 years agodev/core#1564 Fix category name for a/b test temporary table
scardinius [Thu, 30 Jan 2020 09:10:04 +0000 (10:10 +0100)]
dev/core#1564 Fix category name for a/b test temporary table

4 years agoFix obscure bug
eileen [Tue, 4 Feb 2020 07:26:58 +0000 (20:26 +1300)]
Fix obscure bug

After upgrading to MacOS Catalina & MAMP 5.6 (latest) with php version 7.4.1 or 7.3.9
my site was unable to load CiviCRM with a segfault error. I traced it to this line & found that
phpstorm was highlighting the line it red as possibly subject to https://bugs.php.net/bug.php?id=62577

- taking phpstorm's recommendation allowed the site to load - the failure had been on parsing info.xml files

4 years agoMerge pull request #16461 from eileenmcnaughton/api_test
Seamus Lee [Tue, 4 Feb 2020 05:24:53 +0000 (16:24 +1100)]
Merge pull request #16461 from eileenmcnaughton/api_test

Add require_once to api3TestTrait

4 years agoAdd require_once to api3TestTrait
eileen [Tue, 4 Feb 2020 02:11:11 +0000 (15:11 +1300)]
Add require_once to api3TestTrait

I used this trait from an extension but it was used with apiv4 before apiv3 (it supports both).

I got an error because utils.php is not included by this file. It 'freeloads' off the fact apiv3 initialises
the file - but in fact the file that includes a function requiring a function
should have the require once - reduces risk & cognitive load

4 years agoAPIv3 - Only scan files for deprecation checks in Entiy.get
Coleman Watts [Tue, 4 Feb 2020 02:00:48 +0000 (21:00 -0500)]
APIv3 - Only scan files for deprecation checks in Entiy.get

4 years agoMake php 7.3 the recommended php version
eileen [Tue, 4 Feb 2020 01:00:46 +0000 (14:00 +1300)]
Make php 7.3 the recommended php version

We definitely should be recomending the latest version we know it works on

4 years agoAPIv4 - Pluralize entity name in docblocks
Coleman Watts [Mon, 3 Feb 2020 23:05:38 +0000 (18:05 -0500)]
APIv4 - Pluralize entity name in docblocks

4 years agoFix for #1573: Extra columns for Contribution Detail report.
Allen Shaw [Mon, 3 Feb 2020 19:18:45 +0000 (13:18 -0600)]
Fix for #1573: Extra columns for Contribution Detail report.

4 years agoAdd additional test and fixes to ensure that results are the same when
eileen [Sat, 1 Feb 2020 22:24:36 +0000 (11:24 +1300)]
Add additional test and fixes to ensure that results are the  same when

1) creating a partially paid registration with a pending contribution & then adding a payment to  that contribution
2) creating a partially paid registration with a completed contribution for a partial amount
3) created a pending registration with a pending contribution & adding a payment to the contribution.

Note that the following bugs previously affected these flows
 - flow 1 & 2 net_amount was incorrect
 - flow 1, an extraneous payment was added
 - flow 3, participant status was not updated from pending to partially paid on adding a payment

4 years agoUse correct...er flow to create partial payments on events
eileen [Fri, 31 Jan 2020 08:27:18 +0000 (21:27 +1300)]
Use correct...er flow to create partial payments on events

This fixes the methodology for recording partial payments on the backoffice contribution form to create a pending contribution (order)
and then add a payment. The previous method was our first cut at supporting partial payments (before the Order+Payment flow) and
relies on some handling in the BAO which is crufty & has proven unreliable. This allows us to deprecate that handling & remove the
now unused addPayments function.

Prior to this PR I wrote a test for current behaviour & I had to alter that test for this as follows

1) prior to this change net_amount was clearly miscalculated & hence this fixes & I updated the test
2) prior to this change a financial transaction was created for the contribution. Now only the payment financial transaction is made.
3) prior to this change the financial item was set to partially paid, not it is still 'unpaid'

Items 1 is clearly a bug fix whereas 2 & 3 are a bit borderline.

Item 2 is the fact that for pending contributions (in general) we don't create financial items when creating them. We do for (some) other
statuses. This was  discussed here https://github.com/civicrm/civicrm-dev-docs/issues/712#issuecomment-545164618 & the summary was
'it would be better to change this but this is what was the scope /how it is'

Item 3 is discussed in https://docs.civicrm.org/dev/en/latest/financial/financialentities/ with the summary  being that in any other path
to creating a partial payment the financial item would be left at 'Unpaid' - hopefully until it's fully paid.

Item 1 is a clear bug fix & I think the fact no-one picked it up is material because it gives us a clue as to how many
people use this rather obscure flow that requires an admin user to alter the status to 'partially  paid' and alter the amount.

Given the above we have a choice
1) Make this flow behave like other flows, despite this flow being arguably correct or
2) Hack away to keep the current quirks

I've come down on the side of 1 as a standardisation. I think changing it so items 2 & 3 behave differently is worth pursuing but it's better
for this edge case flow to do the same as our approved flow & if we want to iterate on that we can

4 years agoMerge pull request #16441 from eileenmcnaughton/event_pre
Seamus Lee [Mon, 3 Feb 2020 20:58:30 +0000 (07:58 +1100)]
Merge pull request #16441 from eileenmcnaughton/event_pre

[REF] Interim code cleanup - make the usage of addPayments clearer

4 years agoApi4 Replace - simplify by removing unnecessary fallback
Coleman Watts [Mon, 3 Feb 2020 18:22:01 +0000 (13:22 -0500)]
Api4 Replace - simplify by removing unnecessary fallback

4 years agoClearer docblock description of the defaults param
Coleman Watts [Mon, 3 Feb 2020 18:17:58 +0000 (13:17 -0500)]
Clearer docblock description of the defaults param

4 years agoAPIv4 Explorer - use OOP format for chained api calls
Coleman Watts [Mon, 3 Feb 2020 18:05:39 +0000 (13:05 -0500)]
APIv4 Explorer - use OOP format for chained api calls

Passing an array into setChain works, but the more "pure" way is to pass an object into addChain.

4 years agoMerge pull request #16446 from mattwire/wp_passlanguage
Mathieu Lu [Mon, 3 Feb 2020 18:04:07 +0000 (13:04 -0500)]
Merge pull request #16446 from mattwire/wp_passlanguage

Pass language code to CiviCRM for Wordpress

4 years agoMerge pull request #16397 from eileenmcnaughton/cont_setting3
colemanw [Mon, 3 Feb 2020 01:52:25 +0000 (20:52 -0500)]
Merge pull request #16397 from eileenmcnaughton/cont_setting3

dev/core#1558 retrieve setting credit_notes_prefix as  a 'real' setting.

4 years agoMerge pull request #16449 from colemanw/docVars
Eileen McNaughton [Sun, 2 Feb 2020 20:18:06 +0000 (09:18 +1300)]
Merge pull request #16449 from colemanw/docVars

APIv4 - Variable substution in docblocks

4 years agoMerge pull request #16454 from colemanw/explorerDefaults
Eileen McNaughton [Sun, 2 Feb 2020 20:17:00 +0000 (09:17 +1300)]
Merge pull request #16454 from colemanw/explorerDefaults

APIv4 Explorer - Better UI for defaults param

4 years agoAPIv4 Explorer - Better UI for defaults param
Coleman Watts [Sun, 2 Feb 2020 14:54:00 +0000 (09:54 -0500)]
APIv4 Explorer - Better UI for defaults param

4 years agoMerge pull request #16452 from mattwire/tokenrow_docblock
Seamus Lee [Sun, 2 Feb 2020 02:38:20 +0000 (13:38 +1100)]
Merge pull request #16452 from mattwire/tokenrow_docblock

NFC Fix TokenRow docblock

4 years agoFix TokenRow docblock
Matthew Wire [Sun, 2 Feb 2020 00:28:37 +0000 (00:28 +0000)]
Fix TokenRow docblock

4 years agoAPIv4 - Variable substution in docblocks
Coleman Watts [Fri, 31 Jan 2020 22:06:41 +0000 (17:06 -0500)]
APIv4 - Variable substution in docblocks

Replaces $ENTITY and $ACTION in docblocks to improve help text in the api explorer.

4 years agoMerge pull request #16450 from eileenmcnaughton/ev_test
Seamus Lee [Sat, 1 Feb 2020 03:20:42 +0000 (14:20 +1100)]
Merge pull request #16450 from eileenmcnaughton/ev_test

[NFC] Minor test cleanup.

4 years agoMinor test cleanup.
eileen [Sat, 1 Feb 2020 00:08:48 +0000 (13:08 +1300)]
Minor test cleanup.

4 years agoMerge pull request #16438 from eileenmcnaughton/ev_clean
colemanw [Fri, 31 Jan 2020 22:32:45 +0000 (17:32 -0500)]
Merge pull request #16438 from eileenmcnaughton/ev_clean

[REF] Pass params into function rather than this weird check for whether params exists.

4 years agoMerge pull request #16447 from samuelsov/lab#1319
Seamus Lee [Fri, 31 Jan 2020 21:09:11 +0000 (08:09 +1100)]
Merge pull request #16447 from samuelsov/lab#1319

dev/core#1319 Fix regression with shared household address

4 years agodev/core#1319 UI - different label for household and employer
Samuel Vanhove [Fri, 31 Jan 2020 16:33:29 +0000 (11:33 -0500)]
dev/core#1319 UI - different label for household and employer

4 years agoPass language code to CiviCRM
Matthew Wire [Fri, 31 Jan 2020 16:17:54 +0000 (16:17 +0000)]
Pass language code to CiviCRM

4 years agoMerge pull request #16267 from jitendrapurohit/dev-1471
Yashodha Chaku [Fri, 31 Jan 2020 13:52:21 +0000 (19:22 +0530)]
Merge pull request #16267 from jitendrapurohit/dev-1471

dev/core#1471 - Add system status alert for deleted custom fields in …

4 years ago[REF] Interim code cleanup - make the usage of addPayments clearer
eileen [Fri, 31 Jan 2020 07:55:16 +0000 (20:55 +1300)]
[REF] Interim code cleanup - make the usage of addPayments clearer

This brings the condition back to the calling function which clarifies what is going on with it

4 years agoMerge pull request #16437 from eileenmcnaughton/ev_back
Eileen McNaughton [Fri, 31 Jan 2020 08:30:36 +0000 (21:30 +1300)]
Merge pull request #16437 from eileenmcnaughton/ev_back

Add unit test to back office form when a payment is made against a partially paid contribution

4 years agoMerge pull request #16439 from eileenmcnaughton/part_odd
Seamus Lee [Fri, 31 Jan 2020 07:13:13 +0000 (18:13 +1100)]
Merge pull request #16439 from eileenmcnaughton/part_odd

Respect form value for register_date on partipant form

4 years agodev/core#1558 retrieve credit_notes_prefix as a 'real' setting.
eileen [Thu, 30 Jan 2020 21:57:40 +0000 (10:57 +1300)]
dev/core#1558 retrieve credit_notes_prefix as a 'real' setting.

    This is part of work to convert the non-standard contribution_invoice_settings array of settings into settings in line
    with our standards

4 years agoExtend checks in test
eileen [Fri, 31 Jan 2020 02:55:59 +0000 (15:55 +1300)]
Extend checks in test

4 years agoMerge pull request #16425 from colemanw/markdown
Seamus Lee [Fri, 31 Jan 2020 05:34:21 +0000 (16:34 +1100)]
Merge pull request #16425 from colemanw/markdown

Use markdown in php docblocks & display in APIv4 Explorer

4 years agoMerge pull request #16098 from MegaphoneJon/event-23-correct
Seamus Lee [Fri, 31 Jan 2020 05:33:32 +0000 (16:33 +1100)]
Merge pull request #16098 from MegaphoneJon/event-23-correct

event#23 - don't count non-counted participants on Confirm Registrati…

4 years agoRespect form value for register_date on partipant form
eileen [Fri, 31 Jan 2020 04:45:06 +0000 (17:45 +1300)]
Respect form value for register_date on partipant form

The backoffice event registration form has a register_date field. In credit card mode it
does an awful lot of handling which is mostly for legacy code reasons but the net result is to ignore it
& set it to now. However, the field defaults to now & if someone actually changed it they would expect their change to
be respected. This removes that handling & just uses the field value entered. The field is always present from my
digging