Tim Otten [Fri, 31 Dec 2021 00:57:50 +0000 (18:57 -0600)]
(NFC) ContributionTrait
Eileen McNaughton [Wed, 29 Dec 2021 22:00:08 +0000 (11:00 +1300)]
Add workflow template classes for contributions
Eileen McNaughton [Thu, 30 Dec 2021 21:10:38 +0000 (10:10 +1300)]
Merge pull request #22285 from eileenmcnaughton/token_quotes
dev/core#3001 escape single quotes when rendering tokens in html format
Tim Otten [Thu, 30 Dec 2021 17:58:41 +0000 (11:58 -0600)]
TokenSmartyTest - Add more coverage re: HTML escaping of data
demeritcowboy [Thu, 30 Dec 2021 13:21:43 +0000 (08:21 -0500)]
Merge pull request #22280 from eileenmcnaughton/statuses
[REF] Simplify getContributionStatuses
Eileen McNaughton [Thu, 30 Dec 2021 00:55:05 +0000 (13:55 +1300)]
Merge pull request #22342 from civicrm/5.45
5.45 to master
Eileen McNaughton [Thu, 30 Dec 2021 00:54:35 +0000 (13:54 +1300)]
Merge pull request #22341 from MegaphoneJon/core-3013
fixes core#3013 - error when creating > 25 thank-you letters
Jon Goldberg [Wed, 29 Dec 2021 23:11:21 +0000 (18:11 -0500)]
fixes core#3013 - error when creating > 25 thank-you letters
Eileen McNaughton [Wed, 29 Dec 2021 22:50:50 +0000 (11:50 +1300)]
Merge pull request #22321 from colemanw/searchAdminPagerConfigFix
SearchKit - Fix UI for configuring display pager limit
Eileen McNaughton [Mon, 20 Dec 2021 01:17:24 +0000 (14:17 +1300)]
Simplify handing when name not present (new contribution)
Eileen McNaughton [Mon, 20 Dec 2021 01:15:14 +0000 (14:15 +1300)]
[REF] Simplify getContributionStatuses
The effect of the altered calls to getContributionStatus is to get a small set of options returned.
In the cases of participant & membership forms this is pending or completed. For
the ufGroup option it seems cancelled & failed are also data entry options (this method
should still cope if they don't exist).
The existing function is really confusing - but all that confusion is designed for one
form - back office contribution form - and augmented by overloading by other functions.
This splits it out.
Could sites be using 'weird and wonderful other statuses'? Our system really is set up
around supporting specific statuses and doing financial entries for those so I think maybe
we are right to not try to pander to any that could exist
demeritcowboy [Wed, 29 Dec 2021 18:09:56 +0000 (13:09 -0500)]
Merge pull request #22339 from braders/exception-missing-message-fix
[NFC] CRM_Core_Exception incorrectly called without message
demeritcowboy [Wed, 29 Dec 2021 16:45:18 +0000 (11:45 -0500)]
Merge pull request #21596 from agileware/CIVICRM-1845
Find Activities Search, default search option for Activity Status will exclude Activities by default which do not have a status of Scheduled or Completed. Confuses and frustrates End Users.
demeritcowboy [Wed, 29 Dec 2021 16:43:48 +0000 (11:43 -0500)]
Merge pull request #22303 from braders/core-2926-crm-summary-links
"Open in new tab" on .crm-summary-link icons should open contact page
demeritcowboy [Wed, 29 Dec 2021 16:41:50 +0000 (11:41 -0500)]
Merge pull request #22338 from braders/setstatus-param-fixes
Fix params passed to setStatus method
demeritcowboy [Wed, 29 Dec 2021 16:27:16 +0000 (11:27 -0500)]
Merge pull request #22333 from mlutfy/fixTsRecaptcha
Fix Profile helptext menu reference to reCaptcha (by r4zoli)
Mathieu Lutfy [Tue, 28 Dec 2021 13:38:41 +0000 (08:38 -0500)]
Fix Profile helptext menu reference to reCaptcha (by r4zoli)
Bradley Taylor [Wed, 29 Dec 2021 13:49:19 +0000 (13:49 +0000)]
CRM_Core_Exception incorrectly called without message
Bradley Taylor [Wed, 29 Dec 2021 13:33:59 +0000 (13:33 +0000)]
Fix params passed to setStatus method
Yashodha Chaku [Wed, 29 Dec 2021 11:03:45 +0000 (16:33 +0530)]
Merge pull request #22315 from braders/more-hardcoded-strings-2
Wrap another set of hardcoded strings in {ts}
colemanw [Wed, 29 Dec 2021 02:34:05 +0000 (21:34 -0500)]
Merge pull request #22334 from braders/docblock-and-comment-improvements
Fix inaccuracies and mistakes in comments (especially phpdoc comments)
demeritcowboy [Tue, 28 Dec 2021 21:03:27 +0000 (16:03 -0500)]
Merge pull request #22335 from braders/participant-static-method
Correctly mark updateStatusMessage method as static
demeritcowboy [Tue, 28 Dec 2021 20:58:29 +0000 (15:58 -0500)]
Merge pull request #22336 from braders/crm-core-extension-typo
Fix typo. CRM_Core_Execption should be CRM_Core_Exception
Bradley Taylor [Tue, 28 Dec 2021 19:25:56 +0000 (19:25 +0000)]
Fix typo. CRM_Core_Execption should be CRM_Core_Exception
Bradley Taylor [Tue, 28 Dec 2021 19:18:24 +0000 (19:18 +0000)]
Correctly mark updateStatusMessage method as static
Bradley Taylor [Tue, 28 Dec 2021 13:53:46 +0000 (13:53 +0000)]
Fix inaccuracies and mistakes in comments
(especially phpdoc comments)
colemanw [Tue, 28 Dec 2021 14:01:20 +0000 (09:01 -0500)]
Merge pull request #22332 from braders/remove-getGrantStatusOptGroup
Remove unused method getGrantStatusOptGroup
Bradley Taylor [Tue, 28 Dec 2021 11:54:20 +0000 (11:54 +0000)]
Remove unused method getGrantStatusOptGroup
Seamus Lee [Tue, 28 Dec 2021 03:26:08 +0000 (14:26 +1100)]
Merge pull request #22310 from sunilpawar/fix_js_error
Fix JS Error for Free event with multiple participant on registration…
demeritcowboy [Mon, 27 Dec 2021 23:30:17 +0000 (18:30 -0500)]
Merge pull request #22331 from colemanw/fixDefaultDisplay
SearchKit - Fix column headers for custom fields in default display
Coleman Watts [Mon, 27 Dec 2021 21:38:12 +0000 (16:38 -0500)]
SearchKit - Fix column headers for custom fields in default display (standalone)
- Create a search with at least one custom field as a column
- Click the "View" button to visit the standalone display
- Column header for custom fields will be blank without this patch
demeritcowboy [Mon, 27 Dec 2021 16:29:06 +0000 (11:29 -0500)]
Merge pull request #22328 from colemanw/fixCustomNull
APIv4 - Fix saving NULL as custom field value
Coleman Watts [Mon, 27 Dec 2021 14:15:36 +0000 (09:15 -0500)]
APIv4 - Fix saving NULL as custom field value
Fixes dev/report#89
Sunil Pawar [Thu, 23 Dec 2021 08:34:48 +0000 (14:04 +0530)]
Fix JS Error for Free event with multiple participant on registration screen
added comment and same check on waiting list
Eileen McNaughton [Mon, 27 Dec 2021 05:37:36 +0000 (18:37 +1300)]
Merge pull request #22322 from colemanw/groupContactDefaults
APIv4 - Set default status when creating GroupContact record
Coleman Watts [Mon, 27 Dec 2021 00:52:57 +0000 (19:52 -0500)]
APIv4 - Set default status when creating GroupContact record
Fixes dev/core#2924
Coleman Watts [Sun, 26 Dec 2021 21:19:27 +0000 (16:19 -0500)]
SearchKit - Fix UI for configuring display pager limit
Fixes dev/core#3006
demeritcowboy [Fri, 24 Dec 2021 16:04:55 +0000 (11:04 -0500)]
Merge pull request #22292 from totten/master-authxlogin-2
Add authx_login() API for backend script authentication (alt)
demeritcowboy [Fri, 24 Dec 2021 15:10:50 +0000 (10:10 -0500)]
Merge pull request #22307 from eileenmcnaughton/mixed_currency
Demo sample data - Add in some mixed currency contributions
Bradley Taylor [Thu, 23 Dec 2021 16:20:37 +0000 (16:20 +0000)]
Wrap another set of hardcoded strings in {ts}
Tim Otten [Fri, 24 Dec 2021 05:39:01 +0000 (21:39 -0800)]
Merge pull request #22311 from braders/docurl-translate-text-and-fix-urls
Allow text to be translated and fix URL paths in calls to docURL() function.
Tim Otten [Fri, 24 Dec 2021 01:02:41 +0000 (17:02 -0800)]
Merge pull request #22312 from mlutfy/eventPhpTweak
Event Registration: initialize array
Seamus Lee [Fri, 24 Dec 2021 00:02:03 +0000 (11:02 +1100)]
Merge pull request #22317 from civicrm/5.45
5.45
Tim Otten [Thu, 23 Dec 2021 23:36:14 +0000 (15:36 -0800)]
authx - Report a valid outcome if you are already logged in
Eileen McNaughton [Thu, 23 Dec 2021 22:55:16 +0000 (11:55 +1300)]
Merge pull request #22298 from colemanw/fixApi3ValidateString
APIv3 - Fix overzealous pseudoconstant matching
Eileen McNaughton [Thu, 23 Dec 2021 22:53:52 +0000 (11:53 +1300)]
Merge pull request #22302 from colemanw/customMeta
SearchKit - Add links for CustomField and CustomGroup entities
Seamus Lee [Thu, 23 Dec 2021 22:31:29 +0000 (09:31 +1100)]
Merge pull request #22286 from seamuslee001/dev_core_3000
dev/core#3000 Fix database error when copying custom data fields from…
Seamus Lee [Tue, 21 Dec 2021 04:41:23 +0000 (15:41 +1100)]
dev/core#3000 Fix database error when copying custom data fields from a master address to related addresses
Add in hook param as per jon
Mathieu Lutfy [Thu, 23 Dec 2021 14:48:04 +0000 (09:48 -0500)]
Event Registration: initialize array
Bradley Taylor [Thu, 23 Dec 2021 12:47:56 +0000 (12:47 +0000)]
Allow text to be translated and fix URL paths in calls to docURL() function.
Bradley Taylor [Wed, 22 Dec 2021 15:29:21 +0000 (15:29 +0000)]
"Open in new tab" on .crm-summary-link icons should open contact page, not summary content.
Whilst the contact image tooltip is set to preventDefault, it is still possible to copy the URL or open in new tab.
This change ensures that the correct URL is set in these situations.
Backwards compatiability is retained for third parties using the crm-tooltip class without the new data attribute.
Eileen McNaughton [Thu, 23 Dec 2021 10:08:48 +0000 (23:08 +1300)]
Merge pull request #22308 from eileenmcnaughton/notice1
E-notice fix (smarty)
Eileen McNaughton [Thu, 23 Dec 2021 05:19:54 +0000 (18:19 +1300)]
E-notice fix (smarty)
Eileen McNaughton [Thu, 23 Dec 2021 04:31:50 +0000 (17:31 +1300)]
Add in some mixed currency contributions
This fixes some of the contributions & recurring contributions to be in currencies other than USD.
I also found that a lot of the contributions being created are either in 2010 or on the generation
date so I spread the dates out a bit - although that meant making it a bit easier to
keep the activities in sync.
It turns out the API does work in this context - and that would create the activities
more faithfully - but the issues around the processor being created by a different process are
a bit challenging
Seamus Lee [Thu, 23 Dec 2021 00:44:04 +0000 (11:44 +1100)]
Merge pull request #22306 from eileenmcnaughton/charset
Fix char-set for default escaping
Eileen McNaughton [Wed, 22 Dec 2021 23:25:58 +0000 (12:25 +1300)]
Fix char-set for default escaping
Eileen McNaughton [Wed, 22 Dec 2021 22:45:41 +0000 (11:45 +1300)]
Merge pull request #22300 from colemanw/searchKitExportTweak
SearchKit - Tweak export explorer link icon + format
Eileen McNaughton [Wed, 22 Dec 2021 22:44:54 +0000 (11:44 +1300)]
Merge pull request #22304 from braders/feature/smtp-settings-html-positions
Display label before input elements on SMTP settings page
Eileen McNaughton [Wed, 22 Dec 2021 22:34:23 +0000 (11:34 +1300)]
Enable more currencies by default
Seamus Lee [Wed, 22 Dec 2021 22:17:23 +0000 (09:17 +1100)]
Merge pull request #22294 from eileenmcnaughton/esc
Do not apply default escaping to multiselects on currency form
Bradley Taylor [Wed, 22 Dec 2021 21:04:48 +0000 (21:04 +0000)]
Display label before input elements on SMTP settings page
Coleman Watts [Wed, 22 Dec 2021 15:10:42 +0000 (10:10 -0500)]
Fix test error message, and remove bad tests
Coleman Watts [Wed, 22 Dec 2021 14:30:25 +0000 (09:30 -0500)]
SearchKit - Allow more link actions
Yashodha Chaku [Wed, 22 Dec 2021 14:11:13 +0000 (19:41 +0530)]
Merge pull request #22290 from eileenmcnaughton/cont
Fix broken links in default modifier mode on manage contributions
Seamus Lee [Wed, 22 Dec 2021 11:01:50 +0000 (22:01 +1100)]
Merge pull request #22297 from civicrm/5.45
Merge 5.45 to master
Seamus Lee [Wed, 22 Dec 2021 08:42:27 +0000 (19:42 +1100)]
Merge pull request #22295 from alifrumin/rn5.45
[NFC] First Pass at Release Notes for 5.45
Seamus Lee [Wed, 22 Dec 2021 08:41:53 +0000 (19:41 +1100)]
Merge pull request #22299 from colemanw/suitcaseIcon
SearchKit - better icon for packaged searches
Seamus Lee [Wed, 22 Dec 2021 08:41:22 +0000 (19:41 +1100)]
Merge pull request #22301 from eileenmcnaughton/recur_data
Follow up fix on recur data
Eileen McNaughton [Wed, 22 Dec 2021 06:10:44 +0000 (19:10 +1300)]
Follow up fix on recur data
Yashodha Chaku [Wed, 22 Dec 2021 05:45:52 +0000 (11:15 +0530)]
Merge pull request #22296 from eileenmcnaughton/recur_data
Add recurring conributions to sample data
Coleman Watts [Wed, 22 Dec 2021 05:42:16 +0000 (00:42 -0500)]
SearchKit - Tweak export explorer link icon + format
Updates the explorer params to use raw strings, as json-encoding
is not necessary.
Coleman Watts [Wed, 22 Dec 2021 05:32:01 +0000 (00:32 -0500)]
SearchKit - better icon for packaged searches
Coleman Watts [Wed, 22 Dec 2021 04:59:53 +0000 (23:59 -0500)]
APIv3 - Fix overzealous pseudoconstant matching
Strings do not need to be strictly matched to pseudoconstants
during get operations.
Fixes regression caused by #22282.
Eileen McNaughton [Wed, 22 Dec 2021 03:10:20 +0000 (16:10 +1300)]
Merge pull request #22293 from colemanw/fixEditableCustom
SearchKit - Fix editable custom fields
Eileen McNaughton [Wed, 22 Dec 2021 03:06:56 +0000 (16:06 +1300)]
Add recurring conributions to sample data
Alice Frumin [Thu, 9 Dec 2021 17:51:34 +0000 (12:51 -0500)]
[NFC] First pass release notes 5.45
colemanw [Wed, 22 Dec 2021 02:17:37 +0000 (21:17 -0500)]
Merge pull request #22288 from eileenmcnaughton/process
[REF] move code into the function
Eileen McNaughton [Wed, 22 Dec 2021 01:23:18 +0000 (14:23 +1300)]
Do not apply default escaping to multiselects on currency form
This is probably an html pattern we have missed in our early returns but
explictly marking the fields not to be escaped is probably better now the bulk is weeded out
colemanw [Wed, 22 Dec 2021 01:18:20 +0000 (20:18 -0500)]
Merge pull request #22281 from colemanw/fixSearchKitConcatWS
SearchKit - Fix "Combine Text" transformation
colemanw [Wed, 22 Dec 2021 01:16:37 +0000 (20:16 -0500)]
Merge pull request #22228 from colemanw/managedGroup
Apiv4 - Make Groups a managed entity, fix 'null' bugs in BAO_Group
Coleman Watts [Wed, 22 Dec 2021 01:09:28 +0000 (20:09 -0500)]
SearchKit - Fix editable custom fields
Coleman Watts [Wed, 22 Dec 2021 00:58:59 +0000 (19:58 -0500)]
Add path metadata to CustomField and CustomValue entities
Eileen McNaughton [Wed, 22 Dec 2021 00:09:23 +0000 (13:09 +1300)]
Merge pull request #22289 from eileenmcnaughton/urls
Enotice fixes on ContributionPage dash
Tim Otten [Fri, 10 Dec 2021 06:56:33 +0000 (22:56 -0800)]
authx - Add authx_login({principal: array, useSession: bool}) API for use by backend/service scripts
Tim Otten [Fri, 10 Dec 2021 05:51:22 +0000 (21:51 -0800)]
(REF) authx - Add option for authenticator to emit exceptions
Before: If the authenticator encounters an error, it sends a response document.
After: The authenticator encoutners an error, it may either:
- (Default) Send a response document
- (Option) Emit an exception
Tim Otten [Tue, 21 Dec 2021 10:32:11 +0000 (02:32 -0800)]
Drupal8::getUfId() - Fix exception on unknown usernames
As mentioned in https://github.com/civicrm/civicrm-core/pull/22239#issuecomment-
997108926, there can be an exception:
```
Error: Call to a member function id() on bool in ...\CRM\Utils\System\Drupal8.php on line 359 #0 ...\ext\authx\Civi\Authx\Authenticator.php(380)
```
The function signature specifies `@return int|null`. Various callers appear to expect this, and that seems to be how it behaves on D7/WP.
Eileen McNaughton [Tue, 21 Dec 2021 21:17:06 +0000 (10:17 +1300)]
Fix broken links in default modifier mode on manage contributions
Eileen McNaughton [Tue, 21 Dec 2021 21:09:13 +0000 (10:09 +1300)]
Enotice fixes on ContributionPage dash
Eileen McNaughton [Tue, 21 Dec 2021 20:37:06 +0000 (09:37 +1300)]
[REF] move code into the function
Within the if there is some code & then a function call. There doesn't seem
to be much reason for some of the code to be in the function & some
outside - this simplifies
Yashodha Chaku [Tue, 21 Dec 2021 08:51:50 +0000 (14:21 +0530)]
Merge pull request #22287 from eileenmcnaughton/process
[REF] Stop passing this as form, set in function
Eileen McNaughton [Tue, 21 Dec 2021 05:06:41 +0000 (18:06 +1300)]
[REF] Stop passing this as form, set in function
Seamus Lee [Tue, 21 Dec 2021 04:49:56 +0000 (15:49 +1100)]
Merge pull request #21611 from eileenmcnaughton/cancel
Add workflow template for recurring cancelled
colemanw [Tue, 21 Dec 2021 02:24:05 +0000 (21:24 -0500)]
Merge pull request #22229 from colemanw/searchKitExport
SearchKit - Import/Export saved search configuration
colemanw [Tue, 21 Dec 2021 02:21:37 +0000 (21:21 -0500)]
Merge pull request #22284 from eileenmcnaughton/process
[REF] Remove now non-variable variables from previously shared code
Eileen McNaughton [Mon, 20 Dec 2021 22:18:41 +0000 (11:18 +1300)]
dev/core#3001 escape single quotes when rendering tokens in html format
Eileen McNaughton [Mon, 20 Dec 2021 21:53:55 +0000 (10:53 +1300)]
Merge pull request #22283 from eileenmcnaughton/notice
Cleanup Smarty e-notices on campaign dashboard
Eileen McNaughton [Mon, 20 Dec 2021 21:52:03 +0000 (10:52 +1300)]
[REF] Remove now non-variable variables from previously shared code
Coleman Watts [Wed, 8 Dec 2021 17:04:36 +0000 (12:04 -0500)]
SearchKit - Add Import dialog
Coleman Watts [Wed, 8 Dec 2021 16:07:28 +0000 (11:07 -0500)]
Move crmDialog angular utility from message_admin extension to core for reusability
Coleman Watts [Wed, 8 Dec 2021 13:03:21 +0000 (08:03 -0500)]
SearchKit - Rename searchList template to match controller, move "New Search" button to top