civicrm-core.git
12 months agoMerge pull request #28571 from eileenmcnaughton/unused
demeritcowboy [Fri, 8 Dec 2023 01:59:31 +0000 (20:59 -0500)]
Merge pull request #28571 from eileenmcnaughton/unused

Remove unused variable

12 months agoMerge pull request #28572 from eileenmcnaughton/unused_2
demeritcowboy [Fri, 8 Dec 2023 01:45:53 +0000 (20:45 -0500)]
Merge pull request #28572 from eileenmcnaughton/unused_2

remove unused variable

12 months agoMerge pull request #28576 from eileenmcnaughton/noticey
demeritcowboy [Fri, 8 Dec 2023 01:41:45 +0000 (20:41 -0500)]
Merge pull request #28576 from eileenmcnaughton/noticey

Do not suppress appropriate notices

12 months agoDo not suppress appropriate notices
Eileen McNaughton [Fri, 8 Dec 2023 00:12:42 +0000 (13:12 +1300)]
Do not suppress appropriate notices

If getVar is used to get a non-existent property then emitting
a notice is the right behaviour

12 months agoMerge pull request #28474 from twomice/4833_x_invoice_num_alphanumeric
Seamus Lee [Thu, 7 Dec 2023 23:50:58 +0000 (10:50 +1100)]
Merge pull request #28474 from twomice/4833_x_invoice_num_alphanumeric

POC: toward dev/core#4833: this does fix the problem.

12 months agoMerge pull request #28521 from eileenmcnaughton/smarty_warn
Eileen McNaughton [Thu, 7 Dec 2023 23:42:17 +0000 (12:42 +1300)]
Merge pull request #28521 from eileenmcnaughton/smarty_warn

Add system check encouraging Smarty3

12 months agoremove unused variable
Eileen McNaughton [Thu, 7 Dec 2023 19:45:15 +0000 (08:45 +1300)]
remove unused variable

12 months agoRemove unused variable
Eileen McNaughton [Thu, 7 Dec 2023 19:42:56 +0000 (08:42 +1300)]
Remove unused variable

12 months agoMerge pull request #28484 from 19ATF72/mailing-searchkit-afform
Eileen McNaughton [Thu, 7 Dec 2023 19:09:10 +0000 (08:09 +1300)]
Merge pull request #28484 from 19ATF72/mailing-searchkit-afform

Add searchkit and afform display

12 months agoTweak Smarty messaging
Tim Otten [Thu, 7 Dec 2023 17:25:29 +0000 (17:25 +0000)]
Tweak Smarty messaging

12 months agoMerge pull request #28563 from artfulrobot/artfulrobot-fix-docblock
Rich Lott [Thu, 7 Dec 2023 18:39:40 +0000 (18:39 +0000)]
Merge pull request #28563 from artfulrobot/artfulrobot-fix-docblock

Fix docblock for loadUser()

12 months agoFix docblock for loadUser - parameter is a string
Rich Lott / Artful Robot [Thu, 7 Dec 2023 16:34:05 +0000 (16:34 +0000)]
Fix docblock for loadUser - parameter is a string

The dockblock says the user is an object, but it seems all implementations
provide a string, some adding explicit declarations as a string.

12 months agoFix for dev/core#4833: Old-style Authorize.net ARB webhooks failing on x_invoice_num...
Allen Shaw [Mon, 4 Dec 2023 18:38:23 +0000 (12:38 -0600)]
Fix for dev/core#4833: Old-style Authorize.net ARB webhooks failing on x_invoice_num mismatch.

12 months agoMerge pull request #28561 from kcristiano/wputfix
Matthew Wire [Thu, 7 Dec 2023 15:43:37 +0000 (15:43 +0000)]
Merge pull request #28561 from kcristiano/wputfix

add Query to AssetBuilder test to fix WP E2E test failures

12 months agoMerge pull request #28562 from vinay-osseed/typo-fixes
Matthew Wire [Thu, 7 Dec 2023 15:42:26 +0000 (15:42 +0000)]
Merge pull request #28562 from vinay-osseed/typo-fixes

[NFC] Fix typo in `Localization.tpl` file.

12 months agoMerge pull request #28538 from mattwire/ufmatch
colemanw [Thu, 7 Dec 2023 15:36:29 +0000 (10:36 -0500)]
Merge pull request #28538 from mattwire/ufmatch

Add unique constraint on ufmatch user ID+domain ID

12 months agoAdd unique constraint on ufmatch user ID
Matthew Wire [Wed, 6 Dec 2023 12:14:22 +0000 (12:14 +0000)]
Add unique constraint on ufmatch user ID

12 months agotypo fix in `Localization.tpl` file.
vinay-osseed [Thu, 7 Dec 2023 14:06:24 +0000 (19:36 +0530)]
typo fix in `Localization.tpl` file.

12 months agoMerge pull request #28532 from wmortada/standalone-user-delete
Rich Lott [Thu, 7 Dec 2023 11:40:42 +0000 (11:40 +0000)]
Merge pull request #28532 from wmortada/standalone-user-delete

Standalone - prevent users from deleting own user

12 months agoStandalone - prevent users from deleting own user
William Mortada [Wed, 6 Dec 2023 00:12:51 +0000 (00:12 +0000)]
Standalone - prevent users from deleting own user

12 months agoadd Query to AssetBuilder test to fix WP failures
Kevin Cristiano [Thu, 7 Dec 2023 11:36:55 +0000 (11:36 +0000)]
add Query to AssetBuilder test to fix WP failures

Signed-off-by: Kevin Cristiano <kcristiano@kcristiano.com>
12 months agoMerge pull request #28471 from artfulrobot/artfulrobot-cleanup-standalone-tpls
Rich Lott [Thu, 7 Dec 2023 09:27:04 +0000 (09:27 +0000)]
Merge pull request #28471 from artfulrobot/artfulrobot-cleanup-standalone-tpls

Standalone: clean up styling on login/reset password

12 months agostandalone: clean up styling on login/reset password
Rich Lott / Artful Robot [Mon, 4 Dec 2023 15:12:00 +0000 (15:12 +0000)]
standalone: clean up styling on login/reset password

12 months agoMerge pull request #28552 from eileenmcnaughton/uf_group_dao
Matthew Wire [Thu, 7 Dec 2023 08:07:53 +0000 (08:07 +0000)]
Merge pull request #28552 from eileenmcnaughton/uf_group_dao

Fix UFGroup add to call writeRecord

12 months agoMerge pull request #28554 from eileenmcnaughton/map_field
demeritcowboy [Thu, 7 Dec 2023 05:59:28 +0000 (00:59 -0500)]
Merge pull request #28554 from eileenmcnaughton/map_field

Fix test to not do weird form-trait sharing thing

12 months agoFix test to not do weird form-trait sharing thing
Eileen McNaughton [Thu, 7 Dec 2023 03:10:14 +0000 (16:10 +1300)]
Fix test to not do weird form-trait sharing thing

12 months agoMerge pull request #28551 from totten/master-regen
Tim Otten [Thu, 7 Dec 2023 00:22:16 +0000 (00:22 +0000)]
Merge pull request #28551 from totten/master-regen

Regen

12 months agoMerge pull request #28543 from vingle/patch-15
Eileen McNaughton [Wed, 6 Dec 2023 23:36:31 +0000 (12:36 +1300)]
Merge pull request #28543 from vingle/patch-15

Fixes Advanced Search regression in #28418

12 months agoMerge pull request #28496 from eileenmcnaughton/master_import
Tim Otten [Wed, 6 Dec 2023 23:27:57 +0000 (23:27 +0000)]
Merge pull request #28496 from eileenmcnaughton/master_import

dev/core#4447 fix inability to import to master_id

12 months agoFix UFGroup add to call writeRecord
Eileen McNaughton [Wed, 6 Dec 2023 23:18:19 +0000 (12:18 +1300)]
Fix UFGroup add to call writeRecord

12 months agoRegen
Tim Otten [Wed, 6 Dec 2023 23:16:51 +0000 (23:16 +0000)]
Regen

12 months agoMerge pull request #28546 from aydun/searchui_labelformats
Matthew Wire [Wed, 6 Dec 2023 21:56:41 +0000 (21:56 +0000)]
Merge pull request #28546 from aydun/searchui_labelformats

SearchUI - Updates to Label Format display

12 months agoMerge pull request #28541 from vingle/accordion-css
Rich Lott [Wed, 6 Dec 2023 21:51:17 +0000 (21:51 +0000)]
Merge pull request #28541 from vingle/accordion-css

Accordions css – tidies up / bug fixes / simplifies theming / adds two utility classes

12 months agoMerge pull request #28495 from eileenmcnaughton/import
Matthew Wire [Wed, 6 Dec 2023 21:48:06 +0000 (21:48 +0000)]
Merge pull request #28495 from eileenmcnaughton/import

Add support for spreadsheet format in imports

12 months agoMerge pull request #28548 from civicrm/5.68
Seamus Lee [Wed, 6 Dec 2023 21:46:24 +0000 (08:46 +1100)]
Merge pull request #28548 from civicrm/5.68

5.68

12 months agoMerge pull request #27107 from kurund/afform-email-confirmation
Matthew Wire [Wed, 6 Dec 2023 21:43:59 +0000 (21:43 +0000)]
Merge pull request #27107 from kurund/afform-email-confirmation

dev/core#4232 Afform: Allow manual processing of submission

12 months agoremoves change to common.js
Nicol [Wed, 6 Dec 2023 21:30:34 +0000 (21:30 +0000)]
removes change to common.js

12 months agoMerge branch 'civicrm:master' into patch-15
Nicol [Wed, 6 Dec 2023 21:29:26 +0000 (21:29 +0000)]
Merge branch 'civicrm:master' into patch-15

12 months agoTest-notice-fix
Eileen McNaughton [Wed, 6 Dec 2023 03:27:49 +0000 (16:27 +1300)]
Test-notice-fix

12 months agoAdapt test to still have 2 same-address & 1 different address contacts
Eileen McNaughton [Wed, 6 Dec 2023 03:01:23 +0000 (16:01 +1300)]
Adapt test to still have 2 same-address & 1 different address contacts

The BAO change meant the 2 addresses that were meant to be different,
but were shared, became the same, so I had to tweak the test
data to create the 2 same & 1 different scenario

12 months agodev/core#4447 fix inability to import to master_id
Eileen McNaughton [Tue, 5 Dec 2023 06:25:39 +0000 (19:25 +1300)]
dev/core#4447 fix inability to import to master_id

12 months agoMerge pull request #28497 from eileenmcnaughton/pledge
Eileen McNaughton [Wed, 6 Dec 2023 21:12:09 +0000 (10:12 +1300)]
Merge pull request #28497 from eileenmcnaughton/pledge

Sample data fixes for contribution pages

12 months agoRestores 'active' display script function that was lost during <details> conversion
Nicol [Wed, 6 Dec 2023 21:03:33 +0000 (21:03 +0000)]
Restores 'active' display script function that was lost during <details> conversion

12 months agoTightens targeting of AccordionToggle JS
Nicol [Wed, 6 Dec 2023 21:01:58 +0000 (21:01 +0000)]
Tightens targeting of AccordionToggle JS

12 months agoTargets the crmAccordionToggle more tightly
Nicol [Wed, 6 Dec 2023 21:00:30 +0000 (21:00 +0000)]
Targets the crmAccordionToggle more tightly

So as to not hide the <details> content.

12 months agoMerge branch 'civicrm:master' into patch-15
Nicol [Wed, 6 Dec 2023 20:59:31 +0000 (20:59 +0000)]
Merge branch 'civicrm:master' into patch-15

12 months agoMerge pull request #28547 from alifrumin/5.68rnlate
Seamus Lee [Wed, 6 Dec 2023 20:53:17 +0000 (07:53 +1100)]
Merge pull request #28547 from alifrumin/5.68rnlate

[NFC] 5.68 release note late changes

12 months agoMerge pull request #28504 from yashodha/report-fixess
Eileen McNaughton [Wed, 6 Dec 2023 20:26:14 +0000 (09:26 +1300)]
Merge pull request #28504 from yashodha/report-fixess

Add filter on archived in Mailing Summary report

12 months agoMerge pull request #28545 from aydun/labelformat_metadata
Eileen McNaughton [Wed, 6 Dec 2023 20:25:13 +0000 (09:25 +1300)]
Merge pull request #28545 from aydun/labelformat_metadata

Munge paths for labelFormats

12 months agoOpens first three regions
Nicol [Wed, 6 Dec 2023 20:18:57 +0000 (20:18 +0000)]
Opens first three regions

Matches behavior of old Advanced Search.

12 months agoKeeps main Advanced Searchd details always open
Nicol [Wed, 6 Dec 2023 20:10:30 +0000 (20:10 +0000)]
Keeps main Advanced Searchd details always open

12 months agoMerge branch 'civicrm:master' into patch-15
Nicol [Wed, 6 Dec 2023 20:09:14 +0000 (20:09 +0000)]
Merge branch 'civicrm:master' into patch-15

12 months agoMerge pull request #28544 from aydun/premiums_metadata
Eileen McNaughton [Wed, 6 Dec 2023 20:03:09 +0000 (09:03 +1300)]
Merge pull request #28544 from aydun/premiums_metadata

Premiums metadata

12 months agoMerge pull request #28534 from pradpnayak/mappingseaechkit
Eileen McNaughton [Wed, 6 Dec 2023 20:02:39 +0000 (09:02 +1300)]
Merge pull request #28534 from pradpnayak/mappingseaechkit

Use the action definded in DAO for Mapping

12 months ago[NFC] 5.68 release note late changes
Alice Frumin [Wed, 6 Dec 2023 19:54:55 +0000 (14:54 -0500)]
[NFC] 5.68 release note late changes

12 months agoUpdates to Label Format display
Aidan Saunders [Wed, 6 Dec 2023 19:03:04 +0000 (19:03 +0000)]
Updates to Label Format display

12 months agoMunge paths for labelFormats
Aidan Saunders [Wed, 6 Dec 2023 18:21:03 +0000 (18:21 +0000)]
Munge paths for labelFormats

12 months agoRemoves accordion body border when there shouldn't be one
Nicol [Wed, 6 Dec 2023 18:17:27 +0000 (18:17 +0000)]
Removes accordion body border when there shouldn't be one

Civi has two styles of accordions: with a border around it and without. This commit removes a third style – a border around half which isn't intentional and is a byproduct of the new html.

12 months agoMerge pull request #28468 from jaapjansma/timezone
demeritcowboy [Wed, 6 Dec 2023 18:07:29 +0000 (13:07 -0500)]
Merge pull request #28468 from jaapjansma/timezone

dev/core#4410: fixed timezone support for standalone

12 months agoMerge pull request #28513 from wyde22/newuiLabelFormat-dewy
Aidan Saunders [Wed, 6 Dec 2023 18:06:15 +0000 (18:06 +0000)]
Merge pull request #28513 from wyde22/newuiLabelFormat-dewy

searchui : new screen label format

12 months agoMerge branch 'civicrm:master' into accordion-css
Nicol [Wed, 6 Dec 2023 18:05:09 +0000 (18:05 +0000)]
Merge branch 'civicrm:master' into accordion-css

12 months agoRegen
Aidan Saunders [Wed, 6 Dec 2023 17:25:20 +0000 (17:25 +0000)]
Regen

12 months agoPath mangling for managePremiums
Aidan Saunders [Wed, 6 Dec 2023 17:24:07 +0000 (17:24 +0000)]
Path mangling for managePremiums

12 months agoFixes UI regression in #28418
Nicol [Wed, 6 Dec 2023 17:36:52 +0000 (17:36 +0000)]
Fixes UI regression in #28418

Some advanced search accordion regions have a close button on the right – clicking this 'deactivites' the region from the search, and with the recent changes it also makes the expanded region hidden.

This removes the line of JS responsible for that.

12 months agocontact token test fixes
Kurund Jalmi [Wed, 6 Dec 2023 16:06:58 +0000 (16:06 +0000)]
contact token test fixes

12 months agoMerge pull request #28525 from totten/master-pw-rst
Tim Otten [Wed, 6 Dec 2023 15:44:14 +0000 (15:44 +0000)]
Merge pull request #28525 from totten/master-pw-rst

standaloneusers - Fix tokens+docblocks for "Password reset" email

12 months agomanagetest fixes
Kurund Jalmi [Wed, 6 Dec 2023 15:33:37 +0000 (15:33 +0000)]
managetest fixes

12 months agoJenkins error fixes
Nicol [Wed, 6 Dec 2023 15:22:45 +0000 (15:22 +0000)]
Jenkins error fixes

'superfluous spaces'

12 months agoaccordion css fixes
Nicol [Wed, 6 Dec 2023 14:31:02 +0000 (14:31 +0000)]
accordion css fixes

Removes double icon from safari, simple nested accordion handling.

12 months agoAdds utility class: .crm-accordion-light
Nicol [Wed, 6 Dec 2023 14:10:29 +0000 (14:10 +0000)]
Adds utility class: .crm-accordion-light

A style to match Civi's transparent background, non-bold accordion header.

Commit also adds hover states and comments.

12 months agoAdds hover state for accordion-bold
Nicol [Wed, 6 Dec 2023 14:02:06 +0000 (14:02 +0000)]
Adds hover state for accordion-bold

12 months agoAdds utility class: .crm-accordion-bold
Nicol [Wed, 6 Dec 2023 13:57:44 +0000 (13:57 +0000)]
Adds utility class: .crm-accordion-bold

This allows new details/summary elements to be styled the same as the colour-bg crm-accordion-wrapper style. It also fixes a minor issue with border-radius changing on expand/collapse.

12 months agoApplies theme expand/close icon to details/summary
Nicol [Wed, 6 Dec 2023 13:23:59 +0000 (13:23 +0000)]
Applies theme expand/close icon to details/summary

Details/summary has a browser-generated expand/close caret. This PR restores Greenwich's FontAwesome caret/triangle - and provides the class names themers would need to include to make their choice of expand/close icons & animations apply to details/summary.

12 months agoMerge pull request #28528 from wmortada/standalone-users
Matthew Wire [Wed, 6 Dec 2023 12:11:41 +0000 (12:11 +0000)]
Merge pull request #28528 from wmortada/standalone-users

Standalone - Improve administer user screen

12 months agoFix typo in smarty system check
colemanw [Wed, 6 Dec 2023 11:35:28 +0000 (11:35 +0000)]
Fix typo in smarty system check

12 months agostandaloneusers - Fix tokens+docblocks for password-reset email
Tim Otten [Tue, 5 Dec 2023 22:20:27 +0000 (22:20 +0000)]
standaloneusers - Fix tokens+docblocks for password-reset email

12 months agoMerge pull request #28535 from eileenmcnaughton/master_test
Tim Otten [Wed, 6 Dec 2023 11:01:55 +0000 (11:01 +0000)]
Merge pull request #28535 from eileenmcnaughton/master_test

Test-notice-fix affecting all tests

12 months agoTest-notice-fix
Eileen McNaughton [Wed, 6 Dec 2023 03:27:49 +0000 (16:27 +1300)]
Test-notice-fix

12 months agoMerge pull request #28531 from civicrm/5.68
Eileen McNaughton [Wed, 6 Dec 2023 01:38:31 +0000 (14:38 +1300)]
Merge pull request #28531 from civicrm/5.68

5.68

12 months agoSample data fixes for contribution pages
Eileen McNaughton [Tue, 5 Dec 2023 07:30:45 +0000 (20:30 +1300)]
Sample data fixes for contribution pages

12 months agoMerge pull request #28387 from eileenmcnaughton/membership_block_save
Matthew Wire [Wed, 6 Dec 2023 00:30:42 +0000 (00:30 +0000)]
Merge pull request #28387 from eileenmcnaughton/membership_block_save

dev/core#3994 Update membership block on membership type save & remove the same from the Manage form

12 months agoMerge pull request #28344 from eileenmcnaughton/move_set
Matthew Wire [Wed, 6 Dec 2023 00:29:13 +0000 (00:29 +0000)]
Merge pull request #28344 from eileenmcnaughton/move_set

Move form specific code out of shared function

12 months agoMerge pull request #28388 from asmac-org/formbuilder-textarea-support-rows-cols
Matthew Wire [Wed, 6 Dec 2023 00:28:43 +0000 (00:28 +0000)]
Merge pull request #28388 from asmac-org/formbuilder-textarea-support-rows-cols

Formbuilder: support rows and columns values for Note (textarea) custom field type

12 months agoMerge pull request #28386 from eileenmcnaughton/membership_types
Matthew Wire [Wed, 6 Dec 2023 00:28:06 +0000 (00:28 +0000)]
Merge pull request #28386 from eileenmcnaughton/membership_types

Use apv4 rather than V3 for cached membershipTypes retrieval

12 months agoMerge pull request #28487 from eileenmcnaughton/price_notice
Matthew Wire [Wed, 6 Dec 2023 00:27:08 +0000 (00:27 +0000)]
Merge pull request #28487 from eileenmcnaughton/price_notice

dev/core#3083 Add a warning about price fields where non_deductible amount potentially misconfigured

12 months agoMerge pull request #28493 from eileenmcnaughton/invoice
Matthew Wire [Wed, 6 Dec 2023 00:26:33 +0000 (00:26 +0000)]
Merge pull request #28493 from eileenmcnaughton/invoice

Consolidate invoice determination

12 months agoMerge pull request #28491 from eileenmcnaughton/dep
Matthew Wire [Wed, 6 Dec 2023 00:26:08 +0000 (00:26 +0000)]
Merge pull request #28491 from eileenmcnaughton/dep

Update CustomField default_value to NULL instead of '' for floats

12 months agoMerge pull request #28483 from pradpnayak/dateprefAfform
Matthew Wire [Wed, 6 Dec 2023 00:25:28 +0000 (00:25 +0000)]
Merge pull request #28483 from pradpnayak/dateprefAfform

Added DatePreference admin UI

12 months agoUse the action definded in DAO for Mapping
Pradeep Nayak [Wed, 6 Dec 2023 00:25:02 +0000 (00:25 +0000)]
Use the action definded in DAO for Mapping

12 months agoMerge pull request #28482 from pradpnayak/datePrefAPI
Matthew Wire [Wed, 6 Dec 2023 00:24:38 +0000 (00:24 +0000)]
Merge pull request #28482 from pradpnayak/datePrefAPI

Adding PreferencesDate API

12 months agoMerge pull request #28479 from eileenmcnaughton/add_payment_more
Matthew Wire [Wed, 6 Dec 2023 00:23:52 +0000 (00:23 +0000)]
Merge pull request #28479 from eileenmcnaughton/add_payment_more

Clean up parameters in add payment form

12 months agolets make crmAutocomplete non mandatory
Kurund Jalmi [Tue, 5 Dec 2023 12:27:54 +0000 (12:27 +0000)]
lets make crmAutocomplete non mandatory

12 months agotest fixes
Kurund Jalmi [Wed, 25 Oct 2023 22:06:49 +0000 (23:06 +0100)]
test fixes

12 months agomove token definition to token list event
Kurund Jalmi [Thu, 12 Oct 2023 13:19:39 +0000 (14:19 +0100)]
move token definition to token list event

12 months agostyle fixes
Kurund Jalmi [Thu, 12 Oct 2023 12:30:35 +0000 (13:30 +0100)]
style fixes

12 months agogenerate frontend url
Kurund Jalmi [Thu, 12 Oct 2023 12:19:10 +0000 (13:19 +0100)]
generate frontend url

12 months agogenerate encrypted link for email verification; process submission if verified
Noah Miller [Thu, 12 Oct 2023 04:35:51 +0000 (00:35 -0400)]
generate encrypted link for email verification; process submission if verified

12 months agostyle fixes
Kurund Jalmi [Mon, 2 Oct 2023 12:42:17 +0000 (13:42 +0100)]
style fixes

12 months agomove process task to afform
Kurund Jalmi [Tue, 26 Sep 2023 14:27:42 +0000 (15:27 +0100)]
move process task to afform

12 months agoupdate class visibility
Kurund Jalmi [Mon, 25 Sep 2023 18:53:25 +0000 (19:53 +0100)]
update class visibility