civicrm-core.git
4 years agodev/translation#36 Ensure that we are only passing integers to the ngettext function...
Seamus Lee [Thu, 20 Feb 2020 01:53:07 +0000 (12:53 +1100)]
dev/translation#36 Ensure that we are only passing integers to the ngettext function for plurals

4 years agoMerge pull request #16594 from alifrumin/rn-5.23
Seamus Lee [Wed, 19 Feb 2020 21:48:24 +0000 (08:48 +1100)]
Merge pull request #16594 from alifrumin/rn-5.23

First pass at release notes for 5.23

4 years agoFirst pass at release notes for 5.23
Alice Frumin [Wed, 19 Feb 2020 20:43:16 +0000 (15:43 -0500)]
First pass at release notes for 5.23

4 years agoMerge pull request #16588 from eileenmcnaughton/523partnotice
Seamus Lee [Tue, 18 Feb 2020 19:57:08 +0000 (06:57 +1100)]
Merge pull request #16588 from eileenmcnaughton/523partnotice

Fix enotice regression (unreleased)

4 years agoFix enotice regressionn
eileen [Tue, 18 Feb 2020 07:23:13 +0000 (20:23 +1300)]
Fix enotice regressionn

This was merged to 5.23 but I made a booboo in it
https://github.com/civicrm/civicrm-core/commit/a3aed42a453009733e8feb2c56fde5750b37cd14

I think the params are actually not used so it's just the notice it causes but this fixes

4 years agoMerge pull request #16587 from seamuslee001/5.23
Seamus Lee [Tue, 18 Feb 2020 06:52:24 +0000 (17:52 +1100)]
Merge pull request #16587 from seamuslee001/5.23

Add release-notes/5.22.1.md

4 years agoMerge pull request #16583 from totten/5.23-gencode-no-l10n
Eileen McNaughton [Tue, 18 Feb 2020 06:51:57 +0000 (19:51 +1300)]
Merge pull request #16583 from totten/5.23-gencode-no-l10n

xml/GenCode.php - Fix execution in default locale (without l10n data)

4 years agoAdd release-notes/5.22.1.md
Tim Otten [Tue, 18 Feb 2020 06:26:22 +0000 (22:26 -0800)]
Add release-notes/5.22.1.md

4 years agoxml/GenCode.php - Fix execution in default locale (without l10n data)
Tim Otten [Tue, 18 Feb 2020 03:40:14 +0000 (19:40 -0800)]
xml/GenCode.php - Fix execution in default locale (without l10n data)

Overview
--------

This fixes a recent regression in which `xml/GenCode.php` fails to execute in certain configurations.

Initial report: https://github.com/civicrm/civicrm-buildkit/issues/503

Before
------

* If the folder `l10n` exists in its traditional location, and if you run `./bin/setup.sh -g`, then it
  correctly executes.
* If the folder `l10n` does not exist in its traditional locacation, and if you run `./bin/setup.sh -g`,
  then it fails with an error like this:
  ```
  + php -d mysql.default_host=127.0.0.1:3306 -d mysql.default_user=dmasterciv_abcde -d mysql.default_password=abcd1234 GenCode.php schema/Schema.xml '' Drupal

  civicrm_domain.version := 5.23.alpha1

  Parsing schema description schema/Schema.xml
  Extracting database information
  Extracting table information
  PHP Fatal error:  Uncaught RuntimeException: Invalid configuration: the [cms.root] path must be an absolute URL in /home/me/.../Civi/Core/Paths.php:174
  Stack trace:
  #0 /home/me/.../Civi/Core/Paths.php(151): Civi\Core\Paths->toAbsoluteUrl('/', 'cms.root')
  #1 /home/me/.../Civi/Core/Paths.php(176): Civi\Core\Paths->getVariable('cms.root', 'url')
  #2 /home/me/.../Civi/Core/Paths.php(151): Civi\Core\Paths->toAbsoluteUrl('/', 'civicrm.root')
  #3 /home/me/.../Civi/Core/Paths.php(224): Civi\Core\Paths->getVariable('civicrm.root', 'path')
  #4 /home/me/.../Civi/Core/Paths.php(84): Civi\Core\Paths->getPath('l10n')
  #5 [internal function]: Civi\Core\Paths->Civi\Core\{closure}()
  #6 /home/jo in /home/me/.../Civi/Core/Paths.php on line 174
  ```

After
-----

You can run `./bin/setup.sh -g` with or without the `l10n` folder.

Comments
--------

There's an argument to be made that this shouldn't be necessary: when running
`GenCode`, it should only create PHP files, and none of the output should depend
on the CMS URL - because that's liable to change when you deploy the PHP code.
If someone did try to generate URL at such an early stage, it's arguably good to
generate an error.  In point of fact, `GenCode` is not actually using the CMS
URL.

The oddity stems from the contract of `CRM_Utils_System_*` (specifically,
`getCiviSourceStorage()` and `getDefaultFileStorage()`) which do double-duty
providing both path and URL.  To avoid duplicate work, `Civi\Core\Paths` uses
the same grain of information - it tracks the pairs of path+URL.

A more aggressive fix might be to split `getCiviSourceStorage()` and
`getDefaultFileStorage()` so that it's possible to get the path and URL
separately; then revise `Civi\Core\Paths` to take advantage of the finer-grained
contract.  However, splitting those things would be a more invasive patch,
and we're currently in RC.

4 years agoMerge pull request #16578 from seamuslee001/dev_core_1602
Seamus Lee [Tue, 18 Feb 2020 01:01:06 +0000 (12:01 +1100)]
Merge pull request #16578 from seamuslee001/dev_core_1602

dev/core#1602 Fix join date filtering in search builder by standardis…

4 years agodev/core#1602 Fix join date filtering in search builder by standardising date field...
Seamus Lee [Mon, 17 Feb 2020 23:00:46 +0000 (10:00 +1100)]
dev/core#1602 Fix join date filtering in search builder by standardising date field handling in Membership Query BAO

4 years agoMerge pull request #16558 from eileenmcnaughton/523dupe
Eileen McNaughton [Mon, 17 Feb 2020 22:53:15 +0000 (11:53 +1300)]
Merge pull request #16558 from eileenmcnaughton/523dupe

dev/core#1597 & dev/core#1595 fix regression when deduping on custom fields

4 years agodev/core#1597 & dev/core#1595 fix regression when deduping on custom fields
eileen [Sun, 16 Feb 2020 21:26:03 +0000 (10:26 +1300)]
dev/core#1597 & dev/core#1595 fix regression when deduping on custom fields

4 years agoMerge pull request #16567 from eileenmcnaughton/parti_form
Seamus Lee [Mon, 17 Feb 2020 20:50:10 +0000 (07:50 +1100)]
Merge pull request #16567 from eileenmcnaughton/parti_form

Fix theoretical regression

4 years agoMerge pull request #16568 from JGaunt/patch-4
Yashodha Chaku [Mon, 17 Feb 2020 13:25:25 +0000 (18:55 +0530)]
Merge pull request #16568 from JGaunt/patch-4

Update 5.23.0.md

4 years agoUpdate 5.23.0.md
Jade Gaunt [Mon, 17 Feb 2020 11:52:39 +0000 (11:52 +0000)]
Update 5.23.0.md

Added organisation name :)

4 years agoFix theoretical regression
eileen [Mon, 17 Feb 2020 08:04:00 +0000 (21:04 +1300)]
Fix theoretical regression

This PR https://github.com/civicrm/civicrm-core/pull/16363/commits/44237a295dc5eab4f6110fb0556b1af742364f6e
(merged to 5.23) calls self::::getDefaultRoleID() in a way that was always flawed but definitely woudl
not work now. I think it is never reached but better to put this fix into 5.23 & maybe reemove the line in master
later since it assumes participant_status_id is optional - which is not true of the backoffice form

4 years agoMerge pull request #16547 from seamuslee001/5.23
Seamus Lee [Sat, 15 Feb 2020 00:07:37 +0000 (11:07 +1100)]
Merge pull request #16547 from seamuslee001/5.23

[NFC] Ensure that annon permissions are correctly assigned when enabl…

4 years agoMerge pull request #16549 from seamuslee001/style_fix_property_bag
Seamus Lee [Sat, 15 Feb 2020 00:07:28 +0000 (11:07 +1100)]
Merge pull request #16549 from seamuslee001/style_fix_property_bag

[NFC] Fix style error

4 years ago[NFC] Fix style error
Seamus Lee [Fri, 14 Feb 2020 23:58:14 +0000 (10:58 +1100)]
[NFC] Fix style error

4 years agoMerge pull request #16532 from eileenmcnaughton/5.23
Seamus Lee [Fri, 14 Feb 2020 23:55:02 +0000 (10:55 +1100)]
Merge pull request #16532 from eileenmcnaughton/5.23

dev/core#1588 Fix regression where empty string is passed to PropertyBag

4 years ago[NFC] Ensure that annon permissions are correctly assigned when enabling civicrm...
Seamus Lee [Fri, 14 Feb 2020 23:05:34 +0000 (10:05 +1100)]
[NFC] Ensure that annon permissions are correctly assigned when enabling civicrm webtest module in backdrop

4 years agoMerge pull request #16542 from JGaunt/patch-3
Matthew Wire [Fri, 14 Feb 2020 19:18:02 +0000 (19:18 +0000)]
Merge pull request #16542 from JGaunt/patch-3

Update CONTRIBUTORS.txt

4 years agoUpdate CONTRIBUTORS.txt
Jade Gaunt [Fri, 14 Feb 2020 15:19:32 +0000 (15:19 +0000)]
Update CONTRIBUTORS.txt

Added in mine and my colleagues name.

4 years agoMerge pull request #16535 from eileenmcnaughton/523rel
Seamus Lee [Fri, 14 Feb 2020 05:51:17 +0000 (16:51 +1100)]
Merge pull request #16535 from eileenmcnaughton/523rel

dev/core#1592 fix regression on relation active period

4 years agoMerge pull request #16534 from eileenmcnaughton/523m
Seamus Lee [Fri, 14 Feb 2020 05:26:48 +0000 (16:26 +1100)]
Merge pull request #16534 from eileenmcnaughton/523m

dev/core#1551 regression fix

4 years agodev/core#1592 fix regression on relation active period
eileen [Fri, 14 Feb 2020 04:42:17 +0000 (17:42 +1300)]
dev/core#1592 fix regression on relation active period

Per https://lab.civicrm.org/dev/core/issues/1592 the custom query  for this field is being
ignored now it's using datepicker with relevant format changes. This  causes the
custom function for the field to  be called

4 years agodev/core#1551 regression fix
eileen [Fri, 14 Feb 2020 03:55:08 +0000 (16:55 +1300)]
dev/core#1551 regression fix

Now that mailing_id is defined as field metadata the form main metadata fn is trying to handle it, However
the form is casting it to the wrong array format -https://github.com/civicrm/civicrm-core/blob/86f20cc17dde028977130f84feaf3b1d760ca57d/CRM/Contact/Form/Search.php#L649

We could fix  this & rip it out of Mailing_BAO_Query::where but there is still a gap  in  that
there is no pseudoconstant recorded for the field so the qill doesn't work & there is a gap in
pre-parsing for the form 'IN'

Hence this seems like a good approach to remove the regression in the immediate term

4 years agodev/core#1588 Fix regression where empty string is passed to SettingsBag
eileen [Fri, 14 Feb 2020 01:50:18 +0000 (14:50 +1300)]
dev/core#1588 Fix regression where empty string is passed to SettingsBag

We have a scenario where the checkbox is presented but is optional. This is then in 'params' which is passed through to
PropertyBag. The value is equal to '' so it fails to validate when we use it to set the value on the PropertyBag.

I don't think we lose anything meaningful by not setting an empty string and it avoids this error so we should
merge & release as a regression fix IMHO. If we want to revist then we should do that in master

https://lab.civicrm.org/dev/core/issues/1588

4 years agoMerge pull request #16521 from seamuslee001/dev_core_1489_2
Eileen McNaughton [Thu, 13 Feb 2020 21:49:32 +0000 (10:49 +1300)]
Merge pull request #16521 from seamuslee001/dev_core_1489_2

dev/core#1489 Include hook_civicrm_managed into the list of upgrade f…

4 years agodev/core#1489 Include hook_civicrm_managed into the list of upgrade freindly hooks
Seamus Lee [Thu, 13 Feb 2020 01:42:47 +0000 (12:42 +1100)]
dev/core#1489 Include hook_civicrm_managed into the list of upgrade freindly hooks

4 years agoMerge pull request #16520 from agh1/5.23.0-release-notes
Seamus Lee [Wed, 12 Feb 2020 21:40:14 +0000 (08:40 +1100)]
Merge pull request #16520 from agh1/5.23.0-release-notes

5.23.0 release notes

4 years agoMerge pull request #16518 from greenpeace-cee/fix-xoauth-imap
Seamus Lee [Wed, 12 Feb 2020 21:34:05 +0000 (08:34 +1100)]
Merge pull request #16518 from greenpeace-cee/fix-xoauth-imap

dev/mail#59 - Fix use of useXOAUTH2 constant instead of var

4 years agodev/mail#59 - Fix use of useXOAUTH2 constant instead of var
Patrick Figel [Wed, 12 Feb 2020 20:27:02 +0000 (21:27 +0100)]
dev/mail#59 - Fix use of useXOAUTH2 constant instead of var

This fixes an issue where a missing $ before the useXOAUTH2 variable
prevents IMAP authentication with XOAUTH2 from working.

4 years ago5.23.0 release notes: added boilerplate
Andrew Hunt [Wed, 12 Feb 2020 19:18:49 +0000 (14:18 -0500)]
5.23.0 release notes: added boilerplate

4 years ago5.23.0 release notes: raw from script
Andrew Hunt [Wed, 12 Feb 2020 15:58:17 +0000 (10:58 -0500)]
5.23.0 release notes: raw from script

4 years agoMerge pull request #16483 from seamuslee001/utf8mb4_min
Seamus Lee [Fri, 7 Feb 2020 01:06:49 +0000 (12:06 +1100)]
Merge pull request #16483 from seamuslee001/utf8mb4_min

[NFC] Skip utf8mb4 test on MySQL versions lower than 5.7

4 years agoSet version to 5.23.beta1
CiviCRM [Thu, 6 Feb 2020 07:07:34 +0000 (07:07 +0000)]
Set version to 5.23.beta1

4 years ago[NFC] Skip utf8mb4 test on MySQL versions lower than 5.7
Seamus Lee [Thu, 6 Feb 2020 04:21:59 +0000 (15:21 +1100)]
[NFC] Skip utf8mb4 test on MySQL versions lower than 5.7

4 years agoMerge pull request #16485 from seamuslee001/master
Seamus Lee [Thu, 6 Feb 2020 06:46:15 +0000 (17:46 +1100)]
Merge pull request #16485 from seamuslee001/master

release-notes: Late changes for 5.22 release notes

4 years agorelease-notes: Late changes for 5.22 release notes
Alice Frumin [Wed, 5 Feb 2020 15:36:22 +0000 (10:36 -0500)]
release-notes: Late changes for 5.22 release notes

4 years agoMerge pull request #16457 from colemanw/api4doc
Seamus Lee [Wed, 5 Feb 2020 19:07:28 +0000 (06:07 +1100)]
Merge pull request #16457 from colemanw/api4doc

APIv4 documentation & code cleanup

4 years agoMerge pull request #16472 from eileenmcnaughton/cn_for_now
Seamus Lee [Wed, 5 Feb 2020 07:05:11 +0000 (18:05 +1100)]
Merge pull request #16472 from eileenmcnaughton/cn_for_now

Revert "Remove unreachable code lines."

4 years agoMerge pull request #16466 from mattwire/recurringentity_copy
Seamus Lee [Wed, 5 Feb 2020 06:57:54 +0000 (17:57 +1100)]
Merge pull request #16466 from mattwire/recurringentity_copy

Call hook_civicrm_copy for RecurringEntity

4 years agoMerge pull request #16471 from totten/master-psr-log
Seamus Lee [Wed, 5 Feb 2020 06:44:55 +0000 (17:44 +1100)]
Merge pull request #16471 from totten/master-psr-log

composer.json - Relax psr/log constraint. Improve D8 compatibility.

4 years agoRevert "Remove unreachable code lines."
eileen [Wed, 5 Feb 2020 05:12:54 +0000 (18:12 +1300)]
Revert "Remove unreachable code lines."

In the course of https://github.com/civicrm/civicrm-core/pull/16462
I concluded that there might be (untested scenarios) where this would still be hit.

In #16462 I adopted a cleaner (tested) approach. However, I think it's unlikely that
will be merged before 5.23 is cut so I propose reverting this change & re-reverting it
once the rc is cut as a more conservative approach. We can focus on getting #16462
wrapped up for 5.24

This reverts commit d7943ca7f7107c1466e687e876bddaf0f1998d99.

4 years agoMerge pull request #16460 from colemanw/noInclude
Eileen McNaughton [Wed, 5 Feb 2020 04:44:29 +0000 (17:44 +1300)]
Merge pull request #16460 from colemanw/noInclude

APIv3 - Only scan files for deprecation checks in Entity.get

4 years agocomposer.json - Relax psr/log constraint. Improve D8 compatibility.
Tim Otten [Wed, 5 Feb 2020 03:53:58 +0000 (19:53 -0800)]
composer.json - Relax psr/log constraint. Improve D8 compatibility.

Overview
--------

This addresses a composer conflict that's reported when trying to install
on Drupal 8.7. For example, run these commands:

```
drush8 dl drupal-8.7.x
cd drupal-8*
composer require civicrm/civicrm-core:5.22.x-dev
```

This is a port of #16470 for `master`.

Before
------

The install fails because `civicrm-core` requires `psr/log:~1.1`, and something else
is prodding us to use `psr/log:1.0.2`.

```
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Installation request for civicrm/civicrm-core 5.22.x-dev -> satisfiable by civicrm/civicrm-core[5.22.x-dev].
    - Conclusion: remove psr/log 1.0.2
    - Conclusion: don't install psr/log 1.0.2
    - civicrm/civicrm-core 5.22.x-dev requires psr/log ~1.1 -> satisfiable by psr/log[1.1.0, 1.1.1, 1.1.2, 1.1.x-dev].
    - Can only install one of: psr/log[1.1.0, 1.0.2].
    - Can only install one of: psr/log[1.1.1, 1.0.2].
    - Can only install one of: psr/log[1.1.2, 1.0.2].
    - Can only install one of: psr/log[1.1.x-dev, 1.0.2].
    - Installation request for psr/log (locked at 1.0.2) -> satisfiable by psr/log[1.0.2].

Installation failed, reverting ./composer.json to its original content.
```

After
-----

It should work.  However, this is hard to demonstrate via `r-run` without merging.

Comments
--------

The substantive differences between `psr/log` in v1.0 and v1.1 relate to `LoggerInterfaceTest` and `TestLogger`:

https://github.com/php-fig/log/compare/1.0.2...1.1.2

However, `civicrm-core` does not use `LoggerInterfaceTest` or `TestLogger`, so it shouldn't matter.

For the standard tarballs which use `composer.lock`, this does have the side-effect of bumping up from 1.1.0 to 1.1.2.

4 years agoMerge pull request #16458 from twomice/1573_extra_columns_contribution_detail_report
Eileen McNaughton [Wed, 5 Feb 2020 03:01:22 +0000 (16:01 +1300)]
Merge pull request #16458 from twomice/1573_extra_columns_contribution_detail_report

Fix for #1573: Extra columns for Contribution Detail report.

4 years agoAPIv4 Organize debug sql into a single array
Coleman Watts [Tue, 4 Feb 2020 14:12:17 +0000 (09:12 -0500)]
APIv4 Organize debug sql into a single array

4 years agoMerge pull request #16469 from civicrm/5.22
Eileen McNaughton [Tue, 4 Feb 2020 22:43:47 +0000 (11:43 +1300)]
Merge pull request #16469 from civicrm/5.22

5.22 to master

4 years agoMerge pull request #16464 from WeMoveEU/core-1564-against-5.22
Eileen McNaughton [Tue, 4 Feb 2020 22:43:13 +0000 (11:43 +1300)]
Merge pull request #16464 from WeMoveEU/core-1564-against-5.22

dev/core#1564 Fix category name for a/b test temporary table

4 years agoMerge pull request #16463 from eileenmcnaughton/obscure
Seamus Lee [Tue, 4 Feb 2020 22:08:59 +0000 (09:08 +1100)]
Merge pull request #16463 from eileenmcnaughton/obscure

Fix obscure bug

4 years agoCall hook_civicrm_copy when we copy entities using RecurringEntity
Matthew Wire [Tue, 4 Feb 2020 11:43:20 +0000 (11:43 +0000)]
Call hook_civicrm_copy when we copy entities using RecurringEntity

4 years agodev/core#1564 Fix category name for a/b test temporary table
scardinius [Thu, 30 Jan 2020 09:10:04 +0000 (10:10 +0100)]
dev/core#1564 Fix category name for a/b test temporary table

4 years agoFix obscure bug
eileen [Tue, 4 Feb 2020 07:26:58 +0000 (20:26 +1300)]
Fix obscure bug

After upgrading to MacOS Catalina & MAMP 5.6 (latest) with php version 7.4.1 or 7.3.9
my site was unable to load CiviCRM with a segfault error. I traced it to this line & found that
phpstorm was highlighting the line it red as possibly subject to https://bugs.php.net/bug.php?id=62577

- taking phpstorm's recommendation allowed the site to load - the failure had been on parsing info.xml files

4 years agoMerge pull request #16461 from eileenmcnaughton/api_test
Seamus Lee [Tue, 4 Feb 2020 05:24:53 +0000 (16:24 +1100)]
Merge pull request #16461 from eileenmcnaughton/api_test

Add require_once to api3TestTrait

4 years agoAdd require_once to api3TestTrait
eileen [Tue, 4 Feb 2020 02:11:11 +0000 (15:11 +1300)]
Add require_once to api3TestTrait

I used this trait from an extension but it was used with apiv4 before apiv3 (it supports both).

I got an error because utils.php is not included by this file. It 'freeloads' off the fact apiv3 initialises
the file - but in fact the file that includes a function requiring a function
should have the require once - reduces risk & cognitive load

4 years agoAPIv3 - Only scan files for deprecation checks in Entiy.get
Coleman Watts [Tue, 4 Feb 2020 02:00:48 +0000 (21:00 -0500)]
APIv3 - Only scan files for deprecation checks in Entiy.get

4 years agoAPIv4 - Pluralize entity name in docblocks
Coleman Watts [Mon, 3 Feb 2020 23:05:38 +0000 (18:05 -0500)]
APIv4 - Pluralize entity name in docblocks

4 years agoFix for #1573: Extra columns for Contribution Detail report.
Allen Shaw [Mon, 3 Feb 2020 19:18:45 +0000 (13:18 -0600)]
Fix for #1573: Extra columns for Contribution Detail report.

4 years agoMerge pull request #16441 from eileenmcnaughton/event_pre
Seamus Lee [Mon, 3 Feb 2020 20:58:30 +0000 (07:58 +1100)]
Merge pull request #16441 from eileenmcnaughton/event_pre

[REF] Interim code cleanup - make the usage of addPayments clearer

4 years agoApi4 Replace - simplify by removing unnecessary fallback
Coleman Watts [Mon, 3 Feb 2020 18:22:01 +0000 (13:22 -0500)]
Api4 Replace - simplify by removing unnecessary fallback

4 years agoClearer docblock description of the defaults param
Coleman Watts [Mon, 3 Feb 2020 18:17:58 +0000 (13:17 -0500)]
Clearer docblock description of the defaults param

4 years agoAPIv4 Explorer - use OOP format for chained api calls
Coleman Watts [Mon, 3 Feb 2020 18:05:39 +0000 (13:05 -0500)]
APIv4 Explorer - use OOP format for chained api calls

Passing an array into setChain works, but the more "pure" way is to pass an object into addChain.

4 years agoMerge pull request #16446 from mattwire/wp_passlanguage
Mathieu Lu [Mon, 3 Feb 2020 18:04:07 +0000 (13:04 -0500)]
Merge pull request #16446 from mattwire/wp_passlanguage

Pass language code to CiviCRM for Wordpress

4 years agoMerge pull request #16397 from eileenmcnaughton/cont_setting3
colemanw [Mon, 3 Feb 2020 01:52:25 +0000 (20:52 -0500)]
Merge pull request #16397 from eileenmcnaughton/cont_setting3

dev/core#1558 retrieve setting credit_notes_prefix as  a 'real' setting.

4 years agoMerge pull request #16449 from colemanw/docVars
Eileen McNaughton [Sun, 2 Feb 2020 20:18:06 +0000 (09:18 +1300)]
Merge pull request #16449 from colemanw/docVars

APIv4 - Variable substution in docblocks

4 years agoMerge pull request #16454 from colemanw/explorerDefaults
Eileen McNaughton [Sun, 2 Feb 2020 20:17:00 +0000 (09:17 +1300)]
Merge pull request #16454 from colemanw/explorerDefaults

APIv4 Explorer - Better UI for defaults param

4 years agoAPIv4 Explorer - Better UI for defaults param
Coleman Watts [Sun, 2 Feb 2020 14:54:00 +0000 (09:54 -0500)]
APIv4 Explorer - Better UI for defaults param

4 years agoMerge pull request #16452 from mattwire/tokenrow_docblock
Seamus Lee [Sun, 2 Feb 2020 02:38:20 +0000 (13:38 +1100)]
Merge pull request #16452 from mattwire/tokenrow_docblock

NFC Fix TokenRow docblock

4 years agoFix TokenRow docblock
Matthew Wire [Sun, 2 Feb 2020 00:28:37 +0000 (00:28 +0000)]
Fix TokenRow docblock

4 years agoAPIv4 - Variable substution in docblocks
Coleman Watts [Fri, 31 Jan 2020 22:06:41 +0000 (17:06 -0500)]
APIv4 - Variable substution in docblocks

Replaces $ENTITY and $ACTION in docblocks to improve help text in the api explorer.

4 years agoMerge pull request #16450 from eileenmcnaughton/ev_test
Seamus Lee [Sat, 1 Feb 2020 03:20:42 +0000 (14:20 +1100)]
Merge pull request #16450 from eileenmcnaughton/ev_test

[NFC] Minor test cleanup.

4 years agoMinor test cleanup.
eileen [Sat, 1 Feb 2020 00:08:48 +0000 (13:08 +1300)]
Minor test cleanup.

4 years agoMerge pull request #16438 from eileenmcnaughton/ev_clean
colemanw [Fri, 31 Jan 2020 22:32:45 +0000 (17:32 -0500)]
Merge pull request #16438 from eileenmcnaughton/ev_clean

[REF] Pass params into function rather than this weird check for whether params exists.

4 years agoMerge pull request #16447 from samuelsov/lab#1319
Seamus Lee [Fri, 31 Jan 2020 21:09:11 +0000 (08:09 +1100)]
Merge pull request #16447 from samuelsov/lab#1319

dev/core#1319 Fix regression with shared household address

4 years agodev/core#1319 UI - different label for household and employer
Samuel Vanhove [Fri, 31 Jan 2020 16:33:29 +0000 (11:33 -0500)]
dev/core#1319 UI - different label for household and employer

4 years agoPass language code to CiviCRM
Matthew Wire [Fri, 31 Jan 2020 16:17:54 +0000 (16:17 +0000)]
Pass language code to CiviCRM

4 years agoMerge pull request #16267 from jitendrapurohit/dev-1471
Yashodha Chaku [Fri, 31 Jan 2020 13:52:21 +0000 (19:22 +0530)]
Merge pull request #16267 from jitendrapurohit/dev-1471

dev/core#1471 - Add system status alert for deleted custom fields in …

4 years ago[REF] Interim code cleanup - make the usage of addPayments clearer
eileen [Fri, 31 Jan 2020 07:55:16 +0000 (20:55 +1300)]
[REF] Interim code cleanup - make the usage of addPayments clearer

This brings the condition back to the calling function which clarifies what is going on with it

4 years agoMerge pull request #16437 from eileenmcnaughton/ev_back
Eileen McNaughton [Fri, 31 Jan 2020 08:30:36 +0000 (21:30 +1300)]
Merge pull request #16437 from eileenmcnaughton/ev_back

Add unit test to back office form when a payment is made against a partially paid contribution

4 years agoMerge pull request #16439 from eileenmcnaughton/part_odd
Seamus Lee [Fri, 31 Jan 2020 07:13:13 +0000 (18:13 +1100)]
Merge pull request #16439 from eileenmcnaughton/part_odd

Respect form value for register_date on partipant form

4 years agodev/core#1558 retrieve credit_notes_prefix as a 'real' setting.
eileen [Thu, 30 Jan 2020 21:57:40 +0000 (10:57 +1300)]
dev/core#1558 retrieve credit_notes_prefix as a 'real' setting.

    This is part of work to convert the non-standard contribution_invoice_settings array of settings into settings in line
    with our standards

4 years agoExtend checks in test
eileen [Fri, 31 Jan 2020 02:55:59 +0000 (15:55 +1300)]
Extend checks in test

4 years agoMerge pull request #16425 from colemanw/markdown
Seamus Lee [Fri, 31 Jan 2020 05:34:21 +0000 (16:34 +1100)]
Merge pull request #16425 from colemanw/markdown

Use markdown in php docblocks & display in APIv4 Explorer

4 years agoMerge pull request #16098 from MegaphoneJon/event-23-correct
Seamus Lee [Fri, 31 Jan 2020 05:33:32 +0000 (16:33 +1100)]
Merge pull request #16098 from MegaphoneJon/event-23-correct

event#23 - don't count non-counted participants on Confirm Registrati…

4 years agoRespect form value for register_date on partipant form
eileen [Fri, 31 Jan 2020 04:45:06 +0000 (17:45 +1300)]
Respect form value for register_date on partipant form

The backoffice event registration form has a register_date field. In credit card mode it
does an awful lot of handling which is mostly for legacy code reasons but the net result is to ignore it
& set it to now. However, the field defaults to now & if someone actually changed it they would expect their change to
be respected. This removes that handling & just uses the field value entered. The field is always present from my
digging

4 years agoArray formatting
eileen [Fri, 31 Jan 2020 03:59:54 +0000 (16:59 +1300)]
Array formatting

4 years ago[REF] Pass params into function rather than this weird check for whether params exists.
eileen [Fri, 31 Jan 2020 03:58:59 +0000 (16:58 +1300)]
[REF] Pass params into function rather than this weird check for whether params exists.

This function used to be shared with the online form & hence this form had to work to make itself 'look' like the other form.

It is now free to be it's own form

4 years agoMerge pull request #16434 from eileenmcnaughton/cont_form_settings
Seamus Lee [Fri, 31 Jan 2020 03:45:06 +0000 (14:45 +1100)]
Merge pull request #16434 from eileenmcnaughton/cont_form_settings

[REF] Remove unused variable

4 years agoAdd unit test to back office form when a payment is made against a partially paid...
eileen [Fri, 31 Jan 2020 02:33:54 +0000 (15:33 +1300)]
Add unit test to back office form when a payment is made against a partially paid contribution

4 years agoMerge pull request #16374 from colemanw/api4Delete
colemanw [Fri, 31 Jan 2020 00:23:28 +0000 (19:23 -0500)]
Merge pull request #16374 from colemanw/api4Delete

APIv4 - don't throw exception when updating/deleting 0 items

4 years agoMerge pull request #16432 from colemanw/comments
colemanw [Fri, 31 Jan 2020 00:20:14 +0000 (19:20 -0500)]
Merge pull request #16432 from colemanw/comments

Cleanup API_Exception usage

4 years agoevent#23 - don't count non-counted participants on Confirm Registration screen
Jon Goldberg [Thu, 12 Dec 2019 22:10:03 +0000 (17:10 -0500)]
event#23 - don't count non-counted participants on Confirm Registration screen

4 years agoRemove unused setting
eileen [Thu, 30 Jan 2020 23:02:10 +0000 (12:02 +1300)]
Remove unused setting

4 years agoUse markdown in php docblocks & display in APIv4 Explorer
Coleman Watts [Thu, 30 Jan 2020 01:34:49 +0000 (20:34 -0500)]
Use markdown in php docblocks & display in APIv4 Explorer

Reformats some docblocks to use markdown, and uses the marked.js library
to display them in the APIv4 Explorer.

4 years agoMerge pull request #16424 from eileenmcnaughton/cont_setting_handling
Eileen McNaughton [Thu, 30 Jan 2020 21:41:58 +0000 (10:41 +1300)]
Merge pull request #16424 from eileenmcnaughton/cont_setting_handling

dev/core#1558 Data conversion for non-standard setting.

4 years agoMerge pull request #16433 from eileenmcnaughton/fatal
Seamus Lee [Thu, 30 Jan 2020 21:38:42 +0000 (08:38 +1100)]
Merge pull request #16433 from eileenmcnaughton/fatal

dev/core#560 Replace fatal with exception

4 years agoAPIv4 - don't throw exception when updating 0 items
Coleman Watts [Thu, 30 Jan 2020 21:33:05 +0000 (16:33 -0500)]
APIv4 - don't throw exception when updating 0 items