Tim Otten [Thu, 18 Aug 2022 01:22:20 +0000 (18:22 -0700)]
(NFC) Flag more tests as `@group locale`
Eileen McNaughton [Wed, 24 Aug 2022 00:09:39 +0000 (12:09 +1200)]
Merge pull request #24360 from colemanw/api4CaseActivity2
APIv4 - Support updating activity.case_id
Eileen McNaughton [Wed, 24 Aug 2022 00:09:16 +0000 (12:09 +1200)]
Merge pull request #24362 from eileenmcnaughton/imp_cont
[Ref] Extract getContactFields
Eileen McNaughton [Tue, 23 Aug 2022 23:42:53 +0000 (11:42 +1200)]
Merge pull request #24361 from demeritcowboy/unused-funcs
Unused functions in CRM_Upgrade_Form
Eileen McNaughton [Tue, 23 Aug 2022 21:43:05 +0000 (09:43 +1200)]
Merge pull request #24268 from colemanw/groupPermissions
APIv4 - Expand Group.create permissions to include CiviMail
Coleman Watts [Fri, 19 Aug 2022 19:21:20 +0000 (15:21 -0400)]
APIv4 - Support updating activity.case_id
colemanw [Tue, 23 Aug 2022 21:37:29 +0000 (17:37 -0400)]
Merge pull request #24333 from eileenmcnaughton/location_simplify
Simplify Domain edit form to not call complete `LocationBlock::buildQuickForm`
colemanw [Tue, 23 Aug 2022 21:36:48 +0000 (17:36 -0400)]
Merge pull request #24351 from eileenmcnaughton/import_except
[REF] Simplify error handling in contribution import
colemanw [Tue, 23 Aug 2022 21:35:29 +0000 (17:35 -0400)]
Merge pull request #24353 from eileenmcnaughton/import_class_fold
[REF] Fold only parent class into only child class
colemanw [Tue, 23 Aug 2022 21:32:08 +0000 (17:32 -0400)]
Merge pull request #24357 from eileenmcnaughton/import_member_metadata
Deprecate `BAO_Membership::importableFields`
Eileen McNaughton [Tue, 23 Aug 2022 21:16:19 +0000 (09:16 +1200)]
[Ref] Extract getContactFields
demeritcowboy [Tue, 23 Aug 2022 20:07:05 +0000 (16:07 -0400)]
unused functions
demeritcowboy [Tue, 23 Aug 2022 12:37:07 +0000 (08:37 -0400)]
Merge pull request #24338 from eileenmcnaughton/smarty_skip_title
Fix notice on skipTitle
demeritcowboy [Tue, 23 Aug 2022 12:24:40 +0000 (08:24 -0400)]
Merge pull request #24348 from totten/master-class-err
ClassScanner - Throw an exception if a class-file doesn't have the expected class
Eileen McNaughton [Tue, 23 Aug 2022 09:53:34 +0000 (21:53 +1200)]
Merge pull request #24359 from eileenmcnaughton/master
Merge branch '5.53' to master
Eileen McNaughton [Tue, 23 Aug 2022 09:51:54 +0000 (21:51 +1200)]
Merge branch '5.53' of github.com:civicrm/civicrm-core
Eileen McNaughton [Mon, 22 Aug 2022 22:13:30 +0000 (10:13 +1200)]
[REF] Simplify error handling
Update CRM/Contribute/Import/Parser/Contribution.php
Co-authored-by: Seamus Lee <seamuslee001@gmail.com>
Eileen McNaughton [Tue, 23 Aug 2022 06:47:59 +0000 (18:47 +1200)]
Merge pull request #24354 from eileenmcnaughton/import_select_two
Move `isSkipDuplicates` to shared parent
Eileen McNaughton [Tue, 23 Aug 2022 04:49:57 +0000 (16:49 +1200)]
Deprecated Membership::importableFields
Tim Otten [Tue, 23 Aug 2022 03:24:41 +0000 (20:24 -0700)]
UnitTests - Tighten class-scanning for `civicrm-core:tests/phpunit`
This addresses a bug where:
1. Class-scanning of `civicrm-core:tests/phpunit/*` works with core-test-suites
2. Class-scanning of `civicrm-core:tests/phpunit/*` fails with civiimport test-suite.
The difference is that core-tests setup class-loading for
`civicrm-core:tests/phpunit/`; `civimport` understandably doesn't.
Class-scanning is only viable if we regard the specific classes a loadable.
This further tightens it:
1. Since core-test-suites can load `civicrm-core:tests/phpunit/*`, they will scan it
2. Since civiimport test-suite cannot load it, it will not scan it.
Seamus Lee [Tue, 23 Aug 2022 03:32:55 +0000 (13:32 +1000)]
Merge pull request #24346 from eileenmcnaughton/no_proceed
Import - remove import button if it will not work
Eileen McNaughton [Tue, 23 Aug 2022 03:20:15 +0000 (15:20 +1200)]
Move isSkipDuplicates to shared parent
Eileen McNaughton [Wed, 10 Aug 2022 02:10:40 +0000 (14:10 +1200)]
Fold only parent class into only child class
Eileen McNaughton [Tue, 23 Aug 2022 02:45:23 +0000 (14:45 +1200)]
Merge pull request #24350 from eileenmcnaughton/import_cont_less
Remove do-nothing code, add test to prove
colemanw [Tue, 23 Aug 2022 02:04:38 +0000 (22:04 -0400)]
Merge pull request #24344 from eileenmcnaughton/import_cont
Fix imported statuses & contribution id storage on import job
Eileen McNaughton [Mon, 22 Aug 2022 20:52:59 +0000 (08:52 +1200)]
Import - remove import button if it will not work
Eileen McNaughton [Tue, 23 Aug 2022 00:45:01 +0000 (12:45 +1200)]
Merge pull request #24352 from civicrm/5.53
5.53
Seamus Lee [Tue, 23 Aug 2022 00:39:42 +0000 (10:39 +1000)]
Merge pull request #24349 from eileenmcnaughton/import_mem
Fix error on membership imports
Eileen McNaughton [Mon, 22 Aug 2022 21:54:54 +0000 (09:54 +1200)]
Remove do-nothing code, add test to prove
Eileen McNaughton [Mon, 22 Aug 2022 21:10:26 +0000 (09:10 +1200)]
Fix error on membership imports
Tim Otten [Fri, 19 Aug 2022 07:56:06 +0000 (00:56 -0700)]
ClassScanner - Throw an exception if a scanned file doesn't have an expected class
Seamus Lee [Mon, 22 Aug 2022 07:12:12 +0000 (17:12 +1000)]
Merge pull request #24330 from eileenmcnaughton/smarty_notice_single_record_edit
Strict smarty notice fix on contact edit - `isSingleRecordEdit`
Eileen McNaughton [Mon, 22 Aug 2022 06:38:55 +0000 (18:38 +1200)]
Merge pull request #24342 from seamuslee001/membership_cancel_tests_migrate
[REF]dev/core#2517 Remove tests from core test suites relating to mem…
Eileen McNaughton [Sun, 21 Aug 2022 21:50:58 +0000 (09:50 +1200)]
Strict smarty notice fix on contact edit - isSingleRecordEdit
Eileen McNaughton [Mon, 22 Aug 2022 03:47:19 +0000 (15:47 +1200)]
Fix imported statuses & contribution id storage on import job
Eileen McNaughton [Mon, 22 Aug 2022 03:18:51 +0000 (15:18 +1200)]
Merge pull request #24339 from eileenmcnaughton/sup_fields
Remove extraneous `if` (`supportedFields` always returns an array)
Eileen McNaughton [Mon, 22 Aug 2022 03:18:25 +0000 (15:18 +1200)]
Merge pull request #24336 from eileenmcnaughton/smarty_adv_search
Fix Advanced search under strict smarty
colemanw [Mon, 22 Aug 2022 02:57:40 +0000 (22:57 -0400)]
Merge pull request #24317 from eileenmcnaughton/elements_inv
[REF] Clarify what is being used from getElements, remove unused
Eileen McNaughton [Mon, 22 Aug 2022 02:52:54 +0000 (14:52 +1200)]
Merge pull request #24335 from eileenmcnaughton/smarty_no_pref_mail
Smarty notice fix - remove obsolete preferred_mail_format
Seamus Lee [Mon, 22 Aug 2022 01:57:19 +0000 (11:57 +1000)]
Merge pull request #24315 from eileenmcnaughton/cont_tokens_less
Fix `returnProperties` on contact retrieval in `Contact_Tokens` to fetch less, less often
Seamus Lee [Mon, 22 Aug 2022 01:54:51 +0000 (11:54 +1000)]
Merge pull request #24298 from eileenmcnaughton/cache_odd
Clean up another cache usage to use metadata
Seamus Lee [Mon, 22 Aug 2022 01:53:18 +0000 (11:53 +1000)]
Merge pull request #24297 from eileenmcnaughton/cache_miss_cust
Fix another cache usage to use metadata cache
Seamus Lee [Mon, 22 Aug 2022 01:52:40 +0000 (11:52 +1000)]
Merge pull request #24292 from eileenmcnaughton/fast
Further fix on `fastArrayCache` `has`
colemanw [Mon, 22 Aug 2022 01:46:11 +0000 (21:46 -0400)]
Merge pull request #24267 from eileenmcnaughton/datasourcetpl
Finish consolidating DataSource.tpl across non-contact imports
Seamus Lee [Mon, 22 Aug 2022 01:45:34 +0000 (11:45 +1000)]
[REF]dev/core#2517 Remove tests from core test suites relating to membership cancellation process and update extension unit tests to cover for gaps in testing
colemanw [Mon, 22 Aug 2022 01:45:23 +0000 (21:45 -0400)]
Merge pull request #24278 from eileenmcnaughton/imp_field
Remove now-unused addField from Contribution Import
colemanw [Mon, 22 Aug 2022 01:44:41 +0000 (21:44 -0400)]
Merge pull request #24289 from eileenmcnaughton/get_cust_fields
Remove now-unused addField from Custom import
colemanw [Mon, 22 Aug 2022 01:44:02 +0000 (21:44 -0400)]
Merge pull request #24313 from eileenmcnaughton/old
[NFC] Remove no-longer used (protected) function `getAllContactReturnFields()`
Eileen McNaughton [Mon, 22 Aug 2022 00:10:08 +0000 (12:10 +1200)]
Remove extraneous if (supportedFields always returns an array
Eileen McNaughton [Sun, 21 Aug 2022 23:41:47 +0000 (11:41 +1200)]
Fix notice on skipTitle
Eileen McNaughton [Sun, 21 Aug 2022 23:19:09 +0000 (11:19 +1200)]
Fix Advanced search under strict smarty
Eileen McNaughton [Sun, 21 Aug 2022 23:08:38 +0000 (11:08 +1200)]
Smarty notice fix - remove obsolete preferred_mail_format
Eileen McNaughton [Sun, 21 Aug 2022 22:53:03 +0000 (10:53 +1200)]
Simplify Domain edit form to not call complete LocationBlock build
Eileen McNaughton [Sun, 21 Aug 2022 21:53:29 +0000 (09:53 +1200)]
Merge pull request #24326 from demeritcowboy/report-warnings
[php 8 compat] Make sure variables are assigned in civireport
Eileen McNaughton [Sun, 21 Aug 2022 21:18:55 +0000 (09:18 +1200)]
Merge pull request #24327 from demeritcowboy/unused-func
Unused function getOptionalSmartyElements
Eileen McNaughton [Sun, 21 Aug 2022 21:16:42 +0000 (09:16 +1200)]
Merge pull request #24328 from demeritcowboy/linkcases-test
[NFC] Better unit test of Link Cases form
demeritcowboy [Sun, 21 Aug 2022 13:15:29 +0000 (09:15 -0400)]
better test of the form
demeritcowboy [Sun, 21 Aug 2022 11:46:38 +0000 (07:46 -0400)]
unused function
demeritcowboy [Sun, 21 Aug 2022 11:45:32 +0000 (07:45 -0400)]
make sure variables are assigned
colemanw [Sat, 20 Aug 2022 13:18:43 +0000 (09:18 -0400)]
Merge pull request #24314 from eileenmcnaughton/ql
Improve activity demo data - more types
Eileen McNaughton [Fri, 19 Aug 2022 21:48:08 +0000 (09:48 +1200)]
Merge pull request #24319 from eileenmcnaughton/no_load
Finally remove hated `loadRelatedObjects` call from Invoice task
Eileen McNaughton [Thu, 18 Aug 2022 09:25:42 +0000 (21:25 +1200)]
Clean up another cache usage to use metadata
Eileen McNaughton [Fri, 19 Aug 2022 15:42:01 +0000 (03:42 +1200)]
Finally remove hated loadRelatedObjects call from Invoice task
Eileen McNaughton [Fri, 19 Aug 2022 07:59:22 +0000 (19:59 +1200)]
[REF] Clarify what is being used from getElements, remove unused
colemanw [Fri, 19 Aug 2022 13:35:22 +0000 (09:35 -0400)]
Merge pull request #24293 from colemanw/relationshipFilters
SearchKit - Support form filters for relationships
colemanw [Fri, 19 Aug 2022 12:59:02 +0000 (08:59 -0400)]
Merge pull request #24318 from eileenmcnaughton/rows
dev/core#3771 - E-notice fix on manage groups
Eileen McNaughton [Fri, 19 Aug 2022 09:39:11 +0000 (21:39 +1200)]
E-notice fix
Eileen McNaughton [Fri, 19 Aug 2022 06:40:32 +0000 (18:40 +1200)]
Fix returnProperties on contact retrieval
Eileen McNaughton [Fri, 19 Aug 2022 05:13:04 +0000 (17:13 +1200)]
Improve activity demo data - more types
Eileen McNaughton [Fri, 19 Aug 2022 05:43:52 +0000 (17:43 +1200)]
Merge pull request #24311 from eileenmcnaughton/ql
Regenerate sql
Eileen McNaughton [Fri, 19 Aug 2022 04:10:22 +0000 (16:10 +1200)]
Merge pull request #24310 from agileware/CIVICRM-2033
For Contribution pages with a recurring payment option. Change the label from "Regular amount" to "Regular Amount"
Eileen McNaughton [Fri, 19 Aug 2022 02:48:20 +0000 (14:48 +1200)]
Merge pull request #24309 from seamuslee001/greeting_check
[REF] Only add in entry to update Greeting if the greeting doesn't ma…
Seamus Lee [Fri, 19 Aug 2022 01:52:45 +0000 (11:52 +1000)]
Merge pull request #24308 from eileenmcnaughton/processor_notice
Enotice fix on payment processor browse
Eileen McNaughton [Fri, 19 Aug 2022 00:37:34 +0000 (12:37 +1200)]
Regenerate sql
Eileen McNaughton [Fri, 19 Aug 2022 01:11:09 +0000 (13:11 +1200)]
Remove no-longer used (protected) function
Seamus Lee [Fri, 19 Aug 2022 01:03:30 +0000 (11:03 +1000)]
Merge pull request #24103 from eileenmcnaughton/ship_set
dev/core#3685 Update some of our sample data price sets to NOT be quick config
Justin Freeman [Fri, 19 Aug 2022 00:14:39 +0000 (10:14 +1000)]
CIVICRM-2033 Use CiviCRM standard first letter case "Regular amount" changes to "Regular Amount"
Seamus Lee [Fri, 19 Aug 2022 00:09:05 +0000 (10:09 +1000)]
Merge pull request #24183 from seamuslee001/elavon_extension_convert
[REF] Convert Elavon Payment Processor to be a core Extension
Seamus Lee [Thu, 18 Aug 2022 23:47:37 +0000 (09:47 +1000)]
[REF] Only add in entry to update Greeting if the greeting doesn't match what is already in the database
Eileen McNaughton [Thu, 18 Aug 2022 23:46:25 +0000 (11:46 +1200)]
Merge pull request #24306 from eileenmcnaughton/assoc
Deprecate two single-use option-value functions `create-a-sock` and `delete-a-sock`
Seamus Lee [Thu, 18 Aug 2022 23:43:10 +0000 (09:43 +1000)]
Merge pull request #24129 from eileenmcnaughton/greeting_perf
Code cleanup on greeting processing
demeritcowboy [Thu, 18 Aug 2022 23:24:19 +0000 (19:24 -0400)]
Merge pull request #24282 from totten/master-hookstyle-svc
CiviEventDispatcher - Fix pass-by-reference of hook-style arguments for service-based listeners
Eileen McNaughton [Thu, 18 Aug 2022 22:27:47 +0000 (10:27 +1200)]
Enotice fix on payment processor browse
Eileen McNaughton [Thu, 18 Aug 2022 21:43:03 +0000 (09:43 +1200)]
Merge pull request #24307 from totten/master-ornery
(NFC) FileTest - Mark as ornery
Seamus Lee [Mon, 8 Aug 2022 22:51:59 +0000 (08:51 +1000)]
[REF] Convert Elavon Payment Processor to be a core Extension
Tim Otten [Thu, 18 Aug 2022 21:23:03 +0000 (14:23 -0700)]
(NFC) FileTest - Mark as ornery
colemanw [Thu, 18 Aug 2022 21:22:44 +0000 (17:22 -0400)]
Merge pull request #24230 from eileenmcnaughton/import_api
Add `civiimport` core extension with Import api code for viewing import tables
Eileen McNaughton [Thu, 18 Aug 2022 20:34:36 +0000 (08:34 +1200)]
Deprecate two single-use option-value functions
Eileen McNaughton [Thu, 18 Aug 2022 19:53:09 +0000 (07:53 +1200)]
Merge pull request #24299 from colemanw/daoIdField
CRM_Core_DAO - Be more flexible about the primary key name
Eileen McNaughton [Thu, 18 Aug 2022 19:52:22 +0000 (07:52 +1200)]
Merge pull request #24302 from agh1/5.53.0-releasenotes-initial
5.53.0 release notes initial run
Eileen McNaughton [Thu, 18 Aug 2022 19:44:34 +0000 (07:44 +1200)]
Merge pull request #24303 from kurund/recaptcha-fatal-fixes
dev/core#3811 fixes for missing recaptcha_check_answer() when validate is called by other extensions
Eileen McNaughton [Thu, 18 Aug 2022 19:42:37 +0000 (07:42 +1200)]
Merge pull request #24301 from mattwire/participantnotice
Fix PHP notice and hide/show 'including yourself' depending on if contact_id is set
Matthew Wire [Thu, 18 Aug 2022 16:18:27 +0000 (17:18 +0100)]
Merge pull request #24277 from mattwire/testsvalidcountry
AUS is not a valid ISO 3166-1 alpha-2 country code. Do not use it in tests
colemanw [Thu, 18 Aug 2022 16:05:54 +0000 (12:05 -0400)]
Merge pull request #24287 from totten/master-single
(REF) Extract method `Array::single()`
Kurund Jalmi [Thu, 18 Aug 2022 16:03:21 +0000 (17:03 +0100)]
fixes for missing recaptcha_check_answer() when validate is called by other extensions
Andie Hunt [Thu, 18 Aug 2022 16:01:32 +0000 (12:01 -0400)]
5.53.0 release notes: added boilerplate
Matthew Wire [Sun, 3 Jul 2022 16:05:38 +0000 (17:05 +0100)]
Fix PHP notice and hide/show 'including yourself' depending on if contact_id is set
colemanw [Thu, 18 Aug 2022 14:53:25 +0000 (10:53 -0400)]
Merge pull request #24167 from mattwire/participant_created_id
dev/core#3778 Add created_id field to civicrm_participant
Andie Hunt [Thu, 18 Aug 2022 13:57:54 +0000 (09:57 -0400)]
5.53.0 release notes: raw from script
Coleman Watts [Wed, 17 Aug 2022 18:29:17 +0000 (14:29 -0400)]
Import API - remove unused actions, use trait for create/save/update actions