Seamus Lee [Tue, 25 May 2021 00:34:32 +0000 (10:34 +1000)]
Merge pull request #20405 from mattwire/eventcarttest
Update eventcart test to only test payment form
Seamus Lee [Mon, 24 May 2021 23:25:06 +0000 (09:25 +1000)]
Merge pull request #20404 from eileenmcnaughton/pledge_tax2
Fix contribution page pledge tests to create valid contributions
Seamus Lee [Mon, 24 May 2021 22:47:42 +0000 (08:47 +1000)]
Merge pull request #20360 from eileenmcnaughton/ppp
[REF] Cleanup validation in PaypalProIPN single function
Matthew Wire [Tue, 18 May 2021 18:08:40 +0000 (19:08 +0100)]
Update eventcart test to only test payment form
Eileen McNaughton [Mon, 24 May 2021 21:43:42 +0000 (09:43 +1200)]
Fix contribution page pledge tests to create valid contributions
This addresses an issue where they were using a contribution page with a price
set but te submit params were not valid for that price set
Seamus Lee [Mon, 24 May 2021 21:34:47 +0000 (07:34 +1000)]
Merge pull request #20393 from eileenmcnaughton/ref_line
[REF] Minor simplification
Eileen McNaughton [Mon, 24 May 2021 21:33:20 +0000 (09:33 +1200)]
Merge pull request #20390 from eileenmcnaughton/tax2
Tax fixes in unit test
Eileen McNaughton [Mon, 24 May 2021 01:48:24 +0000 (13:48 +1200)]
Tax fixes in unit test
When this->isValidateFinancialsOnPostAssert is true the
test class checks that line items and payments are valid.
I'm trying to enable this for this class. However, there are some issues
that I have found fixes for (and at least 1 I'm still working on)
- some tests try to set tax_amount when it is not enabled
which is invalid - removed
- one test tries to use chaining in a way that
we know is not going to do a job of creating the entities
as it adds the payment before the line items. I switched
this to create a pending payment which doesn't alter the
thing under test & brings it closer to the
recommended flow
- one test is deliberately invalid - I marked it as
not eligible for the validation
- the price set id was not being passed to the Confirm->submit
function (accessed by tests, mostly via the ContributionPage.submit
api) - I added functionality to retrieve it
colemanw [Mon, 24 May 2021 20:02:08 +0000 (16:02 -0400)]
Merge pull request #20400 from MegaphoneJon/check-signature
fix arguments sent to hook_civicrm_check
Jon Goldberg [Mon, 24 May 2021 18:14:59 +0000 (14:14 -0400)]
fix arguments sent to hook_civicrm_check
colemanw [Mon, 24 May 2021 13:39:44 +0000 (09:39 -0400)]
Merge pull request #20383 from colemanw/afformUsageFixes
Afform - Improve Gui, prefill & submit APIs
Coleman Watts [Sun, 23 May 2021 01:00:15 +0000 (21:00 -0400)]
Afform - Improve Gui, prefill & submit APIs
Standardizes prefill & submit APIs to use the same logic for validating contacts.
Displays correct form URL in GUI depending on is_frontend setting.
Shows warning about url arguments to prevent unintentional permissions escalation.
Eileen McNaughton [Mon, 24 May 2021 03:57:29 +0000 (15:57 +1200)]
[REF] Minor simplification
Monish Deb [Mon, 24 May 2021 06:44:01 +0000 (12:14 +0530)]
Merge pull request #20391 from eileenmcnaughton/tax_valid
Add call to validateAllContributions & fix getTotalAmount
Eileen McNaughton [Mon, 24 May 2021 02:29:04 +0000 (14:29 +1200)]
Add call to validateAllContributions & fix getTotalAmount
I've updated 2 tests for readability and extended one to call
validateAllContributions. The call failed and it turned out to
be the check was wrong. Fixing that caused a test to fail.
I have fixed the test by fixing getTotalAmount on the internal
helper BAO_Order class to include the tax_amount for each line
in the total.
I think this would most affect tests - but it might affect the
Membership_Form due to changes made recently to that
form so I'm on the fence about going for the rc with this
one
Monish Deb [Mon, 24 May 2021 04:24:10 +0000 (09:54 +0530)]
Merge pull request #20358 from eileenmcnaughton/partial
Remove legacy references to partial_amount_to_pay
Seamus Lee [Mon, 24 May 2021 03:27:52 +0000 (13:27 +1000)]
Merge pull request #20389 from eileenmcnaughton/tax
[NFC] {test} code cleanup in test class
Eileen McNaughton [Sun, 23 May 2021 23:54:39 +0000 (11:54 +1200)]
[NFC] {test} minor cleanup
Eileen McNaughton [Mon, 24 May 2021 01:27:44 +0000 (13:27 +1200)]
Merge pull request #20387 from eileenmcnaughton/tax
[NFC] Minor cleanup
Eileen McNaughton [Mon, 24 May 2021 00:37:14 +0000 (12:37 +1200)]
Merge pull request #20386 from eileenmcnaughton/cont_f
[NFC] Minor code cleanup
Seamus Lee [Sun, 23 May 2021 23:46:14 +0000 (09:46 +1000)]
Merge pull request #20370 from seamuslee001/phpunit8
Use PHPUnit8 in main test suites
Eileen McNaughton [Sun, 23 May 2021 23:18:44 +0000 (11:18 +1200)]
[NFC] Minor cleanup
Eileen McNaughton [Sun, 23 May 2021 23:08:06 +0000 (11:08 +1200)]
[NFC] Minor code cleanup
Eileen McNaughton [Sun, 23 May 2021 21:59:57 +0000 (09:59 +1200)]
Merge pull request #20384 from mattwire/deprecateddopayment
If paymentprocessor still uses doTransferCheckout/doDirectPayment trigger deprecated function warning
Matthew Wire [Sun, 23 May 2021 10:26:13 +0000 (11:26 +0100)]
If paymentprocessor still uses doTransferCheckout/doDirectPayment trigger deprecated function warning
Seamus Lee [Thu, 20 May 2021 23:50:52 +0000 (09:50 +1000)]
Use PHPUnit8 for main runs
Eileen McNaughton [Sun, 23 May 2021 07:30:47 +0000 (19:30 +1200)]
Merge pull request #20380 from seamuslee001/api_v3_civi_phpunit8_warnings
[NFC] Fix PHPUnit8 Deprecation Warnings in api_v3 and Civi Test Suites
Seamus Lee [Sat, 22 May 2021 04:20:56 +0000 (14:20 +1000)]
[NFC] Fix PHPUnit8 Deprecation Warnings in api_v3 and Civi Test Suites
Seamus Lee [Sat, 22 May 2021 21:33:29 +0000 (07:33 +1000)]
Merge pull request #20373 from eileenmcnaughton/gc
[REF] extract function to get locks
Seamus Lee [Sat, 22 May 2021 07:12:56 +0000 (17:12 +1000)]
Merge pull request #20374 from eileenmcnaughton/gc4
[NFC] [Test] Big cleanup in test class
Seamus Lee [Sat, 22 May 2021 06:35:11 +0000 (16:35 +1000)]
Merge pull request #20381 from seamuslee001/api_v4_phpunit8_warnings
[NFC] Fix PHPUnit8 Deprecation warnings in the api_v4 Test Suite
Seamus Lee [Sat, 22 May 2021 05:56:15 +0000 (15:56 +1000)]
Merge pull request #20379 from seamuslee001/e2e_phpunit8_warnings
[NFC] Fix PHPUnit8 Warning notices in E2E And in some API unit tests
Eileen McNaughton [Fri, 21 May 2021 07:07:14 +0000 (19:07 +1200)]
[NFC] [Test] Big cleanup in test class
Eileen McNaughton [Sat, 22 May 2021 05:28:28 +0000 (17:28 +1200)]
Merge pull request #20378 from eileenmcnaughton/entry
[REF] Remove unused variable
Seamus Lee [Sat, 22 May 2021 04:48:08 +0000 (14:48 +1000)]
[NFC] Fix PHPUnit8 Deprecation warnings in the api_v4 Test Suite
Seamus Lee [Sat, 22 May 2021 02:44:06 +0000 (12:44 +1000)]
Further fixes
Seamus Lee [Sat, 22 May 2021 00:28:04 +0000 (10:28 +1000)]
Fix PHPUnit8 Warning notices in E2E And in some API unit tests
Seamus Lee [Sat, 22 May 2021 01:57:11 +0000 (11:57 +1000)]
Merge pull request #20377 from seamuslee001/crm_phpunit8_warnings
[NFC] Fix PHPUnit8 deprecation warnings in the CRM_AllTests suite
Seamus Lee [Fri, 21 May 2021 22:33:18 +0000 (08:33 +1000)]
[NFC] Fix PHPUnit8 deprecation warnings in the CRM_AllTests suite
Eileen McNaughton [Fri, 21 May 2021 23:03:11 +0000 (11:03 +1200)]
[REF] Remove unused field parameters
Eileen McNaughton [Fri, 21 May 2021 05:52:38 +0000 (17:52 +1200)]
[REF] extract function to get locks
This is part of trying to make the logic more re-usable and make the
way of dealing with a single group more aligned with dealing with
multiple groups in this class
colemanw [Fri, 21 May 2021 18:19:44 +0000 (14:19 -0400)]
Merge pull request #20305 from seamuslee001/afformEntityRefSubmit
Afform Entity Reference Submit
Coleman Watts [Fri, 21 May 2021 00:10:37 +0000 (20:10 -0400)]
Afform - Simplify postprocess event, cleanup api code & improve test coverage
- Simplifies getEntityWeights function using topological sorting library
- Consolodates postprocess event listners to just processGenericEntity
- Adds missing getters/setters to api classes
- Improves the AfformSubmitEvent interface to make it easeier to use
- Adds to tests
Seamus Lee [Fri, 21 May 2021 05:55:15 +0000 (15:55 +1000)]
Merge pull request #20372 from eileenmcnaughton/tax
[NFC] Further cleanup in test class
Eileen McNaughton [Fri, 21 May 2021 01:17:28 +0000 (13:17 +1200)]
[NFC] Further cleanup in test class
Seamus Lee [Fri, 21 May 2021 01:45:36 +0000 (11:45 +1000)]
Merge pull request #20369 from seamuslee001/more_voids
[NFC] Add in more voids to unit tests to support PHPUnit8
Eileen McNaughton [Fri, 21 May 2021 01:19:20 +0000 (13:19 +1200)]
Merge pull request #20371 from eileenmcnaughton/tax
[NFC] [Test] Preliminary cleanup in test class
Tim Otten [Fri, 21 May 2021 01:12:40 +0000 (18:12 -0700)]
Merge pull request #20353 from seamuslee001/fix_distmaker_sync_core_ext
Fix Distmaker building by ensuring we are rsyncing from the right folder
Seamus Lee [Fri, 21 May 2021 01:06:27 +0000 (11:06 +1000)]
Merge pull request #20217 from eileenmcnaughton/contop
[Test] Add test cover for contribution tokens in pdf letter
Seamus Lee [Fri, 21 May 2021 00:13:50 +0000 (10:13 +1000)]
Merge pull request #20368 from eileenmcnaughton/cc
[REF] Slightly more logical order of code
Eileen McNaughton [Thu, 20 May 2021 23:41:47 +0000 (11:41 +1200)]
[NFC] [Test] Preliminary cleanup in test class
Seamus Lee [Thu, 20 May 2021 23:49:10 +0000 (09:49 +1000)]
[NFC] Add in more voids to unit tests to support PHPUnit8
Seamus Lee [Thu, 20 May 2021 23:45:05 +0000 (09:45 +1000)]
Merge pull request #20367 from colemanw/deprecateBulkSave
Deprecate function CRM_Core_BAO_CustomField::bulkSave
Eileen McNaughton [Thu, 20 May 2021 22:34:09 +0000 (10:34 +1200)]
[REF] Slightly more logical order of code
Just moves the lock check to the same area
Coleman Watts [Thu, 20 May 2021 21:48:08 +0000 (17:48 -0400)]
Deprecate function CRM_Core_BAO_CustomField::bulkSave
Seamus Lee [Thu, 20 May 2021 21:24:19 +0000 (07:24 +1000)]
Merge pull request #20366 from demeritcowboy/more-oo
[REF] Useradd contact task - Use OO instead of hardcoding "if Wordpress"
Seamus Lee [Thu, 20 May 2021 21:23:27 +0000 (07:23 +1000)]
Merge pull request #20359 from eileenmcnaughton/in
Superficial tidy up in test class
Seamus Lee [Thu, 20 May 2021 21:22:52 +0000 (07:22 +1000)]
Merge pull request #20363 from eileenmcnaughton/group
Cleanup - declare return types, remove unused var
Seamus Lee [Thu, 20 May 2021 21:20:46 +0000 (07:20 +1000)]
Merge pull request #20196 from eileenmcnaughton/import
[REF] Cleanup on import rows error
colemanw [Thu, 20 May 2021 21:19:21 +0000 (17:19 -0400)]
Merge pull request #20362 from eileenmcnaughton/save
Update bulkSave test to use the api
Eileen McNaughton [Thu, 20 May 2021 21:17:32 +0000 (09:17 +1200)]
Merge pull request #20349 from colemanw/searchKitFixMenuPerm
SearchKit - Fix menu permission
Seamus Lee [Thu, 20 May 2021 21:17:04 +0000 (07:17 +1000)]
Merge pull request #20365 from seamuslee001/voidtearDownAfterClass
[NFC] Add in voids to various setUpBeforeClass and tearDownAfterClass…
Seamus Lee [Thu, 20 May 2021 21:05:46 +0000 (07:05 +1000)]
Merge pull request #20348 from colemanw/searchKitTweaks
SearchKit and Afform UI improvements
Coleman Watts [Thu, 20 May 2021 15:25:29 +0000 (11:25 -0400)]
Afform Gui - Set height on dropdowns so CMS theme doesn't interfere
demeritcowboy [Thu, 20 May 2021 12:34:21 +0000 (08:34 -0400)]
make more oo-ey
Coleman Watts [Wed, 19 May 2021 16:51:19 +0000 (12:51 -0400)]
SearchKit & Afform - Style click-sort column headers
Coleman Watts [Wed, 19 May 2021 15:05:16 +0000 (11:05 -0400)]
SearchKit - Prevent overwriting SavedSearch.modified_date
When saving a search, the modified_date was being overwritten with the old value.
Coleman Watts [Wed, 19 May 2021 14:41:39 +0000 (10:41 -0400)]
SearchKit - Click-sort column headers on list page
Coleman Watts [Wed, 19 May 2021 13:18:03 +0000 (09:18 -0400)]
Afform - Standardize labels with Title Case and no colon
Coleman Watts [Tue, 18 May 2021 23:22:34 +0000 (19:22 -0400)]
Afform - Click-sort column headers on list page
Coleman Watts [Tue, 18 May 2021 17:37:43 +0000 (13:37 -0400)]
Afform - Add 'Placement' colum to admin screen
Coleman Watts [Tue, 18 May 2021 14:55:46 +0000 (10:55 -0400)]
SearchKit - Standardize labels with Title Case and no colon
The trailing colon is a pain for translators.
Coleman Watts [Tue, 18 May 2021 14:04:40 +0000 (10:04 -0400)]
SearchKit - When editing a display, show a checkbox to toggle limit
Previously, limit was a number input which could be disabled by entering the number '0'.
That's less intuitive than a checkbox.
Coleman Watts [Wed, 19 May 2021 20:03:48 +0000 (16:03 -0400)]
SearchKit - Sync menu & navigation permissions to use 'administer CiviCRM data'
Fixes dev/core#2619
https://lab.civicrm.org/dev/core/-/issues/2619
Seamus Lee [Thu, 20 May 2021 08:25:18 +0000 (18:25 +1000)]
[NFC] Add in voids to various setUpBeforeClass and tearDownAfterClass functions
Eileen McNaughton [Thu, 20 May 2021 07:19:53 +0000 (19:19 +1200)]
Cleanup - declare return types, remove unused var
Seamus Lee [Thu, 20 May 2021 06:05:17 +0000 (16:05 +1000)]
Merge pull request #20361 from eileenmcnaughton/zero
Unit test for #20342
Seamus Lee [Thu, 20 May 2021 05:49:06 +0000 (15:49 +1000)]
Merge pull request #20297 from eileenmcnaughton/roup
[REF] Extract function to build temporary table of members of group from Report_Form
Eileen McNaughton [Fri, 14 May 2021 07:14:40 +0000 (19:14 +1200)]
Save test
Eileen McNaughton [Thu, 20 May 2021 04:14:42 +0000 (16:14 +1200)]
Unit test for #20342
Eileen McNaughton [Thu, 20 May 2021 04:13:52 +0000 (16:13 +1200)]
Merge pull request #20342 from bugfolder/mandatory_keys_check
Fix mandatory keys check fail for value of float 0.0 in a required key in an entity
Eileen McNaughton [Thu, 20 May 2021 03:50:37 +0000 (15:50 +1200)]
[REF] Cleanup validation in PaypalProIPN single function
This fixes interaction with the contribution object to instead use the function
and switches the standardised error handling (throw an exception & let
it be caught).
The contribution object used to be passed to completeOrder but no longer
so there is no reason to set total_amount & invoice_id on it
(they will be used from input)
Eileen McNaughton [Thu, 20 May 2021 03:36:42 +0000 (15:36 +1200)]
Superficial tidy up in test class
Eileen McNaughton [Thu, 20 May 2021 03:32:32 +0000 (15:32 +1200)]
Merge pull request #20355 from eileenmcnaughton/ppp2
[REF] Extract getContributionObject
Eileen McNaughton [Thu, 20 May 2021 03:22:57 +0000 (15:22 +1200)]
Remove legacy references to partial_amount_to_pay
This was an early concept of how to do partial payments that we eliminated a while back
in favour of Payment.create
It is not set anywhere in core - only checked so time to remove the checks
Seamus Lee [Thu, 20 May 2021 03:18:53 +0000 (13:18 +1000)]
Merge pull request #20356 from seamuslee001/phpunit8_config
[NFC] Update PHPUnit config to not cache results in phpunit8 and add …
Seamus Lee [Thu, 20 May 2021 03:18:41 +0000 (13:18 +1000)]
Merge pull request #20354 from eileenmcnaughton/ppp
[REF] Remove now-unused parameter
Seamus Lee [Thu, 20 May 2021 03:00:54 +0000 (13:00 +1000)]
Merge pull request #20241 from eileenmcnaughton/haystack
Add test for mixed Order data
Eileen McNaughton [Fri, 14 May 2021 02:37:16 +0000 (14:37 +1200)]
[REF] Extract function to build temporary table of members of group from Report_Form
Seamus Lee [Thu, 20 May 2021 01:52:48 +0000 (11:52 +1000)]
[NFC] Update PHPUnit config to not cache results in phpunit8 and add more voids into PayflowProTest
Eileen McNaughton [Thu, 20 May 2021 01:48:18 +0000 (13:48 +1200)]
Extract getContributionObject
Eileen McNaughton [Thu, 20 May 2021 01:37:01 +0000 (13:37 +1200)]
[REF] Remove now-unused parameter
Eileen McNaughton [Thu, 20 May 2021 01:17:34 +0000 (13:17 +1200)]
Fix tearDown & setup to work under default test db state & leave it closer to default test db state
Seamus Lee [Thu, 20 May 2021 01:33:26 +0000 (11:33 +1000)]
Merge pull request #20318 from eileenmcnaughton/ppp
[REF] Add getter for contributionID
eileen [Thu, 29 Apr 2021 05:40:32 +0000 (17:40 +1200)]
[Test] Add test cover for contribution tokens in pdf letter
Seamus Lee [Thu, 20 May 2021 00:56:06 +0000 (10:56 +1000)]
Merge pull request #20345 from eileenmcnaughton/mem_move
[REF] Make previous unshared function protected & Remove hard-coded params
Seamus Lee [Thu, 20 May 2021 00:54:02 +0000 (10:54 +1000)]
Merge pull request #20330 from mattwire/fixpaymentformstest
Fix form params for testEventPaymentForms
Seamus Lee [Thu, 20 May 2021 00:34:37 +0000 (10:34 +1000)]
Merge pull request #20352 from seamuslee001/test_credit_card_validation
[NFC] Add in unit tests of credit card validation rules
Seamus Lee [Thu, 20 May 2021 00:09:05 +0000 (10:09 +1000)]
Merge pull request #20351 from seamuslee001/update_pear_finance_creditcard
[REF] Update Pear Validate Finance CreditCard to use latest tagged re…
Seamus Lee [Wed, 19 May 2021 23:48:46 +0000 (09:48 +1000)]
Fix Distmaker building by ensuring we are rsyncing from the right folder