Eileen McNaughton [Fri, 3 Mar 2023 19:55:42 +0000 (08:55 +1300)]
Merge pull request #25727 from totten/master-token-case
(dev/core#4137) Tokens - Filters should be HTML-sensitive
Tim Otten [Fri, 3 Mar 2023 09:38:29 +0000 (01:38 -0800)]
Tokens - "|upper" and "|lower" should work differently in text+html
Tim Otten [Fri, 3 Mar 2023 09:15:27 +0000 (01:15 -0800)]
(REF) TokenProcessor - Extract class StandardFilters
Tim Otten [Fri, 3 Mar 2023 08:54:08 +0000 (00:54 -0800)]
CRM_Utils_XML - Add method filterMarkupText
Eileen McNaughton [Fri, 3 Mar 2023 04:36:42 +0000 (17:36 +1300)]
Merge pull request #25722 from eileenmcnaughton/rec_test
Fix in ContributionTest class
colemanw [Fri, 3 Mar 2023 03:02:11 +0000 (22:02 -0500)]
Merge pull request #25718 from eileenmcnaughton/admin
dev/core#4153 Extend the fields available for PrimaryContact on search
Eileen McNaughton [Fri, 3 Mar 2023 02:59:44 +0000 (15:59 +1300)]
Merge pull request #25721 from demeritcowboy/history-report
Pager missing on Aggregate By Relationship civireport
Eileen McNaughton [Fri, 3 Mar 2023 02:52:40 +0000 (15:52 +1300)]
Fix in ContributionTest class
This fixes a set up bug. The test deals with a recurring contribution where the
tax is involved. The set up creates the recurring with an amount of 500
and the contribution with an amount of 100. This is invalid but because of
a code change that was outside of what is being tested it scrapes through.
This fixes the test to test a valid 100 for each, followed by the recurring
being changed to an override amount ot 200.
demeritcowboy [Fri, 3 Mar 2023 02:49:24 +0000 (21:49 -0500)]
Merge pull request #25574 from herbdool/core-4127-5
dev/core#4127 move standalone profile modification to userSystem
Herb v/d Dool [Wed, 15 Feb 2023 22:18:42 +0000 (17:18 -0500)]
dev/core#4127 move standalone profile modification to userSystem
Eileen McNaughton [Thu, 2 Mar 2023 22:55:10 +0000 (11:55 +1300)]
Extend the fields available for PrimaryContact on search
Seamus Lee [Thu, 2 Mar 2023 22:53:01 +0000 (09:53 +1100)]
Merge pull request #25707 from eileenmcnaughton/tax_error
Fix bug in tax calculation when recurring overrides with a different value
Tim Otten [Thu, 2 Mar 2023 22:48:32 +0000 (14:48 -0800)]
Merge pull request #25634 from eileenmcnaughton/except
Add new `\Civi\Exception\DBQueryException` & throw that rather than a `PEAR_Exception`
Seamus Lee [Thu, 2 Mar 2023 22:05:37 +0000 (09:05 +1100)]
Merge pull request #25689 from eileenmcnaughton/php82_quick_config
Php8.2 stop accessing undefined form Property isQuickConfig in `PriceField:addQuickFormElement`
demeritcowboy [Thu, 2 Mar 2023 22:02:39 +0000 (17:02 -0500)]
make pager work
Eileen McNaughton [Thu, 2 Mar 2023 19:53:58 +0000 (08:53 +1300)]
Merge pull request #25713 from totten/worldregion
Worldregion - For API-entity-naming, prefer "WorldRegion"
Tim Otten [Thu, 2 Mar 2023 05:53:53 +0000 (21:53 -0800)]
Worldregion - For API-entity-naming, prefer "WorldRegion"
Eileen McNaughton [Thu, 2 Mar 2023 04:03:02 +0000 (17:03 +1300)]
Merge pull request #25708 from eileenmcnaughton/nfc
[NFC] Superficial cleanup in test class
Eileen McNaughton [Thu, 2 Mar 2023 03:12:45 +0000 (16:12 +1300)]
Merge pull request #25710 from colemanw/deprecatedGone
Deprecated code removal
Eileen McNaughton [Thu, 2 Mar 2023 00:06:17 +0000 (13:06 +1300)]
[NFC] Superficial cleanup in test class
CiviCRM [Thu, 2 Mar 2023 01:32:24 +0000 (01:32 +0000)]
Set version to 5.61.alpha1
CiviCRM [Thu, 2 Mar 2023 01:32:11 +0000 (01:32 +0000)]
Set version to 5.60.beta1
Coleman Watts [Thu, 2 Mar 2023 01:19:54 +0000 (20:19 -0500)]
Deprecated code removal
Eileen McNaughton [Wed, 1 Mar 2023 22:48:36 +0000 (11:48 +1300)]
Fix bug in tax calculation when recurring overrides with a different value
Eileen McNaughton [Wed, 1 Mar 2023 22:46:58 +0000 (11:46 +1300)]
Merge pull request #25706 from eileenmcnaughton/strict
Stricter typing in Apiv4
Eileen McNaughton [Wed, 1 Mar 2023 21:49:40 +0000 (10:49 +1300)]
Stricter typing in Apiv4
colemanw [Wed, 1 Mar 2023 21:03:00 +0000 (16:03 -0500)]
Merge pull request #25705 from eileenmcnaughton/dep
Remove deprecated function calls to Event::del, Membership functions del, OptionValue
Eileen McNaughton [Wed, 1 Mar 2023 19:51:53 +0000 (08:51 +1300)]
Remove some calls to OptionValue deleteRecord
Eileen McNaughton [Wed, 1 Mar 2023 19:48:57 +0000 (08:48 +1300)]
Deprecations in Event, Membership
Per https://github.com/civicrm/civicrm-core/pull/25677
Eileen McNaughton [Wed, 1 Mar 2023 19:44:34 +0000 (08:44 +1300)]
Stop calling deprectated del function
Eileen McNaughton [Wed, 1 Mar 2023 06:34:22 +0000 (19:34 +1300)]
Merge pull request #25702 from civicrm/5.59
5.59
Yashodha Chaku [Wed, 1 Mar 2023 04:42:43 +0000 (10:12 +0530)]
Merge pull request #25698 from colemanw/removeIds
Remove deprecated use of $ids
Yashodha Chaku [Wed, 1 Mar 2023 04:40:51 +0000 (10:10 +0530)]
Merge pull request #25701 from alifrumin/5.59rn
[NFC] 5.59 release notes sorting and annotating
Alice Frumin [Wed, 1 Mar 2023 03:56:11 +0000 (22:56 -0500)]
[NFC] 5.59 release notes sorting and annotating
Eileen McNaughton [Wed, 1 Mar 2023 02:51:57 +0000 (15:51 +1300)]
Merge pull request #25699 from civicrm/5.59
5.59 to master
Eileen McNaughton [Wed, 1 Mar 2023 02:51:34 +0000 (15:51 +1300)]
Merge pull request #25697 from agh1/5.59.0-releasenotes-initial
5.59.0 releasenotes initial run
Tim Otten [Wed, 1 Mar 2023 01:44:30 +0000 (17:44 -0800)]
Merge pull request #25639 from eileenmcnaughton/import_validate
dev/core#4132 Fix import for multi-custom boxes
Coleman Watts [Wed, 1 Mar 2023 01:32:09 +0000 (20:32 -0500)]
Remove deprecated use of $ids
Andie Hunt [Wed, 1 Mar 2023 01:26:08 +0000 (20:26 -0500)]
5.59.0 release notes: added boilerplate
Andie Hunt [Wed, 1 Mar 2023 01:21:59 +0000 (20:21 -0500)]
5.59.0 release notes: raw from script
colemanw [Wed, 1 Mar 2023 00:57:11 +0000 (19:57 -0500)]
Merge pull request #25696 from colemanw/delDep
Delete long-deprecated functions
colemanw [Wed, 1 Mar 2023 00:22:38 +0000 (19:22 -0500)]
Merge pull request #25695 from eileenmcnaughton/CRM/Block
Pull over a few more deprecations + blockDelete deprecation
Coleman Watts [Wed, 1 Mar 2023 00:04:36 +0000 (19:04 -0500)]
Delete long-deprecated functions
Eileen McNaughton [Tue, 28 Feb 2023 23:48:27 +0000 (12:48 +1300)]
Pull over a few more deprecations + blockDelete deprecation
Eileen McNaughton [Tue, 28 Feb 2023 23:45:38 +0000 (12:45 +1300)]
Merge pull request #25693 from eileenmcnaughton/CRM/Block
Address portions of deprecated code replacement
Eileen McNaughton [Tue, 28 Feb 2023 22:31:22 +0000 (11:31 +1300)]
Address portions of deprecated code replacement
colemanw [Tue, 28 Feb 2023 22:07:48 +0000 (17:07 -0500)]
Merge pull request #25691 from eileenmcnaughton/dep_mailing
Deprecations for Mailing::delete functions
Eileen McNaughton [Tue, 28 Feb 2023 21:49:55 +0000 (10:49 +1300)]
Merge pull request #25690 from eileenmcnaughton/dep_test
Deprecations for delete on ACL entities
Eileen McNaughton [Tue, 28 Feb 2023 21:01:23 +0000 (10:01 +1300)]
Deprecations for Mailing::delete functions
Eileen McNaughton [Tue, 28 Feb 2023 20:51:03 +0000 (09:51 +1300)]
Deprecations for delete on ACL entities
Seamus Lee [Tue, 28 Feb 2023 20:10:29 +0000 (07:10 +1100)]
Merge pull request #25688 from eileenmcnaughton/dep_test
Remove deprecated functions from tests
Eileen McNaughton [Tue, 28 Feb 2023 19:30:02 +0000 (08:30 +1300)]
Php8.2 stop accessing undefined form Property isQuickConfig in PriceField:addQuickFormElement
Eileen McNaughton [Tue, 28 Feb 2023 18:48:22 +0000 (07:48 +1300)]
Remove deprecated functions from tests
Eileen McNaughton [Tue, 28 Feb 2023 06:02:16 +0000 (19:02 +1300)]
Merge pull request #25686 from eileenmcnaughton/dep_2020_address
Remove 2020-deprecated handling of `legacyAddressCreate`
Yashodha Chaku [Tue, 28 Feb 2023 03:16:00 +0000 (08:46 +0530)]
Merge pull request #25685 from eileenmcnaughton/dep_2020
Remove function noisily deprecated when the world was young (2020)
Yashodha Chaku [Tue, 28 Feb 2023 03:14:00 +0000 (08:44 +0530)]
Merge pull request #25684 from eileenmcnaughton/address_delete
Remove deprecated function call
Eileen McNaughton [Tue, 28 Feb 2023 02:28:15 +0000 (15:28 +1300)]
Merge pull request #25646 from colemanw/fixSearchDisplayFilter
Afform - Filter autocomplete fields belonging to a search display
Eileen McNaughton [Tue, 28 Feb 2023 02:24:31 +0000 (15:24 +1300)]
Remove 2020-deprecated handline of legacyAddressCreate
Eileen McNaughton [Tue, 28 Feb 2023 02:01:49 +0000 (15:01 +1300)]
Remove function noisily deprecated when the world was young (2020)
demeritcowboy [Tue, 28 Feb 2023 01:53:40 +0000 (20:53 -0500)]
Merge pull request #25669 from eileenmcnaughton/smarty-syntax
dev/core#4146 Remove (old) Smarty-forward incompatible syntax from Address.tpl
demeritcowboy [Tue, 28 Feb 2023 01:34:09 +0000 (20:34 -0500)]
Merge pull request #25683 from eileenmcnaughton/logging_dep
Add gentle deprecation to `debug_log_message`
demeritcowboy [Tue, 28 Feb 2023 01:25:34 +0000 (20:25 -0500)]
Merge pull request #25682 from eileenmcnaughton/log_smarty
Log Smarty debug to it's own channel
demeritcowboy [Tue, 28 Feb 2023 01:05:03 +0000 (20:05 -0500)]
Merge pull request #25680 from eileenmcnaughton/smarty-bank
Smarty notice fix on bank_account_number
Eileen McNaughton [Tue, 28 Feb 2023 00:54:38 +0000 (13:54 +1300)]
Remove deprecated function call
Eileen McNaughton [Tue, 28 Feb 2023 00:50:13 +0000 (13:50 +1300)]
Merge pull request #25678 from eileenmcnaughton/logging-ref
Remove unnecessary pass-by-reference
Eileen McNaughton [Tue, 28 Feb 2023 00:47:52 +0000 (13:47 +1300)]
Add gentle deprecation to debug_log_message
colemanw [Tue, 28 Feb 2023 00:47:11 +0000 (19:47 -0500)]
Merge pull request #25679 from eileenmcnaughton/deprecated_mem_type
Remove code deprecated in 2018
Eileen McNaughton [Tue, 28 Feb 2023 00:36:47 +0000 (13:36 +1300)]
Log Smarty debug to it's own channel
I just wrote the docs on the right way to log using this example
https://docs.civicrm.org/dev/en/latest/framework/logging/
- so we should make it the same. I tested locally
& this results in the smarty debugging going to a separate file (good).
I personally think we should send all the IPN files off to their
own channel but am loath to be pro-active on changing that
Eileen McNaughton [Mon, 27 Feb 2023 23:48:33 +0000 (12:48 +1300)]
Smarty notice fix on bank_account_number
Eileen McNaughton [Mon, 27 Feb 2023 23:23:23 +0000 (12:23 +1300)]
Also remove CRM_Utils_Array call
Eileen McNaughton [Mon, 27 Feb 2023 23:19:50 +0000 (12:19 +1300)]
Remove code deprecated in 2018
Eileen McNaughton [Mon, 27 Feb 2023 23:04:19 +0000 (12:04 +1300)]
Make function private
Eileen McNaughton [Mon, 27 Feb 2023 23:01:52 +0000 (12:01 +1300)]
Remove unnecessary pass-by-reference
demeritcowboy [Mon, 27 Feb 2023 21:44:16 +0000 (16:44 -0500)]
Merge pull request #25675 from eileenmcnaughton/notice_location
Remove empty on location - it should always be set now
Eileen McNaughton [Mon, 27 Feb 2023 19:56:51 +0000 (08:56 +1300)]
Remove empty on location - it should always be set now
See https://github.com/civicrm/civicrm-core/pull/25668
colemanw [Mon, 27 Feb 2023 15:34:25 +0000 (10:34 -0500)]
Merge pull request #25618 from mattwire/caserelationship
Afform: Allow selecting case for relationship
demeritcowboy [Mon, 27 Feb 2023 13:47:30 +0000 (08:47 -0500)]
Merge pull request #25668 from eileenmcnaughton/notice_location
Fix e-notice pattern around location not defined in formButtons.tpl
demeritcowboy [Mon, 27 Feb 2023 13:44:36 +0000 (08:44 -0500)]
Merge pull request #25309 from MegaphoneJon/flexmailer-return-path
closes core#4070 - respect default return path
demeritcowboy [Mon, 27 Feb 2023 13:40:03 +0000 (08:40 -0500)]
Merge pull request #25585 from herbdool/core-4127-4
dev/core#4127 move cms user parameters to userSystem
Seamus Lee [Mon, 27 Feb 2023 03:58:11 +0000 (14:58 +1100)]
Merge pull request #25671 from colemanw/viewSql
SearchKit - Clarify how to view SQL output
Coleman Watts [Mon, 27 Feb 2023 02:16:27 +0000 (21:16 -0500)]
SearchKit - Clarify how to view SQL output
Seamus Lee [Sun, 26 Feb 2023 21:24:29 +0000 (08:24 +1100)]
Merge pull request #25670 from eileenmcnaughton/cust_it
Remove unused variables
Eileen McNaughton [Tue, 21 Feb 2023 03:35:40 +0000 (16:35 +1300)]
Reply on improved exception handling for handling bad sql in import process
Show user sanitised message
Eileen McNaughton [Tue, 21 Feb 2023 02:13:46 +0000 (15:13 +1300)]
Add new \Civi\Exception\DBQueryException & throw that rather than a PEAR_ERROR
Fix api v3 handling of exception to not include the exception (fails on print_r())
m
Eileen McNaughton [Tue, 7 Feb 2023 01:58:54 +0000 (14:58 +1300)]
Remove unused variables
colemanw [Sun, 26 Feb 2023 02:42:48 +0000 (21:42 -0500)]
Merge pull request #25466 from eileenmcnaughton/sep
Remove unused property - not used since import code refactor `_lineCount`
colemanw [Sun, 26 Feb 2023 02:41:42 +0000 (21:41 -0500)]
Merge pull request #25237 from eileenmcnaughton/mem_receipt
Remove conditional assignment around `is_deductible`
colemanw [Sun, 26 Feb 2023 02:40:17 +0000 (21:40 -0500)]
Merge pull request #25621 from eileenmcnaughton/event_test_cleanup
Event test cleanup, fix test to use submitted form values, rather than require a lot of contorting
colemanw [Sun, 26 Feb 2023 02:39:39 +0000 (21:39 -0500)]
Merge pull request #25270 from eileenmcnaughton/separate
Extend testing for ContributionConfirm & consolidate `isSeparateMembershipPayment`
Tim Otten [Sat, 25 Feb 2023 04:46:58 +0000 (20:46 -0800)]
Merge pull request #25667 from eileenmcnaughton/mixin
Fix mixin to use `addTemplateDir`
Eileen McNaughton [Fri, 24 Feb 2023 22:54:41 +0000 (11:54 +1300)]
Remove (old) Smarty-forward incompatible syntax from Address.tpl
Eileen McNaughton [Fri, 24 Feb 2023 21:19:08 +0000 (10:19 +1300)]
Fix e-notice pattern around location not defined in formButtons.tpl
Eileen McNaughton [Fri, 24 Feb 2023 07:36:50 +0000 (20:36 +1300)]
Fix mixin
demeritcowboy [Fri, 24 Feb 2023 19:02:25 +0000 (14:02 -0500)]
Merge pull request #25662 from eileenmcnaughton/token_dep
Add noisy deprecation to deprecated function, after universe search
Herb v/d Dool [Wed, 15 Feb 2023 16:07:14 +0000 (11:07 -0500)]
dev/core#4127 move cms user parameters to userSystem
Seamus Lee [Fri, 24 Feb 2023 09:37:18 +0000 (20:37 +1100)]
Merge pull request #25665 from totten/master-nfc-url
(NFC) crmURL - Add examples and whitespace. Crosslink docs.
Tim Otten [Fri, 24 Feb 2023 08:14:12 +0000 (00:14 -0800)]
Merge pull request #25664 from eileenmcnaughton/tpl_fix
Remove forward incompatible syntax from template
Tim Otten [Fri, 24 Feb 2023 07:43:10 +0000 (23:43 -0800)]
crmURL - Add examples and whitespace. Crosslink docs.
Tim Otten [Fri, 24 Feb 2023 06:59:23 +0000 (22:59 -0800)]
Merge pull request #25661 from eileenmcnaughton/smarty-url
Add `crmUrl function` to smarty in the standard way
Eileen McNaughton [Fri, 24 Feb 2023 06:13:54 +0000 (19:13 +1300)]
Merge pull request #25663 from eileenmcnaughton/civix
run `civix update` on `recaptcha`, `legacyCustomSearches`, `financialacls`