Tim Otten [Wed, 15 Dec 2021 00:38:00 +0000 (16:38 -0800)]
Civi::pipe - Add top-level facade. Add E2E test.
Tim Otten [Wed, 15 Dec 2021 00:39:01 +0000 (16:39 -0800)]
Civi::pipe - JSON-RPC 2.0 session
Tim Otten [Wed, 15 Dec 2021 00:37:38 +0000 (16:37 -0800)]
Civi::pipe - Basic JSON session
Tim Otten [Wed, 15 Dec 2021 00:34:56 +0000 (16:34 -0800)]
Civi::pipe - Add some initial utilities
Eileen McNaughton [Thu, 13 Jan 2022 05:29:37 +0000 (18:29 +1300)]
Merge pull request #22496 from civicrm/5.46
5.46
colemanw [Thu, 13 Jan 2022 03:27:14 +0000 (22:27 -0500)]
Merge pull request #22443 from eileenmcnaughton/download
Remove support for deprecated key
colemanw [Thu, 13 Jan 2022 03:25:39 +0000 (22:25 -0500)]
Merge pull request #22485 from eileenmcnaughton/ab
Fully remove contactAB function
colemanw [Thu, 13 Jan 2022 03:24:55 +0000 (22:24 -0500)]
Merge pull request #22498 from eileenmcnaughton/mem_act
Don't default membership type create to inactive
Eileen McNaughton [Thu, 13 Jan 2022 02:08:56 +0000 (15:08 +1300)]
Merge pull request #22464 from colemanw/extRequirementCheck
Extensions - Add dependency status check
Eileen McNaughton [Thu, 13 Jan 2022 01:55:38 +0000 (14:55 +1300)]
Don't default membership type create to inactive
We don't do this for any other entity...
Eileen McNaughton [Thu, 13 Jan 2022 01:53:59 +0000 (14:53 +1300)]
Merge pull request #22494 from eileenmcnaughton/fin
Remove handling for impossible array
Seamus Lee [Thu, 13 Jan 2022 01:48:29 +0000 (12:48 +1100)]
Merge pull request #22490 from colemanw/refreshButton
SearchKit - Facilitate popup forms
Eileen McNaughton [Thu, 13 Jan 2022 00:57:36 +0000 (13:57 +1300)]
Merge pull request #22403 from colemanw/api4WriteRecords
[REF] Improve APIv4 save functions
Eileen McNaughton [Thu, 13 Jan 2022 00:45:02 +0000 (13:45 +1300)]
Merge pull request #22493 from eileenmcnaughton/546
Cleanup test class
Eileen McNaughton [Thu, 13 Jan 2022 00:42:19 +0000 (13:42 +1300)]
Merge pull request #22467 from colemanw/civigrantSearchKitTab
CiviGrant - Use SearchKit for contact summary tab
colemanw [Thu, 13 Jan 2022 00:31:56 +0000 (19:31 -0500)]
Merge pull request #22492 from braders/system-utils-docblock
Improve method phpdoc for CRM_Utils_System
Eileen McNaughton [Thu, 13 Jan 2022 00:11:24 +0000 (13:11 +1300)]
Remove handling for impossible array
CRM_Financial_BAO_FinancialType::buildPermissionedClause is only called from one place
outside of tests. That place passes in this->_whereClause which is the result of calling
this->whereClause() a few lines earlier. As that function always returns a string
we know that it cannot be an array & can remove the handling
Eileen McNaughton [Wed, 5 Jan 2022 22:04:10 +0000 (11:04 +1300)]
Cleanup test class
Coleman Watts [Wed, 12 Jan 2022 21:07:49 +0000 (16:07 -0500)]
crmDialog - Add convenience binding to automatically launch a dialog when clicking an element
Coleman Watts [Wed, 12 Jan 2022 21:06:33 +0000 (16:06 -0500)]
SearchKit - Auto-refresh search when popup forms submit
This expands the listener to the entire surrounding <form> element,
in case there are related popups on the Afform.
Bradley Taylor [Wed, 12 Jan 2022 22:37:43 +0000 (22:37 +0000)]
Improve method phpdoc for CRM_Utils_System
Coleman Watts [Wed, 12 Jan 2022 22:33:08 +0000 (17:33 -0500)]
CiviGrant - Ensure dependencies are installed before running tests
colemanw [Wed, 12 Jan 2022 21:02:58 +0000 (16:02 -0500)]
Merge pull request #22486 from eileenmcnaughton/rel_check
Remove always-true-if
Eileen McNaughton [Wed, 12 Jan 2022 05:06:56 +0000 (18:06 +1300)]
Remove always-true-if
We just ensured organization is numeric so .. it is
Eileen McNaughton [Wed, 12 Jan 2022 05:01:36 +0000 (18:01 +1300)]
Fully remove contactAB function
The function was a really long winded way of doing what the 3 lines do.
Universe search did not reveal other usages and it is not the
sort of function we would expect to be used by extensions so
I'm straight removing it
Seamus Lee [Wed, 12 Jan 2022 04:49:34 +0000 (15:49 +1100)]
Merge pull request #22468 from eileenmcnaughton/ab
Stop calling confusing function that doesn't do much .....
Eileen McNaughton [Wed, 12 Jan 2022 04:39:00 +0000 (17:39 +1300)]
Merge pull request #22484 from civicrm/5.46
5.46 to master
Eileen McNaughton [Wed, 12 Jan 2022 04:38:33 +0000 (17:38 +1300)]
Merge pull request #22479 from demeritcowboy/fulltext-quickfix-546
dev/core#3026 - 5.46 version of 22478
demeritcowboy [Wed, 12 Jan 2022 02:35:33 +0000 (21:35 -0500)]
quickfix for fulltext search drupal block
demeritcowboy [Wed, 12 Jan 2022 00:33:33 +0000 (19:33 -0500)]
Merge pull request #22469 from eileenmcnaughton/help
Remove seemingly unreachable help text
demeritcowboy [Wed, 12 Jan 2022 00:18:31 +0000 (19:18 -0500)]
Merge pull request #22472 from eileenmcnaughton/import
Move function to the class that 'owns' it
Eileen McNaughton [Tue, 11 Jan 2022 23:05:33 +0000 (12:05 +1300)]
Merge pull request #22451 from MegaphoneJon/member-count-fix
Crash when adding a relationship when CiviMember is disabled
Eileen McNaughton [Tue, 11 Jan 2022 20:36:19 +0000 (09:36 +1300)]
Merge pull request #22474 from braders/incoming-mail-broken-fn-reference
Fix broken function reference
Jon Goldberg [Mon, 10 Jan 2022 18:11:57 +0000 (13:11 -0500)]
fix accessing member/contribution count when not enabled
Eileen McNaughton [Tue, 11 Jan 2022 11:50:11 +0000 (00:50 +1300)]
Move function to the class that 'owns' it
Following https://github.com/civicrm/civicrm-core/commit/
f54e87d9cf1e216036adf92f744cdbac3c1fe79e#diff-5864d6a1d03dffb7699b930837c1c222b41fba16dad7d0a5f73b4923ac53dd42R198
neither of these functions are called from outside their class (I did a universe search)
so making them private (& in one case moving off the parent) means a universe seach won't be needed
next time
Eileen McNaughton [Tue, 11 Jan 2022 18:43:00 +0000 (07:43 +1300)]
Merge pull request #22473 from eileenmcnaughton/script
Remove broken script
Bradley Taylor [Tue, 11 Jan 2022 18:22:38 +0000 (18:22 +0000)]
Fix broken function reference
colemanw [Tue, 11 Jan 2022 17:07:52 +0000 (12:07 -0500)]
Merge pull request #22459 from mlutfy/core983acl
dev/core#983 Fix Access CiviCampaign permissions (instead of admin)
Eileen McNaughton [Tue, 11 Jan 2022 12:04:37 +0000 (01:04 +1300)]
Remove broken script
Eileen McNaughton [Tue, 11 Jan 2022 10:42:19 +0000 (23:42 +1300)]
Remove seemingly unreachable help text
This text is e-notice causing (with default modifiers on). I could not find the tpl file
or the potentially corresponding php file & concluded they were likely long-gone
(If I'm wrong some possibly-outdated help text disappears but I couldnt find it)
Eileen McNaughton [Tue, 11 Jan 2022 01:15:09 +0000 (14:15 +1300)]
Stop calling confusing function that doesn't do much .....
Seamus Lee [Tue, 11 Jan 2022 06:11:47 +0000 (17:11 +1100)]
Merge pull request #22448 from mattwire/recurid
Simplify getting contact_id from recurring contribution when generating subscription URLs
Seamus Lee [Tue, 11 Jan 2022 04:54:14 +0000 (15:54 +1100)]
Merge pull request #22456 from eileenmcnaughton/legt
Remove & deprecate silly function
Coleman Watts [Mon, 10 Jan 2022 01:24:12 +0000 (20:24 -0500)]
CiviGrant - Use SearchKit for contact summary tab
Eileen McNaughton [Tue, 11 Jan 2022 02:09:27 +0000 (15:09 +1300)]
Merge pull request #22064 from colemanw/civigrant
Migrate CiviGrant component to an extension
Eileen McNaughton [Tue, 11 Jan 2022 01:40:45 +0000 (14:40 +1300)]
Merge pull request #22264 from sunilpawar/dev_recurring_error
Fix Fatal Error on contribution tab and user dashboard when recurring payment generated using extension get disabled
Seamus Lee [Tue, 11 Jan 2022 01:38:57 +0000 (12:38 +1100)]
Merge pull request #22462 from eileenmcnaughton/inv2
Remove unused variable
Eileen McNaughton [Mon, 10 Jan 2022 19:33:14 +0000 (08:33 +1300)]
Remove & deprecate silly function
This function just calls another function & it's slightly MORE complicted to call that then the function
it calls - deprecate it....
Eileen McNaughton [Tue, 11 Jan 2022 01:08:02 +0000 (14:08 +1300)]
Merge pull request #22455 from eileenmcnaughton/legg
Remove IF that only loops through one value
colemanw [Tue, 11 Jan 2022 00:38:10 +0000 (19:38 -0500)]
Merge pull request #22421 from eileenmcnaughton/tax
Replace all isset checks on line.tax_rate
Eileen McNaughton [Tue, 11 Jan 2022 00:15:06 +0000 (13:15 +1300)]
Merge pull request #22453 from braders/autorespond-failure
Fix syntax error in CRM_Mailing_Event_BAO_Reply
Seamus Lee [Mon, 10 Jan 2022 23:14:48 +0000 (10:14 +1100)]
Merge pull request #22313 from mlutfy/eventDefaultUrlValues
Event Registration: allow default Price Set values from the URL
Coleman Watts [Mon, 10 Jan 2022 22:48:03 +0000 (17:48 -0500)]
Extensions - Add dependency status check
Adds a system status check to ensure extension dependencies are met
colemanw [Mon, 10 Jan 2022 21:34:50 +0000 (16:34 -0500)]
Merge pull request #22457 from eileenmcnaughton/label
Mark function as private
Eileen McNaughton [Mon, 10 Jan 2022 21:32:56 +0000 (10:32 +1300)]
Remove unused variable
Eileen McNaughton [Mon, 10 Jan 2022 21:29:39 +0000 (10:29 +1300)]
Merge pull request #22460 from civicrm/5.46
5.46
Seamus Lee [Mon, 10 Jan 2022 21:24:00 +0000 (08:24 +1100)]
Merge pull request #22445 from eileenmcnaughton/546
Use field value function to get html signature
Coleman Watts [Thu, 6 Jan 2022 22:46:10 +0000 (17:46 -0500)]
APIv4 - Refactor writeObjects to choose BAO function based on annotations
Instead of using a hardcoded list of BAO functions to call, with extra
hardcoded params to e.g. the Contact & Address BAOs, this switches
to picking the BAO's create/add only if it's not `@deprecated`,
and falling back to WriteRecords.
Also refactors the large `writeObjects` function into two smaller
functions so individual action classes can more easily override them.
Eileen McNaughton [Mon, 10 Jan 2022 21:14:47 +0000 (10:14 +1300)]
Merge pull request #22454 from braders/phpdoc-types
A whole bunch of phpdoc fixes
Mathieu Lutfy [Mon, 10 Jan 2022 21:06:33 +0000 (16:06 -0500)]
dev/core#983 Fix Access CiviCampaign permissions (instead of admin)
Eileen McNaughton [Sat, 8 Jan 2022 07:50:21 +0000 (20:50 +1300)]
Ensure tax is set when it comes form Order BAO
Eileen McNaughton [Sat, 8 Jan 2022 03:53:00 +0000 (16:53 +1300)]
Replace all isset checks on line.tax_rate
It is actually always set here
https://github.com/civicrm/civicrm-core/blob/
64f4eebe75dbaeb429abcaa4dfca90094ce8be20/CRM/Price/BAO/LineItem.php#L246-L253
Eileen McNaughton [Mon, 10 Jan 2022 19:22:14 +0000 (08:22 +1300)]
Remove IF that only loops through one value
Eileen McNaughton [Mon, 10 Jan 2022 19:47:38 +0000 (08:47 +1300)]
Mark function as private
I did a universe search & this is not called outside this class (the
one on the LabelCommon class is called from one place outside that class
Bradley Taylor [Mon, 10 Jan 2022 19:13:26 +0000 (19:13 +0000)]
A whole bunch of phpdoc fixes
Bradley Taylor [Mon, 10 Jan 2022 18:29:24 +0000 (18:29 +0000)]
Fix syntax error in CRM_Mailing_Event_BAO_Reply
Coleman Watts [Fri, 7 Jan 2022 20:37:07 +0000 (15:37 -0500)]
CiviGrant - Regenerate SQL
Coleman Watts [Mon, 15 Nov 2021 17:09:12 +0000 (12:09 -0500)]
CiviGrant - Install extension + managed entities during upgrade
Disable & delete component, install extension as either "enabled" or "disabled" depending on the status of the component.
Migrate option values to managed entities
Migrate navigation menu to extension managed entities
Coleman Watts [Thu, 18 Nov 2021 21:56:18 +0000 (16:56 -0500)]
CiviGrant - Migrate legacy search query code
This fixes up the `CRM_Contact_BAO_Query_Interface` class which had incorrectly
omitted `static` from some static functions.
Adds defaultReurnProperties to search hook interface.
Coleman Watts [Thu, 18 Nov 2021 21:54:17 +0000 (16:54 -0500)]
CiviGrant - Remove or mitigate hardcoded references to civicrm_grant table in core
Removes CiviGrant from hardcoded lists when possible, or at least puts up
guards to check that it's available before attempting to use it.
Coleman Watts [Thu, 18 Nov 2021 00:35:55 +0000 (19:35 -0500)]
CiviGrant - Move unit tests
Coleman Watts [Fri, 12 Nov 2021 20:27:26 +0000 (15:27 -0500)]
CiviGrant - Move report files
Coleman Watts [Fri, 12 Nov 2021 19:45:16 +0000 (14:45 -0500)]
CiviGrant - Migrate schema files
Insert and then delete CiviGrant to avoid messing up legacy code with expectations of component IDs.
Coleman Watts [Fri, 12 Nov 2021 14:44:26 +0000 (09:44 -0500)]
CiviGrant - Migrate component functions to hooks
Coleman Watts [Fri, 12 Nov 2021 14:30:29 +0000 (09:30 -0500)]
CiviGrant - Move CRM & API code from core to extension
Coleman Watts [Fri, 12 Nov 2021 14:22:57 +0000 (09:22 -0500)]
Generate CiviGrant extension
colemanw [Mon, 10 Jan 2022 13:28:40 +0000 (08:28 -0500)]
Merge pull request #22439 from eileenmcnaughton/legt
Simplify variables pass in & out of function
colemanw [Mon, 10 Jan 2022 13:26:20 +0000 (08:26 -0500)]
Merge pull request #22447 from eileenmcnaughton/legg
Remove if & foreach that no longer do anything
colemanw [Mon, 10 Jan 2022 13:24:22 +0000 (08:24 -0500)]
Merge pull request #22446 from eileenmcnaughton/php4
Remove call to php 4 function
Matthew Wire [Mon, 10 Jan 2022 12:43:08 +0000 (12:43 +0000)]
Simplify getting contact_id from recurring contribution
Eileen McNaughton [Sun, 9 Jan 2022 23:52:45 +0000 (12:52 +1300)]
Simplify variables pass in & out of function
Rather than compiling an array, pass in the 3 values. Also
its now obvious that there is only a max of 1 contact_check in the function
so just return rather than 'continuing' (allowing us to de-loop in a more
whitespacey follow up)
Eileen McNaughton [Mon, 10 Jan 2022 03:21:41 +0000 (16:21 +1300)]
Remove if & foreach that no longer do anything
Eileen McNaughton [Mon, 10 Jan 2022 03:14:50 +0000 (16:14 +1300)]
Remove call to php 4 function
This CRM-2122 seems to be php4 thing - it won't exist anymore
https://php.uz/manual/en/function.fribidi-log2vis.php
Eileen McNaughton [Mon, 10 Jan 2022 02:37:23 +0000 (15:37 +1300)]
Use field value function to get html signature
The function is used for all other tokens on the contact object and will better access
the right value and return an empty string rather NULL if not set.
I hit this as an enotice writing a test - but it is possibly the cause of this issue
https://github.com/eileenmcnaughton/nz.co.fuzion.civitoken/issues/58#issuecomment-
966611004
hence targetting the rc
The tokens() function does weird things if you pass it NULL
Seamus Lee [Mon, 10 Jan 2022 02:30:52 +0000 (13:30 +1100)]
Merge pull request #22440 from eileenmcnaughton/legg
Clean up input and outputs
colemanw [Mon, 10 Jan 2022 01:56:55 +0000 (20:56 -0500)]
Merge pull request #22441 from civicrm/5.46
5.46
Eileen McNaughton [Mon, 10 Jan 2022 01:27:28 +0000 (14:27 +1300)]
Remove support for deprecated key
downloadUrl causes notices when default modifier is on.
It turns out is was deprecated approximately 2 forevers ago
https://docs.civicrm.org/dev/en/latest/extensions/info-xml/#downloadUrl
colemanw [Mon, 10 Jan 2022 00:40:09 +0000 (19:40 -0500)]
Merge pull request #22435 from colemanw/subscriptionHistory
APIv4 - Add SubscriptionHistory entity
colemanw [Mon, 10 Jan 2022 00:39:19 +0000 (19:39 -0500)]
Merge pull request #22436 from eileenmcnaughton/noticeme
Enotice fix
Eileen McNaughton [Mon, 10 Jan 2022 00:25:54 +0000 (13:25 +1300)]
Merge pull request #22437 from MegaphoneJon/broken-search-urls
fixes report#93: SearchKit shows broken external URLs
demeritcowboy [Mon, 10 Jan 2022 00:02:40 +0000 (19:02 -0500)]
Merge pull request #22429 from colemanw/fixMoneyType2
Fix input type for smarty number formatting (more forgiving)
Eileen McNaughton [Mon, 10 Jan 2022 00:01:30 +0000 (13:01 +1300)]
Clean up input and outputs
By grepping universe we can see that params['contact_check'] only ever has one value when called
from the supported core place and the unsupported jma grant application extension place.
By clarifying that here we can do further cleanup without having to re-search universe...
Eileen McNaughton [Sun, 9 Jan 2022 23:43:55 +0000 (12:43 +1300)]
Merge pull request #22428 from civicrm/5.46
5.46
Eileen McNaughton [Sun, 9 Jan 2022 23:30:00 +0000 (12:30 +1300)]
Merge pull request #20884 from MegaphoneJon/financial-89
don't allow multiple currencies in a batch
Seamus Lee [Sun, 9 Jan 2022 23:06:12 +0000 (10:06 +1100)]
Merge pull request #22431 from eileenmcnaughton/leg
[REF] Rename variable to be meaningful
Jon Goldberg [Sun, 9 Jan 2022 22:48:33 +0000 (17:48 -0500)]
fixes report#93: SearchKit shows broken external URLs
Eileen McNaughton [Sun, 9 Jan 2022 22:39:58 +0000 (11:39 +1300)]
Enotice fix
Coleman Watts [Sun, 9 Jan 2022 22:27:33 +0000 (17:27 -0500)]
APIv4 - Add SubscriptionHistory entity
Coleman Watts [Sat, 8 Jan 2022 22:10:02 +0000 (17:10 -0500)]
Fix input type for smarty number formatting
Some smarty templates pass NULL to crmMoney, so it needs to handle that possibilty
Eileen McNaughton [Sun, 9 Jan 2022 22:06:54 +0000 (11:06 +1300)]
Merge pull request #22430 from colemanw/navigationDefaults
Navigation - Make required fields NOT NULL