Eileen McNaughton [Wed, 17 May 2023 21:33:26 +0000 (09:33 +1200)]
Merge pull request #26253 from civicrm/5.62
5.62
Eileen McNaughton [Wed, 17 May 2023 21:13:56 +0000 (09:13 +1200)]
Merge pull request #26252 from demeritcowboy/missing-help
Import help text gone missing
demeritcowboy [Wed, 17 May 2023 20:42:36 +0000 (16:42 -0400)]
help gone missing
demeritcowboy [Wed, 17 May 2023 18:01:53 +0000 (14:01 -0400)]
Merge pull request #26249 from larssandergreen/Remove-old-form-rule-on-/-in-page-titles-for-paypal
Remove form rule for Contribution Page and Event titles preventing /
demeritcowboy [Wed, 17 May 2023 17:59:01 +0000 (13:59 -0400)]
Merge pull request #26234 from eileenmcnaughton/deceased_token
Add deceased date token
larssandergreen [Wed, 17 May 2023 16:17:51 +0000 (10:17 -0600)]
Remove form rule for titles preventing /
colemanw [Wed, 17 May 2023 13:56:10 +0000 (09:56 -0400)]
Merge pull request #26244 from eileenmcnaughton/weight_linke
Add weight to a couple more links
Eileen McNaughton [Wed, 17 May 2023 09:17:46 +0000 (21:17 +1200)]
Add weight to a couple more links
Eileen McNaughton [Wed, 17 May 2023 08:03:39 +0000 (20:03 +1200)]
Merge pull request #26241 from eileenmcnaughton/weight
Add some weights to menu link items
Eileen McNaughton [Wed, 17 May 2023 04:53:15 +0000 (16:53 +1200)]
Fix test to expect delete last
Also has some fixes to get away from undeclared property issues on
touched test & helpers
Eileen McNaughton [Wed, 17 May 2023 03:26:51 +0000 (15:26 +1200)]
Adjust weights so link order is inchanged
Eileen McNaughton [Tue, 16 May 2023 22:32:20 +0000 (10:32 +1200)]
Add some weights
Eileen McNaughton [Tue, 16 May 2023 06:42:02 +0000 (18:42 +1200)]
Add deceased date token
Per https://github.com/eileenmcnaughton/nz.co.fuzion.civitoken/issues/63
Eileen McNaughton [Wed, 17 May 2023 04:58:38 +0000 (16:58 +1200)]
Merge pull request #26242 from civicrm/5.62
5.62
Seamus Lee [Wed, 17 May 2023 04:04:02 +0000 (14:04 +1000)]
Merge pull request #26193 from eileenmcnaughton/member
Fix code handling to pre-5.61 for membership block
colemanw [Wed, 17 May 2023 03:06:55 +0000 (23:06 -0400)]
Merge pull request #26240 from civicrm/5.62
5.62
Seamus Lee [Wed, 17 May 2023 01:01:26 +0000 (11:01 +1000)]
Merge pull request #26239 from totten/5.62-uninstall
setup - Fix uninstall on MySQL 8.0
colemanw [Wed, 17 May 2023 00:24:02 +0000 (20:24 -0400)]
Merge pull request #26233 from eileenmcnaughton/weight
Add weight to links spec
Tim Otten [Tue, 16 May 2023 23:56:18 +0000 (16:56 -0700)]
setup - Fix uninstall on MySQL 8.0
Overview
--------
Fix a bug with uninstalling or reinstalling via cv (`cv core:uninstall` or `cv core:install -f`) on MySQL 8.0.
Before
------
On MySQL 8.0, it fails - because all table-names appear as null.
It's looking for a result column named `table_name` but actually receives `TABLE_NAME`.
After
-----
Doesn't matter if the column is called `table_name` or `TABLE_NAME`.
Eileen McNaughton [Tue, 16 May 2023 23:25:20 +0000 (11:25 +1200)]
Merge pull request #26238 from eileenmcnaughton/part_public
Notice fix on edit Household
Eileen McNaughton [Tue, 16 May 2023 22:33:39 +0000 (10:33 +1200)]
Notice fix on edit Household
Eileen McNaughton [Tue, 16 May 2023 06:14:39 +0000 (18:14 +1200)]
Add weight to links spec
This allows a weight to be set & for it to alter the order.
It is a bit hard to know whether to add weights to existing ones as
it would be a lot to do all of them - but I did hear a specific request
(can't recall who from) to have Delete last to reduce mis-clicks
and with the View & Edit declared in the same place
I felt I should add them with low values for some sort of consistency
This would mess with people who have implemented weight in a hook - but
probably any change is low impact & an easy-ish fix
Note that I will update docs once agreed
colemanw [Tue, 16 May 2023 16:23:15 +0000 (12:23 -0400)]
Merge pull request #26235 from ufundo/getsearchtasks-qfkey-for-page-callback
dev/core#4295 SearchKit: check controller class for qfKey when loading legacy search actions for contributions
benjamin [Tue, 16 May 2023 15:02:31 +0000 (16:02 +0100)]
check route callback for generating qfkey
colemanw [Tue, 16 May 2023 15:04:01 +0000 (11:04 -0400)]
Merge pull request #26214 from larssandergreen/Improve-slow-download-from-SearchKit-results
Speed up Download Spreadsheet from SearchKit results
larssandergreen [Tue, 16 May 2023 14:18:53 +0000 (08:18 -0600)]
Improve-slow-download-from-SearchKit-results
Eileen McNaughton [Tue, 16 May 2023 06:49:00 +0000 (18:49 +1200)]
Merge pull request #26230 from colemanw/contributionUpgrade
Upgrader - Use generic (non-api4) code in upgrader
colemanw [Tue, 16 May 2023 01:30:32 +0000 (21:30 -0400)]
Upgrader - Use generic (non-api4) code in upgrader
This was causing issues with https://github.com/civicrm/civicrm-core/pull/26208
because the Contribution API is no longer available without enabling the
civi_contribute extension, which doesn't happen until a later upgrade step.
colemanw [Tue, 16 May 2023 02:11:54 +0000 (22:11 -0400)]
Merge pull request #26068 from colemanw/arrayOperators
dev/core#1321 - SearchKit - Limit operator list for array fields
Matthew Wire [Mon, 15 May 2023 19:48:37 +0000 (20:48 +0100)]
Merge pull request #26223 from eileenmcnaughton/participant_sent
Clarify sent & not sent variables
demeritcowboy [Mon, 15 May 2023 15:42:43 +0000 (11:42 -0400)]
Merge pull request #26225 from olayiwola-compucorp/addNameToContributor
Added Olayiwola Odunsi to contributor-key.yml
olayiwola-compucorp [Mon, 15 May 2023 14:51:19 +0000 (15:51 +0100)]
Added Olayiwola Odunsi to contributor-key.yml
demeritcowboy [Mon, 15 May 2023 14:40:24 +0000 (10:40 -0400)]
Merge pull request #26196 from seamuslee001/skip_vendor_old_files_non_civi_vendor
[REF] dev/core#1777 - Skip checking vendor provided orphaned files if the vendor directory is not within the CiviCRM root
demeritcowboy [Mon, 15 May 2023 14:38:23 +0000 (10:38 -0400)]
Merge pull request #26145 from olayiwola-compucorp/changeContributionDateLabel
dev/core#1403 - CRM/Contribute - Change "Date Received" to "Contribution Date"
Eileen McNaughton [Mon, 15 May 2023 13:20:59 +0000 (01:20 +1200)]
Clarify send & not sent variables
Its silly to pass an array around just to have it finally counted...
Matthew Wire [Mon, 15 May 2023 12:37:53 +0000 (13:37 +0100)]
Merge pull request #26221 from eileenmcnaughton/part_public
Make some internal functions protected
Matthew Wire [Mon, 15 May 2023 12:35:40 +0000 (13:35 +0100)]
Merge pull request #26220 from eileenmcnaughton/crazy_test_4
Fix Participant tests to use full form flow
olayiwola-compucorp [Mon, 15 May 2023 07:31:51 +0000 (08:31 +0100)]
dev/core#1403 - CRM/Contribute - Change "Date Received" to "Contribution Date"
Yashodha Chaku [Mon, 15 May 2023 06:39:36 +0000 (12:09 +0530)]
Merge pull request #26222 from eileenmcnaughton/extract
Remove unreachable validation
Eileen McNaughton [Mon, 15 May 2023 03:53:09 +0000 (15:53 +1200)]
Add getParticipantID to avoid non-php8-friendly path check
This particular fail is due to the path being empy in the test environment - But
it's wrong to check it as it is a crufty check for whether
the search task is being used
Eileen McNaughton [Mon, 15 May 2023 04:09:45 +0000 (16:09 +1200)]
Remove unreachable validation
Some time ago we fixed it such that only Pending and Completed statuses are in
the drop box for contribution_status_id. This fragment of code handles an edge case
that is no longer reachable - ie when the value is Failed and some other confusing stuff
is true
Eileen McNaughton [Mon, 15 May 2023 00:47:19 +0000 (12:47 +1200)]
Fix Participant tests to use full form flow
This doesn't get all of them but fixes a bunch
Eileen McNaughton [Sun, 14 May 2023 23:28:31 +0000 (11:28 +1200)]
Improve fromEmail address handling
We don't need to validate the from Email address in the postProcess as the
form submit validation expects it to be a supplied value.
Fixing this makes testing easier
Eileen McNaughton [Mon, 15 May 2023 00:42:38 +0000 (12:42 +1200)]
Improve test consistency on capitalisation
Eileen McNaughton [Mon, 15 May 2023 01:28:37 +0000 (13:28 +1200)]
Merge pull request #26217 from eileenmcnaughton/crazy_test
Minor cleanup on function
Eileen McNaughton [Mon, 15 May 2023 01:14:56 +0000 (13:14 +1200)]
Make some internal functions protected
I did a universe search to be sure but these 'belong' to the form
Eileen McNaughton [Sun, 14 May 2023 23:07:16 +0000 (11:07 +1200)]
Minor cleanup on function
The primary goal here was to check that it ALWAYS returns an array. It does,
so I added a type hint.
I also confirmed that
- it is not called from universe
- it is not called with no primaryParticipantID
- it is not called with excludeCancel set for false
so I did some deprecating.
Lastly there was code to handle there being no cancelStatus -
assigning a variable cancelID of 0 as a fallback. But, it
was not being used - so I fixed it to cast-to-int.
demeritcowboy [Sat, 13 May 2023 18:41:46 +0000 (14:41 -0400)]
Merge pull request #26213 from dontub/AbstractAction-drop-throws-phpdoc
AbstractAction: Drop `@throws` from phpdoc of `__construct()` because it's not thrown
Dominic Tubach [Sat, 13 May 2023 17:18:38 +0000 (19:18 +0200)]
AbstractAction: Drop `@throws` from phpdoc of `__construct()` because it's not thrown
Eileen McNaughton [Sat, 13 May 2023 03:14:17 +0000 (15:14 +1200)]
Merge pull request #26210 from civicrm/5.62
5.62
Matthew Wire [Fri, 12 May 2023 21:49:33 +0000 (22:49 +0100)]
Merge pull request #26205 from eileenmcnaughton/event_backoffice
Further separate register task from participant form
Matthew Wire [Fri, 12 May 2023 21:49:01 +0000 (22:49 +0100)]
Merge pull request #26209 from larssandergreen/Don't-show-send-confirmation-description-if-registering-multiple
Don't show send broken confirmation description if registering multiple contacts
larssandergreen [Fri, 12 May 2023 21:08:40 +0000 (15:08 -0600)]
Don't show send confirmation description if registering multiple
Matthew Wire [Fri, 12 May 2023 18:01:54 +0000 (19:01 +0100)]
Merge pull request #26206 from eileenmcnaughton/event_mail
Extract sendEmail function
Yashodha Chaku [Fri, 12 May 2023 12:22:35 +0000 (17:52 +0530)]
Merge pull request #26172 from eileenmcnaughton/562_import
dev/core#4227 Fix import to not blank birth_date etc on update
Yashodha Chaku [Fri, 12 May 2023 12:20:00 +0000 (17:50 +0530)]
Merge pull request #26204 from eileenmcnaughton/deprecated
Add missing deprecated tag
Tim Otten [Fri, 12 May 2023 07:54:26 +0000 (00:54 -0700)]
Merge pull request #26036 from colemanw/componentExtensions
dev/core#3961 Create stub extensions for all components
Eileen McNaughton [Fri, 12 May 2023 05:02:32 +0000 (17:02 +1200)]
Extract sendEmail function
This is a straight forward extraction
There is test cover
Eileen McNaughton [Fri, 12 May 2023 04:40:22 +0000 (16:40 +1200)]
Further separate register task from participant form
Coleman Watts [Thu, 27 Apr 2023 21:01:57 +0000 (17:01 -0400)]
Component Extensions - Fix upgrade and test errors
Coleman Watts [Thu, 27 Apr 2023 00:26:49 +0000 (20:26 -0400)]
Component/Extensions - Remove unnecessary cache clearing and prevent recursion
Ensure the cached settings are updated _before_ post_change hooks are called for settings.
All the cache clears being performed by on_change hooks were redundant with what happens when
extensions are enabled/disabled so I removed it.
Also moved the extension install hook to use postInstall which should be more stable, and
added checks in onToggleComponents to prevent recursion.
Coleman Watts [Tue, 11 Apr 2023 01:31:59 +0000 (21:31 -0400)]
Add test for component-extension lifecycle
Coleman Watts [Mon, 10 Apr 2023 16:01:32 +0000 (12:01 -0400)]
Sync enable/disable status of component extensions with core components
Eileen McNaughton [Thu, 11 May 2023 23:44:08 +0000 (11:44 +1200)]
Remove missing deprecated tag
Eileen McNaughton [Thu, 11 May 2023 23:36:02 +0000 (11:36 +1200)]
Merge pull request #26203 from eileenmcnaughton/reg_vars
Remove unused constants
Eileen McNaughton [Thu, 11 May 2023 22:55:29 +0000 (10:55 +1200)]
Remove unused constant
Seamus Lee [Thu, 11 May 2023 21:33:53 +0000 (07:33 +1000)]
Merge pull request #26202 from pradpnayak/extcleanup
flexmailer remove cruft code
demeritcowboy [Thu, 11 May 2023 20:30:25 +0000 (16:30 -0400)]
Merge pull request #26201 from civicrm/5.62
5.62
Pradeep Nayak [Thu, 11 May 2023 18:11:34 +0000 (19:11 +0100)]
flexmailer remove cruft code
demeritcowboy [Thu, 11 May 2023 18:11:29 +0000 (14:11 -0400)]
Merge pull request #26199 from pradpnayak/fatalerror
Regression: Fatal error when importing membership
Pradeep Nayak [Thu, 11 May 2023 17:22:58 +0000 (18:22 +0100)]
Fixed fatal error when importing membership
Coleman Watts [Sun, 9 Apr 2023 03:09:12 +0000 (23:09 -0400)]
Add stub extensions for all components
Eileen McNaughton [Thu, 11 May 2023 06:34:34 +0000 (18:34 +1200)]
Merge pull request #26195 from totten/master-esm
dev/core#4279 - Add support for ECMAScript Modules (ESM, part 1)
Eileen McNaughton [Thu, 11 May 2023 03:56:52 +0000 (15:56 +1200)]
Fix capitalization in comments
Eileen McNaughton [Thu, 11 May 2023 02:45:15 +0000 (14:45 +1200)]
add more esms
Tim Otten [Thu, 11 May 2023 02:05:10 +0000 (19:05 -0700)]
(NFC) Emphasize abbreviation "ESM"
colemanw [Thu, 11 May 2023 01:44:04 +0000 (21:44 -0400)]
Merge pull request #26192 from MegaphoneJon/entity-ref-joins
proper EntityRef joins
Seamus Lee [Thu, 11 May 2023 01:39:27 +0000 (11:39 +1000)]
[REF] Skip checking vendor provided orphened files if the vendor directory is not within the CiviCRM root
Seamus Lee [Thu, 11 May 2023 00:16:59 +0000 (10:16 +1000)]
Merge pull request #26194 from larssandergreen/Ttile-case-all-of-Support-menu
Title case Register Your Site in support menu
larssandergreen [Wed, 10 May 2023 23:39:27 +0000 (17:39 -0600)]
Title case Register Your Site in support menu
Eileen McNaughton [Wed, 10 May 2023 23:38:11 +0000 (11:38 +1200)]
Fix code handling to pre-5.61 for membership block
The work for #26170 concluded that membershipPriceset is always TRUE
at this point. Since we were pushing out a regression fix I left the
variable where it didn't seem to be causing regressions.
However, I think clarifying the variable and
removing the redundant if-else in the rc will set us up well as
1) if there is any further regression we haven't found in
5.61 then people will be able to check on the rc / master
2) if we need to do any further fixes / back-ports the
code will be more synced if we do this in the rc
Note there is some further clean up I feel should be done
folloiwng what we learnt dealing with #26170 - but
I want to let the dust settle so that I'm not creating a
hard-to-backport situation
Tim Otten [Fri, 5 May 2023 07:42:37 +0000 (00:42 -0700)]
Resources - Define helper methods `addModule()`, `addModuleFile()`, `addModuleUrl()`
Tim Otten [Fri, 5 May 2023 05:36:08 +0000 (22:36 -0700)]
CRM_Core_Region::add() - Allow JS resources to be flaged as ES5 modules (`esm=>TRUE`)
Jon Goldberg [Wed, 10 May 2023 18:55:30 +0000 (14:55 -0400)]
proper EntityRef joins
demeritcowboy [Wed, 10 May 2023 20:00:05 +0000 (16:00 -0400)]
Merge pull request #26191 from larssandergreen/Uncheck-is_email_receipt-when-hidden-on-New-Contribution
Uncheck is_email_receipt when hidden on New Contribution
larssandergreen [Wed, 10 May 2023 15:50:06 +0000 (09:50 -0600)]
Uncheck is_email_receipt when hidden
Eileen McNaughton [Wed, 10 May 2023 04:21:41 +0000 (16:21 +1200)]
Merge pull request #26184 from reflexive-communications/crmMailingAB-error
crmMailingAB/services: catch exception, report error and rethrow
Eileen McNaughton [Tue, 9 May 2023 22:36:42 +0000 (10:36 +1200)]
Merge pull request #26178 from stesi561/drupalconfig
Fix config is null on hooks
Eileen McNaughton [Tue, 9 May 2023 22:20:49 +0000 (10:20 +1200)]
Merge pull request #26189 from larssandergreen/Prevent-self-service-cancellation-when-prohibited-by-using-back-office-url
Prevent prohibited self service cancellation by using is_backoffice=1 in URL
Eileen McNaughton [Tue, 9 May 2023 22:12:43 +0000 (10:12 +1200)]
Merge pull request #26188 from larssandergreen/Fix-authorization-failed-on-self-service-participant-transfer
Fix authorization failed on self-service participant transfer
Eileen McNaughton [Tue, 9 May 2023 21:55:19 +0000 (09:55 +1200)]
Merge pull request #26187 from larssandergreen/Preserve-participant-status-when-transfering
Preserve participant status when transferring
larssandergreen [Tue, 9 May 2023 21:33:34 +0000 (15:33 -0600)]
Prevent unauthorized self-service participant update via URL
larssandergreen [Tue, 9 May 2023 20:57:29 +0000 (14:57 -0600)]
Fix authorization failed on self-service participant transfer
larssandergreen [Tue, 9 May 2023 20:40:52 +0000 (14:40 -0600)]
Preserve participant status on transfer
demeritcowboy [Tue, 9 May 2023 15:30:41 +0000 (11:30 -0400)]
Merge pull request #26181 from mattwire/confirmeventmsg
Show/hide billing name/address on event confirm based on if they're set instead of a magical collection of booleans
Sandor Semsey [Tue, 9 May 2023 15:26:47 +0000 (17:26 +0200)]
crmMailingAB/services: catch exception, report error and rethrow
Matthew Wire [Tue, 9 May 2023 13:06:25 +0000 (14:06 +0100)]
Merge pull request #26123 from colemanw/afformValidate
Afform - Ensure checkboxes and radios are validated client-side
Matthew Wire [Tue, 9 May 2023 12:49:47 +0000 (13:49 +0100)]
Show/hide billing name/address on event confirm based on if they're set instead of a magical collection of booleans
Yashodha Chaku [Tue, 9 May 2023 08:09:57 +0000 (13:39 +0530)]
Merge pull request #26167 from larssandergreen/imrpove-footer-and-support-menu
dev/core#3920 Improve footer and support menu
Luke Stewart [Tue, 9 May 2023 01:22:15 +0000 (13:22 +1200)]
Fix config is null on hooks