Eileen McNaughton [Wed, 23 Nov 2022 22:07:06 +0000 (11:07 +1300)]
Merge pull request #25036 from colemanw/renameFinancialTypeAccount
EntityFinancialAccount - A tale of two BAO classes
Eileen McNaughton [Wed, 23 Nov 2022 20:40:48 +0000 (09:40 +1300)]
Merge pull request #24992 from aydun/messagetemplate_schema_changes
Messagetemplate schema changes
Coleman Watts [Wed, 23 Nov 2022 20:22:45 +0000 (15:22 -0500)]
APIv3 - Don't use deprecated del() methods
This follows the same pattern as the create action - to only use BAO methods if they are not @deprecated.
Note that APIv4 already does this in the DAODeleteAction class.
Coleman Watts [Wed, 23 Nov 2022 16:58:34 +0000 (11:58 -0500)]
Alias CRM_Financial_BAO_FinancialTypeAccount -> CRM_Financial_BAO_EntityFinancialAccount
This BAO class did not follow the standard naming convention which effectively made it invisible to the API.
Why was named this way in the first place was never explained, I suspect it was simply a mistake.
A BAO class actually did get added before this PR, in
37c608f6e which further added to the confusion.
This consolidates the two classes.
Because it was an "invisible" BAO class, the create and del functions were never used by the API.
For consistency, I've therefore tagged them as @deprecated which keeps them hidden from the API.
We can add business logic back in as needed using hook listeners.
Eileen McNaughton [Wed, 23 Nov 2022 20:10:31 +0000 (09:10 +1300)]
Merge pull request #24982 from colemanw/renameMailing
Mailing - Rename DAO files for better short names
demeritcowboy [Wed, 23 Nov 2022 18:09:56 +0000 (13:09 -0500)]
Merge pull request #25035 from demeritcowboy/stat
afform/oauth-client - don't call stat on null
demeritcowboy [Wed, 23 Nov 2022 18:09:45 +0000 (13:09 -0500)]
Merge pull request #25034 from civicrm/5.56
5.56
Aidan Saunders [Wed, 23 Nov 2022 16:50:15 +0000 (16:50 +0000)]
Add `master_id` calculated field
Add tet for `master_id`
demeritcowboy [Wed, 23 Nov 2022 16:02:07 +0000 (11:02 -0500)]
don't call stat on null
demeritcowboy [Wed, 23 Nov 2022 15:36:14 +0000 (10:36 -0500)]
Merge pull request #24996 from totten/5.56-locale-uf-test
(dev/core#3979) Localization - Assign a locale for UF during negotiation
demeritcowboy [Wed, 23 Nov 2022 15:34:59 +0000 (10:34 -0500)]
Merge pull request #25012 from colemanw/civiMenuCleanup
Menubar - Fix buggy, slow loader
colemanw [Wed, 23 Nov 2022 15:21:55 +0000 (10:21 -0500)]
Merge pull request #25024 from aydun/bao_del_mailingab
Deprecate `CRM_Mailing_BAO_MailingAB::del()`
colemanw [Wed, 23 Nov 2022 15:18:17 +0000 (10:18 -0500)]
Merge pull request #25032 from eileenmcnaughton/tokens
Update location tokens for Contact to new apiv4 style
Eileen McNaughton [Tue, 22 Nov 2022 01:44:03 +0000 (14:44 +1300)]
Update location tokens for Contact to new apiv4 style
Seamus Lee [Tue, 22 Nov 2022 23:27:49 +0000 (10:27 +1100)]
Merge pull request #25031 from MegaphoneJon/default-token-filter
default token filter
Jon Goldberg [Tue, 22 Nov 2022 21:29:26 +0000 (16:29 -0500)]
default token filter
Eileen McNaughton [Tue, 22 Nov 2022 21:27:20 +0000 (10:27 +1300)]
Merge pull request #25029 from christopher-yu/master
ajax batchSave() method should be static, php8 compatibility
demeritcowboy [Tue, 22 Nov 2022 21:06:40 +0000 (16:06 -0500)]
Merge pull request #25027 from civicrm/5.56
5.56
Seamus Lee [Tue, 22 Nov 2022 20:41:52 +0000 (07:41 +1100)]
Merge pull request #25006 from aydun/bao_del
More del() deprecations in favour of standard deleteRecord()
cyu [Tue, 22 Nov 2022 19:42:33 +0000 (11:42 -0800)]
ajax batchSave() method should be static, php8 compatibility
demeritcowboy [Tue, 22 Nov 2022 18:16:15 +0000 (13:16 -0500)]
Merge pull request #25022 from eileenmcnaughton/tokens
Cleanup in test class
demeritcowboy [Tue, 22 Nov 2022 17:51:10 +0000 (12:51 -0500)]
Merge pull request #25025 from mlutfy/fixAnonEventReg
Fix Authorization failed on Event Registration - 5.56 RC regression
Mathieu Lutfy [Tue, 22 Nov 2022 14:42:39 +0000 (09:42 -0500)]
Fix Authorization failed on Event Registration
Aidan Saunders [Tue, 22 Nov 2022 12:41:42 +0000 (12:41 +0000)]
Don't let missing mailing parts throw exceptions
Aidan Saunders [Mon, 21 Nov 2022 11:09:56 +0000 (11:09 +0000)]
More del() deprecations in favour of standard deleteRecord()
Aidan Saunders [Tue, 22 Nov 2022 12:28:26 +0000 (12:28 +0000)]
Deprecate `CRM_Mailing_BAO_Mailing::del()`
Aidan Saunders [Tue, 22 Nov 2022 09:25:42 +0000 (09:25 +0000)]
Deprecate `CRM_Mailing_BAO_MailingAB::del()`
Eileen McNaughton [Tue, 22 Nov 2022 01:44:03 +0000 (14:44 +1300)]
Cleanup in test class
colemanw [Tue, 22 Nov 2022 01:04:00 +0000 (20:04 -0500)]
Merge pull request #25021 from colemanw/relationshipType
Add default label field for RelationshipType entity
Coleman Watts [Mon, 21 Nov 2022 23:22:46 +0000 (18:22 -0500)]
Add default label field for RelationshipType entity
Tim Otten [Mon, 21 Nov 2022 22:32:19 +0000 (14:32 -0800)]
E2E\Api4\LocaleTest - Update to reflect current reality
Seamus Lee [Mon, 21 Nov 2022 21:23:27 +0000 (08:23 +1100)]
Merge pull request #25019 from aydun/bao_del_more
More BAO `del()` deprecations
colemanw [Mon, 21 Nov 2022 19:43:18 +0000 (14:43 -0500)]
Merge pull request #25018 from aydun/bao_del_event
Deprecate `CRM_Event_BAO_Event::del()` in favour of `deleteRecord()`
colemanw [Mon, 21 Nov 2022 19:43:03 +0000 (14:43 -0500)]
Merge pull request #25017 from aydun/bao_del_relationship
Deprecate `CRM_Contact_BAO_Relationship::del()` in favour of `deleteRecord()`
Aidan Saunders [Mon, 21 Nov 2022 19:37:58 +0000 (19:37 +0000)]
More BAO `del()` deprecations
colemanw [Mon, 21 Nov 2022 18:33:57 +0000 (13:33 -0500)]
Merge pull request #24985 from colemanw/searchDisplayDescriptions
SearchKit - Descriptions for search displays
Aidan Saunders [Mon, 21 Nov 2022 16:40:11 +0000 (16:40 +0000)]
Deprecate `CRM_Contact_BAO_Relationship::del()` in favour of
`deleteRecord()`
Move status message out of business-layer
colemanw [Mon, 21 Nov 2022 17:09:24 +0000 (12:09 -0500)]
Merge pull request #24999 from colemanw/refOptionValueDel
[REF] OptionValue - Deprecate del() function in favor of standard deleteRecord
colemanw [Mon, 21 Nov 2022 17:06:50 +0000 (12:06 -0500)]
Merge pull request #24991 from kurund/formbuilder-event-entity
add event entity to formbuilder
Aidan Saunders [Mon, 21 Nov 2022 16:37:22 +0000 (16:37 +0000)]
Deprecate `CRM_Event_BAO_Event::del()`
Coleman Watts [Mon, 21 Nov 2022 01:23:37 +0000 (20:23 -0500)]
Menubar - Fix buggy, slow loader
Yashodha Chaku [Mon, 21 Nov 2022 13:24:43 +0000 (18:54 +0530)]
Merge pull request #25016 from JMAConsulting/dev-core#3999-56
dev/core#3999 : Unable to delete price field
Monish Deb [Mon, 21 Nov 2022 08:12:05 +0000 (13:42 +0530)]
dev/core#3999 : Unable to delete price field
Seamus Lee [Mon, 21 Nov 2022 04:38:08 +0000 (15:38 +1100)]
Merge pull request #25013 from demeritcowboy/dispatcher-utilstest
[NFC] UtilsTest - convert EventDispatcher to CiviEventDispatcher
demeritcowboy [Mon, 21 Nov 2022 03:09:39 +0000 (22:09 -0500)]
Merge pull request #25010 from colemanw/minHeight
Menubar - fix height of quicksearch (Drupal9)
Seamus Lee [Mon, 21 Nov 2022 03:04:18 +0000 (14:04 +1100)]
Merge pull request #25011 from eileenmcnaughton/res
Var type fix in comment
Eileen McNaughton [Mon, 21 Nov 2022 01:04:17 +0000 (14:04 +1300)]
Var type fix in comment
Coleman Watts [Sun, 20 Nov 2022 23:15:13 +0000 (18:15 -0500)]
Menubar - fix height of quicksearch (Drupal9)
demeritcowboy [Sun, 20 Nov 2022 19:45:20 +0000 (14:45 -0500)]
convert to CiviEventDispatcher
colemanw [Sun, 20 Nov 2022 18:03:42 +0000 (13:03 -0500)]
Merge pull request #25007 from demeritcowboy/daotest2
php8 - don't pass null as string
demeritcowboy [Sun, 20 Nov 2022 01:34:59 +0000 (20:34 -0500)]
Merge pull request #25008 from demeritcowboy/daotest
[NFC] Allow running tests/phpunit/CRM/Core/DAOTest.php on mariadb
demeritcowboy [Sat, 19 Nov 2022 23:04:35 +0000 (18:04 -0500)]
php8 don't pass null as string
demeritcowboy [Sat, 19 Nov 2022 22:50:51 +0000 (17:50 -0500)]
allow mariadb
Kurund Jalmi [Sat, 19 Nov 2022 19:12:15 +0000 (19:12 +0000)]
set standard defaults
colemanw [Sat, 19 Nov 2022 00:45:51 +0000 (19:45 -0500)]
Merge pull request #24989 from eileenmcnaughton/js_strings
Use fastArray cache for js_strings
colemanw [Sat, 19 Nov 2022 00:43:22 +0000 (19:43 -0500)]
Merge pull request #25005 from demeritcowboy/missing-dot-2
(alternate) Sentence runs together since period is inside the if block
demeritcowboy [Fri, 18 Nov 2022 22:35:06 +0000 (17:35 -0500)]
fix missing dot and translation
demeritcowboy [Fri, 18 Nov 2022 22:09:54 +0000 (17:09 -0500)]
Merge pull request #25002 from kurund/crm-user-improvements
add legend to CMS user creation section
Seamus Lee [Fri, 18 Nov 2022 21:47:04 +0000 (08:47 +1100)]
Merge pull request #25000 from mlutfy/fixMenuTranslation
Fix CiviCRM Home/Hide/Logout translation
Kurund Jalmi [Fri, 18 Nov 2022 20:24:21 +0000 (20:24 +0000)]
add legend to CMS user creation section
Mathieu Lutfy [Fri, 18 Nov 2022 18:59:51 +0000 (13:59 -0500)]
Fix CiviCRM Home/Hide/Logout translation
Coleman Watts [Fri, 18 Nov 2022 17:26:23 +0000 (12:26 -0500)]
OptionValue - Deprecate del() function in favor of standard deleteRecord
demeritcowboy [Fri, 18 Nov 2022 14:10:20 +0000 (09:10 -0500)]
Merge pull request #24923 from eileenmcnaughton/filt_bool
dev/core#3962 Add 'boolean' as a filter for tokens
Coleman Watts [Fri, 18 Nov 2022 00:39:45 +0000 (19:39 -0500)]
Mailing - Add APIv3 get actions to make syntaxConformanceTest happy
Tim Otten [Fri, 18 Nov 2022 02:16:00 +0000 (18:16 -0800)]
dev/core#3979 - Make an educated guess about how to set UF locale. Add test-case.
Tim Otten [Fri, 18 Nov 2022 01:12:48 +0000 (17:12 -0800)]
dev/core#3979 - Add test to reproduce error
Note: On current D7, this doesn't actually reproduce the message because `bootstrap.inc` redirects it
```
function _drupal_bootstrap_configuration() {
// Set the Drupal custom error handler.
set_error_handler('_drupal_error_handler');
set_exception_handler('_drupal_exception_handler');
```
But if you comment out `set_error_handler()`, then it does. And I presume it would on D8+...
colemanw [Thu, 17 Nov 2022 22:23:04 +0000 (17:23 -0500)]
Merge pull request #24993 from aydun/joinable_fix
Allow Joinables to be added to tables without specifying a base column
Aidan Saunders [Thu, 17 Nov 2022 18:03:57 +0000 (18:03 +0000)]
Allow `addTableLink(NULL, ...)`
Coleman Watts [Thu, 17 Nov 2022 17:41:43 +0000 (12:41 -0500)]
Mailing - Rename BAO files to match renamed DAOs
Coleman Watts [Wed, 16 Nov 2022 19:10:46 +0000 (14:10 -0500)]
Mailing - Rename DAO files for better short names
Aidan Saunders [Wed, 16 Nov 2022 13:48:16 +0000 (13:48 +0000)]
Make MessageTemplates available to SearchKit
Aidan Saunders [Wed, 16 Nov 2022 13:47:10 +0000 (13:47 +0000)]
Add paths to MessageTemplates xml
Make Title and Subject filterable
Kurund Jalmi [Thu, 17 Nov 2022 15:31:07 +0000 (15:31 +0000)]
add event entity to formbuilder
colemanw [Thu, 17 Nov 2022 02:42:04 +0000 (21:42 -0500)]
Merge pull request #24990 from demeritcowboy/dao
Update DAOs after https://github.com/civicrm/civicrm-core/pull/24984
demeritcowboy [Thu, 17 Nov 2022 02:32:05 +0000 (21:32 -0500)]
update daos
Eileen McNaughton [Thu, 17 Nov 2022 01:32:40 +0000 (14:32 +1300)]
Use fastArray cache for js_strings
Seamus Lee [Thu, 17 Nov 2022 00:06:41 +0000 (11:06 +1100)]
Merge pull request #24986 from civicrm/5.56
5.56
Seamus Lee [Wed, 16 Nov 2022 23:47:15 +0000 (10:47 +1100)]
Merge pull request #24984 from eileenmcnaughton/dao
Add html for default field to schema
demeritcowboy [Wed, 16 Nov 2022 22:13:04 +0000 (17:13 -0500)]
Merge pull request #24926 from eileenmcnaughton/5.56
dev/core#3685 Fix price sets in sample data
Eileen McNaughton [Wed, 16 Nov 2022 22:06:41 +0000 (11:06 +1300)]
Merge pull request #24983 from colemanw/dedupeAliases
[REF] DAO - Use class_alias for aliases of renamed classes
Coleman Watts [Wed, 16 Nov 2022 21:25:00 +0000 (16:25 -0500)]
SearchKit - Descriptions for search displays
This shows the savedSearch description on the default display,
and allows each custom display to have its own description
which shows at the top.
Eileen McNaughton [Tue, 8 Nov 2022 04:45:50 +0000 (17:45 +1300)]
dev/core#3962 Add 'boolean' as a filter for tokens
Add unit tests leveraging & demo-ing boolean fitler in greetings
Eileen McNaughton [Wed, 16 Nov 2022 21:13:55 +0000 (10:13 +1300)]
Merge pull request #24978 from yashodha/dev-3992
(dev/core#3992) Expose created date column in contact reports
Eileen McNaughton [Wed, 16 Nov 2022 21:07:24 +0000 (10:07 +1300)]
Add html for default field to schema
Note in the process I found that OptionValue.is_default is not required and LocationType.is_default
is not required and does not have a default
Coleman Watts [Wed, 16 Nov 2022 20:39:25 +0000 (15:39 -0500)]
DAO - Use class_alias for aliases of renamed classes
colemanw [Wed, 16 Nov 2022 19:54:48 +0000 (14:54 -0500)]
Merge pull request #24963 from colemanw/SearchKitFkFix
SearchKit - Fix campaign, event & primary address dropdowns
Coleman Watts [Sat, 12 Nov 2022 20:19:52 +0000 (15:19 -0500)]
SearchKit - Use EntityRef for all FK fields, even those with option lists
Before: option lists were preferred over FK
After: FK is preferred over option lists
Fixes dev/core#3950
Fixes dev/core#3982
Coleman Watts [Wed, 16 Nov 2022 17:37:52 +0000 (12:37 -0500)]
Customize default display for Countries
Coleman Watts [Sat, 12 Nov 2022 20:31:19 +0000 (15:31 -0500)]
CiviEvent - Add labels to field metadata
Coleman Watts [Sat, 12 Nov 2022 20:16:00 +0000 (15:16 -0500)]
CiviCampaign - Add labels to field metadata
Seamus Lee [Wed, 16 Nov 2022 07:33:15 +0000 (18:33 +1100)]
Merge pull request #24979 from eileenmcnaughton/dao
Regen DAO
Eileen McNaughton [Wed, 16 Nov 2022 05:51:59 +0000 (18:51 +1300)]
Regen DAO
yashodha [Wed, 16 Nov 2022 05:29:59 +0000 (10:59 +0530)]
(dev/core#3992) Expose created date column in contact reports
colemanw [Tue, 15 Nov 2022 19:50:06 +0000 (14:50 -0500)]
Merge pull request #24976 from colemanw/api4Autocompletes
APIv4 Autocomplete - Support searching by ID, customize some entities
Matthew Wire [Tue, 15 Nov 2022 19:33:04 +0000 (19:33 +0000)]
Merge pull request #24977 from colemanw/exceptions
APIv3 - Use the Exception rather than the rule
Coleman Watts [Tue, 15 Nov 2022 13:18:11 +0000 (08:18 -0500)]
APIv4 Autocomplete improvements - Support searching by ID, customize some entities
Gives parity with the v3-based widget which would search either by id or label
and place the exact match at the top if found.
Also gives parity with the customized output of some v3 entities,
plus a few like Relationship that v3 never was able to handle.
Coleman Watts [Tue, 15 Nov 2022 15:58:26 +0000 (10:58 -0500)]
APIv3 - Use the Exception rather than the rule
Following up on #19323 this converts APIv3 in Smarty and Ajax to use exceptions instead
of overriding the PEAR exception handler. Now that PEAR throws exceptions there is
no need to do so and it was interfering with try/catch handlers within the api call.
colemanw [Tue, 15 Nov 2022 14:13:38 +0000 (09:13 -0500)]
Merge pull request #24970 from eileenmcnaughton/enabled_4
Add html definition to schema for is_active (part 4)
colemanw [Tue, 15 Nov 2022 14:13:01 +0000 (09:13 -0500)]
Merge pull request #24969 from eileenmcnaughton/enabled_3
Add html definition to schema for is_active (part 3)
colemanw [Tue, 15 Nov 2022 14:12:01 +0000 (09:12 -0500)]
Merge pull request #24968 from eileenmcnaughton/enabled_2
Add html definition to schema for is_active (part 2)