Yashodha Chaku [Mon, 17 Jul 2023 11:57:27 +0000 (17:27 +0530)]
Merge pull request #26860 from eileenmcnaughton/member
[PHP8.2] move property declaration form CRM_Member_Form_Membership to parent
Aidan Saunders [Mon, 17 Jul 2023 09:44:35 +0000 (10:44 +0100)]
Merge pull request #26842 from colemanw/isActiveToggle
AdminUI - Add toggle for is_active
Yashodha Chaku [Mon, 17 Jul 2023 06:32:51 +0000 (12:02 +0530)]
Merge pull request #26857 from eileenmcnaughton/logged
[tests][php8.2] Use function rather than sometimes declared property for loggedInUserID
Eileen McNaughton [Mon, 17 Jul 2023 01:20:56 +0000 (13:20 +1200)]
[tests][php8.2] Use function rather than sometimes declared property for loggedInUserID
colemanw [Mon, 17 Jul 2023 03:02:23 +0000 (20:02 -0700)]
Merge pull request #26859 from eileenmcnaughton/cust_case
[php8.2] Fix undeclared properties on case custom data form
Seamus Lee [Mon, 17 Jul 2023 03:01:29 +0000 (23:01 -0400)]
Merge pull request #26858 from eileenmcnaughton/cust_by_type
Remove never-true-if
demeritcowboy [Mon, 17 Jul 2023 02:39:38 +0000 (22:39 -0400)]
Merge pull request #26845 from eileenmcnaughton/subname
Remove `_subName` property
Eileen McNaughton [Mon, 17 Jul 2023 02:05:24 +0000 (14:05 +1200)]
[php8.2] Fix undeclared properties on case custom data form
Eileen McNaughton [Mon, 17 Jul 2023 02:18:39 +0000 (14:18 +1200)]
[PHP8.2] move property declaration form CRM_Member_Form_Membership to parent
Eileen McNaughton [Mon, 17 Jul 2023 01:36:51 +0000 (13:36 +1200)]
Remove never-true-if
Tim Otten [Mon, 17 Jul 2023 00:58:45 +0000 (17:58 -0700)]
Merge pull request #26856 from seamuslee001/p82_logged_in_user
[NFC][PHP8.2] Fix dynamic property _loggedInUser
Seamus Lee [Sun, 16 Jul 2023 22:57:16 +0000 (08:57 +1000)]
[NFC][PHP8.2] Fix dynamic property _loggedInUser
demeritcowboy [Sun, 16 Jul 2023 15:08:42 +0000 (11:08 -0400)]
Merge pull request #26843 from colemanw/searchKitButtons
SearchKit - fix min-width of buttons
colemanw [Sun, 16 Jul 2023 14:28:52 +0000 (07:28 -0700)]
Merge pull request #26850 from totten/master-ref-mail
(REF) CMSUser::create - Rename misleading parameter
Eileen McNaughton [Sun, 16 Jul 2023 06:35:45 +0000 (18:35 +1200)]
Merge pull request #26851 from eileenmcnaughton/unshared
Follow up fix (master only regression)
Eileen McNaughton [Sun, 16 Jul 2023 05:12:13 +0000 (17:12 +1200)]
Follow up fix
Tim Otten [Sun, 16 Jul 2023 04:36:16 +0000 (21:36 -0700)]
(REF) CMSUser::create - Rename misleading parameter
The second parameter is very confusing:
* The name `$mail` suggests that the parameter is an email address.
* The parameter `$mail` actually contains the name of the *field* which has the email address.
This is a weird contract. It invites misinterpretation -- and now, e.g., some of the `Standalone`
code has misused it.
To confirm that `$mail` is actually the parameter-name, note that:
1. `create()` actually looks for `$params[$mail]`
2. Callers like `CRM/Contact/Form/Task/Useradd.php` actually give a parameter name
Tim Otten [Sun, 16 Jul 2023 04:26:31 +0000 (21:26 -0700)]
Merge pull request #26771 from totten/master-s3
Standalone - Add support for development-friendly file-layouts
Eileen McNaughton [Sun, 16 Jul 2023 04:13:03 +0000 (16:13 +1200)]
Merge pull request #26839 from colemanw/searchKitActionLinksCleanup
Search kit action links cleanup
Eileen McNaughton [Sun, 16 Jul 2023 04:12:11 +0000 (16:12 +1200)]
Merge pull request #26848 from mlutfy/newEventTR
[NFC] New Event: remove empty table row
colemanw [Sun, 16 Jul 2023 01:57:42 +0000 (18:57 -0700)]
Merge pull request #26846 from eileenmcnaughton/custom
Notice fix - ensure extends_entity_column_value isset
Mathieu Lutfy [Sun, 16 Jul 2023 01:25:34 +0000 (21:25 -0400)]
New Event: remove empty table row
colemanw [Sun, 16 Jul 2023 01:18:09 +0000 (18:18 -0700)]
Merge pull request #26844 from eileenmcnaughton/unshared
Fold private `setGroupTree` function back into caller
Eileen McNaughton [Sun, 16 Jul 2023 00:05:59 +0000 (12:05 +1200)]
Notice fix - ensure extends_entity_column_value isset
Eileen McNaughton [Sat, 15 Jul 2023 23:29:51 +0000 (11:29 +1200)]
Remove subName property in favour of an internal variable
This is not used outside the function
Eileen McNaughton [Sat, 15 Jul 2023 23:26:18 +0000 (11:26 +1200)]
Remove use of subName property
Eileen McNaughton [Sat, 15 Jul 2023 23:20:23 +0000 (11:20 +1200)]
Merge pull request #26791 from jmcclelland/hide-view-only
hide view only custom fields on merge screen
Eileen McNaughton [Sat, 15 Jul 2023 23:17:28 +0000 (11:17 +1200)]
Fold private setGroupTree function back into caller
colemanw [Sat, 15 Jul 2023 20:20:42 +0000 (16:20 -0400)]
SearchKit - fix min-width of buttons
colemanw [Sat, 15 Jul 2023 20:00:33 +0000 (16:00 -0400)]
AdminUI - Add toggle for is_active
colemanw [Sat, 15 Jul 2023 16:10:48 +0000 (12:10 -0400)]
SearchKit - Ensure task links work with relationships
colemanw [Sat, 15 Jul 2023 02:16:32 +0000 (22:16 -0400)]
SearchKit - Make loading task links more efficient
colemanw [Sat, 15 Jul 2023 14:59:28 +0000 (07:59 -0700)]
Merge pull request #26837 from eileenmcnaughton/no_pre_process
Fold `preProcess` into `run`
demeritcowboy [Sat, 15 Jul 2023 14:20:40 +0000 (10:20 -0400)]
Merge pull request #26836 from eileenmcnaughton/unshared
Remove last reference to undefined property `_subType`
Eileen McNaughton [Sat, 15 Jul 2023 03:30:55 +0000 (15:30 +1200)]
Merge pull request #26838 from seamuslee001/php82_ssid_dynamic
[REF][PHP8.2] Ref fix deprecation in PHP8.2 about dynamic property _ssID
Eileen McNaughton [Sat, 15 Jul 2023 01:42:25 +0000 (13:42 +1200)]
Use internal var for groupID
colemanw [Sat, 15 Jul 2023 02:25:06 +0000 (19:25 -0700)]
Merge pull request #26835 from seamuslee001/performance_fix
Ensure that we only check permissions if we want to in getActions fol…
Seamus Lee [Sat, 15 Jul 2023 02:11:54 +0000 (12:11 +1000)]
[REF][PHP8.2] Ref fix deprecation in PHP8.2 about dynamic property _ssID
Eileen McNaughton [Sat, 15 Jul 2023 02:01:48 +0000 (14:01 +1200)]
Fold preProcess into run
there are properties that appear to be being set solely to pass variables from preProcess to
run.
preProcess is called from run and that is the only way it is accessed.
There are some forms that use the pageRun hook in the universe but this has no impact on them
colemanw [Sat, 15 Jul 2023 01:49:28 +0000 (21:49 -0400)]
SearchKit - Break getLinkInfo into 3 smaller functions
Seamus Lee [Sat, 15 Jul 2023 01:43:08 +0000 (21:43 -0400)]
Merge pull request #26834 from eileenmcnaughton/amount
[REF] Use internal variable rather than property to pass variable
Eileen McNaughton [Sat, 15 Jul 2023 01:39:02 +0000 (13:39 +1200)]
Remove last reference to undefined property ->_subType
Seamus Lee [Sat, 15 Jul 2023 01:15:30 +0000 (11:15 +1000)]
Ensure that we only check permissions if we want to in getActions follow up to #26823
Make it more readable as per coleman
Seamus Lee [Sat, 15 Jul 2023 01:21:13 +0000 (21:21 -0400)]
Merge pull request #26832 from eileenmcnaughton/unshared
[REF] [PHP8.2] Post unshare cleanup
Eileen McNaughton [Sat, 15 Jul 2023 01:11:05 +0000 (13:11 +1200)]
Use internal variable rather than property to pass variable
colemanw [Sat, 15 Jul 2023 01:05:51 +0000 (18:05 -0700)]
Merge pull request #26833 from eileenmcnaughton/unshared2
[REF] [PHP8.2]Treat subType as a internal varible, not a form property
Eileen McNaughton [Sat, 15 Jul 2023 00:25:20 +0000 (12:25 +1200)]
Do not pass in subType as the same value will be calculated
Eileen McNaughton [Sat, 15 Jul 2023 00:22:20 +0000 (12:22 +1200)]
Add deprecation to otherwise deprecated chunk
Eileen McNaughton [Sat, 15 Jul 2023 00:20:11 +0000 (12:20 +1200)]
Treat subType as a internal varible, not a form property
Seamus Lee [Sat, 15 Jul 2023 00:17:27 +0000 (20:17 -0400)]
Merge pull request #26830 from seamuslee001/php82_contribute_history
[REF][PHP8.2] Fix Deprectation notice due to dynamic properties on th…
Seamus Lee [Sat, 15 Jul 2023 00:17:16 +0000 (20:17 -0400)]
Merge pull request #26828 from seamuslee001/php82_logging_detail
[REF][PHP8.2] Fix deprecated dynamic properties in Logging Report Detail
Eileen McNaughton [Sat, 15 Jul 2023 00:12:42 +0000 (12:12 +1200)]
Post unshare cleanup
This stops passing & returning unused values from the previously shared function
& removes a deprecated chunk.
This deprecation was very precautionary IMHO so 6 months is long enough
Seamus Lee [Fri, 14 Jul 2023 23:55:04 +0000 (19:55 -0400)]
Merge pull request #26829 from eileenmcnaughton/cust_share
[Ref] [php8] Unshare shared function `CRM_Custom_Form_CustomData::setGroupTree` in order to clean-up
Seamus Lee [Fri, 14 Jul 2023 23:53:11 +0000 (19:53 -0400)]
Merge pull request #26776 from eileenmcnaughton/result
[REF] Stop passing `result` into `getContributionParams` to get one value from it, in one code path
Seamus Lee [Fri, 14 Jul 2023 23:51:57 +0000 (19:51 -0400)]
Merge pull request #26775 from eileenmcnaughton/cont_recur
[Ref] Minor cleanup on handling of financial type
Seamus Lee [Fri, 14 Jul 2023 23:39:29 +0000 (09:39 +1000)]
[REF][PHP8.2] Fix Deprectation notice due to dynamic properties on the Contribute History report
Seamus Lee [Fri, 14 Jul 2023 23:01:42 +0000 (09:01 +1000)]
[REF][PHP8.2] Fix deprecated dynamic properties in Logging Report Detail
Eileen McNaughton [Fri, 14 Jul 2023 23:30:58 +0000 (11:30 +1200)]
Merge pull request #26827 from seamuslee001/php82_multirecord_linsting
[REF][PHP8.2] Fix Dynamic Property Deprecation notice in MultiRecordListing
Eileen McNaughton [Fri, 14 Jul 2023 23:01:25 +0000 (11:01 +1200)]
Unshare shared function in order to clean-up
Seamus Lee [Fri, 14 Jul 2023 23:07:14 +0000 (19:07 -0400)]
Merge pull request #26826 from eileenmcnaughton/case_summary
Clean up CaseSummary Report removing undeclared properties and minor fixes
Seamus Lee [Fri, 14 Jul 2023 22:55:56 +0000 (08:55 +1000)]
[REF] Fix Dynamic Property Deprecation notice in MultiRecordListing
Eileen McNaughton [Fri, 14 Jul 2023 22:25:12 +0000 (10:25 +1200)]
Clean up CaseSummary Report removing undeclared properties and minor fixes
colemanw [Fri, 14 Jul 2023 22:24:30 +0000 (15:24 -0700)]
Merge pull request #26823 from seamuslee001/api4_get_actions_dynamic
[REF] Ensure that getActions respects any modifications by event list…
Jamie McClelland [Tue, 11 Jul 2023 17:18:24 +0000 (13:18 -0400)]
hide view only custom fields on merge screen
And, ensure they are not merged. View only fields with values on the
duplicate that is being discarded will be discarded.
Seamus Lee [Fri, 14 Jul 2023 06:54:49 +0000 (16:54 +1000)]
Add unit test to verify patch fixes dynmaically permissable entity actions
Seamus Lee [Fri, 14 Jul 2023 06:24:03 +0000 (16:24 +1000)]
[REF] Ensure that getActions respects any modifications by event listerners modifying permissions
Seamus Lee [Fri, 14 Jul 2023 06:12:09 +0000 (02:12 -0400)]
Merge pull request #26820 from eileenmcnaughton/search_test
Fix mis-cased apiVersion causing php8.x fails in SavedSearchTest
Eileen McNaughton [Fri, 14 Jul 2023 05:46:38 +0000 (17:46 +1200)]
Merge pull request #26817 from eileenmcnaughton/syntax
Fix undeclared property in SyntaxConformanceTests
Eileen McNaughton [Fri, 14 Jul 2023 02:38:38 +0000 (14:38 +1200)]
Fix mis-cased apiVersion causing php8.x fails in SavedSearchTest
I also removed the delete test - it really isn't adding anything
Eileen McNaughton [Fri, 14 Jul 2023 05:20:46 +0000 (17:20 +1200)]
Merge pull request #26822 from colemanw/agpl
[NFC] Replace nonstandard copyright headers with the standard one
Eileen McNaughton [Fri, 14 Jul 2023 05:17:58 +0000 (17:17 +1200)]
Merge pull request #26821 from seamuslee001/mime_typer_php82
[REF][PHP8.2] Apply PR patch to mimetyper to fix deprecated dynamic p…
Eileen McNaughton [Fri, 14 Jul 2023 02:18:08 +0000 (14:18 +1200)]
Fix undeclared property in SyntaxConformanceTests
Also,
- minor cleanup
- remove a test that just checks version is required for api v3, over & over
Seamus Lee [Fri, 14 Jul 2023 03:26:28 +0000 (23:26 -0400)]
Merge pull request #26819 from eileenmcnaughton/label_test
[PHP8.x] Stop setting undeclared, unused property in test
colemanw [Fri, 14 Jul 2023 03:06:27 +0000 (23:06 -0400)]
Replace nonstandard copyright headers with the standard one
Our standard practice is to add contributors to the release notes rather than putting their name in the
copyright header, as that would be impossible to maintain with so many people contributing to each file.
Seamus Lee [Fri, 14 Jul 2023 02:58:22 +0000 (22:58 -0400)]
Merge pull request #26818 from eileenmcnaughton/report
Reduce test fails on edge for Contact_Detail report
Seamus Lee [Fri, 14 Jul 2023 02:51:43 +0000 (12:51 +1000)]
[REF][PHP8.2] Apply PR patch to mimetyper to fix deprecated dynamic property
Seamus Lee [Fri, 14 Jul 2023 02:50:12 +0000 (22:50 -0400)]
Merge pull request #26816 from eileenmcnaughton/frontend_title
Run regen, with data fix to allow it to run
Eileen McNaughton [Fri, 14 Jul 2023 02:48:45 +0000 (14:48 +1200)]
Stop setting undeclared, unused property in test
Seamus Lee [Fri, 14 Jul 2023 02:38:06 +0000 (22:38 -0400)]
Merge pull request #26815 from seamuslee001/action_button_name_notice
[REF][PHP8.2] Move declaration of _actionButtonName from CRM_Core_Form_Search…
Eileen McNaughton [Fri, 14 Jul 2023 02:28:06 +0000 (14:28 +1200)]
Reduce test fails on edge for Contact_Detail report
There are still more - I lost the will
demeritcowboy [Fri, 14 Jul 2023 02:24:52 +0000 (22:24 -0400)]
Merge pull request #26808 from eileenmcnaughton/reports
ReportTemplate data provider - skip rather than mark incomplete event/income
Eileen McNaughton [Fri, 14 Jul 2023 02:07:21 +0000 (14:07 +1200)]
Run regen, with data fix to allow it to run
Seamus Lee [Fri, 14 Jul 2023 02:03:06 +0000 (12:03 +1000)]
[REF] Move declaration of _actionButtonName from CRM_Core_Form_Search to CRM_Core_Form to fix undefined property errors in Job Report tests
Eileen McNaughton [Fri, 14 Jul 2023 01:57:30 +0000 (13:57 +1200)]
Add frontend_title to uf_group sample data
Eileen McNaughton [Fri, 14 Jul 2023 01:07:50 +0000 (13:07 +1200)]
Merge pull request #26814 from eileenmcnaughton/price
[Ref] Use `isQuickConfig` function, rather than repetitively looking it up
colemanw [Fri, 14 Jul 2023 00:54:27 +0000 (17:54 -0700)]
Merge pull request #26813 from totten/master-nfc-esm
(NFC) Civi\ESM - Doc cleanups
Eileen McNaughton [Fri, 14 Jul 2023 00:31:01 +0000 (12:31 +1200)]
Use isQuickConfig function, rather than repetitively looking it up
Mathieu Lu [Fri, 14 Jul 2023 00:23:54 +0000 (20:23 -0400)]
Merge pull request #26806 from larssandergreen/Standardize-admin-breadcrumbs
Standardize title as Administer in breadcrumbs and on main Administer page
Seamus Lee [Fri, 14 Jul 2023 00:17:09 +0000 (20:17 -0400)]
Merge pull request #26778 from eileenmcnaughton/price
[REF] Clarify loading of PriceSetID
Seamus Lee [Fri, 14 Jul 2023 00:07:27 +0000 (20:07 -0400)]
Merge pull request #26546 from eileenmcnaughton/frontend_group
dev/core#4213 Make frontend_title, name required for Group entity
Eileen McNaughton [Fri, 14 Jul 2023 00:03:42 +0000 (12:03 +1200)]
Merge pull request #26812 from civicrm/5.64
5.64 to master
Eileen McNaughton [Fri, 14 Jul 2023 00:02:28 +0000 (12:02 +1200)]
Merge pull request #26811 from larssandergreen/Re-add-start-date-for-recurring-contributions-for-RC
Add start date back to recurring contributions display on contact - RC
Eileen McNaughton [Thu, 13 Jul 2023 22:03:44 +0000 (10:03 +1200)]
mend
Eileen McNaughton [Sun, 9 Jul 2023 23:42:42 +0000 (11:42 +1200)]
Update the welcome mailing component
It now uses tokens not the now-deprecated function
Eileen McNaughton [Fri, 16 Jun 2023 06:48:44 +0000 (18:48 +1200)]
dev/core#4213 Make frontend_title, name required for Group entity
This follows up on having done this for contribution_page recently.
It will mean we can consistently refer to frontend_title in tokens
and other places where what we really mean is ... frontend_title.
Eileen McNaughton [Sun, 25 Jun 2023 00:25:06 +0000 (17:25 -0700)]
Fix PetitionTest on group frontend_title, erm by doing all the stuff
Tim Otten [Thu, 13 Jul 2023 22:59:44 +0000 (15:59 -0700)]
(NFC) Civi\ESM - Doc cleanups
larssandergreen [Thu, 13 Jul 2023 22:47:43 +0000 (16:47 -0600)]
Add start date back to recurring contributions display on contact
Eileen McNaughton [Thu, 13 Jul 2023 22:36:18 +0000 (10:36 +1200)]
Merge pull request #26809 from eileenmcnaughton/report_logging
Move turning logging off to the tearDown
Eileen McNaughton [Thu, 13 Jul 2023 22:29:40 +0000 (10:29 +1200)]
Merge pull request #26798 from colemanw/searchKitBrowse
SearchKit - Remove irrelevant link from default display