Matthew Wire [Mon, 16 Oct 2023 20:32:35 +0000 (21:32 +0100)]
Merge pull request #27823 from colemanw/arrayCleanupAdmin
[REF] CRM/Admin - Refactor unnecessary uses of CRM_Utils_Array::value
Matthew Wire [Mon, 16 Oct 2023 20:31:21 +0000 (21:31 +0100)]
Merge pull request #27839 from colemanw/participantCount
SearchKit - Add Event.remaining_participants calculated field
Matthew Wire [Mon, 16 Oct 2023 20:29:02 +0000 (21:29 +0100)]
Merge pull request #27836 from eileenmcnaughton/php82
Php8.x fixes on Main online contribution page
Matthew Wire [Mon, 16 Oct 2023 20:26:18 +0000 (21:26 +0100)]
Merge pull request #27838 from colemanw/participantPseudoconstantCleanup
[REF] CRM_Event_PseudoConstant - Cleanup redundant caching
Tim Otten [Mon, 16 Oct 2023 18:47:11 +0000 (11:47 -0700)]
Merge pull request #27821 from colemanw/arrayCleanupEvent
[REF] CRM/Event - Refactor unnecessary uses of CRM_Utils_Array::value
Tim Otten [Mon, 16 Oct 2023 18:43:38 +0000 (11:43 -0700)]
Merge pull request #27807 from colemanw/angLoops
[REF] AngularManager - Skip extra lookups. Document function.
colemanw [Fri, 13 Oct 2023 13:33:43 +0000 (09:33 -0400)]
AngularManager - Simplify loops
Before - unnecessarily loops through array before just setting the entire value of the array
After - skips the unnecessary loop
colemanw [Mon, 16 Oct 2023 15:35:47 +0000 (11:35 -0400)]
CRM_Event_PseudoConstant - Cleanup redundant caching
All these functions were double-caching the output of functions that already use caching.
At best this is a dumb waste of memory.
At worst it can cause bugs when the 2 caches don't get flushed together.
colemanw [Mon, 16 Oct 2023 17:02:03 +0000 (13:02 -0400)]
APIv4 - Add Event.remaining_participants calculated field
colemanw [Mon, 16 Oct 2023 14:47:39 +0000 (10:47 -0400)]
Merge pull request #27808 from colemanw/afformCleanup
[REF] AfformScanner - Update code comments & type hints
colemanw [Mon, 16 Oct 2023 14:46:51 +0000 (10:46 -0400)]
Merge pull request #27837 from colemanw/tsEvent
Participant - Translate untranslated string
colemanw [Mon, 16 Oct 2023 13:49:16 +0000 (09:49 -0400)]
Merge pull request #27775 from eileenmcnaughton/test_fix
Smarty3 Clean up test class - remove ref to internal tplParams
colemanw [Mon, 16 Oct 2023 11:48:29 +0000 (07:48 -0400)]
Participant - Translate untranslated string
colemanw [Fri, 13 Oct 2023 23:42:35 +0000 (19:42 -0400)]
CRM/Event - Refactor unnecessary uses of CRM_Utils_Array::value
Yashodha Chaku [Mon, 16 Oct 2023 05:54:45 +0000 (11:24 +0530)]
Merge pull request #27824 from colemanw/arrayCleanupPrice
[REF] CRM/Price - Refactor unnecessary uses of CRM_Utils_Array::value
Eileen McNaughton [Sun, 15 Oct 2023 21:58:32 +0000 (10:58 +1300)]
Php8.x fixes on Main online contribution page
Eileen McNaughton [Sat, 14 Oct 2023 20:57:53 +0000 (09:57 +1300)]
Php8.x bring handling of other_amount back to relevant form
Eileen McNaughton [Sun, 15 Oct 2023 21:09:36 +0000 (10:09 +1300)]
Merge pull request #27829 from eileenmcnaughton/php82
php8.2 fix undeclared properties on backoffice contribution form
colemanw [Sun, 15 Oct 2023 05:12:19 +0000 (01:12 -0400)]
Merge pull request #27819 from colemanw/arrayCleanupUtils
[REF] CRM/Utils - Refactor unnecessary uses of CRM_Utils_Array::value
colemanw [Sun, 15 Oct 2023 05:12:06 +0000 (01:12 -0400)]
Merge pull request #27817 from colemanw/arrayCleanupCore
[REF] CRM/Core - Refactor unnecessary uses of CRM_Utils_Array::value
colemanw [Fri, 13 Oct 2023 23:40:31 +0000 (19:40 -0400)]
CRM/Core - Refactor unnecessary uses of CRM_Utils_Array::value
colemanw [Fri, 13 Oct 2023 23:40:59 +0000 (19:40 -0400)]
CRM/Utils - Refactor unnecessary uses of CRM_Utils_Array::value
colemanw [Sun, 15 Oct 2023 03:08:08 +0000 (23:08 -0400)]
Merge pull request #27825 from colemanw/arrayCleanupActivity
[REF] CRM/Activity - Refactor unnecessary uses of CRM_Utils_Array::value
colemanw [Sun, 15 Oct 2023 00:26:11 +0000 (20:26 -0400)]
Merge pull request #27814 from colemanw/managedSortable
dev/core#4364 - Don't reset weights when updating managed entity
colemanw [Sat, 14 Oct 2023 23:00:04 +0000 (19:00 -0400)]
Merge pull request #27812 from lemniscus/nullcoalesce
CRM_Utils_Array::value - remove "todo" which we don't actually want to do
Noah Miller [Sat, 14 Oct 2023 22:02:09 +0000 (18:02 -0400)]
remove "todo" which we don't actually want to do
-- throwing this error would break a lot of things.
colemanw [Sat, 14 Oct 2023 21:54:44 +0000 (17:54 -0400)]
Merge pull request #27832 from larssandergreen/Add-hooks-for-Navigations-through-writeRecord
dev/core#4364 Use writeRecord for Navigations so menu changes for managed entities don't reset
colemanw [Sat, 14 Oct 2023 21:09:01 +0000 (17:09 -0400)]
Navigation - Add deprecation notice and remove redundant serialization
Noah Miller [Sat, 14 Oct 2023 20:51:43 +0000 (16:51 -0400)]
the experiment that @colemanw suggested: reject non-array $list param
larssandergreen [Sat, 14 Oct 2023 20:35:32 +0000 (14:35 -0600)]
Use writeRecords for Navigations
colemanw [Sat, 14 Oct 2023 20:14:50 +0000 (16:14 -0400)]
Merge pull request #27811 from eileenmcnaughton/cont_form
Stop calling `CRM_Contribute_Form_Contribution::testSubmit()`, quiet deprecation
Eileen McNaughton [Sat, 14 Oct 2023 20:07:14 +0000 (09:07 +1300)]
Merge pull request #27818 from colemanw/arrayCleanupContact
[REF] CRM/Contact - Refactor unnecessary uses of CRM_Utils_Array::value
Eileen McNaughton [Sat, 14 Oct 2023 05:11:53 +0000 (18:11 +1300)]
php8.2 fix undeclared properties on backoffice contribution form
There are just 2 properties
_payNow is distinctly internal, and easily searched in universe so I made it private
- _contributionID is specifically set for the purposes of hooks - although I expect that
was more relevant when the code was shared with the front end form. However, I have
set it up to still work for now, albeit with a deprecation notice
Eileen McNaughton [Sat, 14 Oct 2023 01:16:45 +0000 (14:16 +1300)]
Fix ContribuionFormTest to use full form flow
Eileen McNaughton [Fri, 13 Oct 2023 22:52:42 +0000 (11:52 +1300)]
Stop calling testSubmit(), quiet deprecation
Eileen McNaughton [Sat, 14 Oct 2023 19:51:15 +0000 (08:51 +1300)]
Merge pull request #27831 from eileenmcnaughton/part_form
Remove no-longer-used parameters from function signature
colemanw [Sat, 14 Oct 2023 19:01:31 +0000 (15:01 -0400)]
Merge pull request #27596 from eileenmcnaughton/participant_custom_assign
Move assigning customGroup to offline participant template out of the form layer
Eileen McNaughton [Sat, 14 Oct 2023 18:49:23 +0000 (07:49 +1300)]
Remove no-longer-used parameters from function signature
Eileen McNaughton [Sat, 14 Oct 2023 18:44:06 +0000 (07:44 +1300)]
Merge pull request #27737 from colemanw/afformStoreValues
SearchKit - Optionally remember filter values when user revisits sear…
colemanw [Sat, 14 Oct 2023 18:14:14 +0000 (14:14 -0400)]
Merge pull request #27830 from lemniscus/utils_array_value
Document and test unique behavior of CRM_Utils_Array::value()
Noah Miller [Sat, 14 Oct 2023 17:27:59 +0000 (13:27 -0400)]
Document and test unique behavior of CRM_Utils_Array::value()
colemanw [Sat, 14 Oct 2023 15:27:46 +0000 (11:27 -0400)]
Merge pull request #23299 from kurund/hide-disabled-financial-types
do not show disabled financial types in select for manage events
colemanw [Sat, 14 Oct 2023 15:16:39 +0000 (11:16 -0400)]
Merge pull request #27666 from mattwire/api4underscore
Searchdisplay issue with contact join activity and _ on the end of custom field
colemanw [Sat, 14 Oct 2023 15:10:36 +0000 (11:10 -0400)]
Merge pull request #27782 from eileenmcnaughton/configure_amount
Smarty3 compatibilty with Contribution Amount tab
colemanw [Sat, 14 Oct 2023 15:09:21 +0000 (11:09 -0400)]
Merge pull request #27787 from eileenmcnaughton/no_soft
Remove irrelevant code from previously shared form
colemanw [Sat, 14 Oct 2023 00:51:44 +0000 (20:51 -0400)]
dev/core#4364 - Don't reset weights when updating managed entity
colemanw [Fri, 13 Oct 2023 23:43:55 +0000 (19:43 -0400)]
CRM/Activity - Refactor unnecessary uses of CRM_Utils_Array::value
Eileen McNaughton [Sat, 14 Oct 2023 05:07:46 +0000 (18:07 +1300)]
Merge pull request #27826 from colemanw/arrayCleanupMailing
[REF] CRM/Mailing - Refactor unnecessary uses of CRM_Utils_Array::value
Eileen McNaughton [Sat, 14 Oct 2023 05:07:29 +0000 (18:07 +1300)]
Merge pull request #27827 from colemanw/arrayCleanupMisc
[REF] CRM/Misc - Refactor unnecessary uses of CRM_Utils_Array::value
Eileen McNaughton [Sat, 14 Oct 2023 05:07:11 +0000 (18:07 +1300)]
Merge pull request #27828 from colemanw/arrayCleanupFlex
[REF] Flexmailer - Refactor unnecessary use of CRM_Utils_Array::value
colemanw [Fri, 13 Oct 2023 23:45:42 +0000 (19:45 -0400)]
Flexmailer - Refactor unnecessary uses of CRM_Utils_Array::value
colemanw [Fri, 13 Oct 2023 23:45:24 +0000 (19:45 -0400)]
CRM/Misc - Refactor unnecessary uses of CRM_Utils_Array::value
colemanw [Fri, 13 Oct 2023 23:44:50 +0000 (19:44 -0400)]
CRM/Mailing - Refactor unnecessary uses of CRM_Utils_Array::value
colemanw [Fri, 13 Oct 2023 23:43:38 +0000 (19:43 -0400)]
CRM/Price - Refactor unnecessary uses of CRM_Utils_Array::value
colemanw [Fri, 13 Oct 2023 23:43:02 +0000 (19:43 -0400)]
CRM/Admin - Refactor unnecessary uses of CRM_Utils_Array::value
colemanw [Fri, 13 Oct 2023 23:40:45 +0000 (19:40 -0400)]
CRM/Contact - Refactor unnecessary uses of CRM_Utils_Array::value
Seamus Lee [Fri, 13 Oct 2023 23:48:33 +0000 (10:48 +1100)]
Merge pull request #27797 from eileenmcnaughton/acl
Move financial acl check on Main contribution page to the financial acl extension
Eileen McNaughton [Fri, 13 Oct 2023 22:52:42 +0000 (11:52 +1300)]
Stop calling testSubmit(), quiet deprecation
colemanw [Fri, 13 Oct 2023 23:19:22 +0000 (19:19 -0400)]
Merge pull request #27810 from eileenmcnaughton/move_test
Move financial acl test to extension
colemanw [Fri, 13 Oct 2023 23:11:16 +0000 (19:11 -0400)]
Merge pull request #27511 from agileware/CIVICRM-2174
🔡 SearchKit, add case-sensitive pattern matching search operators using REGEXP BINARY and NOT REGEXP BINARY
Eileen McNaughton [Fri, 13 Oct 2023 22:38:21 +0000 (11:38 +1300)]
Move financial acl test to extension
colemanw [Fri, 13 Oct 2023 22:12:52 +0000 (18:12 -0400)]
Merge pull request #27809 from colemanw/arrayCleanup
[NFC] Cleanup array syntax in tests directory
colemanw [Fri, 13 Oct 2023 19:36:29 +0000 (15:36 -0400)]
Cleanup array syntax in tests directory
Eileen McNaughton [Thu, 12 Oct 2023 23:03:08 +0000 (12:03 +1300)]
Move financial acl check on Main contribution page to the extension
Note that after our snaffu with memberships I tested with the setting enabled & disabled
Justin Freeman [Tue, 19 Sep 2023 07:25:58 +0000 (17:25 +1000)]
CIVICRM-2174 SearchKit, add case-sensitive pattern matching search operator
colemanw [Fri, 13 Oct 2023 16:12:03 +0000 (12:12 -0400)]
Merge pull request #27806 from demeritcowboy/msgtpl-blank-content
Allow blank message templates
colemanw [Fri, 13 Oct 2023 15:27:12 +0000 (11:27 -0400)]
AfformScanner - Update code comments & type hints
demeritcowboy [Fri, 13 Oct 2023 13:46:12 +0000 (09:46 -0400)]
Merge pull request #27791 from MegaphoneJon/fix-attachment-filenames
allow email attachments with unicode
demeritcowboy [Fri, 13 Oct 2023 13:03:45 +0000 (09:03 -0400)]
allow blank templates
colemanw [Fri, 13 Oct 2023 12:55:54 +0000 (08:55 -0400)]
Merge pull request #27804 from seamuslee001/weight_deduperules
[REF] Fix Smarty Notices on Dedupe Rules screen by setting weight
Aidan Saunders [Fri, 13 Oct 2023 08:41:14 +0000 (09:41 +0100)]
Merge pull request #27803 from colemanw/afformTest
[NFC] Afform - Test cleanup
Yashodha Chaku [Fri, 13 Oct 2023 04:29:18 +0000 (09:59 +0530)]
Merge pull request #27785 from eileenmcnaughton/tokens_more
Add event.self_cancel_xfer tokens
Seamus Lee [Fri, 13 Oct 2023 03:48:41 +0000 (14:48 +1100)]
Merge pull request #27801 from eileenmcnaughton/aclly
Add ContributionFormTrait
Seamus Lee [Fri, 13 Oct 2023 03:43:07 +0000 (14:43 +1100)]
[REF] Fix Smarty Notices on Dedupe Rules screen by setting weight
Eileen McNaughton [Fri, 13 Oct 2023 02:22:53 +0000 (15:22 +1300)]
Add ContributionFormTrait
Seamus Lee [Fri, 13 Oct 2023 03:10:14 +0000 (14:10 +1100)]
Merge pull request #27802 from colemanw/copyEdits
[NFC] Docblocks - Remove 'experimental' comments and other copy-edits
colemanw [Fri, 13 Oct 2023 02:42:56 +0000 (22:42 -0400)]
Afform - Test cleanup
colemanw [Fri, 13 Oct 2023 02:24:11 +0000 (22:24 -0400)]
Docblocks - Remove 'experimental' comments and other copy-edits
Seamus Lee [Fri, 13 Oct 2023 02:25:26 +0000 (13:25 +1100)]
Merge pull request #27799 from demeritcowboy/regen
regen after #27784
Eileen McNaughton [Fri, 13 Oct 2023 01:50:49 +0000 (14:50 +1300)]
Merge pull request #27795 from eileenmcnaughton/notice_main
Split shared function with mostly unshared code
Eileen McNaughton [Thu, 12 Oct 2023 22:23:17 +0000 (11:23 +1300)]
Remove now-always-true-param
Eileen McNaughton [Thu, 12 Oct 2023 22:14:51 +0000 (11:14 +1300)]
Move called functions with similar sharing issues into unshared code
Eileen McNaughton [Thu, 12 Oct 2023 21:11:14 +0000 (10:11 +1300)]
Split shared function with mostly unshared code
Almost all the code in this function is specific to the online form - we don't gain
much by sharing but it is harder to make changes because of
having to check the impact of each change on both forms.
Note both forms have test cover over this
demeritcowboy [Fri, 13 Oct 2023 00:48:49 +0000 (20:48 -0400)]
regen after #27784
demeritcowboy [Fri, 13 Oct 2023 00:40:06 +0000 (20:40 -0400)]
Merge pull request #27739 from eileenmcnaughton/no_assign
Add push upgrade for event offline receipt
colemanw [Thu, 12 Oct 2023 23:49:52 +0000 (19:49 -0400)]
Merge pull request #27792 from colemanw/userDashboard
Add user_dashboard core extension (alpha)
Eileen McNaughton [Thu, 12 Oct 2023 22:38:24 +0000 (11:38 +1300)]
Merge pull request #27796 from seamuslee001/fix_notice_survey_form
[REF] Fix notice error on undefined array key perm
Seamus Lee [Thu, 12 Oct 2023 21:43:46 +0000 (08:43 +1100)]
[REF] Fix notice error on undefined array key perm
colemanw [Wed, 11 Oct 2023 23:23:44 +0000 (19:23 -0400)]
Add user_dashboard core extension (alpha)
Includes search displays to replace the user dashboard, minus the action links
Aidan Saunders [Thu, 12 Oct 2023 15:50:17 +0000 (16:50 +0100)]
Merge pull request #27793 from colemanw/emptyOptions
APIv4 - Prevent fatal errors when getOptions returns an empty array
colemanw [Thu, 12 Oct 2023 14:06:01 +0000 (10:06 -0400)]
APIv4 - Prevent fatal errors when getOptions returns an empty array
Tim Otten [Thu, 12 Oct 2023 03:53:39 +0000 (20:53 -0700)]
Merge pull request #27755 from colemanw/afformPlacement
Afform - Unify 'is_dashlet', 'is_token' & 'contact_summary' as 'placement'
Eileen McNaughton [Wed, 11 Oct 2023 22:46:29 +0000 (11:46 +1300)]
Merge pull request #27784 from midtsveen/patch-2
Update civicrm_state_province.tpl
Eileen McNaughton [Fri, 6 Oct 2023 22:01:34 +0000 (11:01 +1300)]
Add push upgrade for event offline receipt
This follows our historical practice of doing push receipts by
- adding the relevant receipt to the array of template in the upgrade
notification and
- (optionally) noting deprecated params on CRM_Utils_Token::getDeprecatedTokens
I didn't add lineItem to the deprecated array as it is pretty legit
to assign that within a foreach loop.
I also removed the assigns for the variables which are no longer relevant -
this can be followed up with more tidy up (some of which resolves php8.x issues)
Note that the template still uses
$billingName & $address - resolved in
https://github.com/civicrm/civicrm-core/pull/27692
$customGroup - resolved in https://github.com/civicrm/civicrm-core/pull/27596
(actually the variable remains but becomes non-leaky)
$credit_card_date,$credit_card_type (I propose moving to a paymet token)
$credit_card_expiry (I propose removing)
$event.confirm_text - addressed in https://github.com/civicrm/civicrm-core/pull/27162
Jon Goldberg [Wed, 11 Oct 2023 22:21:15 +0000 (18:21 -0400)]
allow email attachments with unicode
Eileen McNaughton [Wed, 11 Oct 2023 22:06:43 +0000 (11:06 +1300)]
Merge pull request #27790 from civicrm/5.67
5.67 to master
Eileen McNaughton [Wed, 11 Oct 2023 22:05:45 +0000 (11:05 +1300)]
Merge pull request #27788 from eileenmcnaughton/567_prem
Add weights to premium screen
pmarg | Erik Midtsveen [Wed, 11 Oct 2023 21:42:35 +0000 (21:42 +0000)]
Update civicrm_state_province.tpl
,
Eileen McNaughton [Wed, 11 Oct 2023 21:11:05 +0000 (10:11 +1300)]
Merge pull request #27786 from eileenmcnaughton/api_func
Tag `getSubmittedValue()` as externally supported
Eileen McNaughton [Wed, 11 Oct 2023 21:05:17 +0000 (10:05 +1300)]
Add weights to premium screen