Eileen McNaughton [Fri, 15 Sep 2023 06:56:27 +0000 (18:56 +1200)]
Superficial cleanup on Event Confirm
str_starts_with is in our polyfill as @colemanw pointed out
colemanw [Fri, 15 Sep 2023 05:31:34 +0000 (01:31 -0400)]
Merge pull request #27438 from eileenmcnaughton/assign
Fix some variables to always assign
colemanw [Fri, 15 Sep 2023 05:24:03 +0000 (01:24 -0400)]
Merge pull request #27437 from eileenmcnaughton/no_1028
Remove references to invalid action
colemanw [Fri, 15 Sep 2023 05:07:54 +0000 (01:07 -0400)]
Merge pull request #27439 from eileenmcnaughton/captca
Remove broken recaptcha from profile preview
colemanw [Fri, 15 Sep 2023 04:52:59 +0000 (00:52 -0400)]
Merge pull request #27441 from eileenmcnaughton/test_set
Remove isset from template within unit tests
Eileen McNaughton [Fri, 15 Sep 2023 03:48:17 +0000 (15:48 +1200)]
Remove isset from template within unit tests
Eileen McNaughton [Fri, 15 Sep 2023 03:40:16 +0000 (15:40 +1200)]
Merge pull request #27440 from civicrm/5.66
5.66 to master
Eileen McNaughton [Fri, 15 Sep 2023 03:29:00 +0000 (15:29 +1200)]
Remove broken recaptcha from profile preview
The reCaptcha variable is never assigned to profile preview - resulting
in it never rendering (but rendering notices). This code has been broken
for a while without someone noticing - remove
Eileen McNaughton [Fri, 15 Sep 2023 03:25:52 +0000 (15:25 +1200)]
Merge pull request #27436 from eileenmcnaughton/dep
Add deprecation notice to code that seems to be superceded
Eileen McNaughton [Fri, 15 Sep 2023 03:24:49 +0000 (15:24 +1200)]
Fix some variables to always assign
Eileen McNaughton [Fri, 15 Sep 2023 03:05:24 +0000 (15:05 +1200)]
Remove outdated code comment
Eileen McNaughton [Fri, 15 Sep 2023 03:01:56 +0000 (15:01 +1200)]
Remove references to invalid action
All these references refer to comparing action to 1028. The comments make is clear that
they are looking for 'preview' mode - but preview mode is 1024. The checks are all
does-not-equal. So, they would have always been true for a very long time.
Copy & paste is dead long live copy & paste
colemanw [Fri, 15 Sep 2023 02:46:05 +0000 (22:46 -0400)]
Merge pull request #27432 from eileenmcnaughton/profile_weight
Add weights on profile links (remove notices)
Eileen McNaughton [Fri, 15 Sep 2023 02:37:54 +0000 (14:37 +1200)]
Add deprecation notice to code that seems to be superceded
colemanw [Fri, 15 Sep 2023 02:21:38 +0000 (22:21 -0400)]
Merge pull request #26042 from seamuslee001/ref_html_entities
[REF][PHP8.2] Fix deprecated usage of mb_convert_encoding with HTML-E…
Eileen McNaughton [Fri, 15 Sep 2023 01:56:13 +0000 (13:56 +1200)]
Add weights on profile links (remove notices)
Eileen McNaughton [Fri, 15 Sep 2023 00:48:57 +0000 (12:48 +1200)]
Merge pull request #27427 from eileenmcnaughton/notice_it
Fix another EventInfo notice
Eileen McNaughton [Fri, 15 Sep 2023 00:01:13 +0000 (12:01 +1200)]
Fix EmailMode
Eileen McNaughton [Thu, 14 Sep 2023 23:59:40 +0000 (11:59 +1200)]
Fix customData Include notice
Eileen McNaughton [Thu, 14 Sep 2023 23:42:32 +0000 (11:42 +1200)]
Add getEventID() - this is part of an effort to ensure consistency
All event & participant forms should have public api functions for
getParticipantID() and getEventID() (participant ID
not so relevant here
Eileen McNaughton [Thu, 14 Sep 2023 23:43:26 +0000 (11:43 +1200)]
Merge pull request #27426 from eileenmcnaughton/pcp
Fix php notices in php dashboard code
Eileen McNaughton [Thu, 14 Sep 2023 23:37:05 +0000 (11:37 +1200)]
Remove unused variable
Seamus Lee [Mon, 10 Apr 2023 02:41:24 +0000 (12:41 +1000)]
[REF][PHP8.2] Fix deprecated usage of mb_convert_encoding with HTML-Entities
Eileen McNaughton [Thu, 14 Sep 2023 23:32:48 +0000 (11:32 +1200)]
Fix another EventInfo notice
Eileen McNaughton [Thu, 14 Sep 2023 23:15:39 +0000 (11:15 +1200)]
Merge pull request #27423 from eileenmcnaughton/notice_it
Fix notice on phone_ext
Eileen McNaughton [Thu, 14 Sep 2023 23:12:57 +0000 (11:12 +1200)]
Fix php notices in php dashboard code
Eileen McNaughton [Thu, 14 Sep 2023 21:52:06 +0000 (09:52 +1200)]
Fix notice on phone_ext
Kurund Jalmi [Thu, 14 Sep 2023 16:16:00 +0000 (17:16 +0100)]
Merge pull request #27294 from colemanw/afformDataType
Afform - Fix getting and setting boolean/numeric types
Yashodha Chaku [Thu, 14 Sep 2023 06:55:21 +0000 (12:25 +0530)]
Merge pull request #27366 from eileenmcnaughton/CRM
Remove always true if for required role_id field, add test for value
Seamus Lee [Thu, 14 Sep 2023 00:55:30 +0000 (10:55 +1000)]
Merge pull request #27421 from demeritcowboy/desc
Revert just merged 27412
demeritcowboy [Thu, 14 Sep 2023 00:37:11 +0000 (20:37 -0400)]
Revert "Fix notice on Membership Component Settings page"
This reverts commit
e3f43b1ab5af0d3cf1063ee45805b3c6b66b6c4c.
Seamus Lee [Thu, 14 Sep 2023 00:09:50 +0000 (10:09 +1000)]
Merge pull request #27412 from eileenmcnaughton/admin_notice
Fix notice on Membership Component Settings page
demeritcowboy [Wed, 13 Sep 2023 21:02:25 +0000 (17:02 -0400)]
Merge pull request #27419 from eileenmcnaughton/no_push
Remove legacy error handling
demeritcowboy [Wed, 13 Sep 2023 21:01:44 +0000 (17:01 -0400)]
Merge pull request #27420 from larssandergreen/follow-up-to-add-comment-on-custom-field-move
(NFC) Add comment for IS NOT NULL in moving custom fields
colemanw [Wed, 13 Sep 2023 20:57:54 +0000 (16:57 -0400)]
Merge pull request #27418 from demeritcowboy/reg
regen
larssandergreen [Wed, 13 Sep 2023 20:23:42 +0000 (14:23 -0600)]
Add comment for IS NOT NULL in moving custom fields
Eileen McNaughton [Wed, 13 Sep 2023 19:43:27 +0000 (07:43 +1200)]
Remove legacy error handling
Our practice now is to throw exceptions - this results in a hard
fatal within apiv4 usage
demeritcowboy [Wed, 13 Sep 2023 19:38:40 +0000 (15:38 -0400)]
Merge pull request #27413 from larssandergreen/Don't-copy-nulls-when-moving-custom-fields
dev/core#4568 Don't copy nulls when moving custom fields
demeritcowboy [Wed, 13 Sep 2023 19:24:52 +0000 (15:24 -0400)]
regen
demeritcowboy [Wed, 13 Sep 2023 19:15:06 +0000 (15:15 -0400)]
Merge pull request #27400 from eileenmcnaughton/legacy
dev/core#4112 stop installing legacycustomsearches on new installs
demeritcowboy [Wed, 13 Sep 2023 19:04:49 +0000 (15:04 -0400)]
Merge pull request #27416 from larssandergreen/Weights-for-custom-field-sets-page
Weights for custom field groups page
larssandergreen [Wed, 13 Sep 2023 16:43:39 +0000 (10:43 -0600)]
Weights for custom field groups page
colemanw [Wed, 13 Sep 2023 16:02:35 +0000 (12:02 -0400)]
Merge pull request #27415 from PrzemyslawTabor/india-provinces
India-provinces update outdated provinces abbreviations
colemanw [Wed, 13 Sep 2023 14:44:53 +0000 (10:44 -0400)]
Merge pull request #27411 from colemanw/civiGrantCleanup
CiviGrant - Cleanup and simplify grant form, remove unused tab code
ptabor [Wed, 13 Sep 2023 14:43:02 +0000 (16:43 +0200)]
India-provinces update outdated provinces abbreviations
colemanw [Wed, 13 Sep 2023 14:21:07 +0000 (10:21 -0400)]
Merge pull request #27414 from pradpnayak/entitybatch
Add Entity batch to Search kit
Pradeep Nayak [Wed, 13 Sep 2023 13:10:11 +0000 (14:10 +0100)]
Add Entity batch to Search kit
larssandergreen [Wed, 13 Sep 2023 04:41:30 +0000 (22:41 -0600)]
Don't copy nulls when moving custom fields
Eileen McNaughton [Wed, 13 Sep 2023 03:18:57 +0000 (15:18 +1200)]
Merge pull request #27408 from eileenmcnaughton/type_bounce
Fix mistake in just-merged email processor code
Eileen McNaughton [Wed, 13 Sep 2023 02:51:14 +0000 (14:51 +1200)]
Fix notice on Membership Component Settings page
colemanw [Wed, 13 Sep 2023 01:24:32 +0000 (21:24 -0400)]
CiviGrant - Cleanup and simplify grant form, remove unused tab code
Deletes unused code for the contact summary tab (now handled by SearchKit).
Simplifies overcomplicated form context and detangles form embedded in page.
colemanw [Wed, 13 Sep 2023 01:22:55 +0000 (21:22 -0400)]
CiviGrant - Add missing note_used_for metadata
Eileen McNaughton [Wed, 13 Sep 2023 00:22:07 +0000 (12:22 +1200)]
Fix mistake in just-merged email processor code
BounceString was compiled in order to be used.... but it got rebased out
colemanw [Tue, 12 Sep 2023 22:32:18 +0000 (18:32 -0400)]
Merge pull request #27404 from totten/5.66-snapshot-mariadb
Upgrader - Skip snapshots on some MariaDB env's (roughly: 10.6.0-10.6.5)
Eileen McNaughton [Tue, 12 Sep 2023 19:13:49 +0000 (07:13 +1200)]
Merge pull request #27406 from larssandergreen/Fix-MoveField-PHP-error
Fix MoveField PHP notice
colemanw [Tue, 12 Sep 2023 18:41:33 +0000 (14:41 -0400)]
Merge pull request #27396 from colemanw/addNoteNote
Metadata - Add "civicrm_note" to "note_used_for" option group
larssandergreen [Tue, 12 Sep 2023 17:28:01 +0000 (11:28 -0600)]
Fix MoveField PHP error
colemanw [Tue, 12 Sep 2023 16:30:01 +0000 (12:30 -0400)]
DAO - Prevent recursion adding acl clause to entity that references itself
colemanw [Tue, 12 Sep 2023 01:45:41 +0000 (21:45 -0400)]
Metadata - Add "civicrm_note" to "note_used_for" option group
colemanw [Tue, 12 Sep 2023 14:45:30 +0000 (10:45 -0400)]
Merge pull request #27389 from colemanw/coreManaged
Scan core `civicrm/managed` directory for entity declarations
colemanw [Tue, 12 Sep 2023 14:45:06 +0000 (10:45 -0400)]
Merge pull request #27402 from eileenmcnaughton/pledge_pay
Smarty notices - Fix a couple more templates to look for elements not a variable that says the element is present
colemanw [Tue, 12 Sep 2023 14:30:55 +0000 (10:30 -0400)]
Merge pull request #27403 from eileenmcnaughton/php8
dev/core#4421 Fix some attempts to count NULL (php8.x)
colemanw [Sun, 10 Sep 2023 22:51:58 +0000 (18:51 -0400)]
Scan core `civicrm/managed` directory for entity declarations
Switch to a more complete module option list using CRM_Core_Module::getAll()
colemanw [Tue, 12 Sep 2023 14:04:45 +0000 (10:04 -0400)]
Merge pull request #27392 from totten/master-module-label
CRM_Core_Module - Generate optional `$label` property
Tim Otten [Tue, 12 Sep 2023 07:43:31 +0000 (00:43 -0700)]
Upgrader - Skip snapshots on some MariaDB env's (roughly: 10.6.0-10.6.5)
Eileen McNaughton [Tue, 12 Sep 2023 05:29:00 +0000 (17:29 +1200)]
dev/core#4421 Fix some attempts to count NULL (php8.x)
Tim Otten [Tue, 12 Sep 2023 00:22:21 +0000 (17:22 -0700)]
Generate `$label`s for modules in `Drupal8` (D8/9/10)
Tim Otten [Tue, 12 Sep 2023 00:09:17 +0000 (17:09 -0700)]
Generate `$label`s for modules in `DrupalBase` (D7/Backdrop)
Eileen McNaughton [Tue, 12 Sep 2023 03:43:15 +0000 (15:43 +1200)]
Fix a couple more templates to look for elements not a variable that says the element is present
Eileen McNaughton [Tue, 12 Sep 2023 03:16:21 +0000 (15:16 +1200)]
Merge pull request #27401 from civicrm/5.66
5.66 to master
Eileen McNaughton [Tue, 12 Sep 2023 03:15:37 +0000 (15:15 +1200)]
Merge pull request #27399 from colemanw/fixContactJoin
APIv4: Implicit joins for email_primary, etc cause error
Eileen McNaughton [Tue, 12 Sep 2023 03:12:20 +0000 (15:12 +1200)]
Merge pull request #27398 from eileenmcnaughton/noticey
Add test cover for handling of returnPath
Eileen McNaughton [Tue, 12 Sep 2023 03:09:12 +0000 (15:09 +1200)]
dev/core#4112 stop installing legacycustomsearches on new installs
Tim Otten [Tue, 12 Sep 2023 00:08:41 +0000 (17:08 -0700)]
Generate $label for module-extensions
Tim Otten [Tue, 12 Sep 2023 00:08:22 +0000 (17:08 -0700)]
CRM_Core_Module - Add optional $label property
Eileen McNaughton [Tue, 12 Sep 2023 02:46:10 +0000 (14:46 +1200)]
Merge pull request #27379 from colemanw/fileApi
Api4 - Enable file attachments to be displayed in SearchKit
Eileen McNaughton [Tue, 12 Sep 2023 02:29:00 +0000 (14:29 +1200)]
Add test cover for handling of returnPath
colemanw [Tue, 12 Sep 2023 02:32:06 +0000 (22:32 -0400)]
Fix dev/core#4562 - APIv4: Implicit joins for email_primary, etc cause error
colemanw [Tue, 12 Sep 2023 02:25:51 +0000 (22:25 -0400)]
Merge pull request #27241 from eileenmcnaughton/type_2
php 8.x Use internal property rather than undefined _type
Eileen McNaughton [Tue, 12 Sep 2023 02:15:03 +0000 (14:15 +1200)]
Merge pull request #27397 from civicrm/5.66
5.66 to master
Eileen McNaughton [Tue, 12 Sep 2023 02:14:53 +0000 (14:14 +1200)]
Merge pull request #27395 from eileenmcnaughton/weight
Fix weight notices on ActivityType (option values) pages
Eileen McNaughton [Tue, 12 Sep 2023 02:12:40 +0000 (14:12 +1200)]
Merge pull request #27394 from eileenmcnaughton/zet
Revert "[REF] Update Zetacomponents/mail to be 1.9.5 to fix email validation handling"
colemanw [Mon, 11 Sep 2023 23:17:40 +0000 (19:17 -0400)]
APIv4 - Giving up on fine-grained File ACLs for now
colemanw [Mon, 11 Sep 2023 20:58:51 +0000 (16:58 -0400)]
APIv4 - Fix rendering GROUP_CONTACT(UNIQUE) with field suffix
colemanw [Mon, 11 Sep 2023 19:52:14 +0000 (15:52 -0400)]
SearchKit - Support aggregated styles in links
colemanw [Mon, 11 Sep 2023 19:04:56 +0000 (15:04 -0400)]
SearchKit - Support aggregated icon fields
colemanw [Sun, 10 Sep 2023 22:39:31 +0000 (18:39 -0400)]
APIv4 - Support output_formatters with aggregated columns
colemanw [Sun, 10 Sep 2023 17:57:12 +0000 (13:57 -0400)]
APIv4 - Enforce ACLs for File entity, dedupe ACL clauses for bridge entities
colemanw [Fri, 8 Sep 2023 19:11:43 +0000 (15:11 -0400)]
APIv4 - Improve performance with explicit join ACL query deduping
colemanw [Thu, 7 Sep 2023 17:32:04 +0000 (13:32 -0400)]
Api4 - Enable file attachments to be displayed in SearchKit
colemanw [Wed, 6 Sep 2023 18:31:12 +0000 (14:31 -0400)]
File - Update completely wrong docblock.
Before: Function does the opposite of what the docblock says it does with .unknown suffixes.
After: Docblock accurately says what the function does.
Eileen McNaughton [Tue, 12 Sep 2023 01:45:35 +0000 (13:45 +1200)]
Fix weight notices on ActivityType (option values) pages
Eileen McNaughton [Tue, 12 Sep 2023 01:39:44 +0000 (13:39 +1200)]
Merge pull request #27393 from colemanw/conformanceTestFix
APIv4 - Fix conformance test for entities with multiple primary keys
colemanw [Tue, 12 Sep 2023 01:16:37 +0000 (21:16 -0400)]
Merge pull request #27356 from eileenmcnaughton/body
dev/core#2800 Fix bounce processing to handle verp emails
Eileen McNaughton [Tue, 12 Sep 2023 01:10:28 +0000 (13:10 +1200)]
Revert "[REF] Update Zetacomponents/mail to be 1.9.5 to fix email validation handling"
This reverts commit
020a1178ac869e64691c4e5fd49ee09f01d8f194.
colemanw [Tue, 12 Sep 2023 01:04:30 +0000 (21:04 -0400)]
APIv4 - Fix conformance test for entities with multiple primary keys
demeritcowboy [Tue, 12 Sep 2023 00:28:43 +0000 (20:28 -0400)]
Merge pull request #27385 from mlutfy/versionCheckSid
VersionCheck: replace hash by sid, add the environment
colemanw [Mon, 11 Sep 2023 23:58:50 +0000 (19:58 -0400)]
Afform - Fix js error when setting default value for the first time
colemanw [Mon, 4 Sep 2023 20:12:44 +0000 (16:12 -0400)]
Afform - Fix getting and setting boolean/numeric types
Fixes dev/core#4465
Replaces https://github.com/civicrm/civicrm-core/pull/27006
Eileen McNaughton [Mon, 11 Sep 2023 22:13:10 +0000 (10:13 +1200)]
Add detail about bounce to activity
Note adding fetch_activities to the test exposed a mysql error so I had
to add handling there