Tim Otten [Fri, 10 Feb 2023 06:18:49 +0000 (22:18 -0800)]
Disambiguate `Address.state_province_id:abbr` (PHP asort)
Consider `ContactJoinTest::testCreateWithPrimaryAndBilling` which writes the value:
'address_billing.state_province_id:abbr' => 'AK',
The symbol 'AK' can map to three places: Akwa Ibom (Nigeria), Atakora
(Benin), and Alaska (USA). This is an ambiguous choice. It should be
resolved in a consistent way.
One flavor of ambiguity comes from PHP. After fetching from MySQL, there is
a secondary sorting (via `CRM_Utils_Array::asort()` => `asort()`). Per
https://www.php.net/asort, the outcome is quirky:
> If two members compare as equal, they retain their original order. Prior
> to PHP 8.0.0, their relative order in the sorted array was undefined.
On PHP 7, you cannot resolve this with any of the standard sort methods
(`asort`, `usort`, `ksort`, etc). They all have the same issue.
However... the docs for `\Collator::asort()` indicate no such issue.
Switching to `\Collator::asort()` causes the tests to pass on PHP 7.3. And
we already use `\Collator::asort()`.
Yashodha Chaku [Fri, 10 Feb 2023 03:07:52 +0000 (08:37 +0530)]
Merge pull request #25519 from eileenmcnaughton/gettree2
Remove always-NULL `$singleRecord` variable
Eileen McNaughton [Fri, 10 Feb 2023 02:51:07 +0000 (15:51 +1300)]
Merge pull request #25546 from eileenmcnaughton/smarty_pledge
Enotice fix, pledge block on UserDashboard
Eileen McNaughton [Fri, 10 Feb 2023 00:17:51 +0000 (13:17 +1300)]
Enotice fix, pledge block on UserDashboard
Eileen McNaughton [Thu, 9 Feb 2023 23:59:12 +0000 (12:59 +1300)]
Merge pull request #25521 from colemanw/actionsMenu
SearchKit - Configurable action menu tasks per-search-display
Yashodha Chaku [Thu, 9 Feb 2023 11:16:53 +0000 (16:46 +0530)]
Merge pull request #25541 from eileenmcnaughton/null_obj
Do not use reference for Object parameter, death to `_NULLObject`
Eileen McNaughton [Thu, 9 Feb 2023 07:22:13 +0000 (20:22 +1300)]
Fix notice, do not pass values that match defaults
Eileen McNaughton [Thu, 9 Feb 2023 05:53:48 +0000 (18:53 +1300)]
Merge pull request #25540 from eileenmcnaughton/world
Remove invalid 'world_region' => 'India' from test
Eileen McNaughton [Thu, 9 Feb 2023 05:02:14 +0000 (18:02 +1300)]
Do not use reference for Object parameter, deathto _NULlObject
Eileen McNaughton [Thu, 9 Feb 2023 04:51:37 +0000 (17:51 +1300)]
Remove invalid 'world_region' => 'India' from test
Coleman Watts [Tue, 7 Feb 2023 23:24:57 +0000 (18:24 -0500)]
SearchKit - Configurable action menu tasks per-search-display
Seamus Lee [Thu, 9 Feb 2023 01:49:10 +0000 (12:49 +1100)]
Merge pull request #25537 from eileenmcnaughton/database
Fix a couple more places to use mysql DATABASE() function
Seamus Lee [Thu, 9 Feb 2023 01:48:48 +0000 (12:48 +1100)]
Merge pull request #25538 from civicrm/5.59
5.59
colemanw [Thu, 9 Feb 2023 01:19:21 +0000 (20:19 -0500)]
Merge pull request #25539 from demeritcowboy/query
Typo executequery => executeQuery
demeritcowboy [Thu, 9 Feb 2023 00:44:16 +0000 (19:44 -0500)]
typo
demeritcowboy [Thu, 9 Feb 2023 00:41:35 +0000 (19:41 -0500)]
Merge pull request #25534 from totten/5.59-test-tz
CiviTestListener - Headless tests should initialize timezone
demeritcowboy [Thu, 9 Feb 2023 00:37:59 +0000 (19:37 -0500)]
Merge pull request #25524 from eileenmcnaughton/finder_test
NFC cleanup in test class
Eileen McNaughton [Wed, 8 Feb 2023 22:59:12 +0000 (11:59 +1300)]
Fix a couple more places to use mysql DATABASE() function
Tim Otten [Wed, 8 Feb 2023 22:47:51 +0000 (14:47 -0800)]
CiviTestListener - Headless tests should have initialized timezone
Before
------
* `CiviUnitTestCase` calls `setMySQLTimeZone()`
* Headless tests (which are initialized via `CiviTestListener`) do not call `setMySQLTimeZone()`
* If you have a test like 5.57's flavor of `QueueTest`, then the tests pass or fail depending on happenstance of server timezone configuration.
After
-----
* `CiviUnitTestCase` and `CiviTestListener` both call `setMySQLTimeZone()`
* If you have a test like 5.57's flavor of `QueueTest`, then the tests pass more consistently.
Comments
--------
This branch should work cleanly as PR for `5.59` (rc) or `master`. I'd
rather like to use this in `5.57-esr` (so that tests run more cleanly).
So maybe `5.59` is the better target (but it doesn't strictly have to be).
Seamus Lee [Wed, 8 Feb 2023 22:47:03 +0000 (09:47 +1100)]
Merge pull request #25530 from eileenmcnaughton/database
Use mysql DATABASE() function instead of php code
Eileen McNaughton [Wed, 8 Feb 2023 02:16:36 +0000 (15:16 +1300)]
NFC cleanup in test class
Eileen McNaughton [Wed, 8 Feb 2023 22:12:05 +0000 (11:12 +1300)]
Merge pull request #25531 from civicrm/5.59
5.59
Eileen McNaughton [Wed, 8 Feb 2023 20:01:10 +0000 (09:01 +1300)]
Use mysql DATABASE() function instead of php code
Yashodha Chaku [Wed, 8 Feb 2023 13:48:13 +0000 (19:18 +0530)]
Merge pull request #25528 from eileenmcnaughton/database
Use `DATABASE()` function rather than lossa code
Yashodha Chaku [Wed, 8 Feb 2023 11:13:40 +0000 (16:43 +0530)]
Merge pull request #25525 from seamuslee001/group_filter_acl
dev/core#4068 Prevent adding in addSelectWhereClause for civicrm_group when filtering by a group as unneded for reports
Seamus Lee [Wed, 8 Feb 2023 03:26:56 +0000 (14:26 +1100)]
dev/core#4068 Expand test coverage to include the contact summary report which is a non optimised report template
Seamus Lee [Wed, 8 Feb 2023 02:40:19 +0000 (13:40 +1100)]
dev/core#4068 Prevent adding in addSelectWhereClause for civicrm_group when filtering by a group as unneded for reports
Add in failing test to demonstrate issue with Group add SelectWhereClause on reports
Yashodha Chaku [Wed, 8 Feb 2023 05:48:18 +0000 (11:18 +0530)]
Merge pull request #24861 from eileenmcnaughton/dash
Enotice fix on userDashboard with contributions, replace deprecated functions with api4v calls
Eileen McNaughton [Wed, 8 Feb 2023 05:00:38 +0000 (18:00 +1300)]
Use DATABASE function rather than lossa code
Seamus Lee [Wed, 8 Feb 2023 04:45:25 +0000 (15:45 +1100)]
Merge pull request #25526 from civicrm/5.59
5.59
demeritcowboy [Wed, 8 Feb 2023 03:33:48 +0000 (22:33 -0500)]
Merge pull request #25523 from demeritcowboy/dompdf-559
Backport 25520
dependabot[bot] [Tue, 7 Feb 2023 23:51:27 +0000 (23:51 +0000)]
Bump dompdf/dompdf from 2.0.2 to 2.0.3
Dependabot couldn't find the original pull request head commit,
889dfb1c9efc4cba2f79ab4088c30fe6774c0835.
Eileen McNaughton [Wed, 8 Feb 2023 01:38:04 +0000 (14:38 +1300)]
Merge pull request #25520 from civicrm/dependabot/composer/dompdf/dompdf-2.0.3
Bump dompdf/dompdf from 2.0.2 to 2.0.3
demeritcowboy [Wed, 8 Feb 2023 00:09:57 +0000 (19:09 -0500)]
Merge pull request #25510 from eileenmcnaughton/dep_token5
Add noisy deprecation to `replaceHookTokens`
dependabot[bot] [Tue, 7 Feb 2023 23:51:27 +0000 (23:51 +0000)]
Bump dompdf/dompdf from 2.0.2 to 2.0.3
Dependabot couldn't find the original pull request head commit,
889dfb1c9efc4cba2f79ab4088c30fe6774c0835.
colemanw [Tue, 7 Feb 2023 23:16:08 +0000 (18:16 -0500)]
Merge pull request #25516 from eileenmcnaughton/expires
dev/core#4117 Add is_current to UserJob, Search
Eileen McNaughton [Sun, 30 Oct 2022 23:00:39 +0000 (12:00 +1300)]
Cleanup notices on contribution.userDashboard, switch to apiv4
Escape option-possible values
Adjust test for change in order
Yashodha Chaku [Tue, 7 Feb 2023 05:36:20 +0000 (11:06 +0530)]
Merge pull request #25518 from eileenmcnaughton/gettree1
Remove never-true IF
Eileen McNaughton [Tue, 7 Feb 2023 01:46:54 +0000 (14:46 +1300)]
Remove always-NULL singleRecord
Eileen McNaughton [Tue, 7 Feb 2023 01:42:35 +0000 (14:42 +1300)]
Remove never-true IF
Per https://github.com/civicrm/civicrm-core/pull/25517 is
always FALSE so this IF is never true
colemanw [Tue, 7 Feb 2023 01:12:14 +0000 (20:12 -0500)]
Merge pull request #25395 from eileenmcnaughton/cust_process
Remove interaction with complex legacy `getTree` function
Eileen McNaughton [Tue, 7 Feb 2023 00:20:24 +0000 (13:20 +1300)]
Merge pull request #25515 from jmcclelland/limit-dedupe-rules-on-import
only load dedupe rules for the chosen entity
Eileen McNaughton [Tue, 7 Feb 2023 00:08:32 +0000 (13:08 +1300)]
dev/core#4117 Add is_current to UserJob, Search
colemanw [Tue, 7 Feb 2023 00:08:48 +0000 (19:08 -0500)]
Merge pull request #25195 from eileenmcnaughton/build_divide_event
Post divide code tidy up
Jamie McClelland [Mon, 6 Feb 2023 22:02:25 +0000 (17:02 -0500)]
only load dedupe rules for the chosen entity
I'm not sure how long this has been broken??
CRM_Dedupe_BAO_DedupeRuleGroup::getByType() clearly takes a string
and will never get one without this change.
Eileen McNaughton [Fri, 20 Jan 2023 01:16:14 +0000 (14:16 +1300)]
Remove interaction with complex legacy getTree function
Eileen McNaughton [Mon, 6 Feb 2023 20:11:09 +0000 (09:11 +1300)]
Merge pull request #25328 from herbdool/core-4028
(dev/core#4028) make CRM_Admin_Form_Setting_UF more CMS agnostic
Seamus Lee [Mon, 6 Feb 2023 20:01:41 +0000 (07:01 +1100)]
Merge pull request #25507 from eileenmcnaughton/token_dep3
Fully deprecate `CRM_Utils_Token::getMembershipTokenDetails`, `CRM_Utils_Token::replaceEntityTokens`
Matthew Wire [Mon, 6 Feb 2023 19:14:08 +0000 (19:14 +0000)]
Merge pull request #25512 from colemanw/ppAjax
PaymentProcessor - Use ajax refresh
Herb v/d Dool [Wed, 11 Jan 2023 20:09:35 +0000 (15:09 -0500)]
dev/core#4028 make CRM_Admin_Form_Setting_UF more CMS agnostic
Coleman Watts [Mon, 6 Feb 2023 17:02:09 +0000 (12:02 -0500)]
PaymentProcessor - Use ajax refresh
Yashodha Chaku [Mon, 6 Feb 2023 10:18:52 +0000 (15:48 +0530)]
Merge pull request #25509 from eileenmcnaughton/token_dep4
Fully deprecate `CRM_Core_SelectValues::eventTokens()`
Eileen McNaughton [Mon, 6 Feb 2023 07:08:30 +0000 (20:08 +1300)]
Fully deprecate getMembershipTokenDetails
Eileen McNaughton [Mon, 6 Feb 2023 09:50:33 +0000 (22:50 +1300)]
Merge pull request #25503 from eileenmcnaughton/basic_test
Add extra test, comment how it could be used to fix bug
Eileen McNaughton [Mon, 6 Feb 2023 09:01:09 +0000 (22:01 +1300)]
Merge pull request #25508 from eileenmcnaughton/token_unused
Remove unused variable
Eileen McNaughton [Mon, 6 Feb 2023 08:54:14 +0000 (21:54 +1300)]
Merge pull request #25506 from eileenmcnaughton/token_dep2
Fully deprecate `CRM_Core_SelectValues::membershipTokens()`
Eileen McNaughton [Mon, 6 Feb 2023 08:33:03 +0000 (21:33 +1300)]
Merge pull request #25505 from eileenmcnaughton/token_dep
Fully deprecate legacy contributionTokens
Eileen McNaughton [Mon, 6 Feb 2023 08:22:48 +0000 (21:22 +1300)]
Merge pull request #24971 from lemniscus/abstractsaveaction-match-on-null
API4: Allow save() to match on null values
Eileen McNaughton [Mon, 6 Feb 2023 03:49:26 +0000 (16:49 +1300)]
Add extra test, comment how it could be used to fix bug
I was working on fixing the ongoing log noise in the tested scenario - but
the first PR https://github.com/civicrm/civicrm-core/pull/25392 is still
pending so I decided just to put up the test with the sign posts
so at least that part is done for the next time someone tries
(I know that people have tried in the past)
Eileen McNaughton [Mon, 6 Feb 2023 07:52:00 +0000 (20:52 +1300)]
Add noisy deprecation to ReplaceHookTokens
This was code-comment deprecated around 15 months ago and
some extensions have updated to stop calling it so
it seems OK to make the deprecation a bit noisier now since
the TokenProcessor has been settled & stable for some time now
Eileen McNaughton [Mon, 6 Feb 2023 07:17:14 +0000 (20:17 +1300)]
Fully deprecate CRM_Core_SelectValues::eventTokens()
Eileen McNaughton [Mon, 6 Feb 2023 07:14:34 +0000 (20:14 +1300)]
Remove unused variable
Eileen McNaughton [Mon, 6 Feb 2023 07:05:48 +0000 (20:05 +1300)]
Fully deprecate CRM_Core_SelectValues::membershipTokens()
Eileen McNaughton [Mon, 6 Feb 2023 06:50:15 +0000 (19:50 +1300)]
Fully deprecate legacy contributionTokens
Eileen McNaughton [Mon, 6 Feb 2023 06:47:19 +0000 (19:47 +1300)]
Merge pull request #25052 from eileenmcnaughton/fix_list
Fix Scheduled reminders form to use tokenProcessor to get token list
Seamus Lee [Mon, 6 Feb 2023 04:14:05 +0000 (15:14 +1100)]
Merge pull request #25063 from eileenmcnaughton/local
Default to supporting partial locales
Eileen McNaughton [Fri, 16 Dec 2022 23:23:57 +0000 (12:23 +1300)]
Post divide code tidy up
Per https://github.com/civicrm/civicrm-core/pull/25194
But the other function split out from
https://github.com/civicrm/civicrm-core/pull/25184
Eileen McNaughton [Wed, 30 Nov 2022 01:10:24 +0000 (14:10 +1300)]
Disable partial_locales in tests that are testing the legacy setting
Eileen McNaughton [Sun, 27 Nov 2022 20:37:48 +0000 (09:37 +1300)]
Default to supporting partial locales
Eileen McNaughton [Fri, 25 Nov 2022 04:20:47 +0000 (17:20 +1300)]
Fix Scheduled reminders form to use tokenProcessor to get token list
This is the last place outside of tests that calls some of these
functions so I will check in on them
Eileen McNaughton [Mon, 6 Feb 2023 02:03:26 +0000 (15:03 +1300)]
Merge pull request #25487 from yashodha/help_class
fix the id help instead use class help
Eileen McNaughton [Mon, 6 Feb 2023 01:40:55 +0000 (14:40 +1300)]
Merge pull request #25501 from braders/event-form-searchtest-properties
[REF][PHP8.2] Refactor properties on CRM_Event_Form_SearchTest
Eileen McNaughton [Sun, 5 Feb 2023 23:01:36 +0000 (12:01 +1300)]
Merge pull request #25502 from braders/sms-tests-dynamic-property
[REF][PHP8.2] Declare dynamic property in two SMS tests
Bradley Taylor [Sun, 5 Feb 2023 12:20:38 +0000 (12:20 +0000)]
[REF][PHP8.2] Declare dynamic property in two SMS tests
Bradley Taylor [Sat, 4 Feb 2023 18:01:39 +0000 (18:01 +0000)]
[REF][PHP8.2] Refactor properties on CRM_Event_Form_SearchTest
demeritcowboy [Thu, 2 Feb 2023 23:39:10 +0000 (18:39 -0500)]
Merge pull request #25499 from demeritcowboy/symfony-composer-json
dev/drupal#176 - allow symfony 6
demeritcowboy [Thu, 2 Feb 2023 23:37:29 +0000 (18:37 -0500)]
Merge pull request #25500 from braders/AdhocMailingTest-setup
(REF) Remove unused setup from AdhocMailingTest
demeritcowboy [Thu, 2 Feb 2023 17:02:33 +0000 (12:02 -0500)]
allow symfony 6
Bradley Taylor [Thu, 2 Feb 2023 20:37:39 +0000 (20:37 +0000)]
Remove unused setup from AdhocMailingTest
Seamus Lee [Thu, 2 Feb 2023 20:30:08 +0000 (07:30 +1100)]
Merge pull request #25054 from demeritcowboy/cacheintegration
dev/drupal#176 - Move cache/integrationtest only used for testing into require-dev
demeritcowboy [Thu, 2 Feb 2023 16:46:48 +0000 (11:46 -0500)]
not compatible with symfony 6 and not needed for a production site anyway
demeritcowboy [Thu, 2 Feb 2023 04:52:08 +0000 (23:52 -0500)]
Merge pull request #25498 from seamuslee001/5.59
[REF] Use Civi::statics in CRM_Utils_File instead of php static
Seamus Lee [Thu, 2 Feb 2023 01:41:08 +0000 (12:41 +1100)]
[REF] Use Civi::statics in CRM_Utils_File instead of php static
CiviCRM [Thu, 2 Feb 2023 01:40:54 +0000 (01:40 +0000)]
Set version to 5.60.alpha1
CiviCRM [Thu, 2 Feb 2023 01:40:41 +0000 (01:40 +0000)]
Set version to 5.59.beta1
Seamus Lee [Thu, 2 Feb 2023 01:14:16 +0000 (12:14 +1100)]
Merge branch '5.58'
Tim Otten [Thu, 2 Feb 2023 00:56:03 +0000 (16:56 -0800)]
Merge pull request #25497 from totten/5.58-bump0
5.58.0 - Set version. Last-minute notes.
Tim Otten [Thu, 2 Feb 2023 00:52:16 +0000 (16:52 -0800)]
Update 5.58.0.md
Tim Otten [Thu, 2 Feb 2023 00:53:01 +0000 (16:53 -0800)]
Set version to 5.58.0
Tim Otten [Thu, 2 Feb 2023 00:35:07 +0000 (16:35 -0800)]
Merge pull request #25490 from colemanw/dynamicCustom
Fix APIv4 autocompletes for dynamic entities
Tim Otten [Thu, 2 Feb 2023 00:32:17 +0000 (16:32 -0800)]
Merge pull request #25485 from colemanw/contributionAutocomplete
Fix dev/core#4104 - APIv4 autocomplete for contributions
Tim Otten [Thu, 2 Feb 2023 00:26:10 +0000 (16:26 -0800)]
Merge pull request #25367 from totten/5.58-check-tz
System Status - Add check to ensure that MySQL timezones are operational
Tim Otten [Thu, 2 Feb 2023 00:06:34 +0000 (16:06 -0800)]
Merge pull request #25494 from agh1/5.58.0-releasenotes-final
5.58.0 release notes final
Andie Hunt [Wed, 1 Feb 2023 23:01:50 +0000 (18:01 -0500)]
5.58.0 release notes: added late changes
Tim Otten [Tue, 31 Jan 2023 04:16:24 +0000 (20:16 -0800)]
Add release-notes/5.57.3.md
Tim Otten [Thu, 26 Jan 2023 06:09:56 +0000 (22:09 -0800)]
Add release-notes/5.57.2.md
Tim Otten [Thu, 26 Jan 2023 01:42:49 +0000 (17:42 -0800)]
Add release-notes/5.57.2.md
Tim Otten [Thu, 12 Jan 2023 06:21:12 +0000 (22:21 -0800)]
Add release-notes/5.57.1.md
Tim Otten [Wed, 4 Jan 2023 00:08:48 +0000 (16:08 -0800)]
Add release-notes/5.56.2.md
Tim Otten [Wed, 21 Dec 2022 03:45:22 +0000 (19:45 -0800)]
Add release-notes/5.56.1.md